Processed: Re: Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-17 Thread Debian Bug Tracking System 
Processing commands for cont...@bugs.debian.org:

> severity 967487 important
Bug #967487 [src:libubootenv] libubootenv: Cannot build libubootenv with 
dpkg-buildpackage
Severity set to 'important' from 'serious'
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
967487: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=967487
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-17 Thread Nobuhiro Iwamatsu 
severity 967487 important
thanks

Hi,

2020年8月17日(月) 17:15 Gylstorff Quirin :

>
>
>
> On 8/12/20 4:29 AM, Nobuhiro Iwamatsu wrote:
> > Hi,
> >
> > Thanks for your report.
> >
> > 2020年8月4日(火) 19:50 Gylstorff Quirin :
> >>
> >> Package: libubootenv-tool
> >> Version: 0.2-1
> >> Severity: serious
> >> Tags: patch ftbfs
> >> Justification: fails to build from source
> >>
> >> Dear Maintainer,
> >>
> >> I tried to  build libubootenv-tool with dpkg-buildpackage and the 
> >> following error
> >> did occur:
> >> ```
> >> -- Detecting C compile features - done
> >> CMake Error at src/CMakeLists.txt:29 (install):
> >>install TARGETS given no RUNTIME DESTINATION for executable target
> >>"fw_printenv".
> >>
> >>
> >> CMake Error at src/CMakeLists.txt:30 (install):
> >>install TARGETS given no RUNTIME DESTINATION for executable target
> >>"fw_setenv".
> >> ```
> >
> > Hmm, I checked this on unstable but didn't reproduce it.
> > I attached a build log.
> > Could you tell me the environment you have confirmed?
> >
>
> Sure, I tried to build it on stable(Debian 10.5) with  cmake version 3.13.4.
>
> Attached is the complete log.

This package is not provided in stable, so the bug severity will not
be set in serious. I change to important.
Could you check this patch in unstable environment as well?
If everything is okay, I will apply.

>
> Kind regards
> Quirin

Best regards,
  Nobuhiro


--
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-17 Thread Gylstorff Quirin 



On 8/12/20 4:29 AM, Nobuhiro Iwamatsu wrote:

Hi,

Thanks for your report.

2020年8月4日(火) 19:50 Gylstorff Quirin :


Package: libubootenv-tool
Version: 0.2-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source

Dear Maintainer,

I tried to  build libubootenv-tool with dpkg-buildpackage and the following 
error
did occur:
```
-- Detecting C compile features - done
CMake Error at src/CMakeLists.txt:29 (install):
   install TARGETS given no RUNTIME DESTINATION for executable target
   "fw_printenv".


CMake Error at src/CMakeLists.txt:30 (install):
   install TARGETS given no RUNTIME DESTINATION for executable target
   "fw_setenv".
```


Hmm, I checked this on unstable but didn't reproduce it.
I attached a build log.
Could you tell me the environment you have confirmed?



Sure, I tried to build it on stable(Debian 10.5) with  cmake version 3.13.4.

Attached is the complete log.

Kind regards
Quirin



I fix the build error by moving the
```
include("GNUInstallDirs")
```
from Subject: [PATCH 2/4] Add support GNUInstallDirs
before
```
  add_subdirectory (src)
```



I see.
Indeed, this will fix your issue.


Best regards,
Quirin


Best regards,
   Nobuhiro


-- System Information:
Debian Release: 10.5
   APT prefers stable
   APT policy: (800, 'stable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-10-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled






dpkg-buildpackage: info: source package libubootenv
dpkg-buildpackage: info: source version 0.2-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Nobuhiro Iwamatsu 

 dpkg-source -I --before-build .
dpkg-buildpackage: info: host architecture armhf
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: applying 
0001-Unifies-the-functionality-provided-by-CMake-to-lower.patch
dpkg-source: info: applying 0002-Add-support-GNUInstallDirs.patch
dpkg-source: info: applying 
0003-Change-name-of-the-output-static-library-to-libuboot.patch
dpkg-source: info: applying 0004-Add-the-static-library-for-installation.patch
 fakeroot debian/rules clean
dh clean
   dh_clean
 dpkg-source -I -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building libubootenv using existing 
./libubootenv_0.2.orig.tar.xz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: building libubootenv in libubootenv_0.2-1.debian.tar.xz
dpkg-source: info: building libubootenv in libubootenv_0.2-1.dsc
 debian/rules build
dh build
   dh_update_autotools_config
   dh_autoreconf
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/home/builder/libubootenv/git'
dh_auto_configure \
-- -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_C_FLAGS_RELEASE="-g -O2 
-fdebug-prefix-map=/home/builder/libubootenv/git=. -fstack-protector-strong 
-Wformat -Werror=format-security" 
-DCMAKE_EXE_LINKER_FLAGS_RELEASE="-Wl,-z,relro" -DBUILD_DOCS=ON 
-DCMAKE_INSTALL_INCLUDEDIR="include/arm-linux-gnueabihf" \
-DCMAKE_SHARED_LINKER_FLAGS_RELEASE="-Wl,-z,relro"
cd obj-arm-linux-gnueabihf && cmake -DCMAKE_INSTALL_PREFIX=/usr 
-DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc 
-DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON 
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_RUNSTATEDIR=/run 
"-GUnix Makefiles" -DCMAKE_VERBOSE_MAKEFILE=ON 
-DCMAKE_INSTALL_LIBDIR=lib/arm-linux-gnueabihf -DCMAKE_VERBOSE_MAKEFILE=ON 
"-DCMAKE_C_FLAGS_RELEASE=-g -O2 
-fdebug-prefix-map=/home/builder/libubootenv/git=. -fstack-protector-strong 
-Wformat -Werror=format-security" -DCMAKE_EXE_LINKER_FLAGS_RELEASE=-Wl,-z,relro 
-DBUILD_DOCS=ON -DCMAKE_INSTALL_INCLUDEDIR=include/arm-linux-gnueabihf 
-DCMAKE_SHARED_LINKER_FLAGS_RELEASE=-Wl,-z,relro ..
-- The C compiler identification is GNU 8.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at src/CMakeLists.txt:29 (install):
  install TARGETS given no RUNTIME DESTINATION for executable target
  "fw_printenv".


CMake Error at src/CMakeLists.txt:30 (install):
  install TARGETS given no RUNTIME DESTINATION for executable target
  "fw_setenv".


-- Found Doxygen: /usr/bin/doxygen (found version "1.8.13") found components:  
doxygen dot 
Doxygen build started
-- Configuring incomplete, errors occurred!
See also 
"/home/builder/libubootenv/git/obj-arm-linux-gnueabihf/CMakeFiles/CMakeOutput.log".
cd obj-arm-linux-gnueabihf && tail -v -n \+0

Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-11 Thread Nobuhiro Iwamatsu 
Hi,

Thanks for your report.

2020年8月4日(火) 19:50 Gylstorff Quirin :
>
> Package: libubootenv-tool
> Version: 0.2-1
> Severity: serious
> Tags: patch ftbfs
> Justification: fails to build from source
>
> Dear Maintainer,
>
> I tried to  build libubootenv-tool with dpkg-buildpackage and the following 
> error
> did occur:
> ```
> -- Detecting C compile features - done
> CMake Error at src/CMakeLists.txt:29 (install):
>   install TARGETS given no RUNTIME DESTINATION for executable target
>   "fw_printenv".
>
>
> CMake Error at src/CMakeLists.txt:30 (install):
>   install TARGETS given no RUNTIME DESTINATION for executable target
>   "fw_setenv".
> ```

Hmm, I checked this on unstable but didn't reproduce it.
I attached a build log.
Could you tell me the environment you have confirmed?

>
> I fix the build error by moving the
> ```
> include("GNUInstallDirs")
> ```
> from Subject: [PATCH 2/4] Add support GNUInstallDirs
> before
> ```
>  add_subdirectory (src)
> ```
>

I see.
Indeed, this will fix your issue.

> Best regards,
> Quirin
>
Best regards,
  Nobuhiro

> -- System Information:
> Debian Release: 10.5
>   APT prefers stable
>   APT policy: (800, 'stable'), (500, 'testing')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 4.19.0-10-amd64 (SMP w/8 CPU cores)
> Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
> Locale: LANG=en_US, LC_CTYPE=en_US (charmap=UTF-8) (ignored: LC_ALL set to 
> en_US.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to 
> en_US.UTF-8)
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6


libubootenv-0.2.buildlog.nocolor.gz
Description: application/gzip

Bug#967487: libubootenv: Cannot build libubootenv with dpkg-buildpackage

2020-08-04 Thread Gylstorff Quirin 
Package: libubootenv-tool
Version: 0.2-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source

Dear Maintainer,

I tried to  build libubootenv-tool with dpkg-buildpackage and the following 
error
did occur:
```
-- Detecting C compile features - done
CMake Error at src/CMakeLists.txt:29 (install):
  install TARGETS given no RUNTIME DESTINATION for executable target
  "fw_printenv".


CMake Error at src/CMakeLists.txt:30 (install):
  install TARGETS given no RUNTIME DESTINATION for executable target
  "fw_setenv".
```

I fix the build error by moving the 
```
include("GNUInstallDirs")
```
from Subject: [PATCH 2/4] Add support GNUInstallDirs
before
```
 add_subdirectory (src)
```

Best regards,
Quirin

-- System Information:
Debian Release: 10.5
  APT prefers stable
  APT policy: (800, 'stable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-10-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to 
en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
>From c0ada30c985cda300c94ab243944b5e70df40bc1 Mon Sep 17 00:00:00 2001
From: Quirin Gylstorff 
Date: Mon, 3 Aug 2020 18:04:03 +0200
Subject: [PATCH] libubootenv: Change possition of include

Cmake modules should be included before the usage of variables or
function from the module.

Signed-off-by: Quirin Gylstorff 
---
 .../0002-Add-support-GNUInstallDirs.patch | 19 ++-
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/debian/patches/0002-Add-support-GNUInstallDirs.patch 
b/debian/patches/0002-Add-support-GNUInstallDirs.patch
index abe9b93..41c3bbe 100644
--- a/debian/patches/0002-Add-support-GNUInstallDirs.patch
+++ b/debian/patches/0002-Add-support-GNUInstallDirs.patch
@@ -1,4 +1,4 @@
-From b17d194bd8285a19382a902a0bec9e5e042df064 Mon Sep 17 00:00:00 2001
+From 6e8ce00347b276a336bb3006f2fccce81d150fc6 Mon Sep 17 00:00:00 2001
 From: Nobuhiro Iwamatsu 
 Date: Tue, 16 Apr 2019 08:52:01 +0900
 Subject: [PATCH 2/4] Add support GNUInstallDirs
@@ -9,24 +9,25 @@ installation compatible with GNU.
 https://cmake.org/cmake/help/v3.14/module/GNUInstallDirs.html
 
 Signed-off-by: Nobuhiro Iwamatsu 
+Signed-off-by: Quirin Gylstorff 
 ---
  CMakeLists.txt | 2 ++
  src/CMakeLists.txt | 8 
  2 files changed, 6 insertions(+), 4 deletions(-)
 
 diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 104969e..1d66f60 100644
+index 104969e..57477fc 100644
 --- a/CMakeLists.txt
 +++ b/CMakeLists.txt
-@@ -14,6 +14,8 @@ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99")
- include_directories ("${PROJECT_SOURCE_DIR}/src")
- add_subdirectory (src)
+@@ -10,6 +10,8 @@ add_definitions(-DVERSION="${VERSION}")
+ 
+ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu99")
  
 +include("GNUInstallDirs")
 +
- # first we can indicate the documentation build as an option and set it to ON 
by default
- option(BUILD_DOC "Build documentation" ON)
- 
+ #set(CMAKE_C_FLAGS_DEBUG "-g")
+ include_directories ("${PROJECT_SOURCE_DIR}/src")
+ add_subdirectory (src)
 diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
 index ea5979c..d97f221 100644
 --- a/src/CMakeLists.txt
@@ -44,5 +45,5 @@ index ea5979c..d97f221 100644
 +install (TARGETS fw_printenv DESTINATION "${CMAKE_INSTALL_BINDIR}")
 +install (TARGETS fw_setenv DESTINATION "${CMAKE_INSTALL_BINDIR}")
 -- 
-2.24.0
+2.20.1
 
-- 
2.20.1

>From c0ada30c985cda300c94ab243944b5e70df40bc1 Mon Sep 17 00:00:00 2001
From: Quirin Gylstorff 
Date: Mon, 3 Aug 2020 18:04:03 +0200
Subject: [PATCH] libubootenv: Change possition of include

Cmake modules should be included before the usage of variables or
function from the module.

Signed-off-by: Quirin Gylstorff 
---
 .../0002-Add-support-GNUInstallDirs.patch | 19 ++-
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/debian/patches/0002-Add-support-GNUInstallDirs.patch 
b/debian/patches/0002-Add-support-GNUInstallDirs.patch
index abe9b93..41c3bbe 100644
--- a/debian/patches/0002-Add-support-GNUInstallDirs.patch
+++ b/debian/patches/0002-Add-support-GNUInstallDirs.patch
@@ -1,4 +1,4 @@
-From b17d194bd8285a19382a902a0bec9e5e042df064 Mon Sep 17 00:00:00 2001
+From 6e8ce00347b276a336bb3006f2fccce81d150fc6 Mon Sep 17 00:00:00 2001
 From: Nobuhiro Iwamatsu 
 Date: Tue, 16 Apr 2019 08:52:01 +0900
 Subject: [PATCH 2/4] Add support GNUInstallDirs
@@ -9,24 +9,25 @@ installation compatible with GNU.
 https://cmake.org/cmake/help/v3.14/module/GNUInstallDirs.html
 
 Signed-off-by: Nobuhiro Iwamatsu 
+Signed-off-by: Quirin Gylstorff 
 ---
  CMakeLists.txt | 2 ++
  src/CMakeLists.txt | 8 
  2 files changed, 6 insertions(+), 4 deletions(-)
 
 diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 104969e..1d66f60 100644
+index 104969e..57477fc 100644
 ---