Re: Building in chroots hides bugs? (was: Successful and unsuccessful Debian development tools)

2006-08-04 Thread Bernhard R. Link
* martin f krafft [EMAIL PROTECTED] [060801 18:17]:
 also sprach Bernhard R. Link [EMAIL PROTECTED] [2006.08.01.1701 +0100]:
  Missing $(DESTDIR)s in Makefiles are an example. Especially when the
  install part was DESTDIRified, but the test before if the file is
  already there (as make install does not want to overwrite a config file)
  was forgotten.
  This leads to a corrupt package when build on a system where the package
  is already installed, i.e. is hidden away in any clean chroot.
 
 This makes zero sense to me.

Consider (in Makefile.in):

install: [...]
[...]
-if [ ! -f $(sysconfdir)/Bla ]; then \
  $(INSTALL) -m644 $(srcdir)/Bla $(DESTDIR)$(sysconfdir)/Bla \
fi

This is clearly a bug, most likely someone added DESTDIR later and
forgot it in the test. But unless that package build depends on itself,
you will never find it when building in a clean chroot.

Hochachtungsvoll,
  Bernhard R. Link


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Building in chroots hides bugs? (was: Successful and unsuccessful Debian development tools)

2006-08-01 Thread martin f krafft
also sprach Marco d'Itri [EMAIL PROTECTED] [2006.08.01.1221 +0100]:
 Building in chroots *hides* bugs.

Uh, what? Please give an example.

-- 
Please do not send copies of list mail to me; I read the list!
 
 .''`. martin f. krafft [EMAIL PROTECTED]
: :'  :proud Debian developer and author: http://debiansystem.info
`. `'`
  `-  Debian - when you have better things to do than fixing a system
 
emacs sucks, literally, not an insult, just a comment that it's
 large enough to have a noticeable gravitational pull...
   -- mercury on #debian-devel


signature.asc
Description: Digital signature (GPG/PGP)


Re: Building in chroots hides bugs? (was: Successful and unsuccessful Debian development tools)

2006-08-01 Thread Martijn van Oosterhout

On 8/1/06, martin f krafft [EMAIL PROTECTED] wrote:

also sprach Marco d'Itri [EMAIL PROTECTED] [2006.08.01.1221 +0100]:
 Building in chroots *hides* bugs.

Uh, what? Please give an example.


The only example I can think of is programs that use configure to
include support for anything they can find installed. So you get
different results depending on what's installed in the buildd. It's a
bug in the packaging though, the maintainer should be doing --enable-*
or --disable-* for every option. The point being that if you only
build in a clean chroot you'll never notice the problem.

That's how I understand it anyway,

Have a nice day,
--
Martijn van Oosterhout [EMAIL PROTECTED] http://svana.org/kleptog/


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: Building in chroots hides bugs? (was: Successful and unsuccessful Debian development tools)

2006-08-01 Thread Bernhard R. Link
* martin f krafft [EMAIL PROTECTED] [060801 15:29]:
 also sprach Marco d'Itri [EMAIL PROTECTED] [2006.08.01.1221 +0100]:
  Building in chroots *hides* bugs.
 
 Uh, what? Please give an example.

Missing $(DESTDIR)s in Makefiles are an example. Especially when the
install part was DESTDIRified, but the test before if the file is
already there (as make install does not want to overwrite a config file)
was forgotten.
This leads to a corrupt package when build on a system where the package
is already installed, i.e. is hidden away in any clean chroot.

Hochachtungsvoll,
  Bernhard R. Link


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Re: Building in chroots hides bugs? (was: Successful and unsuccessful Debian development tools)

2006-08-01 Thread martin f krafft
also sprach Bernhard R. Link [EMAIL PROTECTED] [2006.08.01.1701 +0100]:
 Missing $(DESTDIR)s in Makefiles are an example. Especially when the
 install part was DESTDIRified, but the test before if the file is
 already there (as make install does not want to overwrite a config file)
 was forgotten.
 This leads to a corrupt package when build on a system where the package
 is already installed, i.e. is hidden away in any clean chroot.

This makes zero sense to me.

-- 
Please do not send copies of list mail to me; I read the list!
 
 .''`. martin f. krafft [EMAIL PROTECTED]
: :'  :proud Debian developer and author: http://debiansystem.info
`. `'`
  `-  Debian - when you have better things to do than fixing a system
 
eine schlechte sache erregt, eine gute vertrÃĪgt viel kritik.
-- charles tschopp


signature.asc
Description: Digital signature (GPG/PGP)