Re: Help patching files in dependency package

2023-01-17 Thread Dominic Hargreaves
On Tue, Jan 17, 2023 at 08:52:50AM +0800, Paul Wise wrote:
> On Tue, 2023-01-17 at 00:55 +0100, Tobias Wackenhut wrote:
> 
> > What would be the cleanest way to package the new version with the 
> > mentioned patch?
> 
> Ask the extension author to get the patch included into the upstream
> rt5 core, get a release of that, then get request-tracker-5 updated.
> 
> Alternatively, drop the patch from the extension upstream and work
> around the issue within the extension upstream codebase instead.
> 
> If neither of these are viable, discuss with the request-tracker-5
> maintainers in Debian about including the patch in that package.

Hi, (somewhat dormant) RT maintainer here.

Thanks Paul, that's spot on. We have in the distant past applied
those sort of patches before they hit RT upstream, but it's definitely
not ideal, and it really depends on the patch. 

However, Tobias, I don't see any patch that needs to be applied in

- Debian already has RT 5.0.3 (>= 5.0.2)?

Let's continue the discussion on
pkg-request-tracker-maintain...@alioth-lists.debian.net (CCed).

Cheers
Dominic



Re: Help patching files in dependency package

2023-01-16 Thread Paul Wise
On Tue, 2023-01-17 at 00:55 +0100, Tobias Wackenhut wrote:

> What would be the cleanest way to package the new version with the 
> mentioned patch?

Ask the extension author to get the patch included into the upstream
rt5 core, get a release of that, then get request-tracker-5 updated.

Alternatively, drop the patch from the extension upstream and work
around the issue within the extension upstream codebase instead.

If neither of these are viable, discuss with the request-tracker-5
maintainers in Debian about including the patch in that package.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part


Help patching files in dependency package

2023-01-16 Thread Tobias Wackenhut

Hi,

I so far only have basic packaging experience and would be really happy 
for any pointers in the right direction.




Problem (concrete example for simplicity, general topic):

- This is about perl software, i.e. interpreted script files.
- I want to update rt5-extension-resetpassword
- Upstream introduces a patch to rt5 core packaged in request-tracker-5
- Base package is dependency of extension package

What would be the cleanest way to package the new version with the 
mentioned patch? I think I only need pointers on what direction to take 
and maybe a pointer to the docs. I am more interested in the general 
approach to this kind of problem, but the example is the issue at hand.




Ideas so far:

- Package scripts for patch and patch -R
- Including the affected files in the extension package and overriding 
the ones in the dependency
- Somehow integrate the functionality into the base package, that is 
only used by this extension.



Thanks in advance for any hint

Tobias