Re: Removal of the /selinux directory

2013-05-07 Thread Michael Biebl
Hi Laurent,

Am 07.05.2013 16:51, schrieb Laurent Bigonville:
 I'm intentionally not forcing the migration to the new mountpoint nor
 forcing the deletion of the directory on upgrade as, in my mind, if a
 Wheezy machine is still using the old mountpoint that might be for
 perfectly valid reasons and the package shouldn't touch it.
 A discussion has already been initiated on the bug report, see: #658070.

I think I mentioned that before: imho it would be nice to clean up
/selinux on upgrades automatically *if* /selinux is not in use, ie. no
selinuxfs mounted there.

Do you have any concerns, in doing that?

Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature


Re: Removal of the /selinux directory

2013-05-07 Thread Marco d'Itri
On May 07, Michael Biebl bi...@debian.org wrote:

 I think I mentioned that before: imho it would be nice to clean up
 /selinux on upgrades automatically *if* /selinux is not in use, ie. no
 selinuxfs mounted there.
Agreed.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Re: Removal of the /selinux directory

2013-05-07 Thread Steve Langasek
On Tue, May 07, 2013 at 04:57:51PM +0200, Michael Biebl wrote:
 Am 07.05.2013 16:51, schrieb Laurent Bigonville:
  I'm intentionally not forcing the migration to the new mountpoint nor
  forcing the deletion of the directory on upgrade as, in my mind, if a
  Wheezy machine is still using the old mountpoint that might be for
  perfectly valid reasons and the package shouldn't touch it.
  A discussion has already been initiated on the bug report, see: #658070.

 I think I mentioned that before: imho it would be nice to clean up
 /selinux on upgrades automatically *if* /selinux is not in use, ie. no
 selinuxfs mounted there.

+1.  The system created this directory as an exception to the FHS; it should
take care of cleaning it up as obsolete.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
slanga...@ubuntu.com vor...@debian.org


signature.asc
Description: Digital signature


Re: Removal of the /selinux directory

2013-05-07 Thread Laurent Bigonville
On May 07, Michael Biebl bi...@debian.org wrote:
 Hi Laurent,

Hi Michael,

 Am 07.05.2013 16:51, schrieb Laurent Bigonville:
  I'm intentionally not forcing the migration to the new mountpoint
  nor forcing the deletion of the directory on upgrade as, in my
  mind, if a Wheezy machine is still using the old mountpoint that
  might be for perfectly valid reasons and the package shouldn't
  touch it. A discussion has already been initiated on the bug
  report, see: #658070.
 
 I think I mentioned that before: imho it would be nice to clean up
 /selinux on upgrades automatically *if* /selinux is not in use, ie. no
 selinuxfs mounted there.
 
 Do you have any concerns, in doing that?

The directory should already be automatically removed by dpkg during
the upgrade as it was shipped by the package and not created by the
postinstall script. I'm not sure this was clear enough.

Cheers

Laurent Bigonville


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130507175526.29362...@soldur.bigon.be



Re: Removal of the /selinux directory

2013-05-07 Thread Michael Biebl
Am 07.05.2013 17:55, schrieb Laurent Bigonville:
 The directory should already be automatically removed by dpkg during
 the upgrade as it was shipped by the package and not created by the
 postinstall script. I'm not sure this was clear enough.

This was indeed not clear to me, so thanks for the clarification.

Your proposal seems fine then.
For users, which don't have selinux enabled (which should be the vast
majority), the directory will be removed on upgrades.
And, as you said, wheezy already switched to the new location, I assume
selinux users with a standard setup, will have the directory be removed
on upgrades, too.

If you want to be extra nice, you could add a NEWS.Debian entry about
this change, and maybe run mountpoint /selinux in postinst, referring to
that NEWS entry for users with a non-standard setup.

Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature