Re: Submitting Patches

[Paul Wise]

On Fri, 2022-10-21 at 16:28 +1100, Phillip Smith wrote:

> Where/How do I submit patches for Debian packages?

It completely depends on the preferences of the team or person who will
be reviewing the patches. Most teams and package maintainers accept
changes via Salsa merge requests, but, as mentioned by Julien, patches
attached to bug reports are usually also acceptable.

> I have a small improvement for the iptables-persistent package;
> I cloned the repo and made a patch (attached) on a branch, but it
> appears the public aren't welcome to create accounts on
> salsa.debian.org in order to create merge requests?

The public are welcome to create accounts on Salsa, but due to large
numbers of spammers signing up for accounts and due to the Salsa admins
being part-time volunteers, there may be some delay in the account
approval process, so patience is helpful.

> Are patches even welcome?

Debian always welcomes patches, although usually it is a better idea to
submit patches upstream first, so that they benefit all users instead
of just Debian users. When upstream isn't responsive the Debian
maintainer can be a patch recipient of last resort though.

Of course since iptables-persistent is a native Debian package,
the upstream in this case is the package Debian itself.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part

Re: Submitting Patches

[Phillip Smith]

On Fri, 21 Oct 2022 at 16:50,  wrote:
> "reportbug" should do what you want as far as I know...

Thank-you. I think that's been submitted now.
I appreciate your fast replies, have a great weekend :)

Re: Submitting Patches

[julien . puydt]

Le vendredi 21 octobre 2022 à 16:47 +1100, Phillip Smith a écrit :
> On Fri, 21 Oct 2022 at 16:30, Julien Puydt 
> wrote:
> > In general they are ; just attach them to a bug report against the
> > package.
> 
> Thanks! Is there a (recommended) tool to do this? I presume the
> recommended `bugreport` tool isn't appropriate for sending patches as
> opposed to actual bugs? I don't seem to be able to get `git
> send-email` to cooperate with the "Package" header that is required
> for submitting via email.


"reportbug" should do what you want as far as I know...

Cheers,

J.Puydt

Re: Submitting Patches

[Phillip Smith]

On Fri, 21 Oct 2022 at 16:30, Julien Puydt  wrote:
> In general they are ; just attach them to a bug report against the package.

Thanks! Is there a (recommended) tool to do this? I presume the
recommended `bugreport` tool isn't appropriate for sending patches as
opposed to actual bugs? I don't seem to be able to get `git
send-email` to cooperate with the "Package" header that is required
for submitting via email.

Re: Submitting Patches

[Julien Puydt]

Hi

Le ven. 21 oct. 2022 à 07:28, Phillip Smith  a écrit :

> Apologies if this is the wrong place to be asking this, but my
> Google-fu isn't guiding me to any results... Where/How do I submit
> patches for Debian packages?
>
> I have a small improvement for the iptables-persistent package; I
> cloned the repo and made a patch (attached) on a branch, but it
> appears the public aren't welcome to create accounts on
> salsa.debian.org in order to create merge requests?
>
> Are patches even welcome?
>


In general they are ; just attach them to a bug report against the package.

Thanks for your interest and contribution,

J.Puydt

>

Submitting Patches

[Phillip Smith]

Apologies if this is the wrong place to be asking this, but my
Google-fu isn't guiding me to any results... Where/How do I submit
patches for Debian packages?

I have a small improvement for the iptables-persistent package; I
cloned the repo and made a patch (attached) on a branch, but it
appears the public aren't welcome to create accounts on
salsa.debian.org in order to create merge requests?

Are patches even welcome?

Thanks,
~p

Re: Submitting patches for bugfixes/features for ifenslave

[Guus Sliepen]

On Tue, May 08, 2018 at 05:28:31PM +, Banerjee, Debabrata wrote:

> I can’t find an upstream project for this package, however it has bugs and is 
> now outdated in terms of kernel flags it can set from the 
> /etc/network/interfaces. I’ve tried emailing the maintainers listed and have 
> seen no reply. Is there a generic way to contribute patches for this package?

Hello, sorry for not responding to your earlier email. I'll have a look
at the proposed patch and merge it if it's working fine.

In general, the best way to contribute patches to Debian packages is to
create a bug report and attach the patch(es) to the report. See:
https://www.debian.org/Bugs/Reporting

-- 
Met vriendelijke groet / with kind regards,
  Guus Sliepen 


signature.asc
Description: PGP signature