Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-05-02 Thread Manoj Srivastava
On Thu, May 01 2014, Paul Smith wrote:
 On Wed, 2014-04-30 at 10:55 -0700, Manoj Srivastava wrote:
 Opened bug in Savannah BTS:
  https://savannah.gnu.org/bugs/?42249

 I pushed a fix for this.  See if it helps.

I have built a new version into experimental with that patch. Of
 the ~60 packages previously broken with make 4.0, I have now
 successfully built 6 (or roughly 10%) with a newly patched make.

With the other patches back ported from the savannah git repo, I
 think we have now addressed the issues uncovered by the archive
 rebuild. I am currently uoploading to experimental, and will hold it
 there for 24 hours, and upload it to unstable in 24 hours.

Many thanks to Paul for the quick turn around on this bug.

manoj
-- 
QOTD: This is a one line proof... if we start sufficiently far to the
left.
Manoj Srivastava sriva...@acm.org http://www.golden-gryphon.com/  
4096R/C5779A1C E37E 5EC5 2A01 DA25 AD20  05B6 CF48 9438 C577 9A1C


signature.asc
Description: PGP signature


Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-05-01 Thread Paul Smith
On Wed, 2014-04-30 at 10:55 -0700, Manoj Srivastava wrote:
 On Wed, Apr 30 2014, Paul Smith wrote:
 
  On Wed, 2014-04-30 at 18:19 +0200, Guillem Jover wrote:
  build-stamp:
  echo $@
  
  build-arch: build-stamp
 
  $ make --version | head -n1
  GNU Make 4.0
  $ make -f detect.mk -qn build-arch; echo $?
  2
 
  This is definitely a bug in GNU make 4.0 in handling -q (note the -n is
  not relevant: you can leave it out and get the same behavior).  The docs
  are clear on what the exit codes should be, and with -q make should exit
  with 1 if something needs to be updated and no error was detected.
 
 Opened bug in Savannah BTS:
  https://savannah.gnu.org/bugs/?42249

I pushed a fix for this.  See if it helps.


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1398952707.2353.88.camel@homebase



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Stephen Kitt
On Mon, 28 Apr 2014 23:01:58 -0700, Manoj Srivastava sriva...@ieee.org
wrote:
 Stephen Kitt sk...@debian.org
mingw-w64

This one is due to missing B-D-I...

Regards,

Stephen


signature.asc
Description: PGP signature


Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Roger Leigh
On Tue, Apr 29, 2014 at 09:53:31PM -0700, Russ Allbery wrote:
 Manoj Srivastava sriva...@ieee.org writes:
  On Tue, Apr 29 2014, Felipe Sateler wrote:
  On Mon, 28 Apr 2014 23:01:58 -0700, Manoj Srivastava wrote:
3) We state that packages must provide build-arch and build-indep for
   Jessie. This should trivially be true for every package using cdbs
   or debhelper (or, heaven forbid, my old home brew build system),
   and have dpkg-buildpackage call them without testing to see if they
   exist.  We would need to do another archive rebuild with the
   modified dpkg-buildpackage to see how many packages do not
   actually not implement these targets.
 
 Well, 2 is going back on something that we're trying to transition, and 1
 seems obviously unacceptable.  3 is where we were trying to get to anyway.
 I vote for just biting the bullet and trying to do 3 for jessie.

This transitional workaround has been in place for a decent length
of time now (over two years).  We wanted it removed for jessie; the
make -qn hack was known to be fragile, but worked enough to allow
the transition to be done effectively, and was never planned to
exist except for the short term during the transition, which is now
progressed quite well.  I posted some stats on it a couple of months
back.

This may be an opportune time to remove the nasty hack and mandate
the use of the policy-defined targets.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140430080051.gr30...@codelibre.net



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Alastair McKinstry

On 29/04/2014 07:01, Manoj Srivastava wrote:
 Hi,

  David Suárez  kindly did an archive rebuild with the new
  version of make in experimental, and the results of the build are at:
   http://aws-logs.debian.net/ftbfs-logs/results-make4/

 The summary: 73 packages have failed, though not all seem
  obviously related to make. Out of the 73, I can see 10 failed due to a
  known backward incompatibility in make; I am building a new version
  that reverts that change, though we should still fix the makefiles.

 Alastair McKinstry mckins...@debian.org
ferret-vis

Straightforward tabs/spaces fix. I am preparing a new version now (6.8.5),
may do an interim upload of 6.6.2 because 6.8.5 will introduce a new binary
package and may be delayed by ftp-masters.

rgds
Alastair

-- 
Alastair McKinstry, alast...@sceal.ie, mckins...@debian.org, 
https://diaspora.sceal.ie/u/amckinstry
A decent provision for the poor is the true test of civilization.
~Samuel Johnson, Boswell: Life of Johnson


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/5360e496.9060...@sceal.ie



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Paul Smith
FWIW, I can't determine what the issue is from this email thread.
Please file a bug on Savannah or start a thread with a repro case on the
bug-m...@gnu.org mailing list.

Thanks!




-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1398865839.27316.0.camel@pdsdesk



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Guillem Jover
Hi!

On Tue, 2014-04-29 at 21:53:31 -0700, Russ Allbery wrote:
 Manoj Srivastava sriva...@ieee.org writes:
  I will cut a normal bug on dpkg, and a serious one on make, and
   make the former block the latter while we figure otu what to do. The
   options, as I see it are:
 
   1) Do nothing. retain make-3.81 in Debian forever more. Needless to
  say, this is not very attractive. Pro: There is no action to
  take. Con: Almost every other distro is shipping a more recent
  make. We will continue to diverge from everyone else, and already
  the featires have diverged enough that people are having to add
  special cases in the vuild system for the Debian family of
  distributions.
   2) Hack dpkg-buildpackage to always load B-D-I, and go back to just
  calling ./debian/rules build. This is what we used to do. Pro: it
  is pretty easy to do (umm, I would think, but I don't know the dpkg
  code base so well anymore). This has the con of the inefficiency we
  have tried to eliminate, in that all the build dependencies are
  loaded for every build, even when not strictly needed.
3) We state that packages must provide build-arch and build-indep for
   Jessie. This should trivially be true for every package using cdbs
   or debhelper (or, heaven forbid, my old home brew build system),
   and have dpkg-buildpackage call them without testing to see if they
   exist.  We would need to do another archive rebuild with the
   modified dpkg-buildpackage to see how many packages do not
   actually not implement these targets.
 
 Well, 2 is going back on something that we're trying to transition, and 1
 seems obviously unacceptable.  3 is where we were trying to get to anyway.
 I vote for just biting the bullet and trying to do 3 for jessie.

I think we should first understand why the detection is failing with
the newer make. I'm taking a look now. Once that's done we might just
be able to fix (or workaround) one of:

  * make
  * dpkg-buildpackage
  * affected packages

If none of the above can be fixed then I'm all for just removing the
detection code, although that might be painful, AFAIR the numbers were
a bit scary last time Roger posted them?

Using the debhelper detection logic, which implies parsing make output
looks very much unappealing to me.

Thanks,
Guillem


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140430142237.ga23...@gaara.hadrons.org



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Roger Leigh
On Wed, Apr 30, 2014 at 04:22:37PM +0200, Guillem Jover wrote:
 I think we should first understand why the detection is failing with
 the newer make. I'm taking a look now. Once that's done we might just
 be able to fix (or workaround) one of:
 
   * make
   * dpkg-buildpackage
   * affected packages
 
 If none of the above can be fixed then I'm all for just removing the
 detection code, although that might be painful, AFAIR the numbers were
 a bit scary last time Roger posted them?

Back in February, it was around 14% remaining.  When we originally added
the hack, it was a bit under 50% supported.  Primarily dh and cdbs usage.
A lot of the gains are due to dh adoption since then.  It's fair to say
making the change will break a large number of packages.

However... are these remaining packages actively maintained?  If they are,
the maintainers have obviously been ignoring lintian for quite some time.
We've been quite kind in giving them two years to switch over; maybe it's
time for the stick and forcing them to be updated if they are to be
built again?  We're likely well into the long tail of infrequently-
updated packages at this point.

If we can update the hack to keep it in use for a while longer, that's
great.  It will definitely ease the pain.  However, we still need to
remove it at some point in the next months, so planning on how to handle
the badly-maintained packages is needed either way.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140430143957.gs30...@codelibre.net



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Sven Joachim
On 2014-04-30 16:39 +0200, Roger Leigh wrote:

 On Wed, Apr 30, 2014 at 04:22:37PM +0200, Guillem Jover wrote:
 I think we should first understand why the detection is failing with
 the newer make. I'm taking a look now. Once that's done we might just
 be able to fix (or workaround) one of:
 
   * make
   * dpkg-buildpackage
   * affected packages
 
 If none of the above can be fixed then I'm all for just removing the
 detection code, although that might be painful, AFAIR the numbers were
 a bit scary last time Roger posted them?

 Back in February, it was around 14% remaining.  When we originally added
 the hack, it was a bit under 50% supported.  Primarily dh and cdbs usage.
 A lot of the gains are due to dh adoption since then.  It's fair to say
 making the change will break a large number of packages.

Only 2400+ of them:

http://lintian.debian.org/tags/debian-rules-missing-recommended-target.html

Cheers,
   Sven


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/874n1a3kra@turtle.gmx.de



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Guillem Jover
Hi!

On Wed, 2014-04-30 at 16:22:37 +0200, Guillem Jover wrote:
 I think we should first understand why the detection is failing with
 the newer make. I'm taking a look now. Once that's done we might just
 be able to fix (or workaround) one of:
 
   * make
   * dpkg-buildpackage
   * affected packages

It would appear to me that make is the culprit (if the behaviour
change was not intentional, that is).

Here's the minimal makefile needed to reproduce it, and a transcript:

,--- detect.mk ---
build-stamp:
echo $@

build-arch: build-stamp
`---

$ make --version | head -n1
GNU Make 3.81
$ make -f detect.mk -qn build-arch; echo $?
1

$ make --version | head -n1
GNU Make 4.0
$ make -f detect.mk -qn build-arch; echo $?
2


Thanks,
Guillem


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140430161908.ga3...@gaara.hadrons.org



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Paul Smith
On Wed, 2014-04-30 at 18:19 +0200, Guillem Jover wrote:
 build-stamp:
 echo $@
 
 build-arch: build-stamp

 $ make --version | head -n1
 GNU Make 4.0
 $ make -f detect.mk -qn build-arch; echo $?
 2

This is definitely a bug in GNU make 4.0 in handling -q (note the -n is
not relevant: you can leave it out and get the same behavior).  The docs
are clear on what the exit codes should be, and with -q make should exit
with 1 if something needs to be updated and no error was detected.



-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1398875988.14617.3.camel@pdsdesk



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Manoj Srivastava
On Wed, Apr 30 2014, Paul Smith wrote:

 On Wed, 2014-04-30 at 18:19 +0200, Guillem Jover wrote:
 build-stamp:
 echo $@
 
 build-arch: build-stamp

 $ make --version | head -n1
 GNU Make 4.0
 $ make -f detect.mk -qn build-arch; echo $?
 2

 This is definitely a bug in GNU make 4.0 in handling -q (note the -n is
 not relevant: you can leave it out and get the same behavior).  The docs
 are clear on what the exit codes should be, and with -q make should exit
 with 1 if something needs to be updated and no error was detected.

Opened bug in Savannah BTS:
 https://savannah.gnu.org/bugs/?42249
-- 
Having a wonderful wine, wish you were beer.
Manoj Srivastava sriva...@acm.org http://www.golden-gryphon.com/  
4096R/C5779A1C E37E 5EC5 2A01 DA25 AD20  05B6 CF48 9438 C577 9A1C


signature.asc
Description: PGP signature


Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-30 Thread Paul Smith
On Wed, 2014-04-30 at 10:55 -0700, Manoj Srivastava wrote:
 On Wed, Apr 30 2014, Paul Smith wrote:
 
  On Wed, 2014-04-30 at 18:19 +0200, Guillem Jover wrote:
  build-stamp:
  echo $@
  
  build-arch: build-stamp
 
  $ make --version | head -n1
  GNU Make 4.0
  $ make -f detect.mk -qn build-arch; echo $?
  2
 
  This is definitely a bug in GNU make 4.0 in handling -q (note the -n is
  not relevant: you can leave it out and get the same behavior).  The docs
  are clear on what the exit codes should be, and with -q make should exit
  with 1 if something needs to be updated and no error was detected.
 
 Opened bug in Savannah BTS:
  https://savannah.gnu.org/bugs/?42249

Yes, thanks to Guillem for the repro case.  I see the problem; there's a
failure to propagate the correct exit code up through prerequisites.  I
tried a quick fix but it was not sufficient; I'll need to look into it
further this evening.


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/1398883455.14617.7.camel@pdsdesk



make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Manoj Srivastava
Hi,

 David Suárez  kindly did an archive rebuild with the new
 version of make in experimental, and the results of the build are at:
  http://aws-logs.debian.net/ftbfs-logs/results-make4/

The summary: 73 packages have failed, though not all seem
 obviously related to make. Out of the 73, I can see 10 failed due to a
 known backward incompatibility in make; I am building a new version
 that reverts that change, though we should still fix the makefiles.

At the link above, you have:
 - make4.res: results for make4 rebuild
 - normal.res results for normal sid rebuild
 - compare.list: comparison of normal.res against make4.res
 - make4.failed: failed results for make4 rebuild
 - logs-failed-make4: dir with the build logs of make4 rebuild failed packages

The DD list for the packages that failed  follows: I am
 requesting help to investigate the failures (I'll be working through
 the package list one the new version of make is built and hits
 experimental again)

manoj

Adam C. Powell, IV hazel...@debian.org
   aster (U)
   spooles (U)

Adam Majer ad...@zombino.com
   lpe

Alastair McKinstry mckins...@debian.org
   ferret-vis

Andrea Palazzi palazziand...@yahoo.it
   aster (U)

Anton Gladky gl...@debian.org
   spooles (U)

APT Development Team de...@lists.debian.org
   apt

Aurelien Jarno aure...@debian.org
   libusb-1.0

Balint Reczey bal...@balintreczey.hu
   pulseaudio (U)

Barak A. Pearlmutter b...@debian.org
   ikarus
   nbibtex
   scheme2c

Barry deFreese bddeb...@comcast.net
   xnee (U)

Barry deFreese bdefre...@debian.org
   tecnoballz (U)

Bas Couwenberg sebas...@xs4all.nl
   postgis (U)

Bdale Garbee bd...@gag.com
   gzip
   sdcc (U)

Benjamin Kaduk ka...@mit.edu
   krb5 (U)

Carl Worth cwo...@cworth.org
   gzip (U)

Christian Perrier bubu...@debian.org
   apt (U)

Christophe Trophime christophe.troph...@lncmi.cnrs.fr
   getdp (U)

Clint Adams cl...@debian.org
   haskell-tasty-golden (U)

Cyril Brulebois k...@debian.org
   xserver-xorg-video-vmware (U)

Daniel Glassey w...@debian.org
   grcompiler (U)

Debian Apache Maintainers debian-apa...@lists.debian.org
   apr
   apr-util

Debian Fonts Task Force pkg-fonts-de...@lists.alioth.debian.org
   grcompiler

Debian Games Team pkg-games-de...@lists.alioth.debian.org
   tecnoballz

Debian GIS Project pkg-grass-de...@lists.alioth.debian.org
   postgis

Debian GNOME Maintainers pkg-gnome-maintain...@lists.alioth.debian.org
   libgksu (U)

Debian Haskell Group pkg-haskell-maintain...@lists.alioth.debian.org
   haskell-tasty-golden
   haskell-terminal-progress-bar

Debian Julia Team pkg-julia-de...@lists.alioth.debian.org
   julia

Debian LibreOffice Maintainers debian-openoff...@lists.debian.org
   libreoffice

Debian Med Packaging Team debian-med-packag...@lists.alioth.debian.org
   proftmb

Debian Multimedia Maintainers 
pkg-multimedia-maintain...@lists.alioth.debian.org
   csound

Debian OCaml Maintainers debian-ocaml-ma...@lists.debian.org
   galax
   ocaml-melt

Debian QA Group packa...@qa.debian.org
   gwhere
   socks4-server
   xenwatch

Debian Science Maintainers debian-science-maintain...@lists.alioth.debian.org
   cernlib
   geant321
   mclibs
   paw
   spooles

Debian Science Team debian-science-maintain...@lists.alioth.debian.org
   aster
   getdp

Debian VoIP Team pkg-voip-maintain...@lists.alioth.debian.org
   portaudio

Debian X Strike Force debia...@lists.debian.org
   xserver-xorg-video-vmware

Denis Laxalde denis.laxa...@logilab.fr
   aster (U)

Dmitry Smirnov only...@debian.org
   nocache

Don Armstrong d...@debian.org
   lilypond

Drew Parsons dpars...@debian.org
   xserver-xorg-video-vmware (U)

Felipe Sateler fsate...@debian.org
   csound (U)
   pulseaudio (U)

Filippo Rusconi lopi...@debian.org
   r-cran-base64enc (U)
   r-cran-maldiquant (U)

Forrest Cahoon forrest.cah...@gmail.com
   csound (U)

Francesco Paolo Lovergine fran...@debian.org
   postgis (U)

Frank Lin PIAT fp...@klabs.be
   amtterm (U)

Gerrit Pape p...@smarden.org
   git

Gudjon I. Gudjonsson gud...@gudjon.org
   sdcc

Gustavo Noronha Silva k...@debian.org
   libgksu

J.H.M. Dassen (Ray) jdas...@debian.org
   spellutils

Jakub Adam jakub.a...@ktknet.cz
   jikespg

James Troup ja...@nocrew.org
   gimp-dimage-color

Jeroen Dekkers jer...@dekkers.ch
   sogo

Joachim Breitner nome...@debian.org
   haskell-terminal-progress-bar (U)

Jochen Friedrich joc...@scram.de
   isakmpd
   pinball

Jonas Smedegaard d...@jones.dk
   csound (U)

Jonathan Nieder jrnie...@gmail.com
   git (U)
   xz-utils

Jose Carlos Garcia Sogo js...@debian.org
   portaudio (U)

Josselin Mouette j...@debian.org
   libgksu (U)

Julian Andres Klode j...@debian.org
   apt (U)

Kari Pahula k...@debian.org
   gecode

Kilian Krause kil...@debian.org
   portaudio (U)

Laszlo Kajan lka...@rostlab.org
   proftmb (U)

Lifeng Sun lifong...@gmail.com
   cernlib (U)
   geant321 (U)
   mclibs (U)
   paw (U)

Ludovic Rousseau rouss...@debian.org
   plucker

Marcus Better 

Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Joachim Breitner
Hi,

Am Montag, den 28.04.2014, 23:01 -0700 schrieb Manoj Srivastava:
 Debian Haskell Group pkg-haskell-maintain...@lists.alioth.debian.org
haskell-tasty-golden
haskell-terminal-progress-bar

related to dependencies on the systems locale, it seems. Not related to
make.

Greetings,
Joachim

-- 
Joachim nomeata Breitner
Debian Developer
  nome...@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
  JID: nome...@joachim-breitner.de | http://people.debian.org/~nomeata



signature.asc
Description: This is a digitally signed message part


Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Emilio Pozuelo Monfort
On 29/04/14 08:01, Manoj Srivastava wrote:
 Debian GNOME Maintainers pkg-gnome-maintain...@lists.alioth.debian.org
libgksu (U)

make[1]: Entering directory '/«PKGBUILDDIR»'
Makefile:733: *** missing separator (did you mean TAB instead of 8 spaces?).  
Stop.

That's a problem in libgksu using spaces rather than tabs in ./Makefile.am.
Pretty trivial to fix.

Cheers,
Emilio


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/535f56b2.7050...@debian.org



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Kari Pahula
On Mon, Apr 28, 2014 at 11:01:58PM -0700, Manoj Srivastava wrote:
 Kari Pahula k...@debian.org
gecode

That one failed due to missing Build-Depends-Indep and the build
attempted to call debian/rules build-indep.  I don't think that make
4.0 had anything to do with that failure.


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140429160944.gb15...@sammakko3.piperka.net



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Russ Allbery
Manoj Srivastava sriva...@ieee.org writes:

 Russ Allbery r...@debian.org
krb5 (U)

Missing build dependency on Python, unrelated to make.  I'll file a bug to
make sure this gets fixed.

-- 
Russ Allbery (r...@debian.org)   http://www.eyrie.org/~eagle/


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/877g68gkeu@windlord.stanford.edu



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Julien Cristau
On Mon, Apr 28, 2014 at 23:01:58 -0700, Manoj Srivastava wrote:

 Debian X Strike Force debia...@lists.debian.org
xserver-xorg-video-vmware
 
I've split the rule in
http://anonscm.debian.org/gitweb/?p=pkg-xorg/driver/xserver-xorg-video-vmware.git;a=commitdiff;h=f9208ee13d7ecb6efac784514897c824c65e9365
Hopefully that'll make it happier.  Thanks for the report.

Cheers,
Julien


signature.asc
Description: Digital signature


Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Felipe Sateler
On Mon, 28 Apr 2014 23:01:58 -0700, Manoj Srivastava wrote:


 Felipe Sateler fsate...@debian.org
csound (U)
pulseaudio (U)

On both I'm getting this:

dpkg-buildpackage: warning: debian/rules must be updated to support the 
'build-arch' and 'build-indep' targets (at least 'build-arch' seems to be 
missing)

Looks like the new make is not doing the expected thing when called as

make -f debian/rules -qn build-arch

(And by expected is return 2 when not found, any other return code 
otherwise).

csound fails because Build-Depends-Indep is not installed, pulseaudio 
fails because we use the same make -qn trick in our rules file (although 
it will be gone in the next upload).

-- 
Saludos,
Felipe Sateler


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/ljoiqk$v4a$1...@ger.gmane.org



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Adam Borowski
On Mon, Apr 28, 2014 at 11:01:58PM -0700, Manoj Srivastava wrote:
  David Suárez  kindly did an archive rebuild with the new
  version of make in experimental, and the results of the build are at:
   http://aws-logs.debian.net/ftbfs-logs/results-make4/
 
 The summary: 73 packages have failed, though not all seem
  obviously related to make. Out of the 73, I can see 10 failed due to a
  known backward incompatibility in make; I am building a new version
  that reverts that change, though we should still fix the makefiles.

Add kernel-package to the list of failures.  It doesn't FTBFS itself, but
trying to compile a kernel using it fails with:

debian/ruleset/misc/version_vars.mk:161: *** Error. The Kernel Release
  version make[2]: Leaving directory '/home/kilobyte/linux'.make[2]: Leaving
  directory '/home/kilobyte/linux'.make[2]: Leaving directory
  '/home/kilobyte/linux'make[2]: Leaving directory
  '/home/kilobyte/linux'make[2]: Leaving directory '/home/kilobyte/linux'
  VERSION=[make[2]: Leaving directory '/home/kilobyte/linux'],
  PATCHLEVEL=[make[2]: Leaving directory '/home/kilobyte/linux'],
  SUBLEVEL=[make[2]: Leaving directory '/home/kilobyte/linux'],
  EXTRAVERSION=[make[2]: Leaving directory '/home/kilobyte/linux'], iatv=[],
  LOCALVERSION=[make[2]: Leaving directory '/home/kilobyte/linux'],
  UTS_RELEASE_VERSION=[3.14.2-x32], KERNELRELEASE=[].  is not all lowercase. 
  Since the version ends up in the package name of the kernel image package,
  this is a Debian policy violation, and the packaging system shall refuse to
  package the image.  .  Stop.
make[2]: Leaving directory '/home/kilobyte/linux'
debian/ruleset/targets/image.mk:347: recipe for target
  'debian/stamp/binary/pre-linux-image-3.14.2-x32' failed
make[1]: *** [debian/stamp/binary/pre-linux-image-3.14.2-x32] Error 2
make[1]: Leaving directory '/home/kilobyte/linux'
debian/ruleset/local.mk:105: recipe for target 'linux-image' failed
make: *** [linux-image] Error 2

It does work with old make.

Fortunately, we got rather few packaged build systems that don't get tested
as a part of an archive rebuild, so there's hope there's much more failures.

-- 
A tit a day keeps the vet away.


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140429161334.ga14...@angband.pl



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Jakub Wilk

* Manoj Srivastava sriva...@ieee.org, 2014-04-28, 23:01:

Moritz Muehlenhoff j...@debian.org
  fbi


A bashism (echo -e) in mk/Autoconf.mk slightly corrupts the first line of 
Make.config:


-e LIB  := lib

Apparently the new make doesn't like it.

Beware of #584233 when fixing this bug.

--
Jakub Wilk


--
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20140429180713.ga1...@jwilk.net



Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Manoj Srivastava
On Tue, Apr 29 2014, Felipe Sateler wrote:

 On Mon, 28 Apr 2014 23:01:58 -0700, Manoj Srivastava wrote:


 Felipe Sateler fsate...@debian.org
csound (U)
pulseaudio (U)
Add to that:
 Kari Pahula k...@debian.org
gecode
 Russ Allbery r...@debian.org
krb5 (U)

Missing Build-Depends-Indep is a common pattern among the 60
 or so remaining build failures. 

 On both I'm getting this:

 dpkg-buildpackage: warning: debian/rules must be updated to support the 
 'build-arch' and 'build-indep' targets (at least 'build-arch' seems to be 
 missing)

 Looks like the new make is not doing the expected thing when called as

 make -f debian/rules -qn build-arch

With the old make (3.8,1), it correctly
 loads B-D-I and calls build-indep, with make 4.0-[12], it fails to
 determine of the target exists, and calls  ./debian/rules build


 (And by expected is return 2 when not found, any other return code 
 otherwise).

Right. Since dpkg-buildpackage cannot ascertain that
 'build-arch' and 'build-indep' targets exist, it calls build, and does
 not load B-D-I first.

Most of the archive works, since B-D-I was not paid any
 attention to on the buildds, and every package used to build with
 ./debian/rules build and all the dependencies used to be in
 Build-Depends.

Since then, B-D-I has been fixed, and we see empirical evidence
 that around 60 packages have made us of that.

I don't know why the behaviour has changed; but I have tested
 it on apt and opusfile, and a couple of other packages.

I will cut a normal bug on dpkg, and a serious one on make, and
 make the former block the latter while we figure otu what to do. The
 options, as I see it are:

 1) Do nothing. retain make-3.81 in Debian forever more. Needless to
say, this is not very attractive. Pro: There is no action to
take. Con: Almost every other distro is shipping a more recent
make. We will continue to diverge from everyone else, and already
the featires have diverged enough that people are having to add
special cases in the vuild system for the Debian family of
distributions.
 2) Hack dpkg-buildpackage to always load B-D-I, and go back to just
calling ./debian/rules build. This is what we used to do. Pro: it
is pretty easy to do (umm, I would think, but I don't know the dpkg
code base so well anymore). This has the con of the inefficiency we
have tried to eliminate, in that all the build dependencies are
loaded for every build, even when not strictly needed.
  3) We state that packages must provide build-arch and build-indep for
 Jessie. This should trivially be true for every package using cdbs
 or debhelper (or, heaven forbid, my old home brew build system),
 and have dpkg-buildpackage call them without testing to see if they
 exist.  We would need to do another archive rebuild with the
 modified dpkg-buildpackage to see how many packages do not
 actually not implement these targets.


None of these are very pretty.


manoj
-- 
Just because he's dead is no reason to lay off work.
Manoj Srivastava sriva...@acm.org http://www.golden-gryphon.com/  
4096R/C5779A1C E37E 5EC5 2A01 DA25 AD20  05B6 CF48 9438 C577 9A1C


signature.asc
Description: PGP signature


Re: make 4.0: archive rebuild resulted in 73 packages broken (help wanted)

2014-04-29 Thread Russ Allbery
Manoj Srivastava sriva...@ieee.org writes:
 On Tue, Apr 29 2014, Felipe Sateler wrote:
 On Mon, 28 Apr 2014 23:01:58 -0700, Manoj Srivastava wrote:


 Felipe Sateler fsate...@debian.org
csound (U)
pulseaudio (U)
 Add to that:
 Kari Pahula k...@debian.org
gecode
 Russ Allbery r...@debian.org
krb5 (U)

 Missing Build-Depends-Indep is a common pattern among the 60
  or so remaining build failures. 

Yeah, I was wrong about my analysis here.  I'll let Sam know.  (Although
it's still a minor bug that the package doesn't B-D-I directly on
python-lxml.)

 I will cut a normal bug on dpkg, and a serious one on make, and
  make the former block the latter while we figure otu what to do. The
  options, as I see it are:

  1) Do nothing. retain make-3.81 in Debian forever more. Needless to
 say, this is not very attractive. Pro: There is no action to
 take. Con: Almost every other distro is shipping a more recent
 make. We will continue to diverge from everyone else, and already
 the featires have diverged enough that people are having to add
 special cases in the vuild system for the Debian family of
 distributions.
  2) Hack dpkg-buildpackage to always load B-D-I, and go back to just
 calling ./debian/rules build. This is what we used to do. Pro: it
 is pretty easy to do (umm, I would think, but I don't know the dpkg
 code base so well anymore). This has the con of the inefficiency we
 have tried to eliminate, in that all the build dependencies are
 loaded for every build, even when not strictly needed.
   3) We state that packages must provide build-arch and build-indep for
  Jessie. This should trivially be true for every package using cdbs
  or debhelper (or, heaven forbid, my old home brew build system),
  and have dpkg-buildpackage call them without testing to see if they
  exist.  We would need to do another archive rebuild with the
  modified dpkg-buildpackage to see how many packages do not
  actually not implement these targets.

Well, 2 is going back on something that we're trying to transition, and 1
seems obviously unacceptable.  3 is where we were trying to get to anyway.
I vote for just biting the bullet and trying to do 3 for jessie.

-- 
Russ Allbery (r...@debian.org)   http://www.eyrie.org/~eagle/


-- 
To UNSUBSCRIBE, email to debian-devel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/87lhun2zas@windlord.stanford.edu