Re: Review/Merge queue
Raphael Hertzog: The tool looks neat (just discovered it via LWN.net) for reviewing single patches but less so to review a full branch as you must submit a single patch that combines all the commit of your branch. Yes, therein lies what I see as its greatest flaw. Really? Really. That's the feature that sold us at my $dayjob. -- \\// Peter - http://www.softwolves.pp.se/ -- To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/alpine.deb.2.00.1005091847020.14...@ds9.cixit.se
Re: Review/Merge queue
Raphael Hertzog: If you have suggestions or ideas, go ahead. This is a very basic framework to organize code reviews, it can surely be extended. Or perhaps look at using a proper code review tool? Review Board - http://www.reviewboard.org/ - is quite OK, and does have support for handling patches against code in Git repositories. -- \\// Peter - http://www.softwolves.pp.se/ -- To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/alpine.deb.2.00.1005070756590.5...@ds9.cixit.se
Re: Review/Merge queue
Hi, Peter Krefting wrote: Raphael Hertzog: If you have suggestions or ideas, go ahead. This is a very basic framework to organize code reviews, it can surely be extended. Or perhaps look at using a proper code review tool? Review Board - http://www.reviewboard.org/ - is quite OK, and does have support for handling patches against code in Git repositories. Is such a tool actually helpful when there are so few people involved? Not a rhetorical question --- I have too little experience of processes other than “discuss the patch on a mailing list” to know. Jonathan -- To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100507070853.ga...@progeny.tock
Re: Review/Merge queue
Jonathan Nieder: Is such a tool actually helpful when there are so few people involved? They can be helpful to manage review queues and keep track of what has been reviewed and what has not. And, unlike a Wiki page, they are built to do just that. And Review Board has a nice function that it generates well-formatted and threaded e-mail from the review comments it creates, this can be fed back to the mailing list if that is wanted. Not a rhetorical question --- I have too little experience of processes other than ?discuss the patch on a mailing list? to know. I have used it at $dayjob for a while (but the project we use it for is a lot larger), and find it useful. -- \\// Peter - http://www.softwolves.pp.se/ -- To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/alpine.deb.2.00.1005070831320.5...@ds9.cixit.se
Re: Review/Merge queue
On Fri, 07 May 2010, Peter Krefting wrote: They can be helpful to manage review queues and keep track of what has been reviewed and what has not. And, unlike a Wiki page, they are built to do just that. And reviewers can approve the patch as being ready to be included (and the main list can show the number of approvals), and the dashboard lets you follow the patches that you reviewed that got updated and so on. The tool looks neat (just discovered it via LWN.net) for reviewing single patches but less so to review a full branch as you must submit a single patch that combines all the commit of your branch. Do you know if there are ways to handle this better? And Review Board has a nice function that it generates well-formatted and threaded e-mail from the review comments it creates, this can be fed back to the mailing list if that is wanted. Really? Cheers, -- Raphaël Hertzog Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/ My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/ -- To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100507080500.ga25...@rivendell
Re: Review/Merge queue
Peter Krefting pe...@softwolves.pp.se writes: Raphael Hertzog: If you have suggestions or ideas, go ahead. This is a very basic framework to organize code reviews, it can surely be extended. Or perhaps look at using a proper code review tool? Review Board - http://www.reviewboard.org/ - is quite OK, and does have support for handling patches against code in Git repositories. I can also wholeheartedly recommend Gerrit, which has been an absolutely transformative experience for the one project (OpenAFS) where I've been involved in deploying it. The rate of change increased by probably a factor of three and new contributors have come out of the woodwork now that they can propose a patch for review by just pushing it to a particular Git repository. At the moment, it has the serious drawback that it's not yet packaged for Debian (and it's a Java application, so this is non-trivial). I may have the opportunity to have Stanford pay me to do that packaging work sometime this summer, but I have a lot of other things on my plate so I'm not sure that will happen. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-dpkg-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/878w7vbm1s@windlord.stanford.edu
