Bug#20471: patch to check rdepends on unpack
Raphael Hertzog writes (Re: Bug#20471: patch to check rdepends on unpack): I just did that locally and attached is the corresponding patch (created by git-format-patch for easy inclusion). I adjusted the commit log, the changelog and fixed some trailing spaces (that the pre-commit hook forbid me to commit). Where is your patch available as a public git branch ? Ian. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#20471: patch to check rdepends on unpack
Hi, On Thu, 01 Nov 2007, Ian Jackson wrote: Raphael Hertzog writes (Re: Bug#20471: patch to check rdepends on unpack): I just did that locally and attached is the corresponding patch (created by git-format-patch for easy inclusion). I adjusted the commit log, the changelog and fixed some trailing spaces (that the pre-commit hook forbid me to commit). Where is your patch available as a public git branch ? bug20471 branch in git://git.debian.org/~rhertzog/dpkg.git http://git.debian.org/?p=users/hertzog/dpkg.git;a=shortlog;h=bug20471 On Thu, 01 Nov 2007, Ian Jackson wrote: Raphael Hertzog writes (Re: Bug#20471: patch to check rdepends on unpack): I just did that locally and attached is the corresponding patch (created by git-format-patch for easy inclusion). I adjusted the commit log, the changelog and fixed some trailing spaces (that the pre-commit hook forbid me to commit). Firstly, surely applying patches, rather than merging using the RCS, defeats the purpose of using the RCS ? As long as the serie of patches matches the series of commits, it doesn't make any difference for git. git-format-patch and git-am are precisely used to exchange changesets over email. (We come again to the same discussion: it's the content that matters not the precise id of the commit) Secondly, what is wrong with a bit of trailing whitespace ? Not much, except that we advise to enable the default pre-commit hooks and it forbids committing with trailing whitespaces (but the reason we suggest this is that it also forbids to commit conflict markers, and some translators managed to do this). And I got caught by this after cherry-picking your commit on top of the official master branch. Cheers, -- Raphaël Hertzog Premier livre français sur Debian GNU/Linux : http://www.ouaza.com/livre/admin-debian/
Bug#20471: patch to check rdepends on unpack
Raphael Hertzog writes (Re: Bug#20471: patch to check rdepends on unpack): bug20471 branch in git://git.debian.org/~rhertzog/dpkg.git http://git.debian.org/?p=users/hertzog/dpkg.git;a=shortlog;h=bug20471 For the record, while I think trailing whitespace is hardly a big crime :-), that commit (17b87fa1) is obviously also fine by me. I don't have an opinion about which of these should be applied. Ian. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#20471: patch to check rdepends on unpack
Raphael Hertzog writes (Bug#20471: patch to check rdepends on unpack): Please either attach a copy of the patch or use git.debian.org so that we can browse the changes via gitweb. It's now at http://git.debian.org/?p=users/iwj/dpkg.git git://git.debian.org/git/users/iwj/dpkg.git etc. as the branch bug20471 Thanks for your help, Raphael. Ian. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#20471: patch to check rdepends on unpack
On Tue, 30 Oct 2007, Ian Jackson wrote: tags 20471 + patch thanks I have prepared and tested a change that fixes this problem. It's available at http://www.chiark.greenend.org.uk/~ian/git/dpkg/dpkg.bugfixes/ as the branch bug20471 Please either attach a copy of the patch or use git.debian.org so that we can browse the changes via gitweb. Cheers, -- Raphaël Hertzog Premier livre français sur Debian GNU/Linux : http://www.ouaza.com/livre/admin-debian/
