Bug#435126: dpkg-source please ignore vcs dirs for native packages too
On Wed, Sep 26, 2007 at 09:54:26AM +0200, Raphael Hertzog wrote: > On Tue, 25 Sep 2007, Brendan O'Dea wrote: > > So, while dpkg-source needs to be able to parse W&P format, the task > > of creating it should fall to tools better suited to the job: think > > git-buildpackage and other such tools which should have knowledge of a > > discrete set of patches/changesets. > > I'm not sure I like this idea... I'd rather have those tools generate the > debian/source file (or more generally interface with a dpkg API to define > how the package should be built). I would agree with this. This should avoid too much doubled code in all tools that might want to use the new format. Plus a working reference implementation (that doesn't need to be very user friendly, just as complete as possible) would probably do wonders for testing and advertising of the new format. Gruesse, -- Frank Lichtenheld <[EMAIL PROTECTED]> www: http://www.djpig.de/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#435126: dpkg-source please ignore vcs dirs for native packages too
On 9/26/07, Raphael Hertzog <[EMAIL PROTECTED]> wrote: > BTW, do you have pointers summing up everything what's already defined > concerning W&P ? The canonical documentation was the dpkg.org wiki, which I have a tarball of, but no good place to host right now. Scott gave a good, concise description here: http://lwn.net/Articles/139811/ --bod -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#435126: dpkg-source please ignore vcs dirs for native packages too
Hi, On Tue, 25 Sep 2007, Brendan O'Dea wrote: > On 9/22/07, Frank Lichtenheld <[EMAIL PROTECTED]> wrote: > > On Thu, Aug 02, 2007 at 08:33:05PM +0200, Raphael Hertzog wrote: > > A good opportunity to change the default behaviour of dpkg-source would > > be the addition of wig&pen build support, BTW ;) > > The problem with generating W&P format is that you need to provide > more information about how the package is constructed than is given to > an invocation of "dpkg-source -b" which has only the .orig dir or > .orig.tar.gz and the current dir. Given those basic input, the most > sensible output is v1.0 format. Up to now yes, but we could define debian/source (or new headers in debian/control) to contain that supplementary information. BTW, do you have pointers summing up everything what's already defined concerning W&P ? > So, while dpkg-source needs to be able to parse W&P format, the task > of creating it should fall to tools better suited to the job: think > git-buildpackage and other such tools which should have knowledge of a > discrete set of patches/changesets. I'm not sure I like this idea... I'd rather have those tools generate the debian/source file (or more generally interface with a dpkg API to define how the package should be built). Cheers, -- Raphaël Hertzog Premier livre français sur Debian GNU/Linux : http://www.ouaza.com/livre/admin-debian/
Bug#435126: dpkg-source please ignore vcs dirs for native packages too
On 9/22/07, Frank Lichtenheld <[EMAIL PROTECTED]> wrote: > On Thu, Aug 02, 2007 at 08:33:05PM +0200, Raphael Hertzog wrote: > A good opportunity to change the default behaviour of dpkg-source would > be the addition of wig&pen build support, BTW ;) The problem with generating W&P format is that you need to provide more information about how the package is constructed than is given to an invocation of "dpkg-source -b" which has only the .orig dir or .orig.tar.gz and the current dir. Given those basic input, the most sensible output is v1.0 format. So, while dpkg-source needs to be able to parse W&P format, the task of creating it should fall to tools better suited to the job: think git-buildpackage and other such tools which should have knowledge of a discrete set of patches/changesets. Note that parse support in dpkg-source still allows for a package to be unpacked/edited/rebuilt (albeit in a "lossy" way) by a local admin, the security team or whoever using only dpkg-dev tools. dpkg-source -x pack.dsc # unpack v2.0 [edit] dpkg-buildpackage ... # create v1.0 --bod -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#435126: dpkg-source please ignore vcs dirs for native packages too
On Thu, Aug 02, 2007 at 08:33:05PM +0200, Raphael Hertzog wrote: > I agree with maks that it would be nice if dpkg-source excluded those > directories by default. Thus I made this small patch. > > If Guillem or Frank are OK with this patch, I can apply it myself. > I tested it here and it works fine at least in the case of dpkg's git > repository. Apart from the fact that the patch looks more like a proof-of-concept than a real patch (e.g. no documentation updates, default list is not overridable) I'm a bit wary about changing the default behaviour of dpkg-source about this. A good opportunity to change the default behaviour of dpkg-source would be the addition of wig&pen build support, BTW ;) Gruesse, -- Frank Lichtenheld <[EMAIL PROTECTED]> www: http://www.djpig.de/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#435126: dpkg-source please ignore vcs dirs for native packages too
tags 435126 + patch
thanks
Hello,
I agree with maks that it would be nice if dpkg-source excluded those
directories by default. Thus I made this small patch.
If Guillem or Frank are OK with this patch, I can apply it myself.
I tested it here and it works fine at least in the case of dpkg's git
repository.
Cheers,
--
Raphaël Hertzog
Premier livre français sur Debian GNU/Linux :
http://www.ouaza.com/livre/admin-debian/
>From 854f7973ba2ca50123b64ddc60adac04c61bde43 Mon Sep 17 00:00:00 2001
From: Raphael Hertzog <[EMAIL PROTECTED]>
Date: Thu, 2 Aug 2007 19:18:12 +0200
Subject: [PATCH] dpkg-source: exclude directories created by distributed VCS from a native tarball build
It's much more convenient to be able to start a build from the VCS tree
instead of having to make an export or similar. This is particularly true
with distributed VCS which tend to keep all their stuff in a single directory
at the root of the tree. Current list includes bzr/git/hg/darcs/arch.
---
scripts/dpkg-source.pl |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/scripts/dpkg-source.pl b/scripts/dpkg-source.pl
index 1ed1213..20c98fb 100755
--- a/scripts/dpkg-source.pl
+++ b/scripts/dpkg-source.pl
@@ -56,7 +56,8 @@ my %type; # used by checktype
my %filepatched; # used by checkdiff
my %dirtocreate; # used by checkdiff
-my @tar_ignore;
+my @tar_ignore = qw(--exclude=.git --exclude=.bzr --exclude=_darcs
+ --exclude=.hg --exclude={arch});
use POSIX;
use Fcntl qw (:mode);
--
1.5.2.4
Bug#435126: dpkg-source please ignore vcs dirs for native packages too
Package: dpkg Version: 1.14.5 Severity: normal tar -tzvf ../initramfs-tools_0.90.tar.gz | grep .git | wc -l 625 current workaround is to pass -I.git option with DEBUILD_DPKG_BUILDPACKAGE_OPTS in .devscripts best regards -- maks -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (900, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.22-1-686 (SMP w/1 CPU core) Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1) Shell: /bin/sh linked to /bin/bash Versions of packages dpkg depends on: ii coreutils 5.97-5.3 The GNU core utilities ii libc6 2.6-2 GNU C Library: Shared libraries dpkg recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
