Bug#892217: [PATCH] libffi: Please add support for the riscv64 architecture

[Manuel A. Fernandez Montecelo]

Hi,

2018-03-13 16:21 Matthias Klose:

Source: libffi
Source-Version: 3.3~20180313-1

We believe that the bug you reported is fixed in the latest version of
libffi, which is due to be installed in the Debian FTP archive.
[...]
libffi (3.3~20180313-1) experimental; urgency=medium
.
  * Snapshot, taken from the trunk.
- Add RISC-V support. Closes: #892217.


Thanks for the quick fix!

It was built "natively" and passes the tests :)

---

 === libffi tests ===

 Schedule of variations:
 unix

 Running target unix
 Using /usr/share/dejagnu/baseboards/unix.exp as board description file for 
target.
 Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
 Using ../../testsuite/config/default.exp as tool-and-target-specific interface 
file.
 Running ../../testsuite/libffi.bhaible/bhaible.exp ...
 Running ../../testsuite/libffi.call/call.exp ...
 Running ../../testsuite/libffi.complex/complex.exp ...
 Running ../../testsuite/libffi.go/go.exp ...

 === libffi Summary ===

 # of expected passes3495
 # of unsupported tests  30

--
Manuel A. Fernandez Montecelo 

Bug#892217: [PATCH] libffi: Please add support for the riscv64 architecture

[Aurelien Jarno]

On 2018-03-06 22:31, Karsten Merker wrote:
> Source: libffi
> Version: 3.3~20180131
> Severity: wishlist
> X-Debbugs-CC: debian-ri...@lists.debian.org
> Tags: patch
> User: debian-ri...@lists.debian.org
> Usertags: riscv64
> 
> Hello,
> 
> we are in the process of bootstrapping a Debian port for the
> riscv64 architecture (https://wiki.debian.org/RISC-V).  The
> libffi package is part of the build-dependency chain for the
> essential package set, so we need to build it for riscv64 to be
> able to complete the bootstrap process.
> 
> Current upstream libffi doesn't yet have support for the RISC-V
> architecture, but a pull request to add it has been submitted:
> 
>   https://github.com/libffi/libffi/pull/281/ respectively
>   https://patch-diff.githubusercontent.com/raw/libffi/libffi/pull/281.patch
> 
> The pull request has been authored by one of the Fedora riscv64
> porters and the Fedora riscv64 port already uses this patchset. 
> It would be great if you could add the patchset to the Debian
> libffi package as well.

Note that the patch has now been merged upstream:
https://github.com/libffi/libffi/commit/3840d49aaa831d649b1597518a2903dfed0d57f3

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net

Bug#892217: [PATCH] libffi: Please add support for the riscv64 architecture

[Karsten Merker]

Source: libffi
Version: 3.3~20180131
Severity: wishlist
X-Debbugs-CC: debian-ri...@lists.debian.org
Tags: patch
User: debian-ri...@lists.debian.org
Usertags: riscv64

Hello,

we are in the process of bootstrapping a Debian port for the
riscv64 architecture (https://wiki.debian.org/RISC-V).  The
libffi package is part of the build-dependency chain for the
essential package set, so we need to build it for riscv64 to be
able to complete the bootstrap process.

Current upstream libffi doesn't yet have support for the RISC-V
architecture, but a pull request to add it has been submitted:

  https://github.com/libffi/libffi/pull/281/ respectively
  https://patch-diff.githubusercontent.com/raw/libffi/libffi/pull/281.patch

The pull request has been authored by one of the Fedora riscv64
porters and the Fedora riscv64 port already uses this patchset. 
It would be great if you could add the patchset to the Debian
libffi package as well.

The RISC-V support provided by the patchset is not all-encompassing
(please cf. the last comment from Stefan O'Rear in the pull
request), but it provides the same amount of features that libffi
has for a number of other Debian-supported architectures, so that
shouldn't be a problem.  The symbols file would need to be
adjusted, though:

dh_makeshlibs -plibffi7 --add-udeb=libffi7-udeb
dpkg-gensymbols: warning: some symbols or patterns disappeared in the symbols 
file: see diff output below
dpkg-gensymbols: warning: debian/libffi7/DEBIAN/symbols doesn't match 
completely debian/libffi7.symbols
--- debian/libffi7.symbols (libffi7_3.3~20180131-2_riscv64)
+++ dpkg-gensymbols50ytax   2018-03-06 21:11:57.533480937 +
@@ -2,5 +2,5 @@
  (symver)LIBFFI_BASE_7.0 3.3~20170512
  (symver)LIBFFI_BASE_7.1 3.3~20170512
  (symver)LIBFFI_CLOSURE_7.0 3.3~20170512
- (symver|arch=!hppa !ia64 !m68k !mips !mipsel !mips64el !powerpc !powerpcspe 
!ppc64 !ppc64el !sh4)LIBFFI_COMPLEX_7.0 3.3~20170512
- (symver|arch=!hppa !ia64 !m68k !sh4)LIBFFI_GO_CLOSURE_7.0 3.3~20170512
+#MISSING: 3.3~20180131-2# (symver|arch=!hppa !ia64 !m68k !mips !mipsel 
!mips64el !powerpc !powerpcspe !ppc64 !ppc64el !sh4)LIBFFI_COMPLEX_7.0 
3.3~20170512
+#MISSING: 3.3~20180131-2# (symver|arch=!hppa !ia64 !m68k 
!sh4)LIBFFI_GO_CLOSURE_7.0 3.3~20170512

Regards,
Karsten
-- 
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.