Bug#822489: armhf ABI detection crashing ldconfig on arm64
On 2016-04-26 00:33, Steve McIntyre wrote: > On Mon, Apr 25, 2016 at 09:57:00AM +0200, Aurelien Jarno wrote: > >On 2016-04-25 00:30, Steve McIntyre wrote: > >> Package: libc6-bin > >> Severity: serious > >> Version: 2.22-7 > >> Tags: patch > >> > >> Hi folks, > >> > >> Steev has reported some crashing using ldconfig on arm64 systems with > >> armhf added as a secondary architecture - he's using this config in > >> Kali, for example. > >> > >> Working through the problem with him on #debian-arm, I can see that > >> it's a problem with our/my patch for ARM ABI detection. On older > >> binaries that predate the new ABI flags in the ELF header, we're still > >> parsing the ARM attributes. That works fine on armel/armhf, but on > >> arm64 this code is being built wrongly using native (ELF64) > >> types. This patch is the obvious fix - enforce using ELF32 types for > >> all arches. > > > >You have the same code in unsubmitted-ldconfig-cache-abi.diff, so I > >guess it also have to be patched? > > Ah, yes - good point. I'd not considered that yet. Hmmm, pondering > some more... > > No, we're safe here. In *that* case, we're running inside the armhf > (or armel) version of ld.so, *not* in the arm64 version. There's no > problem there. Does that make sense to you? Ok, thanks for looking. > >> It seems that we still have some older packages without the ABI flags > >> attached - libshout3 is one such. :-( > > > >Frankly we are keeping "temporary" hacks for quite too long on armhf. I > >would like to drop the following patches after the Stretch release: > > > >- local-soname-hack.diff > > Can go away easily I think, yes. The old soname should already be > history now. Ok. > >- unsubmitted-ldconfig-cache-abi.diff > > Should go away after stretch, agreed. > > >- unsubmitted-ldso-abi-check.diff > >- unsubmitted-ldso-multilib.diff > > U. I don't think these two can go away *at all* without breaking > multi-arch on ARM. > > The first one could do with updating to use the new ARM ABI float > flags in preference to the old, slow ARM attributes scan (as an > optimisation), but the concept isn't going to change. > > The second one is also necessary to deal with finding two different > float ABIs in the ld.so cache. Ok. Do you think these patches can be upstreamed then? > >Could you please ensure that all the binaries in the archive that still > >needs these patches are rebuilt? > > I'll look again for broken/old stuff. I thought you'd already pushed > binNMUs for everything outstanding, though?? I have done that for the local-soname-hack.diff patch. According to my list the only remaining binaries are the following ones: argus-client_2.0.6.fixes.1-3 cuba_3.0+2024-2 icebreaker_1.21-11 ipkungfu_0.6.1-6 isakmpd_20041012-7.2 libprinterconf_0.5-12 nget_0.27.1-11 They are not in stretch anymore, so we should just make sure they are removed from sid before we can drop the patch. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
Bug#822489: armhf ABI detection crashing ldconfig on arm64
On Tue, Apr 26, 2016 at 12:33:38AM +0100, Steve McIntyre wrote: >On Mon, Apr 25, 2016 at 09:57:00AM +0200, Aurelien Jarno wrote: > >>Could you please ensure that all the binaries in the archive that still >>needs these patches are rebuilt? > >I'll look again for broken/old stuff. I thought you'd already pushed >binNMUs for everything outstanding, though?? And checking my archive, that was just for the linker path in fact. I'm re-scanning all armel and armhf binary packages in unstable right now for all the following: linker path (armhf) fp ABI flags (both) I'll report the results in the morning when it's done. -- Steve McIntyre, Cambridge, UK.st...@einval.com Support the Campaign for Audiovisual Free Expression: http://www.eff.org/cafe/
Bug#822489: armhf ABI detection crashing ldconfig on arm64
On Mon, Apr 25, 2016 at 09:57:00AM +0200, Aurelien Jarno wrote: >On 2016-04-25 00:30, Steve McIntyre wrote: >> Package: libc6-bin >> Severity: serious >> Version: 2.22-7 >> Tags: patch >> >> Hi folks, >> >> Steev has reported some crashing using ldconfig on arm64 systems with >> armhf added as a secondary architecture - he's using this config in >> Kali, for example. >> >> Working through the problem with him on #debian-arm, I can see that >> it's a problem with our/my patch for ARM ABI detection. On older >> binaries that predate the new ABI flags in the ELF header, we're still >> parsing the ARM attributes. That works fine on armel/armhf, but on >> arm64 this code is being built wrongly using native (ELF64) >> types. This patch is the obvious fix - enforce using ELF32 types for >> all arches. > >You have the same code in unsubmitted-ldconfig-cache-abi.diff, so I >guess it also have to be patched? Ah, yes - good point. I'd not considered that yet. Hmmm, pondering some more... No, we're safe here. In *that* case, we're running inside the armhf (or armel) version of ld.so, *not* in the arm64 version. There's no problem there. Does that make sense to you? >> It seems that we still have some older packages without the ABI flags >> attached - libshout3 is one such. :-( > >Frankly we are keeping "temporary" hacks for quite too long on armhf. I >would like to drop the following patches after the Stretch release: > >- local-soname-hack.diff Can go away easily I think, yes. The old soname should already be history now. >- unsubmitted-ldconfig-cache-abi.diff Should go away after stretch, agreed. >- unsubmitted-ldso-abi-check.diff >- unsubmitted-ldso-multilib.diff U. I don't think these two can go away *at all* without breaking multi-arch on ARM. The first one could do with updating to use the new ARM ABI float flags in preference to the old, slow ARM attributes scan (as an optimisation), but the concept isn't going to change. The second one is also necessary to deal with finding two different float ABIs in the ld.so cache. >Could you please ensure that all the binaries in the archive that still >needs these patches are rebuilt? I'll look again for broken/old stuff. I thought you'd already pushed binNMUs for everything outstanding, though?? Also: the -- Steve McIntyre, Cambridge, UK.st...@einval.com Is there anybody out there?
Bug#822489: armhf ABI detection crashing ldconfig on arm64
On 2016-04-25 00:30, Steve McIntyre wrote: > Package: libc6-bin > Severity: serious > Version: 2.22-7 > Tags: patch > > Hi folks, > > Steev has reported some crashing using ldconfig on arm64 systems with > armhf added as a secondary architecture - he's using this config in > Kali, for example. > > Working through the problem with him on #debian-arm, I can see that > it's a problem with our/my patch for ARM ABI detection. On older > binaries that predate the new ABI flags in the ELF header, we're still > parsing the ARM attributes. That works fine on armel/armhf, but on > arm64 this code is being built wrongly using native (ELF64) > types. This patch is the obvious fix - enforce using ELF32 types for > all arches. You have the same code in unsubmitted-ldconfig-cache-abi.diff, so I guess it also have to be patched? > It seems that we still have some older packages without the ABI flags > attached - libshout3 is one such. :-( Frankly we are keeping "temporary" hacks for quite too long on armhf. I would like to drop the following patches after the Stretch release: - local-soname-hack.diff - unsubmitted-ldconfig-cache-abi.diff - unsubmitted-ldso-abi-check.diff - unsubmitted-ldso-multilib.diff Could you please ensure that all the binaries in the archive that still needs these patches are rebuilt? Thanks, Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
