Processed: Re: Bug#824442: and conflict needs to be resolved

[Debian Bug Tracking System]

Processing control commands:

> severity -1 important
Bug #860013 [linux] linux: libc-compat.h sets __UAPI_DEF_IF_* to 1 even when 
if.h hasn't been included
Severity set to 'important' from 'serious'
> severity 824442 important
Bug #824442 [src:glibc]  and  conflict needs to be 
resolved
Severity set to 'important' from 'serious'

-- 
824442: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824442
860013: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860013
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#824442: and conflict needs to be resolved

[Aurelien Jarno]

tag 824442 - pending
clone 824442 -1
reassign -1 linux
retitle -1 linux: libc-compat.h sets __UAPI_DEF_IF_* to 1 even when if.h hasn't 
been included
thanks

> On 2017-03-04 17:23, Niels Thykier wrote:
> > On Tue, 14 Feb 2017 20:36:43 +0100 Aurelien Jarno 
> > wrote:
> > > [...]
> > > 
> > > Now that the change have been done on the kernel side, the bug is not
> > > really visible anymore, so nobody really cared about this bug.
> > > 
> > > I'll see if I can come with a patch in the next days.
> > > 
> > > Aurelien
> > > 
> > > -- 
> > > Aurelien Jarno  GPG: 4096R/1DDD8C9B
> > > aurel...@aurel32.net http://www.aurel32.net
> > > 
> > > 
> > 
> > Thanks for the reply.  I am looking forward to the patch. :)
> 
> I have opened a bug upstream and sent a patch to the libc-alpha mailing
> list. I'll include the patch in the next upload, either today or
> tomorrow.

Unfortunately I have been pointed on the libc-alpha mailing list that
it doesn't work if another file which includes 
(e.g. ) is included before . The problem is
that the __UAPI_DEF_IF_* constants are set to 1 in 
even if  is not included.

Even if we are able to workaround that on the glibc side (for example
by checking for _LINUX_IF_H), the following sequence doesn't work:
  #include 
  #include 
  #include 

In that case  tries to redefine the same enum and struct
already defined by , which is obviously a kernel header bug.

I am therefore cloning this bug to the kernel headers. A fix is needed
on both sides.

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net

Processed: Re: Bug#824442: and conflict needs to be resolved

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tag 824442 - pending
Bug #824442 [src:glibc]  and  conflict needs to be 
resolved
Removed tag(s) pending.
> clone 824442 -1
Bug #824442 [src:glibc]  and  conflict needs to be 
resolved
Bug 824442 cloned as bug 860013
> reassign -1 linux
Bug #860013 [src:glibc]  and  conflict needs to be 
resolved
Bug reassigned from package 'src:glibc' to 'linux'.
Ignoring request to alter found versions of bug #860013 to the same values 
previously set
Ignoring request to alter fixed versions of bug #860013 to the same values 
previously set
> retitle -1 linux: libc-compat.h sets __UAPI_DEF_IF_* to 1 even when if.h 
> hasn't been included
Bug #860013 [linux]  and  conflict needs to be resolved
Changed Bug title to 'linux: libc-compat.h sets __UAPI_DEF_IF_* to 1 even when 
if.h hasn't been included' from ' and  conflict needs to 
be resolved'.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
824442: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824442
860013: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860013
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#824442: and conflict needs to be resolved

[Aurelien Jarno]

control: forwarded -1 https://sourceware.org/bugzilla/show_bug.cgi?id=21367

On 2017-03-04 17:23, Niels Thykier wrote:
> On Tue, 14 Feb 2017 20:36:43 +0100 Aurelien Jarno 
> wrote:
> > [...]
> > 
> > Now that the change have been done on the kernel side, the bug is not
> > really visible anymore, so nobody really cared about this bug.
> > 
> > I'll see if I can come with a patch in the next days.
> > 
> > Aurelien
> > 
> > -- 
> > Aurelien Jarno  GPG: 4096R/1DDD8C9B
> > aurel...@aurel32.net http://www.aurel32.net
> > 
> > 
> 
> Thanks for the reply.  I am looking forward to the patch. :)

I have opened a bug upstream and sent a patch to the libc-alpha mailing
list. I'll include the patch in the next upload, either today or
tomorrow.

Ben, you probably want to backport commit 2618be7dccf87 to the 4.9
kernel to make this patch actually useful.

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net

Processed: Re: Bug#824442: and conflict needs to be resolved

[Debian Bug Tracking System]

Processing control commands:

> forwarded -1 https://sourceware.org/bugzilla/show_bug.cgi?id=21367
Bug #824442 [src:glibc]  and  conflict needs to be 
resolved
Set Bug forwarded-to-address to 
'https://sourceware.org/bugzilla/show_bug.cgi?id=21367'.

-- 
824442: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824442
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#824442: and conflict needs to be resolved

[Niels Thykier]

On Tue, 14 Feb 2017 20:36:43 +0100 Aurelien Jarno 
wrote:
> [...]
> 
> Now that the change have been done on the kernel side, the bug is not
> really visible anymore, so nobody really cared about this bug.
> 
> I'll see if I can come with a patch in the next days.
> 
> Aurelien
> 
> -- 
> Aurelien Jarno  GPG: 4096R/1DDD8C9B
> aurel...@aurel32.net http://www.aurel32.net
> 
> 

Thanks for the reply.  I am looking forward to the patch. :)

Forgot to mention, please CC me on replies :)

Thanks,
~Niels

Bug#824442: and conflict needs to be resolved

[Aurelien Jarno]

On 2017-02-11 05:44, Niels Thykier wrote:
> On Mon, 16 May 2016 03:12:51 +0100 Ben Hutchings 
> wrote:
> > Source: glibc
> > Version: 2.22-7
> > Severity: serious
> > 
> > (Continued from bug #822393.)
> > 
> > glibc's  should check whether  has already been
> > included and, if so, avoid making conflicting definitions.
> > 
> > Including the headers in the opposite order works since this change in
> > Linux 4.6:
> > https://git.kernel.org/linus/4a91cb61bb995e5571098188092e296192309c77
> > 
> > Ben.
> > 
> > -- 
> > Ben Hutchings
> > 73.46% of all statistics are made up.
> 
> Hi,
> 
> Any news on this bug?

Now that the change have been done on the kernel side, the bug is not
really visible anymore, so nobody really cared about this bug.

I'll see if I can come with a patch in the next days.

Aurelien

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net

Bug#824442: and conflict needs to be resolved

[Niels Thykier]

On Mon, 16 May 2016 03:12:51 +0100 Ben Hutchings 
wrote:
> Source: glibc
> Version: 2.22-7
> Severity: serious
> 
> (Continued from bug #822393.)
> 
> glibc's  should check whether  has already been
> included and, if so, avoid making conflicting definitions.
> 
> Including the headers in the opposite order works since this change in
> Linux 4.6:
> https://git.kernel.org/linus/4a91cb61bb995e5571098188092e296192309c77
> 
> Ben.
> 
> -- 
> Ben Hutchings
> 73.46% of all statistics are made up.

Hi,

Any news on this bug?

~Niels

Bug#824442: and conflict needs to be resolved

[Ben Hutchings]

Source: glibc
Version: 2.22-7
Severity: serious

(Continued from bug #822393.)

glibc's  should check whether  has already been
included and, if so, avoid making conflicting definitions.

Including the headers in the opposite order works since this change in
Linux 4.6:
https://git.kernel.org/linus/4a91cb61bb995e5571098188092e296192309c77

Ben.

-- 
Ben Hutchings
73.46% of all statistics are made up.


signature.asc
Description: This is a digitally signed message part