Re: Bug#959829: [covid-19] Help needed to finalise bazel predependency google-api-client-java
Hi, On Wed, Jun 17, 2020 at 02:12:09PM -0400, Olek Wojnar wrote: > > That was easy. I have pushed my changes to "sudip" which now builds > > only those two. > > Great, thanks! Yep. > Good catch, thanks! The repo should be named google-api-client-java for > consistency with the rest of the ecosystem. (And Debian Java policy) Name fixed and uploaded to experimental. Thanks to all who helped Andreas. -- http://fam-tille.de
Re: Bug#959829: [covid-19] Help needed to finalise bazel predependency google-api-client-java
Hi Sudip, On Wed, Jun 17, 2020, 13:38 Sudip Mukherjee wrote: > > That was easy. I have pushed my changes to "sudip" which now builds > only those two. > Great, thanks! And, just noticed (after pushing) that the Vcs in d/control is wrong. > It should be https://salsa.debian.org/java-team/google-api-java-client > or the repo needs to be renamed. > Good catch, thanks! The repo should be named google-api-client-java for consistency with the rest of the ecosystem. (And Debian Java policy) -Olek PS I suppose one could theoretically do google-api-java-client-java but I think that's needlessly awkward and repetitive.
Re: Bug#959829: [covid-19] Help needed to finalise bazel predependency google-api-client-java
On Wed, Jun 17, 2020 at 5:40 PM Olek Wojnar wrote: > > On Wed, Jun 17, 2020 at 12:19 PM Andreas Tille wrote: >> >> I have the feeling we are coming closer to a solution iteratively now >> but there are some remaining errors unfortunately: > > > If any of you have a moment, I recommend patching the main pom.xml to only > build the two modules that we need (google-api-client and > google-api-client-jackson2). That should vastly simplify things. That was easy. I have pushed my changes to "sudip" which now builds only those two. And, just noticed (after pushing) that the Vcs in d/control is wrong. It should be https://salsa.debian.org/java-team/google-api-java-client or the repo needs to be renamed. -- Regards Sudip
Re: Bug#959829: [covid-19] Help needed to finalise bazel predependency google-api-client-java
On Wed, Jun 17, 2020 at 12:19 PM Andreas Tille wrote: > I have the feeling we are coming closer to a solution iteratively now > but there are some remaining errors unfortunately: > If any of you have a moment, I recommend patching the main pom.xml to only build the two modules that we need (google-api-client and google-api-client-jackson2). That should vastly simplify things. -Olek
Re: Bug#959829: [covid-19] Help needed to finalise bazel predependency google-api-client-java
Hi Sudip, On Wed, Jun 17, 2020 at 11:42:52AM +0100, Sudip Mukherjee wrote: > > I have taken the liberty to push to "tmancill" branch and the issue As I tried to express: I wished you all would take the freedom to simply push to the master branch which is perfectly fine for me. ;-) Thanks a lot for providing some fix in any case! > with "com.google.api.client.util" is now resolved. It needs to depend > on "libgoogle-oauth-client-java" which is still in NEW. I've a local repository and can deal with this. > But, it now fails with: > > google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java:[435,16] > cannot find symbol > [ERROR] symbol: method setResponseReturnRawInputStream(boolean) > [ERROR] location: variable httpRequest of type > com.google.api.client.http.HttpRequest > > And, indeed > https://salsa.debian.org/java-team/google-http-client-java/-/blob/master/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java > is not having the method "setResponseReturnRawInputStream". And, it > seems the packaged version of libgoogle-http-client-java in Debian is > 1.27 and "setResponseReturnRawInputStream" was added in v1.29.0. So, > we will need to update libgoogle-http-client-java to 1.29.0 atleast. I somehow ignored Olek's hint that we should rather start with version 1.27 to avoid issues with circular (and more) dependencies. That's why I downgraded the version in Git now and merged tmancill branch to master. I have the feeling we are coming closer to a solution iteratively now but there are some remaining errors unfortunately: ... [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ google-api-client --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 27 source files to /build/google-api-client-java-1.27.1/google-api-client/target/test-classes [INFO] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java: Some input files use or override a deprecated API. [INFO] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java: Recompile with -Xlint:deprecation for details. [INFO] - [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[29,38] package com.google.api.client.protobuf does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[182,43] package ErrorOutput does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[192,38] package ErrorOutput does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[228,39] package MockData does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[235,35] package MockData does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[244,39] package MockData does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[251,35] package MockData does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/CloudShellCredentialTest.java:[36,39] package com.google.api.client.json.gson does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/GoogleClientSecretsTest.java:[18,39] package com.google.api.client.json.gson does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[196,20] package ErrorOutput does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[207,25] package ErrorOutput does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[333,50] package MockData does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java:[339,50] package MockData does not exist [ERROR] /build/google-api-client-java-1.27.1/google-api-client/src/test/java/com/google/
Re: Bug#959829: [covid-19] Help needed to finalise bazel predependency google-api-client-java
On Wed, Jun 17, 2020 at 9:13 AM Andreas Tille wrote: > > Hi Tony, > > On Tue, Jun 16, 2020 at 09:34:20PM -0700, tony mancill wrote: > > > > I've pushed a "tmancill" branch to the Salsa repo that gets us further > > along. I have taken the liberty to push to "tmancill" branch and the issue with "com.google.api.client.util" is now resolved. It needs to depend on "libgoogle-oauth-client-java" which is still in NEW. But, it now fails with: google-api-client/src/main/java/com/google/api/client/googleapis/services/AbstractGoogleClientRequest.java:[435,16] cannot find symbol [ERROR] symbol: method setResponseReturnRawInputStream(boolean) [ERROR] location: variable httpRequest of type com.google.api.client.http.HttpRequest And, indeed https://salsa.debian.org/java-team/google-http-client-java/-/blob/master/google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java is not having the method "setResponseReturnRawInputStream". And, it seems the packaged version of libgoogle-http-client-java in Debian is 1.27 and "setResponseReturnRawInputStream" was added in v1.29.0. So, we will need to update libgoogle-http-client-java to 1.29.0 atleast. -- Regards Sudip
Re: Bug#959829: [covid-19] Help needed to finalise bazel predependency google-api-client-java
Hi Tony, On Tue, Jun 16, 2020 at 09:34:20PM -0700, tony mancill wrote: > > I've pushed a "tmancill" branch to the Salsa repo that gets us further > along. Thanks a lot for your great help. I've merged your branch to master. Feel free to push right to master in future since I feel unable to do any changes creating any race condition. ;-) > At this point, the build is failing with this error: > >package com.google.api.client.util does not exist > > This Java package should be part of the google-http-java-client package. > I'm looking into why it's missing now. Your work is highly appreciated Andreas. -- http://fam-tille.de
Re: Bug#959829: [covid-19] Help needed to finalise bazel predependency google-api-client-java
Hi Olek, On Tue, Jun 16, 2020 at 05:01:37AM -0400, Olek Wojnar wrote: > > Good question! Due to some dependency issues, the bom artifacts are not > packaged. OK, that explains the issue ... > But you should be able to just depend on the non-bom pom files. ... but I'm to uneducated to implement your suggested solution. (Feel free to push and I keep on testing). Kind regards Andreas. -- http://fam-tille.de
