Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-07-07 Thread Matthias Klose
Am 05.07.2014 20:20, schrieb Emmanuel Bourg:
> Le 05/07/2014 18:13, Matthias Klose a écrit :
> 
>> You should use the ecj from the eclipse package, if you
>> need the exact upstream version, you should use org.eclipse.jdt.core from the
>> eclipse-platform-data package, and maybe split out the jar file into it's own
>> package.
> 
> Thank you for the advice but that's a lot of work for a library that
> could be simply shared between GCJ, Tomcat, Gradle, Scilab, Plexus,
> Commons JCI, Spring and JasperReports. Also note that upgrading the
> whole Eclipse platform is much more difficult than just upgrading the
> compiler.
> 
> I'd rather wait for upstream to fix the bug we identified and re-upload
> ecj 3.10.0 to unstable.

sorry, this is not an advice but a request.  I had to spend some time this
weekend to undo this upload, which I don't want to see repeated.

ecj is part of the java toolchain on some architectures, and from my point of
view it is more important to keep these working instead of updating to a new ecj
version.

I did point out a way forward to use a new org.eclipse.jdt.core by updating
eclipse.  If you don't have the time to do this, fine, but please don't mess
around with *my* time.

  Matthias


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53baac6b.8010...@debian.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-07-05 Thread Emmanuel Bourg
Le 05/07/2014 18:13, Matthias Klose a écrit :

> You should use the ecj from the eclipse package, if you
> need the exact upstream version, you should use org.eclipse.jdt.core from the
> eclipse-platform-data package, and maybe split out the jar file into it's own
> package.

Thank you for the advice but that's a lot of work for a library that
could be simply shared between GCJ, Tomcat, Gradle, Scilab, Plexus,
Commons JCI, Spring and JasperReports. Also note that upgrading the
whole Eclipse platform is much more difficult than just upgrading the
compiler.

I'd rather wait for upstream to fix the bug we identified and re-upload
ecj 3.10.0 to unstable.

Emmanuel Bourg


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53b841e3.8080...@apache.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-07-05 Thread Matthias Klose
Am 01.07.2014 00:09, schrieb Emmanuel Bourg:
> Le 30/06/2014 14:52, Matthias Klose a écrit :
> 
>> This breaks the gcj builds configured with --enable-java-maintainer mode. I
>> filed an RC issue, and planning to revert that upload next weekend.
> 
> If we can't get gcc and ecj 3.10 to work together I'd rather split ecj
> into an older version dedicated to gcc and an up to date version used by
> Tomcat and others. Simply reversing the update would hamper the
> integration of Java 8.

No, relying on ecj for Tomcat is the wrong thing.  This package has been there
for GCJ all the time.  You should use the ecj from the eclipse package, if you
need the exact upstream version, you should use org.eclipse.jdt.core from the
eclipse-platform-data package, and maybe split out the jar file into it's own
package.

Reverted back to 3.9 in unstable and uploaded 3.10 to experimental.

  Matthias


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53b82410.3070...@debian.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-07-03 Thread Emmanuel Bourg
This issue is caused by a bug in ecj 3.10 related to overridden methods
with a covariant return type. Here StringBuffer.class is missing bridge
methods matching the signature of the methods defined in the Appendable
class. javac and ecj 3.9 generate them properly. I reported the issue
upstream:

https://bugs.eclipse.org/438812

I tried to work around this issue by replacing 'name_sig->append' with
'name_sig->StringBuffer$append'. It compiles but break later in the
build process:

libtool: link: /home/ebourg/gcc/host-x86_64-linux-gnu/gcc/gcj
-B/home/ebourg/gcc/x86_64-linux-gnu/libjava/
-B/home/ebourg/gcc/host-x86_64-linux-gnu/gcc/
-B/home/packages/gcc/svn/jinstall/x86_64-linux-gnu/bin/
-B/home/packages/gcc/svn/jinstall/x86_64-linux-gnu/lib/ -isystem
/home/packages/gcc/svn/jinstall/x86_64-linux-gnu/include -isystem
/home/packages/gcc/svn/jinstall/x86_64-linux-gnu/sys-include
-fomit-frame-pointer -Usun -g -O2 -o .libs/jv-convert
--main=gnu.gcj.convert.Convert -shared-libgcc
-L/home/ebourg/gcc/x86_64-linux-gnu/libjava/.libs
-L/home/ebourg/gcc/x86_64-linux-gnu/libjava ./.libs/libgcj.so -lpthread
-lrt -ldl -Wl,-rpath -Wl,/home/packages/gcc/svn/jinstall/lib/../lib64
./.libs/libgcj.so: undefined reference to `java::lang::StringBuffer*
java::lang::StringBuffer::StringBuffer$append(wchar_t)'
collect2: error: ld returned 1 exit status

Emmanuel Bourg


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53b5689c.5020...@apache.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-07-01 Thread Matthias Klose
Am 30.06.2014 23:12, schrieb Emmanuel Bourg:
> Thank you for the log Matthias. Could you also detail the steps to
> reproduce this error please? I tried to build gcc with
> --enable-java-maintainer-mode but I didn't see this error (but my
> configure args were probably incomplete).

see libjava/HACKING.

 - you need the ecj1 and gjavah scripts

 - From "Import a new release", do "Remove the generated
   class and header files"

I configured with

# to install:
# libgstreamer0.10-dev libgstreamer-plugins-base0.10-dev libgconf2-dev 
libqt4-dev

triplet=x86_64-linux-gnu

#PATH=/scratch/packages/gcc/svn:$PATH
#export PATH
branch=gcc-4_9-branch
#branch=trunk
ecjjar=/home/packages/gcc/svn/ecj-4.9.jar
ecjjar=/usr/share/java/ecj.jar

../$branch/configure \
--prefix=/home/packages/gcc/svn/jinstall \
--enable-languages=c,c++,java \
--disable-multilib \
--enable-java-maintainer-mode \
--with-ecj-jar=$ecjjar \
--enable-gjdoc \
--enable-gconf-peer \
--enable-gstreamer-peer \
--enable-java-awt=gtk,qt,xlib \
--enable-gtk-cairo \
--build=$triplet \
--host=$triplet \
--target=$triplet \


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53b26b10.8010...@debian.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-06-30 Thread Emmanuel Bourg
Le 30/06/2014 14:52, Matthias Klose a écrit :

> This breaks the gcj builds configured with --enable-java-maintainer mode. I
> filed an RC issue, and planning to revert that upload next weekend.

If we can't get gcc and ecj 3.10 to work together I'd rather split ecj
into an older version dedicated to gcc and an up to date version used by
Tomcat and others. Simply reversing the update would hamper the
integration of Java 8.

Emmanuel Bourg


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53b1e016.2050...@apache.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-06-30 Thread Emmanuel Bourg
Thank you for the log Matthias. Could you also detail the steps to
reproduce this error please? I tried to build gcc with
--enable-java-maintainer-mode but I didn't see this error (but my
configure args were probably incomplete).

Emmanuel Bourg


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53b1d2db.1080...@apache.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-06-30 Thread Matthias Klose
Am 30.06.2014 15:05, schrieb Emmanuel Bourg:
> Le 30/06/2014 14:52, Matthias Klose a écrit :
> 
>> This breaks the gcj builds configured with --enable-java-maintainer mode. I
>> filed an RC issue, and planning to revert that upload next weekend.  Such
>> uploads should go to experimental first if at all.  I told Emmanuel about 
>> this
>> weeks before on irc, so I'm surprised about this upload.
> 
> Hi Matthias,
> 
> Do you have a log of the build failure please?
> 
> Emmanuel Bourg
> 

../../../gcc-4_9-branch/libjava/jni.cc: In function '_Jv_Method*
_Jv_JNI_GetAnyMethodID(JNIEnv*, jclass, const char*, const char*)':
../../../gcc-4_9-branch/libjava/jni.cc:760:36: error: call of overloaded
'append(jchar&)' is ambiguous
   name_sig->append ((jchar) ' ');
^
../../../gcc-4_9-branch/libjava/jni.cc:760:36: note: candidates are:
In file included from ../../../gcc-4_9-branch/libjava/jni.cc:34:0:
../../../gcc-4_9-branch/libjava/java/lang/StringBuffer.h:90:40: note: virtual
java::lang::AbstractStringBuffer* java::lang::StringBuffer::append(jdouble)
   ::java::lang::AbstractStringBuffer * append(jdouble);
^
../../../gcc-4_9-branch/libjava/java/lang/StringBuffer.h:91:40: note: virtual
java::lang::AbstractStringBuffer* java::lang::StringBuffer::append(jfloat)
   ::java::lang::AbstractStringBuffer * append(jfloat);
^
../../../gcc-4_9-branch/libjava/java/lang/StringBuffer.h:92:40: note: virtual
java::lang::AbstractStringBuffer* java::lang::StringBuffer::append(jlong)
   ::java::lang::AbstractStringBuffer * append(jlong);
^
../../../gcc-4_9-branch/libjava/java/lang/StringBuffer.h:93:40: note: virtual
java::lang::AbstractStringBuffer* java::lang::StringBuffer::append(jint)
   ::java::lang::AbstractStringBuffer * append(jint);
^
../../../gcc-4_9-branch/libjava/java/lang/StringBuffer.h:97:40: note: virtual
java::lang::AbstractStringBuffer* java::lang::StringBuffer::append(jboolean)
   ::java::lang::AbstractStringBuffer * append(jboolean);
^
Makefile:9930: recipe for target 'jni.lo' failed
make[3]: *** [jni.lo] Error 1

which differs when using the ecj 3.10 jar to regenerate the header files

$ svn diff libjava/java/lang/StringBuffer.h
Index: libjava/java/lang/StringBuffer.h
===
--- libjava/java/lang/StringBuffer.h(revision 212141)
+++ libjava/java/lang/StringBuffer.h(working copy)
@@ -91,11 +91,8 @@
   ::java::lang::AbstractStringBuffer * append(jfloat);
   ::java::lang::AbstractStringBuffer * append(jlong);
   ::java::lang::AbstractStringBuffer * append(jint);
-  ::java::lang::Appendable * append(::java::lang::CharSequence *, jint, jint);
   ::java::lang::AbstractStringBuffer *
AbstractStringBuffer$append(::java::lang::CharSequence *, jint, jint);
-  ::java::lang::Appendable * append(::java::lang::CharSequence *);
   ::java::lang::AbstractStringBuffer *
AbstractStringBuffer$append(::java::lang::CharSequence *);
-  ::java::lang::Appendable * append(jchar);
   ::java::lang::AbstractStringBuffer * AbstractStringBuffer$append(jchar);
   ::java::lang::AbstractStringBuffer * append(jboolean);
   ::java::lang::AbstractStringBuffer * append(JArray< jchar > *, jint, jint);


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53b16cc0.3010...@debian.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-06-30 Thread Emmanuel Bourg
Le 30/06/2014 14:52, Matthias Klose a écrit :

> This breaks the gcj builds configured with --enable-java-maintainer mode. I
> filed an RC issue, and planning to revert that upload next weekend.  Such
> uploads should go to experimental first if at all.  I told Emmanuel about this
> weeks before on irc, so I'm surprised about this upload.

Hi Matthias,

Do you have a log of the build failure please?

Emmanuel Bourg


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53b160b1.30...@apache.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-06-30 Thread Matthias Klose
Am 28.06.2014 06:33, schrieb tony mancill:
> On 06/26/2014 09:10 AM, Emmanuel Bourg wrote:
>> Hi all,
>> 
>> I packaged the latest version of the Eclipse Compiler for Java and I'm 
>> looking for a sponsor to upload it. This is the first release supporting 
>> the new Java 8 syntax. This update will fix 4 build failures with OpenJDK
>> 8 (eclipse-egit, eclipse-emf, eclipse-wtp and eclipse-xsd. Unfortunately
>> eclipse and eclipse-cdt are still broken).
>> 
>> This package wasn't managed in a VCS yet, so I created a new repository:
>> 
>> https://alioth.debian.org/anonscm/git/pkg-java/ecj.git
> 
> Uploaded and tagged in git.

This breaks the gcj builds configured with --enable-java-maintainer mode. I
filed an RC issue, and planning to revert that upload next weekend.  Such
uploads should go to experimental first if at all.  I told Emmanuel about this
weeks before on irc, so I'm surprised about this upload.


-- 
To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/53b15da7.20...@debian.org



Re: RFS: ecj/3.10.0-1 - [UPLOADED]

2014-06-27 Thread tony mancill
On 06/26/2014 09:10 AM, Emmanuel Bourg wrote:
> Hi all,
> 
> I packaged the latest version of the Eclipse Compiler for Java and I'm
> looking for a sponsor to upload it. This is the first release supporting
> the new Java 8 syntax. This update will fix 4 build failures with
> OpenJDK 8 (eclipse-egit, eclipse-emf, eclipse-wtp and eclipse-xsd.
> Unfortunately eclipse and eclipse-cdt are still broken).
> 
> This package wasn't managed in a VCS yet, so I created a new repository:
> 
> https://alioth.debian.org/anonscm/git/pkg-java/ecj.git

Uploaded and tagged in git.

Cheers,
tony




signature.asc
Description: OpenPGP digital signature