Bug#782561: please backport commit ccfe8c3f7e52 from upstream

2015-04-20 Thread Herbert Xu
On Mon, Apr 20, 2015 at 09:17:22AM +0200, Romain Francoise wrote:

 For example, here's a photo I took of the crash on 3.18.4:
 
  https://orebokech.com/tmp/IMG_20150129_181653.jpg

OK I have reviewed this and indeed it does appear that the bug
can be triggered.  The trick appears to be making sure that your
input packet is fragmented.  That should then activate the kmalloc
path and lead to the memory corruption.

Thanks,
-- 
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/20150420072648.ga19...@gondor.apana.org.au



Bug#485070: cryptsetup: FATAL padlock_{aes,sha} error during boot

2011-07-30 Thread Herbert Xu
Ralf Jung ralfjun...@gmx.de wrote:
 Hi,
 
 as per request of Jonathan at http://bugs.debian.org/cgi-
 bin/bugreport.cgi?bug=485070, I am reporting the mentioned bug to this list 
 as 
 well:
 
 With current Debian testing (Kernel 2.6.39), I am getting this error on each 
 boot:
 FATAL: Error inserting padlock_sha (/lib/modules/2.6.39-2-
 amd64/kernel/drivers/crypto/padlock-sha.ko): No such device
 I understand it is harmless, but it should still be fixed since it irritates 
 users suggesting something is seriously going wrong.

That message comes from user-space and needs to be fixed there.

Cheers,
-- 
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110730061307.ga24...@gondor.apana.org.au



Bug#596802: linux-image-2.6.32-5-xen-amd64: oops in skb_gso_segment

2010-09-15 Thread Herbert Xu
On Wed, Sep 15, 2010 at 02:12:03AM +0100, Ben Hutchings wrote:
 Herbert,
 
 Does the warning below look like a symptom of the bug you fixed with
 this commit?

Yes it does look like.

Cheers,
-- 
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20100915064936.gb21...@gondor.apana.org.au



Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2010-01-23 Thread Herbert Xu
Ben Hutchings b...@decadent.org.uk wrote:
 
 Based on the TCP sequence numbers, it seems that the length of the
 broken packet is correct but its IP header is wrong.
 
 My understanding is that the length of the TCP payload in a GSO skb must
 always be a multiple of the gso_size, so that hardware is not required
 to adjust length fields.  So I see several possible explanations:

No, there is no such requirement.  The trailer skb can be of any
size less than or equal to gso_size.

However, if the hardware assumed this then yes it would explain
the problem.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#478166: linux-image-2.6.24-1-686: airo hang when loading because of aes

2009-06-01 Thread Herbert Xu
Ben Hutchings b...@decadent.org.uk wrote:
 
 I believe geode_aes can be fixed by either (1) removing the MODULE_ALIAS
 declaration or (2) making the module initialisation function fail if the
 device is not present.  The latter behaviour is generally wrong for PCI
 drivers, but this device presumably cannot be hotplugged.

I was going to remove this alias but found that it was already
removed two years ago.  Please revise your theory based on this
new discovery :)
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#272351: 2.2.25 has security issues, 2.2.26 available

2004-09-19 Thread Herbert Xu
Martin Michlmayr [EMAIL PROTECTED] wrote:
 Package: kernel-source-2.2.25
 Severity: important
 Tags: security
 
 2.2.26 fixes some security issues.  I don't know how severe they are
 so I'm filing this bug as 'important' but it may just as well be RC.

All of the security fixes in 2.2.26 are already in the Debian 2.2.25
package.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#272139: /sys/block names are mangled with '!' in current 2.6 kernels, not '.'

2004-09-17 Thread Herbert Xu
Martin Michlmayr [EMAIL PROTECTED] wrote:

 +   for separator in . !; do

You should try the new separator first, i.e., `!' and then `.'.
Otherwise this'll break once people start putting dots in the names.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#263169: initrd-tools orphaned?

2004-09-16 Thread Herbert Xu
On Wed, Sep 15, 2004 at 05:28:22PM +0200, Harald Dunkel wrote:

 The right solution in general is to establish a way to get the list of
 SCSI drivers loaded in the system sorted in the order by which they
 were loaded.
 
 This sequence is written down nowhere, AFAIK, so there is nothing
 to get.

It is (was) written down in /proc/scsi.  The ordering of the subdirectories
correspond directly to their load order.  The ordering in /proc/modules
is fine as well, except that you need to reverse it.

However, /proc/modules is fundamentally broken because it prevents
someone from installing an initrd kernel while running a kernel with the
driver built-in.

 Probably you would agree that it is sufficient to generate the
 same load sequence for all IDE, SCSI, and SATA devices on each
 reboot. If all these modules are loaded by the initrd boot script,
 then this sequence is completely under control of the initrd-tools,
 regardless of the module load history of the currently running
 kernel.

You can't assume that they are all loaded by the initrd.  You must
consider users with the drivers built-in as well users who load
modules after root has been mounted.  How else is someone going to
install an initrd kernel while running a non-initrd kernel?

 The scsi modules found via /proc/modules are _appended_ to
 the list of modules found so far. The sequence of modules
 found before mkinitrd looked into /proc/modules is not changed.
 It doesn't get worse, AFAICS. ALATBSOL.

This is broken.  For example, on a machine that boots of SATA while
also having another SCSI card with a disk attached, doing this will
cause the non-SATA SCSI disk to become /dev/sda.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#249978: kernel-package: Could we have kernel-image packages check for anything but build on install?

2004-09-14 Thread Herbert Xu
Manoj Srivastava [EMAIL PROTECTED] wrote:

 to make this kind of a change; but the current practice of shipping
 the conflicting build file in the headers packages _without_
 conflicting with the image packages must stop.

But nobody is doing that.  For official kernel-image packages, the
build symlink is not included.  For unofficial kernel-headers packages,
the build symlink also doesn't exist.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#270941: depmod: Can't open /stor/usr-src/linux/debian/tmp-image/lib/modules/extra/modules.dep for writing

2004-09-10 Thread Herbert Xu
Horms [EMAIL PROTECTED] wrote:

 cd /stor/usr-src/linux/debian/tmp-image/lib/modules/2.4.27; \
   ^^

 /stor/usr-src/linux/debian/tmp-image/lib/modules/extra/modules.dep for
^
 writing

See the problem?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Bug#269648: kernel-kbuild-2.6-2: Build-depends on kernel-source-2.6.5

2004-09-03 Thread Herbert Xu
On Fri, Sep 03, 2004 at 04:21:15PM -0700, Joshua Kwan wrote:
 
 To the rest of the team (plus Herbert, CCed:)
 It seems, though, that we don't actually bother to Depend on this 
 package for any of our headers packages. Is it really necessary to have? 
 And why not ship it in the kernel-source package and have it provide a 
 kernel-kbuild-2.6 metapackage? That seems cleaner + transparent to me.

It was depended on by the kernel-headers packages.  Is this no longer
the case?

I did it that way to avoid the main kernel packages having a dependency
on glibc.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: kernel image question

2004-08-15 Thread Herbert Xu
On Sun, Aug 15, 2004 at 09:09:45PM -0400, Andres Salomon wrote:
 
 Would you mind explaining the purpose of config/default in debian's i386
 kernel image packages?  The config ends up in /usr/src/kernel-headers-

It was useful when glibc used the generic kernel-headers package.
In order for that to work, the kernel-headers package must contain
an autoconf.h which depends on having a .config file.  The .config
file is usually just the default config file for that architecture.
I didn't use the kernel's default directly since it tends to get
out-of-sync with what's actually in the kernel.

These days it isn't that useful anymore since glibc doesn't use
kernel-headers at all.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#265011: initrd-tools: Handle change to sysfs PCI IDE driver names

2004-08-11 Thread Herbert Xu
On Wed, Aug 11, 2004 at 01:13:19PM +0100, Martin Michlmayr wrote:
 * [EMAIL PROTECTED] [EMAIL PROTECTED] [2004-08-11 21:41]:
  This is a preemptive patch to deal with upcoming changes to the PCI
  IDE driver names exported via sysfs.  This may appear as early as
  2.6.9.
 
 I've seen Adrian Bunk's patches removin the spaces, but do you know
 the rationale for it?

It may be that spaces are hard to deal with in shell scripts.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#252464: please comment

2004-06-29 Thread Herbert Xu
On Tue, Jun 29, 2004 at 11:51:30AM +0200, Sven Luther wrote:
 
 | Ok, a bit late, but better late than never.
 |
 | You will find at :
 |
 | http://people.debian.org/~luther/mkinitrd.tgz
 |
 | a tarball containing the initrd, the output of the mkinitrd with sh -x,
 | as well as the content of /etc/mkinitrd which was used to generate it.

Thanks.

I suspect the problem is that you didn't have ext2 loaded when you were
building the initrd image.  Since mkinitrd doesn't use the type field in
/etc/fstab this means that ext2 will not get loaded at all.

The solution is to always append the types in /etc/fstab to the end
of /proc/filesystems.

Please try this patch.
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Index: mkinitrd
===
RCS file: /home/gondolin/herbert/src/CVS/debian/initrd-tools/mkinitrd,v
retrieving revision 1.203
diff -u -r1.203 mkinitrd
--- mkinitrd28 May 2004 10:14:33 -  1.203
+++ mkinitrd29 Jun 2004 11:53:00 -
@@ -607,15 +607,21 @@
set +f -- $ROOT
device=$1
type=$2
+
+   local fstabtype=
if [ $device = probe ]; then
local script root
 
script='
BEGIN { printf set --  }
/^#/ { next }
-   $2 == / { root = $1; next }
+   $2 == / { root = $1; type = $3; next }
$3 == swap { printf '\''%s'\'', $1 }
-   END { print ; print root= root }
+   END {
+   print 
+   print root= root
+   print fstabtype= type
+   }
'
root=
eval $(awk $script /etc/fstab)
@@ -632,7 +638,16 @@
fi
 
if [ -z $type ]; then
-   set -- $(awk -F '   ' '!$1 { print $2 }' /proc/filesystems)
+   set -- $(
+   {
+   awk -F '' '!$1 { print $2 }' \
+   /proc/filesystems
+   if [ -n $fstabtype ]; then
+   IFS=,
+   printf '%s\n' $fstabtype
+   fi
+   } | cat -n | sort -u -k 2,2 | sort -n | cut -f 2-
+   )
if [ $# -eq 0 ]; then
echo $PROG: Cannot determine root file system 2
exit 1


Re: Bug#247455: The istallion module prevents the machine from restarting.

2004-06-25 Thread Herbert Xu
On Fri, Jun 25, 2004 at 01:55:27AM +0300, Shaul Karl wrote:
 
 
   modorpbe --ignore-install istallion
 
 prevent the system from restarting. Which is consistent with my previous
 report.

OK.

This all points at the istallion driver, except for the fact that you
said that an ealier 2.6 kernels did not have this problem.  The
istallion driver haven't changed much for ages so this could still
be due to something else.

So can you please find the last 2.6 kernel that did work and tell
me what it was?

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Bug#247455: The istallion module prevents the machine from restarting.

2004-06-23 Thread Herbert Xu
On Tue, Jun 22, 2004 at 03:58:13PM +0300, Shaul Karl wrote:
 
   I do have that board installed. Currently I am using only 1 out of its
 32 ports. That port seems to work. I do intent to use more ports.

OK, can you please boot a clean system using init=/bin/bash, and
then load istallion without actually using it? If that still breaks
the reboot, we can start debugging the init code in it.

   Doesn't the following /proc/iomem output shows that I should have the
 64K starting at 0xe free for this module?

You mean the fact that istallion doesn't show up there? That's because
it's a legacy ISA device so the kernel doesn't know that it's there.
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: [SELINUX][PATCH 1/4] Fine-grained Netlink support - SELinux headers update

2004-06-16 Thread Herbert Xu
James Morris [EMAIL PROTECTED] wrote:
 
 The script lives in the SELinux policy compilation package, which is
 considered the source of truth for these headers.  They are only ever
 regenerated manually when significant changes are made to SELinux (like
 this), and I don't think there is any advantage in doing this in the
 kernel tree.

The Debian crowd might get into a fit over this with arguments over the
preferred form of modification and the GPL :)
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#247054: Crypto-root patch updated to initrd-tools 0.1.70

2004-06-07 Thread Herbert Xu
On Mon, Jun 07, 2004 at 01:15:21PM +0200, Wesley W. Terpstra wrote:
 
 This ... sucks. It means that we have to setup both in case the system is
 sometimes resumed, but other times rebooted properly. Have you used swsusp?

Well you can have swsusp under cryptoroot as a configuration option
that is disabled by default.  If it is enabled then yes you probably
do have to setup both.

   If so, I will update my patch and setup swsusp on my machine to test it.
 
 My stock debian 2.6.6 kernel blew oopses all over the place when I ran
 hibernate. Does this even work with 2.6? Crypto root is only supported by
 = 2.6.4, so maybe trying to get this to work doesn't make sense.

I've never used hibernate so I don't know whether it can start swsusp.

I simply do echo 4  /proc/acpi/sleep.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Bug#247054: Crypto-root patch updated to initrd-tools 0.1.70

2004-06-06 Thread Herbert Xu
On Sun, Jun 06, 2004 at 01:19:35AM +0200, Wesley W. Terpstra wrote:
 
 Why on earth is swap being configured in the initrd?!

Swap is used for swsusp.
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




Re: Bug#240812: RC bugs in Linux

2004-06-03 Thread Herbert Xu
On Thu, Jun 03, 2004 at 10:34:22AM +0200, Robert Millan wrote:
 
 What's the status with these bugs? There are 5 reported violations of the
 DFSG, from 65 to 53 days old.
 
 William, you're the current maintainer of the Debian packaged version of
 Linux (well, technicaly not yet, but I'm told you're dessignated for that
 task). These bugs should be your main priority for what Linux packaging is
 concerned. Which progress have you made? When do you expect to have this
 fixed?

I thought that the upcoming GR vote would have an effect on their RC
status.  That is the reason why I did not act on them while I was still
maintaining these packages.

Anthony, can you please clarify this? That is, does the upcoming GR vote
have a potential effect on whether these kernel DFSG issues are release
critical?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email:  Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt