Bug#752789: initramfs-tools: mkinitramfs doesn't honor /usr/share/initramfs-tools/modules

2014-09-29 Thread Lukas Anzinger
On Mon, Sep 29, 2014 at 7:47 PM, Ben Hutchings  wrote:
> I think the best way to deal with this would be to add a comment
> clarifying which file path is actually read.

Yes, that would be really helpful!


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CACB1Aevxtv8O1k=v2m9sqljx7fi5lww4q+q-buwc0x2cxlz...@mail.gmail.com



Bug#752789: initramfs-tools: mkinitramfs doesn't honor /usr/share/initramfs-tools/modules

2014-09-29 Thread Lukas Anzinger
On Mon, Sep 29, 2014 at 7:47 PM, Ben Hutchings  wrote:
> /usr/share/initramfs-tools/modules is the 'shipped' version of
> /etc/initramfs-tools/modules, and is copied to the latter file if it
> does not already exist.  The comment is of course correct in the copy.
> And user-edittable configuration files are always installed in /etc,
> not /usr.
>
> Normally we would include /etc/initramfs-tools/modules in the package as
> a conffile, and then dpkg would take care of preserving any customised
> version.  However, the installer may in some cases add modules to this
> file, which could result in dpkg later claiming that it's been edited by
> the user.
>
> I think the best way to deal with this would be to add a comment
> clarifying which file path is actually read.


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CACB1AevZMOD7c0b+edrFt9gY9iNQO4gjK5Wcb7jk0=hnnmx...@mail.gmail.com



Bug#751488: initramfs-tools: Shell spawned despite panic=0

2014-06-26 Thread Lukas Anzinger
Control: found -1 0.115

This bug is still present in the latest available version.

Regards,

Lukas


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/CACB1AevZvjWgF1dW9ho-vMS=dfq7faucsw-wok_q_hyeu8k...@mail.gmail.com



Bug#752789: initramfs-tools: mkinitramfs doesn't honor /usr/share/initramfs-tools/modules

2014-06-26 Thread Lukas Anzinger
Package: initramfs-tools
Version: 0.115
Severity: normal

Hi,

mkinitramfs (the tool that is called from update-initramfs) doesn't
honor /usr/share/initramfs-tools/modules, it only honors
/etc/initramfs-tools/modules and /usr/share/initramfs-tools/modules.d.

This is unfortunate because /usr/share/initramfs-tools/modules
explicitly states that the modules listed in that file are included in
the initramfs.

The file /usr/share/initramfs-tools/modules should therefore be either
added to the list of files that are processed or removed altogether.

Regards,

Lukas


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/cacb1aesjvdjpponjcmccegrjqus+wzqx-vy2+zd9uyav0ns...@mail.gmail.com



Bug#751488: initramfs-tools: Shell spawned despite panic=0

2014-06-13 Thread Lukas Anzinger
Package: initramfs-tools
Version: 0.109.1
Severity: critical
Tags: patch

Hi,

I've set panic=0 as a kernel cmdline argument which should trigger a
reboot instead of spawning a shell. However, the reboot seems to be
uneffective and a shell is spawned nevertheless. This is unpleasing
since spawn=0 is "marketed" as a security feature in
initramfs-tools(8):

panic sets an timeout on panic.  panic= is a documented
security feature: it disables the debug shell.

Output on screen:

Loading, please wait ...
Spawning shell within the initramfs
Rebooting automatically due to panic= boot argument


BusyBox v1.20.2 (Debian 1:1.20.0-7) built-in shell (ash)
Enter 'help' for a list of built-in commands.

/bin/sh: can't access tty; job control turned off
(initramfs) _

The commands halt, reboot, etc. don't work either.

To fix the security impact of an open shell I propose to at least add a
return after the reboot command so that if the reboot is effectively a
NOP still no shell is spawned.

diff --git a/scripts/functions b/scripts/functions
index 5352f1d..de64494 100644
--- a/scripts/functions
+++ b/scripts/functions
@@ -43,6 +43,7 @@ panic()
echo "Rebooting automatically due to panic= boot argument"
sleep ${panic}
reboot
+   return
fi
modprobe -v i8042 || true
modprobe -v atkbd || true

Regards,

Lukas


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/cacb1aesuy7boyp9q4z1taovla3udqb-h3vhwyruolgrq2w4...@mail.gmail.com



Bug#661696: [2.6.33.y] drm/i915: wrong fifo size due to uncareful refactoring which results in an xserver crash at 800x600

2012-06-25 Thread Lukas Anzinger
Hi Jonathan,

yes, it works for me!

Regards,

Lukas

On Sun, Jun 24, 2012 at 6:39 PM, Jonathan Nieder  wrote:
> forwarded 661696 https://bugzilla.kernel.org/show_bug.cgi?id=42839
> quit
>
> (cc-ing Stefan Bader since he maintains the linux-2.6.32.y-drm33.z tree)
> Hi again,
>
> Lukas Anzinger wrote[1]:
>
>> During a refactoring of the i915 driver a regression has been introduced
> [e70236a8d3d0]
>> For some chipsets the wrong fifo size is determined which results in
>> lot's of pixel errors when starting the xserver and choosing 800x600
>> as a resolution. If another resolution is used (eg. 1024x768 or
>> 1280x1024), I don't encounter this problem.
>
> [...]
> Jonathan Nieder wrote:
>> Lukas Anzinger wrote:
>
>>> looks good to me.
>>
>> Do you mean that the patch looks good or that you've tried applying it
>> and the behavior was bad before and good afterward?
>
> Ping.  Have you tested this patch?
>
>        From: Adam Jackson 
>        Date: Fri, 16 Apr 2010 18:20:57 -0400
>        Subject: drm/i915: Attempt to fix watermark setup on 85x (v2)
>
>        commit 8f4695ed1c9e068772bcce4cd4ff03f88d57a008 upstream.
>
>        IS_MOBILE() catches 85x, so we'd always try to use the 9xx FIFO sizing;
>        since there's an explicit 85x version, this seems wrong.
>
>        v2: Handle 830m correctly too.
>
>        Signed-off-by: Adam Jackson 
>        Reviewed-by: Eric Anholt 
>        Signed-off-by: Eric Anholt 
>        Signed-off-by: Jonathan Nieder 
>
> In suspense,
> Jonathan
>
> [1] http://bugs.debian.org/661696



--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CACB1AevQqCXmmcZie2Sn4w0=z4rrqs-jdfu6acsdyvkflv9...@mail.gmail.com



Bug#661696: drm/i915: wrong fifo size due to uncareful refactoring which results in an xserver crash at 800x600

2012-03-02 Thread Lukas Anzinger
Hi Jonathan,

looks good to me.

I've also reported this bug upstream under #42839.

Regards,

Lukas

On Wed, Feb 29, 2012 at 19:36, Jonathan Nieder  wrote:
> tags 661696 = upstream patch moreinfo
> quit
>
> Hi Lukas,
>
> Lukas Anzinger wrote:
>
>> During a refactoring of the i915 driver a regression has been introduced
>> ([...]h=e70236a8d3d0a4c100a0b9f7d394d9bda9c56aca): For some chipsets
>> the wrong fifo size is determined which results in lot's of pixel
>> errors when starting the xserver and choosing 800x600 as a
>> resolution. If another resolution is used (eg. 1024x768 or
>> 1280x1024), I don't encounter this problem.
>>
>> I've attached a patch that fixes the problem (no pixel errors
>> anymore) and determines the correct fifo size.
>
> Thanks for the report and analysis.  Please test the attached patch
> against 2.6.32.y or a squeeze kernel.  If it works, we can send this
> to Greg for inclusion in the 2.6.32.y series so everyone benefits.
>
> Hope that helps,
> Jonathan



--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CACB1AevCnHALYyVt57WC+Q=VtjO4g=ZH+xAwza_=b+b0rv9...@mail.gmail.com



Bug#661696: drm/i915: wrong fifo size due to uncareful refactoring which results in an xserver crash at 800x600

2012-02-29 Thread Lukas Anzinger
Package: linux-2.6
Version: 2.6.32-41
Severity: important
Tags: upstream patch

Hi,

I've encountered a nasty bug in the drm/i915 part of Debian's stable kernel. 
The code is also present in 2.6.33.20, which is the latest stable upstream 
release of 2.6.33.y at the time of writing.

During a refactoring of the i915 driver a regression has been introduced 
(http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=commit;h=e70236a8d3d0a4c100a0b9f7d394d9bda9c56aca):
 For some chipsets the wrong fifo size is determined which results in lot's of 
pixel errors when starting the xserver and choosing 800x600 as a resolution. If 
another resolution is used (eg. 1024x768 or 1280x1024), I don't encounter this 
problem.

I've attached a patch that fixes the problem (no pixel errors anymore) and 
determines the correct fifo size.

--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4828,15 +4828,15 @@ static void intel_init_display(struct drm_device *dev)
dev_priv->display.update_wm = i965_update_wm;
else if (IS_I9XX(dev) || IS_MOBILE(dev)) {
dev_priv->display.update_wm = i9xx_update_wm;
-   dev_priv->display.get_fifo_size = i9xx_get_fifo_size;
-   } else {
if (IS_I85X(dev))
dev_priv->display.get_fifo_size = i85x_get_fifo_size;
else if (IS_845G(dev))
dev_priv->display.get_fifo_size = i845_get_fifo_size;
else
-   dev_priv->display.get_fifo_size = i830_get_fifo_size;
+   dev_priv->display.get_fifo_size = i9xx_get_fifo_size;
+   } else {
dev_priv->display.update_wm = i830_update_wm;
+   dev_priv->display.get_fifo_size = i830_get_fifo_size;
}   
 }

Regards,

Lukas

-- Package-specific info:
** Version:
Linux version 2.6.32-5-686 (Debian 2.6.32-41) (b...@decadent.org.uk) (gcc 
version 4.3.5 (Debian 4.3.5-4) ) #1 SMP Mon Jan 16 16:04:25 UTC 2012

** Command line:
BOOT_IMAGE=/boot/vmlinuz-2.6.32-5-686 
root=UUID=08a419ad-d4d1-47ff-94fd-6d7c8c5321de ro quiet

** Not tainted

** Kernel log:
[1.637921] sd 0:0:0:0: [sda] 8027712 512-byte logical blocks: (4.11 GB/3.82 
GiB)
[1.638005] sd 0:0:0:0: [sda] Write Protect is off
[1.638010] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
[1.638045] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, 
doesn't support DPO or FUA
[1.638258]  sda: sda1 sda2
[1.639892] sd 0:0:0:0: [sda] Attached SCSI disk
[1.740461] usb 1-1: new full speed USB device using uhci_hcd and address 2
[1.744283] kjournald starting.  Commit interval 5 seconds
[1.744299] EXT3-fs: mounted filesystem with ordered data mode.
[1.897098] usb 1-1: New USB device found, idVendor=1a40, idProduct=0201
[1.897104] usb 1-1: New USB device strings: Mfr=0, Product=1, SerialNumber=0
[1.897109] usb 1-1: Product: USB 2.0 Hub [MTT]
[1.897256] usb 1-1: configuration #1 chosen from 1 choice
[1.900120] hub 1-1:1.0: USB hub found
[1.902075] hub 1-1:1.0: 7 ports detected
[2.006518] udev[254]: starting version 164
[2.020066] usb 1-2: new full speed USB device using uhci_hcd and address 3
[2.194232] usb 1-2: New USB device found, idVendor=9710, idProduct=7830
[2.194239] usb 1-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[2.194244] usb 1-2: Product: USB-MAC Controller   
[2.194247] usb 1-2: Manufacturer: Moschip Semiconductor
[2.194251] usb 1-2: SerialNumber: 3b00043d
[2.194414] usb 1-2: configuration #1 chosen from 1 choice
[2.274033] usb 1-1.2: new full speed USB device using uhci_hcd and address 4
[2.350298] pci_hotplug: PCI Hot Plug PCI Core version: 0.5
[2.388923] input: PC Speaker as /devices/platform/pcspkr/input/input0
[2.403022] Marking TSC unstable due to TSC halts in idle
[2.405028] processor LNXCPU:00: registered as cooling_device1
[2.419214] Switching to clocksource acpi_pm
[2.456113] intel_rng: FWH not detected
[2.470309] ACPI: AC Adapter [ADP1] (off-line)
[2.470506] input: Power Button as 
/devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0C:00/input/input1
[2.470522] ACPI: Power Button [PWRB]
[2.470618] input: Power Button as 
/devices/LNXSYSTM:00/LNXPWRBN:00/input/input2
[2.470624] ACPI: Power Button [PWRF]
[2.488242] i801_smbus :00:1f.3: PCI INT B -> GSI 17 (level, low) -> IRQ 
17
[2.499895] shpchp: Standard Hot Plug PCI Controller Driver version: 0.4
[2.529165] usb 1-1.3: new low speed USB device using uhci_hcd and address 5
[2.542981] usb 1-2: applying rev.C fixup
[2.549198] usb 1-2: applying rev.C fixup
[2.561229] eth1: register 'MOSCHIP usb-ethernet driver' at 
usb-:00:1d.0-2, MOSCHIP 7830/7730 usb-NET adapter, 00:13:3b:00:04:3d
[2.561269] usbcore: registered new interface driver MOSCHIP usb-ethernet 
driver
[2.618157] [drm] Initialized drm 1.1.0 20060810
[