Re: Bug#545517: Intel/KMS/suspend-to-disk bug still present on 2.6.34
On 02/07/2010 22:36, Vincent Danjean wrote: Hi, On 02/07/2010 16:16, Julien Cristau wrote: On Mon, Jun 14, 2010 at 22:15:17 +0200, Vincent Danjean wrote: Since the introduction of KMS, suspend-to-disk never works reliably on my laptop. [...] This may be fixed by commit 985b823b919273fe1327d56d2196b4f92e5d0fae (included below). Can you test it? I compile and run an upstream kernel (2.6.35-rc3+ commit 123f94f22e3d283dfe68742b269c245b0501ad82 ) I did not observe memory corruption. However, with about 10 resumes, 2 had been ok but 8 leads to a hard freeze just after the come back (ie just after I see my gnome desktop). SysRq key was still working (but not C-A-Fx switches) I will wait for the official release of 2.6.35 in case this is due to other bugs. Regards, Vincent -- Vincent Danjean GPG key ID 0x9D025E87 vdanj...@debian.org GPG key fingerprint: FC95 08A6 854D DB48 4B9A 8A94 0BF7 7867 9D02 5E87 Unofficial packages: http://moais.imag.fr/membres/vincent.danjean/deb.html APT repo: deb http://perso.debian.org/~vdanjean/debian unstable main -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4c325043.9030...@ens-lyon.org
Bug#545517: Intel/KMS/suspend-to-disk bug still present on 2.6.34
Hi Vincent,
On Mon, Jun 14, 2010 at 22:15:17 +0200, Vincent Danjean wrote:
Since the introduction of KMS, suspend-to-disk never works reliably
on my laptop. Todays, it is so unstable that I do not try it. The
biggest problem is that, when it does not work, the session is restored
but (I think) memory corruption occurs. So the symptom can differ from
time to time.
My classical symptom is applications crashing or refusing to be
load (with a segv in libc when trying to run ls for example).
In these cases, I immediately hard-switch-off the laptop so that
in-memory corruption was not writen-back on disk (I had several
difficult fsck before I do that).
I'm not sure that this is related to KMS but it begins to occurs when
KMS has been introduced and (in the first time, I do not recheck recently),
I have no problems when I disabled KMS.
#534422 can be linked to this bug.
This bug is also reported to xorg:
https://bugs.freedesktop.org/show_bug.cgi?id=23836
This may be fixed by commit 985b823b919273fe1327d56d2196b4f92e5d0fae
(included below).
Can you test it?
commit 985b823b919273fe1327d56d2196b4f92e5d0fae
Author: Linus Torvalds torva...@linux-foundation.org
Date: Fri Jul 2 10:04:42 2010 +1000
drm/i915: fix hibernation since i915 self-reclaim fixes
Since commit 4bdadb9785696439c6e2b3efe34aa76df1149c83 (drm/i915:
Selectively enable self-reclaim), we've been passing GFP_MOVABLE to the
i915 page allocator where we weren't before due to some over-eager
removal of the page mapping gfp_flags games the code used to play.
This caused hibernate on Intel hardware to result in a lot of memory
corruptions on resume. See for example
http://bugzilla.kernel.org/show_bug.cgi?id=13811
Reported-by: Evengi Golov (in bugzilla)
Signed-off-by: Dave Airlie airl...@redhat.com
Tested-by: M. Vefa Bicakci bic...@superonline.com
Cc: sta...@kernel.org
Cc: Chris Wilson ch...@chris-wilson.co.uk
Cc: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
Cc: Hugh Dickins hugh.dick...@tiscali.co.uk
Signed-off-by: Linus Torvalds torva...@linux-foundation.org
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 9ded3da..0743858 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2239,7 +2239,7 @@ i915_gem_object_get_pages(struct drm_gem_object *obj,
mapping = inode-i_mapping;
for (i = 0; i page_count; i++) {
page = read_cache_page_gfp(mapping, i,
- mapping_gfp_mask (mapping) |
+ GFP_HIGHUSER |
__GFP_COLD |
gfpmask);
if (IS_ERR(page))
Cheers,
Julien
signature.asc
Description: Digital signature
Bug#545517: Intel/KMS/suspend-to-disk bug still present on 2.6.34
Hi, On 02/07/2010 16:16, Julien Cristau wrote: On Mon, Jun 14, 2010 at 22:15:17 +0200, Vincent Danjean wrote: Since the introduction of KMS, suspend-to-disk never works reliably on my laptop. [...] This may be fixed by commit 985b823b919273fe1327d56d2196b4f92e5d0fae (included below). Hourra ! Can you test it? Not for now (I'm traveling without possibly restoring my system from backups) but the described symptoms and the explanations seem to fit with my experiments. Since two days, I was trying again suspend-to-disk with the new (from experimental) intel video driver. I succeeded in two or three rounds of suspend-to-disk but - I was finding strange that a user driver can corrupt kernel memory so badly - I sometimes succeed in doing several rounds of suspend-to-disk before triggering the bug (and corrupting my disks :-( ) If this fix is confirmed, I think the patch should be backported/applied in the Debian kernel Regards, Vincent -- Vincent Danjean GPG key ID 0x9D025E87 vdanj...@debian.org GPG key fingerprint: FC95 08A6 854D DB48 4B9A 8A94 0BF7 7867 9D02 5E87 Unofficial packages: http://moais.imag.fr/membres/vincent.danjean/deb.html APT repo: deb http://perso.debian.org/~vdanjean/debian unstable main -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4c2e4dcf.8050...@debian.org
