Bug#604096: Bug#602418: #601341, #602418 and #604096 seem to be duplicates
a) Fix the GART/AGP backend (so drivers/char/agp/*.c) so they use the PCI API. Only the i915 and higher are using the PCI API and I've some of the older boxes with i860 so can actually test it. I've posted patches to address this (https://lkml.org/lkml/2010/12/6/480) and Dave question is why anyone cares about AGP in 2010. I was wondering if any folks could comment? -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101207002754.ga31...@dumpdata.com
Bug#604096: Bug#602418: #601341, #602418 and #604096 seem to be duplicates
On Mon, 2010-11-29 at 02:52 +, Ben Hutchings wrote: On Sun, 2010-11-28 at 18:12 +, Ian Campbell wrote: On Sun, 2010-11-28 at 16:58 +, Ben Hutchings wrote: On Tue, 2010-11-23 at 12:56 +0100, Lionel Elie Mamane wrote: On Tue, Nov 23, 2010 at 10:41:57AM +0100, Alexander Kurtz wrote: The following bugs seem to be identical: #601341 #602418 #604096 They all seem to be fixed by this kernel: http://xenbits.xen.org/people/ianc/ I think it would be a good idea to *) merge them all *) assign to linux-2.6 *) mark as affecting xserver-xorg *) mark as patched *) possibly mark them as RC That's all fine by me (as reporter of #601341 and #602418). Possibly the patch tag is not adequate as the exact read-to-apply-to-the-Debian-package patch is not there, just one of the differences between the Debian package and http://xenbits.xen.org/people/ianc/ fixes this. Ian, can you identify which patch we're currently missing? They are the changes attached to Reinstating GPU fixes to Xen flavour on debian-kernel (1290518224.5514.27.ca...@zakaz.uk.xensource.com) last week. [...] IIRC the original discussion regarding the omission of these changes from the last Xen pvops merge starts at 20100817192832.ga22...@wavehammer.waldi.eu.org (on debian-kernel back in August). Thanks for the pointers. I agree with Bastian that some of these changes are really quite nasty. Do you and other Xen developers have any plan for how to fix the GART and TTM mapping problems in a cleaner way as Xen dom0 support goes upstream? I know that there is a plan to get rid of the _PAGE_IOMAP stuff altogether by simply arranging for a 1-1 mapping for the relevant device PFNs in the P2M array. However I'm not sure whether or not this knocks-on into a fix for the GART/TTM stuff. Konrad, do you have an idea how you plan to solve the GART/TTM issues upstream? If there is no such plan then I would rather disable these drivers than make them work temporarily with a hack. Thanks, Ian. -- Ian Campbell You will not be elected to public office this year. signature.asc Description: This is a digitally signed message part
Bug#604096: Bug#602418: #601341, #602418 and #604096 seem to be duplicates
.. snip of back-history.. Thanks for the pointers. I agree with Bastian that some of these changes are really quite nasty. Do you and other Xen developers have any plan for how to fix the GART and TTM mapping problems in a cleaner way as Xen dom0 support goes upstream? I know that there is a plan to get rid of the _PAGE_IOMAP stuff altogether by simply arranging for a 1-1 mapping for the relevant device PFNs in the P2M array. However I'm not sure whether or not this knocks-on into a fix for the GART/TTM stuff. Unfortunately it won't fit the whole bill. What some of those patches did was introduce a mechanism to use the PCI API to do virt_to_phys. And when I say use, I mean that really loosely. The solution I cobbled was to bypass using any API and just hard-coded the phys-bus address lookup. My plan for upstream is to actually work on those drivers (intel-agp.c, agpgart.c) to utilize the PCI API. Konrad, do you have an idea how you plan to solve the GART/TTM issues upstream? Yes, I am working on a set of patches that are cleaner and more upstream-able than the first revision. Hope to have most of a) and b) done in the next two weeks. And there are actually three distinct milestones here: a) Fix the GART/AGP backend (so drivers/char/agp/*.c) so they use the PCI API. Only the i915 and higher are using the PCI API and I've some of the older boxes with i860 so can actually test it. b) Fix the TTM to use the DMA API. c) Lastly, get rid of _PAGE_IOMAP so we don't have to depend on radeon/nouveau/etc to set the proper _PAGE_IOMAP on the PFNs/BARs.. If there is no such plan then I would rather disable these drivers than make them work temporarily with a hack. The shape of the stuff that I am going to propose upstream is more refined and much cleaner. Do you want me to send you an email when I am ready and had done my testing so you can take a look at it? -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101129151808.ga19...@dumpdata.com
Bug#604096: Bug#602418: #601341, #602418 and #604096 seem to be duplicates
On Tue, 2010-11-23 at 12:56 +0100, Lionel Elie Mamane wrote: On Tue, Nov 23, 2010 at 10:41:57AM +0100, Alexander Kurtz wrote: The following bugs seem to be identical: #601341 #602418 #604096 They all seem to be fixed by this kernel: http://xenbits.xen.org/people/ianc/ I think it would be a good idea to *) merge them all *) assign to linux-2.6 *) mark as affecting xserver-xorg *) mark as patched *) possibly mark them as RC That's all fine by me (as reporter of #601341 and #602418). Possibly the patch tag is not adequate as the exact read-to-apply-to-the-Debian-package patch is not there, just one of the differences between the Debian package and http://xenbits.xen.org/people/ianc/ fixes this. Ian, can you identify which patch we're currently missing? Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. signature.asc Description: This is a digitally signed message part
Bug#604096: Bug#602418: #601341, #602418 and #604096 seem to be duplicates
On Sun, 2010-11-28 at 16:58 +, Ben Hutchings wrote: On Tue, 2010-11-23 at 12:56 +0100, Lionel Elie Mamane wrote: On Tue, Nov 23, 2010 at 10:41:57AM +0100, Alexander Kurtz wrote: The following bugs seem to be identical: #601341 #602418 #604096 They all seem to be fixed by this kernel: http://xenbits.xen.org/people/ianc/ I think it would be a good idea to *) merge them all *) assign to linux-2.6 *) mark as affecting xserver-xorg *) mark as patched *) possibly mark them as RC That's all fine by me (as reporter of #601341 and #602418). Possibly the patch tag is not adequate as the exact read-to-apply-to-the-Debian-package patch is not there, just one of the differences between the Debian package and http://xenbits.xen.org/people/ianc/ fixes this. Ian, can you identify which patch we're currently missing? They are the changes attached to Reinstating GPU fixes to Xen flavour on debian-kernel (1290518224.5514.27.ca...@zakaz.uk.xensource.com) last week. That patch correspond to several separate commits upstream in xen.git: d541daf6b95641953a1eb1938c640a0178bed726 pvops: make pte_flags() go via pvops e1687eae6f85475ebf8579039badafbbe5602014 fb: propagate VM_IO to VMA. c54d5aa10b7a96d182c6dff5160834a0374f9b31 ttm: Change VMA flags if they != to the TTM flags. c57bd3e45674e26c1eb99b65a8ed9db49651aa4a amd64-agp:Use Xen back-door to get page's physical address for AMD64 chipsets. 1e6dcf8d925ac125c780c693f89134532c6e121a intel-agp: Use Xen back-door to get page's physical address for i8[1,3]0 a2395df466453e0bf7ee223c449a29dd3b0ed7f0 intel-agp: Warn when !USE_PCI_DMA_API and inserting bogus bus addresses. 2b6c99e135cd8467f7a5999ee3e9bb877426a8b0 agp-backend: Use Xen back-door to get bus address for scratch page. 0f03e715260f3b715a0f55cd1efd0100d121c27b agp: If _GFP_DMA_32 flag is set enforce pages to be under 4GB under Xen. 597bbe84922e0966a77d05d62857f3553c7aeffe agp: Program the GART with the real physical address under Xen. 534c050301a7c672e3c035034fa6b9c7752f9066 agp: Use Xen back-door to get bus address for legacy code. 9551827190db2d34f106255f0b5bfdc452e85cd8 ttm: Set VM_IO only on pages with TTM_MEMTYPE_FLAG_NEEDS_IOREMAP set. 0675de9b57cf7afa00ceab93a3ca180c085c3f9a ttm: When TTM_PAGE_FLAG_DMA32 allocate pages under 4GB under Xen. but I think they can be considered as a single set for the purposes of resolving these tickets. IIRC the original discussion regarding the omission of these changes from the last Xen pvops merge starts at 20100817192832.ga22...@wavehammer.waldi.eu.org (on debian-kernel back in August). Ian. -- Ian Campbell I feel like a wet parking meter on Darvon! signature.asc Description: This is a digitally signed message part
Bug#604096: Bug#602418: #601341, #602418 and #604096 seem to be duplicates
On Sun, 2010-11-28 at 18:12 +, Ian Campbell wrote: On Sun, 2010-11-28 at 16:58 +, Ben Hutchings wrote: On Tue, 2010-11-23 at 12:56 +0100, Lionel Elie Mamane wrote: On Tue, Nov 23, 2010 at 10:41:57AM +0100, Alexander Kurtz wrote: The following bugs seem to be identical: #601341 #602418 #604096 They all seem to be fixed by this kernel: http://xenbits.xen.org/people/ianc/ I think it would be a good idea to *) merge them all *) assign to linux-2.6 *) mark as affecting xserver-xorg *) mark as patched *) possibly mark them as RC That's all fine by me (as reporter of #601341 and #602418). Possibly the patch tag is not adequate as the exact read-to-apply-to-the-Debian-package patch is not there, just one of the differences between the Debian package and http://xenbits.xen.org/people/ianc/ fixes this. Ian, can you identify which patch we're currently missing? They are the changes attached to Reinstating GPU fixes to Xen flavour on debian-kernel (1290518224.5514.27.ca...@zakaz.uk.xensource.com) last week. [...] IIRC the original discussion regarding the omission of these changes from the last Xen pvops merge starts at 20100817192832.ga22...@wavehammer.waldi.eu.org (on debian-kernel back in August). Thanks for the pointers. I agree with Bastian that some of these changes are really quite nasty. Do you and other Xen developers have any plan for how to fix the GART and TTM mapping problems in a cleaner way as Xen dom0 support goes upstream? If there is no such plan then I would rather disable these drivers than make them work temporarily with a hack. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. signature.asc Description: This is a digitally signed message part
