Bug#622937: [squeeze] Include important changes from 2.6.32.37

2011-04-18 Thread dann frazier
On Sat, Apr 16, 2011 at 02:49:28AM +0100, Ben Hutchings wrote:
 On Fri, 2011-04-15 at 17:52 -0600, dann frazier wrote:
 [...]
   bd378dd net: fix rds_iovec page count overflow
  
  overflow fix, looks pretty straightforward
 
 but needs a fix-up, which is in 2.6.32.38.

*nod* - yeah noticed that later

 [...]
   f101d38 ext4: fix credits computing for indirect mapped files
  
  I'm not sure what improvement this provides users
 
 When using delayed allocation, ext4 still needs to count how many blocks
 the pending writes will need and fail any writes that would overflow the
 disk.  This is a fix for under-counting which would result in data loss
 (or a crash?) when a disk fills up.

ok

 [...]
   483cb5a atm/solos-pci: Don't include frame pseudo-header on transmit 
   hex-dump
  
  This seems to be a fixup for debug code? I suggest omitting.
 
 I would rather not diverge from upstream here.  It has no effect if the
 user doesn't set the atmdebug parameter.

That's less conservative than we have been for previous stable
releases, but I do agree it won't affect the vast majority of users.

 [...]
   ba7eb95 Squashfs: handle corruption of directory structure
  
  Adds some sanity checks that might avoid an oops; looks good to me
 
 I asked Vince Sanders to eyeball this as he has done some work with
 squashfs.  He didn't see anything wrong with it.

Thanks

 [...]
   6373cc6 x86, microcode, AMD: Extend ucode size verification
 
 That hash is ambiguous here.  Full hash is
 6373cc665a7f5859bcd7772a45a581ecbc86e2cd.
 
  I'll defer to Ben who commented on this upstream.
 
 The code is dumb but this doesn't seem to make it any worse.  It raises
 the maximum allowed size for microcode updates to AMD family 15h
 processors, and will presumably be necessary to apply microcode updates
 at some point.

ok

 [...]
   5381fb8 gro: reset skb_iif on reuse
  
  Doesn't apply to our tree
 
 It depends on the next one; did you try to apply them in reverse order?

perhaps..

   2863e5a gro: Reset dev pointer on reuse
  
  This looks like it'd apply, but I'll defer to Ben's network expertise here
 
 I think the bug is likely to result in a crash.

 [...]
   6216277 Treat writes as new when holes span across page boundaries
  
  looks like a data corruption fix
 
 and information leak.
 [...]
   d7c7517 mm: avoid wrapping vm_pgoff in mremap()
  
  avoids a BUG()
 
 which is a trivial local DoS.

right

 [...]
   bd94ab2 Relax si_code check in rt_sigqueueinfo and rt_tgsigqueueinfo
  
  looks like a good correctness fix
 
 Not sure about correctness, but it's important for compatibility.
 
   11ab449 staging: hv: use sync_bitops when interacting with the hypervisor
   af352e4 staging: hv: Fix GARP not sent after Quick Migration
  
  we don't enable HYPERV, but might be good for those who build from our 
  source
 
 I'm intending to enable them at some point.  I may just backport the
 current upstream versions though.
 
   1ed34c9 staging: usbip: bugfix for isochronous packets and optimization
   d9638d9 staging: usbip: bugfix add number of packets for isochronous 
   frames
   98d7db5 staging: usbip: bugfixes related to kthread conversion
  
  I'm a bit concerned about the size of these patches, but they *seem*
  important for compatibility (and the last one avoids a deadlock)
 [...]
 
 This is staging.  It was crap to start with and these will probably make
 it marginally less crap. :-)

I've started preparing a commit but I'll be mostly offline today so I
won't be able to finish it up before this evening.

  - dann




-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20110418142658.ga4...@dannf.org



Bug#622937: [squeeze] Include important changes from 2.6.32.37

2011-04-15 Thread dann frazier
Source: linux-2.6
Version: 2.6.32-33
Tags: squeeze

Since we've seen a few regressions w/ longterm updates lately, I thought
I'd use a bug as a way to review each change w/ a Debian-specific
lens.

Here's my initial pass - other reviews welcome..

 eebefbf xfs: zero proper structure size for geometry calls

already included in 2.6.32-33

 bd378dd net: fix rds_iovec page count overflow

overflow fix, looks pretty straightforward

 c18114e exec: copy-and-paste the fixes into compat_do_execve() paths

already included in 2.6.32-30

 d3de146 exec: make argv/envp memory visible to oom-killer

already included in 2.6.32-30

 40521c9 CAN: Use inode instead of kernel address for /proc file

already included in 2.6.32-31

 9d880ce irda: prevent integer underflow in IRLMP_ENUMDEVICES

already included in 2.6.32-30

 7847ca8 econet: Fix crash in aun_incoming().

already included in 2.6.32-30

 2dbba29 inet_diag: Make sure we actually run the same bytecode we audited.

already included in 2.6.32-30

 4312007 net: tipc: fix information leak to userland

already included in 2.6.32-30

 fe540c3 nfsd: fix auth_domain reference leak on nlm operations

fixes a reference leak - code change looks innocuous enough

 f101d38 ext4: fix credits computing for indirect mapped files

I'm not sure what improvement this provides users

 975c07c net: packet: fix information leak to userland

already included in 2.6.32-30

 1fe4497 net: ax25: fix information leak to userland

already included in 2.6.32-30

 483cb5a atm/solos-pci: Don't include frame pseudo-header on transmit hex-dump

This seems to be a fixup for debug code? I suggest omitting.

 3f89dad sctp: fix to calc the INIT/INIT-ACK chunk length correctly is set

Fixes an oops; commit log includes a test case we should use to verify.

 ba7eb95 Squashfs: handle corruption of directory structure

Adds some sanity checks that might avoid an oops; looks good to me

 794e8ff Revert x86: Cleanup highmap after brk is concluded

Already queued for 2.6.32-34 (#621072)

 7b74539 powerpc: Fix default_machine_crash_shutdown #ifdef botch
 a55ee54 powerpc/kexec: Add ifdef CONFIG_PPC_STD_MMU_64 to PPC64 code

Already included in 2.6.32-33

 6373cc6 x86, microcode, AMD: Extend ucode size verification

I'll defer to Ben who commented on this upstream.

 7dbaa2b x86, amd-ucode: Remove needless log messages

Removes a useless log message... doesn't seem = important to me

 5381fb8 gro: reset skb_iif on reuse

Doesn't apply to our tree

 2863e5a gro: Reset dev pointer on reuse

This looks like it'd apply, but I'll defer to Ben's network expertise here

 79760cb repair gdbstub to match the gdbserial protocol specification

We don't enable KGDB, but it might fix an issue for someone using our
source to build their own kernel.

 a98fa05 sound: oss: midi_synth: check get_user() return value
 0042e33 sound/oss: remove offset from load_patch callbacks

We don't build these, but might help someone building w/ our source

 d343ebc econet: 4 byte infoleak to the network

Already included in 2.6.32-32

 48a129a drivers/misc/ep93xx_pwm.c: world-writable sysfs files
 92d191d drivers/rtc/rtc-ds1511.c: world-writable sysfs nvram file

These should probably get CVEs

 23b37e1 mfd: ab3100: world-writable debugfs *_priv files

debugfs shouldn't get a CVE, but should be fixed

 a41e7f1 ipv6: netfilter: ip6_tables: fix infoleak to userspace

Already included in 2.6.32-32

 8fd563c netfilter: ipt_CLUSTERIP: fix buffer overflow

+1

 bf97177 netfilter: arp_tables: fix infoleak to userspace

Already included in 2.6.32-32

 3be5e2f netfilter: ip_tables: fix infoleak to userspace

Already included in 2.6.32-32

 913bb1e char/tpm: Fix unitialized usage of data buffer

should probably get a CVE

 6216277 Treat writes as new when holes span across page boundaries

looks like a data corruption fix

 e469bb3 Bluetooth: add support for Apple MacBook Pro 8,2

just adding ids

 e826581 Bluetooth: bnep: fix buffer overflow

already fixed in 2.6.32-32

 a04a632 bridge: netfilter: fix information leak

already fixed in 2.6.32-32

 1fdae72 Bluetooth: sco: fix information leak to userspace

already fixed in 2.6.32-32

 91443ec b43: allocate receive buffers big enough for max frame len + offset

avoids a BUG()

 cda10c1 p54usb: IDs for two new devices

just adding ids

 d7c7517 mm: avoid wrapping vm_pgoff in mremap()

avoids a BUG()

 8975a50 quota: Don't write quota info in dquot_commit()

the journaling filesystem aspect seems like it makes this a candidate

 b94738f UBIFS: fix debugging failure in dbg_check_space_info

fixes an oops

 5cb4b85 UBIFS: fix oops on error path in read_pnode

good oops fix

 b7236ed UBIFS: do not read flash unnecessarily

basically a performance improvement... but trivial.

 a8c2609 ath9k: fix a chip wakeup related crash in ath9k_start

looks good

 a9a4c9c x86, mtrr, pat: Fix one cpu getting out of sync during resume

looks good to me

 e8a7988 Btrfs: Fix uninitialized root flags for subvolumes

looks 

Bug#622937: [squeeze] Include important changes from 2.6.32.37

2011-04-15 Thread Ben Hutchings
On Fri, 2011-04-15 at 17:52 -0600, dann frazier wrote:
[...]
  bd378dd net: fix rds_iovec page count overflow
 
 overflow fix, looks pretty straightforward

but needs a fix-up, which is in 2.6.32.38.

[...]
  f101d38 ext4: fix credits computing for indirect mapped files
 
 I'm not sure what improvement this provides users

When using delayed allocation, ext4 still needs to count how many blocks
the pending writes will need and fail any writes that would overflow the
disk.  This is a fix for under-counting which would result in data loss
(or a crash?) when a disk fills up.

[...]
  483cb5a atm/solos-pci: Don't include frame pseudo-header on transmit 
  hex-dump
 
 This seems to be a fixup for debug code? I suggest omitting.

I would rather not diverge from upstream here.  It has no effect if the
user doesn't set the atmdebug parameter.

[...]
  ba7eb95 Squashfs: handle corruption of directory structure
 
 Adds some sanity checks that might avoid an oops; looks good to me

I asked Vince Sanders to eyeball this as he has done some work with
squashfs.  He didn't see anything wrong with it.

[...]
  6373cc6 x86, microcode, AMD: Extend ucode size verification

That hash is ambiguous here.  Full hash is
6373cc665a7f5859bcd7772a45a581ecbc86e2cd.

 I'll defer to Ben who commented on this upstream.

The code is dumb but this doesn't seem to make it any worse.  It raises
the maximum allowed size for microcode updates to AMD family 15h
processors, and will presumably be necessary to apply microcode updates
at some point.

[...]
  5381fb8 gro: reset skb_iif on reuse
 
 Doesn't apply to our tree

It depends on the next one; did you try to apply them in reverse order?

  2863e5a gro: Reset dev pointer on reuse
 
 This looks like it'd apply, but I'll defer to Ben's network expertise here

I think the bug is likely to result in a crash.

[...]
  6216277 Treat writes as new when holes span across page boundaries
 
 looks like a data corruption fix

and information leak.

[...]
  d7c7517 mm: avoid wrapping vm_pgoff in mremap()
 
 avoids a BUG()

which is a trivial local DoS.

[...]
  bd94ab2 Relax si_code check in rt_sigqueueinfo and rt_tgsigqueueinfo
 
 looks like a good correctness fix

Not sure about correctness, but it's important for compatibility.

  11ab449 staging: hv: use sync_bitops when interacting with the hypervisor
  af352e4 staging: hv: Fix GARP not sent after Quick Migration
 
 we don't enable HYPERV, but might be good for those who build from our source

I'm intending to enable them at some point.  I may just backport the
current upstream versions though.

  1ed34c9 staging: usbip: bugfix for isochronous packets and optimization
  d9638d9 staging: usbip: bugfix add number of packets for isochronous frames
  98d7db5 staging: usbip: bugfixes related to kthread conversion
 
 I'm a bit concerned about the size of these patches, but they *seem*
 important for compatibility (and the last one avoids a deadlock)
[...]

This is staging.  It was crap to start with and these will probably make
it marginally less crap. :-)

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.


signature.asc
Description: This is a digitally signed message part