Bug#703715: Kernel bug ALPS TouchPad and i915 DRM do not play nicely on Wheezy 3.2.0-4-amd64

2013-07-23 Thread iiNET

Hi Kernel Maintainers

I have been tracking related bugs 704987 and 703715, I have suggested a 
fix that has been under test for the last week and seems to fix the 
reported issue, the following is the patch from the stable tree that 
reverts Debian patch, 
features/all/Input-add-Synaptics-USB-device-driver.patch.


Testing has been editing, creating and reading various Libre Office 
files without any symptoms reported, all with various touch pad 
interactions, suspend, resume.



commit e24fb4d67f53530038a9711d0c1f65937490bb8c
Author: Ben Hutchings b...@decadent.org.uk
Date:   Tue Jun 25 04:15:27 2013 +0100

Revert drm/i915: GFX_MODE Flush TLB Invalidate Mode must be  '1' 
for scanli


This reverts commit 393143615d9f2f581d87387268dc11b95adc339c, which
was commit f05bb0c7b624252a5e768287e340e8e45df96e42 upstream.

This has been found to cause GPU hangs when backported to 3.2, though
not in mainline.

References: http://bugs.launchpad.net/bugs/1140716
Cc: Steve Conklin sconk...@canonical.com
Cc: Stefan Bader stefan.ba...@canonical.com
Cc: Bradd Figg brad.f...@canonical.com
Cc: Luis Henriques luis.henriq...@canonical.com
Signed-off-by: Ben Hutchings b...@decadent.org.uk

diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c 
b/drivers/gpu/drm/i915/inte

index 4fddd21..38a7793 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -408,11 +408,6 @@ static int init_render_ring(struct 
intel_ring_buffer *ring)

if (INTEL_INFO(dev)-gen = 6)
I915_WRITE(MI_MODE, 
GFX_MODE_ENABLE(ASYNC_FLIP_PERF_DISABLE));


-   /* Required for the hardware to program scanline values for 
waiting */

-   if (INTEL_INFO(dev)-gen == 6)
-   I915_WRITE(GFX_MODE,
- GFX_MODE_ENABLE(GFX_TLB_INVALIDATE_ALWAYS));
-
if (IS_GEN7(dev))
I915_WRITE(GFX_MODE_GEN7,
GFX_MODE_DISABLE(GFX_TLB_INVALIDATE_ALWAYS) |


--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/51ee5760.4060...@iinet.net.au



Bug#703715: Kernel bug ALPS TouchPad and i915 DRM do not play nicely on Wheezy 3.2.0-4-amd64

2013-07-23 Thread Ben Hutchings
On Tue, 2013-07-23 at 20:13 +1000, iiNET wrote:
 Hi Kernel Maintainers
 
 I have been tracking related bugs 704987 and 703715, I have suggested a 
 fix that has been under test for the last week and seems to fix the 
 reported issue, the following is the patch from the stable tree that 
 reverts Debian patch, 
 features/all/Input-add-Synaptics-USB-device-driver.patch.

I don't know how you think these are connected...

 Testing has been editing, creating and reading various Libre Office 
 files without any symptoms reported, all with various touch pad 
 interactions, suspend, resume.
 
 
 commit e24fb4d67f53530038a9711d0c1f65937490bb8c
 Author: Ben Hutchings b...@decadent.org.uk
 Date:   Tue Jun 25 04:15:27 2013 +0100
 
  Revert drm/i915: GFX_MODE Flush TLB Invalidate Mode must be  '1' 
 for scanli
 
  This reverts commit 393143615d9f2f581d87387268dc11b95adc339c, which
  was commit f05bb0c7b624252a5e768287e340e8e45df96e42 upstream.
 
  This has been found to cause GPU hangs when backported to 3.2, though
  not in mainline.
[...]

We are actually using the DRM code from 3.4, not 3.2.  But this patch is
applied and should not be.  Thanks for finding this.

If anyone else would like to test and confirm that this fixes the hangs
they are seeing, please use the attached patch, following the
instructions at
http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-official.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
reverted:
--- b/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ a/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -407,11 +407,6 @@
 	if (INTEL_INFO(dev)-gen = 6)
 		I915_WRITE(MI_MODE, GFX_MODE_ENABLE(ASYNC_FLIP_PERF_DISABLE));
 
-	/* Required for the hardware to program scanline values for waiting */
-	if (INTEL_INFO(dev)-gen == 6)
-		I915_WRITE(GFX_MODE,
-			   GFX_MODE_ENABLE(GFX_TLB_INVALIDATE_ALWAYS));
-
 	if (IS_GEN7(dev))
 		I915_WRITE(GFX_MODE_GEN7,
 			   GFX_MODE_DISABLE(GFX_TLB_INVALIDATE_ALWAYS) |


signature.asc
Description: This is a digitally signed message part


Bug#703715: Kernel bug ALPS TouchPad and i915 DRM do not play nicely on Wheezy 3.2.0-4-amd64

2013-07-23 Thread Darren Williams



On 07/24/13 11:12, Ben Hutchings wrote:

On Tue, 2013-07-23 at 20:13 +1000, iiNET wrote:

Hi Kernel Maintainers

I have been tracking related bugs 704987 and 703715, I have suggested a
fix that has been under test for the last week and seems to fix the
reported issue, the following is the patch from the stable tree that
reverts Debian patch,
features/all/Input-add-Synaptics-USB-device-driver.patch.


I don't know how you think these are connected...

Aargh there not, should of said:
bugfix/x86/drm-i915-GFX_MODE-Flush-TLB-Invalidate-Mode-must-be-.
patch

Thanks for following up
Darren




Testing has been editing, creating and reading various Libre Office
files without any symptoms reported, all with various touch pad
interactions, suspend, resume.


commit e24fb4d67f53530038a9711d0c1f65937490bb8c
Author: Ben Hutchingsb...@decadent.org.uk
Date:   Tue Jun 25 04:15:27 2013 +0100

  Revert drm/i915: GFX_MODE Flush TLB Invalidate Mode must be  '1'
for scanli

  This reverts commit 393143615d9f2f581d87387268dc11b95adc339c, which
  was commit f05bb0c7b624252a5e768287e340e8e45df96e42 upstream.

  This has been found to cause GPU hangs when backported to 3.2, though
  not in mainline.

[...]

We are actually using the DRM code from 3.4, not 3.2.  But this patch is
applied and should not be.  Thanks for finding this.

If anyone else would like to test and confirm that this fixes the hangs
they are seeing, please use the attached patch, following the
instructions at
http://kernel-handbook.alioth.debian.org/ch-common-tasks.html#s-common-official.

Ben.



--

Darren Williams
IT Operations Manager
Australian Technology Park

National ICT Australia Limited
Level 5
13 Garden Street,
Eveleigh NSW 2015
Australia

Tel: (02) 8306 0517
Mob: 0409 835 793
Fax: (02) 8374 5558
Email: Darren.Williams AT nicta.com.au
Web: http://www.nicta.com.au

The imagination driving Australia's ICT future.



The information in this e-mail may be confidential and subject to legal 
professional privilege and/or copyright. National ICT Australia Limited accepts 
no liability for any damage caused by this email or its attachments.


--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/51ef3433.2050...@nicta.com.au



Bug#703715: Kernel bug ALPS TouchPad and i915 DRM do not play nicely on Wheezy 3.2.0-4-amd64

2013-07-15 Thread Darren Williams

Hi Guys

I have been tracking this bug since installing Wheezy a few weeks ago.

After a weekend of testing I discovered that this bug is related to the
ALPS DualPoint TouchPad device and the DRM i915 modules. More precisely
the scroll bar on the touch pad.

testing I have:

1. Built and run the earliest stable branch where the synaptic_usb code
was introduced, v3.4.0.
   I could not reproduce the bug.

2. stable tree 3.3.0  with patches
   features/all/Input-add-Synaptics-USB-device-driver.patch
   features/all/USB-add-USB_VENDOR_AND_INTERFACE_INFO-macro.patch

   I could not reproduce the bug

   Turned out I was chasing the wrong device though on the right path.

3. Tested 3.2.46 and 3.2.47 from the stable tree with with patches
   features/all/Input-ALPS-move-protocol-information-to-Documentatio.patch
   features/all/Input-ALPS-add-protocol-version-field-in-alps_model_.patch
   features/all/Input-ALPS-remove-assumptions-about-packet-size.patch
   features/all/Input-ALPS-add-support-for-protocol-versions-3-and-4.patch
   features/all/Input-ALPS-add-semi-MT-support-for-v3-protocol.patch
   features/all/Input-add-Synaptics-USB-device-driver.patch
   features/all/USB-add-USB_VENDOR_AND_INTERFACE_INFO-macro.patch

   Bug reproducible

4. Tested 3.2.48 from stable tree with patches
   features/all/Input-add-Synaptics-USB-device-driver.patch
   features/all/USB-add-USB_VENDOR_AND_INTERFACE_INFO-macro.patch

   I could not reproduce the bug

5. Possible fix candidate: e24fb4d67f53530038a9711d0c1f65937490bb8c

I'm no kernel expert and testing this bug is difficult, in some cases it
turns up as soon as you start Libre Office and start scrolling with the
touch pad, in others it may take 20 - 30 mins.

I'll run with patched 3.2.48 for a week and let you know the results

Details of my machine:
System Information
Manufacturer: Dell Inc.
Product Name: Latitude E6220
Product Name: 0R97MN
Version: A00
CPU: Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz
Mouse: AlpsPS/2 ALPS DualPoint TouchPad
VGA compatible controller: Intel Corporation 2nd Generation
Core Processor Family Integrated Graphics Controller (rev 09)

Hope this helps
Darren

--

Darren Williams
National ICT Australia Limited
Web: http://www.nicta.com.au
The imagination driving Australia's ICT future.



The information in this e-mail may be confidential and subject to legal 
professional privilege and/or copyright. National ICT Australia Limited accepts 
no liability for any damage caused by this email or its attachments.


--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/51e3ef1f.8040...@nicta.com.au