Bug#714092: installation-reports: wheezy install on QNAP TS-212 fails to write to flash
On Thu, 2013-07-18 at 20:50 +0100, Martin Michlmayr wrote: * Mike Miller mtmil...@ieee.org [2013-06-27 09:15]: FWIW, I successfully installed on this QNAP using a daily installer [1] running 3.9-1-kirkwood. Here is the dmesg snippet probing the flash, looks exactly like what you describe: Ben, can you please add the git comments listed here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=714092#12 Thanks! I've added the N25Q128 IDs but didn't bother with the 256 Mbit part (not needed for this system). So this should be fixed in Debian 7.2. Ben. -- Ben Hutchings Humans are not rational beings; they are rationalising beings. signature.asc Description: This is a digitally signed message part
Bug#714092: installation-reports: wheezy install on QNAP TS-212 fails to write to flash
* Ben Hutchings b...@decadent.org.uk [2013-07-20 22:40]: I've added the N25Q128 IDs but didn't bother with the 256 Mbit part (not needed for this system). So this should be fixed in Debian 7.2. Thanks! -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130721030313.gb17...@jirafa.cyrius.com
Bug#714092: installation-reports: wheezy install on QNAP TS-212 fails to write to flash
On Sat, Jul 20, 2013 at 20:03:14 -0700, Martin Michlmayr wrote: * Ben Hutchings b...@decadent.org.uk [2013-07-20 22:40]: I've added the N25Q128 IDs but didn't bother with the 256 Mbit part (not needed for this system). So this should be fixed in Debian 7.2. Thanks! Yes, thanks very much Ben! -- mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/CAD6LDL+K5uq7ur-6-K87C-jp+qrfTJdRfqoNkfhn_2p=qj7...@mail.gmail.com
Bug#714092: installation-reports: wheezy install on QNAP TS-212 fails to write to flash
* Mike Miller mtmil...@ieee.org [2013-06-27 09:15]: FWIW, I successfully installed on this QNAP using a daily installer [1] running 3.9-1-kirkwood. Here is the dmesg snippet probing the flash, looks exactly like what you describe: Ben, can you please add the git comments listed here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=714092#12 Thanks! -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130718195050.ga14...@jirafa.cyrius.com
Bug#714092: installation-reports: wheezy install on QNAP TS-212 fails to write to flash
* Mike Miller mtmil...@ieee.org [2013-06-27 09:15]: FWIW, I successfully installed on this QNAP using a daily installer [1] running 3.9-1-kirkwood. Here is the dmesg snippet probing the flash, looks exactly like what you describe: Ok, great! Ben, can you add the relevant patches? Thanks. -- Martin Michlmayr http://www.cyrius.com/ -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130629130309.gd25...@jirafa.cyrius.com
Bug#714092: installation-reports: wheezy install on QNAP TS-212 fails to write to flash
On Wed, Jun 26, 2013 at 01:13:58 +0100, Ben Hutchings wrote: My reading of the m25p_probe() function is that if the named chip has a JEDEC ID, and the chip it finds has a different JEDEC ID that's also in the device ID table, it will then automatically adapt (but will warn). So long as the same partition map is used for the two chips, I think the platform code should just probe once as now, though the warning is annoying. It seems like there ought to be a way to tell m25p80 to auto-detect and warn only if the size doesn't match the partition map. FWIW, I successfully installed on this QNAP using a daily installer [1] running 3.9-1-kirkwood. Here is the dmesg snippet probing the flash, looks exactly like what you describe: [8.328203] m25p80 spi0.0: found n25q128a13, expected m25p128 [8.334003] m25p80 spi0.0: n25q128a13 (16384 Kbytes) [8.338989] Creating 6 MTD partitions on spi_flash: [8.344074] 0x-0x0008 : U-Boot [8.349708] 0x0020-0x0040 : Kernel [8.355309] 0x0040-0x00d0 : RootFS1 [8.360987] 0x00d0-0x0100 : RootFS2 [8.366689] 0x0008-0x000c : U-Boot Config [8.372895] 0x000c-0x0020 : NAS Config [1] http://d-i.debian.org/daily-images/armel/20130625-08:44/kirkwood/network-console/qnap/ts-219/ -- mike -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130627131554.ga12...@xps14z.home.local
Processed: Re: Bug#714092: installation-reports: wheezy install on QNAP TS-212 fails to write to flash
Processing commands for cont...@bugs.debian.org: reassign 714092 linux Bug #714092 [installation-reports] installation-reports: wheezy install on QNAP TS-212 fails to write to flash Bug reassigned from package 'installation-reports' to 'linux'. Ignoring request to alter found versions of bug #714092 to the same values previously set Ignoring request to alter fixed versions of bug #714092 to the same values previously set -- Stopping processing here. Please contact me if you need assistance. -- 714092: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=714092 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.137218154615526.transcr...@bugs.debian.org
Bug#714092: installation-reports: wheezy install on QNAP TS-212 fails to write to flash
* Mike Miller mtmil...@ieee.org [2013-06-25 12:54]:
The relevant line from the installer syslog
Jun 25 15:35:14 kernel: [8.570234] m25p80 spi0.0: unrecognized JEDEC id
20ba18
This ID was added in:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/devices/m25p80.c?id=98a9e2450667e497246449f96eab06eb3fb4d24b
which depends on:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/devices/m25p80.c?id=3105875f6b8902628caee2fd7821af43707c6bde
and
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/devices/m25p80.c?id=8da28681eb1430fb6715c7aef67001acfbbbcba5
The other problem is that arch/arm/mach-kirkwood/tsx1x-common.c
contains:
static const struct flash_platform_data qnap_tsx1x_flash = {
.type = m25p128,
.name = spi_flash,
.parts = qnap_tsx1x_partitions,
.nr_parts = ARRAY_SIZE(qnap_tsx1x_partitions),
};
I'm not sure if .type is optional or if we have to create another
flash_platform_data structure and initialize both (and then one will
fail). Ben, do you know what the best solution would be for this?
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130625191049.gb29...@jirafa.cyrius.com
Bug#714092: installation-reports: wheezy install on QNAP TS-212 fails to write to flash
On Tue, 2013-06-25 at 20:10 +0100, Martin Michlmayr wrote:
* Mike Miller mtmil...@ieee.org [2013-06-25 12:54]:
The relevant line from the installer syslog
Jun 25 15:35:14 kernel: [8.570234] m25p80 spi0.0: unrecognized JEDEC
id 20ba18
This ID was added in:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/devices/m25p80.c?id=98a9e2450667e497246449f96eab06eb3fb4d24b
which depends on:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/devices/m25p80.c?id=3105875f6b8902628caee2fd7821af43707c6bde
and
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mtd/devices/m25p80.c?id=8da28681eb1430fb6715c7aef67001acfbbbcba5
The other problem is that arch/arm/mach-kirkwood/tsx1x-common.c
contains:
static const struct flash_platform_data qnap_tsx1x_flash = {
.type = m25p128,
.name = spi_flash,
.parts = qnap_tsx1x_partitions,
.nr_parts = ARRAY_SIZE(qnap_tsx1x_partitions),
};
I'm not sure if .type is optional or if we have to create another
flash_platform_data structure and initialize both (and then one will
fail). Ben, do you know what the best solution would be for this?
My reading of the m25p_probe() function is that if the named chip has a
JEDEC ID, and the chip it finds has a different JEDEC ID that's also in
the device ID table, it will then automatically adapt (but will warn).
So long as the same partition map is used for the two chips, I think the
platform code should just probe once as now, though the warning is
annoying. It seems like there ought to be a way to tell m25p80 to
auto-detect and warn only if the size doesn't match the partition map.
Ben.
--
Ben Hutchings
Knowledge is power. France is bacon.
signature.asc
Description: This is a digitally signed message part
