Bug#841044: Problem with gem network card

[Salvatore Bonaccorso]

Control: tags -1 + moreinfo

On Mon, Aug 27, 2018 at 12:14:58PM +0100, Mark Cave-Ayland wrote:
> On 27/08/18 10:39, Mathieu Malaterre wrote:
> 
> > Christian,
> > 
> > On Mon, Oct 17, 2016 at 9:32 AM Mathieu Malaterre  wrote:
> >>
> >> Hi,
> >>
> >> On Fri, Oct 14, 2016 at 4:45 PM, Thadeu Lima de Souza Cascardo
> >>  wrote:
> >>> There is certainly a way to automate this, but my question on whether
> >>> that sequence would fix the problem was intended to more easily fix a
> >>> real bug in the driver.
> >>>
> >>> I can try to help fix the driver on my free time as a volunteer.
> >>> Christian, would you be willing to test patches to the driver? That
> >>> would require some back and forth between us and some patience of yours,
> >>> as I would be doing it on my spare time, considering I have family and
> >>> other projects I would like to attend to as well.
> >>>
> >>> I don't have a PPC Macbook of my own, but I used to fix Linux drivers on
> >>> PPC64 for a living not too long ago.
> >>
> >> That's a good news ! Feel free to use the bug report #841044 to send
> >> your patch (and/or updates).
> > 
> > Any update on the patch ?
> > 
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841044#30
> 
> FWIW QEMU now has sungem emulation which may help when trying to track
> down overflow errors such as this.

Is this bug still relevant/present or can the bug be closed by now?

Regards,
Salvatore

Processed: Re: Bug#841044: Problem with gem network card

[Debian Bug Tracking System]

Processing control commands:

> tags -1 + moreinfo
Bug #841044 [src:linux] gem 0001:04:0f.0 eth0: RX MAC fifo overflow 
smac[03810400]
Added tag(s) moreinfo.

-- 
841044: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841044
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#841044: Problem with gem network card

[Mark Cave-Ayland]

On 27/08/18 10:39, Mathieu Malaterre wrote:

> Christian,
> 
> On Mon, Oct 17, 2016 at 9:32 AM Mathieu Malaterre  wrote:
>>
>> Hi,
>>
>> On Fri, Oct 14, 2016 at 4:45 PM, Thadeu Lima de Souza Cascardo
>>  wrote:
>>> There is certainly a way to automate this, but my question on whether
>>> that sequence would fix the problem was intended to more easily fix a
>>> real bug in the driver.
>>>
>>> I can try to help fix the driver on my free time as a volunteer.
>>> Christian, would you be willing to test patches to the driver? That
>>> would require some back and forth between us and some patience of yours,
>>> as I would be doing it on my spare time, considering I have family and
>>> other projects I would like to attend to as well.
>>>
>>> I don't have a PPC Macbook of my own, but I used to fix Linux drivers on
>>> PPC64 for a living not too long ago.
>>
>> That's a good news ! Feel free to use the bug report #841044 to send
>> your patch (and/or updates).
> 
> Any update on the patch ?
> 
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841044#30

FWIW QEMU now has sungem emulation which may help when trying to track
down overflow errors such as this.


ATB,

Mark.

Bug#841044: Problem with gem network card

[Mathieu Malaterre]

Christian,

On Mon, Oct 17, 2016 at 9:32 AM Mathieu Malaterre  wrote:
>
> Hi,
>
> On Fri, Oct 14, 2016 at 4:45 PM, Thadeu Lima de Souza Cascardo
>  wrote:
> > There is certainly a way to automate this, but my question on whether
> > that sequence would fix the problem was intended to more easily fix a
> > real bug in the driver.
> >
> > I can try to help fix the driver on my free time as a volunteer.
> > Christian, would you be willing to test patches to the driver? That
> > would require some back and forth between us and some patience of yours,
> > as I would be doing it on my spare time, considering I have family and
> > other projects I would like to attend to as well.
> >
> > I don't have a PPC Macbook of my own, but I used to fix Linux drivers on
> > PPC64 for a living not too long ago.
>
> That's a good news ! Feel free to use the bug report #841044 to send
> your patch (and/or updates).

Any update on the patch ?

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841044#30

Bug#841044: Problem with gem network card

[Thadeu Lima de Souza Cascardo]

Hey, Christian.

Can you build a patched kernel or a patched driver? If you need help, I
can provide some instructions later this week, after I do it myself on a
G4 I am about to put my hands on.

If you already know how to do it, the patch below does two things: it
will do a chip reset instead of only a MAC reset when there is an
overflow. I hope this will fix things for you, but I would like to do
more tests so we can find out why the MAC reset is not working so I can
convince upstream to accept such an approach (which would require a
different patch).

The second thing it does is accept an ioctl to do the MAC and chip
reset, likely during normal operation. This will require a small
userspace program I will send later, so we can test whether the MAC and
chip reset work under light load on the card. The test would go this
way: setup the interface up, issue one of the resets, then try to use
the network. If it works fine, great, the reset didn't break anything,
and we need to investigate the specific occasion when there is an
overflow. If things stop working, then the reset itself is causing the
problem.

Thanks.
Cascardo.
---
diff --git a/drivers/net/ethernet/sun/sungem.c 
b/drivers/net/ethernet/sun/sungem.c
index d6ad0fb..e140363 100644
--- a/drivers/net/ethernet/sun/sungem.c
+++ b/drivers/net/ethernet/sun/sungem.c
@@ -473,6 +473,10 @@ static int gem_rxmac_interrupt(struct net_device *dev, 
struct gem *gp, u32 gem_s
dev->stats.rx_fifo_errors++;
 
ret = gem_rxmac_reset(gp);
+   if (ret == 0) {
+   netdev_err(dev, "RXMAC reset succeeded, will reset 
everything anyway.\n");
+   ret = 1;
+   }
}
 
if (rxmac_stat & MAC_RXSTAT_ACE)
@@ -2705,6 +2709,13 @@ static int gem_ioctl(struct net_device *dev, struct 
ifreq *ifr, int cmd)
data->val_in);
rc = 0;
break;
+   case SIOCDEVPRIVATE:
+   rc = gem_rxmac_reset(gp);
+   break;
+   case SIOCDEVPRIVATE + 1:
+   gem_schedule_reset(gp);
+   rc = 0;
+   break;
}
return rc;
 }

Bug#841044: Problem with gem network card

[Mathieu Malaterre]

Hi,

On Fri, Oct 14, 2016 at 4:45 PM, Thadeu Lima de Souza Cascardo
 wrote:
> There is certainly a way to automate this, but my question on whether
> that sequence would fix the problem was intended to more easily fix a
> real bug in the driver.
>
> I can try to help fix the driver on my free time as a volunteer.
> Christian, would you be willing to test patches to the driver? That
> would require some back and forth between us and some patience of yours,
> as I would be doing it on my spare time, considering I have family and
> other projects I would like to attend to as well.
>
> I don't have a PPC Macbook of my own, but I used to fix Linux drivers on
> PPC64 for a living not too long ago.

That's a good news ! Feel free to use the bug report #841044 to send
your patch (and/or updates).

Regards.