Bug#883194: please convert mountstats and nfsiostat scripts to Python3
On 2021-06-28 00:35, Diederik de Haas wrote: On zondag 27 juni 2021 22:37:10 CEST Salvatore Bonaccorso wrote: Let's ask the release team instead. Here my arguments why: nfs-utils needs a major rehaul, this was not possible to finish in time for bullseye, so this means nfs-utils is generally in not a very good shape for bullseye,details in https://salsa.debian.org/kernel-team/nfs-utils/-/merge_requests/3 . That overhaul/MR is indeed out of scope for Bullseye. Agreed, we don't want to make a major rehaul here. But unless I misunderstood, here we only need to update shebangs, as Diederik and Laurent mentioned. Jann Haber prepared a small PR, https://salsa.debian.org/kernel-team/nfs-utils/-/merge_requests/4 Is anything more than that needed for updating the python2 Recommends to python3? Drew
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
On zondag 27 juni 2021 22:37:10 CEST Salvatore Bonaccorso wrote: > Let's ask the release team instead. Here my arguments why: nfs-utils > needs a major rehaul, this was not possible to finish in time for > bullseye, so this means nfs-utils is generally in not a very good > shape for bullseye,details in > https://salsa.debian.org/kernel-team/nfs-utils/-/merge_requests/3 . That overhaul/MR is indeed out of scope for Bullseye. But as Laurent Bigonville already said: > So it's just a matter of changing the shebang and the dependency. (It's actually a Recommends) Without that fix, many Bullseye systems will get python2 because of NFS, and several people have already verified that it works just fine with python3. My €0.02 signature.asc Description: This is a digitally signed message part.
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
Hi Drew, On Sun, Jun 27, 2021 at 10:37:14PM +0200, Salvatore Bonaccorso wrote: > Hi, > > On Sun, Jun 27, 2021 at 04:46:36PM +0200, Drew Parsons wrote: > > Package: nfs-common > > Followup-For: Bug #883194 > > X-Debbugs-Cc: debian-rele...@lists.debian.org > > Control: severity 883194 serious > > Control: usertag 883194 py2removal > > > > Since removing Python2 is a release goal for bullseye (other packages > > have been removed because of their python2 dependencies), and since > > the fix for this bug in nfs-common is trivial, I'm flagging this bug > > as RC. > > Let's ask the release team instead. Here my arguments why: nfs-utils > needs a major rehaul, this was not possible to finish in time for > bullseye, so this means nfs-utils is generally in not a very good > shape for bullseye,details in > https://salsa.debian.org/kernel-team/nfs-utils/-/merge_requests/3 . > > I would rather not touch at this stage of the release for bullseye > nfs-utils anymore, instead we should try to rewamp asap after the > bullseye release so we can make sure nfs-utils is proper again for > bookworm. > > Release team, do you want a fix this late still for #883194 ? forgot to metion: if the Release team agrees on the late fix for it sitll, I'm happy to do it and ask for an unblock. Regards, Salvatore
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
Hi, On Sun, Jun 27, 2021 at 04:46:36PM +0200, Drew Parsons wrote: > Package: nfs-common > Followup-For: Bug #883194 > X-Debbugs-Cc: debian-rele...@lists.debian.org > Control: severity 883194 serious > Control: usertag 883194 py2removal > > Since removing Python2 is a release goal for bullseye (other packages > have been removed because of their python2 dependencies), and since > the fix for this bug in nfs-common is trivial, I'm flagging this bug > as RC. Let's ask the release team instead. Here my arguments why: nfs-utils needs a major rehaul, this was not possible to finish in time for bullseye, so this means nfs-utils is generally in not a very good shape for bullseye,details in https://salsa.debian.org/kernel-team/nfs-utils/-/merge_requests/3 . I would rather not touch at this stage of the release for bullseye nfs-utils anymore, instead we should try to rewamp asap after the bullseye release so we can make sure nfs-utils is proper again for bookworm. Release team, do you want a fix this late still for #883194 ? Regards, Salvatore
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
Package: nfs-common Followup-For: Bug #883194 X-Debbugs-Cc: debian-rele...@lists.debian.org Control: severity 883194 serious Control: usertag 883194 py2removal Since removing Python2 is a release goal for bullseye (other packages have been removed because of their python2 dependencies), and since the fix for this bug in nfs-common is trivial, I'm flagging this bug as RC. Drew
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
On maandag 21 juni 2021 13:20:46 CEST Drew Parsons wrote: > I was surprised to see python2 pulled in on a new bullseye > installation using nfs. > > It's a trivial patch of course to update the hashbangs for mountstats > and nfsiostat in nfs-common 1:1.3.4-5 to python3. https://salsa.debian.org/kernel-team/nfs-utils/-/merge_requests/4 has been submitted 9 months ago, which does exactly that. signature.asc Description: This is a digitally signed message part.
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
Package: nfs-common Followup-For: Bug #883194 X-Debbugs-Cc: debian-rele...@lists.debian.org I was surprised to see python2 pulled in on a new bullseye installation using nfs. It's a trivial patch of course to update the hashbangs for mountstats and nfsiostat in nfs-common 1:1.3.4-5 to python3. As far as I can see the scripts are python3 compatible. Upstream history at http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=history;f=tools/mountstats/mountstats.py;hb=d1683f356bd920d93f2db007902b2c46f97a2e49 http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=history;f=tools/nfs-iostat/nfs-iostat.py;hb=d1683f356bd920d93f2db007902b2c46f97a2e49 indicates the scripts were patched in July 2014 to work with python3 Should Bug#883194 be considered RC and the patch applied now?
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
On Tue, 22 Oct 2019 20:34:44 +0200 Laurent Bigonville wrote: > On Thu, 30 Nov 2017 16:37:52 +0100 Matthias Klose wrote: > > > > the changelog reads: > > > > - nfs-common: Add Recommends python for mountstats and nfsiostat > > > > Please convert these scripts to python3, and recommend Python3 instead. > > I think they should already be compatible with python3 since 1.2.9 (or > 1.3.1) if I'm looking at upstream git repository: > > http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=9f9289efda1a7eff26cd046997efc56c2de40534 > > http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=1df82a36df74a59f55eea99d08612564fa22cbef > > So it's just a matter of changing the shebang and the dependency. Those code changes are included in the version of mountstats and nfsiostat on my Sid system. http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=d1683f356bd920d93f2db007902b2c46f97a2e49 is the commit where the shebang is replaced to python3 and that commit is included in version nfs-utils-2-5-2-rc4 https://salsa.debian.org/kernel-team/nfs-utils/-/tree/upstream already contains 2.5.1 and according to https://bugs.debian.org/cgi-bin/bugreport.cgi? bug=925022#10 it is a WIP by the kernel team. OTOH, the "Transition and (build-)essentials Freeze" is only 3 months out and nfs-utils will go from version 1.3.4 to 2.5.x which is quite a leap ... So it seems to me that a rather imminent release would be highly preferable if it is to be part of Bullseye signature.asc Description: This is a digitally signed message part.
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
Hello, recently Debian removed the binary package "python" from sid and testing, thus breaking the Recommends: for nfs-common. The affected scripts should be converted to Python 3 and the Recommend: field should be updated accordingly. Regards, Gabriele Stilli
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
On Thu, 30 Nov 2017 16:37:52 +0100 Matthias Klose wrote: > > the changelog reads: > > - nfs-common: Add Recommends python for mountstats and nfsiostat > > Please convert these scripts to python3, and recommend Python3 instead. > I think they should already be compatible with python3 since 1.2.9 (or 1.3.1) if I'm looking at upstream git repository: http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=9f9289efda1a7eff26cd046997efc56c2de40534 http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=1df82a36df74a59f55eea99d08612564fa22cbef So it's just a matter of changing the shebang and the dependency. Question, why is this a recommends? The executable is using python(3) without any fallback mechanism I can understand that this is a "not often use binary", but shouldn't that be changed to a Depends?
Bug#883194: please convert mountstats and nfsiostat scripts to Python3
Package: nfs-utils Version: 1:1.3.4-2.1 User: debian-pyt...@lists.debian.org Usertags: py2-removal the changelog reads: - nfs-common: Add Recommends python for mountstats and nfsiostat Please convert these scripts to python3, and recommend Python3 instead.
