Re: Proposed changes to initramfs-tools hook scripts
On Fri, 02 Jul 2010, maximilian attems wrote: On Wed, 30 Jun 2010, Stephen Powell wrote: Max, As promised, here are my proposed changes to the initramfs-tools hook scripts. /etc/kernel/postinst.d/initramfs-tools: http://www.wowway.com/~zlinuxman/kernel/postinst.d/initramfs-tools /etc/kernel/postrm.d/initramfs-tools: http://www.wowway.com/~zlinuxman/kernel/postrm.d/initramfs-tools I release the changes under the same license as currently used. I did not include the scripts or patches in-line in my e-mail because my e-mail client has the nasty habit of expanding tabs, inserting extra line breaks, etc. So I up-loaded the files to my web site and included links to them in this e-mail. Changes: (1) Does not create an initial RAM file system image for a custom kernel created by make-kpkg if one was not requested by the --initrd flag of make-kpkg. (2) Redirects STDOUT to STDERR when invoking update-initramfs. (Avoids output being swallowed by debconf's redirection of STDOUT.) (3) Postinst.d version always exits with status code zero, even if an error occurs attempting to delete the initramfs. thank you very much. applied your 3 changes to branch maks/hooks on http://git.debian.org/?p=kernel/initramfs-tools.git;a=summary please review before I'd merge into master for next upload. I'm not sure if the indirection to STDERR is needed for make deb-pkg, but it shouldn't hurt there? so mika reviewed http://git.debian.org/?p=kernel/initramfs-tools.git;a=shortlog;h=refs/heads/maks/hooks he critisize the exit 0 without any stdout/stderr message. so rethinking why do you want that anyway? I do not see the point of it, update-initramfs is already told to not care if that initramfs exists with the takeover flag so will not errexit. thanks -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100708132402.gc2...@stro.at
Re: Proposed changes to initramfs-tools hook scripts
On Thu, 08 Jul 2010 09:24:02 -0400 (EDT), maximilian attems wrote: so mika reviewed http://git.debian.org/?p=kernel/initramfs-tools.git;a=shortlog;h=refs/heads/maks/hooks he critisize the exit 0 without any stdout/stderr message. so rethinking why do you want that anyway? I do not see the point of it, update-initramfs is already told to not care if that initramfs exists with the takeover flag so will not errexit. You're right. With the -t flag, attempting to delete a non-existent initial RAM file system does not cause an error exit. Exit status is zero, even if the file does not exist. The exit 0 is unnecessary. Good catch, Mika! -- .''`. Stephen Powell : :' : `. `'` `- -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1884856145.37359.1278598343367.javamail.r...@md01.wow.synacor.com
Re: Proposed changes to initramfs-tools hook scripts
On Fri, 02 Jul 2010 02:20:45 -0400 (EDT), maximilian attems wrote: On Wed, 30 Jun 2010, Stephen Powell wrote: As promised, here are my proposed changes to the initramfs-tools hook scripts. thank you very much. applied your 3 changes to branch maks/hooks on http://git.debian.org/?p=kernel/initramfs-tools.git;a=summary please review before I'd merge into master for next upload. I just reviewed them. They look good to me. -- .''`. Stephen Powell : :' : `. `'` `- -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1762086613.144660.1278180301574.javamail.r...@md01.wow.synacor.com
Re: Proposed changes to initramfs-tools hook scripts
On Wed, 30 Jun 2010, Stephen Powell wrote: Max, As promised, here are my proposed changes to the initramfs-tools hook scripts. /etc/kernel/postinst.d/initramfs-tools: http://www.wowway.com/~zlinuxman/kernel/postinst.d/initramfs-tools /etc/kernel/postrm.d/initramfs-tools: http://www.wowway.com/~zlinuxman/kernel/postrm.d/initramfs-tools I release the changes under the same license as currently used. I did not include the scripts or patches in-line in my e-mail because my e-mail client has the nasty habit of expanding tabs, inserting extra line breaks, etc. So I up-loaded the files to my web site and included links to them in this e-mail. Changes: (1) Does not create an initial RAM file system image for a custom kernel created by make-kpkg if one was not requested by the --initrd flag of make-kpkg. (2) Redirects STDOUT to STDERR when invoking update-initramfs. (Avoids output being swallowed by debconf's redirection of STDOUT.) (3) Postinst.d version always exits with status code zero, even if an error occurs attempting to delete the initramfs. thank you very much. applied your 3 changes to branch maks/hooks on http://git.debian.org/?p=kernel/initramfs-tools.git;a=summary please review before I'd merge into master for next upload. I'm not sure if the indirection to STDERR is needed for make deb-pkg, but it shouldn't hurt there? you may want to have a look at for initramfs-tools dev http://git.debian.org/?p=kernel/initramfs-tools.git;a=blob_plain;f=docs/maintainer-notes.html;h=eeceafdfc498bd6585328d1eeb52e6e454d524ee;hb=HEAD changes in git send-email or online git repo are easier to handle. Although not strictly within your jurisdiction, I will also send you another e-mail soon with links to my proposed boot loader hook script for lilo and zipl. I'd like you to take a look at it to make sure that everything is going to flow together smoothly. I'm talking about the kernel hook script at this point, not the initramfs hook script. okay cool. -- maks -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100702062045.ga4...@stro.at
Re: Proposed changes to initramfs-tools hook scripts
On Fri, 02 Jul 2010 02:20:45 -0400 (EDT), maximilian attems wrote: On Wed, 30 Jun 2010, Stephen Powell wrote: Max, As promised, here are my proposed changes to the initramfs-tools hook scripts. ... thank you very much. applied your 3 changes to branch maks/hooks on http://git.debian.org/?p=kernel/initramfs-tools.git;a=summary please review before I'd merge into master for next upload. I'll take a look at those tonight, the Lord willing. I'm not sure if the indirection to STDERR is needed for make deb-pkg, but it shouldn't hurt there? It all depends on whether debconf is active or not. If it is, then it's necessary. If it's not, it won't hurt anything. you may want to have a look at for initramfs-tools dev http://git.debian.org/?p=kernel/initramfs-tools.git;a=blob_plain;f=docs/maintainer-notes.html;h=eeceafdfc498bd6585328d1eeb52e6e454d524ee;hb=HEAD changes in git send-email or online git repo are easier to handle. I'll take a look at that too. There are so many new things to learn all at once! -- .''`. Stephen Powell : :' : `. `'` `- -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/874427008.133057.1278106852146.javamail.r...@md01.wow.synacor.com
