Re: Speakup modules in squeeze

2009-10-14 Thread Samuel Thibault
Ben Hutchings, le Wed 14 Oct 2009 03:52:20 +0100, a écrit :
 On Wed, 2009-10-14 at 03:12 +0200, Samuel Thibault wrote:
 [...]
   Those modules that may be needed at installation time will be added to
   the linux-2.6 package, and the speakup modules are clearly among those.
   I have added patches that put them under drivers/staging:
   
   svn://svn.debian.org/svn/kernel/dists/trunk/linux-2.6/debian/patches/features/all/speakup/
  
   Please review these
  
  So speakup-add.patch would always be a mere copy of speakup-source?
 
 Yes, or you could drop speakup-source.
 
  Speakup-kbuild.patch seems just right and will probably never have to
  change.
  
   and let the kernel team know whenever speakup needs to be updated.
  
  Mmm, couldn't linux-2.6 build-depend on speakup-source and just
  automatically import the source from there?
 
 No, that just moves the problem we have now to linux-2.6.

Ok, so basically speakup could now only contain the tools and we'll push
the kernel modules as needed to linux-2.6 itself.

I think we should still keep speakup-source for people who are compiling
their own vanilla kernel or such.

Thanks,
Samuel


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: Speakup modules in squeeze

2009-10-14 Thread maximilian attems
On Wed, Oct 14, 2009 at 01:54:47AM +0100, Ben Hutchings wrote:
 
 Please review these and let the kernel team know whenever speakup needs
 to be updated.  Currently staging drivers are only built for x86 because
 many of them are not really portable.  I think this is not the case for
 speakup, so let me know if it should be built for more architectures.
 

great, as code quality does not satisfy upstream yet,
can we also add the taint flag on load for those.
didn't check if it already happens for aufs and speakup.


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: Speakup modules in squeeze

2009-10-14 Thread Ben Hutchings
On Wed, 2009-10-14 at 12:56 +0200, maximilian attems wrote:
 On Wed, Oct 14, 2009 at 01:54:47AM +0100, Ben Hutchings wrote:
  
  Please review these and let the kernel team know whenever speakup needs
  to be updated.  Currently staging drivers are only built for x86 because
  many of them are not really portable.  I think this is not the case for
  speakup, so let me know if it should be built for more architectures.
  
 
 great, as code quality does not satisfy upstream yet,
 can we also add the taint flag on load for those.
 didn't check if it already happens for aufs and speakup.

This is already done.  The taint flag is added when a module is loaded
and its module info includes the keyword 'staging'.  modpost adds this
to all modules built under drivers/staging, and I included a patch to
add this to aufs2.

Ben.

-- 
Ben Hutchings
I'm not a reverse psychological virus.  Please don't copy me into your sig.


signature.asc
Description: This is a digitally signed message part


Re: Speakup modules in squeeze

2009-10-14 Thread maximilian attems
On Wed, 14 Oct 2009, Ben Hutchings wrote:

 On Wed, 2009-10-14 at 12:56 +0200, maximilian attems wrote:
  On Wed, Oct 14, 2009 at 01:54:47AM +0100, Ben Hutchings wrote:
   
   Please review these and let the kernel team know whenever speakup needs
   to be updated.  Currently staging drivers are only built for x86 because
   many of them are not really portable.  I think this is not the case for
   speakup, so let me know if it should be built for more architectures.
   
  
  great, as code quality does not satisfy upstream yet,
  can we also add the taint flag on load for those.
  didn't check if it already happens for aufs and speakup.
 
 This is already done.  The taint flag is added when a module is loaded
 and its module info includes the keyword 'staging'.  modpost adds this
 to all modules built under drivers/staging, and I included a patch to
 add this to aufs2.

very nice indeed. thanks


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Speakup modules in squeeze

2009-10-13 Thread Ben Hutchings
There is a big problem with the current linux-modules-extra-2.6 package,
which is that the resulting binary packages are related to their source
only by build-dependency, and this does not ensure that corresponding
source and binary packages are kept released together.  The FTP team had
to spend a long time making sure this happened for lenny and is not
prepared to do so again.  Therefore, linux-modules-extra-2.6 will be
removed and not included in squeeze.

Those modules that may be needed at installation time will be added to
the linux-2.6 package, and the speakup modules are clearly among those.
I have added patches that put them under drivers/staging:

svn://svn.debian.org/svn/kernel/dists/trunk/linux-2.6/debian/patches/features/all/speakup/

Please review these and let the kernel team know whenever speakup needs
to be updated.  Currently staging drivers are only built for x86 because
many of them are not really portable.  I think this is not the case for
speakup, so let me know if it should be built for more architectures.

Ben.

-- 
Ben Hutchings
For every action, there is an equal and opposite criticism. - Harrison


signature.asc
Description: This is a digitally signed message part


Re: Speakup modules in squeeze

2009-10-13 Thread Samuel Thibault
Hello,

Ben Hutchings, le Wed 14 Oct 2009 01:54:47 +0100, a écrit :
 There is a big problem with the current linux-modules-extra-2.6 package,
 which is that the resulting binary packages are related to their source
 only by build-dependency, and this does not ensure that corresponding
 source and binary packages are kept released together.

Yes, that was a source of confusion for the users too.

 Those modules that may be needed at installation time will be added to
 the linux-2.6 package, and the speakup modules are clearly among those.
 I have added patches that put them under drivers/staging:
 
 svn://svn.debian.org/svn/kernel/dists/trunk/linux-2.6/debian/patches/features/all/speakup/

 Please review these

So speakup-add.patch would always be a mere copy of speakup-source?

Speakup-kbuild.patch seems just right and will probably never have to
change.

 and let the kernel team know whenever speakup needs to be updated.

Mmm, couldn't linux-2.6 build-depend on speakup-source and just
automatically import the source from there?

 Currently staging drivers are only built for x86 because
 many of them are not really portable.  I think this is not the case for
 speakup, so let me know if it should be built for more architectures.

Speakup should build and work on basically all archs (it was tested on
both 32 and 64bit platforms, and both little and big endians).

Samuel


-- 
To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: Speakup modules in squeeze

2009-10-13 Thread Ben Hutchings
On Wed, 2009-10-14 at 03:12 +0200, Samuel Thibault wrote:
[...]
  Those modules that may be needed at installation time will be added to
  the linux-2.6 package, and the speakup modules are clearly among those.
  I have added patches that put them under drivers/staging:
  
  svn://svn.debian.org/svn/kernel/dists/trunk/linux-2.6/debian/patches/features/all/speakup/
 
  Please review these
 
 So speakup-add.patch would always be a mere copy of speakup-source?

Yes, or you could drop speakup-source.

 Speakup-kbuild.patch seems just right and will probably never have to
 change.
 
  and let the kernel team know whenever speakup needs to be updated.
 
 Mmm, couldn't linux-2.6 build-depend on speakup-source and just
 automatically import the source from there?

No, that just moves the problem we have now to linux-2.6.

  Currently staging drivers are only built for x86 because
  many of them are not really portable.  I think this is not the case for
  speakup, so let me know if it should be built for more architectures.
 
 Speakup should build and work on basically all archs (it was tested on
 both 32 and 64bit platforms, and both little and big endians).

OK.

Ben.

-- 
Ben Hutchings
For every action, there is an equal and opposite criticism. - Harrison


signature.asc
Description: This is a digitally signed message part