Re: netxen_nic support for unified firmware images
On Fri, Sep 03, 2010 at 11:55:42PM +0100, Ben Hutchings wrote: On Thu, 2010-09-02 at 17:20 -0600, dann frazier wrote: I'd like to propose we add support for unified firmware images for netxen nics for squeeze. HP ships servers with netxen controllers, and we've seen problems with old firmware/new driver combinations - basically the network runs ridiculously slow, causing network installs to take many hours. Flashing to the latest firmware resolves the issues - but flashing a system (or 50) before install can be a pain (once you've finally identified firmware as the problem). There's an online flash tool you can use post-install but, as of this writing, it is not very Debian friendly (distributed in an RPM, needs out of tree driver, script has incompatible paths/bashisms). netxen_nic can load updated firmware via request_firmware, and recently a firmware blob got accepted into the linux-firmware tree w/ a non-free-compatible license, specifically for this reason. However, this blob is in a newer unified format that the 2.6.32 driver didn't yet support. This patch cherry picks the change to add support for the unified rom image, as well as several fixes that came after. I prefer to deal with individual patches as it's easier to compare them with the upstream version that way. I'm not sure how much that matters here. Thanks for the review, and sorry for my slow response. Yeah, I also like to keep track of individual patches, but in this case I did so by just keeping the changeset summaries at the top of the unified patch. I have all of them stored as such in a local git tree if we decide to go that way. In addition, I'd like to also package the firmware blob. The blob alone is 1.7 MB, whereas the entire contents of firmware-linux-nonfree is 940K. That implies to me that it should be a new binary package, but I don't feel strongly about that. It should be. k. I'll commit the changes I have queued for this new package then. Any objections to these changes? AFAIK only HP shipped many of these NICs so if you (wearing your HP hat) are happy with the changes then that's good enough for me. da...@hp.com I am, thanks. -- dann frazier -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100908153602.ga31...@lackof.org
Re: netxen_nic support for unified firmware images
On Thu, 2010-09-02 at 17:20 -0600, dann frazier wrote: I'd like to propose we add support for unified firmware images for netxen nics for squeeze. HP ships servers with netxen controllers, and we've seen problems with old firmware/new driver combinations - basically the network runs ridiculously slow, causing network installs to take many hours. Flashing to the latest firmware resolves the issues - but flashing a system (or 50) before install can be a pain (once you've finally identified firmware as the problem). There's an online flash tool you can use post-install but, as of this writing, it is not very Debian friendly (distributed in an RPM, needs out of tree driver, script has incompatible paths/bashisms). netxen_nic can load updated firmware via request_firmware, and recently a firmware blob got accepted into the linux-firmware tree w/ a non-free-compatible license, specifically for this reason. However, this blob is in a newer unified format that the 2.6.32 driver didn't yet support. This patch cherry picks the change to add support for the unified rom image, as well as several fixes that came after. I prefer to deal with individual patches as it's easier to compare them with the upstream version that way. I'm not sure how much that matters here. In addition, I'd like to also package the firmware blob. The blob alone is 1.7 MB, whereas the entire contents of firmware-linux-nonfree is 940K. That implies to me that it should be a new binary package, but I don't feel strongly about that. It should be. Any objections to these changes? AFAIK only HP shipped many of these NICs so if you (wearing your HP hat) are happy with the changes then that's good enough for me. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. signature.asc Description: This is a digitally signed message part
netxen_nic support for unified firmware images
I'd like to propose we add support for unified firmware images for netxen nics for squeeze. HP ships servers with netxen controllers, and we've seen problems with old firmware/new driver combinations - basically the network runs ridiculously slow, causing network installs to take many hours. Flashing to the latest firmware resolves the issues - but flashing a system (or 50) before install can be a pain (once you've finally identified firmware as the problem). There's an online flash tool you can use post-install but, as of this writing, it is not very Debian friendly (distributed in an RPM, needs out of tree driver, script has incompatible paths/bashisms). netxen_nic can load updated firmware via request_firmware, and recently a firmware blob got accepted into the linux-firmware tree w/ a non-free-compatible license, specifically for this reason. However, this blob is in a newer unified format that the 2.6.32 driver didn't yet support. This patch cherry picks the change to add support for the unified rom image, as well as several fixes that came after. In addition, I'd like to also package the firmware blob. The blob alone is 1.7 MB, whereas the entire contents of firmware-linux-nonfree is 940K. That implies to me that it should be a new binary package, but I don't feel strongly about that. Any objections to these changes? diff --git a/sid/linux-2.6/debian/changelog b/sid/linux-2.6/debian/changelog index 56d05b1..2474c4a 100644 --- a/sid/linux-2.6/debian/changelog +++ b/sid/linux-2.6/debian/changelog @@ -35,6 +35,9 @@ linux-2.6 (2.6.32-22) UNRELEASED; urgency=low [ Bastian Blank ] * Use Breaks instead of Conflicts. + [ dann frazier ] + * netxen_nic: add support for loading unified firmware images + -- Ben Hutchings b...@decadent.org.uk Fri, 27 Aug 2010 08:38:26 +0100 linux-2.6 (2.6.32-21) unstable; urgency=high diff --git a/sid/linux-2.6/debian/patches/features/all/netxen-unified-fw-image.patch b/sid/linux-2.6/debian/patches/features/all/netxen-unified-fw-image.patch new file mode 100644 index 000..04294e0 --- /dev/null +++ b/sid/linux-2.6/debian/patches/features/all/netxen-unified-fw-image.patch @@ -0,0 +1,1566 @@ +commit 5fe4d5c338291bbd504b8ebbd4d3931adfa61772 +Author: Amit Kumar Salecha amit.sale...@qlogic.com +Date: Mon Mar 29 02:43:44 2010 + + +netxen: fix fw load from file + +Rarely: Fw file size can be unaligned to 8. + +Signed-off-by: Amit Kumar Salecha amit.sale...@qlogic.com +Signed-off-by: David S. Miller da...@davemloft.net + +commit 3111bf7ed99902687728eeec2ad068c2a7f8e5f0 +Author: Rajesh K Borundia rajesh.borun...@qlogic.com +Date: Mon Mar 29 02:43:43 2010 + + +netxen: validate unified romimage + +Signed-off-by: Rajesh K Borundia rajesh.borun...@qlogic.com +Signed-off-by: Amit Kumar Salecha amit.sale...@qlogic.com + +Validate all sections of unified romimage, before accessing them, + to avoid seg fault. + +Signed-off-by: Amit Kumar Salecha amit.sale...@qlogic.com +Signed-off-by: David S. Miller da...@davemloft.net + +commit e9c75051c380aa07e237fd271a191f71cc5b79ef +Author: Amit Kumar Salecha amit.sale...@qlogic.com +Date: Fri Mar 26 00:30:07 2010 + + +netxen: fix bios version calculation + +Bios sub version from unified fw image is calculated incorrect. + +Signed-off-by: Amit Kumar Salecha amit.sale...@qlogic.com +Signed-off-by: David S. Miller da...@davemloft.net + +commit 31ae5cfdfd99db77ef6f213d4c35422320356d3b +Author: Amit Kumar Salecha amit.sale...@qlogic.com +Date: Tue Dec 8 20:40:57 2009 + + +netxen: fix unified fw size check + +o Unified firmware image size can be 1 MB + +Signed-off-by: Amit Kumar Salecha amit.sale...@qlogic.com +Signed-off-by: David S. Miller da...@davemloft.net + +commit fd1ae25890ba3e63c62f4ba53519ec21bcc7181b +Author: Dhananjay Phadke dhanan...@netxen.com +Date: Sat Dec 5 12:23:56 2009 + + +netxen: fix firmware type check + +Unified firmware image may not contain MN type of firmware. +Driver should fall back to NOMN firmware type instead +of going to flash. + +Signed-off-by: Dhananjay Phadke dhanan...@netxen.com +Signed-off-by: Amit Kumar Salecha amit.sale...@qlogic.com +Signed-off-by: David S. Miller da...@davemloft.net + +commit 629073465ea87a2f5792225dc4647b9f965ee2d3 +Author: Amit Kumar Salecha a...@netxen.com +Date: Sat Oct 24 16:03:58 2009 + + +netxen: support for new firmware file format + +Add support for extracting firmware from a unified +file format which embeds firmware images for all chip +revisions. Fallback to orginal file formats if new +image is not found. + +Signed-off-by: Amit Kumar Salecha a...@netxen.com +Signed-off-by: Dhananjay Phadke dhanan...@netxen.com +Signed-off-by: David S. Miller da...@davemloft.net + +commit 57cf596bef5692dc543b846cd1c05ea075270741 +Author: Dhananjay Phadke
