Re: Bug#109642: debhelper: Simplify inclusion of lintian overrides

2006-01-22 Thread Raphael Hertzog
On Sat, 21 Jan 2006, Russ Allbery wrote:
  But IMHO, debian/package.lintian-overrides should automatically be
  installed in /usr/share/lintian/overrides/package by one of the dh_*
  script (maybe dh_lintian could be folded into a generic dh_ script?).
 
 Please make it just package.lintian; the directory listing of the debian
 directory is bad enough as is without adding more extra-wide filenames.

I was proposing this name in consistency with the filename needed by
lintian for source overrides which is source.lintian-overrides
according to the doc.

Howewer lintian could be changed to accept both the short and the long
version.

Cheers,
-- 
Raphaël Hertzog

Premier livre français sur Debian GNU/Linux :
http://www.ouaza.com/livre/admin-debian/



Bug#349273: lintian: allow quilt in Build-Depends

2006-01-22 Thread Frank Lichtenheld
On Sat, Jan 21, 2006 at 02:48:05PM -0800, Russ Allbery wrote:
 Not sure if anyone has started using quilt for an arch-independent package
 yet, but since the debian/rules glue works the same as dpatch, it too must
 be present during debian/rules clean and therefore must be in Build-Depends
 rather than Build-Depends-Indep.  May as well head off the problem in
 advance.  The attached patch adds that case.

Hmm, I see you sending a lot of patches these days. Could you please
get you an account in lintian's SVN repository
(See http://svn.wolffelaar.nl/)? Especially for trivial patches
like this one I would really prefer if you commit them yourself...

Gruesse,
-- 
Frank Lichtenheld [EMAIL PROTECTED]
www: http://www.djpig.de/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r550 - trunk/debian

2006-01-22 Thread rra
Author: rra
Date: 2006-01-22 22:06:55 +0100 (Sun, 22 Jan 2006)
New Revision: 550

Modified:
   trunk/debian/changelog
Log:
Distribution should be UNRELEASED for now.


Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2006-01-22 21:04:58 UTC (rev 549)
+++ trunk/debian/changelog  2006-01-22 21:06:55 UTC (rev 550)
@@ -1,4 +1,4 @@
-lintian (1.23.16) unstable; urgency=low
+lintian (1.23.16) UNRELEASED; urgency=low
 
   * checks/fields:
 + [RA] Allow a quilt build-dependency for arch-independent packages if


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#347510: lintian: menu-icon-not-in-xpm-format needs updating/removing

2006-01-22 Thread Russ Allbery
Paul Wise [EMAIL PROTECTED] writes:
 On Sat, 2006-01-21 at 15:03 -0800, Russ Allbery wrote:

  Aha, so that is where it is. Well, lintian should probably make what it
  is referring to more apparent, something like Debian Menu System 3.7.
 
 It does currently say menu 3.7; does that still seem unclear to you?

 To me, that suggested the menu policy. menu manual 3.7 would clarify
 that.

Ah, sorry, I understand.  That seems unobjectionable to me; I'll commit a
patch.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Lintian bugs fixed in revision r549

2006-01-22 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r549 by rra
 tag 349273 + pending
Bug#349273: lintian: allow quilt in Build-Depends
Tags were: patch
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Lintian bugs fixed in revision r552

2006-01-22 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r552 by rra
 tag 349272 + pending
Bug#349272: lintian: understand DH_COMPAT := level
Tags were: patch
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r553 - in trunk: checks debian testset testset/maintainer-scripts/debian

2006-01-22 Thread rra
Author: rra
Date: 2006-01-23 01:49:24 +0100 (Mon, 23 Jan 2006)
New Revision: 553

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
   trunk/testset/maintainer-scripts/debian/postinst
   trunk/testset/tags.maintainer-scripts
Log:
* checks/scripts:
  + [RA] Allow /tmp in variable settings.  It's likely to be a false
positive.  Reported by Frank Kuster.  (Closes: #344998)


Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2006-01-22 22:09:29 UTC (rev 552)
+++ trunk/checks/scripts2006-01-23 00:49:24 UTC (rev 553)
@@ -417,7 +417,7 @@
next if m,^\s*\#,; # skip comment lines
s/\#.*$//; # eat comments
chomp();
-   if (m,\W(/var)?/tmp\b, and not m/\bmktemp\b/ and not m/\btempfile\b/ 
and not m/\bmkdir\b/) {
+   if (m,[^\w=](/var)?/tmp\b, and not m/\bmktemp\b/ and not 
m/\btempfile\b/ and not m/\bmkdir\b/) {
tag possibly-insecure-handling-of-tmp-files-in-maintainer-script, 
$file:$.
unless $warned_tmp;
$warned_tmp = 1;

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2006-01-22 22:09:29 UTC (rev 552)
+++ trunk/debian/changelog  2006-01-23 00:49:24 UTC (rev 553)
@@ -9,8 +9,11 @@
   * checks/menu-format.desc:
 + [RA] Use menu manual rather than menu for references to more
   clearly distinguish from the Debian Menu Policy.  (Closes: #347510)
+  * checks/scripts:
++ [RA] Allow /tmp in variable settings.  It's likely to be a false
+  positive.  Reported by Frank Küster.  (Closes: #344998)
 
- -- Russ Allbery [EMAIL PROTECTED]  Sun, 22 Jan 2006 14:08:12 -0800
+ -- Russ Allbery [EMAIL PROTECTED]  Sun, 22 Jan 2006 16:27:20 -0800
 
 lintian (1.23.15) unstable; urgency=low
   

Modified: trunk/testset/maintainer-scripts/debian/postinst
===
--- trunk/testset/maintainer-scripts/debian/postinst2006-01-22 22:09:29 UTC 
(rev 552)
+++ trunk/testset/maintainer-scripts/debian/postinst2006-01-23 00:49:24 UTC 
(rev 553)
@@ -37,3 +37,16 @@
 update-rc.d foo defaults /dev/null
 update-rc.d $FOO defaults
 update-rc.d foo remove
+
+# valid
+FOO=/tmp
+FOO=/var/tmp
+: ${FOO:=/tmp}
+FOO=`mktemp /tmp/scripts.XX`
+rm $FOO
+FOO=`tempfile -n/tmp/scripts.tmp`
+mkdir /var/tmp/scripts
+# invalid
+echo foo /tmp/scripts.tmp
+rm /tmp/scripts.tmp
+rmdir /var/tmp/scripts

Modified: trunk/testset/tags.maintainer-scripts
===
--- trunk/testset/tags.maintainer-scripts   2006-01-22 22:09:29 UTC (rev 
552)
+++ trunk/testset/tags.maintainer-scripts   2006-01-23 00:49:24 UTC (rev 
553)
@@ -38,6 +38,7 @@
 W: maintainer-scripts: possible-bashism-in-maintainer-script prerm:31 'trap 
echo hi EXIT HUP 3'
 W: maintainer-scripts: possible-bashism-in-maintainer-script prerm:33 '[['
 W: maintainer-scripts: possible-bashism-in-maintainer-script prerm:34 '
kill -HUP'
+W: maintainer-scripts: 
possibly-insecure-handling-of-tmp-files-in-maintainer-script postinst:50
 W: maintainer-scripts: postinst-does-not-load-confmodule
 W: maintainer-scripts: postinst-should-not-set-usr-doc-link
 W: maintainer-scripts: postrm-does-not-purge-debconf


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]