Processed: Lintian bugs fixed in revision r775

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r775 by rra
 tag 190897 + pending
Bug#190897: [checks/cruft] outdated config.sub/config.guess should be an error, 
not warning
There were no tags set.
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r776 - in trunk: checks debian

2006-11-11 Thread rra
Author: rra
Date: 2006-11-11 09:14:41 +0100 (Sat, 11 Nov 2006)
New Revision: 776

Modified:
   trunk/checks/debdiff
   trunk/checks/debdiff.desc
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
Log:
  + [RA] Check for creation of ~ and .xxx.swp backup files in the Debian
diff, but only at the info level for now since they cause no harm.
(Closes: #332770)
* checks/files{.desc,}:
  + [RA] Check for vim .swp files in the package.
  + [RA] Split the warning for NFS temporary files into a separate tag
from the warning for editor backup files.

Modified: trunk/checks/debdiff
===
--- trunk/checks/debdiff2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/checks/debdiff2006-11-11 08:14:41 UTC (rev 776)
@@ -51,7 +51,7 @@
 tag_warn(patch-failure-file-in-diff, $file)
if ($file =~ m/\.(orig|rej)$/);
 tag_warn(editor-backup-file-in-diff, $file)
-   if ($file =~ /~$/  /\|\s+\d+\s+\++$/);
+   if ($file =~ m%((^|/)\.[^/]+\.swp|~)$%  /\|\s+\d+\s+\++$/);
 
 tag_warn(diff-contains-substvars, $file)
if ($file =~ m%^debian/substvars$%);

Modified: trunk/checks/debdiff.desc
===
--- trunk/checks/debdiff.desc   2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/checks/debdiff.desc   2006-11-11 08:14:41 UTC (rev 776)
@@ -17,11 +17,11 @@
 
 Tag: editor-backup-file-in-diff
 Type: info
-Info: The Debian diff contains a file ending in tt~/tt, which is
- normally either an Emacs backup file or a backup file created by programs
- such as ttautoheader/tt or ttdebconf-updatepo/tt.  This usually
- causes no harm, but it's messy and bloats the size of the Debian diff,
- usually to no useful purpose.
+Info: The Debian diff contains a file ending in tt~/tt or of the form
+ tt.xxx.swp/tt, which is normally either an Emacs or vim backup file
+ or a backup file created by programs such as ttautoheader/tt or
+ ttdebconf-updatepo/tt.  This usually causes no harm, but it's messy
+ and bloats the size of the Debian diff to no useful purpose.
 
 Tag: native-package-with-dash-version
 Type: warning

Modified: trunk/checks/files
===
--- trunk/checks/files  2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/checks/files  2006-11-11 08:14:41 UTC (rev 776)
@@ -512,9 +512,12 @@
 if ($perm =~ m/^-/) {
my $wanted_operm;
#  backup files and autosave files
-   if ($file =~ /~$/ or $file =~ m,\#[^/]+\#$, or $file =~ 
m,/\.nfs[^/]+$,) {
+   if ($file =~ /~$/ or $file =~ m,\#[^/]+\#$, or $file =~ 
m,/\.[^/]+\.swp$,) {
tag backup-file-in-package, $file;
}
+   if ($file =~ m,/\.nfs[^/]+$,) {
+   tag nfs-temporary-file-in-package, $file;
+   }

#  cvsignore files
if ($file =~ m/\.cvsignore$/) {

Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/checks/files.desc 2006-11-11 08:14:41 UTC (rev 776)
@@ -399,9 +399,17 @@
 
 Tag: backup-file-in-package
 Type: warning
-Info: There is a file in the package that matches the format emacs uses
- for backup and autosave files.  It may have been installed by accident.
+Info: There is a file in the package whose name matches the format emacs
+ or vim uses for backup and autosave files.  It may have been installed by
+ accident.
 
+Tag: nfs-temporary-file-in-package
+Type: warning
+Info: There is a file in the package whose name matches the format NFS
+ uses to temporarily save files that were deleted while another process
+ had them open.  It may have been included in the package by accident
+ while building the package in an NFS filesystem.
+
 Tag: package-installs-perllocal-pod
 Type: warning
 Info: This package installs a file ttperllocal.pod/tt.  Since that

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2006-11-11 07:52:53 UTC (rev 775)
+++ trunk/debian/changelog  2006-11-11 08:14:41 UTC (rev 776)
@@ -38,13 +38,18 @@
 + [RA] Close files after opening them, fixing incorrect line numbers
   when reporting problems with config scripts.
   * checks/debdiff{.desc,}:
-+ [RA] Check for creation of ~ backup files in the Debian diff, but
-  only at the info level for now since they cause no harm.
++ [RA] Check for creation of ~ and .xxx.swp backup files in the Debian
+  diff, but only at the info level for now since they cause no harm.
+  (Closes: #332770)
   * checks/fields{.desc,}:
 + [RA] Clarify in missing-build-dependency why lintian does not take
   into account transitive build dependencies.  (Closes: #393975)
 + [RA] Avoid Perl warning when diagnosing a Python-Version of the form
   all, = 

Processed: Lintian bugs fixed in revision r776

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r776 by rra
 tag 332770 + pending
Bug#332770: Should check for editor's cruft
There were no tags set.
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r777 - in trunk: checks debian testset testset/binary/debian

2006-11-11 Thread rra
Author: rra
Date: 2006-11-11 10:06:05 +0100 (Sat, 11 Nov 2006)
New Revision: 777

Modified:
   trunk/checks/menu-format
   trunk/checks/menu-format.desc
   trunk/debian/changelog
   trunk/testset/binary/debian/menu
   trunk/testset/tags.binary
Log:
* checks/menu-format{.desc,}:
  + [RA] Support the sux, gksu, and kdesu wrappers in menu commands as
well as su-to-root.  (Closes: #360227)

Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2006-11-11 08:14:41 UTC (rev 776)
+++ trunk/checks/menu-format2006-11-11 09:06:05 UTC (rev 777)
@@ -1,4 +1,4 @@
-# menu format -- lintian check script
+# menu format -- lintian check script -*- perl -*-
 
 # Copyright (C) 1998 by Joey Hess
 #
@@ -94,6 +94,9 @@
XShells
   );
 
+# Path in which to search for binaries referenced in menu entries.
+my @path = qw(/usr/local/bin/ /usr/bin/ /bin/ /usr/X11R6/bin/ /usr/games/);
+
 my %known_tags_hash;
 my %needs_tag_vals_hash;
 my %root_sections_hash;
@@ -316,8 +319,8 @@
 
 # Sanitize the section tag
 my $section = $vals{'section'};
-   $section =~ tr:/:/:s;   # eliminate duplicate slashes.
-   $section =~ s:/$::; # remove trailing slash.
+$section =~ tr:/:/:s;  # eliminate duplicate slashes.
+$section =~ s:/$::;# remove trailing slash.

 # Read the file index:
 my %file_index;
@@ -327,48 +330,47 @@
 }
 close FILE_INDEX;
 
-   my @com=split(' ',$vals{'command'});
-   if ($com[0] eq /usr/sbin/su-to-root) {
-   tag su-to-root-with-usr-sbin, $fullname:$linecount;
-   } elsif ($com[0] =~ m,(/usr/bin/)?su-to-root,o) {
-   shift @com;
-   
-my $cmd;
-while (@com) {
-if ($com[0]) {
-if ($com[0] eq '-p') {
-shift @com;
-shift @com;
-} elsif ($com[0] eq '-X') {
-shift @com;
-} elsif ($com[0] eq '-c') {
-$cmd = $com[1];
-shift @com;
-shift @com;
-} else {
-shift @com;
-}
-} else {
-shift @com;
-}
-}
-
-unless ($cmd) {
-   tag su-to-root-without--c, $fullname:$linecount;
-   } else {   
-   tag menu-command-not-in-package, $fullname:$linecount $cmd
-   if (!($file_index{.$cmd} 
-   || grep {$file_index{..$_.$cmd}} qw(/usr/local/bin/ 
/usr/bin/ /bin/ /usr/X11R6/bin/ /usr/games/)) # Check for binary in PATH
-($tested_packages  2)
-($section !~ m:^WindowManagers/Modules:));
+# Handle su wrappers.  The option parsing here is ugly and dead-simple,
+# but it's hopefully good enough for what will show up in menu files.
+# su-to-root and sux require -c options, kdesu optionally allows one, and
+# gksu has the command at the end of its arguments.
+my @com = split(' ',$vals{'command'});
+my $cmd;
+if ($com[0] eq /usr/sbin/su-to-root) {
+   tag su-to-root-with-usr-sbin, $fullname:$linecount;
+} elsif ($com[0] =~ m,^(?:/usr/bin/)?(su-to-root|gksu|kdesu|sux)$,) {
+   my $wrapper = $1;
+   shift @com;
+   while (@com) {
+   unless ($com[0]) {
+   shift @com;
+   next;
}
-   } else {
-   tag menu-command-not-in-package, $fullname:$linecount $com[0]
-   if ($com[0]  ! ($file_index{.$com[0]}
-   || grep {$file_index{..$_.$com[0]}} qw(/usr/local/bin/ 
/usr/bin/ /bin/ /usr/X11R6/bin/ /usr/games/)) # Check for binary in PATH
-($tested_packages  2)
-($section !~ m:^WindowManagers/Modules:));
+   if ($com[0] eq '-c') {
+   $cmd = $com[1];
+   last;
+   } elsif ($com[0] =~ /^-[Dfmupi]|^--(user|description|message)/) {
+   shift @com;
+   shift @com;
+   } elsif ($com[0] =~ /^-/) {
+   shift @com;
+   } else {
+   last;
+   }
}
+   if (!$cmd  $wrapper =~ /^(gk|kde)su$/) {
+   $cmd = $com[0];
+   } elsif (!$cmd) {
+   tag su-wrapper-without--c, $fullname:$linecount $wrapper;
+   }
+} else {
+   $cmd = $com[0];
+}
+tag menu-command-not-in-package, $fullname:$linecount $cmd
+   if ($cmd
+!($file_index{.$cmd} || grep {$file_index{..$_.$cmd}} @path)
+($tested_packages  2)
+($section !~ m:^WindowManagers/Modules:));
 
 if (exists($vals{'icon'})) {
VerifyIcon($menufile, $fullname, $linecount, $vals{'icon'}, 32);

Modified: trunk/checks/menu-format.desc

Processed: severity of 120323 is wishlist

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 # Automatically generated email from bts, devscripts version 2.9.22
 severity 120323 wishlist
Bug#120323: [external] Cannot detect manual pages provided by dependencies
Severity set to `wishlist' from `minor'


End of message, stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#359059: [frontend] load custom checks from ~/.lintian/checks?

2006-11-11 Thread Russ Allbery
tags 359059 = wontfix
thanks

As previously discussed on the mailing list, this isn't a feature we
currently want to support in lintian.  One of the goals of lintian is to
produce consistent output regardless of how it's run.  We'd rather that
people donate their own checks, and for special circumstances, one can
always make a copy of the root directory, modify it however, and then
point lintian at it.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Lintian bugs fixed in revision r777

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r777 by rra
 tag 360227 + pending
Bug#360227: lintian: check for gksu in menu-command-not-in-package
There were no tags set.
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: tagging 367466

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 # Automatically generated email from bts, devscripts version 2.9.22
 # not ready for application until false positives are dealt with
 tags 367466 - patch
Bug#367466: lintian: enhancement, check for missing menu files
Tags were: patch
Tags removed: patch


End of message, stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Re: Bug#359059: [frontend] load custom checks from ~/.lintian/checks?

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 tags 359059 = wontfix
Bug#359059: [frontend] load custom checks from ~/.lintian/checks?
Tags were: patch
Tags set to: wontfix

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: tagging 172078

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 # Automatically generated email from bts, devscripts version 2.9.22
 # not actually a path, just an idea
 tags 172078 - patch
Bug#172078: [new check] check for PIC code in .a libraries
Tags were: patch
Tags removed: patch


End of message, stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: severity of 368792 is wishlist

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 # Automatically generated email from bts, devscripts version 2.9.22
 severity 368792 wishlist
Bug#368792: [scripts] limit script-not-executable to /usr/bin
Severity set to `wishlist' from `normal'


End of message, stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r778 - in trunk: checks debian testset

2006-11-11 Thread rra
Author: rra
Date: 2006-11-11 10:32:24 +0100 (Sat, 11 Nov 2006)
New Revision: 778

Modified:
   trunk/checks/control-file
   trunk/checks/control-file.desc
   trunk/debian/changelog
   trunk/testset/tags.empty
   trunk/testset/tags.non-us
Log:
  + [RA] Add info-level check for Section in the source section of the
control file.  (Closes: #322244)

Modified: trunk/checks/control-file
===
--- trunk/checks/control-file   2006-11-11 09:06:05 UTC (rev 777)
+++ trunk/checks/control-file   2006-11-11 09:32:24 UTC (rev 778)
@@ -78,6 +78,8 @@
} else {
$category = '';
}
+} else {
+   tag no-section-field-for-source, ;
 }
 for my $binary_control (@binary_controls) {
next unless $binary_control-{'section'};

Modified: trunk/checks/control-file.desc
===
--- trunk/checks/control-file.desc  2006-11-11 09:06:05 UTC (rev 777)
+++ trunk/checks/control-file.desc  2006-11-11 09:32:24 UTC (rev 778)
@@ -40,6 +40,18 @@
  file should be available in the source package under multiple names, make
  ttdebian/control/tt the real file and the other names symlinks to it.
 
+Tag: no-section-field-for-source
+Type: info
+Ref: policy 5.2
+Info: The package does not have a Section: field in the source package
+ section of its control file.
+ .
+ The Section field is optional for a source package and ignored by the
+ Debian archive software, but it's recommended by Policy and not including
+ it may cause problems if the package is ever handled by
+ archive-processing software that doesn't support pools (private archives,
+ for instance).
+
 Tag: section-category-mismatch
 Type: error
 Info: The ttdebian/control/tt file places the indicated binary package

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2006-11-11 09:06:05 UTC (rev 777)
+++ trunk/debian/changelog  2006-11-11 09:32:24 UTC (rev 778)
@@ -16,6 +16,8 @@
   different archive category from the source package or the other
   binary packages.  Idea from Yann Dirson.  (Closes: #394720)
 + [RA] Close opened files.
++ [RA] Add info-level check for Section in the source section of the
+  control file.  (Closes: #322244)
   * checks/cruft{.desc,}:
 + [RA] Tighten the timestamp check on config.{sub,guess} to look for
   files dated 2004 or newer, since that's when x86_64 was added.
@@ -74,7 +76,7 @@
   various subdirectories of its standard search path based on hardware
   capabilities.  Reported by Aurelien Jarno.  (Closes: #396278)
 
- -- Russ Allbery [EMAIL PROTECTED]  Sat, 11 Nov 2006 01:06:00 -0800
+ -- Russ Allbery [EMAIL PROTECTED]  Sat, 11 Nov 2006 01:32:20 -0800
 
 lintian (1.23.25) unstable; urgency=low
 

Modified: trunk/testset/tags.empty
===
--- trunk/testset/tags.empty2006-11-11 09:06:05 UTC (rev 777)
+++ trunk/testset/tags.empty2006-11-11 09:32:24 UTC (rev 778)
@@ -5,6 +5,7 @@
 E: empty: no-copyright-file
 E: empty: package-has-no-description
 E: empty_1_i386.changes: no-description-in-changes-file
+I: empty source: no-section-field-for-source
 I: empty: no-md5sums-control-file
 W: empty source: changelog-should-mention-nmu
 W: empty source: maintainer-not-full-name empty

Modified: trunk/testset/tags.non-us
===
--- trunk/testset/tags.non-us   2006-11-11 09:06:05 UTC (rev 777)
+++ trunk/testset/tags.non-us   2006-11-11 09:32:24 UTC (rev 778)
@@ -6,6 +6,7 @@
 E: patented-app: no-copyright-file
 I: broken-crypto: no-md5sums-control-file
 I: crypto-app: no-md5sums-control-file
+I: non-us source: no-section-field-for-source
 I: nonfree-crypto-app: no-md5sums-control-file
 I: patented-app: no-md5sums-control-file
 I: patented-app: non-us-spelling


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Lintian bugs fixed in revision r778

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r778 by rra
 tag 322244 + pending
Bug#322244: [checks/fields] should warn about missing source section?
Tags were: moreinfo
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#200423: marked as done (should not warn about outdated autotools helper files if pkg uses cdbs)

2006-11-11 Thread Debian Bug Tracking System
Your message dated Sat, 11 Nov 2006 01:37:40 -0800
with message-id [EMAIL PROTECTED]
and subject line Bug#200423: lintian: CDBS interaction - outdated autotools-dev 
files
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

---BeginMessage---
Package: lintian
Version: 1.22.8.1
Severity: normal

Hi Joy,

The outdated-autotools-helper-file config.{guess,sub} warning is
invalid for packages built using CDBS as it will update those files
during the build when autotools.mk is invoked. To avoid bloating the
diff, CDBS will restore the original  outdated files before generating
the diff.

Yours sincerely,
Andrew Netsnipe Lau

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux snoopy 2.4.22-pre1 #1 Wed Jul 2 01:18:15 EST 2003 i686
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8

Versions of packages lintian depends on:
ii  binutils 2.14.90.0.4-0.1 The GNU assembler, linker and bina
ii  diffstat 1.33-1  produces graph of changes introduc
ii  file 4.02-4  Determines file type using magic
ii  man-db   2.4.1-10The on-line manual pager
ii  perl 5.8.0-18Larry Wall's Practical Extraction 

-- no debconf information


-- 
---
* Andrew Netsnipe Lau  Computer Science  Student Rep, UNSW *
*   # apt-get into it Debian GNU/Linux Package Maintainer *
* netsnipe(+)debianplanet.org\0  alau(+)cse.unsw.edu.au\0 *
* GnuPG 1024D/2E8B68BD 0B77 73D0 4F3B F286 63F1  9F4A 9B24 C07D 2E8B 68BD *
---


pgpLe4WbBStYH.pgp
Description: PGP signature
---End Message---
---BeginMessage---
The original bug requested that lintian not complain about outdated
config.{sub,guess} if the package uses cdbs since cdbs updates them at
build time.

cdbs doesn't depend on autotools-dev, only recommends it, so in order to
be assured of being able to update these files at build-time, the
maintainer would have to add a build-dependency on autotools-dev.  lintian
already suppresses this tag if such a build-dependency is present.  So
this bug has already been fixed.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/
---End Message---


lintian: r779 - in trunk: checks debian

2006-11-11 Thread rra
Author: rra
Date: 2006-11-11 11:03:59 +0100 (Sat, 11 Nov 2006)
New Revision: 779

Modified:
   trunk/checks/fields
   trunk/debian/changelog
Log:
  + [RA] Teach the debian/rules parsing about make conditionals and
don't require build dependencies for lines encountered inside a
conditional (in other words, assume people using conditionals know
what they're doing).  Fixes a false positive due to the unusual
arch-specific build dependencies for openoffice.org, reported by
Rene Engelhard.  (Closes: #380286)

Modified: trunk/checks/fields
===
--- trunk/checks/fields 2006-11-11 09:32:24 UTC (rev 778)
+++ trunk/checks/fields 2006-11-11 10:03:59 UTC (rev 779)
@@ -531,10 +531,20 @@
my $target = none;
local $/ = \n;# Read this linewise
my @rules = qw(clean binary-arch build-arch);
+my $maybe_skipping;
while (RULES) {
+   if (/^ifn?(eq|def)\s/) {
+   $maybe_skipping++;
+   } elsif (/^endif\s/) {
+   $maybe_skipping--;
+   }
for my $rule (@global_clean_depends) {
if ($_ =~ /$rule-[1]/) {
-   $needed_clean{$rule-[0]} = $rule-[2] || 
$needed_clean{$rule-[0]} || '';
+   if ($maybe_skipping) {
+   $allowed_clean{$rule-[0]} = 1;
+   } else {
+   $needed_clean{$rule-[0]} = $rule-[2] 
|| $needed_clean{$rule-[0]} || '';
+   }
}
}
for my $rule (@global_clean_allowed) {
@@ -548,7 +558,7 @@
}
}
for my $rule (@global_depends) {
-   if ($_ =~ /$rule-[1]/) {
+   if ($_ =~ /$rule-[1]/  !$maybe_skipping) {
$needed{$rule-[0]} = $rule-[2] || 
$needed{$rule-[0]} || '';
}
}
@@ -561,7 +571,11 @@
if (grep ($_ eq $target, @rules)) {
for my $rule (@rule_clean_depends) {
if ($_ =~ /$rule-[1]/) {
-   $needed_clean{$rule-[0]} = $rule-[2] 
|| $needed_clean{$rule-[0]} || '';
+   if ($maybe_skipping) {
+   $allowed_clean{$rule-[0]} = 1;
+   } else {
+   $needed_clean{$rule-[0]} = 
$rule-[2] || $needed_clean{$rule-[0]} || '';
+   }
}
}
for my $rule (@rule_clean_allowed) {

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2006-11-11 09:32:24 UTC (rev 778)
+++ trunk/debian/changelog  2006-11-11 10:03:59 UTC (rev 779)
@@ -48,6 +48,12 @@
   into account transitive build dependencies.  (Closes: #393975)
 + [RA] Avoid Perl warning when diagnosing a Python-Version of the form
   all, = 2.4.  Thanks, Thijs Kinkhorst.  (Closes: #394104)
++ [RA] Teach the debian/rules parsing about make conditionals and
+  don't require build dependencies for lines encountered inside a
+  conditional (in other words, assume people using conditionals know
+  what they're doing).  Fixes a false positive due to the unusual
+  arch-specific build dependencies for openoffice.org, reported by
+  Rene Engelhard.  (Closes: #380286)
   * checks/files{.desc,}:
 + [RA] Check for vim .swp files in the package.
 + [RA] Split the warning for NFS temporary files into a separate tag
@@ -76,7 +82,7 @@
   various subdirectories of its standard search path based on hardware
   capabilities.  Reported by Aurelien Jarno.  (Closes: #396278)
 
- -- Russ Allbery [EMAIL PROTECTED]  Sat, 11 Nov 2006 01:32:20 -0800
+ --
 
 lintian (1.23.25) unstable; urgency=low
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r780 - in trunk: debian frontend man

2006-11-11 Thread rra
Author: rra
Date: 2006-11-11 11:18:35 +0100 (Sat, 11 Nov 2006)
New Revision: 780

Modified:
   trunk/debian/changelog
   trunk/frontend/lintian
   trunk/man/lintian.1
Log:
* frontend/lintian:
  + [RA] Add --fail-on-warning option to exit with non-zero status if
any warnings were found.  Thanks, Daniel Bonniot.  (Closes: #189656)
* man/lintian.1:
  + [RA] Document --fail-on-warning.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2006-11-11 10:03:59 UTC (rev 779)
+++ trunk/debian/changelog  2006-11-11 10:18:35 UTC (rev 780)
@@ -82,8 +82,15 @@
   various subdirectories of its standard search path based on hardware
   capabilities.  Reported by Aurelien Jarno.  (Closes: #396278)
 
- --
+  * frontend/lintian:
++ [RA] Add --fail-on-warning option to exit with non-zero status if
+  any warnings were found.  Thanks, Daniel Bonniot.  (Closes: #189656)
 
+  * man/lintian.1:
++ [RA] Document --fail-on-warning.
+
+ -- Russ Allbery [EMAIL PROTECTED]  Sat, 11 Nov 2006 02:11:18 -0800
+
 lintian (1.23.25) unstable; urgency=low
 
   The dependency and debconf release

Modified: trunk/frontend/lintian
===
--- trunk/frontend/lintian  2006-11-11 10:03:59 UTC (rev 779)
+++ trunk/frontend/lintian  2006-11-11 10:18:35 UTC (rev 780)
@@ -51,9 +51,10 @@
 our $display_infotags = 0; #flag for -I|--display-info switch
 my $unpack_level = undef;  #flag for -l|--unpack-level switch
 our $no_override = 0;  #flag for -o|--no-override switch
-our $show_overrides = 0;   #flag for --show-overrides switch
+our $show_overrides = 0;   #flag for --show-overrides switch
 my $check_md5sums = 0; #flag for -m|--md5sums switch
 my $allow_root = 0;#flag for --allow-root swtich
+my $fail_on_warnings = 0;   #flag for --fail-on-warnings switch
 my $packages_file = 0; #string for the -p option
 my $OPT_LINTIAN_LAB = ;  #string for the --lab option
 my $OPT_LINTIAN_ARCHIVEDIR = ;#string for the --archivedir option
@@ -145,6 +146,7 @@
 -U X, --unpack-info X specify which info should be collected
 -m, --md5sums check md5sums when processing a .changes file
 --allow-root  suppress lintian\'s warning when run as root
+--fail-on-warningsreturn a non-zero exit status if warnings found
 Configuration options:
 --cfg CONFIGFILE  read CONFIGFILE for configuration
 --lab LABDIR  use LABDIR as permanent laboratory
@@ -260,6 +262,7 @@
   unpack-info|U=s = \record_unpack_info,
   md5sums|m = \$check_md5sums,
   allow-root = \$allow_root,
+   fail-on-warnings = \$fail_on_warnings,
   # Note: Ubuntu has (and other derivatives might gain) a
   # -D/--debian option to make lintian behave like in Debian, that
   # is, to revert distribution-specific changes
@@ -707,6 +710,8 @@
my $stats = Tags::get_stats( $arg );
if ($stats-{severity}{4}) {
$exit_code = 1;
+   } elsif ($fail_on_warnings  $stats-{severity}{2}) {
+   $exit_code = 1;
}
}
 
@@ -1317,6 +1322,8 @@
my $stats = Tags::get_stats( $file );
if ($stats-{severity}{4}) {
$exit_code = 1;
+   } elsif ($fail_on_warnings  $stats-{severity}{2}) {
+   $exit_code = 1;
}
}
 

Modified: trunk/man/lintian.1
===
--- trunk/man/lintian.1 2006-11-11 10:03:59 UTC (rev 779)
+++ trunk/man/lintian.1 2006-11-11 10:18:35 UTC (rev 780)
@@ -172,6 +172,13 @@
 .BR lintian 's
 warning when it is run with superuser privileges.
 
+.TP
+.BR \-\-fail\-on\-warnings
+By default,
+.B lintian
+exits with 0 status if only warnings were found.  If this flag is given,
+exit with a status of 1 if either warnings or errors are found.
+
 .PP
 
 Configuration options:


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Lintian bugs fixed in revision r779

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r779 by rra
 tag 380286 + pending
Bug#380286: bogus missing-dh_python-build-dependency error with arch-specific 
build-deps
There were no tags set.
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Lintian bugs fixed in revision r780

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r780 by rra
 tag 189656 + pending
Bug#189656: [frontend] option to return non-zero on warnings
There were no tags set.
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#384424: closed by Russ Allbery [EMAIL PROTECTED] (Re: Re: Bug#384424: lintian: possible mishandling of similarily-named shlibs with dashes)

2006-11-11 Thread Martin-Éric Racine
reopen 384424
reassign 384424 debhelper
thanks

pe, 2006-11-10 kello 21:18 -0800, Debian Bug Tracking System kirjoitti:

  --- Välitetty viesti -
  Lähettäjä: Russ Allbery [EMAIL PROTECTED]
  Vastaanottaja: [EMAIL PROTECTED]
  Aihe: Re: Re: Bug#384424: lintian: possible mishandling of
  similarily-named shlibs with dashes
  Päiväys: Fri, 10 Nov 2006 21:07:38 -0800
  Postittaja: Gnus/5.110006 (No Gnus v0.6) XEmacs/21.4.19 (linux)
  
  As discussed in the bug log, the shlibs file really is invalid, so
  lintian's behavior here is correct.  I'm not sure if dh_makeshlibs is
  doing the right thing or not in this case; it is intentionally parsing
  SONAMEs in that way, and there's a comment in the source that seems to
  indicate this is done because of an annoying SONAME syntax used in some
  packages.
  
  I'll leave it to you whether you want to just exclude these files from
  dh_makeshlibs or open another bug against debhelper to see if its matching
  logic can be improved.

Since the issue itself is not resolved, reassigning this bug to
debhelper makes more sense than closing it.  Doing this now.

-- 
Martin-Éric Racine
http://q-funk.iki.fi




Processed: Re: Bug#384424 closed by Russ Allbery [EMAIL PROTECTED] (Re: Re: Bug#384424: lintian: possible mishandling of similarily-named shlibs with dashes)

2006-11-11 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 reopen 384424
Bug#384424: lintian: possible mishandling of similarily-named shlibs with dashes
Bug reopened, originator not changed.

 reassign 384424 debhelper
Bug#384424: lintian: possible mishandling of similarily-named shlibs with dashes
Bug reassigned from package `lintian' to `debhelper'.

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]