Bug#421549: build-depends-without-arch-dep: support libmodule-build-perl use in clean target

2007-04-29 Thread Ian Beckwith
Package: lintian
Version: 1.23.30
Severity: wishlist
Tags: patch

When testing a perl package built using Module::Build, lintian says:

I: liburi-template-perl source: build-depends-without-arch-dep 
libmodule-build-perl

because it doesn't know libmodule-build-perl is needed in the clean target.

The attached patch adds a regexp to @global_clean_depends to support this.
I just hope no other build system uses Build.PL anywhere.

For a package using Module::Build, see

http://nessie.mcc.ac.uk/~ianb/debian/liburi-template-perl_0.06-1.dsc

which was generated with dh-make-perl.

Ian.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.18-4-686 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages lintian depends on:
ii  binutils   2.17cvs20070426-2 The GNU assembler, linker and bina
ii  diffstat   1.43-2produces graph of changes introduc
ii  dpkg-dev   1.13.25   package building tools for Debian
ii  file   4.20-5Determines file type using magic
ii  gettext0.16.1-1  GNU Internationalization utilities
ii  intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libparse-debianchangel 1.0-1 parse Debian changelogs and output
ii  man-db 2.4.4-2   The on-line manual pager
ii  perl [libdigest-md5-pe 5.8.8-7   Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information
diff -Naur orig/lintian-1.23.30/checks/fields lintian-1.23.30/checks/fields
--- orig/lintian-1.23.30/checks/fields  2007-04-28 05:57:16.0 +0100
+++ lintian-1.23.30/checks/fields   2007-04-29 22:34:12.0 +0100
@@ -52,6 +52,7 @@
[ dpatch = '^include\s+/usr/share/dpatch/' ],
[ quilt = '^include\s+/usr/share/quilt/' ],
[ $python_depend = '/usr/share/cdbs/1/class/python-distutils.mk' ],
+   [ 'libmodule-build-perl' = 'Build.PL' ],
 );
 
 # These are similar, but the resulting dependency is only allowed, not


lintian: r879 - trunk/checks

2007-04-29 Thread rra
Author: rra
Date: 2007-04-30 05:03:47 +0200 (Mon, 30 Apr 2007)
New Revision: 879

Modified:
   trunk/checks/fields
Log:
Whoops, fix tabs.


Modified: trunk/checks/fields
===
--- trunk/checks/fields 2007-04-30 02:59:05 UTC (rev 878)
+++ trunk/checks/fields 2007-04-30 03:03:47 UTC (rev 879)
@@ -85,7 +85,7 @@
 my @rule_clean_depends = (
[ debhelper = '^\t\s*dh_.+' ],
[ dpatch = '^\t\s*dpatch\s' ],
-[ 'libmodule-build-perl' = '(^\t|\|\|)\s*(perl|\$\(PERL\))\s+Build\b' 
],
+   [ 'libmodule-build-perl' = '(^\t|\|\|)\s*(perl|\$\(PERL\))\s+Build\b' 
],
[ po-debconf = '^\t\s*debconf-updatepo\s' ],
[ $python_depend = '^\t\s*python\s' ],
[ quilt = '^\t\s*(\S+=\S+\s+)*quilt\s' ],


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#421549: build-depends-without-arch-dep: support libmodule-build-perl use in clean target

2007-04-29 Thread Russ Allbery
Ian Beckwith [EMAIL PROTECTED] writes:

 Package: lintian
 Version: 1.23.30
 Severity: wishlist
 Tags: patch

 When testing a perl package built using Module::Build, lintian says:

 I: liburi-template-perl source: build-depends-without-arch-dep 
 libmodule-build-perl

 because it doesn't know libmodule-build-perl is needed in the clean target.

 The attached patch adds a regexp to @global_clean_depends to support
 this.  I just hope no other build system uses Build.PL anywhere.

 For a package using Module::Build, see

 http://nessie.mcc.ac.uk/~ianb/debian/liburi-template-perl_0.06-1.dsc

 which was generated with dh-make-perl.

I added this to @rule_clean_depends instead of @global_clean_depends since
the requirement really does depend on someone running perl Build in the
clean rule.  I hope this isn't too aggressive; I may have to move it to
@rule_clean_allowed instead.  As-is, it will require libmodule-build-perl
in Build-Depends and error if it's not there, which *seems* right, but
we'll see.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Lintian bugs fixed in revision r878

2007-04-29 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r878 by rra
 tag 421549 + pending
Bug#421549: build-depends-without-arch-dep: support libmodule-build-perl use in 
clean target
Tags were: patch
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]