lintian: r956 - in trunk: checks debian testset testset/filenames/debian
Author: rra
Date: 2007-10-15 02:52:01 +0200 (Mon, 15 Oct 2007)
New Revision: 956
Modified:
trunk/checks/files
trunk/checks/files.desc
trunk/debian/changelog
trunk/testset/filenames/debian/rules
trunk/testset/tags.filenames
Log:
* checks/files{.desc,}:
+ [RA] Warn about Thumbs.db files, which are usually useless Windows
thumbnail databases. Thanks, Paul Wise. (Closes: #438202)
Modified: trunk/checks/files
===
--- trunk/checks/files 2007-10-15 00:34:32 UTC (rev 955)
+++ trunk/checks/files 2007-10-15 00:52:01 UTC (rev 956)
@@ -179,12 +179,12 @@
if ($owner ne 'root/root') {
tag bad-owner-for-doc-file, $file $owner != root/root;
}
-
+
# file directly in /usr/share/doc ?
if ($perm =~ m/^-/ and $file =~ m,^usr/share/doc/[^/]+$,) {
tag file-directly-in-usr-share-doc, $file;
}
-
+
# executable in /usr/share/doc ?
if ($perm =~ m/^-.*[xs]/ and $file !~
m,^usr/share/doc/([^/]+/)?examples/,) {
if ($script{$file}) {
@@ -193,7 +193,7 @@
tag executable-in-usr-share-doc, $file, (sprintf
%04o, $operm);
}
}
-
+
# zero byte file in /usr/share/doc/
if ($size == 0 and $perm =~ m,^-,) {
# exception: __init__.py files are empty tagging files (see
@@ -217,7 +217,7 @@
} elsif ($file =~ m,^usr/share/lintian/overrides/$tmp/.*,) {
tag override-file-in-wrong-location, $file;
}
-
+
# contains an INSTALL file?
if ($file =~ m,^usr/share/doc/$tmp/INSTALL(?:\..+)*$,) {
tag package-contains-upstream-install-documentation,
$file;
@@ -372,7 +372,7 @@
elsif ($file =~ m,/usr/share/(?:gnome/apps|applink)/[^/]+\.desktop$,) {
tag desktop-file-in-wrong-dir, $file;
}
-
+
}
# /var subdirs
elsif ($type ne 'udeb' and $file =~ m,^var/[^/]+/$,) { # FSSTND dirs
@@ -551,6 +551,11 @@
tag script-with-language-extension, $file;
}
+ # Windows thumbnail databases
+ if ($file =~ m,/Thumbs\.db(\.gz)?$,) {
+ tag windows-thumbnail-database-in-package, $file;
+ }
+
# general: setuid/setgid files!
if ($perm =~ m/s/) {
my ($setuid, $setgid) = (,);
Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2007-10-15 00:34:32 UTC (rev 955)
+++ trunk/checks/files.desc 2007-10-15 00:52:01 UTC (rev 956)
@@ -410,6 +410,12 @@
had them open. It may have been included in the package by accident
while building the package in an NFS filesystem.
+Tag: windows-thumbnail-database-in-package
+Type: warning
+Info: There is a file in the package named ttThumbs.db/tt or
+ ttThumbs.db.gz/tt, which is normally a Windows image thumbnail
+ database. Such databases are generally useless in Debian packages.
+
Tag: package-installs-perllocal-pod
Type: warning
Info: This package installs a file ttperllocal.pod/tt. Since that
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 00:34:32 UTC (rev 955)
+++ trunk/debian/changelog 2007-10-15 00:52:01 UTC (rev 956)
@@ -12,6 +12,9 @@
* checks/description{.desc,}:
+ [RA] Warn (at info level for now) about Homepage pseudo-fields in
the extended description. (Closes: #444336)
+ * checks/files{.desc,}:
++ [RA] Warn about Thumbs.db files, which are usually useless Windows
+ thumbnail databases. Thanks, Paul Wise. (Closes: #438202)
* checks/nmu.desc:
+ [RA] Remove obsolete note about binary NMUs. Patch from Thijs
Kinkhorst. (Closes: #437925)
@@ -19,7 +22,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 17:34:23 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 17:47:43 -0700
lintian (1.23.34) unstable; urgency=low
Modified: trunk/testset/filenames/debian/rules
===
--- trunk/testset/filenames/debian/rules2007-10-15 00:34:32 UTC (rev
955)
+++ trunk/testset/filenames/debian/rules2007-10-15 00:52:01 UTC (rev
956)
@@ -80,6 +80,8 @@
echo foo debian/tmp/usr/share/doc/filenames/bokm\\�l
echo foo debian/tmp/usr/share/doc/filenames/bokm�l
+ echo foo debian/tmp/usr/share/doc/filenames/Thumbs.db
+
touch debian/tmp/usr/share/doc/filenames/news.debian
gzip
lintian: r978 - releases
Author: rra Date: 2007-10-15 07:42:10 +0200 (Mon, 15 Oct 2007) New Revision: 978 Added: releases/1.23.35/ Log: Tag 1.23.35 release. Copied: releases/1.23.35 (from rev 977, trunk) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r977 - trunk/debian
Author: rra
Date: 2007-10-15 07:30:07 +0200 (Mon, 15 Oct 2007)
New Revision: 977
Modified:
trunk/debian/changelog
Log:
Finalize changes for 1.23.35.
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 05:29:45 UTC (rev 976)
+++ trunk/debian/changelog 2007-10-15 05:30:07 UTC (rev 977)
@@ -1,5 +1,7 @@
-lintian (1.23.35) UNRELEASED; urgency=low
+lintian (1.23.35) unstable; urgency=low
+ The frantic bug catchup release.
+
* checks/changelog-file{.desc,}:
+ [RA] Add some basic checks for NEWS.Debian files: naming,
compression, encoding, a syntax check with Parse::DebianChangelog,
@@ -86,7 +88,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 22:18:41 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 22:29:51 -0700
lintian (1.23.34) unstable; urgency=low
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r976 - in trunk: checks testset
Author: rra
Date: 2007-10-15 07:29:45 +0200 (Mon, 15 Oct 2007)
New Revision: 976
Modified:
trunk/checks/menu-format
trunk/testset/tags.binary
Log:
Clean up some mess I left in my last commit.
Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-15 05:18:47 UTC (rev 975)
+++ trunk/checks/menu-format2007-10-15 05:29:45 UTC (rev 976)
@@ -362,7 +362,7 @@
);
# Path in which to search for binaries referenced in menu entries.
-my @path = qw(/usr/local/bin/ /usr/bin/ /bin/ /usr/X11R6/bin/ /usr/games/);
+my @path = qw(usr/local/bin/ usr/bin/ bin/ usr/X11R6/bin/ usr/games/);
my %known_tags_hash = map { $_ = 1 } @known_tags;
my %needs_tag_vals_hash = map { $_ = 1 } @needs_tag_vals;
@@ -790,7 +790,7 @@
#
# TODO: Should check quoting and the check special field
# codes in Exec for desktop files.
-if ($file =~ ,usr/share/applications/[^/]+$, and $vals{'Exec'} =~ /\S/) {
+if ($file =~ m,usr/share/applications/[^/]+$, and $vals{'Exec'} =~ /\S/) {
my ($okay, $command) = VerifyCmd ($file, undef, $vals{'Exec'});
tag desktop-command-not-in-package, $file $command
unless $okay or $command eq 'kcmshell';
@@ -867,7 +867,7 @@
} else {
$cmd = $com[0];
}
-my $okay = $cmd ($file_index{.$cmd} || grep { $file_index{'.' . $_ .
$cmd} } @path);
+my $okay = $cmd ($file_index{.$cmd} || grep { $file_index{$_ . $cmd}
} @path);
return ($okay, $cmd);
}
Modified: trunk/testset/tags.binary
===
--- trunk/testset/tags.binary 2007-10-15 05:18:47 UTC (rev 975)
+++ trunk/testset/tags.binary 2007-10-15 05:29:45 UTC (rev 976)
@@ -3,7 +3,7 @@
E: binary: debian-changelog-file-missing-or-wrong-name
E: binary: debian-news-file-uses-obsolete-national-encoding at line 3
E: binary: depends-on-x-metapackage depends: xorg
-E: binary: desktop-entry-missing-required-key
./usr/share/applications/goodbye.desktop Name
+E: binary: desktop-entry-missing-required-key
usr/share/applications/goodbye.desktop Name
E: binary: doc-base-document-field-ends-in-whitespace binary:1
E: binary: doc-base-file-no-format binary:22
E: binary: doc-base-file-no-index binary:31
@@ -13,7 +13,7 @@
E: binary: doc-base-file-references-missing-file binary:27
/usr/share/doc/binary/hml/*.html
E: binary: doc-base-file-references-missing-file binary:30
/usr/share/info/binary.info.gz
E: binary: doc-base-index-references-multiple-files binary:21
-E: binary: executable-desktop-file ./usr/share/applications/goodbye.desktop
0755
+E: binary: executable-desktop-file usr/share/applications/goodbye.desktop 0755
E: binary: file-directly-in-usr-share usr/share/baz
E: binary: lengthy-symlink usr/share/doc/binary/html/ch2.html
../html/./ch1.html
E: binary: menu-item-missing-required-tag needs /usr/lib/menu/binary:6
@@ -39,8 +39,8 @@
I: binary: arch-dep-package-has-big-usr-share
I: binary: binary-has-unneeded-section ./usr/bin/hello-static .comment
I: binary: description-contains-homepage
-I: binary: desktop-entry-contains-encoding-key
./usr/share/applications/goodbye.desktop:11 Encoding
-I: binary: desktop-entry-contains-encoding-key
./usr/share/applications/hello.desktop:13 Encoding
+I: binary: desktop-entry-contains-encoding-key
usr/share/applications/goodbye.desktop:11 Encoding
+I: binary: desktop-entry-contains-encoding-key
usr/share/applications/hello.desktop:13 Encoding
I: binary: no-md5sums-control-file
W: binary source: ancient-standards-version 3.2.1 (current is 3.7.2)
W: binary source: debian-rules-uses-pwd line 9
@@ -57,12 +57,11 @@
W: binary: binary-without-manpage usr/bin/static-hello
W: binary: changelog-file-not-compressed changelog
W: binary: debian-news-entry-has-strange-distribution UNRELEASED
-W: binary: desktop-command-not-in-package
./usr/share/applications/goodbye.desktop goodbye
-W: binary: desktop-entry-contains-unknown-key
./usr/share/applications/goodbye.desktop:5 SpecialTag
-W: binary: desktop-entry-contains-unknown-key
./usr/share/applications/goodbye.desktop:7 icon
-W: binary: desktop-entry-invalid-category WeirdStuff
./usr/share/applications/goodbye.desktop
-W: binary: desktop-entry-lacks-main-category
./usr/share/applications/goodbye.desktop
-W: binary: desktop-entry-uses-reserved-category Screensaver
./usr/share/applications/goodbye.desktop
+W: binary: desktop-command-not-in-package
usr/share/applications/goodbye.desktop goodbye
+W: binary: desktop-entry-contains-unknown-key
usr/share/applications/goodbye.desktop:5 SpecialTag
+W: binary: desktop-entry-contains-unknown-key
usr/share/applications/goodbye.desktop:7 icon
+W: binary: desktop-entry-invalid-category WeirdStuff
usr/share/applications/goodbye.desktop
+W: binary: desktop-entry-uses-reserved-category Screensaver
usr/share/applications/goodbye.desktop
W: binary: doc-base-file-unknown-format binary:16 esp
lintian: r975 - in trunk: checks debian
Author: rra
Date: 2007-10-15 07:18:47 +0200 (Mon, 15 Oct 2007)
New Revision: 975
Modified:
trunk/checks/menu-format
trunk/debian/changelog
Log:
+ [RA] Ignore desktop files not for one of the known types. This
should significantly reduce the noise for KDE packages.
+ [RA] Only check whether a program referenced by Exec is in the
package if the desktop file is in /usr/share/applications. Too many
applications use Exec for desktop files elsewhere without the
standard PATH.
+ [RA] Ignore Exec fields pointing to kcmshell.
+ [RA] Ignore desktop files in /usr/share/doc or that appear to be
templates.
+ [RA] Avoid uninitialized warnings on all-whitespace commands.
Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-15 04:35:45 UTC (rev 974)
+++ trunk/checks/menu-format2007-10-15 05:18:47 UTC (rev 975)
@@ -194,6 +194,15 @@
UnmountIcon
);
+# Known types of desktop entries.
+# http://standards.freedesktop.org/desktop-entry-spec/1.0/ar01s05.html
+my %known_desktop_types = map { $_ = 1 }
+qw(
+ Application
+ Link
+ Directory
+ );
+
# Authorative source of desktop categories:
# http://standards.freedesktop.org/menu-spec/1.0/apa.html
@@ -386,6 +395,7 @@
while (IN) {
chomp;
my ($perm, $owner, $size, $date, $time, $file) = split(' ', $_, 6);
+$file =~ s,^\./,,;
$file =~ s/ link to .*//;
$file =~ s/ - .*//;
my $operm = perm2oct($perm);
@@ -395,7 +405,9 @@
if ($perm =~ m,x,o) {
tag executable-desktop-file, sprintf($file %04o,$operm);
}
-push (@desktop_files, $file);
+unless (m,template, or m,^usr/share/doc/,) {
+push (@desktop_files, $file);
+}
}
}
close IN;
@@ -762,7 +774,8 @@
}
close DESKTOP;
-# Now validate the data in the desktop file.
+# Now validate the data in the desktop file, but only if it's a known type.
+next unless ($vals{'Type'} and $known_desktop_types{$vals{'Type'}});
# Test for important keys.
for my $tag (@req_desktop_keys) {
@@ -771,12 +784,16 @@
}
}
-# TODO: Should check quoting and the check special field codes in Exec
-# for desktiop files.
-if (defined $vals{'Exec'}) {
+# Only test whether the binary is in the package if the desktop file is
+# directly under /usr/share/applications. Too many applications use
+# desktop files for other purposes with custom paths.
+#
+# TODO: Should check quoting and the check special field
+# codes in Exec for desktop files.
+if ($file =~ ,usr/share/applications/[^/]+$, and $vals{'Exec'} =~ /\S/) {
my ($okay, $command) = VerifyCmd ($file, undef, $vals{'Exec'});
tag desktop-command-not-in-package, $file $command
-unless $okay;
+unless $okay or $command eq 'kcmshell';
}
# Check the Category tag.
@@ -816,10 +833,10 @@
# allows one, and gksu has the command at the end of its arguments.
my @com = split (' ', $exec);
my $cmd;
-if ($com[0] eq /usr/sbin/su-to-root) {
+if ($com[0] and $com[0] eq /usr/sbin/su-to-root) {
tag 'su-to-root-with-usr-sbin', $location;
}
-if ($com[0] =~ m,^(?:/usr/s?bin/)?(su-to-root|gksu|kdesu|sux)$,) {
+if ($com[0] and $com[0] =~
m,^(?:/usr/s?bin/)?(su-to-root|gksu|kdesu|sux)$,) {
my $wrapper = $1;
shift @com;
while (@com) {
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 04:35:45 UTC (rev 974)
+++ trunk/debian/changelog 2007-10-15 05:18:47 UTC (rev 975)
@@ -56,6 +56,16 @@
extensions. Thanks, Josselin Mouette. (Closes: #443827)
+ [RA] Allow Actions keys. This isn't in the desktop standard but
is widely used. Thanks, Raphael Geissert. (Closes: #444651)
++ [RA] Ignore desktop files not for one of the known types. This
+ should significantly reduce the noise for KDE packages.
++ [RA] Only check whether a program referenced by Exec is in the
+ package if the desktop file is in /usr/share/applications. Too many
+ applications use Exec for desktop files elsewhere without the
+ standard PATH.
++ [RA] Ignore Exec fields pointing to kcmshell.
++ [RA] Ignore desktop files in /usr/share/doc or that appear to be
+ templates.
++ [RA] Avoid uninitialized warnings on all-whitespace commands.
* checks/menus:
+ [RA] Find the targets of hard links correctly. (Closes: #444355)
+ [RA] Use the three-argument form of open to not fail on doc-base
@@ -76,7 +86,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 21:19:01 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 22:18:41
lintian: r971 - trunk/testset
Author: rra Date: 2007-10-15 05:56:21 +0200 (Mon, 15 Oct 2007) New Revision: 971 Modified: trunk/testset/tags.cdbs-test trunk/testset/tags.debconf Log: Adjust tags for the python-all change. Modified: trunk/testset/tags.cdbs-test === --- trunk/testset/tags.cdbs-test2007-10-15 03:40:31 UTC (rev 970) +++ trunk/testset/tags.cdbs-test2007-10-15 03:56:21 UTC (rev 971) @@ -1,5 +1,5 @@ E: cdbs-test source: clean-should-be-satisfied-by-build-depends debhelper -E: cdbs-test source: missing-build-dependency python | python-dev | python-all-dev +E: cdbs-test source: missing-build-dependency python | python-dev | python-all | python-all-dev I: cdbs-test source: build-depends-without-arch-dep yada I: cdbs-test source: package-lacks-versioned-build-depends-on-debhelper 5 W: cdbs-test source: native-package-with-dash-version Modified: trunk/testset/tags.debconf === --- trunk/testset/tags.debconf 2007-10-15 03:40:31 UTC (rev 970) +++ trunk/testset/tags.debconf 2007-10-15 03:56:21 UTC (rev 971) @@ -1,5 +1,5 @@ E: debconf source: declares-possibly-conflicting-debhelper-compat-versions rules=4 compat=4 -E: debconf source: missing-dh_python-build-dependency python | python-dev | python-all-dev +E: debconf source: missing-dh_python-build-dependency python | python-dev | python-all | python-all-dev E: debconf-test: extended-description-is-empty E: debconf-test: mismatch-translated-choices debconf/testmulti-escape choices-de.utf-8 E: debconf-test: no-template-description debconf/no-description -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r969 - trunk/checks
Author: rra
Date: 2007-10-15 05:38:09 +0200 (Mon, 15 Oct 2007)
New Revision: 969
Modified:
trunk/checks/files
Log:
Diagnose any capitalization of Thumbs.db.
Modified: trunk/checks/files
===
--- trunk/checks/files 2007-10-15 03:37:26 UTC (rev 968)
+++ trunk/checks/files 2007-10-15 03:38:09 UTC (rev 969)
@@ -554,7 +554,7 @@
}
# Autogenerated databases from other OSes
- if ($file =~ m,/Thumbs\.db(\.gz)?$,) {
+ if ($file =~ m,/Thumbs\.db(\.gz)?$,i) {
tag windows-thumbnail-database-in-package, $file;
}
if ($file =~ m,/\.DS_Store$,) {
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r965 - in trunk: checks debian testset testset/binary/debian
Author: rra
Date: 2007-10-15 04:26:33 +0200 (Mon, 15 Oct 2007)
New Revision: 965
Modified:
trunk/checks/menu-format
trunk/checks/menu-format.desc
trunk/debian/changelog
trunk/testset/binary/debian/goodbye.desktop
trunk/testset/binary/debian/hello.desktop
trunk/testset/tags.binary
Log:
* checks/menu-format{.desc,}:
+ [RA] Reserved categories are okay in .desktop files if OnlyShowIn is
present, and generally deserve their own separate tag regardless.
Thanks, Michael Biebl. (Closes: #442709)
Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-15 02:11:29 UTC (rev 964)
+++ trunk/checks/menu-format2007-10-15 02:26:33 UTC (rev 965)
@@ -339,6 +339,17 @@
ConsoleOnly
);
+# This is a list of Reserved Categories for .desktop files. To use one of
+# these, the desktop entry must also have an OnlyShowIn key limiting the
+# environment to one that supports this category.
+my %reserved_categories = map { $_ = 1 }
+qw(
+ Screensaver
+ TrayIcon
+ Applet
+ Shell
+ );
+
# Path in which to search for binaries referenced in menu entries.
my @path = qw(/usr/local/bin/ /usr/bin/ /bin/ /usr/X11R6/bin/ /usr/games/);
@@ -771,7 +782,10 @@
my @cats = split (';', $vals{'Categories'});
my $saw_main;
for my $cat (@cats) {
-if (not $categories{$cat} and not $main_categories{$cat}) {
+if ($reserved_categories{$cat}) {
+tag desktop-entry-uses-reserved-category, $cat $file
+unless $vals{'OnlyShowIn'};
+} elsif (not $categories{$cat} and not $main_categories{$cat}) {
tag desktop-entry-invalid-category, $cat $file;
} elsif ($main_categories{$cat}) {
$saw_main = 1;
Modified: trunk/checks/menu-format.desc
===
--- trunk/checks/menu-format.desc 2007-10-15 02:11:29 UTC (rev 964)
+++ trunk/checks/menu-format.desc 2007-10-15 02:26:33 UTC (rev 965)
@@ -231,6 +231,15 @@
only be used on conjunction with one or more Main Categories.
Ref: http://standards.freedesktop.org/menu-spec/1.0/apa.html
+Tag: desktop-entry-uses-reserved-category
+Type: warning
+Info: This desktop entry includes a Reserved Category, one which has a
+ desktop-specific meaning that has not yet been standardized, but does not
+ include an OnlyShowIn key. Desktop entries using a Reserved Category
+ must include an OnlyShowIn key limiting the entry to those environments
+ that support the category.
+Ref: http://standards.freedesktop.org/menu-spec/1.0/apa.html
+
Tag: desktop-entry-invalid-category
Type: warning
Info: This desktop entry lists a category that is not one of the
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 02:11:29 UTC (rev 964)
+++ trunk/debian/changelog 2007-10-15 02:26:33 UTC (rev 965)
@@ -41,6 +41,10 @@
+ [RA] Emacs 22 now allows embedded images in info files, so accept
and ignore PNG files in the info directory. More image types may be
needed. Thanks, Andreas Metzler. (Closes: #438602)
+ * checks/menu-format{.desc,}:
++ [RA] Reserved categories are okay in .desktop files if OnlyShowIn is
+ present, and generally deserve their own separate tag regardless.
+ Thanks, Michael Biebl. (Closes: #442709)
* checks/nmu.desc:
+ [RA] Remove obsolete note about binary NMUs. Patch from Thijs
Kinkhorst. (Closes: #437925)
@@ -53,7 +57,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 19:11:25 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 19:24:56 -0700
lintian (1.23.34) unstable; urgency=low
Modified: trunk/testset/binary/debian/goodbye.desktop
===
--- trunk/testset/binary/debian/goodbye.desktop 2007-10-15 02:11:29 UTC (rev
964)
+++ trunk/testset/binary/debian/goodbye.desktop 2007-10-15 02:26:33 UTC (rev
965)
@@ -7,7 +7,7 @@
icon=hello
Terminal=true
Type=Application
-Categories=WeirdStuff;
+Categories=WeirdStuff;Screensaver;
Encoding=ISO-10646-1
[Other Entry]
Name=Goodbye
Modified: trunk/testset/binary/debian/hello.desktop
===
--- trunk/testset/binary/debian/hello.desktop 2007-10-15 02:11:29 UTC (rev
964)
+++ trunk/testset/binary/debian/hello.desktop 2007-10-15 02:26:33 UTC (rev
965)
@@ -9,5 +9,6 @@
Icon=hello
Terminal=true
Type=Application
-Categories=GNOME;GTK;System;Settings;
+Categories=GNOME;GTK;System;Applet;Settings;
Encoding=UTF-8
+OnlyShowIn=GNOME;
Modified: trunk/testset/tags.binary
lintian: r973 - in trunk: checks debian testset testset/binary/debian
Author: rra
Date: 2007-10-15 06:19:12 +0200 (Mon, 15 Oct 2007)
New Revision: 973
Modified:
trunk/checks/files
trunk/checks/files.desc
trunk/checks/menus
trunk/checks/menus.desc
trunk/debian/changelog
trunk/testset/binary/debian/doc-base
trunk/testset/binary/debian/rules
trunk/testset/tags.binary
trunk/testset/tags.filenames
Log:
+ [RA] Diagnose files with names ending in whitespace.
+ [RA] Use the three-argument form of open to not fail on doc-base
files ending in whitespace. Error on doc-base files with Document
fields that end in whitespace, since currently they break multiple
tools. Thanks, Ian Zimmerman. (Closes: #444889)
Modified: trunk/checks/files
===
--- trunk/checks/files 2007-10-15 03:56:32 UTC (rev 972)
+++ trunk/checks/files 2007-10-15 04:19:12 UTC (rev 973)
@@ -518,6 +518,10 @@
tag extra-license-file, $file;
}
+# weird file names
+if ($file =~ m,\s+\z,) {
+ tag file-name-ends-in-whitespace, $file;
+}
# plain files
if ($perm =~ m/^-/) {
@@ -689,7 +693,7 @@
# symbolic links
elsif ($perm =~ m/^l/) {
# link
-
+
my $mylink = $link;
if ($mylink =~ s,//+,/,g) {
tag symlink-has-double-slash, $file $link;
@@ -779,7 +783,7 @@
}
}
NEXT_LINK:
-
+
if ($link =~ m,\.(gz|z|Z|bz|bz2|tgz|zip)\s*$,) {
# symlink is pointing to a compressed file
Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2007-10-15 03:56:32 UTC (rev 972)
+++ trunk/checks/files.desc 2007-10-15 04:19:12 UTC (rev 973)
@@ -668,3 +668,12 @@
Info: This package installs a file in tt/usr/lib/sgml/tt. This was
the old location for SGML catalogs and similar flies. All those files
should now go into tt/usr/share/sgml/tt.
+
+Tag: file-name-ends-in-whitespace
+Type: warning
+Info: This package installs a file or directory whose name ends in
+ whitespace. This might be intentional but it's normally a mistake. If
+ it is intentional, add a lintian override.
+ .
+ One possible cause is using debhelper 5.0.57 or earlier to install a
+ doc-base file with a Document field that ends in whitespace.
Modified: trunk/checks/menus
===
--- trunk/checks/menus 2007-10-15 03:56:32 UTC (rev 972)
+++ trunk/checks/menus 2007-10-15 04:19:12 UTC (rev 973)
@@ -163,7 +163,7 @@
while (my $dbfile = readdir DOCBASEDIR) {
# don't try to parse executables, plus we already warned about it
next if -x doc-base/$dbfile;
- open IN, doc-base/$dbfile or
+ open (IN, '', doc-base/$dbfile) or
fail(cannot open doc-base file $dbfile for reading.);
# Check if files referenced by doc-base are included in the package.
@@ -228,6 +228,8 @@
unless $known_doc_base_formats{$format};
} elsif (defined ($_) /^Document\s*:/i) {
$sawdocument = 1;
+tag doc-base-document-field-ends-in-whitespace, $dbfile:$.
+if /[ \t]$/;
} elsif (defined ($_) /^\s/ $field) {
push (@files, split ' ');
}
Modified: trunk/checks/menus.desc
===
--- trunk/checks/menus.desc 2007-10-15 03:56:32 UTC (rev 972)
+++ trunk/checks/menus.desc 2007-10-15 04:19:12 UTC (rev 973)
@@ -191,3 +191,10 @@
documentation. Even if the documentation is a single file, this field
must be present.
Ref: Debian doc-base Manual section 2.3.2.2
+
+Tag: doc-base-document-field-ends-in-whitespace
+Type: error
+Info: The Document field in a doc-base file should not end in whitespace.
+ doc-base (at least as of 0.8.5) cannot cope with such fields and
+ debhelper 5.0.57 or earlier may create files ending in whitespace when
+ installing such files.
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 03:56:32 UTC (rev 972)
+++ trunk/debian/changelog 2007-10-15 04:19:12 UTC (rev 973)
@@ -43,6 +43,7 @@
+ [RA] Improve the recommended command to remove .packlist files.
Thanks, Justin Pryzby.
+ [RA] Don't think hard links are zero-length files.
++ [RA] Diagnose files with names ending in whitespace.
* checks/infofiles:
+ [RA] Emacs 22 now allows embedded images in info files, so accept
and ignore PNG files in the info directory. More image types may be
@@ -57,6 +58,10 @@
is widely used. Thanks, Raphael Geissert. (Closes: #444651)
* checks/menus:
+ [RA] Find the targets of hard links correctly. (Closes: #444355)
++ [RA] Use the three-argument form of open to not fail on doc-base
+
lintian: r972 - in trunk: checks debian testset testset/binary/debian
Author: rra
Date: 2007-10-15 05:56:32 +0200 (Mon, 15 Oct 2007)
New Revision: 972
Modified:
trunk/checks/control-file
trunk/checks/control-file.desc
trunk/debian/changelog
trunk/testset/binary/debian/control
trunk/testset/tags.binary
Log:
+ [RA] Check for XS-Vcs-* headers and recommend (at info level) that
they be changed to Vcs-* headers. (Closes: #444661)
Modified: trunk/checks/control-file
===
--- trunk/checks/control-file 2007-10-15 03:56:21 UTC (rev 971)
+++ trunk/checks/control-file 2007-10-15 03:56:32 UTC (rev 972)
@@ -20,6 +20,8 @@
package Lintian::control_file;
use strict;
+use lib $ENV{'LINTIAN_ROOT'}/checks/;
+use common_data;
use Util;
use Tags;
@@ -55,6 +57,12 @@
tag debian-control-with-duplicate-fields, $field:
$$seen_fields{$field}, $.;
}
$seen_fields-{$field} = $.;
+ if ($field =~ /^xs-vcs-/) {
+ my $base = $field;
+ $base =~ s/^xs-//;
+ tag xs-vcs-header-in-debian-control, $field
+ if $known_source_fields{$base};
+ }
}
}
close CONTROL;
Modified: trunk/checks/control-file.desc
===
--- trunk/checks/control-file.desc 2007-10-15 03:56:21 UTC (rev 971)
+++ trunk/checks/control-file.desc 2007-10-15 03:56:32 UTC (rev 972)
@@ -21,8 +21,8 @@
Tag: build-info-in-binary-control-file-section
Type: error
Ref: policy 5.2
-Info: The control file has a `Build-Depends', `Build-Depends-Indep',
- `Build-Conflicts' or `Build-Conflicts-Indep' field in a binary
+Info: The control file has a Build-Depends, Build-Depends-Indep,
+ Build-Conflicts, or Build-Conflicts-Indep field in a binary
section. These specify source package relationships, and should be in
the source section of the control file.
@@ -61,3 +61,10 @@
category of the archive. A source package in main may only build binary
packages in main, a source package in non-free may only build binary
packages in non-free, and so forth.
+
+Tag: xs-vcs-header-in-debian-control
+Type: info
+Info: There is an XS-Vcs-* field in the ttdebian/control/tt file. As
+ of dpkg 1.14.6, the XS- prefix is no longer necessary. dpkg now
+ recognizes these headers and handles them correctly. Consider removing
+ the XS- prefix for this field.
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 03:56:21 UTC (rev 971)
+++ trunk/debian/changelog 2007-10-15 03:56:32 UTC (rev 972)
@@ -9,6 +9,8 @@
* checks/control-file:
+ [RA] Support and ignore comments in debian/control. Thanks, Julien
Cristau. (Closes: #440830)
++ [RA] Check for XS-Vcs-* headers and recommend (at info level) that
+ they be changed to Vcs-* headers. (Closes: #444661)
* checks/cruft.desc:
+ [RA] Fix incorrect tag name for patch failure files. Thanks, Romain
Francoise. (Closes: #437463)
Modified: trunk/testset/binary/debian/control
===
--- trunk/testset/binary/debian/control 2007-10-15 03:56:21 UTC (rev 971)
+++ trunk/testset/binary/debian/control 2007-10-15 03:56:32 UTC (rev 972)
@@ -6,6 +6,7 @@
Standards-Version: 3.2.1
Homepage: http://lintian.debian.org/
Vcs-Svn: http://svn.wolffelaar.nl/lintian/trunk
+XS-Vcs-Browser: http://svn.wolffelaar.nl/lintian/trunk
Package: binary
Architecture: any
Modified: trunk/testset/tags.binary
===
--- trunk/testset/tags.binary 2007-10-15 03:56:21 UTC (rev 971)
+++ trunk/testset/tags.binary 2007-10-15 03:56:32 UTC (rev 972)
@@ -34,6 +34,7 @@
E: binary: symlink-contains-spurious-segments
usr/share/doc/binary/html/ch2.html ../html/./ch1.html
E: binary: symlink-should-be-relative usr/share/doc/binary/html/ch3.html
/usr/share/doc/binary/htm/ch1.html
E: binary: unstripped-binary-or-object ./usr/bin/hello
+I: binary source: xs-vcs-header-in-debian-control xs-vcs-browser
I: binary: arch-dep-package-has-big-usr-share
I: binary: binary-has-unneeded-section ./usr/bin/hello-static .comment
I: binary: description-contains-homepage
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r964 - in trunk: checks debian
Author: rra
Date: 2007-10-15 04:11:29 +0200 (Mon, 15 Oct 2007)
New Revision: 964
Modified:
trunk/checks/fields.desc
trunk/checks/files.desc
trunk/checks/version-substvars.desc
trunk/debian/changelog
Log:
* checks/fields.desc:
+ [RA] Properly escape and .
+ [RA] Improve the recommended command to remove .packlist files.
Thanks, Justin Pryzby.
* checks/version-substvars.desc:
+ [RA] Properly escape and .
Modified: trunk/checks/fields.desc
===
--- trunk/checks/fields.desc2007-10-15 02:03:07 UTC (rev 963)
+++ trunk/checks/fields.desc2007-10-15 02:11:29 UTC (rev 964)
@@ -648,9 +648,9 @@
.
all
current
- current, = X.Y
- = X.Y
- = A.B, X.Y
+ current, gt;= X.Y
+ gt;= X.Y
+ gt;= A.B, lt;lt; X.Y
A.B, X.Y
.
(One or more specific versions may be listed with the last form.) A.B
Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2007-10-15 02:03:07 UTC (rev 963)
+++ trunk/checks/files.desc 2007-10-15 02:11:29 UTC (rev 964)
@@ -487,12 +487,10 @@
.
They can be suppressed by adding the following to ttdebian/rules/tt:
.
- ttfind debian/tmp -type f -name .packlist | xargs rm -f/tt
+ find debian/ipkg/i -type f -name .packlist | xargs rm -f
.
- tt-find debian/tmp/usr/lib/perl5 -type d -empty | xargs rmdir -p/tt
- .
- Or by telling MakeMaker to use vendor install dirs; consult a recent
- version of perl policy. Perl 5.6.0-12 or higher supports this.
+ or by telling MakeMaker to use vendor install dirs; consult a recent
+ version of Perl policy. Perl 5.6.0-12 or higher supports this.
Tag: zero-byte-file-in-doc-directory
Type: warning
Modified: trunk/checks/version-substvars.desc
===
--- trunk/checks/version-substvars.desc 2007-10-15 02:03:07 UTC (rev 963)
+++ trunk/checks/version-substvars.desc 2007-10-15 02:11:29 UTC (rev 964)
@@ -32,8 +32,9 @@
arch:any packages while having the package binNMUable, so please use
one of these, whichever is more appropriate:
.
- Depends: arch_any (= ${source:Version})
- Depends: arch_any (= ${source:Version}), arch_any ( ${source:Version}.1~)
+ Depends: arch_any (gt;= ${source:Version})
+ Depends: arch_any (gt;= ${source:Version}),
+arch_any (lt;lt; ${source:Version}.1~)
Tag: version-substvar-for-external-package
Type: error
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 02:03:07 UTC (rev 963)
+++ trunk/debian/changelog 2007-10-15 02:11:29 UTC (rev 964)
@@ -28,11 +28,15 @@
* checks/description{.desc,}:
+ [RA] Warn (at info level for now) about Homepage pseudo-fields in
the extended description. (Closes: #444336)
+ * checks/fields.desc:
++ [RA] Properly escape and .
* checks/files{.desc,}:
+ [RA] Warn about Thumbs.db files, which are usually useless Windows
thumbnail databases. Thanks, Paul Wise. (Closes: #438202)
+ [RA] Warn about .DS_Store files, used by Mac OS X to store extended
folder attributes. Thanks, Paul Wise. (Closes: #438203)
++ [RA] Improve the recommended command to remove .packlist files.
+ Thanks, Justin Pryzby.
* checks/infofiles:
+ [RA] Emacs 22 now allows embedded images in info files, so accept
and ignore PNG files in the info directory. More image types may be
@@ -43,11 +47,13 @@
* checks/scripts:
+ [RA] We now have a csh package. Allow it as an alternative for csh
script dependencies. Thanks, Bernd Zeimetz. (Closes: #440825)
+ * checks/version-substvars.desc:
++ [RA] Properly escape and .
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 19:00:30 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 19:11:25 -0700
lintian (1.23.34) unstable; urgency=low
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r966 - in trunk: checks debian testset testset/binary/debian testset/maintainer-scripts/debian
Author: rra
Date: 2007-10-15 04:44:24 +0200 (Mon, 15 Oct 2007)
New Revision: 966
Modified:
trunk/checks/menu-format
trunk/checks/scripts
trunk/checks/scripts.desc
trunk/debian/changelog
trunk/testset/binary/debian/hello.desktop
trunk/testset/maintainer-scripts/debian/postinst
trunk/testset/maintainer-scripts/debian/postrm
trunk/testset/tags.maintainer-scripts
Log:
+ [RA] Ignore categories beginning with X-, reserved for category
extensions. Thanks, Josselin Mouette. (Closes: #443827)
* checks/scripts{.desc,}:
+ [RA] Allow install-sgmlcatalog --remove in postinst as well as
prerm and suggest removing it entirely in the long description.
Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-15 02:26:33 UTC (rev 965)
+++ trunk/checks/menu-format2007-10-15 02:44:24 UTC (rev 966)
@@ -782,6 +782,7 @@
my @cats = split (';', $vals{'Categories'});
my $saw_main;
for my $cat (@cats) {
+next if $cat =~ /^X-/;
if ($reserved_categories{$cat}) {
tag desktop-entry-uses-reserved-category, $cat $file
unless $vals{'OnlyShowIn'};
Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2007-10-15 02:26:33 UTC (rev 965)
+++ trunk/checks/scripts2007-10-15 02:44:24 UTC (rev 966)
@@ -656,7 +656,7 @@
if (m,\bgconftool(-2)?(\s|\Z),) {
tag gconftool-used-in-maintainer-script, $file:$.;
}
- if (m,\binstall-sgmlcatalog\b, !(m,--remove, $file eq 'prerm')) {
+ if (m,\binstall-sgmlcatalog\b, !(m,--remove, ($file eq 'prerm' ||
$file eq 'postinst'))) {
tag install-sgmlcatalog-deprecated, $file:$.;
}
if (m,/var/lib/dpkg/status\b, $pkg ne 'base-files' $pkg ne
'dpkg') {
Modified: trunk/checks/scripts.desc
===
--- trunk/checks/scripts.desc 2007-10-15 02:26:33 UTC (rev 965)
+++ trunk/checks/scripts.desc 2007-10-15 02:44:24 UTC (rev 966)
@@ -408,6 +408,8 @@
Tag: install-sgmlcatalog-deprecated
Type: error
Info: The maintainer script apparently runs install-sgmlcatalog with flags
- other than tt--quiet/tt and tt--remove/tt. install-sgmlcatalog
- is deprecated and should only be used in prerm to remove the entries from
- earlier packages.
+ other than tt--quiet/tt and tt--remove/tt or in a maintainer
+ script other than postinst or prerm. install-sgmlcatalog is deprecated
+ and should only be used in postinst or prerm to remove the entries from
+ earlier packages. Given how long ago this transition was, consider
+ removing it entirely.
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 02:26:33 UTC (rev 965)
+++ trunk/debian/changelog 2007-10-15 02:44:24 UTC (rev 966)
@@ -45,19 +45,23 @@
+ [RA] Reserved categories are okay in .desktop files if OnlyShowIn is
present, and generally deserve their own separate tag regardless.
Thanks, Michael Biebl. (Closes: #442709)
++ [RA] Ignore categories beginning with X-, reserved for category
+ extensions. Thanks, Josselin Mouette. (Closes: #443827)
* checks/nmu.desc:
+ [RA] Remove obsolete note about binary NMUs. Patch from Thijs
Kinkhorst. (Closes: #437925)
- * checks/scripts:
+ * checks/scripts{.desc,}:
+ [RA] We now have a csh package. Allow it as an alternative for csh
script dependencies. Thanks, Bernd Zeimetz. (Closes: #440825)
++ [RA] Allow install-sgmlcatalog --remove in postinst as well as
+ prerm and suggest removing it entirely in the long description.
* checks/version-substvars.desc:
+ [RA] Properly escape and .
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 19:24:56 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 19:41:13 -0700
lintian (1.23.34) unstable; urgency=low
Modified: trunk/testset/binary/debian/hello.desktop
===
--- trunk/testset/binary/debian/hello.desktop 2007-10-15 02:26:33 UTC (rev
965)
+++ trunk/testset/binary/debian/hello.desktop 2007-10-15 02:44:24 UTC (rev
966)
@@ -9,6 +9,6 @@
Icon=hello
Terminal=true
Type=Application
-Categories=GNOME;GTK;System;Applet;Settings;
+Categories=GNOME;GTK;System;Applet;X-Foo;Settings;
Encoding=UTF-8
OnlyShowIn=GNOME;
Modified: trunk/testset/maintainer-scripts/debian/postinst
===
--- trunk/testset/maintainer-scripts/debian/postinst2007-10-15 02:26:33 UTC
(rev 965)
+++ trunk/testset/maintainer-scripts/debian/postinst2007-10-15 02:44:24 UTC
(rev 966)
@@ -94,6
lintian: r958 - in trunk: checks debian testset/manpages/debian
Author: rra
Date: 2007-10-15 03:05:06 +0200 (Mon, 15 Oct 2007)
New Revision: 958
Modified:
trunk/checks/infofiles
trunk/debian/changelog
trunk/testset/manpages/debian/rules
Log:
* checks/infofiles:
+ [RA] Emacs 22 now allows embedded images in info files, so accept
and ignore PNG files in the info directory. More image types may be
needed. Thanks, Andreas Metzler. (Closes: #438602)
Modified: trunk/checks/infofiles
===
--- trunk/checks/infofiles 2007-10-15 00:59:02 UTC (rev 957)
+++ trunk/checks/infofiles 2007-10-15 01:05:06 UTC (rev 958)
@@ -80,6 +80,9 @@
next unless ($perm =~ m,^[\-l],o)
and ($path =~ m,^usr/share/info/, or $path =~ m,^usr/info/,);
+# Analyze the file names making sure the documents are named properly.
+# Note that Emacs 22 added support for images in info files, so we have to
+# accept those and ignore them. Just ignore .png files for now.
my @fname_pieces = split /\./, $fname;
my $ext = pop @fname_pieces;
if ($ext eq gz) { # ok!
@@ -93,6 +96,8 @@
}
}
}
+} elsif ($ext eq 'png') {
+next;
} else {
push (@fname_pieces, $ext);
tag info-document-not-compressed, $file;
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 00:59:02 UTC (rev 957)
+++ trunk/debian/changelog 2007-10-15 01:05:06 UTC (rev 958)
@@ -17,6 +17,10 @@
thumbnail databases. Thanks, Paul Wise. (Closes: #438202)
+ [RA] Warn about .DS_Store files, used by Mac OS X to store extended
folder attributes. Thanks, Paul Wise. (Closes: #438203)
+ * checks/infofiles:
++ [RA] Emacs 22 now allows embedded images in info files, so accept
+ and ignore PNG files in the info directory. More image types may be
+ needed. Thanks, Andreas Metzler. (Closes: #438602)
* checks/nmu.desc:
+ [RA] Remove obsolete note about binary NMUs. Patch from Thijs
Kinkhorst. (Closes: #437925)
@@ -24,7 +28,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 17:56:35 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 18:05:02 -0700
lintian (1.23.34) unstable; urgency=low
Modified: trunk/testset/manpages/debian/rules
===
--- trunk/testset/manpages/debian/rules 2007-10-15 00:59:02 UTC (rev 957)
+++ trunk/testset/manpages/debian/rules 2007-10-15 01:05:06 UTC (rev 958)
@@ -63,6 +63,7 @@
gzip -c9 foo.info $(tmp)/usr/share/info/foo.info.gz
gzip -c1 /dev/null $(tmp)/usr/share/info/bar.gz
install -m644 foo.info $(tmp)/usr/share/info/baz.broken.gz
+ touch $(tmp)/usr/share/info/image.png
install -d $(tmp)/usr/share/doc/manpages
cp debian/changelog $(tmp)/usr/share/doc/manpages/changelog
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r970 - in trunk: checks debian
Author: rra
Date: 2007-10-15 05:40:31 +0200 (Mon, 15 Oct 2007)
New Revision: 970
Modified:
trunk/checks/menu-format
trunk/debian/changelog
Log:
+ [RA] Allow Actions keys. This isn't in the desktop standard but
is widely used. Thanks, Raphael Geissert. (Closes: #444651)
Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-15 03:38:09 UTC (rev 969)
+++ trunk/checks/menu-format2007-10-15 03:40:31 UTC (rev 970)
@@ -136,7 +136,8 @@
# This is a list of all keys that should be in every desktop entry.
my @req_desktop_keys = qw(Type Name);
-# This is a list of all known keys.
+# This is a list of all known keys. Note that Actions isn't part of the
+# standard but appears to be widely used, so we include it anyway.
my %known_desktop_keys = map { $_ = 1 }
qw(
Type
@@ -160,6 +161,7 @@
StartupNotify
StartupWMClass
URL
+ Actions
);
my %deprecated_desktop_keys = map { $_ = 1 }
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 03:38:09 UTC (rev 969)
+++ trunk/debian/changelog 2007-10-15 03:40:31 UTC (rev 970)
@@ -51,6 +51,8 @@
Thanks, Michael Biebl. (Closes: #442709)
+ [RA] Ignore categories beginning with X-, reserved for category
extensions. Thanks, Josselin Mouette. (Closes: #443827)
++ [RA] Allow Actions keys. This isn't in the desktop standard but
+ is widely used. Thanks, Raphael Geissert. (Closes: #444651)
* checks/menus:
+ [RA] Find the targets of hard links correctly. (Closes: #444355)
* checks/nmu.desc:
@@ -67,7 +69,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 20:37:12 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 20:40:24 -0700
lintian (1.23.34) unstable; urgency=low
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r957 - in trunk: checks debian testset testset/filenames/debian
Author: rra
Date: 2007-10-15 02:59:02 +0200 (Mon, 15 Oct 2007)
New Revision: 957
Modified:
trunk/checks/files
trunk/checks/files.desc
trunk/debian/changelog
trunk/testset/filenames/debian/rules
trunk/testset/tags.filenames
Log:
+ [RA] Warn about .DS_Store files, used by Mac OS X to store extended
folder attributes. Thanks, Paul Wise. (Closes: #438203)
Modified: trunk/checks/files
===
--- trunk/checks/files 2007-10-15 00:52:01 UTC (rev 956)
+++ trunk/checks/files 2007-10-15 00:59:02 UTC (rev 957)
@@ -422,8 +422,8 @@
# setting up the base system. (Specifically, /cdrom, /floppy,
# /initrd, and /proc are not mentioned in the FHS).
tag non-standard-toplevel-dir, $file
- unless $pkg eq 'base-files'
- or $pkg eq 'hurd'
+ unless $pkg eq 'base-files'
+ or $pkg eq 'hurd'
or $pkg =~ /^rootskel(-bootfloppy)?/;
}
@@ -551,10 +551,13 @@
tag script-with-language-extension, $file;
}
- # Windows thumbnail databases
+ # Autogenerated databases from other OSes
if ($file =~ m,/Thumbs\.db(\.gz)?$,) {
tag windows-thumbnail-database-in-package, $file;
}
+ if ($file =~ m,/\.DS_Store$,) {
+ tag macos-ds-store-file-in-package, $file;
+ }
# general: setuid/setgid files!
if ($perm =~ m/s/) {
Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2007-10-15 00:52:01 UTC (rev 956)
+++ trunk/checks/files.desc 2007-10-15 00:59:02 UTC (rev 957)
@@ -416,6 +416,12 @@
ttThumbs.db.gz/tt, which is normally a Windows image thumbnail
database. Such databases are generally useless in Debian packages.
+Tag: macos-ds-store-file-in-package
+Type: warning
+Info: There is a file in the package named tt.DS_Store/tt, the file
+ name used by Mac OS X to store folder attributes. Such files are
+ generally useless in Debian packages.
+
Tag: package-installs-perllocal-pod
Type: warning
Info: This package installs a file ttperllocal.pod/tt. Since that
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 00:52:01 UTC (rev 956)
+++ trunk/debian/changelog 2007-10-15 00:59:02 UTC (rev 957)
@@ -15,6 +15,8 @@
* checks/files{.desc,}:
+ [RA] Warn about Thumbs.db files, which are usually useless Windows
thumbnail databases. Thanks, Paul Wise. (Closes: #438202)
++ [RA] Warn about .DS_Store files, used by Mac OS X to store extended
+ folder attributes. Thanks, Paul Wise. (Closes: #438203)
* checks/nmu.desc:
+ [RA] Remove obsolete note about binary NMUs. Patch from Thijs
Kinkhorst. (Closes: #437925)
@@ -22,7 +24,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 17:47:43 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 17:56:35 -0700
lintian (1.23.34) unstable; urgency=low
Modified: trunk/testset/filenames/debian/rules
===
--- trunk/testset/filenames/debian/rules2007-10-15 00:52:01 UTC (rev
956)
+++ trunk/testset/filenames/debian/rules2007-10-15 00:59:02 UTC (rev
957)
@@ -81,6 +81,7 @@
echo foo debian/tmp/usr/share/doc/filenames/bokm�l
echo foo debian/tmp/usr/share/doc/filenames/Thumbs.db
+ echo foo debian/tmp/usr/share/doc/filenames/.DS_Store
touch debian/tmp/usr/share/doc/filenames/news.debian
gzip debian/tmp/usr/share/doc/filenames/news.debian
Modified: trunk/testset/tags.filenames
===
--- trunk/testset/tags.filenames2007-10-15 00:52:01 UTC (rev 956)
+++ trunk/testset/tags.filenames2007-10-15 00:59:02 UTC (rev 957)
@@ -65,6 +65,7 @@
W: filenames: file-in-unusual-dir files/svn-commit.tmp
W: filenames: file-in-unusual-dir srv/foo/bar
W: filenames: file-in-usr-lib-sgml usr/lib/sgml/package
+W: filenames: macos-ds-store-file-in-package usr/share/doc/filenames/.DS_Store
W: filenames: menu-file-in-usr-lib usr/lib/menu/menu
W: filenames: no-priority-field
W: filenames: no-section-field
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r974 - trunk/checks
Author: rra
Date: 2007-10-15 06:35:45 +0200 (Mon, 15 Oct 2007)
New Revision: 974
Modified:
trunk/checks/menu-format
Log:
If there is a reserved category, don't diagnose missing main categories,
since the reserved category may be a main category.
Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-15 04:19:12 UTC (rev 973)
+++ trunk/checks/menu-format2007-10-15 04:35:45 UTC (rev 974)
@@ -788,6 +788,7 @@
if ($reserved_categories{$cat}) {
tag desktop-entry-uses-reserved-category, $cat $file
unless $vals{'OnlyShowIn'};
+$saw_main = 1;
} elsif (not $categories{$cat} and not $main_categories{$cat}) {
tag desktop-entry-invalid-category, $cat $file;
} elsif ($main_categories{$cat}) {
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r962 - in trunk: checks debian testset/binary/debian
Author: rra
Date: 2007-10-15 03:56:44 +0200 (Mon, 15 Oct 2007)
New Revision: 962
Modified:
trunk/checks/control-file
trunk/debian/changelog
trunk/testset/binary/debian/control
Log:
* checks/control-file:
+ [RA] Support and ignore comments in debian/control. Thanks, Julien
Cristau. (Closes: #440830)
Modified: trunk/checks/control-file
===
--- trunk/checks/control-file 2007-10-15 01:38:31 UTC (rev 961)
+++ trunk/checks/control-file 2007-10-15 01:56:44 UTC (rev 962)
@@ -43,6 +43,7 @@
open (CONTROL, debfiles/control) or fail Couldn't read debfiles/control:
$!;
while (CONTROL) {
s/\s*\n$//;
+ next if /^\#/;
#Reset seen_fields if we enter a new section:
$seen_fields = {} if /^$/;
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 01:38:31 UTC (rev 961)
+++ trunk/debian/changelog 2007-10-15 01:56:44 UTC (rev 962)
@@ -6,6 +6,9 @@
and unreleased for the distribution. (Closes: #437707)
* checks/common_data.pm:
+ [RA] Allow Homepage in source and binary packages.
+ * checks/control-file:
++ [RA] Support and ignore comments in debian/control. Thanks, Julien
+ Cristau. (Closes: #440830)
* checks/cruft.desc:
+ [RA] Fix incorrect tag name for patch failure files. Thanks, Romain
Francoise. (Closes: #437463)
@@ -40,7 +43,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 18:38:07 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 18:53:49 -0700
lintian (1.23.34) unstable; urgency=low
Modified: trunk/testset/binary/debian/control
===
--- trunk/testset/binary/debian/control 2007-10-15 01:38:31 UTC (rev 961)
+++ trunk/testset/binary/debian/control 2007-10-15 01:56:44 UTC (rev 962)
@@ -23,3 +23,11 @@
Description: test handling of binary relationships
Regression test for lintian's checking of package relationships between
arch:any and arch:all packages.
+
+#Package: binary-comment
+#Architecture: space-almonds
+#Depends: *
+#Depends: *
+#Description: test comment support
+# Yes, comments are actually allowed in debian/control, so none of the
+# above should produce errors.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r967 - in trunk: checks debian testset/binary/debian testset/filenames/debian
Author: rra
Date: 2007-10-15 05:31:43 +0200 (Mon, 15 Oct 2007)
New Revision: 967
Modified:
trunk/checks/files
trunk/checks/menus
trunk/debian/changelog
trunk/testset/binary/debian/doc-base
trunk/testset/binary/debian/rules
trunk/testset/filenames/debian/rules
Log:
+ [RA] Don't think hard links are zero-length files.
* checks/menus:
+ [RA] Find the targets of hard links correctly. (Closes: #444355)
Modified: trunk/checks/files
===
--- trunk/checks/files 2007-10-15 02:44:24 UTC (rev 966)
+++ trunk/checks/files 2007-10-15 03:31:43 UTC (rev 967)
@@ -36,6 +36,7 @@
my $has_binary_perl_file;
my @nonbinary_perl_files_in_lib;
+my %is_hard_link;
my %linked_against_libvga;
my %script = ();
@@ -86,6 +87,7 @@
$file =~ s,^\./,,;
if ($file =~ s/ link to (.*)//) {
+$is_hard_link{$file} = 1;
my $link_target = $1;
$link_target =~ s,^\./,,;
my $link_target_dir = $link_target;
@@ -195,7 +197,7 @@
}
# zero byte file in /usr/share/doc/
- if ($size == 0 and $perm =~ m,^-,) {
+ if ($size == 0 and $perm =~ m,^-, and not $is_hard_link{$file})
{
# exception: __init__.py files are empty tagging files (see
# bug #215234)
unless ($file =~
m,^usr/share/doc/([^/]+/)?examples/(.+/)?__init__\.py$,) {
Modified: trunk/checks/menus
===
--- trunk/checks/menus 2007-10-15 02:44:24 UTC (rev 966)
+++ trunk/checks/menus 2007-10-15 03:31:43 UTC (rev 967)
@@ -292,12 +292,15 @@
$file = / . $file if (not $file =~ m%^/%); # make file absolute
$file =~ s%/+%/%g; # remove duplicated `/'
-($file, $link) = split(/ - /, $file);
+my $ishard = ($file =~ / link to /);
+($file, $link) = split(/ (?:-|link to) /, $file);
$all_files{$file} = 1;
if (defined $link) {
- if (not $link =~ m,^/,) { # not absolute link
+ if ($ishard) {
+ $link =~ s,^\./,/,;
+ } elsif (not $link =~ m,^/,) {# not absolute link
$link = / . $link; # make sure link starts with
'/'
$link =~ s,/+\./+,/,g;# remove all /./ parts
my $dcount = 1;
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 02:44:24 UTC (rev 966)
+++ trunk/debian/changelog 2007-10-15 03:31:43 UTC (rev 967)
@@ -37,6 +37,7 @@
folder attributes. Thanks, Paul Wise. (Closes: #438203)
+ [RA] Improve the recommended command to remove .packlist files.
Thanks, Justin Pryzby.
++ [RA] Don't think hard links are zero-length files.
* checks/infofiles:
+ [RA] Emacs 22 now allows embedded images in info files, so accept
and ignore PNG files in the info directory. More image types may be
@@ -47,6 +48,8 @@
Thanks, Michael Biebl. (Closes: #442709)
+ [RA] Ignore categories beginning with X-, reserved for category
extensions. Thanks, Josselin Mouette. (Closes: #443827)
+ * checks/menus:
++ [RA] Find the targets of hard links correctly. (Closes: #444355)
* checks/nmu.desc:
+ [RA] Remove obsolete note about binary NMUs. Patch from Thijs
Kinkhorst. (Closes: #437925)
@@ -61,7 +64,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 19:41:13 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 20:29:58 -0700
lintian (1.23.34) unstable; urgency=low
Modified: trunk/testset/binary/debian/doc-base
===
--- trunk/testset/binary/debian/doc-base2007-10-15 02:44:24 UTC (rev
966)
+++ trunk/testset/binary/debian/doc-base2007-10-15 03:31:43 UTC (rev
967)
@@ -29,4 +29,9 @@
Format: inFO
Files: /usr/share/info/binary.info.gz
+Format: HTML
+Index: /usr/share/doc/binary/html/index.html
+Files: /usr/share/doc/binary/html/ch5.html
+ /usr/share/doc/binary/html/ch6.html
+
Modified: trunk/testset/binary/debian/rules
===
--- trunk/testset/binary/debian/rules 2007-10-15 02:44:24 UTC (rev 966)
+++ trunk/testset/binary/debian/rules 2007-10-15 03:31:43 UTC (rev 967)
@@ -33,6 +33,9 @@
echo 'html/html' $(tmp)/usr/share/doc/binary/html/ch1.html
ln -s ../html/./ch1.html $(tmp)/usr/share/doc/binary/html/ch2.html
ln -s /usr/share/doc/binary/htm/ch1.html
$(tmp)/usr/share/doc/binary/html/ch3.html
+ echo 'html/html' $(tmp)/usr/share/doc/binary/html/ch5.html
+ ln $(tmp)/usr/share/doc/binary/html/ch5.html \
+ $(tmp)/usr/share/doc/binary/html/ch6.html
install -d
lintian: r968 - in trunk: checks debian
Author: rra
Date: 2007-10-15 05:37:26 +0200 (Mon, 15 Oct 2007)
New Revision: 968
Modified:
trunk/checks/fields
trunk/debian/changelog
Log:
* checks/fields:
+ [RA] Allow python-all as yet another way of satisfying a Python
build dependency. (Closes: #444642)
Modified: trunk/checks/fields
===
--- trunk/checks/fields 2007-10-15 03:31:43 UTC (rev 967)
+++ trunk/checks/fields 2007-10-15 03:37:26 UTC (rev 968)
@@ -33,7 +33,7 @@
# The allowed Python dependencies currently. This is the list of alternatives
# that, either directly or through transitive dependencies that can be relied
# upon, ensure /usr/bin/python will exist for the use of dh_python.
-my $python_depend = 'python | python-dev | python-all-dev';
+my $python_depend = 'python | python-dev | python-all | python-all-dev';
# Certain build tools must be listed in Build-Depends even if there are no
# arch-specific packages because they're required in order to run the clean
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 03:31:43 UTC (rev 967)
+++ trunk/debian/changelog 2007-10-15 03:37:26 UTC (rev 968)
@@ -28,6 +28,9 @@
* checks/description{.desc,}:
+ [RA] Warn (at info level for now) about Homepage pseudo-fields in
the extended description. (Closes: #444336)
+ * checks/fields:
++ [RA] Allow python-all as yet another way of satisfying a Python
+ build dependency. (Closes: #444642)
* checks/fields.desc:
+ [RA] Properly escape and .
* checks/files{.desc,}:
@@ -64,7 +67,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 20:29:58 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 20:37:12 -0700
lintian (1.23.34) unstable; urgency=low
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r963 - in trunk: checks debian testset
Author: rra
Date: 2007-10-15 04:03:07 +0200 (Mon, 15 Oct 2007)
New Revision: 963
Modified:
trunk/checks/debconf
trunk/debian/changelog
trunk/testset/tags.debconf
Log:
+ [RA] More exactly follow the Developer's Reference recommendations
by only requiring open prompts for string and password prompts and
only complaining about imperative wording for select and multiselect
templates. Thanks, Steve Langasek. (Closes: #442711)
Modified: trunk/checks/debconf
===
--- trunk/checks/debconf2007-10-15 01:56:44 UTC (rev 962)
+++ trunk/checks/debconf2007-10-15 02:03:07 UTC (rev 963)
@@ -281,11 +281,14 @@
}
my $type = $template-{type} || '';
unless ($short =~ /for internal use/i) {
- my $isprompt = grep { $_ eq $type } qw(string select password
multiselect);
+ my $isprompt = grep { $_ eq $type } qw(string password);
+my $isselect = grep { $_ eq $type } qw(select multiselect);
if ($isprompt) {
if ($short ($short !~ m/:$/ || $short =~
m/^(what|who|when|where|which|how)/i)) {
tag malformed-prompt-in-templates, $template-{template};
}
+}
+if ($isselect) {
if ($short =~ /^(Please|Cho+se|Enter|Select|Specify|Give)/) {
tag using-imperative-form-in-templates, $template-{template};
}
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 01:56:44 UTC (rev 962)
+++ trunk/debian/changelog 2007-10-15 02:03:07 UTC (rev 963)
@@ -21,6 +21,10 @@
warn on any questions in the extended description, allow yes/no
mentions in non-boolean templates, and catch more first-person
language. (Closes: #439508)
++ [RA] More exactly follow the Developer's Reference recommendations
+ by only requiring open prompts for string and password prompts and
+ only complaining about imperative wording for select and multiselect
+ templates. Thanks, Steve Langasek. (Closes: #442711)
* checks/description{.desc,}:
+ [RA] Warn (at info level for now) about Homepage pseudo-fields in
the extended description. (Closes: #444336)
@@ -43,7 +47,7 @@
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 18:53:49 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 19:00:30 -0700
lintian (1.23.34) unstable; urgency=low
Modified: trunk/testset/tags.debconf
===
--- trunk/testset/tags.debconf 2007-10-15 01:56:44 UTC (rev 962)
+++ trunk/testset/tags.debconf 2007-10-15 02:03:07 UTC (rev 963)
@@ -25,7 +25,6 @@
W: debconf-test-preinst: missing-debconf-dependency-for-preinst
W: debconf-test-preinst: old-fsf-address-in-copyright-file
W: debconf-test: making-assumptions-about-interfaces-in-templates
debconf/testboolean
-W: debconf-test: malformed-prompt-in-templates debconf/testmulti
W: debconf-test: malformed-prompt-in-templates debconf/teststring
W: debconf-test: malformed-question-in-templates debconf/testboolean
W: debconf-test: malformed-title-in-templates debconf/testnote
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r960 - in trunk: checks debian
Author: rra
Date: 2007-10-15 03:12:31 +0200 (Mon, 15 Oct 2007)
New Revision: 960
Modified:
trunk/checks/scripts
trunk/debian/changelog
Log:
* checks/scripts:
+ [RA] We now have a csh package. Allow it as an alternative for csh
script dependencies. Thanks, Bernd Zeimetz. (Closes: #440825)
Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2007-10-15 01:10:38 UTC (rev 959)
+++ trunk/checks/scripts2007-10-15 01:12:31 UTC (rev 960)
@@ -123,7 +123,7 @@
'ash' = 'ash',
'bltwish' = 'blt',
'burlap' = 'felt',
- 'csh' = 'c-shell | tcsh',
+ 'csh' = 'c-shell | tcsh | csh',
'dash' = 'dash',
'expect' = 'expect',
'expectk' = 'expectk',
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 01:10:38 UTC (rev 959)
+++ trunk/debian/changelog 2007-10-15 01:12:31 UTC (rev 960)
@@ -28,11 +28,14 @@
* checks/nmu.desc:
+ [RA] Remove obsolete note about binary NMUs. Patch from Thijs
Kinkhorst. (Closes: #437925)
+ * checks/scripts:
++ [RA] We now have a csh package. Allow it as an alternative for csh
+ script dependencies. Thanks, Bernd Zeimetz. (Closes: #440825)
* collection/changelog-file{.desc,}:
+ [RA] Collect NEWS.Debian as well as changelog.
- -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 18:06:47 -0700
+ -- Russ Allbery [EMAIL PROTECTED] Sun, 14 Oct 2007 18:12:22 -0700
lintian (1.23.34) unstable; urgency=low
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r961 - in trunk: checks debian testset testset/debconf/debian
Author: rra
Date: 2007-10-15 03:38:31 +0200 (Mon, 15 Oct 2007)
New Revision: 961
Modified:
trunk/checks/debconf
trunk/checks/debconf.desc
trunk/debian/changelog
trunk/testset/debconf/debian/debconf-test.templates
trunk/testset/tags.debconf
Log:
+ [RA] Various improvements from Thomas Huriaux: Diagnose select
templates with only yes/no options, diagnose more question prompts,
warn on any questions in the extended description, allow yes/no
mentions in non-boolean templates, and catch more first-person
language. (Closes: #439508)
Modified: trunk/checks/debconf
===
--- trunk/checks/debconf2007-10-15 01:12:31 UTC (rev 960)
+++ trunk/checks/debconf2007-10-15 01:38:31 UTC (rev 961)
@@ -215,6 +215,9 @@
}
}
}
+ if ($template-{choices} =~ /^\s*(yes\s*,\s*no|no\s*,\s*yes)\s*$/i) {
+ tag select-with-boolean-choices, $template-{template};
+ }
}
if ($isselect and not exists $template-{choices}) {
@@ -280,7 +283,7 @@
unless ($short =~ /for internal use/i) {
my $isprompt = grep { $_ eq $type } qw(string select password
multiselect);
if ($isprompt) {
- if ($short $short !~ m/:$/) {
+ if ($short ($short !~ m/:$/ || $short =~
m/^(what|who|when|where|which|how)/i)) {
tag malformed-prompt-in-templates, $template-{template};
}
if ($short =~ /^(Please|Cho+se|Enter|Select|Specify|Give)/) {
@@ -291,10 +294,10 @@
if ($short !~ /\?/) {
tag malformed-question-in-templates, $template-{template};
}
- if (defined ($extended) $extended =~ /\?/) {
- tag using-question-in-extended-description-in-templates,
$template-{template};
- }
}
+ if (defined ($extended) $extended =~ /\?/) {
+ tag using-question-in-extended-description-in-templates,
$template-{template};
+ }
if ($type eq 'note') {
if ($short =~ /[.?;:]$/) {
tag malformed-title-in-templates, $template-{template};
@@ -304,10 +307,10 @@
tag too-long-short-description-in-templates,
$template-{template};
}
if (defined $template-{description}) {
-if ($template-{description} =~
/(\A|\s)(I|[Mm]y|[Ww]e|[Oo]ur|[Oo]urs|mine|myself|ourself|me|us) /) {
+if ($template-{description} =~
/(\A|\s)(I|[Mm]y|[Ww]e|[Oo]ur|[Oo]urs|mine|myself|ourself|me|us)(\Z|\s)/) {
tag using-first-person-in-templates, $template-{template};
}
-if ($template-{description} =~ /[ \'\]([Yy]es)[ \'\,.]/) {
+if ($template-{description} =~ /[ \'\](yes|no)[ \'\,;.]/i and
$type eq 'boolean') {
tag making-assumptions-about-interfaces-in-templates,
$template-{template};
}
}
Modified: trunk/checks/debconf.desc
===
--- trunk/checks/debconf.desc 2007-10-15 01:12:31 UTC (rev 960)
+++ trunk/checks/debconf.desc 2007-10-15 01:38:31 UTC (rev 961)
@@ -218,12 +218,12 @@
Tag: using-question-in-extended-description-in-templates
Type: warning
-Info: The extended description of a boolean debconf template should not
- include a question.
+Info: The extended description of a debconf template should never include
+ a question.
.
If this template is only used internally by the package and not displayed
to the user, put for internal use in the short description.
-Ref: devref 6.5.4.2.2
+Ref: devref 6.5.3.2
Tag: using-imperative-form-in-templates
Type: warning
@@ -290,3 +290,9 @@
needed (e.g. welcome notes). Changing the templates type to error
can also be appropriate, such as for input validation errors.
Ref: policy 3.9.1
+
+Tag: select-with-boolean-choices
+Type: warning
+Info: Select templates with only yes and no choices should use the boolean
+ type instead.
+Ref: debconf-devel(7)
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 01:12:31 UTC (rev 960)
+++ trunk/debian/changelog 2007-10-15 01:38:31 UTC (rev 961)
@@ -13,6 +13,11 @@
+ [RA] A cdebconf that supported error was released with sarge, so
don't require a versioned cdebconf dependency. Thanks, Thijs
Kinkhorst. (Closes: #438860)
++ [RA] Various improvements from Thomas Huriaux: Diagnose select
+ templates with only yes/no options, diagnose more question prompts,
+ warn on any questions in the extended description, allow yes/no
+ mentions in non-boolean templates, and catch more first-person
+ language. (Closes: #439508)
* checks/description{.desc,}:
+ [RA] Warn (at info level for now) about Homepage pseudo-fields in
the extended description. (Closes: #444336)
@@ -35,7 +40,7 @@
*
Processed: Lintian bugs fixed in revision r972
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r972 by rra tag 444661 + pending Bug#444661: lintian: promote the use of the Vcs-* fields There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r967
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r967 by rra tag 444355 + pending Bug#444355: lintian: Bogus diagnostics for hard-linked files There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r963
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r963 by rra tag 442711 + pending Bug#442711: lintian: tries to enforce devref 6.5.4.2 on debconf select templates There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r965
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r965 by rra tag 442709 + pending Bug#442709: lintian: complains about desktop-entry-invalid-category Applet although OnlyShowIn is set There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r966
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r966 by rra tag 443827 + pending Bug#443827: lintian: desktop-entry-invalid-category complains about X-* categories There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r970
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r970 by rra tag 444651 + pending Bug#444651: desktop-entry-contains-unknown-key: Actions There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r962
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r962 by rra tag 440830 + pending Bug#440830: lintian: should ignore comments in debian/control There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r957
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r957 by rra tag 438203 + pending Bug#438203: lintian: detect useless MacOS Desktop Services Store files (.DS_Store) There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r956
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r956 by rra tag 438202 + pending Bug#438202: lintian: detect useless windows thumbnail databases (thumbs.db) There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r961
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r961 by rra tag 439508 + pending Bug#439508: lintian: Various updates for the debconf writing style checks Tags were: patch Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r968
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r968 by rra tag 444642 + pending Bug#444642: lintian: python-all is a valid build-dep for arch:all packages There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r960
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r960 by rra tag 440825 + pending Bug#440825: lintian: fails to recognize csh fulfilled csh dependencies There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r958
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r958 by rra tag 438602 + pending Bug#438602: lintian: symlink to image files in /usr/share/info trigger false positives for info-document-has-wrong-extension and info-document-not-compressed There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r959
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r959 by rra tag 438860 + pending Bug#438860: debconf-error-requires-versioned-depends too strict There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#446768: lintian: Bug in pred_implies in lib/Dep.pm
Package: lintian
Version: 1.23.34
Severity: normal
I worked on creating a Dpkg::Deps module for dpkg and used lib/Dep.pm as
inspiration for some parts. I think I discovered some errors in that
code while writing Dpkg::Deps.
If you want to compare with my (object-oriented version of the) code,
you'll find it here for the moment:
http://lists.debian.org/debian-dpkg/2007/10/msg00136.html
(the relevant part is in the version_implies function)
The problem are in pred_implies(). It returns 0 in some cases where it
should return undef.
if ($$q[2] eq '=') {
if ($$p[2] eq '') {
return Dep::versions_gte($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '=') {
return Dep::versions_gt($$p[3], $$q[3]) ? 0 : undef;
} else {
return Dep::versions_lte($$p[3], $$q[3]);
}
}
Here in the case p=['pkg', '', '1.6'] and q=['pkg', '=','1.5'] you return 0
while you should return undef. The fix is to have this in the else clause:
return Dep::versions_lte($$p[3], $$q[3]) ? 1 : undef;
However it also means that you would return undef if in the same case
$$p[2]='='
while you should return 0 because the implication is obviously impossible.
For this you need to add another elsif testing specifically this case. So the
end
result is:
if ($$q[2] eq '=') {
if ($$p[2] eq '') {
return Dep::versions_gte($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '=') {
return Dep::versions_gt($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '=') {
return Dep::versions_lte($$p[3], $$q[3]) ? 1 : 0;
} else {
return Dep::versions_lte($$p[3], $$q[3]) ? 1 : undef;
}
}
You must make similar changes in the 3 other cases (all except the = one).
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1,
'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.22-2-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages lintian depends on:
ii binutils 2.18-1The GNU assembler, linker and bina
ii diffstat 1.45-2produces graph of changes introduc
ii dpkg-dev 1.14.8package building tools for Debian
ii file 4.21-3Determines file type using magic
ii gettext0.16.1-2 GNU Internationalization utilities
ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii libparse-debianchangel 1.1.1-1 parse Debian changelogs and output
ii man-db 2.5.0-3 on-line manual pager
ii perl [libdigest-md5-pe 5.8.8-11 Larry Wall's Practical Extraction
lintian recommends no packages.
-- no debconf information
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#446796: lintian: bogus `menu-command-not-in-package' warning
Package: lintian Version: 1.23.35 Severity: normal Hi, After upgrading to 1.23.35, lintian started to complain on all my packages that include menu files, e.g.: [141]/tmp lintian dwww_1.10.6_i386.deb W: dwww: menu-command-not-in-package /usr/share/menu/dwww:4 /usr/bin/dwww W: dwww: menu-command-not-in-package /usr/share/menu/dwww:9 /usr/bin/dwww [142]/tmp dpkg-deb --fsys-tarfile dwww_1.10.6_i386.deb | tar tvf - | grep usr/bin/dwww rwxr-xr-x root/root 1006 2006-05-09 21:05 ./usr/bin/dwww [143]/tmp lintian isag_8.0.1-1_all.deb W: isag: menu-command-not-in-package /usr/share/menu/isag:5 /usr/bin/isag [144]/tmp dpkg-deb --fsys-tarfile isag_8.0.1-1_all.deb | tar tvf - | grep usr/bin/isag -rwxr-xr-x root/root 44873 2007-10-09 00:02 ./usr/bin/isag Best Regards, robert -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (990, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.22 Locale: LANG=pl_PL, LC_CTYPE=pl_PL (charmap=ISO-8859-2) Shell: /bin/sh linked to /bin/pdksh Versions of packages lintian depends on: ii binutils 2.18-1The GNU assembler, linker and bina ii diffstat 1.45-2produces graph of changes introduc ii dpkg-dev 1.14.7package building tools for Debian ii file 4.21-3Determines file type using magic ii gettext0.16.1-2 GNU Internationalization utilities ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf ii libparse-debianchangel 1.1.1-1 parse Debian changelogs and output ii man-db 2.5.0-3 on-line manual pager ii perl [libdigest-md5-pe 5.8.8-11 Larry Wall's Practical Extraction lintian recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r979 - in trunk: checks debian testset testset/binary/debian
Author: rra
Date: 2007-10-15 23:38:51 +0200 (Mon, 15 Oct 2007)
New Revision: 979
Modified:
trunk/checks/menu-format
trunk/debian/changelog
trunk/testset/binary/debian/menu
trunk/testset/tags.binary
Log:
* checks/menu-format:
+ [RA] Fix detection of commands for menu entries when the command is
given with its full path. (Closes: #446796)
Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-15 05:42:10 UTC (rev 978)
+++ trunk/checks/menu-format2007-10-15 21:38:51 UTC (rev 979)
@@ -362,7 +362,7 @@
);
# Path in which to search for binaries referenced in menu entries.
-my @path = qw(usr/local/bin/ usr/bin/ bin/ usr/X11R6/bin/ usr/games/);
+my @path = qw(/usr/local/bin/ /usr/bin/ /bin/ /usr/X11R6/bin/ /usr/games/);
my %known_tags_hash = map { $_ = 1 } @known_tags;
my %needs_tag_vals_hash = map { $_ = 1 } @needs_tag_vals;
@@ -395,7 +395,7 @@
while (IN) {
chomp;
my ($perm, $owner, $size, $date, $time, $file) = split(' ', $_, 6);
-$file =~ s,^\./,,;
+$file =~ s,^\./,/,;
$file =~ s/ link to .*//;
$file =~ s/ - .*//;
my $operm = perm2oct($perm);
@@ -867,7 +867,7 @@
} else {
$cmd = $com[0];
}
-my $okay = $cmd ($file_index{.$cmd} || grep { $file_index{$_ . $cmd}
} @path);
+my $okay = $cmd ($file_index{$cmd} || grep { $file_index{$_ . $cmd} }
@path);
return ($okay, $cmd);
}
Modified: trunk/debian/changelog
===
--- trunk/debian/changelog 2007-10-15 05:42:10 UTC (rev 978)
+++ trunk/debian/changelog 2007-10-15 21:38:51 UTC (rev 979)
@@ -1,3 +1,11 @@
+lintian (1.23.36) UNRELEASED; urgency=low
+
+ * checks/menu-format:
++ [RA] Fix detection of commands for menu entries when the command is
+ given with its full path. (Closes: #446796)
+
+ -- Russ Allbery [EMAIL PROTECTED] Mon, 15 Oct 2007 14:38:45 -0700
+
lintian (1.23.35) unstable; urgency=low
The frantic bug catchup release.
Modified: trunk/testset/binary/debian/menu
===
--- trunk/testset/binary/debian/menu2007-10-15 05:42:10 UTC (rev 978)
+++ trunk/testset/binary/debian/menu2007-10-15 21:38:51 UTC (rev 979)
@@ -18,3 +18,4 @@
title=I'm not root! command=su-to-root -c imnothere
?package(binary):needs=text section=Applications/System/Administration\
title=Run cfdisk (0) command=cfdisk
+?package(binary):needs=text section=Applications/System/Administration
title=Hello World command=/usr/bin/hello
Modified: trunk/testset/tags.binary
===
--- trunk/testset/tags.binary 2007-10-15 05:42:10 UTC (rev 978)
+++ trunk/testset/tags.binary 2007-10-15 21:38:51 UTC (rev 979)
@@ -3,7 +3,7 @@
E: binary: debian-changelog-file-missing-or-wrong-name
E: binary: debian-news-file-uses-obsolete-national-encoding at line 3
E: binary: depends-on-x-metapackage depends: xorg
-E: binary: desktop-entry-missing-required-key
usr/share/applications/goodbye.desktop Name
+E: binary: desktop-entry-missing-required-key
/usr/share/applications/goodbye.desktop Name
E: binary: doc-base-document-field-ends-in-whitespace binary:1
E: binary: doc-base-file-no-format binary:22
E: binary: doc-base-file-no-index binary:31
@@ -13,7 +13,7 @@
E: binary: doc-base-file-references-missing-file binary:27
/usr/share/doc/binary/hml/*.html
E: binary: doc-base-file-references-missing-file binary:30
/usr/share/info/binary.info.gz
E: binary: doc-base-index-references-multiple-files binary:21
-E: binary: executable-desktop-file usr/share/applications/goodbye.desktop 0755
+E: binary: executable-desktop-file /usr/share/applications/goodbye.desktop 0755
E: binary: file-directly-in-usr-share usr/share/baz
E: binary: lengthy-symlink usr/share/doc/binary/html/ch2.html
../html/./ch1.html
E: binary: menu-item-missing-required-tag needs /usr/lib/menu/binary:6
@@ -39,8 +39,8 @@
I: binary: arch-dep-package-has-big-usr-share
I: binary: binary-has-unneeded-section ./usr/bin/hello-static .comment
I: binary: description-contains-homepage
-I: binary: desktop-entry-contains-encoding-key
usr/share/applications/goodbye.desktop:11 Encoding
-I: binary: desktop-entry-contains-encoding-key
usr/share/applications/hello.desktop:13 Encoding
+I: binary: desktop-entry-contains-encoding-key
/usr/share/applications/goodbye.desktop:11 Encoding
+I: binary: desktop-entry-contains-encoding-key
/usr/share/applications/hello.desktop:13 Encoding
I: binary: no-md5sums-control-file
W: binary source: ancient-standards-version 3.2.1 (current is 3.7.2)
W: binary source: debian-rules-uses-pwd line 9
@@ -57,11 +57,11 @@
W: binary: binary-without-manpage usr/bin/static-hello
W: binary: changelog-file-not-compressed changelog
W: binary: debian-news-entry-has-strange-distribution UNRELEASED
-W: binary:
Bug#446768: lintian: Bug in pred_implies in lib/Dep.pm
Raphael Hertzog [EMAIL PROTECTED] writes:
Package: lintian
Version: 1.23.34
Severity: normal
I worked on creating a Dpkg::Deps module for dpkg and used lib/Dep.pm as
inspiration for some parts. I think I discovered some errors in that
code while writing Dpkg::Deps.
Hm, ideally it would be cool if lintian could use that down the road. I
know I hurt my head when trying to expand that code to support OR and full
version implication, and the fewer times that people have to write it, the
better.
The problem are in pred_implies(). It returns 0 in some cases where it
should return undef.
if ($$q[2] eq '=') {
if ($$p[2] eq '') {
return Dep::versions_gte($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '=') {
return Dep::versions_gt($$p[3], $$q[3]) ? 0 : undef;
} else {
return Dep::versions_lte($$p[3], $$q[3]);
}
}
Here in the case p=['pkg', '', '1.6'] and q=['pkg', '=','1.5'] you
return 0 while you should return undef. The fix is to have this in the
else clause:
return Dep::versions_lte($$p[3], $$q[3]) ? 1 : undef;
However it also means that you would return undef if in the same case
$$p[2]='=' while you should return 0 because the implication is
obviously impossible. For this you need to add another elsif testing
specifically this case.
Indeed. Thanks! This fix will be in the next release.
--
Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processing of lintian_1.23.36_i386.changes
lintian_1.23.36_i386.changes uploaded successfully to localhost along with the files: lintian_1.23.36.dsc lintian_1.23.36.tar.gz lintian_1.23.36_all.deb Greetings, Your Debian queue daemon -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian_1.23.36_i386.changes ACCEPTED
Accepted: lintian_1.23.36.dsc to pool/main/l/lintian/lintian_1.23.36.dsc lintian_1.23.36.tar.gz to pool/main/l/lintian/lintian_1.23.36.tar.gz lintian_1.23.36_all.deb to pool/main/l/lintian/lintian_1.23.36_all.deb Override entries for your package: lintian_1.23.36.dsc - source devel lintian_1.23.36_all.deb - optional devel Announcing to [EMAIL PROTECTED] Closing bugs: 446768 446796 Thank you for your contribution to Debian. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#446796: marked as done (lintian: bogus `menu-command-not-in-package' warning)
Your message dated Tue, 16 Oct 2007 04:47:02 +
with message-id [EMAIL PROTECTED]
and subject line Bug#446796: fixed in lintian 1.23.36
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
---BeginMessage---
Package: lintian
Version: 1.23.35
Severity: normal
Hi,
After upgrading to 1.23.35, lintian started to complain on all my
packages that include menu files, e.g.:
[141]/tmp lintian dwww_1.10.6_i386.deb
W: dwww: menu-command-not-in-package /usr/share/menu/dwww:4 /usr/bin/dwww
W: dwww: menu-command-not-in-package /usr/share/menu/dwww:9 /usr/bin/dwww
[142]/tmp dpkg-deb --fsys-tarfile dwww_1.10.6_i386.deb | tar tvf - | grep
usr/bin/dwww
rwxr-xr-x root/root 1006 2006-05-09 21:05 ./usr/bin/dwww
[143]/tmp lintian isag_8.0.1-1_all.deb
W: isag: menu-command-not-in-package /usr/share/menu/isag:5 /usr/bin/isag
[144]/tmp dpkg-deb --fsys-tarfile isag_8.0.1-1_all.deb | tar tvf - | grep
usr/bin/isag
-rwxr-xr-x root/root 44873 2007-10-09 00:02 ./usr/bin/isag
Best Regards,
robert
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (990, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.22
Locale: LANG=pl_PL, LC_CTYPE=pl_PL (charmap=ISO-8859-2)
Shell: /bin/sh linked to /bin/pdksh
Versions of packages lintian depends on:
ii binutils 2.18-1The GNU assembler, linker and bina
ii diffstat 1.45-2produces graph of changes introduc
ii dpkg-dev 1.14.7package building tools for Debian
ii file 4.21-3Determines file type using magic
ii gettext0.16.1-2 GNU Internationalization utilities
ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii libparse-debianchangel 1.1.1-1 parse Debian changelogs and output
ii man-db 2.5.0-3 on-line manual pager
ii perl [libdigest-md5-pe 5.8.8-11 Larry Wall's Practical Extraction
lintian recommends no packages.
-- no debconf information
---End Message---
---BeginMessage---
Source: lintian
Source-Version: 1.23.36
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:
lintian_1.23.36.dsc
to pool/main/l/lintian/lintian_1.23.36.dsc
lintian_1.23.36.tar.gz
to pool/main/l/lintian/lintian_1.23.36.tar.gz
lintian_1.23.36_all.deb
to pool/main/l/lintian/lintian_1.23.36_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Russ Allbery [EMAIL PROTECTED] (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Format: 1.7
Date: Mon, 15 Oct 2007 21:23:16 -0700
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.23.36
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers [EMAIL PROTECTED]
Changed-By: Russ Allbery [EMAIL PROTECTED]
Description:
lintian- Debian package checker
Closes: 446768 446796
Changes:
lintian (1.23.36) unstable; urgency=low
.
The grand open change and desktop cleanup release.
.
* {checks,collection,depcheck,frontend,lib,reporting,unpack}/*:
+ [RA] Use the three-argument form of open uniformly, whether needed
or not, to head off further quoting and whitespace interpretation
bugs.
.
* checks/files{.desc,}:
+ [RA] Catch .DS_Store.gz files as well.
+ [RA] Warn about ._ Mac OS X resource files in the package.
+ [RA] Add a hopefully helpful note about how cruft from other
operating systems can show up in binary packages.
* checks/menu-format:
+ [RA] Fix detection of commands for menu entries when the command is
given with its full path. (Closes: #446796)
+ [RA] Remove Actions from known desktop keys again, as I believe the
root problem was our willingness to inspect desktop types other than
Application (also fixed in the previous release).
+ [RA] Fix Perl flow error when skipping some desktop files.
+ [RA] Skip unknown and
Bug#446768: marked as done (lintian: Bug in pred_implies in lib/Dep.pm)
Your message dated Tue, 16 Oct 2007 04:47:02 +
with message-id [EMAIL PROTECTED]
and subject line Bug#446768: fixed in lintian 1.23.36
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
---BeginMessage---
Package: lintian
Version: 1.23.34
Severity: normal
I worked on creating a Dpkg::Deps module for dpkg and used lib/Dep.pm as
inspiration for some parts. I think I discovered some errors in that
code while writing Dpkg::Deps.
If you want to compare with my (object-oriented version of the) code,
you'll find it here for the moment:
http://lists.debian.org/debian-dpkg/2007/10/msg00136.html
(the relevant part is in the version_implies function)
The problem are in pred_implies(). It returns 0 in some cases where it
should return undef.
if ($$q[2] eq '=') {
if ($$p[2] eq '') {
return Dep::versions_gte($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '=') {
return Dep::versions_gt($$p[3], $$q[3]) ? 0 : undef;
} else {
return Dep::versions_lte($$p[3], $$q[3]);
}
}
Here in the case p=['pkg', '', '1.6'] and q=['pkg', '=','1.5'] you return 0
while you should return undef. The fix is to have this in the else clause:
return Dep::versions_lte($$p[3], $$q[3]) ? 1 : undef;
However it also means that you would return undef if in the same case
$$p[2]='='
while you should return 0 because the implication is obviously impossible.
For this you need to add another elsif testing specifically this case. So the
end
result is:
if ($$q[2] eq '=') {
if ($$p[2] eq '') {
return Dep::versions_gte($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '=') {
return Dep::versions_gt($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '=') {
return Dep::versions_lte($$p[3], $$q[3]) ? 1 : 0;
} else {
return Dep::versions_lte($$p[3], $$q[3]) ? 1 : undef;
}
}
You must make similar changes in the 3 other cases (all except the = one).
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1,
'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.22-2-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages lintian depends on:
ii binutils 2.18-1The GNU assembler, linker and bina
ii diffstat 1.45-2produces graph of changes introduc
ii dpkg-dev 1.14.8package building tools for Debian
ii file 4.21-3Determines file type using magic
ii gettext0.16.1-2 GNU Internationalization utilities
ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii libparse-debianchangel 1.1.1-1 parse Debian changelogs and output
ii man-db 2.5.0-3 on-line manual pager
ii perl [libdigest-md5-pe 5.8.8-11 Larry Wall's Practical Extraction
lintian recommends no packages.
-- no debconf information
---End Message---
---BeginMessage---
Source: lintian
Source-Version: 1.23.36
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:
lintian_1.23.36.dsc
to pool/main/l/lintian/lintian_1.23.36.dsc
lintian_1.23.36.tar.gz
to pool/main/l/lintian/lintian_1.23.36.tar.gz
lintian_1.23.36_all.deb
to pool/main/l/lintian/lintian_1.23.36_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Russ Allbery [EMAIL PROTECTED] (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Format: 1.7
Date: Mon, 15 Oct 2007 21:23:16 -0700
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.23.36
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers [EMAIL PROTECTED]
Changed-By: Russ Allbery [EMAIL PROTECTED]
Description:
lintian- Debian package checker
Closes: 446768 446796
Changes:
