Bug#446768: lintian: Bug in pred_implies in lib/Dep.pm

2007-10-16 Thread Raphael Hertzog
Hi,

On Mon, 15 Oct 2007, Russ Allbery wrote:
 Raphael Hertzog [EMAIL PROTECTED] writes:
 
  Package: lintian
  Version: 1.23.34
  Severity: normal
 
  I worked on creating a Dpkg::Deps module for dpkg and used lib/Dep.pm as
  inspiration for some parts. I think I discovered some errors in that
  code while writing Dpkg::Deps.
 
 Hm, ideally it would be cool if lintian could use that down the road.  I
 know I hurt my head when trying to expand that code to support OR and full
 version implication, and the fewer times that people have to write it, the
 better.

This will be possible. All Dpkg::* modules are currently installed in
/usr/share/perl5/ so they are globally available. However since we're
early in that process of modularization we don't want to make any
promise of API stability. And they sometimes lack good POD documentation.
It's up to you if you can live with a strong dpkg dependency in case of
incompatible changes.

BTW, I did my best to support all kinds of dependencies. But I'm sure a
review could be useful... :-)

Cheers,
-- 
Raphaël Hertzog

Premier livre français sur Debian GNU/Linux :
http://www.ouaza.com/livre/admin-debian/




lintian: r980 - in trunk: checks debian testset testset/filenames/debian

2007-10-16 Thread rra
Author: rra
Date: 2007-10-16 05:00:00 +0200 (Tue, 16 Oct 2007)
New Revision: 980

Modified:
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
   trunk/testset/filenames/debian/rules
   trunk/testset/tags.filenames
Log:
* checks/files{.desc,}:
  + [RA] Catch .DS_Store.gz files as well.
  + [RA] Warn about ._ Mac OS X resource files in the package.
  + [RA] Add a hopefully helpful note about how cruft from other
operating systems can show up in binary packages.

Modified: trunk/checks/files
===
--- trunk/checks/files  2007-10-15 21:38:51 UTC (rev 979)
+++ trunk/checks/files  2007-10-16 03:00:00 UTC (rev 980)
@@ -561,9 +561,12 @@
if ($file =~ m,/Thumbs\.db(\.gz)?$,i) {
tag windows-thumbnail-database-in-package, $file;
}
-   if ($file =~ m,/\.DS_Store$,) {
+   if ($file =~ m,/\.DS_Store(\.gz)?$,) {
tag macos-ds-store-file-in-package, $file;
}
+   if ($file =~ m,/\._[^_/][^/]*$, and $file !~ m/\.swp$/) {
+   tag macos-resource-fork-file-in-package, $file;
+   }
 
#  general: setuid/setgid files!
if ($perm =~ m/s/) {

Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2007-10-15 21:38:51 UTC (rev 979)
+++ trunk/checks/files.desc 2007-10-16 03:00:00 UTC (rev 980)
@@ -414,14 +414,26 @@
 Type: warning
 Info: There is a file in the package named ttThumbs.db/tt or
  ttThumbs.db.gz/tt, which is normally a Windows image thumbnail
- database.  Such databases are generally useless in Debian packages.
+ database.  Such databases are generally useless in Debian packages and
+ were usually accidentally included by copying complete directories from
+ the source tarball.
 
 Tag: macos-ds-store-file-in-package
 Type: warning
-Info: There is a file in the package named tt.DS_Store/tt, the file
- name used by Mac OS X to store folder attributes.  Such files are
- generally useless in Debian packages.
+Info: There is a file in the package named tt.DS_Store/tt or
+ tt.DS_Store.gz/tt, the file name used by Mac OS X to store folder
+ attributes.  Such files are generally useless in Debian packages and were
+ usually accidentally included by copying complete directories from the
+ source tarball.
 
+Tag: macos-resource-fork-file-in-package
+Type: warning
+Info: There is a file in the package with a name starting with
+ tt._/tt, the file name pattern used by Mac OS X to store resource
+ forks in non-native file systems.  Such files are generally useless in
+ Debian packages and were usually accidentally included by copying
+ complete directories from the source tarball.
+
 Tag: package-installs-perllocal-pod
 Type: warning
 Info: This package installs a file ttperllocal.pod/tt.  Since that

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2007-10-15 21:38:51 UTC (rev 979)
+++ trunk/debian/changelog  2007-10-16 03:00:00 UTC (rev 980)
@@ -1,10 +1,15 @@
 lintian (1.23.36) UNRELEASED; urgency=low
 
+  * checks/files{.desc,}:
++ [RA] Catch .DS_Store.gz files as well.
++ [RA] Warn about ._ Mac OS X resource files in the package.
++ [RA] Add a hopefully helpful note about how cruft from other
+  operating systems can show up in binary packages.
   * checks/menu-format:
 + [RA] Fix detection of commands for menu entries when the command is
   given with its full path.  (Closes: #446796)
 
- -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 14:38:45 -0700
+ -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 19:58:18 -0700
 
 lintian (1.23.35) unstable; urgency=low
 

Modified: trunk/testset/filenames/debian/rules
===
--- trunk/testset/filenames/debian/rules2007-10-15 21:38:51 UTC (rev 
979)
+++ trunk/testset/filenames/debian/rules2007-10-16 03:00:00 UTC (rev 
980)
@@ -82,6 +82,7 @@
 
echo foo  debian/tmp/usr/share/doc/filenames/Thumbs.db
echo foo  debian/tmp/usr/share/doc/filenames/.DS_Store
+   echo foo  debian/tmp/usr/share/doc/filenames/._NEWS.Debian
 
touch debian/tmp/usr/share/doc/filenames/news.debian
gzip debian/tmp/usr/share/doc/filenames/news.debian

Modified: trunk/testset/tags.filenames
===
--- trunk/testset/tags.filenames2007-10-15 21:38:51 UTC (rev 979)
+++ trunk/testset/tags.filenames2007-10-16 03:00:00 UTC (rev 980)
@@ -67,6 +67,7 @@
 W: filenames: file-in-usr-lib-sgml usr/lib/sgml/package
 W: filenames: file-name-ends-in-whitespace files/'\\ 
 W: filenames: macos-ds-store-file-in-package usr/share/doc/filenames/.DS_Store
+W: filenames: macos-resource-fork-file-in-package 
usr/share/doc/filenames/._NEWS.Debian
 W: filenames: 

Bug#443939: marked as done ([checks/scripts] install-sgmlcatalog-deprecated check probably wrong)

2007-10-16 Thread Debian Bug Tracking System
Your message dated Tue, 16 Oct 2007 01:01:23 -0700
with message-id [EMAIL PROTECTED]
and subject line Bug#443939: [checks/scripts] install-sgmlcatalog-deprecated 
check probably wrong
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

---BeginMessage---
Package: lintian
Version: 1.23.34
Severity: normal

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

I'm in doubt about the install-sgmlcatalog-deprecated check. It seems,
this check was added during fixing http://bugs.debian.org/90019. It
seems, we are required to put install-sgmlcatalog calls into prerm to
make lintian stop complaining. But I'm wondering, why? I did not find an
explanation in the report. What is so bad in making the transition in
postinst?

Regards, Daniel


- -- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (850, 'unstable'), (700, 'testing'), (550, 'stable'), (110, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.21.5 (PREEMPT)
Locale: LANG=de_DE, LC_CTYPE=de_DE (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash

Versions of packages lintian depends on:
ii  binutils   2.18-1The GNU assembler, linker and bina
ii  diffstat   1.45-2produces graph of changes introduc
ii  dpkg-dev   1.14.6package building tools for Debian
ii  file   4.21-3Determines file type using magic
ii  gettext0.16.1-2  GNU Internationalization utilities
ii  intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libparse-debianchangel 1.1.1-1   parse Debian changelogs and output
ii  man-db 2.4.4-4   on-line manual pager
ii  perl [libdigest-md5-pe 5.8.8-11  Larry Wall's Practical Extraction 

lintian recommends no packages.

- -- no debconf information

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFG+ISim0bx+wiPa4wRAof7AJ9bXK+UpVu5lXh6+0pGEN46DVjbqACfVg/F
OqLcfKGaXY5VNXouEvjCs58=
=GzE5
-END PGP SIGNATURE-


---End Message---
---BeginMessage---
Version: 1.23.35

This was fixed in 1.23.35, but I forgot to add a bug closer.

  * checks/scripts{.desc,}:
+ [RA] Allow install-sgmlcatalog --remove in postinst as well as
  prerm and suggest removing it entirely in the long description.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/

---End Message---


Bug#439390: lintian: error debian-rules-ignores-make-clean-error

2007-10-16 Thread Russ Allbery
tags 439390 moreinfo
thanks

Hi Dmitry,

Some time back, I sent you the following reply with respect to this bug.
Did this make sense?  Are you still having problems with this lintian tag?
Please let me know.

| Dmitry E. Oboukhov [EMAIL PROTECTED] writes:
| 
|  I don't understand why you'd ever run make distclean, ignoring errors or
|  not, if the Makefile doesn't have a distclean target.  If the Makefile
|  doesn't have a distclean target, why wouldn't you just remove that line
|  from debian/rules?
| 
|  There is no mention of distclean target/call in Makefile and
|  debian/rules. But lintian nevertheless produces a warning.
| 
| Could you show me what line of your rules file it's warning about, then?
| I don't understand the problem that you're reporting at all.
| 
|  This problem is rather political than technical.
|  Many DDs conceive lintian messages too seriously and want lintian
|  recommendations to be fulfilled before upload. For all that they do not
|  accept the variant with overrides.
| 
|  If the distclean target is absent, then fulfillment of lintian
|  recommendations leads to the necessity of making a patch on Makefile.
| 
| I'm afraid that your diagnosis of what's wrong is probably wrong.  This
| warning isn't about running make distclean, and it's not triggered by the
| lack of a distclean target in your Makefile.  It's produced by a very
| particular command in debian/rules that's bad practice and has a simple
| replacement.  It's possible that it's triggering on a line that it
| shouldn't trigger on.  I need to know more about the package and the line
| that's causing the error to understand what the problem really is.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#446097: marked as done (lintian: desktop files check over strict for kde packages)

2007-10-16 Thread Debian Bug Tracking System
Your message dated Tue, 16 Oct 2007 01:11:06 -0700
with message-id [EMAIL PROTECTED]
and subject line Bug#446097: lintian: desktop files check over strict for kde 
packages
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

---BeginMessage---
Package: lintian
Version: 1.23.34
Severity: important


Hi!

KDE has a history of using desktop files for all sorts of things, not
only for applications and such.

for example kdegraphics, a fairly minor kde package, there is now around
10 errors and 60 warnings.

If at least those checks could not be run for desktop files in some
locations mostly used for kde things:

/usr/share/services
/usr/share/servicetypes
/usr/share/applnk

currently lintian generates so much output for no reasons that makes
lintian impossible to use to check the kde packages.

I guess it is the desktop checks implementet in version .33 that is the
culprit.

/Sune


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.20-1-vserver-k7 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.18-1The GNU assembler, linker and bina
ii  diffstat   1.45-1produces graph of changes introduc
ii  dpkg-dev   1.14.6package building tools for Debian
ii  file   4.21-3Determines file type using magic
ii  gettext0.16.1-2  GNU Internationalization utilities
ii  intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libparse-debianchangel 1.1.1-1   parse Debian changelogs and output
ii  man-db 2.4.4-4   on-line manual pager
ii  perl [libdigest-md5-pe 5.8.8-7   Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information


---End Message---
---BeginMessage---
Version: 1.23.36

As of 1.23.36, I think this should now be fixed.  The main thing that
lintian was doing that it shouldn't have been was checking desktop files
of a Type that it didn't know about.  It now doesn't do that, which makes
nearly all of the KDE warnings go away.

If you still are seeing specific false positives, please open bugs about
them so that they can be cleaned up in later versions.

Thanks!

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/

---End Message---


Processed: Re: Bug#439390: lintian: error debian-rules-ignores-make-clean-error

2007-10-16 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 tags 439390 moreinfo
Bug#439390: lintian: error debian-rules-ignores-make-clean-error
There were no tags set.
Tags added: moreinfo

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#443509: menu policy checks may be ahead of their time

2007-10-16 Thread Russ Allbery
Peter Eisentraut [EMAIL PROTECTED] writes:

 Package: lintian
 Version: 1.23.34
 Severity: normal

 The menu policy checks such as menu-item-uses-apps-section tell me to
 check Debian Menu sub-policy 2.1.  But the web site and the current
 debian-policy package still contain what is presumably considered the
 old version of the menu policy, which contains an Apps section.  There
 is no information in the obvious places that tells what this new menu
 policy is supposed to be or what authority it carries.

The problem here, unfortunately, is Policy.  The new menu policy is
available in the menu package and is already being implemented, but Policy
is lagging way behind reality (and not just in this area).

Need more hands

Our documentation is therefore in wretched condition, but I believe that
lintian is still correct so far as that goes, and I don't want to hold up
the menu transition just because Policy isn't cutting it.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r984 - trunk/debian

2007-10-16 Thread rra
Author: rra
Date: 2007-10-16 06:13:26 +0200 (Tue, 16 Oct 2007)
New Revision: 984

Modified:
   trunk/debian/changelog
Log:
Finalize changes for 1.23.36.


Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2007-10-16 04:06:55 UTC (rev 983)
+++ trunk/debian/changelog  2007-10-16 04:13:26 UTC (rev 984)
@@ -1,5 +1,7 @@
-lintian (1.23.36) UNRELEASED; urgency=low
+lintian (1.23.36) unstable; urgency=low
 
+  The grand open change release.
+
   * {checks,collection,depcheck,frontend,lib,reporting,unpack}/*:
 + [RA] Use the three-argument form of open uniformly, whether needed
   or not, to head off further quoting and whitespace interpretation
@@ -22,7 +24,7 @@
   two versioned relationships in the same direction.  Thanks to
   Raphael Hertzog for the analysis and fix.  (Closes: #446768)
 
- -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 20:59:47 -0700
+ -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 21:13:15 -0700
 
 lintian (1.23.35) unstable; urgency=low
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r985 - in trunk: checks debian

2007-10-16 Thread rra
Author: rra
Date: 2007-10-16 06:17:22 +0200 (Tue, 16 Oct 2007)
New Revision: 985

Modified:
   trunk/checks/menu-format
   trunk/debian/changelog
Log:
  + [RA] Fix Perl flow error when skipping some desktop files.

Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-16 04:13:26 UTC (rev 984)
+++ trunk/checks/menu-format2007-10-16 04:17:22 UTC (rev 985)
@@ -774,7 +774,7 @@
 close DESKTOP;
 
 # Now validate the data in the desktop file, but only if it's a known type.
-next unless ($vals{'Type'} and $known_desktop_types{$vals{'Type'}});
+return unless ($vals{'Type'} and $known_desktop_types{$vals{'Type'}});
 
 # Test for important keys.
 for my $tag (@req_desktop_keys) {

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2007-10-16 04:13:26 UTC (rev 984)
+++ trunk/debian/changelog  2007-10-16 04:17:22 UTC (rev 985)
@@ -18,13 +18,14 @@
 + [RA] Remove Actions from known desktop keys again, as I believe the
   root problem was our willingness to inspect desktop types other than
   Application (also fixed in the previous release).
++ [RA] Fix Perl flow error when skipping some desktop files.
 
   * lib/Dep.pm:
 + [RA] Fix negative implication in some boundary cases when comparing
   two versioned relationships in the same direction.  Thanks to
   Raphael Hertzog for the analysis and fix.  (Closes: #446768)
 
- -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 21:13:15 -0700
+ -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 21:17:15 -0700
 
 lintian (1.23.35) unstable; urgency=low
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r982 - in trunk: checks debian

2007-10-16 Thread rra
Author: rra
Date: 2007-10-16 05:13:13 +0200 (Tue, 16 Oct 2007)
New Revision: 982

Modified:
   trunk/checks/menu-format
   trunk/debian/changelog
Log:
  + [RA] Remove Actions from known desktop keys again, as I believe the
root problem was our willingness to inspect desktop types other than
Application (also fixed in the previous release).

Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-16 03:09:35 UTC (rev 981)
+++ trunk/checks/menu-format2007-10-16 03:13:13 UTC (rev 982)
@@ -136,8 +136,7 @@
 # This is a list of all keys that should be in every desktop entry.
 my @req_desktop_keys = qw(Type Name);
 
-# This is a list of all known keys.  Note that Actions isn't part of the
-# standard but appears to be widely used, so we include it anyway.
+# This is a list of all known keys.
 my %known_desktop_keys = map { $_ = 1 }
 qw(
Type
@@ -161,7 +160,6 @@
StartupNotify
StartupWMClass
URL
-   Actions
   );
 
 my %deprecated_desktop_keys = map { $_ = 1 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2007-10-16 03:09:35 UTC (rev 981)
+++ trunk/debian/changelog  2007-10-16 03:13:13 UTC (rev 982)
@@ -8,13 +8,16 @@
   * checks/menu-format:
 + [RA] Fix detection of commands for menu entries when the command is
   given with its full path.  (Closes: #446796)
++ [RA] Remove Actions from known desktop keys again, as I believe the
+  root problem was our willingness to inspect desktop types other than
+  Application (also fixed in the previous release).
 
   * lib/Dep.pm:
 + [RA] Fix negative implication in some boundary cases when comparing
   two versioned relationships in the same direction.  Thanks to
   Raphael Hertzog for the analysis and fix.  (Closes: #446768)
 
- -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 20:09:28 -0700
+ -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 20:11:15 -0700
 
 lintian (1.23.35) unstable; urgency=low
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r986 - in trunk: checks debian

2007-10-16 Thread rra
Author: rra
Date: 2007-10-16 06:23:22 +0200 (Tue, 16 Oct 2007)
New Revision: 986

Modified:
   trunk/checks/menu-format
   trunk/debian/changelog
Log:
The grand open change and desktop cleanup release.
  + [RA] Skip unknown and deprecated key warnings and encoding key
warnings in desktop files if they were of an unknown type.

Modified: trunk/checks/menu-format
===
--- trunk/checks/menu-format2007-10-16 04:17:22 UTC (rev 985)
+++ trunk/checks/menu-format2007-10-16 04:23:22 UTC (rev 986)
@@ -734,6 +734,7 @@
 open (DESKTOP, '', unpacked/$file)
or fail(cannot open desktop file $file: $!);
 my ($line, $saw_first);
+my @pending;
 while (defined ($line = DESKTOP)) {
 chomp $line;
 next if ($line =~ m/^\s*\#/ or $line =~ m/^\s*$/);
@@ -747,35 +748,43 @@
 $saw_first = 1;
 }
 
-# Tag = Value
-# TODO: We do not check for properly formatted localised values for
-# keys but might be worth checking if they are properly formatted (not
-# their value)
-if ($line =~ /^(.*?)\s*=\s*(.*)$/) {
-my ($tag, $value) = ($1, $2);
-my $basetag = $tag;
-my ($encoding) = ($basetag =~ s/\[([^\]]+)\]$//);
-if (exists $vals{$tag}) {
-tag duplicated-key-in-desktop-entry, $file:$. $tag;
-} elsif ($deprecated_desktop_keys{$basetag}) {
-if ($basetag eq 'Encoding') {
-tag desktop-entry-contains-encoding-key, $file:$. $tag;
-} else {
-tag desktop-entry-contains-deprecated-key, $file:$. 
$tag;
-}
-} elsif (not $known_desktop_keys{$basetag}
- and not $kde_desktop_keys{$basetag}
- and not $basetag =~ /^X-/) {
-tag desktop-entry-contains-unknown-key, $file:$. $tag;
-}
-$vals{$tag} = $value;
-}
+   # Tag = Value.  For most errors, just add the error to pending rather
+   # than warning on it immediately since we want to not warn on tag
+   # errors if we didn't know the file type.
+   #
+   # TODO: We do not check for properly formatted localised values for
+   # keys but might be worth checking if they are properly formatted (not
+   # their value)
+   if ($line =~ /^(.*?)\s*=\s*(.*)$/) {
+   my ($tag, $value) = ($1, $2);
+   my $basetag = $tag;
+   my ($encoding) = ($basetag =~ s/\[([^\]]+)\]$//);
+   if (exists $vals{$tag}) {
+   tag duplicated-key-in-desktop-entry, $file:$. $tag;
+   } elsif ($deprecated_desktop_keys{$basetag}) {
+   if ($basetag eq 'Encoding') {
+   push (@pending, [ desktop-entry-contains-encoding-key, 
$file:$. $tag ]);
+   } else {
+   push (@pending, [ desktop-entry-contains-deprecated-key, 
$file:$. $tag ]);
+   }
+   } elsif (not $known_desktop_keys{$basetag}
+and not $kde_desktop_keys{$basetag}
+and not $basetag =~ /^X-/) {
+   push (@pending, [ desktop-entry-contains-unknown-key, 
$file:$. $tag ]);
+   }
+   $vals{$tag} = $value;
+   }
 }
 close DESKTOP;
 
 # Now validate the data in the desktop file, but only if it's a known type.
 return unless ($vals{'Type'} and $known_desktop_types{$vals{'Type'}});
 
+# Now we can issue any pending tags.
+for my $pending (@pending) {
+   tag @$pending;
+}
+
 # Test for important keys.
 for my $tag (@req_desktop_keys) {
 unless (defined $vals{$tag}) {

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2007-10-16 04:17:22 UTC (rev 985)
+++ trunk/debian/changelog  2007-10-16 04:23:22 UTC (rev 986)
@@ -1,6 +1,6 @@
 lintian (1.23.36) unstable; urgency=low
 
-  The grand open change release.
+  The grand open change and desktop cleanup release.
 
   * {checks,collection,depcheck,frontend,lib,reporting,unpack}/*:
 + [RA] Use the three-argument form of open uniformly, whether needed
@@ -19,13 +19,15 @@
   root problem was our willingness to inspect desktop types other than
   Application (also fixed in the previous release).
 + [RA] Fix Perl flow error when skipping some desktop files.
++ [RA] Skip unknown and deprecated key warnings and encoding key
+  warnings in desktop files if they were of an unknown type.
 
   * lib/Dep.pm:
 + [RA] Fix negative implication in some boundary cases when comparing
   two versioned relationships in the same direction.  Thanks to
   Raphael Hertzog for the analysis and fix.  (Closes: #446768)
 
- -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 21:17:15 -0700
+ -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 

lintian: r981 - in trunk: debian lib

2007-10-16 Thread rra
Author: rra
Date: 2007-10-16 05:09:35 +0200 (Tue, 16 Oct 2007)
New Revision: 981

Modified:
   trunk/debian/changelog
   trunk/lib/Dep.pm
Log:
* lib/Dep.pm:
  + [RA] Fix negative implication in some boundary cases when comparing
two versioned relationships in the same direction.  Thanks to
Raphael Hertzog for the analysis and fix.  (Closes: #446768)

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2007-10-16 03:00:00 UTC (rev 980)
+++ trunk/debian/changelog  2007-10-16 03:09:35 UTC (rev 981)
@@ -9,8 +9,13 @@
 + [RA] Fix detection of commands for menu entries when the command is
   given with its full path.  (Closes: #446796)
 
- -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 19:58:18 -0700
+  * lib/Dep.pm:
++ [RA] Fix negative implication in some boundary cases when comparing
+  two versioned relationships in the same direction.  Thanks to
+  Raphael Hertzog for the analysis and fix.  (Closes: #446768)
 
+ -- Russ Allbery [EMAIL PROTECTED]  Mon, 15 Oct 2007 20:09:28 -0700
+
 lintian (1.23.35) unstable; urgency=low
 
   The frantic bug catchup release.

Modified: trunk/lib/Dep.pm
===
--- trunk/lib/Dep.pm2007-10-16 03:00:00 UTC (rev 980)
+++ trunk/lib/Dep.pm2007-10-16 03:09:35 UTC (rev 981)
@@ -348,8 +348,10 @@
return Dep::versions_gte($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '=') {
return Dep::versions_gt($$p[3], $$q[3]) ? 0 : undef;
+   } elsif ($$p[2] eq '=') {
+   return Dep::versions_lte($$p[3], $$q[3]);
} else {
-   return Dep::versions_lte($$p[3], $$q[3]);
+   return Dep::versions_lte($$p[3], $$q[3]) ? 1 : undef;
}
 }
 
@@ -360,8 +362,10 @@
return Dep::versions_gte($$p[3], $$p[3]) ? 0 : undef;
} elsif ($$p[2] eq '') {
return Dep::versions_lte($$p[3], $$q[3]);
+   } elsif ($$p[2] eq '=') {
+   return Dep::versions_lt($$p[3], $$q[3]);
} else {
-   return Dep::versions_lt($$p[3], $$q[3]);
+   return Dep::versions_lt($$p[3], $$q[3]) ? 1 : undef;
}
 }
 
@@ -371,8 +375,10 @@
return Dep::versions_lte($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '=') {
return Dep::versions_lt($$p[3], $$q[3]) ? 0 : undef;
+   } elsif ($$p[2] eq '=') {
+   return Dep::versions_gte($$p[3], $$q[3]);
} else {
-   return Dep::versions_gte($$p[3], $$q[3]);
+   return Dep::versions_gte($$p[3], $$q[3]) ? 1 : undef;
}
 }
 if ($$q[2] eq '') {
@@ -380,8 +386,10 @@
return Dep::versions_lte($$p[3], $$q[3]) ? 0 : undef;
} elsif ($$p[2] eq '') {
return Dep::versions_gte($$p[3], $$q[3]);
+   } elsif ($$p[2] eq '=') {
+   return Dep::versions_gt($$p[3], $$q[3]);
} else {
-   return Dep::versions_gt($$p[3], $$q[3]);
+   return Dep::versions_gt($$p[3], $$q[3]) ? 1 : undef;
}
 }
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r987 - releases

2007-10-16 Thread rra
Author: rra
Date: 2007-10-16 06:35:16 +0200 (Tue, 16 Oct 2007)
New Revision: 987

Added:
   releases/1.23.36/
Log:
Tag 1.23.36 release.


Copied: releases/1.23.36 (from rev 986, trunk)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#445542: marked as done (Fails on doc-base files ending with spaces)

2007-10-16 Thread Debian Bug Tracking System
Your message dated Tue, 16 Oct 2007 01:03:41 -0700
with message-id [EMAIL PROTECTED]
and subject line Bug#445542: Fails on doc-base files ending with spaces
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

---BeginMessage---
Package: lintian
Version: 1.23.34
Severity: normal

[EMAIL PROTECTED]:~/src/phox-0.85.050301$ lintian ../phox_0.85.050301-1_i386.deb
W: phox: binary-without-manpage usr/bin/phox
W: phox: binary-without-manpage usr/bin/phoxdep
W: phox: binary-without-manpage usr/bin/pretty
W: phox: zero-byte-file-in-doc-directory usr/share/doc/phox/text/cardinal.pht
W: phox: zero-byte-file-in-doc-directory usr/share/doc/phox/text/rel_ax.pht
internal error: cannot open doc-base file phox  for reading.
internal error: cannot run menus check on package phox
N: Skipping check of binary package phox
[EMAIL PROTECTED]:~/src/phox-0.85.050301$ ls debian
changelog  copyright  files  phox.doc-base.lib
phox.prerm.debhelper  postrm   rules
compat dirs   phox   phox.examples
phox.substvarspreinst
controldocs   phox.doc-base  phox.postinst.debhelper  postinst
prerm


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.21-6unicorn200709091248
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.18-1The GNU assembler, linker and bina
ii  diffstat   1.45-1produces graph of changes introduc
ii  dpkg-dev   1.14.6package building tools for Debian
ii  file   4.21-3Determines file type using magic
ii  gettext0.16.1-2  GNU Internationalization utilities
ii  intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libparse-debianchangel 1.1.1-1   parse Debian changelogs and output
ii  man-db 2.4.4-4   on-line manual pager
ii  perl [libdigest-md5-pe 5.8.8-7   Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information


---End Message---
---BeginMessage---
Version: 1.23.35

This was fixed in 1.23.35, but I closed the wrong bug.  Fixing that now.

  * checks/menus:
+ [RA] Use the three-argument form of open to not fail on doc-base
  files ending in whitespace.  Error on doc-base files with Document
  fields that end in whitespace, since currently they break multiple
  tools.  Thanks, Ian Zimmerman.  (Closes: #444889)

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/

---End Message---


Melanie

2007-10-16 Thread Johnnie

Our company buy unpaid Court ordered Judgements. We force t hat fairness
takes place.


Kindley Telephone our company here  3 0 3---4 8 0---5 7 1 2

all,
The younger one lay upon the ground sobbing and still violently agitated by
recollections of the frightful experiences he had undergone



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]