Bug#286842: lintian: Avoid false positives
Package: lintian Followup-For: Bug #286842 Is this working correctly? Take this from the csound package I'm preparing (not in the archive yet): Copyright notices: Csound is copyright (c) 1986-1992 by the Massachussetts Institute of Technology 1991-2008 by Barry Vercoe, John ffitch and others. CsoundAC (formerly CsoundVST) is copyright (c) 2001-2008 by Michael Gogins. The csound Manual is copyright (c): 2003 by Kevin Conder 2004-2005 by Michael Gogins This is causing lintian to warn about copyright-without-copyright-notice -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.24-1-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils2.18.1~cvs20080103-1 The GNU assembler, linker and bina ii diffstat1.45-2 produces graph of changes introduc ii dpkg-dev1.14.16.6package building tools for Debian ii file4.23-2 Determines file type using magic ii gettext 0.17-2 GNU Internationalization utilities ii intltool-debian 0.35.0+20060710.1Help i18n of RFC822 compliant conf ii libparse-debianchan 1.1.1-2 parse Debian changelogs and output ii liburi-perl 1.35.dfsg.1-1Manipulates and accesses URI strin ii man-db 2.5.1-2 on-line manual pager ii perl [libdigest-md5 5.8.8-12 Larry Wall's Practical Extraction lintian recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#286842: lintian: Avoid false positives
Felipe Sateler [EMAIL PROTECTED] writes: Package: lintian Followup-For: Bug #286842 Is this working correctly? Take this from the csound package I'm preparing (not in the archive yet): Copyright notices: Csound is copyright (c) 1986-1992 by the Massachussetts Institute of Technology 1991-2008 by Barry Vercoe, John ffitch and others. CsoundAC (formerly CsoundVST) is copyright (c) 2001-2008 by Michael Gogins. The csound Manual is copyright (c): 2003 by Kevin Conder 2004-2005 by Michael Gogins This is causing lintian to warn about copyright-without-copyright-notice It doesn't like the interposed (and meaningless) (c) in the case where the copyright is split across multiple lines. I'll try to make it better about recognizing this, but the second example in particular gets more and more annoying to detect as more punctuation and newlines are added. It's much easier if the debian/copyright file just has the official legal copyright notices on lines by themselves. The more work that goes into moving things around, adding punctuation and newlines, and whatnot, the harder it is to detect. In other words, better would be: Copyright 2003 by Kevin Conder Copyright 2004-2005 by Michael Gogins However, in general you want to copy the upstream notices verbatim, and I know that these two desires are in tension and upstreams use notices like you have above. The cases above should be possible to adapt for. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#286842: lintian: Avoid false positives
On Wednesday 13 February 2008 20:00:44 you wrote: Felipe Sateler [EMAIL PROTECTED] writes: Package: lintian Followup-For: Bug #286842 Is this working correctly? Take this from the csound package I'm preparing (not in the archive yet): Copyright notices: Csound is copyright (c) 1986-1992 by the Massachussetts Institute of Technology 1991-2008 by Barry Vercoe, John ffitch and others. CsoundAC (formerly CsoundVST) is copyright (c) 2001-2008 by Michael Gogins. The csound Manual is copyright (c): 2003 by Kevin Conder 2004-2005 by Michael Gogins This is causing lintian to warn about copyright-without-copyright-notice It doesn't like the interposed (and meaningless) (c) in the case where the copyright is split across multiple lines. I'll try to make it better about recognizing this, but the second example in particular gets more and more annoying to detect as more punctuation and newlines are added. It's much easier if the debian/copyright file just has the official legal copyright notices on lines by themselves. The more work that goes into moving things around, adding punctuation and newlines, and whatnot, the harder it is to detect. In other words, better would be: Copyright 2003 by Kevin Conder Copyright 2004-2005 by Michael Gogins However, in general you want to copy the upstream notices verbatim, and I know that these two desires are in tension and upstreams use notices like you have above. The cases above should be possible to adapt for. What bothers me is that although I have a line blah is copyright by joe, lintian is still complaining. After all, the different modules have different copyrights. I see that the regex is not case insensitive and thus checks for Copyright but not copyright, which would have avoided the warnings in my case. Had I written CsoundAC (formerly CsoundVST) is Copyright (c) 2001-2008 by Michael Gogins., the warning would have not appeared. For the other cases, can't perl be made to read more than one line per pattern? -- Felipe Sateler signature.asc Description: This is a digitally signed message part.
Bug#286842: lintian: Avoid false positives
Felipe Sateler [EMAIL PROTECTED] writes: What bothers me is that although I have a line blah is copyright by joe, lintian is still complaining. After all, the different modules have different copyrights. I see that the regex is not case insensitive and thus checks for Copyright but not copyright, which would have avoided the warnings in my case. Ah, yes, I missed that you also had that line. Yes, the fix for the other bug already reported will take care of that. For the other cases, can't perl be made to read more than one line per pattern? It can, but that also leads to false negatives. I think it's better the way that it is, once the case insensitivity is fixed and it's a bit more accepting about (c) bits when there's an intervening newline. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
