Bug#466979: lintian: Learn new fields Checksums-* in .dsc and .changes

2008-02-22 Thread Raphael Hertzog
Package: lintian
Version: 1.23.45
Severity: normal

The upcoming dpkg will add new fields in the .dsc and in the .changes
files: you should accept/recognize by default the fields
Checksums-Sha1, Checksums-Sha256 and Checksums-Md5 (though the latter is
auto-removed for now as it would be a duplicate of the Files: field)

On my machine I get:
I: dpkg source: unknown-field-in-dsc checksums-sha1
I: dpkg source: unknown-field-in-dsc checksums-sha256

Cheers,
-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages lintian depends on:
ii  binutils2.18.1~cvs20080103-1 The GNU assembler, linker and bina
ii  diffstat1.45-2   produces graph of changes introduc
ii  dpkg-dev1.14.17  package building tools for Debian
ii  file4.23-2   Determines file type using magic
ii  gettext 0.17-2   GNU Internationalization utilities
ii  intltool-debian 0.35.0+20060710.1Help i18n of RFC822 compliant conf
ii  libparse-debianchan 1.1.1-2  parse Debian changelogs and output
ii  liburi-perl 1.35.dfsg.1-1Manipulates and accesses URI strin
ii  man-db  2.5.1-2  on-line manual pager
ii  perl [libdigest-md5 5.8.8-12 Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#467019: off-by-one error in debian-changelog-line-too-long (80 column check)

2008-02-22 Thread Robert Millan
Package: lintian
Version: 1.23.45
Severity: normal

The following check:

W: nsis: debian-changelog-line-too-long line 3
N:
N:   The given line of the latest changelog entry is over 80 columns. Such
N:   changelog entries may look poor in terminal windows and mail messages
N:   and be annoying to read. Please wrap changelog entries at 80 columns
N:   or less where possible.

is triggered when lines are exactly 80 char, not necessarily over 80 columns
as it says.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.18-6-amd64 (SMP w/2 CPU cores)
Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages lintian depends on:
ii  binutils2.18.1~cvs20080103-1 The GNU assembler, linker and bina
ii  diffstat1.45-2   produces graph of changes introduc
ii  dpkg-dev1.14.16.6package building tools for Debian
ii  file4.23-2   Determines file type using magic
ii  gettext 0.17-2   GNU Internationalization utilities
ii  intltool-debian 0.35.0+20060710.1Help i18n of RFC822 compliant conf
ii  libparse-debianchan 1.1.1-2  parse Debian changelogs and output
ii  liburi-perl 1.35.dfsg.1-1Manipulates and accesses URI strin
ii  man-db  2.5.1-2  on-line manual pager
ii  perl [libdigest-md5 5.8.8-12 Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



lintian: r1227 - in trunk: checks debian testset/debconf/debian

2008-02-22 Thread rra
Author: rra
Date: 2008-02-22 18:15:33 +0100 (Fri, 22 Feb 2008)
New Revision: 1227

Modified:
   trunk/checks/changelog-file
   trunk/debian/changelog
   trunk/testset/debconf/debian/changelog
Log:
* checks/changelog-file:
  + [RA] Adjust for the extra space added by Parse::DebianChangelog when
checking line length.  Thanks, Robert Millan.  (Closes: #467019)

Modified: trunk/checks/changelog-file
===
--- trunk/checks/changelog-file 2008-02-21 02:47:58 UTC (rev 1226)
+++ trunk/checks/changelog-file 2008-02-22 17:15:33 UTC (rev 1227)
@@ -333,9 +333,12 @@
 # check.  For some reason, use open ':utf8' isn't sufficient.  If the
 # changelog uses a non-UTF-8 encoding, this will mangle it, but it doesn't
 # matter for the length check.
-my @lines = split ('\n', decode ('utf-8', $changes));
+#
+# Parse::DebianChangelog adds an additional space to the beginning of each
+# line, so we have to adjust for that in the length check.
+my @lines = split (\n, decode ('utf-8', $changes));
 for my $i (0 .. $#lines) {
-if (length ($lines[$i])  80  $lines[$i] !~ /^[\s.o*+-]*\S+$/) {
+if (length ($lines[$i])  81  $lines[$i] !~ /^[\s.o*+-]*\S+$/) {
 tag 'debian-changelog-line-too-long', line  . ($i + 1);
 }
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-02-21 02:47:58 UTC (rev 1226)
+++ trunk/debian/changelog  2008-02-22 17:15:33 UTC (rev 1227)
@@ -4,6 +4,9 @@
 + [RA] Anchor file matches for Perl libraries and debugging symbols so
   as to not match partial paths.  Based on a patch from Niko Tyni.
   (Closes: #466501)
+  * checks/changelog-file:
++ [RA] Adjust for the extra space added by Parse::DebianChangelog when
+  checking line length.  Thanks, Robert Millan.  (Closes: #467019)
   * checks/control-files{.desc,}:
 + [FL] Warn about empty control files. I can't see any use for
   them. Exclude udebs though, since they might differ there.

Modified: trunk/testset/debconf/debian/changelog
===
--- trunk/testset/debconf/debian/changelog  2008-02-21 02:47:58 UTC (rev 
1226)
+++ trunk/testset/debconf/debian/changelog  2008-02-22 17:15:33 UTC (rev 
1227)
@@ -1,5 +1,6 @@
 debconf (1~rc1) unstable; urgency=low
 
   * Initial Release
+  * Changelog line with exactly 80 characters which tests the line-too-long 
tag.
 
  -- Lintian Maintainers [EMAIL PROTECTED]  Sat, 13 Nov 2004 22:45:05 +0100


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Lintian bugs fixed in revision r1227

2008-02-22 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r1227 by rra
 tag 467019 + pending
Bug#467019: off-by-one error in debian-changelog-line-too-long (80 column check)
There were no tags set.
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#467019: off-by-one error in debian-changelog-line-too-long (80 column check)

2008-02-22 Thread Russ Allbery
Robert Millan [EMAIL PROTECTED] writes:

 Package: lintian
 Version: 1.23.45
 Severity: normal

 The following check:

 W: nsis: debian-changelog-line-too-long line 3
 N:
 N:   The given line of the latest changelog entry is over 80 columns. Such
 N:   changelog entries may look poor in terminal windows and mail messages
 N:   and be annoying to read. Please wrap changelog entries at 80 columns
 N:   or less where possible.

 is triggered when lines are exactly 80 char, not necessarily over 80 columns
 as it says.

Parse::DebianChangelog was adding an additional space to the beginning of
each line (to convert the format into what one would expect in a .changes
file presumably).  The test needed to be adjusted for that.

Thanks!

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Processed: Lintian bugs fixed in revision r1228

2008-02-22 Thread Debian Bug Tracking System
Processing commands for [EMAIL PROTECTED]:

 package lintian
Ignoring bugs not assigned to: lintian

 # Fixed in r1228 by rra
 tag 466979 + pending
Bug#466979: lintian: Learn new fields Checksums-* in .dsc and .changes
There were no tags set.
Tags added: pending

 thanks
Stopping processing here.

Please contact me if you need assistance.

Debian bug tracking system administrator
(administrator, Debian Bugs database)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]