Bug#681061: lintian: False positive: unneeded-build-dep-on-quilt

2012-07-10 Thread Frank Kuester
Package: lintian
Version: 2.5.10
Severity: normal

In source package texlive-bin, the error tag unneeded-build-dep-on-quilt is
found by quilt. 

However, we do use quilt in debian/rules:

$ grep -i quilt debian/rules 
# this is for dh_quilt_patch (--with quilt) which reads this
# variable and sets QUILT_PATCHES accordingly
export QUILT_PATCH_DIR=debian/quilt
export QUILT_PATCHES=debian/quilt
dh $@ --with quilt --with autoreconf --builddirectory Work
dh_quilt_unpatch

Regards, Frank


-- System Information:
Debian Release: 6.0.5
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-5-686 (SMP w/1 CPU core)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.20.1-16 The GNU assembler, linker and bina
ii  diffstat   1.53-1produces graph of changes introduc
ii  dpkg-dev   1.15.8.12 Debian package development tools
ii  file   5.04-5+squeeze2   Determines file type using magic
ii  gettext0.18.1.1-3GNU Internationalization utilities
ii  intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-perl0.1.24+b1 Perl interface to libapt-pkg
ii  libclass-accessor-perl 0.34-1Perl module that automatically gen
ii  libipc-run-perl0.89-1Perl module for running processes
ii  libparse-debianchangel 1.1.1-2.1 parse Debian changelogs and output
ii  libtimedate-perl   1.2000-1  collection of modules to manipulat
ii  liburi-perl1.54-2module to manipulate and access UR
ii  locales2.11.3-3  Embedded GNU C Library: National L
ii  man-db 2.5.7-8   on-line manual pager
ii  perl [libdigest-sha-pe 5.10.1-17squeeze3 Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarchnone (no description available)
pn  libtext-template-perl none (no description available)
ii  man-db2.5.7-8on-line manual pager

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/87sjczg9qm@riesling.miltenberg.kuesterei.ch



Processed: limit source to lintian, tagging 680391

2012-07-10 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

 #lintian (2.5.11) UNRELEASED; urgency=low
 #
 #  * checks/deb-format{,.desc}:
 #+ [NT] Retire data.tar.xz tag.  (Closes: #680391)
 #
 limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'

 tags 680391 + pending
Bug #680391 [src:lintian] lintian: precise now released, remove 
data.tar.xz-member-without-dpkg-pre-depends
Added tag(s) pending.
 thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
680391: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680391
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/handler.s.c.134192025431592.transcr...@bugs.debian.org



Bug#680391: lintian: precise now released, remove data.tar.xz-member-without-dpkg-pre-depends

2012-07-10 Thread Niels Thykier
On 2012-07-05 17:16, shawn wrote:
 Source: lintian
 Version: unstable
 Severity: minor
 
 The data.tar.xz-member-without-dpkg-pre-depends
 
 pedantic warning can now be dropped, as precise has been released 
 (lucid--precise)
 and the two old update-from targets (squeeze and precise) both have xz 
 support.
 
 [...]
 
 

Thanks, fixed in git.

Do you know the status of
preinst-uses-dpkg-maintscript-helper-without-predepends as well?  Is
that still needed?

~Niels




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ffc1438.3050...@thykier.net



[SCM] Debian package checker branch, master, updated. 2.5.10-2-g3eb5fc7

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 3eb5fc7bd03a58e307525e19f054aaeab49d2417
Author: gregor herrmann gre...@debian.org
Date:   Thu Jul 5 15:10:50 2012 -0600

c/fields: Add info about how to fix perl-dependency problems

Point to cme as a means of fixing versioned-dependency-satisfied-by-perl
and package-superseded-by-perl.

diff --git a/checks/fields.desc b/checks/fields.desc
index 002a058..94d1fde 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -941,6 +941,9 @@ Info: This package declares an unnecessary versioned 
dependency
  should come second.
  .
  Example: libextutils-parsexs-perl (gt;= 2.21) | perl (gt;= 5.14)
+ .
+ Running ttcme fix dpkg -from control -filter Depends/tt should be able
+ to update these dependencies.
 Ref: policy 7.5
 
 Tag: package-superseded-by-perl
@@ -962,6 +965,9 @@ Info: This package is also provided by one of the Perl core 
packages
  versioned dependency a secondary one.
  .
  Example: perl (gt;= 5.10.0) | libmodule-build-perl (gt;= 0.26)
+ .
+ Running ttcme fix dpkg -from control -filter Depends/tt should be able
+ to update these dependencies.
 Ref: policy 7.5
 
 Tag: vcs-field-uses-not-recommended-uri-format
diff --git a/debian/changelog b/debian/changelog
index 4e3f2b9..edf4994 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,10 @@ lintian (2.5.11) UNRELEASED; urgency=low
 
   * checks/deb-format{,.desc}:
 + [NT] Retire data.tar.xz tag.  (Closes: #680391)
+  * checks/fields.desc:
++ [NT] Mention that cme can automate fixing some perl
+  related tags.  Thanks to gregor herrmann for the report
+  and patch.  (Closes: #680446)
 
  -- Niels Thykier ni...@thykier.net  Tue, 10 Jul 2012 13:21:56 +0200
 

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1soyqy-0003vy...@vasks.debian.org



[SCM] Debian package checker branch, master, updated. 2.5.10-2-g3eb5fc7

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 602ce7b05f617edabcea5d089bb542d6fa9e0df1
Author: Niels Thykier ni...@thykier.net
Date:   Tue Jul 10 13:36:13 2012 +0200

Retire data.tar.xz-member-without-dpkg-pre-depends

Signed-off-by: Niels Thykier ni...@thykier.net

diff --git a/checks/deb-format b/checks/deb-format
index 9b498e8..97ce811 100644
--- a/checks/deb-format
+++ b/checks/deb-format
@@ -60,10 +60,6 @@ if ($success) {
 } else {
 if ($type eq 'udeb'  $members[2] !~ m/^data\.tar\.[gx]z$/) {
 tag 'udeb-uses-unsupported-compression-for-data-tarball';
-} elsif ($type ne 'udeb'  $members[2] eq 'data.tar.xz') {
-my $rel = $info-relation('pre-depends');
-tag 'data.tar.xz-member-without-dpkg-pre-depends'
-unless $rel-implies('dpkg (= 1.15.6~)');
 }
 $okay = 1;
 }
diff --git a/checks/deb-format.desc b/checks/deb-format.desc
index f070cef..a3de854 100644
--- a/checks/deb-format.desc
+++ b/checks/deb-format.desc
@@ -49,11 +49,3 @@ Info: The data tarball of this udeb package is not 
compressed in format
  .
  Currently, udpkg supports .gz and .xz compressed tarballs.
 
-Tag: data.tar.xz-member-without-dpkg-pre-depends
-Severity: pedantic
-Certainty: certain
-Info: The deb uses xz compression for the data member, which requires
- a Pre-Depends on dpkg (gt;= 1.15.6~).  This is trivially satisfied in
- Debian, but it can complicate upgrades from Ubuntu Lucid where dpkg
- 1.15.6 is not currently available.
-
diff --git a/debian/changelog b/debian/changelog
index 817fcab..4e3f2b9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+lintian (2.5.11) UNRELEASED; urgency=low
+
+  * Summary of tag changes:
++ Removed:
+  - data.tar.xz-member-without-dpkg-pre-depends
+
+  * checks/deb-format{,.desc}:
++ [NT] Retire data.tar.xz tag.  (Closes: #680391)
+
+ -- Niels Thykier ni...@thykier.net  Tue, 10 Jul 2012 13:21:56 +0200
+
 lintian (2.5.10) unstable; urgency=low
 
   * Summary of tag changes:
diff --git a/profiles/ubuntu/main.profile b/profiles/ubuntu/main.profile
index 25c35a4..8df51be 100644
--- a/profiles/ubuntu/main.profile
+++ b/profiles/ubuntu/main.profile
@@ -12,7 +12,6 @@ Disable-Tags: changelog-should-mention-nmu,
  upstart-job-in-etc-init.d-not-registered-via-update-rc.d
 
 # Serious as it may break Lucid upgrade path
-Tags: data.tar.xz-member-without-dpkg-pre-depends,
- preinst-uses-dpkg-maintscript-helper-without-predepends
+Tags: preinst-uses-dpkg-maintscript-helper-without-predepends
 Severity: serious
 
diff --git a/t/tests/deb-format-xz-compression-ubuntu/debian/debian/rules 
b/t/tests/deb-format-xz-compression-ubuntu/debian/debian/rules
deleted file mode 100644
index 3e46a11..000
--- a/t/tests/deb-format-xz-compression-ubuntu/debian/debian/rules
+++ /dev/null
@@ -1,8 +0,0 @@
-#!/usr/bin/make -f
-
-%:
-   dh $@
-
-override_dh_builddeb:
-   dh_builddeb -- -Zxz
-
diff --git a/t/tests/deb-format-xz-compression-ubuntu/desc 
b/t/tests/deb-format-xz-compression-ubuntu/desc
deleted file mode 100644
index fa60813..000
--- a/t/tests/deb-format-xz-compression-ubuntu/desc
+++ /dev/null
@@ -1,7 +0,0 @@
-Testname: deb-format-xz-compression-ubuntu
-Sequence: 6000
-Version: 1.0
-Profile: ubuntu/main
-Distribution: precise
-Description: Test of xz compression without dpkg pre-dep
-Test-For: data.tar.xz-member-without-dpkg-pre-depends
diff --git a/t/tests/deb-format-xz-compression-ubuntu/tags 
b/t/tests/deb-format-xz-compression-ubuntu/tags
deleted file mode 100644
index 1b359ef..000
--- a/t/tests/deb-format-xz-compression-ubuntu/tags
+++ /dev/null
@@ -1 +0,0 @@
-E: deb-format-xz-compression-ubuntu: 
data.tar.xz-member-without-dpkg-pre-depends

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1soyqx-0003un...@vasks.debian.org



Processed: limit source to lintian, tagging 680446

2012-07-10 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

 #lintian (2.5.11) UNRELEASED; urgency=low
 #
 #  * checks/fields.desc:
 #+ [NT] Mention that cme can automate fixing some perl
 #  related tags.  Thanks to gregor herrmann for the report
 #  and patch.  (Closes: #680446)
 #
 limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'

 tags 680446 + pending
Bug #680446 [lintian] lintian: Description update for perl-dependency tags
Added tag(s) pending.
 thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
680446: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680446
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/handler.s.c.1341920537794.transcr...@bugs.debian.org



[SCM] Debian package checker branch, master, updated. 2.5.10-3-g3c351b6

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 3c351b692b94ee7daf3cab55efb018685900cefb
Author: Niels Thykier ni...@thykier.net
Date:   Tue Jul 10 14:12:41 2012 +0200

c/manpages: Manual redirect  chdir when invoking man

Signed-off-by: Niels Thykier ni...@thykier.net

diff --git a/checks/manpages b/checks/manpages
index 94ebdb3..cdf6e74 100644
--- a/checks/manpages
+++ b/checks/manpages
@@ -233,22 +233,36 @@ foreach my $file ($info-sorted_index) {
 # parent directory before running man so that .so directives are
 # processed properly.  (Yes, there are man pages that include other
 # pages with .so but aren't simple links; rbash, for instance.)
-my $cmd;
+my @cmd = ('man', '--warnings', '-E', 'UTF-8', '-l');
+my $dir;
 if ($path =~ m,^(.*)/(man\d/.*)$,) {
-$cmd = cd \Q$1\E  man --warnings -E UTF-8 -l \Q$2\E;
+$dir = $1;
+push @cmd, $2;
 } else {
-$cmd = man --warnings -E UTF-8 -l \Q$path\E;
+push @cmd, $path;
 }
-my $pid = open MANERRS, '-|';
+my ($read, $write);
+pipe ($read, $write) or fail pipe failed: $!;
+my $pid = fork;
 if (not defined $pid) {
-fail(cannot run man -E UTF-8 -l: $!);
+fail fork failed: $!;
 } elsif ($pid == 0) {
 clean_env;
+close STDOUT;
+close $read;
+open STDERR, '', $write
+or fail Redirecting STDERR: $!;
+if ($dir) {
+chdir $dir or fail chdir $dir: $!;
+}
 $ENV{MANWIDTH} = 80;
-exec ($cmd /dev/null) 21
+exec { $cmd[0] } @cmd
 or fail(cannot run man -E UTF-8 -l: $!);
+} else {
+# parent - close write end
+close $write;
 }
-while (MANERRS) {
+while ($read) {
 # ignore progress information from man
 next if /^Reformatting/;
 next if /^\s*$/;
diff --git a/debian/changelog b/debian/changelog
index edf4994..e92c39d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -10,6 +10,9 @@ lintian (2.5.11) UNRELEASED; urgency=low
 + [NT] Mention that cme can automate fixing some perl
   related tags.  Thanks to gregor herrmann for the report
   and patch.  (Closes: #680446)
+  * checks/manpages:
++ [NT] Manually do redirects and chdir rather than invoking
+  a shell when calling man.
 
  -- Niels Thykier ni...@thykier.net  Tue, 10 Jul 2012 13:21:56 +0200
 

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1sozki-00088m...@vasks.debian.org



[SCM] Debian package checker branch, master, updated. 2.5.10-4-g750623c

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 750623c4dab40aa2044e49c67ece359e83fe4cf8
Author: Niels Thykier ni...@thykier.net
Date:   Tue Jul 10 14:37:16 2012 +0200

c/manpages: Set MANROFFSEQ when calling man

Signed-off-by: Niels Thykier ni...@thykier.net

diff --git a/checks/manpages b/checks/manpages
index cdf6e74..31c97a0 100644
--- a/checks/manpages
+++ b/checks/manpages
@@ -255,6 +255,7 @@ foreach my $file ($info-sorted_index) {
 if ($dir) {
 chdir $dir or fail chdir $dir: $!;
 }
+$ENV{MANROFFSEQ} = '';
 $ENV{MANWIDTH} = 80;
 exec { $cmd[0] } @cmd
 or fail(cannot run man -E UTF-8 -l: $!);
diff --git a/checks/manpages.desc b/checks/manpages.desc
index e9c7c3e..c6ceb01 100644
--- a/checks/manpages.desc
+++ b/checks/manpages.desc
@@ -164,8 +164,11 @@ Info: This man page provokes warnings or errors from man.
  At worst, warning messages can be disabled with the .warn directive, see
  Debugging in the groff manual.
  .
+ Lintian also stricter in regards to declaring manpage preprocessors.
+ .
  To test this for yourself you can use the following command:
-  LC_ALL=en_US.UTF-8 MANWIDTH=80 man --warnings -E UTF-8 -l lt;filegt; 
gt;/dev/null
+  LC_ALL=en_US.UTF-8 MANROFFSEQ='' MANWIDTH=80 \
+ man --warnings -E UTF-8 -l lt;filegt; gt;/dev/null
 
 Tag: manpage-has-errors-from-pod2man
 Severity: normal
diff --git a/debian/changelog b/debian/changelog
index e92c39d..3999266 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -10,9 +10,11 @@ lintian (2.5.11) UNRELEASED; urgency=low
 + [NT] Mention that cme can automate fixing some perl
   related tags.  Thanks to gregor herrmann for the report
   and patch.  (Closes: #680446)
-  * checks/manpages:
-+ [NT] Manually do redirects and chdir rather than invoking
-  a shell when calling man.
+  * checks/manpages{,.desc}:
++ [CW,NT] Manually do redirects and chdir rather than
+  invoking a shell when calling man.
++ [CW,NT] Be stricter with missing roff preprocessors by
+  setting MANROFFSEQ to the empty string when calling man.
 
  -- Niels Thykier ni...@thykier.net  Tue, 10 Jul 2012 13:21:56 +0200
 

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1sozii-7l...@vasks.debian.org



[SCM] Debian package checker branch, master, updated. 2.5.10-5-g17d0f91

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 17d0f9192aa83110de1f1aa0e5ca7bd0ca136172
Author: Niels Thykier ni...@thykier.net
Date:   Tue Jul 10 14:42:08 2012 +0200

c/manpages: Re-direct man's stdout to /dev/null

While closing stdout does not seem to cause any errors, it seems
more prudent to redirect to /dev/null instead.

Signed-off-by: Niels Thykier ni...@thykier.net

diff --git a/checks/manpages b/checks/manpages
index 31c97a0..375fb5e 100644
--- a/checks/manpages
+++ b/checks/manpages
@@ -250,6 +250,8 @@ foreach my $file ($info-sorted_index) {
 clean_env;
 close STDOUT;
 close $read;
+open STDOUT, '', '/dev/null'
+or fail Redirecting STDOUT: $!;
 open STDERR, '', $write
 or fail Redirecting STDERR: $!;
 if ($dir) {

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1sozo4-0007n3...@vasks.debian.org



[SCM] Debian package checker branch, master, updated. 2.5.10-6-g9fd5d80

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 9fd5d8049dfa8f726bc5b129773d18a2bb626429
Author: Niels Thykier ni...@thykier.net
Date:   Tue Jul 10 15:11:39 2012 +0200

c/manpages: Pass -Tutf8 -Z to man

This skips part of the groff pipeline, making Lintian a bit faster on
packages with a lot of manpages.

Signed-off-by: Niels Thykier ni...@thykier.net

diff --git a/checks/manpages b/checks/manpages
index 375fb5e..4b27afb 100644
--- a/checks/manpages
+++ b/checks/manpages
@@ -233,7 +233,7 @@ foreach my $file ($info-sorted_index) {
 # parent directory before running man so that .so directives are
 # processed properly.  (Yes, there are man pages that include other
 # pages with .so but aren't simple links; rbash, for instance.)
-my @cmd = ('man', '--warnings', '-E', 'UTF-8', '-l');
+my @cmd = ('man', '--warnings', '-E', 'UTF-8', '-l', '-Tutf8', '-Z');
 my $dir;
 if ($path =~ m,^(.*)/(man\d/.*)$,) {
 $dir = $1;
diff --git a/checks/manpages.desc b/checks/manpages.desc
index c6ceb01..1b22764 100644
--- a/checks/manpages.desc
+++ b/checks/manpages.desc
@@ -168,7 +168,7 @@ Info: This man page provokes warnings or errors from man.
  .
  To test this for yourself you can use the following command:
   LC_ALL=en_US.UTF-8 MANROFFSEQ='' MANWIDTH=80 \
- man --warnings -E UTF-8 -l lt;filegt; gt;/dev/null
+ man --warnings -E UTF-8 -l -Tutf8 -Z lt;filegt; gt;/dev/null
 
 Tag: manpage-has-errors-from-pod2man
 Severity: normal
diff --git a/debian/changelog b/debian/changelog
index 3999266..78d48b0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -15,6 +15,8 @@ lintian (2.5.11) UNRELEASED; urgency=low
   invoking a shell when calling man.
 + [CW,NT] Be stricter with missing roff preprocessors by
   setting MANROFFSEQ to the empty string when calling man.
++ [CW,NT] Pass -Tutf8 -Z to man to skip an unused part of
+  the groff pipeline.
 
  -- Niels Thykier ni...@thykier.net  Tue, 10 Jul 2012 13:21:56 +0200
 

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1soaf2-0005ck...@vasks.debian.org



Bug#674004: marked as done (lintian: doc-base-unknown-section Video should be known)

2012-07-10 Thread Debian Bug Tracking System
Your message dated Tue, 10 Jul 2012 15:22:47 +0200
with message-id 4ffc2ca7.10...@thykier.net
and subject line Re: Bug#674004: lintian: doc-base-unknown-section Video should 
be known
has caused the Debian Bug report #674004,
regarding lintian: doc-base-unknown-section Video should be known
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
674004: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674004
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
---BeginMessage---
Package: lintian
Version: 2.5.7
Severity: minor

While working on a new version of the package photofilmstrip I came across this 
lintian hint:
W: photofilmstrip: doc-base-unknown-section photofilmstrip:5 Video

Checking the available documentation and running
install-docs --verbose --check debian/photofilmstrip.doc-base
show that Video is indeed a valid section, hence Lintian is wrong.


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (250, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.22-6
ii  bzip2  1.0.6-1
ii  diffstat   1.55-2
ii  file   5.11-1
ii  gettext0.18.1.1-8
ii  hardening-includes 2.1
ii  intltool-debian0.35.0+20060710.1
ii  libapt-pkg-perl0.1.26+b1
ii  libc-bin   2.13-32
ii  libclass-accessor-perl 0.34-1
ii  libclone-perl  0.31-1+b2
ii  libdpkg-perl   1.16.3
ii  libemail-valid-perl0.190-1
ii  libipc-run-perl0.91-1
ii  libparse-debianchangelog-perl  1.2.0-1
ii  libtimedate-perl   1.2000-1
ii  liburi-perl1.60-1
ii  locales2.13-32
ii  locales-all [locales]  2.13-32
ii  man-db 2.6.1-2
ii  patchutils 0.3.2-1.1
ii  perl [libdigest-sha-perl]  5.14.2-10
ii  unzip  6.0-6

lintian recommends no packages.

Versions of packages lintian suggests:
ii  binutils-multiarch none
ii  dpkg-dev   1.16.3
ii  libhtml-parser-perl3.69-2
ii  libtext-template-perl  none
ii  man-db 2.6.1-2
ii  xz-utils   5.1.1alpha+20110809-3

-- no debconf information


---End Message---
---BeginMessage---
On 2012-05-23 20:24, Niels Thykier wrote:
 tags 674004 + unreproducible
 thanks
 
 
 On 2012-05-22 15:23, Philipp Huebner wrote:
 Package: lintian
 Version: 2.5.7
 Severity: minor

 While working on a new version of the package photofilmstrip I came across 
 this lintian hint:
 W: photofilmstrip: doc-base-unknown-section photofilmstrip:5 Video

 Checking the available documentation and running
 install-docs --verbose --check debian/photofilmstrip.doc-base
 show that Video is indeed a valid section, hence Lintian is wrong.


 [...]

 
 Hi,
 
 I cannot reproduce this, I tested the deb photofilmstrip/1.9.91+dfsg-1
 currently in sid.
 
 
 As far as I can tell, Lintian has known about the Video section since
 2008 (according to git blame).  So I am a bit puzzled about this report...
 
 ~Niels
 
 
 
 

Hi,

I still cannot reproduce this and as I haven't heard from you, I am
taking the liberty of closing this as not a bug (as it looks to be
fixed).  If you can reproduce it, please write back and include the
version of Lintian you are using.

~Niels


---End Message---


[SCM] Debian package checker branch, master, updated. 2.5.10-7-g33389b5

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 33389b5ce86999418f7bca1c06ff409f5bf24eff
Author: Niels Thykier ni...@thykier.net
Date:   Tue Jul 10 15:30:02 2012 +0200

data: Update doc-base section list

Signed-off-by: Niels Thykier ni...@thykier.net

diff --git a/debian/changelog b/debian/changelog
index 78d48b0..576e830 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -18,6 +18,9 @@ lintian (2.5.11) UNRELEASED; urgency=low
 + [CW,NT] Pass -Tutf8 -Z to man to skip an unused part of
   the groff pipeline.
 
+  * data/doc-base/sections:
++ [NT] Update section list.  (Closes: #678650)
+
  -- Niels Thykier ni...@thykier.net  Tue, 10 Jul 2012 13:21:56 +0200
 
 lintian (2.5.10) unstable; urgency=low
diff --git a/vendors/debian/ftp-master-auto-reject/data/doc-base/sections 
b/vendors/debian/ftp-master-auto-reject/data/doc-base/sections
index 8d74588..649e198 100644
--- a/vendors/debian/ftp-master-auto-reject/data/doc-base/sections
+++ b/vendors/debian/ftp-master-auto-reject/data/doc-base/sections
@@ -1,6 +1,6 @@
 # Taken from /usr/share/doc-base/data/sections.list.
 #
-# Last synchronized with doc-base 0.9.5 (2009-10-27).
+# Last synchronized with doc-base 0.10.4 (2012-07-10).
 
 Accessibility
 Amateur Radio
@@ -31,6 +31,7 @@ Mobile Devices
 Network/Communication
 Network/File Transfer
 Network/Monitoring
+Network/Remote Access
 Network/Web Browsing
 Network/Web News
 Office

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1soawn-00013p...@vasks.debian.org



Processed: limit source to lintian, tagging 678650

2012-07-10 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

 #lintian (2.5.11) UNRELEASED; urgency=low
 #
 #  * data/doc-base/sections:
 #+ [NT] Update section list.  (Closes: #678650)
 #
 limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'

 tags 678650 + pending
Bug #678650 [lintian] Please recognize doc-base section Network/Remote Access
Added tag(s) pending.
 thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
678650: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=678650
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/handler.s.c.13419270611154.transcr...@bugs.debian.org



Bug#679132: lintian: false positive on package-uses-local-diversion when --local and --package are not given

2012-07-10 Thread Niels Thykier
On 2012-06-26 16:53, Raphaël Hertzog wrote:
 Package: lintian
 Version: 2.5.9
 Severity: normal
 
 When you use a dpkg-divert invocation like this one:
 
   dpkg-divert --rename --divert $file.original --add $file
 
 Lintian triggers an error package-uses-local-diversion. But this error is
 wrong since those calls are in maintainer scripts and thus
 DPKG_MAINTSCRIPT_PACKAGE is set. When --package and --local are both
 missing, and when $DPKG_MAINTSCRIPT_PACKAGE is set, dpkg-divert assumes
 --package $DPKG_MAINTSCRIPT_PACKAGE.
 
 This is the case since dpkg 1.16.0 (i.e. since wheezy's dpkg).
 
 [...]
 
 
 

Actually, it sounds like it is a proper warning, since Squeeze (i.e.
stable) still has 1.15.8.12.  That means it could cause issues for
people not upgrading dpkg before everything else (or for any package
upgraded together with dpkg).

~Niels






--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4ffc301e.2090...@thykier.net



Processed: severity of 678639 is wishlist

2012-07-10 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

 severity 678639 wishlist
Bug #678639 [lintian] lintian: DEP-5 and typoes in field names
Severity set to 'wishlist' from 'normal'
 thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
678639: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=678639
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/handler.s.c.13419277944404.transcr...@bugs.debian.org



Bug#679132: lintian: false positive on package-uses-local-diversion when --local and --package are not given

2012-07-10 Thread Raphael Hertzog
On Tue, 10 Jul 2012, Niels Thykier wrote:
 Actually, it sounds like it is a proper warning, since Squeeze (i.e.
 stable) still has 1.15.8.12.  That means it could cause issues for
 people not upgrading dpkg before everything else (or for any package
 upgraded together with dpkg).

Right. It's a wheezy+1 or wheezy+2 wishlist then.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/



--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120710141849.ga28...@rivendell.home.ouaza.com



[SCM] Debian package checker branch, master, updated. 2.5.10-8-g1144b47

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 1144b47acd967552ff9c094a581de8f710c541b8
Author: Niels Thykier ni...@thykier.net
Date:   Tue Jul 10 16:33:50 2012 +0200

c/source-cpy: Check for common misspelled field names

Use Levenshtein edit distance to detect misspelled field names in
DEP-5 copyright files.

Signed-off-by: Niels Thykier ni...@thykier.net

diff --git a/checks/source-copyright b/checks/source-copyright
index fea9e44..916dadd 100644
--- a/checks/source-copyright
+++ b/checks/source-copyright
@@ -23,6 +23,8 @@ package Lintian::source_copyright;
 use strict;
 use warnings;
 
+use Text::Levenshtein qw(distance);
+
 use Lintian::Relation::Version qw(versions_compare);
 use Lintian::Tags qw(tag);
 use Lintian::Util qw(parse_dpkg_control slurp_entire_file fail);
@@ -167,8 +169,8 @@ if (@dep5) {
 my $i = 0;
 for my $para (@dep5) {
 $i++;
-my $license = $para-{'license'};
-my $files = $para-{'files'};
+my $license = get_field ($para, 'license');
+my $files = get_field ($para, 'files');
 if (defined $license and not defined $files) {
 # Standalone license paragraph
 if (not $license =~ m/\n/) {
@@ -190,7 +192,7 @@ if (@dep5) {
 else {
 tag 'missing-field-in-dep5-copyright', license (paragraph at 
line $lines[$i]);
 }
-if (not defined $para-{'copyright'}) {
+if (not defined get_field ($para, 'copyright')) {
 tag 'missing-field-in-dep5-copyright', copyright (paragraph 
at line $lines[$i]);
 }
 }
@@ -224,6 +226,19 @@ sub split_licenses {
 return map \L$_, (split /\s++(?:and|or)\s++/);
 }
 
+sub get_field {
+my ($para, $field) = @_;
+return $para-{$field} if exists $para-{$field};
+# Fall back to a likely misspelling of the field.
+foreach my $f (sort keys %$para) {
+if (distance ($field, $f)  3) {
+tag 'field-name-typo-in-dep5-copyright', $f, '-', $field;
+return $para-{$f};
+}
+}
+return;
+}
+
 1;
 
 # Local Variables:
diff --git a/checks/source-copyright.desc b/checks/source-copyright.desc
index 4a6ff26..d6c98f8 100644
--- a/checks/source-copyright.desc
+++ b/checks/source-copyright.desc
@@ -132,3 +132,16 @@ Certainty: possible
 Ref: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Info: The machine-readable copyright file contains a paragraph that is neither
  a standalone license paragraph nor a files paragraph.
+
+Tag: field-name-typo-in-dep5-copyright
+Severity: normal
+Certainty: possible
+Info: The listed field name is a likely misspelling of one of the documented
+ DEP-5 fields.
+ .
+ Lintian will continue by using the misspelled variant, but other parsers
+ are unlikely to do so.
+ .
+ Implementation detail: The typo is detected by using Levenshtein
+ edit distance.  Therefore, if the typo involve several characters,
+ Lintian may not detect it.
diff --git a/debian/changelog b/debian/changelog
index 576e830..ae6b29b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,8 @@
 lintian (2.5.11) UNRELEASED; urgency=low
 
   * Summary of tag changes:
++ Added:
+  - field-name-typo-in-dep5-copyright
 + Removed:
   - data.tar.xz-member-without-dpkg-pre-depends
 
@@ -17,10 +19,16 @@ lintian (2.5.11) UNRELEASED; urgency=low
   setting MANROFFSEQ to the empty string when calling man.
 + [CW,NT] Pass -Tutf8 -Z to man to skip an unused part of
   the groff pipeline.
+  * checks/source-copyright{,.desc}:
++ [NT] Check for possible misspellings of known field
+  names.  (Closes: #678639)
 
   * data/doc-base/sections:
 + [NT] Update section list.  (Closes: #678650)
 
+  * debian/control:
++ [NT] Add (Build-)Depends on libtext-levenshtein-perl.
+
  -- Niels Thykier ni...@thykier.net  Tue, 10 Jul 2012 13:21:56 +0200
 
 lintian (2.5.10) unstable; urgency=low
diff --git a/debian/control b/debian/control
index 1265b43..c02c378 100644
--- a/debian/control
+++ b/debian/control
@@ -39,6 +39,7 @@ Build-Depends: binutils,
libtest-pod-perl,
libtest-strict-perl,
libtest-synopsis-perl,
+   libtext-levenshtein-perl,
libtext-template-perl,
libtimedate-perl,
liburi-perl,
@@ -78,6 +79,7 @@ Depends: binutils,
  libemail-valid-perl,
  libipc-run-perl,
  libparse-debianchangelog-perl,
+ libtext-levenshtein-perl,
  libtimedate-perl,
  liburi-perl,
  man-db,
diff --git a/t/COVERAGE b/t/COVERAGE
index 7aef2b5..7005c28 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,5 +1,5 @@
-Last generated 2012-04-23
-Coverage: 811/964 (84.13%), w. legacy tests: 916/964 (95.02%)
+Last generated 2012-07-10
+Coverage: 812/965 (84.15%), w. legacy tests: 917/965 (95.03%)
 
 The following tags are not tested by the test suite:
 

Processed: limit source to lintian, tagging 678639

2012-07-10 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

 #lintian (2.5.11) UNRELEASED; urgency=low
 #
 #  * checks/source-copyright{,.desc}:
 #+ [NT] Check for possible misspellings of known field
 #  names.  (Closes: #678639)
 #
 limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'

 tags 678639 + pending
Bug #678639 [lintian] lintian: DEP-5 and typoes in field names
Added tag(s) pending.
 thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
678639: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=678639
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems


--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/handler.s.c.134193124621427.transcr...@bugs.debian.org



[SCM] Debian package checker branch, master, updated. 2.5.10-9-g99188a5

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 99188a5bd6f8cec660894e60316e80d6059e4db0
Author: Niels Thykier ni...@thykier.net
Date:   Tue Jul 10 23:32:03 2012 +0200

L::Collect{,::Source}: Add DEFAULT parameter to {X_,}field

This new optional parameter can be used to determine the default value
if a field is missing.  This is useful to avoid having to having to
handle undef values in some cases.

Signed-off-by: Niels Thykier ni...@thykier.net

diff --git a/checks/binaries b/checks/binaries
index 07a2b00..c7476c1 100644
--- a/checks/binaries
+++ b/checks/binaries
@@ -105,9 +105,9 @@ my $uses_numpy_c_abi = 0;
 
 my %SONAME;
 
-$arch = $info-field('architecture')//'';
-$multiarch = $info-field('multi-arch')//'no';
-my $srcpkg = $proc-pkg_src()//'';
+$arch = $info-field ('architecture', '');
+$multiarch = $info-field ('multi-arch', 'no');
+my $srcpkg = $proc-pkg_src;
 
 foreach my $file (sort keys %{$info-objdump_info}) {
 my $objdump = $info-objdump_info-{$file};
diff --git a/checks/changes-file b/checks/changes-file
index 919dd2b..0c7a749 100644
--- a/checks/changes-file
+++ b/checks/changes-file
@@ -43,7 +43,7 @@ if (!$info-field('format')) {
 
 # Description is mandated by dak, but only makes sense if binary
 # packages are included.  Don't tag pure source uploads.
-if (!$info-field('description')  ($info-field('architecture')//'') ne 
'source') {
+if (!$info-field ('description')  $info-field ('architecture', '') ne 
'source') {
 tag 'no-description-in-changes-file';
 }
 
diff --git a/checks/control-file b/checks/control-file
index 9ab8efe..7536c52 100644
--- a/checks/control-file
+++ b/checks/control-file
@@ -309,7 +309,7 @@ sub check_dev_depends {
 # Note, we do not check if the -dev package is
 # arch:all as well.  The version-substvars check
 # handles that for us.
-next if ($info-binary_field ($target, 'architecture')//'') eq 
'all'
+next if $info-binary_field ($target, 'architecture', '') eq 
'all'
  $versions[0] =~ /^\s*=\s*\$\{source:Version\}/;
 tag 'weak-library-dev-dependency', $package on $depends[0];
 }
diff --git a/checks/fields b/checks/fields
index 8ab3dc8..69bb103 100644
--- a/checks/fields
+++ b/checks/fields
@@ -439,7 +439,7 @@ if (not defined $info-field('section')) {
 }
 }
 if ($info-is_transitional) {
-my $pri = $info-field ('priority')//'';
+my $pri = $info-field ('priority', '');
 # Cannot use unfold as it could emit a tag for priority,
 # which will be duplicated below.
 $pri =~ s/\n//;
@@ -735,7 +735,7 @@ if ($type eq 'source') {
 my $arch_indep_packages = 0;
 my $arch_dep_packages = 0;
 foreach my $binpkg (keys %$binpkgs) {
-my $arch = $info-binary_field($binpkg, 'architecture')//'';
+my $arch = $info-binary_field($binpkg, 'architecture', '');
 if ($arch eq 'all') {
 $arch_indep_packages++;
 } else {
@@ -851,14 +851,14 @@ if ($type eq 'source') {
 foreach my $binpkg (keys %$binpkgs) {
 if ($binpkg =~ m/-dbg$/) {
 push @dbg_pkgs, $binpkg;
-} elsif (($info-binary_field($binpkg, 'architecture')//'') ne 'all') {
+} elsif ($info-binary_field ($binpkg, 'architecture', '') ne 'all') {
 push @arch_dep_pkgs, $binpkg;
 }
 }
 foreach (@dbg_pkgs) {
 my $deps;
-$deps  = ($info-binary_field($_, 'pre-depends')//'') . ', ';
-$deps .= $info-binary_field($_, 'depends');
+$deps  = $info-binary_field($_, 'pre-depends', '') . ', ';
+$deps .= $info-binary_field($_, 'depends', '');
 tag 'dbg-package-missing-depends', $_
unless (grep {my $quoted_name = qr\Q$_; $deps =~ 
m/(?:\s|,|^)$quoted_name(?:\s|,|\z)/} @arch_dep_pkgs);
 }
diff --git a/checks/filename-length b/checks/filename-length
index eef9c1e..423bcaa 100644
--- a/checks/filename-length
+++ b/checks/filename-length
@@ -71,7 +71,7 @@ return if $type ne 'source';
 # Reset to work with elements of the dsc file.
 $len = 0;
 
-foreach my $entry (split m/\n/o, $info-field('files')//''){
+foreach my $entry (split m/\n/o, $info-field ('files', '')){
 my $filename;
 my $flen;
 $entry =~ s/^\s++//o;
diff --git a/checks/files b/checks/files
index af293d5..87b0824 100644
--- a/checks/files
+++ b/checks/files
@@ -176,8 +176,8 @@ my %linked_against_libvga;
 my $py_support_nver = undef;
 
 my $arch_dep_files = 0;
-my $arch = $info-field ('architecture')//'';
-my $isma_same = ($info-field ('multi-arch')//'') eq 'same';
+my $arch = $info-field ('architecture', '');
+my $isma_same = $info-field ('multi-arch', '') eq 'same';
 my $ppkg = quotemeta ($pkg);
 
 # read data from objdump-info file
@@ -198,10 +198,10 @@ foreach my $file (sort keys %{$info-objdump_info}) {
 #
 # Otherwise set it to the 

[SCM] Debian package checker branch, master, updated. 2.5.10-10-g701e44e

2012-07-10 Thread Niels Thykier
The following commit has been merged in the master branch:
commit 701e44e2b14308faaf22805172f7c1b42f71748c
Author: Niels Thykier ni...@thykier.net
Date:   Sun Apr 15 16:41:43 2012 +0200

coll/objdump-info: dctrl-ify the output

Instead of relying on making readelf output look like objdump,
filter out the unneeded part and write the interesting data as
a dctrl formatted file.

As a side effect, merge apparently-truncated-elf-binary into
apparently-corrupted-elf-binary.  Unlike objdump, readelf does not
really give a reliable way of distinguishing the two cases.

The patch also fixes a couple of references to objdump in the
tag description of two tags.

Signed-off-by: Niels Thykier ni...@thykier.net

diff --git a/checks/binaries b/checks/binaries
index c7476c1..051d24f 100644
--- a/checks/binaries
+++ b/checks/binaries
@@ -131,16 +131,10 @@ foreach my $file (sort keys %{$info-objdump_info}) {
 }
 }
 }
-foreach (@{$objdump-{NOTES}}) {
-if ($_ eq 'File format not recognized') {
-tag 'apparently-corrupted-elf-binary', $file;
-} elsif ($_ eq 'File truncated') {
-tag 'apparently-truncated-elf-binary', $file;
-} elsif ($_ eq 'Packed with UPX') {
-tag 'binary-file-compressed-with-upx', $file;
-} elsif ($_ eq 'Invalid operation') {
-tag 'binary-with-bad-dynamic-table', $file unless $file =~ 
m%^usr/lib/debug/%;
-}
+tag 'binary-file-compressed-with-upx', $file if $objdump-{'UPX'};
+tag 'apparently-corrupted-elf-binary', $file if $objdump-{'ERRORS'};
+if ($objdump-{'BAD-DYNAMIC-TABLE'}) {
+tag 'binary-with-bad-dynamic-table', $file unless $file =~ 
m%^usr/lib/debug/%;
 }
 }
 
@@ -291,11 +285,10 @@ foreach my $file ($info-sorted_index) {
 tag 'library-in-debug-or-profile-should-not-be-stripped', $file;
 } else {
 # appropriately stripped, but is it stripped enough?
-if (exists $objdump-{NOTE_SECTION}) {
-tag 'binary-has-unneeded-section', $file .note;
-}
-if (exists $objdump-{COMMENT_SECTION}) {
-tag 'binary-has-unneeded-section', $file .comment;
+foreach my $sect ('.note', '.comment') {
+if (exists $objdump-{'SH'}-{$sect}) {
+tag 'binary-has-unneeded-section', $file $sect;
+}
 }
 }
 }
@@ -346,21 +339,21 @@ foreach my $file ($info-sorted_index) {
 
 # Something other than detached debugging symbols in /usr/lib/debug paths.
 if ($file =~ m,^usr/lib/debug/(?:lib\d*|s?bin|usr|opt|dev|emul)/,) {
-if (exists($objdump-{NEEDED})) {
+if (scalar (@{ $objdump-{NEEDED} }) ) {
 tag 'debug-file-should-use-detached-symbols', $file;
 }
 }
 
 # Detached debugging symbols directly in /usr/lib/debug.
 if ($file =~ m,^usr/lib/debug/[^/]+$,) {
-unless (exists($objdump-{NEEDED})
+unless (scalar (@{ $objdump-{NEEDED} })
 || $fileinfo =~ m/statically linked/) {
 tag 'debug-symbols-directly-in-usr-lib-debug', $file;
 }
 }
 
 # statically linked?
-if (!exists($objdump-{NEEDED}) || !defined($objdump-{NEEDED})) {
+if (! scalar (@{ $objdump-{NEEDED} }) ) {
 if ($fileinfo =~ m/shared object/o) {
 # Some exceptions: detached debugging information and the dynamic
 # loader (which itself has no dependencies).
@@ -374,7 +367,8 @@ foreach my $file ($info-sorted_index) {
 next if ($file =~ /[\.-]static$/);
 next if ($pkg =~ /-static$/);
 # klibc binaries appear to be static.
-next if ($objdump-{KLIBC});
+next if (exists $objdump-{INTERP}
+  $objdump-{INTERP} =~ m,/lib/klibc-\S+\.so,);
 # Location of debugging symbols.
 next if ($file =~ m%^usr/lib/debug/%);
 # ldconfig must be static.
diff --git a/checks/binaries.desc b/checks/binaries.desc
index 9a81f60..c6f3e25 100644
--- a/checks/binaries.desc
+++ b/checks/binaries.desc
@@ -150,26 +150,24 @@ Info: The package name of a library package should 
usually reflect
 Tag: binary-with-bad-dynamic-table
 Severity: serious
 Certainty: possible
-Info: This appears to be an ELF file but objdump -T cannot parse it.
- If it is external debugging symbols for another file, it should be
- installed under /usr/lib/debug.
+Info: This appears to be an ELF file.  According to readelf, the
+ program headers suggests it should have a dynamic section, but
+ readelf cannot find it.
+ .
+ If it is meant to be external debugging symbols for another file,
+ it should be installed under /usr/lib/debug.  Otherwise, this
+ could be a corrupt ELF file.
 
 Tag: apparently-corrupted-elf-binary
 Severity: normal
 Certainty: possible
-Info: This appears to be an ELF file but objdump -T doesn't