date:20181108

Bug#913290: lintian: Incorrectly reports invalid-template-id-in-symbols-file/syntax-error-in-symbols-file for certain symbols files

2018-11-08 Thread James McCoy

Package: lintian
Version: 2.5.110
Severity: normal
Tags: patch

14098d4c65159b651d6c324d04cc9a83c26a592e introduced a regression with
these two tags[0][1], as noticed by the libsvn1 package.  This was due
to no longer re-setting[2] meta_info_seen when encountering a new entry
in the symbols file.

[0]: https://lintian.debian.org/tags/invalid-template-id-in-symbols-file.html
[1]: https://lintian.debian.org/tags/syntax-error-in-symbols-file.html
[2]: 
https://salsa.debian.org/lintian/lintian/commit/14098d4c65159b651d6c324d04cc9a83c26a592e#1fa89243df10deea1f8a05360d685b460458e201_500_500

The below patch fixes the issue, although I'm not familiar enough with
the test suite to add a regression test.

diff --git i/checks/shared-libs.pm w/checks/shared-libs.pm
index 61dcd4138..9d520d4f5 100644
--- i/checks/shared-libs.pm
+++ w/checks/shared-libs.pm
@@ -498,6 +498,7 @@ sub run {
 
 $dep_templates = 0;
 $symbol_count = 0;
+undef %meta_info_seen;
 } elsif (m/^\|\s+\S+\s*(?:\(\S+\s+\S+\)|#MINVER#)?/) {
 # alternative dependency template
 

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.18.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils   2.31.1-7
ii  bzip2  1.0.6-9
ii  diffstat   1.61-1+b1
ii  dpkg   1.19.2
ii  file   1:5.34-2
ii  gettext0.19.8.1-8
ii  intltool-debian0.35.0+20060710.4
ii  libapt-pkg-perl0.1.34+b1
ii  libarchive-zip-perl1.64-1
ii  libcgi-pm-perl 4.40-1
ii  libclass-accessor-perl 0.51-1
ii  libclone-perl  0.41-1+b1
ii  libdpkg-perl   1.19.2
ii  libemail-valid-perl1.202-1
ii  libfile-basedir-perl   0.08-1
ii  libipc-run-perl20180523.0-1
ii  liblist-moreutils-perl 0.416-1+b4
ii  libparse-debianchangelog-perl  1.2.0-13
ii  libtext-levenshtein-perl   0.13-1
ii  libtimedate-perl   2.3000-2
ii  liburi-perl1.74-1
ii  libxml-simple-perl 2.25-1
ii  libyaml-libyaml-perl   0.74+repack-1+b1
ii  man-db 2.8.4-3
ii  patchutils 0.3.4-2
ii  perl [libdigest-sha-perl]  5.28.0-3
ii  t1utils1.41-2
ii  xz-utils   5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b5

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.19.2
ii  libhtml-parser-perl3.72-3+b3
ii  libtext-template-perl  1.53-1

-- no debconf information

Bug#913280: lintian: please warn about packages including files in /usr/share/hal/ (used by obsolete hal package)

2018-11-08 Thread Paul Wise

Package: lintian
Version: 2.5.111
Severity: wishlist
Usertags: obsolete

Three packages install files in /usr/share/hal/ but this directory is
no longer looked at by any package in Debian since hal was removed in
2014 because it was replaced by udev. I will file bugs on the three
affected packages but it would be good for lintian to warn about use of
/usr/share/hal/ so that no new or updated packages add files there.

https://bugs.debian.org/747662

$ apt-file search /usr/share/hal/
libmtp-common: /usr/share/hal/fdi/information/20thirdparty/20-libmtp9.fdi
libsane-common: /usr/share/hal/fdi/preprobe/10osvendor/20-libsane.fdi
ntfs-3g: /usr/share/hal/fdi/policy/10osvendor/25-ntfs-3g-policy.fdi

-- System Information:
Debian Release: buster/sid
  APT prefers testing-debug
  APT policy: (900, 'testing-debug'), (900, 'testing'), (800, 
'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700, 
'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.18.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8), 
LANGUAGE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils   2.31.1-7
ii  bzip2  1.0.6-9
ii  diffstat   1.61-1+b1
ii  dpkg   1.19.2
ii  file   1:5.34-2
ii  gettext0.19.8.1-8
ii  intltool-debian0.35.0+20060710.4
ii  libapt-pkg-perl0.1.34+b1
ii  libarchive-zip-perl1.64-1
ii  libcgi-pm-perl 4.40-1
ii  libclass-accessor-perl 0.51-1
ii  libclone-perl  0.41-1+b1
ii  libdpkg-perl   1.19.2
ii  libemail-valid-perl1.202-1
ii  libfile-basedir-perl   0.08-1
ii  libipc-run-perl20180523.0-1
ii  liblist-moreutils-perl 0.416-1+b4
ii  libparse-debianchangelog-perl  1.2.0-13
ii  libtext-levenshtein-perl   0.13-1
ii  libtimedate-perl   2.3000-2
ii  liburi-perl1.74-1
ii  libxml-simple-perl 2.25-1
ii  libyaml-libyaml-perl   0.74+repack-1+b1
ii  man-db 2.8.4-2+b1
ii  patchutils 0.3.4-2
ii  perl [libdigest-sha-perl]  5.28.0-3
ii  t1utils1.41-2
ii  xz-utils   5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b5

Versions of packages lintian suggests:
ii  binutils-multiarch 2.31.1-7
ii  dpkg-dev   1.19.2
ii  libhtml-parser-perl3.72-3+b3
ii  libtext-template-perl  1.53-1

-- no debconf information

-- 
bye,
pabs

https://wiki.debian.org/PaulWise



signature.asc
Description: This is a digitally signed message part

lintian_2.5.112_amd64.changes ACCEPTED into unstable

2018-11-08 Thread Debian FTP Masters




Accepted:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Format: 1.8
Date: Thu, 08 Nov 2018 22:29:31 +
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.112
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers 
Changed-By: Chris Lamb 
Description:
 lintian- Debian package checker
Closes: 912292 912330 913078 913099
Changes:
 lintian (2.5.112) unstable; urgency=medium
 .
   * Summary of tag changes:
 + Added:
   - public-upstream-key-in-native-package
   - public-upstream-key-not-minimal
   - public-upstream-key-unusable
   - public-upstream-keys-in-multiple-locations
   - systemd-service-file-pidfile-refers-to-var-run
 .
   * checks/cruft.desc:
 + [CL] Bump the severity of the source-contains-prebuilt-windows-binary
   tag from "P:" to "W:" and update the description to mention that this
   could potentially be a DFSG violation.
   * checks/systemd.{desc,pm}:
 + [CL] Warn if a PIDFile entry in a .service unit references /var/run.
   (Closes: #913078)
   * checks/upstream-signing-key.{desc,pm}:
 + [CL] Apply a patch series from Felix Lechner to add multiple tests
   for upstream GPG keys.  Thanks!  (MR: !62)
 .
   * data/java/constants:
 + [CL] Apply patches from Bas Couwenberg to update the bytecode checks
   for OpenJDK 11.  (Closes: #912292)
   * data/rules/rules-should-not-use:
 + [CL] Ensure --dbgsym-migration='quoted with spaces' is correctly
   displayed when emitting debug-symbol-migration-possibly-complete.
   * data/spelling/corrections:
 + [PW] Add a number of corrections.
 .
   * debian/control:
 + [CL] Apply a patch from Mathieu Parent to add a dependency on
   dpkg-dev to ensure dpkg-architecture is available.  Thanks!
   (Closes: #912330)
 .
   * t/*:
 + [CL] Apply a patch from Adam Conrad to fix two tests on non-amd64
   architectures in Ubuntu.  Thanks!  (Closes: #913099)
 + [CL] Apply a patch series Felix Lechner to parameterise the source
   format in all applicable tests.  (MR: !64)
 + [CL] Apply a patch series from Felix Lechner to parameterise the
   package architecture for all tests that build only single binary
   package.  (MR: !68)
   * t/tests/basic-non-native-with-epoch/desc:
 + [CL] Apply a patch from Felix Lechner to correct a test "Type" field.
   (MR: !63)
   * t/tests/watch-file-pgpmode-next/*:
 + [CL] Apply a patch series from Felix Lechner to add missing "-I -E"
   options to the existing "--pedantic" one.  (MR: !67)
 .
   * vendors/ubuntu/main/data/changes-file/known-dists:
 + [CL] Add "disco" as a known Ubuntu distribution.
Checksums-Sha1:
 8fc5d099123e5856824ed83919c7dbe1d46f690e 3507 lintian_2.5.112.dsc
 69733d82324ca203dfc63baa57ee40147ea4f647 1611372 lintian_2.5.112.tar.xz
 590e651c17f832b456b854ccfc4dc53d74c9aaf1 1143516 lintian_2.5.112_all.deb
 82a821b28b71a743fa37580afa5c9989da8a73ee 17585 lintian_2.5.112_amd64.buildinfo
Checksums-Sha256:
 de38791686eea190f379290adf1ca7ce23fde851b38f097bf1f385c1449e06d7 3507 
lintian_2.5.112.dsc
 556d84309d50783219c56bbfe1475c2f34be69214428d1516e651eaf82999469 1611372 
lintian_2.5.112.tar.xz
 dcdf828c03d52a0f383706170f805093f8ff3660706c1f7eb148a307c078b12d 1143516 
lintian_2.5.112_all.deb
 c38887cb026b661312343911e5269a861ec3be5f3c02bc752977909825a88f64 17585 
lintian_2.5.112_amd64.buildinfo
Files:
 f011cbe32feda18885b33125d9813ced 3507 devel optional lintian_2.5.112.dsc
 4cc5f16434c050dfe01ef2094639dd7c 1611372 devel optional lintian_2.5.112.tar.xz
 3fec816d0083169edb052b73c3343d71 1143516 devel optional lintian_2.5.112_all.deb
 dd209edfa76887301e3493d2301d8756 17585 devel optional 
lintian_2.5.112_amd64.buildinfo

-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlvkvcYACgkQHpU+J9Qx
HlhcSg/8D4MHHkaE/XNzvYqDH6sXOf4+UzsRn59GWtWG9UWbL2PAuxQb7V7XQre3
WTFwCFtBq40geQ+C3hr+kfCg+IyESMpTaJPVIZFb29D0ySXq+ZvBbIiwY8hspMZL
T4/xFCkTTwsGNUSZX+odr2FUujJ4MECgZ+/x3cjCN+fwhkyf80ZtmWx4fCuawupr
kVD3ScKO9W+85vDlPUvu3XmjGB+Ged0bMzddabVIf6jaDoMjQiEFaVTwSqhnV5b4
Z7GV27VAaO1jNtX5u5r8Z3sQQcJGoFqLZhXk/XA16+zQeSZU1d34NaPL9gnolcLn
HJWkvvZTfaW3As+djXwqsuDq6o0THWDabZp7BXcCbPrxaCFKpTG8wnEZj1+Cw5Ar
jsebyHeJqhBhan50ePaIuOvKIWkIgXuKjyIEnySyPjxXDHDtHJ1704r3y6QjOW2a
+oMrE54c+ybnVOcblPSQe04JVz0tuqLWM6ztBqXbvX1GdHgmtqJWplr+wxuqFbYF
7TxiVCtRkVocfQpYW8vkfvT9UIzYrT/eql5ioz5uD+GyQU+I8LOg73eJAoe6eu/P
fFvMGovUVqJOAlo4idRl7/KIrEbRR8yFddJ9UwHCTEMInTHzPGnKohxL7rnTZr0r
Y/qs6rpVMUaUAdntX/7/U3bHgmwOLE85xDO+rIK/pacPU65Pij0=
=T0DG
-END PGP SIGNATURE-


Thank you for your contribution to Debian.

Bug#913078: marked as done (Please warn if PIDFile in a .service unit contains /var/run)

2018-11-08 Thread Debian Bug Tracking System

Your message dated Thu, 08 Nov 2018 23:35:30 +
with message-id 
and subject line Bug#913078: fixed in lintian 2.5.112
has caused the Debian Bug report #913078,
regarding Please warn if PIDFile in a .service unit contains /var/run
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
913078: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913078
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.111
Severity: wishlist

Hi,

debian introduced /run a couple of releases ago and nowadays /var/run is
merely a symlink pointing to /run.
I would consider it best practice nowadays that packages use /run
directly instead of /var/run and would therefor like to see a check
added to lintian which warns if it finds PIDFile=/var/run in a systemd
.service file. Lintian should suggest that /run should be used directly
instead.
As a related data point: Since debhelper compat level 11, runstatedir
defaults to /run

There are quite packages which still use /var/run [1], and while
discussing this on #debian-systemd it was suggested that this warning
should only be prio pedantic or at most info for the time being.

Thanks for considering,
Michael

https://codesearch.debian.net/search?q=PIDFile%3D%2Fvar%2Frun&perpkg=1

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), 
LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils   2.31.1-7
ii  bzip2  1.0.6-9
ii  diffstat   1.61-1+b1
ii  dpkg   1.19.2+test3
ii  file   1:5.34-2
ii  gettext0.19.8.1-8
ii  intltool-debian0.35.0+20060710.4
ii  libapt-pkg-perl0.1.34+b1
ii  libarchive-zip-perl1.64-1
ii  libcgi-pm-perl 4.40-1
ii  libclass-accessor-perl 0.51-1
ii  libclone-perl  0.41-1+b1
ii  libdigest-sha-perl 6.02-1+b1
ii  libdpkg-perl   1.19.2
ii  libemail-valid-perl1.202-1
ii  libfile-basedir-perl   0.08-1
ii  libipc-run-perl20180523.0-1
ii  liblist-moreutils-perl 0.416-1+b4
ii  libparse-debianchangelog-perl  1.2.0-13
ii  libtext-levenshtein-perl   0.13-1
ii  libtimedate-perl   2.3000-2
ii  liburi-perl1.74-1
ii  libxml-simple-perl 2.25-1
ii  libyaml-libyaml-perl   0.74+repack-1+b1
ii  man-db 2.8.4-3
ii  patchutils 0.3.4-2
ii  perl [libdigest-sha-perl]  5.28.0-3
ii  t1utils1.41-2
ii  xz-utils   5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b5

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.19.2
ii  libhtml-parser-perl3.72-3+b3
ii  libtext-template-perl  1.53-1

-- no debconf information
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.112

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 913...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb  (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Format: 1.8
Date: Thu, 08 Nov 2018 22:29:31 +
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.112
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers 
Changed-By: Chris Lamb 
Description:
 lintian- Debian package checker
Closes: 912292 912330 913078 913099
Changes:
 lintian (2.5.112) unstable; urgency=medium
 .
   * Summary of tag changes:
 + Added:
   - public-upstream-key-in-na

Bug#912330: marked as done (lintian: Command 'dpkg-architecture' not found in /usr/local/sbin, [..])

2018-11-08 Thread Debian Bug Tracking System

Your message dated Thu, 08 Nov 2018 23:35:30 +
with message-id 
and subject line Bug#912330: fixed in lintian 2.5.112
has caused the Debian Bug report #912330,
regarding lintian: Command 'dpkg-architecture' not found in /usr/local/sbin, 
[..]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
912330: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912330
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.111
Severity: important
X-Debbugs-CC: Felix Lechner 

Hi,

Refiling from:

  
https://salsa.debian.org/lintian/lintian/commit/ccb387b450e732b0df1a63430dd75a26e9d4efc8#note_49947

§
  
With this change dpkg-dev should be moved from suggests to depends
I think. Otherwise:

Command 'dpkg-architecture' not found in /usr/local/sbin, /usr/local/bin, 
/usr/sbin, /usr/bin, /sbin, /bin at /usr/share/perl5/Lintian/Command.pm line 
274.
 at /usr/share/lintian/checks/fields.pm line 387.

internal error: cannot run fields check on package 
source:samba/2:4.9.1+dfsg-2
warning: skipping check of source:samba/2:4.9.1+dfsg-2

(then lintian returns exit code 1. See
https://salsa.debian.org/samba-team/samba/-/jobs/65704)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.112

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 912...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb  (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Format: 1.8
Date: Thu, 08 Nov 2018 22:29:31 +
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.112
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers 
Changed-By: Chris Lamb 
Description:
 lintian- Debian package checker
Closes: 912292 912330 913078 913099
Changes:
 lintian (2.5.112) unstable; urgency=medium
 .
   * Summary of tag changes:
 + Added:
   - public-upstream-key-in-native-package
   - public-upstream-key-not-minimal
   - public-upstream-key-unusable
   - public-upstream-keys-in-multiple-locations
   - systemd-service-file-pidfile-refers-to-var-run
 .
   * checks/cruft.desc:
 + [CL] Bump the severity of the source-contains-prebuilt-windows-binary
   tag from "P:" to "W:" and update the description to mention that this
   could potentially be a DFSG violation.
   * checks/systemd.{desc,pm}:
 + [CL] Warn if a PIDFile entry in a .service unit references /var/run.
   (Closes: #913078)
   * checks/upstream-signing-key.{desc,pm}:
 + [CL] Apply a patch series from Felix Lechner to add multiple tests
   for upstream GPG keys.  Thanks!  (MR: !62)
 .
   * data/java/constants:
 + [CL] Apply patches from Bas Couwenberg to update the bytecode checks
   for OpenJDK 11.  (Closes: #912292)
   * data/rules/rules-should-not-use:
 + [CL] Ensure --dbgsym-migration='quoted with spaces' is correctly
   displayed when emitting debug-symbol-migration-possibly-complete.
   * data/spelling/corrections:
 + [PW] Add a number of corrections.
 .
   * debian/control:
 + [CL] Apply a patch from Mathieu Parent to add a dependency on
   dpkg-dev to ensure dpkg-architecture is available.  Thanks!
   (Closes: #912330)
 .
   * t/*:
 + [CL] Apply a patch from Adam Conrad to fix two tests on non-amd64
   architectures in Ubuntu.  Thanks!  (Closes: #913099)
 + [CL] Apply a patch series Felix Lechner to parameterise the source
   format in all applicable tests.  (MR: !64)
 + [CL] Apply a patch series from Felix Lechner to parameterise the
   package architecture for all tests that build only single binary
   package.  (MR: !68)
   * t/tests/basic-non-native-with-epoch/desc:
 + [CL] Apply a patch from Felix Lechner to correct a test "Type" field.
   (MR: !63)
   * t/tests/watch-file-pgpmode-next/*:
 + [CL] Apply a patch series from Felix Le

Bug#912292: marked as done (lintian: Update Java bytecode checks for openjdk-11)

2018-11-08 Thread Debian Bug Tracking System

Your message dated Thu, 08 Nov 2018 23:35:30 +
with message-id 
and subject line Bug#912292: fixed in lintian 2.5.112
has caused the Debian Bug report #912292,
regarding lintian: Update Java bytecode checks for openjdk-11
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
912292: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912292
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: lintian
Version: 2.5.110
Severity: normal
Tags: patch

Dear Maintainer,

Now that openjdk-11 is the default JDK & JRE in unstable, the Java
bytecode checks in lintian need to be updated again, as per the attached
patch.

Note that the bytecode version for the upcoming Java12 is assumed to be
56, but this may not be the case. max-bytecode-existing-version has not
been incremented because of that.

Kind Regards,

Bas
>From 7d25cdc4c055b0c06962e8cc23a5ac0f8f4c7702 Mon Sep 17 00:00:00 2001
From: Bas Couwenberg 
Date: Mon, 29 Oct 2018 22:21:53 +0100
Subject: Update Java bytecode checks for openjdk-11.

---
 checks/java.desc  | 2 +-
 checks/java.pm| 3 ++-
 data/java/constants   | 7 ---
 t/tests/java-class-format/debian/debian/rules | 4 ++--
 t/tests/java-class-format/tags| 2 +-
 5 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/checks/java.desc b/checks/java.desc
index 78e7e03f2..db1c491f0 100644
--- a/checks/java.desc
+++ b/checks/java.desc
@@ -91,7 +91,7 @@ Info: The package contains a Jar file with Java class files 
compiled for an
  for a newer version of Java than Lintian knows about.  In the latter case,
  please file a bug against Lintian.
  .
- The latest class version known by Lintian is Java10 (Major version 54).
+ The latest class version known by Lintian is Java11 (Major version 55).
 
 Tag: zip-parse-error
 Severity: normal
diff --git a/checks/java.pm b/checks/java.pm
index 1c2c97598..19e670fab 100644
--- a/checks/java.pm
+++ b/checks/java.pm
@@ -98,7 +98,7 @@ sub run {
 or $mver
 > $MAX_BYTECODE->value('max-bytecode-existing-version')) {
 # First public major version was 45 (Java1), latest
-# version is 54 (Java10).
+# version is 55 (Java11).
 tag 'unknown-java-class-version', $jar_file,
   "($class -> $mver)";
 # Skip the rest of this Jar.
@@ -215,6 +215,7 @@ sub run {
 # 52 -> Java8
 # 53 -> Java9
 # 54 -> Java10
+# 55 -> Java11
 my $bad = 0;
 
 # If the lowest version used is greater than the requested
diff --git a/data/java/constants b/data/java/constants
index b08e0cfd4..ebb45af62 100644
--- a/data/java/constants
+++ b/data/java/constants
@@ -6,9 +6,10 @@
 # 51 -> Java7
 # 52 -> Java8
 # 53 -> Java9
-# 54 -> Java10 - Current max version in Debian unstable
-# 55 -> Java11
-max-bytecode-version = 54
+# 54 -> Java10
+# 55 -> Java11 - Current max version in Debian unstable
+# 56 -> Java12
+max-bytecode-version = 55
 
 max-bytecode-existing-version = 55
 
diff --git a/t/tests/java-class-format/debian/debian/rules 
b/t/tests/java-class-format/debian/debian/rules
index b79c40c78..59235963f 100755
--- a/t/tests/java-class-format/debian/debian/rules
+++ b/t/tests/java-class-format/debian/debian/rules
@@ -7,8 +7,8 @@ override_jh_build:
unzip test.jar
# Unknown class version
perl -i -pe 's/^(\xCA\xFE\xBA\xBE...)./$$1\x2A/' 
org/debian/lintian/TestA.class
-   # Java11 (unsupported)
-   perl -i -pe 's/^(\xCA\xFE\xBA\xBE...)./$$1\x37/' 
org/debian/lintian/TestB.class
+   # Java12 (unsupported)
+   perl -i -pe 's/^(\xCA\xFE\xBA\xBE...)./$$1\x38/' 
org/debian/lintian/TestB.class
# Put them in separate Jars because Lintian stops when the first
# "unknown class format" is seen
zip -r testa.jar META-INF/ org/debian/lintian/TestA.class
diff --git a/t/tests/java-class-format/tags b/t/tests/java-class-format/tags
index 588eb01c0..aa21ea634 100644
--- a/t/tests/java-class-format/tags
+++ b/t/tests/java-class-format/tags
@@ -1,2 +1,2 @@
-W: libtest-java: incompatible-java-bytecode-format Java11 version (Class 
format: 55)
+W: libtest-java: incompatible-java-bytecode-format Java12 version (Class 
format: 56)
 W: libtest-java: unknown-java-class-version usr/share/java/testa-1.0.jar 
(org/debian/lintian/TestA.class -> 42)
-- 
2.11.0

--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.112

Processing of lintian_2.5.112_amd64.changes

2018-11-08 Thread Debian FTP Masters

lintian_2.5.112_amd64.changes uploaded successfully to localhost
along with the files:
  lintian_2.5.112.dsc
  lintian_2.5.112.tar.xz
  lintian_2.5.112_all.deb
  lintian_2.5.112_amd64.buildinfo

Greetings,

Your Debian queue daemon (running on host usper.debian.org)

Bug#913099: Thank you

2018-11-08 Thread Felix Lechner

Hi,

Thank you for sending the patch. We adopted all your changes except
for the architecture restriction on 'files-multiarch-foreign-files'.
(The issue may not be related to #886163.) Instead, the previous
behavior should be restored with this commit:

https://salsa.debian.org/lintian/lintian/commit/1b886506df601e2235a7ba0b9ab80e5ee0e8889d#756caf68255acd27da6501c989bfd38778f890e0_5_5

Thank you!

Kind regards,
Felix Lechner

Bug#913099: lintian: autopkgtests fail on !(amd64)

2018-11-08 Thread Chris Lamb

tags 913099 + pending
thanks

Merged https://salsa.debian.org/lintian/lintian/merge_requests/71
into Git, pending upload:

  
https://salsa.debian.org/lintian/lintian/commit/4326d7d416d482bbda7ae550097b2e2ac297d416

  debian/changelog  | 2 ++
  t/tests/binaries-missing-lfs/debian/debian/compat | 1 +
  t/tests/binaries-missing-lfs/desc | 4 +++-
  t/tests/binaries-missing-lfs/tags | 1 +
  t/tests/shared-libs-non-pic-i386/debian/debian/compat | 1 +
  t/tests/shared-libs-non-pic-i386/desc | 4 +++-
  t/tests/shared-libs-non-pic-i386/tags | 1 +
  7 files changed, 12 insertions(+), 2 deletions(-)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Processed: Re: lintian: autopkgtests fail on !(amd64)

2018-11-08 Thread Debian Bug Tracking System

Processing commands for cont...@bugs.debian.org:

> tags 913099 + pending
Bug #913099 [lintian] lintian: autopkgtests fail on !(amd64)
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
913099: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913099
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#912912: marked as done (lintian: please detect for loops without set -e)

2018-11-08 Thread Debian Bug Tracking System

Your message dated Thu, 8 Nov 2018 19:18:33 +0100
with message-id <20181108181832.gq2...@mapreri.org>
and subject line Re: Bug#912912: lintian: please detect for loops without set -e
has caused the Debian Bug report #912912,
regarding lintian: please detect for loops without set -e
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)

-- 
912912: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912912
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Severity: wishlist

See #912910 - I think these situations could easily be detected by
lintian, and marked with an E-tag when d/rules doesn't.

Reference: Policy §4.6

bad bad bad:
for var in $(things_to_to_loop_on); do \
$(whatever); \
done

"good":
set -e ; for var in $(things_to_to_loop_on); do \
$(whatever); \
done

Note however that the set -e could be omitted if one has

SHELL=sh -e

or

.SHELLFLAGS=-ec

or similar (even if *personally* I find using such means somewhat
obscure).

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
On Sun, Nov 04, 2018 at 05:41:51PM -0500, Chris Lamb wrote:
> Not wishing to play severity wars but I think E-tag would be a
> little aggressive for such a tag,

The E was mostly because it's a fairly important bug, potentially RC
that could cause quite some headaches while debugging, that was the
logic behind my suggestion.

> but I  worry we would expect a
> large number of false-positives. For example:
> 
>  for var in $(things_to_to_loop_on); do \
>  $(whatever) || exit $?; \
>  done
> 
> I mean, this exact code exists in disorderfs (albeit in tests/
> Makefile, not debian/rules).

Helmut did told me the same things…

> > Note however that the set -e could be omitted if one has
>  
> Detecting SHELL=sh -e and .SHELLFLAGS=-ec reliably too would only
> complicate such things.

TBH, I mostly hoped that in the time you have been maintaining lintian
you figured a why to reduce such false positives, but I understand
statically parsing makefiles is not exactly simple and accurate...

> Could you perhaps run some codesearch.debian.net queries to see
> what kind of false-positives we could expect? There will definitely
> be some, but if it's above "some" threshold I think this might be
> beyond Lintian's reach, alas.

I haven't done such search, but for now I'll just close this report.
Thanks for reading it nonetheless!

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

signature.asc
Description: PGP signature
--- End Message ---

Bug#913290: lintian: Incorrectly reports invalid-template-id-in-symbols-file/syntax-error-in-symbols-file for certain symbols files

Bug#913280: lintian: please warn about packages including files in /usr/share/hal/ (used by obsolete hal package)

lintian_2.5.112_amd64.changes ACCEPTED into unstable

Bug#913078: marked as done (Please warn if PIDFile in a .service unit contains /var/run)

Bug#912330: marked as done (lintian: Command 'dpkg-architecture' not found in /usr/local/sbin, [..])

Bug#912292: marked as done (lintian: Update Java bytecode checks for openjdk-11)

Processing of lintian_2.5.112_amd64.changes

Bug#913099: Thank you

Bug#913099: lintian: autopkgtests fail on !(amd64)

Processed: Re: lintian: autopkgtests fail on !(amd64)

Bug#912912: marked as done (lintian: please detect for loops without set -e)

11 matches

Site Navigation

Mail list logo

Footer information