Bug#932862: lintian: check for autopkgtests that do cmd --version/--help but don't have Restrictions: superficial

[Paul Wise]

Control: tags -1 - moreinfo

On Wed, 2019-07-24 at 11:25 -0300, Chris Lamb wrote:

> Thanks for this idea and for mentioning the "superficial" Restriction;
> I was not aware of that. I guess my question at this point is how you
> see this interacting, if at all, with the: no-op-testsuite tag?

I would say that superficial tests do provide a small amount of test
coverage (command-line parsing and options processing), while no-op
commands do not test the package in any way. So superficial tests do
provide a small amount of value. I think that this case is distinct
enough from autopkgtests testing /bin/true that it should be a separate
tag, mainly so that the two issues can be of different severity and
have different explanatory text. Personally I'd promote no-op-testsuite
 to error (and autoreject such packages) and use warning for this one.

> They are, of course, reporting on different things but they
> would somewhat overlap in intention and perhaps merging them might be
> worth considering, or perhaps separating them out even further.

I think that what we can surmise about the intent of the people
creating these errors and thus the lintian info text associated with
these tags is going to be different enough to warrant separation. For
example no-op-testsuite is at best naivety and at worst intentionally
taking advantage of the reduced testing migration delay, while the
superficial tests can either be a precursor to deeper testing or just
the best one can do for some packages.

For example a set of packages I maintain for Discord support can only
be tested by humans since testing them would require a machine to pass
reCAPTCHA, register two accounts, send messages between them and then
delete the accounts. Even if the first requirement were feasible,
testing like this is probably constitutes abuse of the Discord service.
So superficial testing is the best that can be automatically done.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise



signature.asc
Description: This is a digitally signed message part

Processed: Re: Bug#932862: lintian: check for autopkgtests that do cmd --version/--help but don't have Restrictions: superficial

[Debian Bug Tracking System]

Processing control commands:

> tags -1 - moreinfo
Bug #932862 [lintian] lintian: check for autopkgtests that do cmd 
--version/--help but don't have Restrictions: superficial
Removed tag(s) moreinfo.

-- 
932862: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932862
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Re: Bug#932870: lintian: check that there are some autopkgtests that don't have Restrictions: superficial

[Debian Bug Tracking System]

Processing control commands:

> tags -1 - moreinfo
Bug #932870 [lintian] lintian: check that there are some autopkgtests that 
don't have Restrictions: superficial
Removed tag(s) moreinfo.

-- 
932870: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932870
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#932870: lintian: check that there are some autopkgtests that don't have Restrictions: superficial

[Paul Wise]

Control: tags -1 - moreinfo

On Wed, 2019-07-24 at 11:26 -0300, Chris Lamb wrote:

> Parallel to my comment on #932862, what would you say to simply also
> emitting testsuite-autopkgtest-missing in this case (and naturally
> updating the description, etc).

I would say that superficial tests do provide a small amount of test
coverage (command-line parsing and options processing) so they do
provide some value, so I think that this case is distinct enough from
autopkgtests being entirely missing that it should be a separate tag.
In addition I think this superficial-only-tests tag should be of a
different severity to testsuite-autopkgtest-missing, perhaps raised to
info or warning level instead of pedantic.

> What I really mean to say is that I wonder whether we should zoom out
> a bit and get a good picture about what we want in this area without
> any duplicative code or effort. :)

I agree that we should zoom out and get a more global view of the
problems that could potentially arise in autopkgtests. This is my first
foray into autopkgtest QA and so it is the first thing I ran into.

I came into it through the uhubctl RC bug, which reports failure of a
test that runs `uhubctl -v` via a script, rather than from the
debian/tests/control file. I think unless lintian folks want to write
some Haskell based on shellcheck or OCaml based on morbig (see Ralf's
talks in recent DebConfs about shell script parsing), lintian will
never be able to detect the uhubctl case as superficial.

As a result I prepared an item for Misc Dev News asking people to tag
their tests and to write some non-superficial tests:

https://wiki.debian.org/DeveloperNews?action=diff=608=609

-- 
bye,
pabs

https://wiki.debian.org/PaulWise



signature.asc
Description: This is a digitally signed message part

Bug#930487: lintian: use GitLab caching of test packages to speed up test suite CI

[Georg Faerber]

Hi,

I'm not sure if the following is of help, as I didn't saw the involved
code, but:

On 19-07-20 17:28:56, Chris Lamb wrote:
> I have something working except that I am running into a blocker
> whereby the GitLab cache is not seen in subsequent runs.
> 
> For example, the cache is being stored at the end of the test package
> build stage:
> 
> Creating cache default-2...
> .cache/: found 2 matching files
> No URL provided, cache will be not uploaded to shared cache server. Cache 
> will be stored only locally. 
> Created cache
> 
> … but it is not seen when you re-run that same pipeline:
> 
> Checking cache for default-2...
> No URL provided, cache will not be downloaded from shared cache server. 
> Instead a local version of cache will be extracted. 
> Successfully extracted cache
> 
> $ ls -l .cache || true
> ls: cannot access '.cache': No such file or directory
> 
> I will try and hunt down a Salsa admin during DebConf. This might be
> due to the use of shared runners and us not using a centralised cache.

An alternative might be to use artifacts [1], which work as expected on
Salsa.

Cheers,
Georg


[1] https://docs.gitlab.com/ee/user/project/pipelines/job_artifacts.html


signature.asc
Description: PGP signature

Jenkins build is back to normal : lintian-tests_sid #3825

[jenkins]

See 

Build failed in Jenkins: lintian-tests_sid #3824

[jenkins]

See 

--
[...truncated 425.52 KB...]
debian/test-out/tags/checks/scripts/scripts-interpreters/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-missing-call-to-dpkg-maintscript-helper/generic.t
 . ok
debian/test-out/tags/checks/scripts/scripts-maintainer-script-empty/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-maintainer-general/generic.t 
.. ok
debian/test-out/tags/checks/scripts/scripts-killall/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-maintainer-script-invalid-update-inetd-options/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-maintainer-script-set-e/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-missing-call-to-update-fonts-unrel/generic.t
 .. ok
debian/test-out/tags/checks/shared-libs/binaries-missing-lfs/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/scripts/scripts-missing-call-to-update-fonts/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-missing-dep-fp/generic.t 
.. ok
debian/test-out/tags/checks/scripts/scripts-missing-versioned-depends-on-init-system-helpers/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-multi-arch-same-calls-pycompile/generic.t
 . ok
debian/test-out/tags/checks/scripts/scripts-ocamlrun/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-supports-ancient-package-version/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard-unrel/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-missing-dep/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-skip-systemd-native/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-with-dep/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-unconditional-use-of-dpkg-statoverride/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard/generic.t
  ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-without-dep/generic.t
 . ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends-on-libc/generic.t
  ok
debian/test-out/tags/checks/shared-libs/files-wrong-ma-foreign/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch-same/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/files-pkgconfig/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/binaries-doesnt-match-sonames/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/legacy-libbaz/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-non-pic-i386/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/shared-libs/legacy-debug/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/legacy-debconf/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/legacy-maintainer-scripts/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink-fp/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/shared-libs-la-files/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-bit/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-stack/generic.t 

Build failed in Jenkins: lintian-tests_sid #3823

[jenkins]

See 


Changes:

[lamby] Update tests for change of severity levels.

--
[...truncated 425.28 KB...]
debian/test-out/tags/checks/scripts/scripts-interpreters-nodejs/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-exec/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-maintainer-script-set-e/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-maintainer-script-invalid-update-inetd-options/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-missing-call-to-update-fonts-unrel/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-missing-call-to-dpkg-maintscript-helper/generic.t
 . ok
debian/test-out/tags/checks/scripts/scripts-maintainer-script-empty/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-maintainer-general/generic.t 
.. ok
debian/test-out/tags/checks/scripts/scripts-missing-call-to-update-fonts/generic.t
  ok
debian/test-out/tags/checks/shared-libs/binaries-missing-lfs/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/scripts/scripts-missing-dep-fp/generic.t 
.. ok
debian/test-out/tags/checks/scripts/scripts-missing-versioned-depends-on-init-system-helpers/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-multi-arch-same-calls-pycompile/generic.t
 . ok
debian/test-out/tags/checks/scripts/scripts-ocamlrun/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-supports-ancient-package-version/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-skip-systemd-native/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard-unrel/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-with-dep/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-unconditional-use-of-dpkg-statoverride/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-missing-dep/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends-on-libc/generic.t
  ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-without-dep/generic.t
 . ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch-same/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/binaries-doesnt-match-sonames/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/files-pkgconfig/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/files-wrong-ma-foreign/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/legacy-debug/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-non-pic-i386/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink-fp/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/legacy-maintainer-scripts/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-bit/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/legacy-debconf/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-stack/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/legacy-libbaz/generic.t 
... ok

Build failed in Jenkins: lintian-tests_sid #3822

[jenkins]

See 


Changes:

[lamby] Correct private/generate-tag-summary to point to the new path for tag 
description files.

--
[...truncated 427.15 KB...]
debian/test-out/tags/checks/scripts/scripts-interpreters/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/binaries-missing-lfs/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/scripts/scripts-missing-call-to-update-fonts/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-maintainer-general/generic.t 
.. ok
debian/test-out/tags/checks/scripts/scripts-missing-dep-fp/generic.t 
.. ok
debian/test-out/tags/checks/scripts/scripts-supports-ancient-package-version/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-missing-versioned-depends-on-init-system-helpers/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-ocamlrun/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-multi-arch-same-calls-pycompile/generic.t
 . ok
debian/test-out/tags/checks/scripts/scripts-unconditional-use-of-dpkg-statoverride/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-skip-systemd-native/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard-unrel/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-missing-dep/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-with-dep/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends-on-libc/generic.t
  ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-without-dep/generic.t
 . ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch-same/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/files-wrong-ma-foreign/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/files-pkgconfig/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/binaries-doesnt-match-sonames/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-non-pic-i386/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/shared-libs/legacy-debug/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink-fp/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/legacy-libbaz/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/legacy-maintainer-scripts/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/legacy-debconf/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/shared-libs-control-file/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-ldconfig-not-symlink/generic.t
  ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-bit/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-exit/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-exit-fork/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-stack/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/shared-libs-la-files/generic.t 
 ok

Build failed in Jenkins: lintian-tests_sid #3821

[jenkins]

See 


Changes:

[lamby] Also ship the 'tags' directory under /usr/share/lintian.

--
[...truncated 427.12 KB...]
debian/test-out/tags/checks/scripts/scripts-missing-call-to-update-fonts/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-maintainer-general/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/binaries-missing-lfs/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/scripts/scripts-missing-dep-fp/generic.t 
.. ok
debian/test-out/tags/checks/scripts/scripts-missing-call-to-update-fonts-unrel/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-missing-versioned-depends-on-init-system-helpers/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-ocamlrun/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-multi-arch-same-calls-pycompile/generic.t
 . ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard-unrel/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-skip-systemd-native/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-supports-ancient-package-version/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-unconditional-use-of-dpkg-statoverride/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-missing-dep/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-with-dep/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-without-dep/generic.t
 . ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends-on-libc/generic.t
  ok
debian/test-out/tags/checks/shared-libs/files-pkgconfig/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch-same/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/files-wrong-ma-foreign/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/binaries-doesnt-match-sonames/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink-fp/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/shared-libs-non-pic-i386/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/shared-libs/legacy-maintainer-scripts/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/legacy-debug/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/legacy-debconf/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/legacy-libbaz/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-control-file/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-bit/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-la-files/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-stack/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/shared-libs-exit-fork/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-exit/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-ldconfig-not-symlink/generic.t
  ok
debian/test-out/tags/checks/shared-libs/shared-libs-ldconfig-wrong-file/generic.t
 

Build failed in Jenkins: lintian-tests_sid #3820

[jenkins]

See 


Changes:

[lamby] Downgrade command-in-sbin-has-manpage-in-incorrect-section to pedantic 
severity for the time being. (Closes: #570998)

[lamby] Downgrade severity/certainty of 
package-supports-alternative-init-but-no-init.d-script for the time being. 
(Closes: #931889)

--
[...truncated 427.08 KB...]
debian/test-out/tags/checks/scripts/scripts-maintainer-script-invalid-update-inetd-options/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-missing-call-to-update-fonts/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-missing-call-to-update-fonts-unrel/generic.t
 .. ok
debian/test-out/tags/checks/shared-libs/binaries-missing-lfs/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/scripts/scripts-missing-dep-fp/generic.t 
.. ok
debian/test-out/tags/checks/scripts/scripts-missing-versioned-depends-on-init-system-helpers/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-ocamlrun/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-multi-arch-same-calls-pycompile/generic.t
 . ok
debian/test-out/tags/checks/scripts/scripts-skip-systemd-native/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-supports-ancient-package-version/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard/generic.t
  ok
debian/test-out/tags/checks/scripts/scripts-udevadm-called-without-guard-unrel/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-unconditional-use-of-dpkg-statoverride/generic.t
 .. ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-with-dep/generic.t 
 ok
debian/test-out/tags/checks/scripts/scripts-missing-dep/generic.t 
. ok
debian/test-out/tags/checks/scripts/scripts-uses-perl4-libs-without-dep/generic.t
 . ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/binaries-missing-depends-on-libc/generic.t
  ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch-same/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/binaries-multiarch/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/files-wrong-ma-foreign/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/files-pkgconfig/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/binaries-doesnt-match-sonames/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/legacy-debug/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-non-pic-i386/generic.t 
 skipped: Architecture mismatch
debian/test-out/tags/checks/shared-libs/legacy-libbaz/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/legacy-debconf/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/legacy-maintainer-scripts/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink-fp/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/shared-libs-dev-symlink/generic.t 
. ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-bit/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-la-files/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-exec-stack/generic.t 
.. ok
debian/test-out/tags/checks/shared-libs/shared-libs-exit-fork/generic.t 
... ok
debian/test-out/tags/checks/shared-libs/shared-libs-control-file/generic.t 
 ok
debian/test-out/tags/checks/shared-libs/shared-libs-exit/generic.t 
 ok

Build failed in Jenkins: lintian-tests_sid #3819

[jenkins]

See 

--
[...truncated 248.79 KB...]
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Test/Lintian.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Relation.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Relation.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Lab.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Lab.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Tag/Override.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Tag/Override.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Check.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Check.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "lib/Lintian/Util.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   lib/Lintian/Util.pm:1:1:Code is not tidy
t/scripts/01-critic/lib.t .. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 7/44 subtests 
t/scripts/Lintian/Lab/repair.t . ok
t/scripts/Lintian/Lab/auto-repair.t  ok
t/scripts/Lintian/Relation/04-multiarch.t .. ok
t/scripts/Lintian/Util/parse_bool.t  ok

#   Failed test 'Test::Perl::Critic for "checks/scripts.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   checks/scripts.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "checks/binaries.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   checks/binaries.pm:1:1:Code is not tidy
t/scripts/Lintian/Util/path.t .. ok

#   Failed test 'Test::Perl::Critic for "t/scripts/needs-info-missing.t"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   t/scripts/needs-info-missing.t:1:1:Code is not tidy
t/scripts/01-critic/test-scripts.t . 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 2/78 subtests 

#   Failed test 'Test::Perl::Critic for "checks/changelog-file.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   checks/changelog-file.pm:1:1:Code is not tidy
t/scripts/Lintian/Relation/07-implies.t  ok

#   Failed test 'Test::Perl::Critic for "checks/fields.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   checks/fields.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "checks/cruft.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   checks/cruft.pm:1:1:Code is not tidy

#   Failed test 'Test::Perl::Critic for "checks/files.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 121.
# 
#   checks/files.pm:1:1:Code is not tidy
t/scripts/01-critic/checks.t ... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 35/57 subtests 
t/scripts/static-lab.t . ok
t/scripts/profile-load.t ... ok
t/scripts/needs-info-exists.t .. ok
t/scripts/spellintian.t  ok
t/scripts/02-minimum-version/commands.t  ok
t/scripts/version.t  ok
t/scripts/pod-coverage.t ... ok
t/scripts/pod-synopsis.t ... ok
t/scripts/pod.t  ok
t/scripts/implemented-tags.t ... ok
t/scripts/unpack-level.t ... ok
t/scripts/needs-info-missing.t . ok
t/scripts/check-load.t . ok
t/scripts/03-strict/lib.t .. ok
t/scripts/changelog-format.t ... ok
t/scripts/profiles-coverage.t .. ok
t/scripts/02-minimum-version/test-scripts.t  ok
t/scripts/pod-spelling.t ... ok
t/scripts/check-descs.t  ok
t/scripts/03-strict/checks.t ... ok
t/scripts/03-strict/test-scripts.t . ok
t/scripts/02-minimum-version/lib.t . ok
t/scripts/02-minimum-version/checks.t .. ok

Test Summary Report
---
t/scripts/01-critic/helpers.t(Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
t/scripts/01-critic/collection.t (Wstat: 256 Tests: 14 Failed: 
4)
  Failed tests:  2, 8, 11-12
  Non-zero exit status: 1
t/scripts/01-critic/commands.t   (Wstat: 256 Tests: 8 Failed: 3)
  Failed tests:  6-8
  Non-zero exit status: 1
t/scripts/01-critic/private.t(Wstat: 256 Tests: 13 Failed: 
2)
  Failed tests:  3, 11
  Non-zero exit status: 1
t/scripts/ancient-sv-date.t  (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
t/scripts/01-critic/lib.t

Processed: Bug#570998 marked as pending in lintian

[Debian Bug Tracking System]

Processing control commands:

> tag -1 pending
Bug #570998 [lintian] lintian: Please check that commands in /{usr/,}sbin do 
not use section 1 manpages
Added tag(s) pending.

-- 
570998: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=570998
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Bug#931889 marked as pending in lintian

[Debian Bug Tracking System]

Processing control commands:

> tag -1 pending
Bug #931889 [lintian] Bogus 
package-supports-alternative-init-but-no-init.d-script test?
Bug #931847 [lintian] Bogus 
package-supports-alternative-init-but-no-init.d-script test?
Added tag(s) pending.
Added tag(s) pending.

-- 
931847: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931847
931889: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931889
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Re: lintian: Please check that commands in /{usr/, }sbin do not use section 1 manpages

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> found 570998 2.16.0
Bug #570998 {Done: Chris Lamb } [lintian] lintian: Please 
check that commands in /{usr/,}sbin do not use section 1 manpages
Marked as found in versions lintian/2.16.0; no longer marked as fixed in 
versions lintian/2.16.0 and reopened.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
570998: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=570998
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Processed: Re: Bug#932634: lintian: false-positive embedded-library libyaml due to matching string (defined in data/binaries/embedded-libs) with package rust-yaml-rust

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 932634 + moreinfo
Bug #932634 [lintian] lintian: false-positive embedded-library libyaml due to 
matching string (defined in data/binaries/embedded-libs) with package 
rust-yaml-rust
Added tag(s) moreinfo.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
932634: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932634
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#932634: lintian: false-positive embedded-library libyaml due to matching string (defined in data/binaries/embedded-libs) with package rust-yaml-rust

[Chris Lamb]

tags 932634 + moreinfo
thanks

Hi Helen,

> In lintian/data/binaries/embedded-libs, the criterium to detect if a
> library was linked statically against libyaml is to verify the string:
> 
> libyaml   ||(?m)^did not find expected 
> 
> But this string is also found in package rust-yaml-rust.

Indeed. So, I not sure how Lintian is meant to "know" that this is
from the Rust version of YAML over the libyaml version. If bat was
called, say, "rust-bat" instead then we could use embedded-libs's
ability to filter via a regular expression, but that is alas not the
case. Any ideas...?


Best wishes,,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-

Utica

[alessandro bacher]

Inviato da iPhone

Processed: Re: Bug#932870: lintian: check that there are some autopkgtests that don't have Restrictions: superficial

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 932870 + moreinfo
Bug #932870 [lintian] lintian: check that there are some autopkgtests that 
don't have Restrictions: superficial
Added tag(s) moreinfo.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
932870: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932870
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#932870: lintian: check that there are some autopkgtests that don't have Restrictions: superficial

[Chris Lamb]

tags 932870 + moreinfo
thanks

Hi Paul,

> autopkgtests that have Restrictions: superficial do not provide
> significant test coverage. Please add a tag that is similar to the
> testsuite-autopkgtest-missing tag that is shown when there are no
> autopkgtests that are not marked as superficial.

Parallel to my comment on #932862, what would you say to simply also
emitting testsuite-autopkgtest-missing in this case (and naturally
updating the description, etc).

What I really mean to say is that I wonder whether we should zoom out
a bit and get a good picture about what we want in this area without
any duplicative code or effort. :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-

Bug#932862: lintian: check for autopkgtests that do cmd --version/--help but don't have Restrictions: superficial

[Chris Lamb]

tags 932862 + moreinfo
thanks

Hi Paul,

> A number of packages run cmd --version/--help in their autopkgtests.
> This test doesn't really test the functionality of the command, just of 
> the command-line and options parsing.

Thanks for this idea and for mentioning the "superficial" Restriction;
I was not aware of that. I guess my question at this point is how you
see this interacting, if at all, with the:

  https://lintian.debian.org/tags/no-op-testsuite.html

… tag? They are, of course, reporting on different things but they
would somewhat overlap in intention and perhaps merging them might be
worth considering, or perhaps separating them out even further.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org  chris-lamb.co.uk
   `-

Processed: Re: Bug#932862: lintian: check for autopkgtests that do cmd --version/--help but don't have Restrictions: superficial

[Debian Bug Tracking System]

Processing commands for cont...@bugs.debian.org:

> tags 932862 + moreinfo
Bug #932862 [lintian] lintian: check for autopkgtests that do cmd 
--version/--help but don't have Restrictions: superficial
Added tag(s) moreinfo.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
932862: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=932862
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

lintian_2.16.0~bpo10+1_amd64.changes ACCEPTED into buster-backports, buster-backports

[Debian FTP Masters]

Accepted:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Format: 1.8
Date: Mon, 22 Jul 2019 09:24:11 -0300
Source: lintian
Binary: lintian
Built-For-Profiles: nocheck
Architecture: source all
Version: 2.16.0~bpo10+1
Distribution: buster-backports
Urgency: medium
Maintainer: Debian Lintian Maintainers 
Changed-By: Chris Lamb 
Description:
 lintian- Debian package checker
Closes: 570998 928283 930700 930702 931183 931426 931446 931632 932729
Changes:
 lintian (2.16.0~bpo10+1) buster-backports; urgency=medium
 .
   * Rebuild for buster-backports. (Closes: #932729)
 .
 lintian (2.16.0) unstable; urgency=medium
 .
   The "post-buster" release.
 .
   * Summary of tag changes:
 + Added:
   - bin-sbin-mismatch
   - command-in-sbin-has-manpage-in-incorrect-section
   - directory-in-etc-sv-directory-without-executable-run-script
   - package-supports-alternative-init-but-no-init.d-script
 .
   [ Chris Lamb ]
   * Add 4.4.0 as a known Standards-Version.
   * Post-buster changes:
 - Reflect the release, updating dates (etc.) of "oldstable" and so on.
 - Bump the recommended debhelper level to 12 (see #918809).
 - Bump the old and ancient version numbers for Python 3 checks (see
   #903399).
 - Drop the deprecated --fail-on-warnings option to help towards fixing
   Debian bug #709932.
 - Upgrade package-uses-vendor-specific-patch-series to "E:" level
   severity (see #904302).
   * Warn about files referencing /usr/bin/foo if the binary is actually
 installed under /usr/sbin/foo. (Closes: #930702)
   * Check that a package that ships a /etc/sv/foo directory then
 /etc/sv/foo/run exists and is executable. (Closes: #931426)
   * Support suppress-tags-from-file in Lintian configuration file.
 (Closes: #930700)
   * Don't emit pkg-js-tools-test-is-missing if the "dh" invocation uses
 variables in its arguments. (Closes: #928283)
   * Fix "mistake||correction" delimiter for a number of entries in
 data/spelling/corrections-case. (Closes: #931446)
   * Disable the duplicate word checker when analysing patch files.
 (Closes: #931183)
   * Override dh_dwz in a binaries-general test to avoid testsuite hanging.
 (Closes: #931632)
   * Don't emit latest-debian-changelog-entry-without-new-version for
 uploads to (eg.) buster-security to avoid false-positives when
 performing "no-change" uploads with a ~debXuY suffix.
 .
   [ Felix Lechner ]
   * Bump the minimum perltidy version required to avoid test failures.
   * Add runtime dependency on liblist-compare-perl.
   * Reduce the complexity of code in Lintian::Unpacker.
 .
   [ Dmitry Bogatov ]
   * Check for commands in /sbin or /usr/sbin with manpages in the
 incorrect section. (Closes: #570998)
 .
   [ Adam D. Barratt ]
   * Lintian::Reporting::Util: Add missing import of Exporter::import.
 .
   [ Axel Beckert ]
   * Fix typo in description of debian-watch-does-not-check-gpg-signature.
Checksums-Sha1:
 9b63dc45ddc8ee74d54ded78423676344ff3c44a 3964 lintian_2.16.0~bpo10+1.dsc
 d8272c7013c1f13cdbb94e326a64a3697db3967a 1719576 lintian_2.16.0~bpo10+1.tar.xz
 90ea00aa7c2899a7da39e1e3756a6d14a883d1a7 1188712 lintian_2.16.0~bpo10+1_all.deb
 f82c8a41017e2e23e7bfeb24f921dbea425a3eea 8947 
lintian_2.16.0~bpo10+1_amd64.buildinfo
Checksums-Sha256:
 56360298ec6ab58ee930a41bc7acb99145be0b3c81151a1feffb88e0a1c305d5 3964 
lintian_2.16.0~bpo10+1.dsc
 045ee32001d3723f9642bf1cd40d0b77bcde6bb43c2e25340d7bd069cbdaff18 1719576 
lintian_2.16.0~bpo10+1.tar.xz
 b0819629534d66a5db3cb02f95e6dac57dd65fcee74e4ff3d98e18bbbf3284fe 1188712 
lintian_2.16.0~bpo10+1_all.deb
 ef96c268047aad7192007f6abae2a78cb9f6cc31f4708fe530e0020f31ddce57 8947 
lintian_2.16.0~bpo10+1_amd64.buildinfo
Files:
 a8415f766ecaba53831f913f5543a64d 3964 devel optional lintian_2.16.0~bpo10+1.dsc
 b1e168b76de9f4c85c33c07bb6d94a17 1719576 devel optional 
lintian_2.16.0~bpo10+1.tar.xz
 58f2e2aaf56102ef44e6ee3ab4685803 1188712 devel optional 
lintian_2.16.0~bpo10+1_all.deb
 936a60e96a542d3a2dffaa6153a316f3 8947 devel optional 
lintian_2.16.0~bpo10+1_amd64.buildinfo

-BEGIN PGP SIGNATURE-

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAl01soAACgkQHpU+J9Qx
Hli50RAAhXgi7Xl9WR1JuXpJF0kvx/2g/XDpdInRK7ArAzFq1k5UrWOEpM5dPRIa
tcsDJjqgJrp41MCdd3ufT4srVMymyugHEsho/7VimXZy9XwD4W7THgCCFf5ygfkN
+4Z2KfpQztcvrjTkMONsKere7XDPm7OmUnTFHZFPy87hg+eOwAU19fh9ndIcAbFR
7cvKfBV+BqcMSJnaa1+TcWMOjB6iQuaG5M36+wWPoe8gNuYx5W4R2wrGr9d6zUVY
3yqf1Mz+8qI0eYXaCSxLP45/wiWh3dikgctlvTkAT3dIswpftowt57VaeAN9IGhu
dDK/3nJ3Ftn+KvcuWcxZv2gDtW2tth45grDxdf7KbKR61kg/xpo4UkDO6humlfWV
ZqlaBExCkSIJ5hqwJp780Pp4EyJaCZnD6A5VNhI9OkZpXGqkM0QKu83Ud7gfpwdM
+RfiduCKcmvPouEngBbTciTgIsAIL7wU7pXcADxlUGzm9WjoQESgcDQd3+eiwtcb
EaqPx9PKcrWGbi1i3q8yG+WEekb7ZZ7MS/Cf2Q5DwXESunEZ2e+ZrjaE2fuoq/f4
6Q2wflQwBLsNLOrTMaDkThV5wYR+GvU/pi6W2JILP8aC2easiFXCBY9yqSBw28ij
A6ejmPQ+LZOL9bau5sB+MokMu6YUcv3uhToPkWNtQ4o/luqVbPs=
=hQrj
-END PGP SIGNATURE-


Thank you for your contribution to Debian.