Bug#1029479: lintian: reject packages with debmake default description
Package: lintian Severity: wishlist X-Debbugs-CC: ftp-master yq was just accepted into Debian with a completely bogus description that is the default from the debmake automatic package generator. Please add a lintian tag and add it to the ftp-master auto-rejects. $ apt-cache show yq | grep-dctrl -s Description-en . Description-en: auto-generated package by debmake This Debian binary package was auto-generated by the debmake(1) command provided by the debmake package. $ dgrep -A5 'auto-generated' debmake /usr/lib/python3/dist-packages/debmake/control.py:desc = "auto-generated package by debmake" /usr/lib/python3/dist-packages/debmake/control.py-# /usr/lib/python3/dist-packages/debmake/control.py-if para["desc_long"].rstrip(): /usr/lib/python3/dist-packages/debmake/control.py-desc_long = para["desc_long"].rstrip() /usr/lib/python3/dist-packages/debmake/control.py-elif para["desc"].strip(): /usr/lib/python3/dist-packages/debmake/control.py-desc_long = " " + para["desc"].strip() -- /usr/lib/python3/dist-packages/debmake/para.py:help="pedantically check auto-generated files", /usr/lib/python3/dist-packages/debmake/para.py-) /usr/lib/python3/dist-packages/debmake/para.py-p.add_argument( /usr/lib/python3/dist-packages/debmake/para.py-"-T", /usr/lib/python3/dist-packages/debmake/para.py-"--tutorial", /usr/lib/python3/dist-packages/debmake/para.py-action="store_true", -- /usr/share/debmake/extra0desc_long/_long: This Debian binary package was auto-generated by the /usr/share/debmake/extra0desc_long/_long- debmake(1) command provided by the debmake package. -- /usr/share/debmake/extra0desc_long/_long_tutorial: This Debian binary package was auto-generated by the /usr/share/debmake/extra0desc_long/_long_tutorial- debmake(1) command provided by the debmake package. /usr/share/debmake/extra0desc_long/_long_tutorial- . /usr/share/debmake/extra0desc_long/_long_tutorial- = This comes from the unmodified template file = /usr/share/debmake/extra0desc_long/_long_tutorial- . /usr/share/debmake/extra0desc_long/_long_tutorial- Please edit this template file (debian/control) and other package files -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Processed: Bug#1029177 marked as pending in lintian
Processing control commands: > tag -1 pending Bug #1029177 [lintian] lintian: Update Lintian User's Manual wrt. to Pointed Hints format Ignoring request to alter tags of bug #1029177 to the same tags previously set -- 1029177: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029177 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug#1027744 marked as pending in lintian
Processing control commands: > tag -1 pending Bug #1027744 [lintian] spare-manual-page triggers for binaries in /usr/libexec Ignoring request to alter tags of bug #1027744 to the same tags previously set -- 1027744: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027744 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug#1014885 marked as pending in lintian
Processing control commands: > tag -1 pending Bug #1014885 [lintian] Conflict: unknown-field Go-Import-Path x missing-xs-go-import-path-for-golang-package Ignoring request to alter tags of bug #1014885 to the same tags previously set -- 1014885: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014885 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: Bug#1029055 marked as pending in lintian
Processing control commands: > tag -1 pending Bug #1029055 [lintian] lintian: Lintian does not recognize the AppStream's metainfo.xml MIT license is the same as Debian's Expat license Ignoring request to alter tags of bug #1029055 to the same tags previously set -- 1029055: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029055 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: tagging 1027744
Processing commands for cont...@bugs.debian.org: > tags 1027744 + pending Bug #1027744 [lintian] spare-manual-page triggers for binaries in /usr/libexec Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 1027744: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027744 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: retitle 1029470 to lintian: Needs to distinguish between valid field names for .dsc files and for debian/control files (with vs without "XS-" prefix) ...
Processing commands for cont...@bugs.debian.org: > # Fixup botched control headers in > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029471#15 > retitle 1029470 lintian: Needs to distinguish between valid field names for > .dsc files and for debian/control files (with vs without "XS-" prefix) Bug #1029470 [lintian] Conflict: unknown-field Go-Import-Path x missing-xs-go-import-path-for-golang-package Changed Bug title to 'lintian: Needs to distinguish between valid field names for .dsc files and for debian/control files (with vs without "XS-" prefix)' from 'Conflict: unknown-field Go-Import-Path x missing-xs-go-import-path-for-golang-package'. > tags 1029470 + help Bug #1029470 [lintian] lintian: Needs to distinguish between valid field names for .dsc files and for debian/control files (with vs without "XS-" prefix) Added tag(s) help. > thanks Stopping processing here. Please contact me if you need assistance. -- 1029470: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029470 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed (with 2 errors): Re: Bug#1014885: lintian wrongly complains about XS-Go-Import-Path
Processing control commands:
> clone -1 2
Bug #1014885 [lintian] Conflict: unknown-field Go-Import-Path x
missing-xs-go-import-path-for-golang-package
Bug 1014885 cloned as bug 1029470
> retitle -2 lintian: Needs to distinguish between valid field names for .dsc
> files and for debian/control files (with vs without "XS-" prefix)
Failed to set the title of -2: The 'bug' parameter ("-2") to
Debbugs::Control::set_title did not pass regex check
.
> tag -1 + pending
Bug #1014885 [lintian] Conflict: unknown-field Go-Import-Path x
missing-xs-go-import-path-for-golang-package
Added tag(s) pending.
> tag -2 + help
Failed to alter tags of Bug -2: The 'bug' parameter ("-2") to
Debbugs::Control::set_tag did not pass regex check
.
--
1014885: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014885
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Bug#1014885: lintian wrongly complains about XS-Go-Import-Path
Control: clone -1 2 Control: retitle -2 lintian: Needs to distinguish between valid field names for .dsc files and for debian/control files (with vs without "XS-" prefix) Control: tag -1 + pending Control: tag -2 + help Hi, Holger Levsen wrote: > I can confirm this issue for lintian 2.116.0 against src:piuparts > as it is in git or unstable. I can confirm as well. Unfortunately this is not as trivial to fix properly as it seems: A) Lintian currently doesn't seem to make a difference between the fields in the .dsc file and those in the debian/control file. But especially these XS-* fields exactly need that differentiation. B) If I add Autobuild, Go-Import-Path, and Ruby-Versions to data/common/source-fields, the test suite shows that then these lintian tags would fire although they shouldn't (according to the test suite): adopted-extended-field (in section for source) XS-Go-Import-Path adopted-extended-field (in section for source) XS-Autobuild So for now I have no idea except for hardcoding these three inside the source function in lib/Lintian/Check/Fields/Unknown.pm. But this feels wrong. This though might lead to false negatives if someone uses e.g. Go-Import-Path without the "XS-" prefix in debian/control. What would be worse: The current false positives or the potential false negatives? I assume that any potential false negative on these three fields will cause package breakage at build time (wrong Ruby versions, some Go stuff not working, non-free packages not autobuilding, etc.), so that we can cope with them. Cloning this bug report to document that we need a rewrite of Lintian::Check::Fields::Unknown and module dependencies to distinguish between .dsc fields and debian/control fields with a common subset. And maybe with the one set being calculated from the other set by stripping the XS- prefix. Regards, Axel -- ,''`. | Axel Beckert , https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `-| 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
Processed (with 2 errors): Re: Bug#1014885: lintian wrongly complains about XS-Go-Import-Path
Processing control commands:
> clone -1 2
Bug #1014885 [lintian] Conflict: unknown-field Go-Import-Path x
missing-xs-go-import-path-for-golang-package
Bug 1014885 cloned as bug 1029471
> retitle -2 lintian: Needs to distinguish between valid field names for .dsc
> files and for debian/control files (with vs without "XS-" prefix)
Failed to set the title of -2: The 'bug' parameter ("-2") to
Debbugs::Control::set_title did not pass regex check
.
> tag -1 + pending
Bug #1014885 [lintian] Conflict: unknown-field Go-Import-Path x
missing-xs-go-import-path-for-golang-package
Ignoring request to alter tags of bug #1014885 to the same tags previously set
> tag -2 + help
Failed to alter tags of Bug -2: The 'bug' parameter ("-2") to
Debbugs::Control::set_tag did not pass regex check
.
--
1014885: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1014885
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
Processed: tagging 1029177
Processing commands for cont...@bugs.debian.org: > tags 1029177 + pending Bug #1029177 [lintian] lintian: Update Lintian User's Manual wrt. to Pointed Hints format Ignoring request to alter tags of bug #1029177 to the same tags previously set > thanks Stopping processing here. Please contact me if you need assistance. -- 1029177: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029177 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Processed: tagging 1029055
Processing commands for cont...@bugs.debian.org: > tags 1029055 + pending Bug #1029055 [lintian] lintian: Lintian does not recognize the AppStream's metainfo.xml MIT license is the same as Debian's Expat license Added tag(s) pending. > thanks Stopping processing here. Please contact me if you need assistance. -- 1029055: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029055 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
