Bug#672292: lintian: harness errors out on master due to list being passed to require

2012-05-09 Thread Evan Broder
Package: lintian
Version: 2.5.6-100-geef3c3b
Severity: important

Dear Maintainer,

Currently the reporting harness on master exits with the following error:

  syntax error at ./harness line 104, near "require Lintian::Util 
qw(visit_dpkg_paragraph)"

It seems that this is because the `require` function doesn't accept a
list argument in the same way that `use` does.

-- System Information:
Debian Release: wheezy/sid
  APT prefers precise-updates
  APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500, 
'precise'), (100, 'precise-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-24-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.22-6ubuntu1
ii  bzip2  1.0.6-1
ii  diffstat   1.54-1
ii  file   5.09-2
ii  gettext0.18.1.1-5ubuntu3
ii  intltool-debian0.35.0+20060710.1
ii  libapt-pkg-perl0.1.25build2
ii  libc-bin   2.15-0ubuntu10
ii  libclass-accessor-perl 0.34-1
ii  libclone-perl  0.31-1build3
ii  libdpkg-perl   1.16.1.2ubuntu7
ii  libemail-valid-perl0.185-1
ii  libipc-run-perl0.90-1
ii  libparse-debianchangelog-perl  1.2.0-1ubuntu1
ii  libtimedate-perl   1.2000-1
ii  liburi-perl1.59-1
ii  locales2.13+git20120306-3
ii  man-db 2.6.1-2
ii  patchutils 0.3.2-1.1
ii  perl [libdigest-sha-perl]  5.14.2-6ubuntu2
ii  unzip  6.0-4ubuntu1

lintian recommends no packages.

Versions of packages lintian suggests:
ii  binutils-multiarch 
ii  dpkg-dev   1.16.1.2ubuntu7
ii  libhtml-parser-perl3.69-1build1
ii  libtext-template-perl  1.45-2
ii  man-db 2.6.1-2
ii  xz-utils   5.1.1alpha+20110809-3

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120509191057.31859.85898.reportbug@caron



Bug#650793: lintian: No way to suppress langpack-related package-contains-broken-symlink on Ubuntu

2011-12-02 Thread Evan Broder
Package: lintian
Version: 2.5.4
Severity: normal

Part of Ubuntu's package build process involves taking all localized
data for packages in our main component and separating it into
separate per-language "language packages" (or "langpacks"), such as
language-pack-en or language-pack-fr-base. This allows users to only
install the translations that they will use.

When we separate out the language data at build-time, we replace files
in /usr/share/help, /usr/share/gnome/help, /usr/share/omf with
symlinks to the same path in /usr/share/help-langpack,
/usr/share/gnome/help-langpack, etc. These -langpack files are
contained within our language pack packages, but are not directly
depended on.

As a result of this, when run across the Ubuntu archive, Lintian
current emits almost 29,000 instances of
package-contains-broken-symlink that match one of these translated
paths [1].

I'm not sure what the right solution here is, but my best idea is to
extend vendor profiles to support suppressing tags based on the
additional intian-info field, probably with wildcard matching. Such a
mechanism would also solve bug #649852.

[1] http://lintian.ubuntuwire.org/tags/package-contains-broken-symlink.html

Thanks,
 - Evan

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 
'oneiric'), (100, 'oneiric-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-13-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.21.53.20110810-0ubuntu5 The GNU assembler, linker and bina
ii  bzip2  1.0.5-6ubuntu1high-quality block-sorting file co
ii  diffstat   1.54-1produces graph of changes introduc
ii  file   5.04-5ubuntu3 Determines file type using "magic"
ii  gettext0.18.1.1-3ubuntu1 GNU Internationalization utilities
ii  intltool-debia 0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-per 0.1.24build3  Perl interface to libapt-pkg
ii  libclass-acces 0.34-1Perl module that automatically gen
ii  libdpkg-perl   1.16.0.3ubuntu5   Dpkg perl modules
ii  libemail-valid 0.184-1   Perl module for checking the valid
ii  libipc-run-per 0.90-1Perl module for running processes
ii  libparse-debia 1.2.0-1ubuntu1parse Debian changelogs and output
ii  libtimedate-pe 1.2000-1  collection of modules to manipulat
ii  liburi-perl1.58-1module to manipulate and access UR
ii  locales2.13+git20110622-2common files for locale support
ii  man-db 2.6.0.2-2 on-line manual pager
ii  patchutils 0.3.2-1   Utilities to work with patches
ii  perl [libdiges 5.12.4-4  Larry Wall's Practical Extraction 
ii  unzip  6.0-4ubuntu1  De-archiver for .zip files

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch (no description available)
ii  dpkg-dev 1.16.0.3ubuntu5 Debian package development tools
ii  libhtml-parser-perl  3.68-1build1collection of modules that parse H
ii  libtext-template-perl1.45-2  Text::Template perl module
ii  man-db   2.6.0.2-2   on-line manual pager
ii  xz-utils 5.0.0-2 XZ-format compression utilities

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111203051001.15517.82308.reportbug@caron



Bug#650791: lintian: Lab does not update info when component of package changes

2011-12-02 Thread Evan Broder
Source: lintian
Version: 2.5.3ubuntu2
Usertags: origin-ubuntu precise

Ubuntu regularly moves (both source and binary) packages between
components in its repository (generally between main and universe). We
do not require a new upload or binNMU to do this move.

Since Lintian only re-processes a package when its version number
change, the cache about the package in the info/ section of a static
lab will be inaccurate until the package is updated. Because of this,
manual attempts to run lintian across the whole lab will error out.

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 
'oneiric'), (100, 'oneiric-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-13-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.21.53.20110810-0ubuntu5 The GNU assembler, linker and bina
ii  bzip2  1.0.5-6ubuntu1high-quality block-sorting file co
ii  diffstat   1.54-1produces graph of changes introduc
ii  file   5.04-5ubuntu3 Determines file type using "magic"
ii  gettext0.18.1.1-3ubuntu1 GNU Internationalization utilities
ii  intltool-debia 0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-per 0.1.24build3  Perl interface to libapt-pkg
ii  libclass-acces 0.34-1Perl module that automatically gen
ii  libdpkg-perl   1.16.0.3ubuntu5   Dpkg perl modules
ii  libemail-valid 0.184-1   Perl module for checking the valid
ii  libipc-run-per 0.90-1Perl module for running processes
ii  libparse-debia 1.2.0-1ubuntu1parse Debian changelogs and output
ii  libtimedate-pe 1.2000-1  collection of modules to manipulat
ii  liburi-perl1.58-1module to manipulate and access UR
ii  locales2.13+git20110622-2common files for locale support
ii  man-db 2.6.0.2-2 on-line manual pager
ii  patchutils 0.3.2-1   Utilities to work with patches
ii  perl [libdiges 5.12.4-4  Larry Wall's Practical Extraction 
ii  unzip  6.0-4ubuntu1  De-archiver for .zip files

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch (no description available)
ii  dpkg-dev 1.16.0.3ubuntu5 Debian package development tools
ii  libhtml-parser-perl  3.68-1build1collection of modules that parse H
ii  libtext-template-perl1.45-2  Text::Template perl module
ii  man-db   2.6.0.2-2   on-line manual pager
ii  xz-utils 5.0.0-2 XZ-format compression utilities

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111203030828.11233.98842.reportbug@caron



Bug#602249: [PATCH] Added check for maintscript-helper in preinst without dpkg Pre-Depends

2011-12-02 Thread Evan Broder
tags 602249 patch
thanks

I've attached a patch which checks for use of dpkg-maintscript-helper
in preinst scripts in the same manner as existing checks for tools
like gconf-schemas. I marked it as severity pedantic for Debian, but
with a profile change for Ubuntu to make it serious (as this can
impact Ubuntu 10.04 -> 12.04 upgrades)

The check is marked as certainty: possible because the check will
match uses of maintscript-helper which are safely guarded in a
"maintscript-helper supports" conditional, but because of the impact
to Ubuntu, it seems better to have a check with false positives than
none at all.

Thanks,
 - Evan
From fc261862e08341adc824441da3056db94726127d Mon Sep 17 00:00:00 2001
From: Evan Broder 
Date: Fri, 2 Dec 2011 15:32:44 -0800
Subject: [PATCH] Added check for maintscript-helper in preinst without dpkg
 Pre-Depends

dpkg in Squeeze is new enough that this is not strictly necessary,
making this pedantic in Debian. However, dpkg in Lucid does not have
dpkg-maintscript-helper, making this serious as it could break the
upgrade path.

Signed-off-by: Evan Broder 
---
 checks/scripts   |6 ++
 checks/scripts.desc  |8 
 profiles/ubuntu/main.profile |3 ++-
 3 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/checks/scripts b/checks/scripts
index 46bc373..0918cb4 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -886,6 +886,12 @@ while () {
 if (m,\bsuidregister\b,) {
 tag 'suidregister-used-in-maintainer-script', $file;
 }
+if ($file eq 'preinst') {
+if (m/^\s*dpkg-maintscript-helper(?:\s|\z)/ &&
+!$info->relation('pre-depends')->implies('dpkg (>= 1.15.7.2)')) {
+tag 'preinst-uses-dpkg-maintscript-helper-without-predepends', "$file:$.";
+}
+}
 if ($file eq 'postrm') {
 if (m,update\-alternatives \-\-remove,) {
 tag 'update-alternatives-remove-called-in-postrm';
diff --git a/checks/scripts.desc b/checks/scripts.desc
index 113e30c..b33a19b 100644
--- a/checks/scripts.desc
+++ b/checks/scripts.desc
@@ -154,6 +154,14 @@ Info: The package contains a preinst maintainer script that uses
  section 3.5).
 Ref: policy 7.2
 
+Tag: preinst-uses-dpkg-maintscript-helper-without-predepends
+Severity: pedantic
+Certainty: possible
+Info: The package contains a preinst maintainer script that
+ uses dpkg-maintscript-helper but does not declare a
+ pre-dependency on a version of dpkg that provides that
+ script.
+
 Tag: control-interpreter-without-depends
 Severity: serious
 Certainty: possible
diff --git a/profiles/ubuntu/main.profile b/profiles/ubuntu/main.profile
index 753fd36..fd84533 100644
--- a/profiles/ubuntu/main.profile
+++ b/profiles/ubuntu/main.profile
@@ -7,6 +7,7 @@ Disable-Tags: debian-changelog-file-is-a-symlink,
  upstart-job-in-etc-init.d-not-registered-via-update-rc.d
 
 # Serious as it may break Lucid upgrade path
-Tags: data.tar.xz-member-without-dpkg-pre-depends
+Tags: data.tar.xz-member-without-dpkg-pre-depends,
+ preinst-uses-dpkg-maintscript-helper-without-predepends
 Severity: serious
 
-- 
1.7.5.4



Bug#650712: lintian: [PATCH] Respect vendor profiles when generating HTML reports

2011-12-02 Thread Evan Broder
Package: lintian
Version: 2.5.3ubuntu2
Severity: normal

Currently Lintian does not look at vendor profiles at all when
generating HTML reports.

This patchset changes the html_reports script to look at the default
vendor profile instead of parsing the .desc files in checks on its
own. It's currently deployed at lintian.ubuntuwire.org (for instance,
http://lintian.ubuntuwire.org/tags/data.tar.xz-member-without-dpkg-pre-depends.html
correctly shows up as Severity: serious)

I'm not sure this patch is ideal in its current form, because it means
that if a tag were suppressed in the Debian profile, it wouldn't show
up on lintian.d.o at all, and I know several people who treat
lintian.d.o as an online repository of information about Lintian tags

It's also possible that the profile should be settable from
reporting/config.

Thanks,
 - Evan

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 
'oneiric'), (100, 'oneiric-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-13-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.21.53.20110810-0ubuntu5 The GNU assembler, linker and bina
ii  bzip2  1.0.5-6ubuntu1high-quality block-sorting file co
ii  diffstat   1.54-1produces graph of changes introduc
ii  file   5.04-5ubuntu3 Determines file type using "magic"
ii  gettext0.18.1.1-3ubuntu1 GNU Internationalization utilities
ii  intltool-debia 0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-per 0.1.24build3  Perl interface to libapt-pkg
ii  libclass-acces 0.34-1Perl module that automatically gen
ii  libdpkg-perl   1.16.0.3ubuntu5   Dpkg perl modules
ii  libemail-valid 0.184-1   Perl module for checking the valid
ii  libipc-run-per 0.90-1Perl module for running processes
ii  libparse-debia 1.2.0-1ubuntu1parse Debian changelogs and output
ii  libtimedate-pe 1.2000-1  collection of modules to manipulat
ii  liburi-perl1.58-1module to manipulate and access UR
ii  locales2.13+git20110622-2common files for locale support
ii  man-db 2.6.0.2-2 on-line manual pager
ii  patchutils 0.3.2-1   Utilities to work with patches
ii  perl [libdiges 5.12.4-4  Larry Wall's Practical Extraction 
ii  unzip  6.0-4ubuntu1  De-archiver for .zip files

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch (no description available)
ii  dpkg-dev 1.16.0.3ubuntu5 Debian package development tools
ii  libhtml-parser-perl  3.68-1build1collection of modules that parse H
ii  libtext-template-perl1.45-2  Text::Template perl module
ii  man-db   2.6.0.2-2   on-line manual pager
ii  xz-utils 5.0.0-2 XZ-format compression utilities

-- no debconf information
>From 8f16f3a76717eff9ab4730a632f57dfbf3bb2eb8 Mon Sep 17 00:00:00 2001
From: Evan Broder 
Date: Fri, 2 Dec 2011 00:18:08 -0800
Subject: [PATCH 1/2] Always use the effective severity in a tag's long-form
 description

Signed-off-by: Evan Broder 
---
 lib/Lintian/Tag/Info.pm |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/Lintian/Tag/Info.pm b/lib/Lintian/Tag/Info.pm
index ff2b269..5f871c7 100644
--- a/lib/Lintian/Tag/Info.pm
+++ b/lib/Lintian/Tag/Info.pm
@@ -283,9 +283,9 @@ sub description {
 if ($self->{ref}) {
 push(@text, '', _format_reference($self->{ref}));
 }
-if ($self->{severity} and $self->{certainty}) {
-my $severity = $self->{severity};
-my $certainty = $self->{certainty};
+if ($self->severity and $self->certainty) {
+my $severity = $self->severity;
+my $certainty = $self->certainty;
 push(@text, '', "Severity: $severity, Certainty: $certainty");
 }
     if ($self->{script} and $self->{'script-type'}){
-- 
1.7.5.4

>From 4c70e2c05cf003e6bc332ad3c663c429d42eeefe Mon Sep 17 00:00:00 2001
From: Evan Broder 
Date: Fri, 2 Dec 2011 00:18:47 -0800
Subject: [PATCH 2/2] Use profile information about tags in HTML reports

instead of parsing the tag descriptions independently.

Signed-off-by: Evan Broder 
---
 reporting/html_reports |   25 -
 1 files changed, 12 insertions(+), 13 deletions(-)

diff --git a/reporting/html_reports b/reporting/html_reports
index 5815434..a16f0de 100755
--- a/reporting/html_report

Bug#650710: lintian: please check for dpkg-maintscript-helper in preinst without pre-depends: dpkg (>= 1.15.7.2)

2011-12-01 Thread Evan Broder
Package: lintian
Version: 2.5.4
Severity: wishlist

dpkg-maintscript-helper was introduced in dpkg 1.15.7.2, and that
version is required to use the dpkg-maintscript-helper mv_conffile and
rm_conffile subcommands.

The dpkg-maintscript-helper manpage recommends setting Pre-Depends:
dpkg (>= 1.15.7.2) in packages which use these features in the
preinst. However, since Squeeze released with a newer version than
that (1.15.8.11), this Pre-Depends is not strictly needed to upgrade
from Squeeze to Wheezy.

On the other hand, Ubuntu's last LTS (10.04 or Lucid) released with
dpkg 1.15.5.6, and does not include dpkg-maintscript helper, which
means that the Pre-Depends is necessary on Ubuntu to ensure a safe
upgrade from 10.04 to our next LTS, 12.04 (Precise)

It would be helpful of Lintian could catch preinsts using
dpkg-maintscript-helper without also setting the Pre-Depends.

As with bug #648350, this should be severity: serious for Ubuntu,
though I can't imagine a static analysis check that would have high
certainty, so it will probably have to be certainty: possible.

Thanks,
 - Evan

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 
'oneiric'), (100, 'oneiric-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-13-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.21.53.20110810-0ubuntu5 The GNU assembler, linker and bina
ii  bzip2  1.0.5-6ubuntu1high-quality block-sorting file co
ii  diffstat   1.54-1produces graph of changes introduc
ii  file   5.04-5ubuntu3 Determines file type using "magic"
ii  gettext0.18.1.1-3ubuntu1 GNU Internationalization utilities
ii  intltool-debia 0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-per 0.1.24build3  Perl interface to libapt-pkg
ii  libclass-acces 0.34-1Perl module that automatically gen
ii  libdpkg-perl   1.16.0.3ubuntu5   Dpkg perl modules
ii  libemail-valid 0.184-1   Perl module for checking the valid
ii  libipc-run-per 0.90-1Perl module for running processes
ii  libparse-debia 1.2.0-1ubuntu1parse Debian changelogs and output
ii  libtimedate-pe 1.2000-1  collection of modules to manipulat
ii  liburi-perl1.58-1module to manipulate and access UR
ii  locales2.13+git20110622-2common files for locale support
ii  man-db 2.6.0.2-2 on-line manual pager
ii  patchutils 0.3.2-1   Utilities to work with patches
ii  perl [libdiges 5.12.4-4  Larry Wall's Practical Extraction 
ii  unzip  6.0-4ubuntu1  De-archiver for .zip files

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch (no description available)
ii  dpkg-dev 1.16.0.3ubuntu5 Debian package development tools
ii  libhtml-parser-perl  3.68-1build1collection of modules that parse H
ii  libtext-template-perl1.45-2  Text::Template perl module
ii  man-db   2.6.0.2-2   on-line manual pager
ii  xz-utils 5.0.0-2 XZ-format compression utilities

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20111202073804.13406.69926.reportbug@caron



Bug#650701: [PATCH] Check git and debian/changelog before showing dummy version number

2011-12-01 Thread Evan Broder
Source: lintian
Version: 2.5.4
Severity: wishlist

Currently Lintian has a placeholder version number ("") which
gets replaced at build time. However, things like the lintian.d.o
harness run from source checkouts. Without manual cleanup, they will
keep showing the dummy number.

If the version number hasn't been substituted in, this patch checks
for a more authoritative version number, first trying git-describe,
and then the debian/changelog, and finally printing "" only
if neither of the other two pan out.

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 
'oneiric'), (100, 'oneiric-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-13-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.21.53.20110810-0ubuntu5 The GNU assembler, linker and bina
ii  bzip2  1.0.5-6ubuntu1high-quality block-sorting file co
ii  diffstat   1.54-1produces graph of changes introduc
ii  file   5.04-5ubuntu3 Determines file type using "magic"
ii  gettext0.18.1.1-3ubuntu1 GNU Internationalization utilities
ii  intltool-debia 0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-per 0.1.24build3  Perl interface to libapt-pkg
ii  libclass-acces 0.34-1Perl module that automatically gen
ii  libdpkg-perl   1.16.0.3ubuntu5   Dpkg perl modules
ii  libemail-valid 0.184-1   Perl module for checking the valid
ii  libipc-run-per 0.90-1Perl module for running processes
ii  libparse-debia 1.2.0-1ubuntu1parse Debian changelogs and output
ii  libtimedate-pe 1.2000-1  collection of modules to manipulat
ii  liburi-perl1.58-1module to manipulate and access UR
ii  locales2.13+git20110622-2common files for locale support
ii  man-db 2.6.0.2-2 on-line manual pager
ii  patchutils 0.3.2-1   Utilities to work with patches
ii  perl [libdiges 5.12.4-4  Larry Wall's Practical Extraction 
ii  unzip  6.0-4ubuntu1  De-archiver for .zip files

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch (no description available)
ii  dpkg-dev 1.16.0.3ubuntu5 Debian package development tools
ii  libhtml-parser-perl  3.68-1build1collection of modules that parse H
ii  libtext-template-perl1.45-2  Text::Template perl module
ii  man-db   2.6.0.2-2   on-line manual pager
ii  xz-utils 5.0.0-2 XZ-format compression utilities

-- no debconf information
>From 4332ec8f449562df13079f0b8f408a90a0b7d1bc Mon Sep 17 00:00:00 2001
From: Evan Broder 
Date: Thu, 1 Dec 2011 20:59:57 -0800
Subject: [PATCH] Check git and debian/changelog before showing dummy version
 number

This should ensure that lintian --version prints out something
reasonable if it's run from a source tree.

Signed-off-by: Evan Broder 
---
 debian/rules |2 +-
 frontend/lintian |   15 ++-
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/debian/rules b/debian/rules
index feaaf11..a1aafb9 100755
--- a/debian/rules
+++ b/debian/rules
@@ -97,7 +97,7 @@ binary-indep: $(neededfiles) build
 
 	dh_install
 # some manual work
-	sed -i 's//$(VER)/' $(tmp)/usr/bin/lintian
+	sed -i 's/my $$LINTIAN_VERSION = ""/my $$LINTIAN_VERSION = "$(VER)"/' $(tmp)/usr/bin/lintian
 	install -m 644 doc/lintianrc.example $(tmp)/etc/lintianrc
 	dh_installdocs
 	dh_installchangelogs
diff --git a/frontend/lintian b/frontend/lintian
index 8e2b64c..f054618 100755
--- a/frontend/lintian
+++ b/frontend/lintian
@@ -26,6 +26,9 @@ use strict;
 use warnings;
 
 use Getopt::Long;
+use File::Basename;
+use IPC::Run;
+use Parse::DebianChangelog;
 
 # }}}
 
@@ -73,7 +76,17 @@ qw(
 ### "Normal" application variables
 
 # Version number - Is replaced during build with sed, see d/rules
-my $LINTIAN_VERSION = '';  #External Version number
+my $LINTIAN_VERSION = "";  #External Version number
+if ( $LINTIAN_VERSION eq '' && -d dirname(__FILE__) . "/../.git" ) {
+IPC::Run::run ["git", "--git-dir=" . dirname(__FILE__) . "/../.git", "describe"], \
+undef, \$LINTIAN_VERSION;
+chomp $LINTIAN_VERSION;
+}
+if ( $LINTIAN_VERSION eq '' && -f dirname(__FILE__) . "/../debian/changelog" ) {
+my $changelog = Parse::DebianChangelog->init({ infile => dirname(__F

Bug#649852: lintian: No way to suppress unknown-field-in-control original-maintainer in Ubuntu

2011-11-24 Thread Evan Broder
Package: lintian
Version: 2.5.4
Severity: wishlist

Lintian already suppresses complaints about the Original-Maintainer
field in Ubuntu packages whose version number contains "ubuntu"
(i.e. the source package in Ubuntu has been modified from Debian).

However, in compliance with [1], the Ubuntu buildds also change the
Maintainer field of every *binary* package during the build process.

In practice, this is causing Ubuntu's Lintian instance to emit a
spurious unknown-field-in-control original-maintainer on all 25,700 or
so packages which Ubuntu syncs directly from Debian ([2]).

[1] https://wiki.ubuntu.com/DebianMaintainerField
[2] http://lintian.ubuntuwire.org/tags/unknown-field-in-control.html

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric-updates
  APT policy: (500, 'oneiric-updates'), (500, 'oneiric-security'), (500, 
'oneiric'), (100, 'oneiric-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-13-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils   2.21.53.20110810-0ubuntu5 The GNU assembler, linker and bina
ii  bzip2  1.0.5-6ubuntu1high-quality block-sorting file co
ii  diffstat   1.54-1produces graph of changes introduc
ii  file   5.04-5ubuntu3 Determines file type using "magic"
ii  gettext0.18.1.1-3ubuntu1 GNU Internationalization utilities
ii  intltool-debia 0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-per 0.1.24build3  Perl interface to libapt-pkg
ii  libclass-acces 0.34-1Perl module that automatically gen
ii  libdpkg-perl   1.16.0.3ubuntu5   Dpkg perl modules
ii  libemail-valid 0.184-1   Perl module for checking the valid
ii  libipc-run-per 0.90-1Perl module for running processes
ii  libparse-debia 1.2.0-1ubuntu1parse Debian changelogs and output
ii  libtimedate-pe 1.2000-1  collection of modules to manipulat
ii  liburi-perl1.58-1module to manipulate and access UR
ii  locales2.13+git20110622-2common files for locale support
ii  man-db 2.6.0.2-2 on-line manual pager
ii  patchutils 0.3.2-1   Utilities to work with patches
ii  perl [libdiges 5.12.4-4  Larry Wall's Practical Extraction 
ii  unzip  6.0-4ubuntu1  De-archiver for .zip files

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch (no description available)
ii  dpkg-dev 1.16.0.3ubuntu5 Debian package development tools
ii  libhtml-parser-perl  3.68-1build1collection of modules that parse H
ii  libtext-template-perl1.45-2  Text::Template perl module
ii  man-db   2.6.0.2-2   on-line manual pager
ii  xz-utils 5.0.0-2 XZ-format compression utilities

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/2024101021.26252.10840.reportbug@caron



Re: lintian and Debian derivatives

2011-11-08 Thread Evan Broder
On Tue, Nov 8, 2011 at 8:02 PM, Evan Broder  wrote:
> On Thu, Jul 7, 2011 at 12:10 AM, Paul Wise  wrote:
>> On Thu, Jul 7, 2011 at 12:49 AM, Geoffrey Thomas wrote:
>>
>>> We are the only one? I'm proud :-) We set that up about a year ago because
>>> why not, but in practice, we've more been using Lintian output from the
>>> package build process (debuild/sbuild) than the page, and making sure there
>>> are no regressions and no unexpected warnings on new packages.
>>
>> Cool :)
>>
>>> In terms of making Lintian useful for derivatives, I think the biggest
>>> feature we'd like is having a way to suppress Lintian checks during the
>>> build process for an entire origin of packages (defined somehow...).
>>
>> Probably this will be useful to you:
>>
>> http://wiki.debian.org/Lintian/Spec/VendorCustomization
>>
>> The work on this is in progress, so I would suggest you check it out
>> as soon as possible.
>>
>> If you have any suggestions on how it works, now is the time to make them.
>
> I realize I'm a bit late getting in on this, but I do have a small
> amount of feedback on vendor profiles having just finished (finally)
> setting up an Ubuntu lintian harness (http://lintian.ubuntuwire.org)
>
> We're triggering a handful of specific tags that don't apply in an
> Ubuntu context, but only with certain...arguments? (I'm a little shaky
> on the terminology)
>
> One example of this is unknown-field-in-control. Because we use a tool
> on our buildds to modify all binary packages (http://bit.ly/vjllQi),
> our binary packages all include both a Maintainer and
> Original-Maintainer field. Lintian already handles Original-Maintainer
> for packages with an Ubuntu modification, but we're currently
> generating unknown-field-in-control tags on the vast majority of
> packages in our archive
> (http://lintian.ubuntuwire.org/tags/unknown-field-in-control.html).
>
> If I could filter "unknown-field-in-debian-control
> original-maintainer", that page would be almost empty.
>
> Similarly, we've diverged from Debian in the list of Essential
> packages - python-minimal is essential for us, so we're generating
> new-essential-package.

Ah, yes. I also meant to mention that, to date, we haven't found any
overrides we want to put in that require wildcards, just constant
string matches.

- Evan


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CAFvUpeJqHFYZJjVuzsPnPpCOD9J3xiVc=qegc1xj7rd4gmk...@mail.gmail.com



Re: lintian and Debian derivatives

2011-11-08 Thread Evan Broder
On Thu, Jul 7, 2011 at 12:10 AM, Paul Wise  wrote:
> On Thu, Jul 7, 2011 at 12:49 AM, Geoffrey Thomas wrote:
>
>> We are the only one? I'm proud :-) We set that up about a year ago because
>> why not, but in practice, we've more been using Lintian output from the
>> package build process (debuild/sbuild) than the page, and making sure there
>> are no regressions and no unexpected warnings on new packages.
>
> Cool :)
>
>> In terms of making Lintian useful for derivatives, I think the biggest
>> feature we'd like is having a way to suppress Lintian checks during the
>> build process for an entire origin of packages (defined somehow...).
>
> Probably this will be useful to you:
>
> http://wiki.debian.org/Lintian/Spec/VendorCustomization
>
> The work on this is in progress, so I would suggest you check it out
> as soon as possible.
>
> If you have any suggestions on how it works, now is the time to make them.

I realize I'm a bit late getting in on this, but I do have a small
amount of feedback on vendor profiles having just finished (finally)
setting up an Ubuntu lintian harness (http://lintian.ubuntuwire.org)

We're triggering a handful of specific tags that don't apply in an
Ubuntu context, but only with certain...arguments? (I'm a little shaky
on the terminology)

One example of this is unknown-field-in-control. Because we use a tool
on our buildds to modify all binary packages (http://bit.ly/vjllQi),
our binary packages all include both a Maintainer and
Original-Maintainer field. Lintian already handles Original-Maintainer
for packages with an Ubuntu modification, but we're currently
generating unknown-field-in-control tags on the vast majority of
packages in our archive
(http://lintian.ubuntuwire.org/tags/unknown-field-in-control.html).

If I could filter "unknown-field-in-debian-control
original-maintainer", that page would be almost empty.

Similarly, we've diverged from Debian in the list of Essential
packages - python-minimal is essential for us, so we're generating
new-essential-package.

I have a couple of small other nits and patches, but most of the
modifications I had to make were around templating

- Evan


-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/CAFvUpeLnZSqBc01OCQdiQqknHGNpLvtuJ+yT=KCdCJ5WKixf=g...@mail.gmail.com



Bug#648117: [PATCH] Disable the lzma-deb-archive tag under the Ubuntu profile.

2011-11-08 Thread Evan Broder
Package: lintian
Version: 2.5.3ubuntu2
Tags: patch

The Ubuntu archive can accept (and current has several) binary
packages using lzma compression.
---
 profiles/ubuntu/main.profile |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/profiles/ubuntu/main.profile b/profiles/ubuntu/main.profile
index 95443a9..54db5c9 100644
--- a/profiles/ubuntu/main.profile
+++ b/profiles/ubuntu/main.profile
@@ -2,4 +2,5 @@
 Profile: ubuntu/main
 Extends: debian/main
 Disable-Tags: debian-changelog-file-is-a-symlink,
- upstart-job-in-etc-init.d-not-registered-via-update-rc.d
+ upstart-job-in-etc-init.d-not-registered-via-update-rc.d,
+ lzma-deb-archive
-- 
1.7.5.4




-- 
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/1320806704-7557-1-git-send-email-e...@ebroder.net