Bug#409099: lintian: debian/control::Depends check for missing commas

2008-03-20 Thread Raphael Hertzog 
On Tue, 30 Jan 2007, Russ Allbery wrote:
  An example:
 
  debian/control
  Depends: ${shlibs:Depends} ${misc:Depends}
 
  SUGGESTION
 
  If possible, detect the missing commas in debain/control fields
  like Build-Depends and Depends. That is:
 
  * After a word or ending paren, a comma should follow
  * an exception: not enforced at the end of line.
 
 Hm, doesn't check/fields already do a syntax check here?  If not, it
 certainly should, but I thought it already did.
 
 Of course, if those substitutions expand to nothing, it will miss that
 because the syntax check is done on the binary package.

dpkg-gencontrol will also error out if the resulting field is not correct
however there are no check prior to substvars expansion.

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/

Bug#409099: lintian: debian/control::Depends check for missing commas

2007-01-30 Thread Jari Aalto 
Package: lintian
Version: 1.23.27
Severity: wishlist


An example:

debian/control
Depends: ${shlibs:Depends} ${misc:Depends}

SUGGESTION

If possible, detect the missing commas in debain/control fields
like Build-Depends and Depends. That is:

* After a word or ending paren, a comma should follow
* an exception: not enforced at the end of line.

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.18-3-686
Locale: LANG=C, LC_CTYPE=C (charmap=ISO-8859-1) (ignored: LC_ALL set to en_US)

Versions of packages lintian depends on:
ii  binutils   2.17-3The GNU assembler, linker and bina
ii  diffstat   1.43-2produces graph of changes introduc
ii  dpkg-dev   1.13.25   package building tools for Debian
ii  file   4.17-5Determines file type using magic
ii  gettext0.16.1-1  GNU Internationalization utilities
ii  intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libparse-debianchangel 1.0-1 parse Debian changelogs and output
ii  man-db 2.4.3-5   The on-line manual pager
ii  perl [libdigest-md5-pe 5.8.8-7   Larry Wall's Practical Extraction 

lintian recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#409099: lintian: debian/control::Depends check for missing commas

2007-01-30 Thread Russ Allbery 
Jari Aalto [EMAIL PROTECTED] writes:

 Package: lintian
 Version: 1.23.27
 Severity: wishlist

 An example:

   debian/control
   Depends: ${shlibs:Depends} ${misc:Depends}

 SUGGESTION

 If possible, detect the missing commas in debain/control fields
 like Build-Depends and Depends. That is:

 * After a word or ending paren, a comma should follow
 * an exception: not enforced at the end of line.

Hm, doesn't check/fields already do a syntax check here?  If not, it
certainly should, but I thought it already did.

Of course, if those substitutions expand to nothing, it will miss that
because the syntax check is done on the binary package.

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]