Bug#460168: lintian: ant needed in clean target

2008-01-10 Thread Cyril Brulebois 
Package: lintian
Version: 1.23.42
Severity: minor

Hi,

similarly to #457501, I noticed the following for ant:
| I: sunflow source: build-depends-without-arch-dep ant

But ant is in fact needed in the clean target, at least when used
through cdbs's ant.mk: (an equivalent to “make clean”, roughly)
| dh_clean
| cd .  /usr/lib/jvm/java-gcj/bin/java -classpath 
/usr/share/ant/lib/ant.jar:/usr/share/ant/lib/ant-launcher.jar:/usr/share/java/janino.jar:/usr/lib/jvm/java-gcj/lib/tools.jar
  -Dant.home=/usr/share/ant org.apache.tools.ant.Main -Dcompile.debug=true 
-Dcompile.optimize=true clean
| Buildfile: build.xml
| 
| init:
| 
| clean:
|[delete] Deleting directory /home/kibi/sunflow.git/build
|[delete] Deleting directory /home/kibi/sunflow.git/release
| 
| BUILD SUCCESSFUL
| Total time: 0 seconds

I guess that it might be a bit hard to detect because of its being java,
but, at first glance, trying to detect “/usr/share/ant/lib/ant.jar”
should do the trick.

The sunflow package currently in unstable and testing exhibits this
minor issue.

Thanks again. Cheers,

-- 
Cyril Brulebois



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#460168: lintian: ant needed in clean target

2008-01-10 Thread Russ Allbery 
Cyril Brulebois [EMAIL PROTECTED] writes:

 Package: lintian
 Version: 1.23.42
 Severity: minor

 Hi,

 similarly to #457501, I noticed the following for ant:
 | I: sunflow source: build-depends-without-arch-dep ant

 But ant is in fact needed in the clean target, at least when used
 through cdbs's ant.mk: (an equivalent to “make clean”, roughly)

lintian tries to bail completely for this tag on packages that use ant.
It's too hard to figure out what's needed and what isn't.  However, it
looks like that logic isn't working in your case for some reason.

Currently, lintian looks for:

^include\s*/usr/share/cdbs/1/rules/ant.mk

in debian/rules, and it looks like that's the problem and it should be
class/ant.mk instead.  I'll fix this for the next release of lintian.

Thanks for the report!

-- 
Russ Allbery ([EMAIL PROTECTED])   http://www.eyrie.org/~eagle/