Bug#513650: lintian: pedantic: check for fonts in non-font package
Hi Russ, Hope you will give me some time to sleep and then write a couple more checks :) Russ Allbery wrote: [...] A pure filename match on the fonts I think is only certainty: possible. I made that adjustment after committing. At the beginning I considered downloading the .deb files to calculate the checksums of the files, based on the analysis of Contents, but when Paul replied to my questions I was thinking about using the file he mentioned. I decided to implement the check using none of those methods because I didn't see much gain, as it would consume more time to calculate the checksums. If it is really desired, the current script in private/ could take some more bits from the debhelper one which already downloads .deb files, and checks/files be adapted. The list of fonts files is a bit large actually, so I though not using checksums to be a good compromise between accuracy (or rather number of false negatives) and speed. Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#513650: lintian: pedantic: check for fonts in non-font package
Raphael Geissert atomo64+deb...@gmail.com writes: At the beginning I considered downloading the .deb files to calculate the checksums of the files, based on the analysis of Contents, but when Paul replied to my questions I was thinking about using the file he mentioned. I decided to implement the check using none of those methods because I didn't see much gain, as it would consume more time to calculate the checksums. If it is really desired, the current script in private/ could take some more bits from the debhelper one which already downloads .deb files, and checks/files be adapted. The list of fonts files is a bit large actually, so I though not using checksums to be a good compromise between accuracy (or rather number of false negatives) and speed. Oh, I have no problem at all with what you did, and I don't think the additional work is worth it for the additional level of certainty unless people start complaining. I just wanted to acknowledge in the certainty that with a pure file name match, there are plausible cases where we'll get the tag wrong. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#513650: lintian: pedantic: check for fonts in non-font package
Package: lintian Severity: wishlist Please check for *.ttf *.otf fonts in packages not named ttf-* and otf-*. These fonts should be generally be packaged separately and depended on because they are usually useful outside the package that embeds them (often they are decorative fonts, which are even more useful). The check should ignore symlinks because some software just loads a font filename instead of using fontconfig and symlinks are the easiest way to make them work. -- bye, pabs http://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#513650: lintian: pedantic: check for fonts in non-font package
Raphael Geissert atomo64+deb...@gmail.com writes: Attached mbox has two patches, one implementing font-in-non-font-package, and the second one implementing duplicate-font-file. Looks like we both did the former at the same time. :) I implemented the former check as wishlist and not pedantic because there is no reason to do it that way. My POV is that pedantic checks should be those for which one would normally not file a bug, not even as wishlist. In this case if I think a font could be re-used I would definitely file a report with severity wishlist. Yup, this is a good point. I've changed the implementation that I committed to match. A pure filename match on the fonts I think is only certainty: possible. I made that adjustment after committing. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
