Bug#846009: look for FIX_MEs in control and copyright created by npm2deb

[Chris Lamb]

Hey Bastien,

> > I see. That way I'm not sure we get the line number though? This is rather a
> > nice usability feature IMHO.
> 
> No we do not get the line number, but in theory it is possible by
> counting the number of \n each time we had a block

Given the non-trivial complexity of a sliding window compounded by the
\n technique you refer to... combined with the debian/{control,copyright}
files rarely being very big anyway, IMHO I don't think this would be the
best tradeoff. :)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb, Debian Project Leader
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#846009: look for FIX_MEs in control and copyright created by npm2deb

[Bastien ROUCARIES]

On Sat, Jul 15, 2017 at 12:02 PM, Chris Lamb  wrote:
> Hi Bastien,
>
>> > Thanks for your review. Whilst I am aware of such algorithms, could you
>> > elaborate on what you mean in concrete terms here?
>>
>> see sub full_text_check function
>
> I see. That way I'm not sure we get the line number though? This is rather a
> nice usability feature IMHO.

No we do not get the line number, but in theory it is possible by
counting the number of \n each time we had a block

>
>
> Best wishes,
>
> --
>   ,''`.
>  : :'  : Chris Lamb, Debian Project Leader
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-

Bug#846009: look for FIX_MEs in control and copyright created by npm2deb

[Chris Lamb]

Hi Bastien,

> > Thanks for your review. Whilst I am aware of such algorithms, could you
> > elaborate on what you mean in concrete terms here?
> 
> see sub full_text_check function

I see. That way I'm not sure we get the line number though? This is rather a
nice usability feature IMHO.


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb, Debian Project Leader
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#846009: look for FIX_MEs in control and copyright created by npm2deb

[Bastien ROUCARIES]

On Fri, Jul 14, 2017 at 9:36 PM, Chris Lamb  wrote:
> Hi Bastien,
>
>> >   
>> > https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=7319953bad3ae5e0e15f778a7ed19dd20241b77c
>>
>> Did you consider to use the sliding windows algo ?
>
> Thanks for your review. Whilst I am aware of such algorithms, could you
> elaborate on what you mean in concrete terms here?

see sub full_text_check function

Instead of reading line per line you could read block by block.

The algortihm assemble the block by pair therefore avoiding boundary problems

Bastien

>
> Regards,
>
> --
>   ,''`.
>  : :'  : Chris Lamb, Debian Project Leader
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-

Bug#846009: look for FIX_MEs in control and copyright created by npm2deb

[Chris Lamb]

Hi Bastien,

> >   
> > https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=7319953bad3ae5e0e15f778a7ed19dd20241b77c
> 
> Did you consider to use the sliding windows algo ?

Thanks for your review. Whilst I am aware of such algorithms, could you
elaborate on what you mean in concrete terms here?


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb, Debian Project Leader
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#846009: look for FIX_MEs in control and copyright created by npm2deb

[Bastien ROUCARIES]

On Tue, Jul 11, 2017 at 11:44 PM, Chris Lamb  wrote:
> tags 846009 + pending
> thanks
>
> Fixed in Git:
>
>   
> https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=7319953bad3ae5e0e15f778a7ed19dd20241b77c

Did you consider to use the sliding windows algo ?

Bastien
>
>
> Regards,
>
> --
>   ,''`.
>  : :'  : Chris Lamb, Debian Project Leader
>  `. `'`  la...@debian.org / chris-lamb.co.uk
>`-
>

Bug#846009: look for FIX_MEs in control and copyright created by npm2deb

[Chris Lamb]

tags 846009 + pending
thanks

Fixed in Git:

  
https://anonscm.debian.org/git/lintian/lintian.git/commit/?id=7319953bad3ae5e0e15f778a7ed19dd20241b77c


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb, Debian Project Leader
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-