Bug#849043: privacy-breach-w3c-valid-html: incorrect lowercase "Icon" in path

2016-12-23 Thread Bastien ROUCARIES
On Thu, Dec 22, 2016 at 4:37 AM, Trent W. Buck  wrote:
> Package: lintian
> Version: 2.5.30+deb8u4
> Severity: minor
>
> While making a package I got this from lintian:
>
> E: foo: privacy-breach-w3c-valid-html usr/foo/foo.html 
> (http://www.w3.org/icons/valid-xhtml10.png)
>
> However the actual URL in the file has an uppercase I in Icons:
>
> http://www.w3.org/Icons/valid-xhtml10.png
>
> This misleading error confused me and I wasted half an hour trying to
> download the wrong URL (which 404s).
>
> Attached is a simple shell script which reproduces the problem.
>
> This file looks relevant, but I can't understand where the downcasing 
> actually happens:
>
> /usr/share/lintian/data/files/privacy-breaker-websites

We compare only lowercase string in order to be quicker. I think we
should document it
>
>
> If it is easy to do so,
> please avoid downcasing the path part of URLs in these lintian errors.



Bug#849043: privacy-breach-w3c-valid-html: incorrect lowercase "Icon" in path

2016-12-21 Thread Trent W. Buck
Package: lintian
Version: 2.5.30+deb8u4
Severity: minor

While making a package I got this from lintian:

E: foo: privacy-breach-w3c-valid-html usr/foo/foo.html 
(http://www.w3.org/icons/valid-xhtml10.png)

However the actual URL in the file has an uppercase I in Icons:

http://www.w3.org/Icons/valid-xhtml10.png

This misleading error confused me and I wasted half an hour trying to
download the wrong URL (which 404s).

Attached is a simple shell script which reproduces the problem.

This file looks relevant, but I can't understand where the downcasing actually 
happens:

/usr/share/lintian/data/files/privacy-breaker-websites


If it is easy to do so,
please avoid downcasing the path part of URLs in these lintian errors.
#!/bin/bash

# Goal: move shitty inkscape help crap into its own .deb,
# so it doesn't fill up my inmate desktop branches.
# Especially necessary now that Hopkins branches are all coming in.

set -eEu -o pipefail
shopt -s failglob
trap 'echo >&2 "$0:${LINENO}: unknown error"' ERR

rm -rf   /tmp/foo
mkdir -p /tmp/foo/debian/source
cd   /tmp/foo

apt-get install build-essential dpkg-dev devscripts lintian debhelper fakeroot binutils debhelper

export NAME='Trent W. Buck' EMAIL=t...@cyber.com.au  # used by dch
dch --create --package foo -v0~1 -Dstable 'Initial release.'
>debian/compat  echo 9
>debian/source/format   echo '3.0 (native)'
>debian/install echo '*.html usr/foo/'
>foo.html   echo 'http://www.w3.org/Icons/valid-xhtml10.png"/>'
>debian/rules cat <<'EOF' && chmod +x debian/rules
#!/usr/bin/make -f
%:
	dh $@
EOF
>debian/control cat <<'EOF'
Source: foo
Section: doc
Priority: optional
Standards-Version: 3.9.6
Maintainer: Trent W. Buck 
Build-Depends: debhelper

Package: foo
Depends: ${misc:Depends}
Architecture: all
Description: foo
 foo
EOF

debuild -uc -us