Bug#865531: lintian: testsuite-autopkgtest-missing checks the wrong thing

[Raphael Hertzog]

Hi,

On Thu, 06 Jul 2017, Niels Thykier wrote:
> On Thu, 22 Jun 2017 14:45:52 +0200 =?utf-8?q?Rapha=C3=ABl_Hertzog?=
>  wrote:
> > Package: lintian
> > Version: 2.5.51
> > Severity: normal
> > 
> > lintian complains with testsuite-autopkgtest-missing when debian/control
> > is missing the "Testsuite" field but that field is usually not present
> > in the unpacked source package because it is automatically added by
> > dpkg-source to the .dsc when it finds debian/tests/control.
> 
> Please provide a test case for this.

I did not verify this, I just assumed this based on the long description
of the tag.

> > So instead you should check that field in the .dsc or directly
> > debian/tests/control in the unpacked source package.
> 
> The code currently checks for the field in the .dsc file.

So then it's only a documentation issue and not a real problem.

> > BTW the long description must also be updated as it instructs the user
> > to add this field in debian/control when it's not needed.
> 
> That is true though.

Feel free to correct only this and close this bug. And word the long
description in a way that makes it clear that the test checks the field
in the .dsc file.

Thank you!
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#865531: lintian: testsuite-autopkgtest-missing checks the wrong thing

[Niels Thykier]

Control: tags -1 moreinfo

On Thu, 22 Jun 2017 14:45:52 +0200 =?utf-8?q?Rapha=C3=ABl_Hertzog?=
 wrote:
> Package: lintian
> Version: 2.5.51
> Severity: normal
> 
> lintian complains with testsuite-autopkgtest-missing when debian/control
> is missing the "Testsuite" field but that field is usually not present
> in the unpacked source package because it is automatically added by
> dpkg-source to the .dsc when it finds debian/tests/control.
> 

Hi,

Please provide a test case for this.

> So instead you should check that field in the .dsc or directly
> debian/tests/control in the unpacked source package.
> 
> Cheers,
> 
> [...]

The code currently checks for the field in the .dsc file.

(Separate mail)
> BTW the long description must also be updated as it instructs the user
> to add this field in debian/control when it's not needed.
> 
> Cheers,
> -- 
> Raphaël Hertzog ◈ Debian Developer

That is true though.

Thanks,
~Niels

Bug#865531: lintian: testsuite-autopkgtest-missing checks the wrong thing

[Raphael Hertzog]

On Thu, 22 Jun 2017, Raphaël Hertzog wrote:
> lintian complains with testsuite-autopkgtest-missing when debian/control
> is missing the "Testsuite" field but that field is usually not present
> in the unpacked source package because it is automatically added by
> dpkg-source to the .dsc when it finds debian/tests/control.

BTW the long description must also be updated as it instructs the user
to add this field in debian/control when it's not needed.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#865531: lintian: testsuite-autopkgtest-missing checks the wrong thing

[Raphaël Hertzog]

Package: lintian
Version: 2.5.51
Severity: normal

lintian complains with testsuite-autopkgtest-missing when debian/control
is missing the "Testsuite" field but that field is usually not present
in the unpacked source package because it is automatically added by
dpkg-source to the .dsc when it finds debian/tests/control.

So instead you should check that field in the .dsc or directly
debian/tests/control in the unpacked source package.

Cheers,

-- System Information:
Debian Release: 9.0
  APT prefers oldoldstable
  APT policy: (500, 'oldoldstable'), (500, 'unstable'), (500, 'oldstable'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils  2.28-6
ii  bzip2 1.0.6-8.1
ii  diffstat  1.61-1+b1
ii  dpkg  1.18.24
ii  file  1:5.30-1
ii  gettext   0.19.8.1-2
ii  intltool-debian   0.35.0+20060710.4
ii  libapt-pkg-perl   0.1.32
ii  libarchive-zip-perl   1.59-1
ii  libclass-accessor-perl0.34-1
ii  libclone-perl 0.38-2+b1
ii  libdpkg-perl  1.18.24
ii  libemail-valid-perl   1.202-1
ii  libfile-basedir-perl  0.07-1
ii  libipc-run-perl   0.94-1
ii  liblist-moreutils-perl0.416-1+b1
ii  libparse-debianchangelog-perl 1.2.0-12
ii  libperl5.24 [libdigest-sha-perl]  5.24.1-3
ii  libtext-levenshtein-perl  0.13-1
ii  libtimedate-perl  2.3000-2
ii  liburi-perl   1.71-1
ii  libyaml-libyaml-perl  0.63-2
ii  man-db2.7.6.1-2
ii  patchutils0.3.4-2
ii  perl  5.24.1-3
ii  t1utils   1.39-2
ii  xz-utils  5.2.2-1.2+b1

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b2

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.18.24
ii  libhtml-parser-perl3.72-3
ii  libtext-template-perl  1.46-1

-- no debconf information