Bug#920691: lintian gets stuck collecting info after failed objdump-info

2019-02-05 Thread Felix Lechner
On Mon, Feb 4, 2019 at 5:03 AM Raphael Hertzog  wrote:
> Thanks for the notice, I tried with that version of Perl but the problem I
> reported is still present. So it seems unrelated.

This MR fixes the hang here:

https://salsa.debian.org/lintian/lintian/merge_requests/140



Bug#920691: lintian gets stuck collecting info after failed objdump-info

2019-02-05 Thread Felix Lechner
On Mon, Feb 4, 2019 at 5:03 AM Raphael Hertzog  wrote:
> Thanks for the notice, I tried with that version of Perl but the problem I
> reported is still present. So it seems unrelated.

Here is a merge request that seems to fix the issue by reverting:
https://salsa.debian.org/lintian/lintian/merge_requests/139

I am only making it available in case downgrading is not an option.
The merge request should not be accepted. Still looking for the actual
bug.



Bug#920691: lintian gets stuck collecting info after failed objdump-info

2019-02-04 Thread Raphael Hertzog
On Sat, 02 Feb 2019, Niko Tyni wrote:
> On Mon, Jan 28, 2019 at 07:01:52PM -0800, Felix Lechner wrote:
> > Maybe the pending Perl commit 672eb451 will help? Details in #916313.
> 
> FYI I've just uploaded perl/5.28.1-4 which fixes #916313.

Thanks for the notice, I tried with that version of Perl but the problem I
reported is still present. So it seems unrelated.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/



Bug#920691: lintian gets stuck collecting info after failed objdump-info

2019-02-02 Thread Niko Tyni
On Mon, Jan 28, 2019 at 07:01:52PM -0800, Felix Lechner wrote:
> Maybe the pending Perl commit 672eb451 will help? Details in #916313.

FYI I've just uploaded perl/5.28.1-4 which fixes #916313.

Hope that helps.
-- 
Niko Tyni   nt...@debian.org



Bug#920691: lintian gets stuck collecting info after failed objdump-info

2019-01-28 Thread Felix Lechner
Maybe the pending Perl commit 672eb451 will help? Details in #916313.



Bug#920691: lintian gets stuck collecting info after failed objdump-info

2019-01-28 Thread Felix Lechner
I think this is related to Perl update 5.28.1-3. Shortly afterward, I
had the problem raised in #916087, which also showed up with
IO::Async. Files did not close properly. It seemed processes were
spawned differently. Copies of open file descriptors survived in
spawned processes, and I was unable to close files open for writing.
Perhaps the note helps someone.



Bug#920691: lintian gets stuck collecting info after failed objdump-info

2019-01-28 Thread Raphaël Hertzog
Package: lintian
Version: 2.5.123
Severity: important
User: de...@kali.org
Usertags: origin-kali

$ dget 
http://http.kali.org/pool/main/m/metasploit-framework/metasploit-framework_5.0.1-0kali1_amd64.changes
$ lintian --debug metasploit-framework_5.0.1-0kali1_amd64.changes 
N: Lintian v2.5.124
N: Lintian root directory: /usr/share/lintian
N: Configuration file: /etc/lintianrc
N: Laboratory: 
N: UTF-8: ✓ (☃)
N: 
N: Using profile debian/main.
N: Setting up lab in /tmp/temp-lintian-lab-L0aZNzyB6W ...
N: Selected action: check
N: Selected checks: 
apache2,application-not-library,appstream-metadata,automake,binaries,changelog-file,changes-file,conffiles,control-file,control-files,copyright-file,cruft,dbus,deb-format,debconf,debhelper,debian-readme,debian-source-dir,description,duplicate-files,elpa,fields,filename-length,files,gir,group-checks,huge-usr-share,infofiles,init.d,java,manpages,md5sums,menu-format,menus,nmu,obsolete-sites,ocaml,patch-systems,pe,phppear,po-debconf,python,rules,scripts,shared-libs,source-changelog,source-copyright,standards-version,symlinks,systemd,testsuite,triggers,udev,upstream-metadata,upstream-signing-key,usrmerge,version-substvars,watch-file
N: Parallelization limit: 5
N: Starting on group metasploit-framework/5.0.1-0kali1
N: Unpacking packages in group metasploit-framework/5.0.1-0kali1
N: Collecting info: unpacked for binary:metasploit-framework/5.0.1-0kali1/amd64 
...
N: Collecting info: bin-pkg-control for 
binary:metasploit-framework/5.0.1-0kali1/amd64 ...
N: Collection script bin-pkg-control for 
binary:metasploit-framework/5.0.1-0kali1/amd64 done (0.090s)
N: Collection script unpacked for 
binary:metasploit-framework/5.0.1-0kali1/amd64 done (5.759s)
N: Collecting info: file-info for 
binary:metasploit-framework/5.0.1-0kali1/amd64 ...
N: Collecting info: md5sums for binary:metasploit-framework/5.0.1-0kali1/amd64 
...
N: Collecting info: scripts for binary:metasploit-framework/5.0.1-0kali1/amd64 
...
N: Collecting info: changelog-file for 
binary:metasploit-framework/5.0.1-0kali1/amd64 ...
N: Collecting info: ar-info for binary:metasploit-framework/5.0.1-0kali1/amd64 
...
N: Collection script changelog-file for 
binary:metasploit-framework/5.0.1-0kali1/amd64 done (0.011s)
N: Collecting info: override-file for 
binary:metasploit-framework/5.0.1-0kali1/amd64 ...
N: Collection script override-file for 
binary:metasploit-framework/5.0.1-0kali1/amd64 done (0.006s)
N: Collecting info: copyright-file for 
binary:metasploit-framework/5.0.1-0kali1/amd64 ...
N: Collection script copyright-file for 
binary:metasploit-framework/5.0.1-0kali1/amd64 done (0.015s)
N: Collection script ar-info for binary:metasploit-framework/5.0.1-0kali1/amd64 
done (0.733s)
N: Collection script md5sums for binary:metasploit-framework/5.0.1-0kali1/amd64 
done (1.425s)
N: Collection script scripts for binary:metasploit-framework/5.0.1-0kali1/amd64 
done (1.457s)
N: Collection script file-info for 
binary:metasploit-framework/5.0.1-0kali1/amd64 done (25.078s)
N: Collecting info: objdump-info for 
binary:metasploit-framework/5.0.1-0kali1/amd64 ...
N: Collecting info: strings for binary:metasploit-framework/5.0.1-0kali1/amd64 
...
N: Collecting info: java-info for 
binary:metasploit-framework/5.0.1-0kali1/amd64 ...
N: Collection script java-info for 
binary:metasploit-framework/5.0.1-0kali1/amd64 done (0.788s)
Can't close(GLOB(0x556d03f87a30)) filehandle: '' at 
/usr/share/lintian/helpers/coll/objdump-info-helper line 222
command failed with error code 123 at 
/usr/share/lintian/collection/objdump-info line 81.
warning: collect info objdump-info about package metasploit-framework failed 
(512)
warning: skipping check of binary package metasploit-framework
N: Collection script strings for binary:metasploit-framework/5.0.1-0kali1/amd64 
done (3.036s)

And here lintian does not fail, it just gets stuck.

This problem can be reproduced with 2.5.123 and 2.5.124 but not with 2.5.122.

I expect this problem has been introduced with the merge of Niels' work
on switching Lintian::Unpacker to IO::Async:
https://salsa.debian.org/lintian/lintian/commit/7cbc5efd619bb6d5c9bc45504e3ce9893b98f13c

Since lintian is run automatically after sbuild, this is very annoying
as it means builds get stuck on Kali's build daemons.

Cheers,

-- System Information:
Debian Release: buster/sid
  APT prefers oldoldstable
  APT policy: (500, 'oldoldstable'), (500, 'unstable'), (500, 'testing'), (500, 
'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils   2.31.1-11
ii  bzip2  1.0.6-9
ii  diffstat   1.62-1
ii  dpkg