Author: rra Date: 2008-02-04 01:22:38 +0100 (Mon, 04 Feb 2008) New Revision: 1161
Modified: trunk/checks/files trunk/checks/files.desc trunk/debian/changelog trunk/testset/etcfiles/debian/conffiles trunk/testset/etcfiles/debian/rules trunk/testset/tags.etcfiles Log: + [RA] Warn about /etc/cron.{hourly,daily,weekly,monthly} scripts that won't be executed by run-parts because of periods in the name. Patch from Chris Lamb. (Closes: #458742) Modified: trunk/checks/files =================================================================== --- trunk/checks/files 2008-02-03 23:06:18 UTC (rev 1160) +++ trunk/checks/files 2008-02-04 00:22:38 UTC (rev 1161) @@ -155,6 +155,10 @@ if ($file =~ m,^etc/nntpserver, ) { tag "package-uses-obsolete-file", "$file"; } + # ---------------- /etc/cron.daily, etc. + elsif ($file =~ m,^etc/cron\.(daily|hourly|monthly|weekly)/[^\.].*\., ) { + tag "run-parts-cron-filename-contains-full-stop", "$file"; + } # ---------------- /etc/cron.d elsif ($file =~ m,^etc/cron\.d/\S, and $operm != 0644) { tag "bad-permissions-for-etc-cron.d-script", sprintf("$file %04o != 0644",$operm); Modified: trunk/checks/files.desc =================================================================== --- trunk/checks/files.desc 2008-02-03 23:06:18 UTC (rev 1160) +++ trunk/checks/files.desc 2008-02-04 00:22:38 UTC (rev 1161) @@ -346,6 +346,11 @@ will fix this problem for you. Ref: policy 10.5 +Tag: run-parts-cron-filename-contains-full-stop +Type: warning +Info: The script in /etc/cron.<time-interval> will not be executed by + run-parts(8) because the filename contains a "." (full stop). + Tag: bad-permissions-for-etc-cron.d-script Type: error Info: Files in <tt>/etc/cron.d</tt> are configuration files for cron and not Modified: trunk/debian/changelog =================================================================== --- trunk/debian/changelog 2008-02-03 23:06:18 UTC (rev 1160) +++ trunk/debian/changelog 2008-02-04 00:22:38 UTC (rev 1161) @@ -29,6 +29,9 @@ not KDE appears to actively use it still. + [RA] Check for *.devhelp{2,} files not linked into devhelp's search path. Based on a patch by Bradley Smith. (Closes: #273309) + + [RA] Warn about /etc/cron.{hourly,daily,weekly,monthly} scripts that + won't be executed by run-parts because of periods in the name. + Patch from Chris Lamb. (Closes: #458742) * checks/infofiles: + [RA] Don't issue unknown-intepreter for maintainer scripts with weird interpreters. checks/scripts already handles this and the tag Modified: trunk/testset/etcfiles/debian/conffiles =================================================================== --- trunk/testset/etcfiles/debian/conffiles 2008-02-03 23:06:18 UTC (rev 1160) +++ trunk/testset/etcfiles/debian/conffiles 2008-02-04 00:22:38 UTC (rev 1161) @@ -1,2 +1,5 @@ /etc/proper /var/lib/foo +/etc/cron.daily/cronfile-normal +/etc/cron.daily/.cronfile-begins-with-fullstop +/etc/cron.daily/cronfile-contains.fullstop Modified: trunk/testset/etcfiles/debian/rules =================================================================== --- trunk/testset/etcfiles/debian/rules 2008-02-03 23:06:18 UTC (rev 1160) +++ trunk/testset/etcfiles/debian/rules 2008-02-04 00:22:38 UTC (rev 1161) @@ -11,6 +11,10 @@ install -d $(tmp)/etc install -m 644 proper $(tmp)/etc install -m 644 improper $(tmp)/etc + mkdir $(tmp)/etc/cron.daily + touch $(tmp)/etc/cron.daily/cronfile-normal + touch $(tmp)/etc/cron.daily/.cronfile-begins-with-fullstop + touch $(tmp)/etc/cron.daily/cronfile-contains.fullstop ln $(tmp)/etc/improper $(tmp)/etc/improper-link install -d $(tmp)/usr/share/doc/etcfiles install -d $(tmp)/var/lib @@ -21,6 +25,12 @@ install -d $(tmp)/DEBIAN install -m 644 debian/conffiles $(tmp)/DEBIAN + echo '68b329da9893e34099c7d8ad5cb9c940 ./etc/cron.daily/cronfile-normal' \ + > debian/tmp/DEBIAN/md5sums + echo '68b329da9893e34099c7d8ad5cb9c940 ./etc/cron.daily/.cronfile-begins-with-fullstop' \ + > debian/tmp/DEBIAN/md5sums + echo '68b329da9893e34099c7d8ad5cb9c940 ./etc/cron.daily/cronfile-contains.fullstop' \ + > debian/tmp/DEBIAN/md5sums echo 'ab371382468880299e5ebd05921764ce ./etc/proper' \ > debian/tmp/DEBIAN/md5sums echo 'ab371382468880299e5ebd05921764ce etc/improper' \ Modified: trunk/testset/tags.etcfiles =================================================================== --- trunk/testset/tags.etcfiles 2008-02-03 23:06:18 UTC (rev 1160) +++ trunk/testset/tags.etcfiles 2008-02-04 00:22:38 UTC (rev 1161) @@ -12,3 +12,4 @@ W: etcfiles: file-missing-in-md5sums usr/share/doc/etcfiles/changelog W: etcfiles: non-etc-file-marked-as-conffile /var/lib/foo W: etcfiles: package-contains-hardlink etc/improper -> etc/improper-link +W: etcfiles: run-parts-cron-filename-contains-full-stop etc/cron.daily/cronfile-contains.fullstop -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]