Bug#898708: vcs-deprecated-in-debian-infrastructure browse.dgit.debian.org

2018-05-15 Thread Ian Jackson
Package: lintian
Version: 2.5.86

xnox reports that lintian is complaining about
  https://browse.dgit.debian.org/mdadm.git
in vcs-browse.  (FAOD, browse.dgit.debian.org is fully supported
and is not going away.)

I was pointed to this commit which fixes git.dgit.d.o
  
https://salsa.debian.org/lintian/lintian/commit/999a659122e2b328fb6823978640e3a7d5f91f7e
but this is still wrong because the exception regexp does not match
browse.dgit.d.o.

I suggest
  unless $1 =~ m{^(?:salsa|.*\.dgit)$};
since there are no obsolete dgit.d.o urls.

Thanks,
Ian.

-- 
Ian JacksonThese opinions are my own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.



Bug#898715: lintian: fails to parse extended timestamps in tarballs

2018-05-15 Thread Stephen Kitt
Package: lintian
Version: 2.5.85
Severity: normal
Tags: patch

Dear Maintainer,

Now that lintian correctly instructs tar to output full timestamps
(22e197e4), it fails to parse timestamps in tarballs which contain
high-resolution times, such as xmp_4.1.0.orig.tar.gz
(http://http.debian.net/debian/pool/main/x/xmp/xmp_4.1.0.orig.tar.gz):

cannot parse tar output from src-orig-index: -rw-rw-r-- claudio/claudio 926 
2014-11-25 21:47:29.12396808  INSTALL at /usr/share/lintian/checks/cruft.pm 
line 450.
internal error: cannot run cruft check on package source:xmp/4.1.0-1
warning: skipping check of source:xmp/4.1.0-1

The attached patch fixes this.

Regards,

Stephen


-- System Information:
Debian Release: 9.4
  APT prefers stable-debug
  APT policy: (500, 'stable-debug'), (500, 'stable'), (100, 'unstable-debug'), 
(100, 'testing-debug'), (100, 'unstable'), (100, 'testing'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-6-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils  2.28-5
ii  bzip2 1.0.6-8.1
ii  diffstat  1.61-1+b1
ii  dpkg  1.18.24
ii  file  1:5.30-1+deb9u1
ii  gettext   0.19.8.1-2
ii  intltool-debian   0.35.0+20060710.4
ii  libapt-pkg-perl   0.1.32
ii  libarchive-zip-perl   1.59-1
ii  libclass-accessor-perl0.34-1
ii  libclone-perl 0.38-2+b1
ii  libdigest-sha-perl5.96-1+b1
ii  libdpkg-perl  1.18.24
ii  libemail-valid-perl   1.202-1
ii  libfile-basedir-perl  0.07-1
ii  libipc-run-perl   0.94-1
ii  liblist-moreutils-perl0.416-1+b1
ii  libparse-debianchangelog-perl 1.2.0-12
ii  libperl5.24 [libdigest-sha-perl]  5.24.1-3+deb9u3
ii  libtext-levenshtein-perl  0.13-1
ii  libtimedate-perl  2.3000-2
ii  liburi-perl   1.71-1
ii  libxml-simple-perl2.22-1
ii  libyaml-libyaml-perl  0.63-2
ii  man-db2.7.6.1-2
ii  patchutils0.3.4-2
ii  perl  5.24.1-3+deb9u3
ii  t1utils   1.39-2
ii  xz-utils  5.2.2-1.2+b1

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b2

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.18.24
ii  libhtml-parser-perl3.72-3
ii  libtext-template-perl  1.46-1

-- no debconf information
diff --git a/lib/Lintian/Collect/Package.pm b/lib/Lintian/Collect/Package.pm
index a39a54e7a..8feae7f3b 100644
--- a/lib/Lintian/Collect/Package.pm
+++ b/lib/Lintian/Collect/Package.pm
@@ -444,7 +444,7 @@ sub _fetch_index_data {
 # Note this cannot ever be 100% reliable as the filename might contain
 # "fake" dates.
 ($perm,$ownership,$size,$date,$time,$name)
-  = $line=~ /^(.{10}) (.*?) (\d+) ([-\d]{10}) ([:\d]{5,8}) (.*)$/;
+  = $line=~ /^(.{10}) (.*?) (\d+) ([-\d]{10}) ([:\d]{5,8}\.?\d*) 
(.*)$/;
 croak "cannot parse tar output from $index: $line"
   unless defined $perm;
 $ownership =~ s/\s+$//;


Bug#898721: lintian -- maybe false positive on description-starts-with-package-name

2018-05-15 Thread Thorsten Alteholz

Package: lintian
Version: 2.5.82~bpo9+1
Severity: normal


I am not sure whether this is a good english expression, but if so, this is a 
false positive:

Description: base58 encode/decode: command-line interface



 lintian check for base58_1.0.0-1_all.deb 
N: 'base58 encode/decode' is a description of what the package does, not
N: a repeat of the package name.
O: base58: description-starts-with-package-name


 Thorsten



Bug#898759: should report UNRELEASED in a NEWS.Debian file

2018-05-15 Thread Marc Haber
Package: lintian
Version: 2.5.86
Severity: wishlist

Hi,

lintian should report if the NEWS.Debian file contains UNRELEASED in the
top line as a warning.

Greetings
Marc


-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.16.8-zgsrv20080 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8), LANGUAGE=en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils  2.30-19
ii  bzip2 1.0.6-8.1
ii  diffstat  1.61-1+b1
ii  dpkg  1.19.0.5+b1
ii  file  1:5.33-2
ii  gettext   0.19.8.1-6+b1
ii  intltool-debian   0.35.0+20060710.4
ii  libapt-pkg-perl   0.1.34
ii  libarchive-zip-perl   1.60-1
ii  libclass-accessor-perl0.51-1
ii  libclone-perl 0.39-1
ii  libdpkg-perl  1.19.0.5
ii  libemail-valid-perl   1.202-1
ii  libfile-basedir-perl  0.07-1
ii  libipc-run-perl   0.99-1
ii  liblist-moreutils-perl0.416-1+b3
ii  libparse-debianchangelog-perl 1.2.0-12
ii  libperl5.26 [libdigest-sha-perl]  5.26.2-3
ii  libtext-levenshtein-perl  0.13-1
ii  libtimedate-perl  2.3000-2
ii  liburi-perl   1.74-1
ii  libxml-simple-perl2.25-1
ii  libyaml-libyaml-perl  0.69+repack-1
ii  man-db2.8.3-2
ii  patchutils0.3.4-2
ii  perl  5.26.2-3
ii  t1utils   1.41-2
ii  xz-utils  5.2.2-1.3

Versions of packages lintian recommends:
pn  libperlio-gzip-perl  

Versions of packages lintian suggests:
pn  binutils-multiarch 
ii  dpkg-dev   1.19.0.5
ii  libhtml-parser-perl3.72-3+b2
ii  libtext-template-perl  1.53-1

-- no debconf information



Bug#898715: lintian: fails to parse extended timestamps in tarballs

2018-05-15 Thread Chris Lamb
tags 898715 + pending
thanks

Hey Stephen,

Thanks for the patch! I fixed it in a slightly different way, but you
did 90% of the work:

  
https://salsa.debian.org/lintian/lintian.git/commit/f4ee651c1792f6d645014d3aa20490506d981a5c

  debian/changelog   | 5 +
  lib/Lintian/Collect/Package.pm | 3 ++-
  2 files changed, 7 insertions(+), 1 deletion(-)

Thanks again :)


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Processed: Re: lintian: fails to parse extended timestamps in tarballs

2018-05-15 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 898715 + pending
Bug #898715 [lintian] lintian: fails to parse extended timestamps in tarballs
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
898715: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898715
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#898715: lintian: fails to parse extended timestamps in tarballs

2018-05-15 Thread Stephen Kitt
Hi Chris,

On Tue, 15 May 2018 20:00:00 +0100, Chris Lamb  wrote:
> Thanks for the patch! I fixed it in a slightly different way, but you
> did 90% of the work:
> 
>   
> https://salsa.debian.org/lintian/lintian.git/commit/f4ee651c1792f6d645014d3aa20490506d981a5c

Nice, I wasn’t sure how to ensure the group started with a period and then
contained only digits in a Perl regex!

Regards,

Stephen


pgpKr7_dR4thS.pgp
Description: OpenPGP digital signature


Bug#898759: should report UNRELEASED in a NEWS.Debian file

2018-05-15 Thread Chris Lamb
tags 898759 + moreinfo
thanks

Hi Marc,

> lintian should report if the NEWS.Debian file contains UNRELEASED in the
> top line as a warning.

Does Lintian not do this already? For example:

  
https://lintian.debian.org/tags/debian-news-entry-has-strange-distribution.html

We also check for mismatches in the distribution and priority between
debian/changelog.


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Processed: Re: Bug#898759: should report UNRELEASED in a NEWS.Debian file

2018-05-15 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 898759 + moreinfo
Bug #898759 [lintian] should report UNRELEASED in a NEWS.Debian file
Added tag(s) moreinfo.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
898759: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898759
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#898721: lintian -- maybe false positive on description-starts-with-package-name

2018-05-15 Thread Chris Lamb
tags 898721 + moreinfo
thanks

Hi Thorsten,

> I am not sure whether this is a good english expression, but if so, this 
> is a false positive:
> 
> Description: base58 encode/decode: command-line interface

It's "valid" but very clunky. Could you suggest they use, for example:

  command-line interface to encode and decode base58 integers

?

Moreover, I'm not sure what pattern would deterministically detect
this as a false-positive...


Best wishes,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Processed: Re: vcs-deprecated-in-debian-infrastructure browse.dgit.debian.org

2018-05-15 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 898708 + pending
Bug #898708 [lintian] vcs-deprecated-in-debian-infrastructure 
browse.dgit.debian.org
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
898708: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898708
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#898708: vcs-deprecated-in-debian-infrastructure browse.dgit.debian.org

2018-05-15 Thread Chris Lamb
tags 898708 + pending
thanks

Hi Ian,

> browse.dgit.debian.org is fully supported and is not going away.

Was merely an oversight, don't worry. ;)  Applied in Git, pending upload:

  
https://salsa.debian.org/lintian/lintian.git/commit/cdeb447a02cd382ec5c22fb8ace02dfd8280e76b

  checks/fields.pm   | 2 +-
  debian/changelog   | 3 +++
  .../debian/debian/control.in   | 2 +-
  3 files changed, 5 insertions(+), 2 deletions(-)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#898708: vcs-deprecated-in-debian-infrastructure browse.dgit.debian.org

2018-05-15 Thread Ian Jackson
Chris Lamb writes ("Re: vcs-deprecated-in-debian-infrastructure 
browse.dgit.debian.org"):
> tags 898708 + pending
> thanks
> 
> Hi Ian,
> > browse.dgit.debian.org is fully supported and is not going away.
> 
> Was merely an oversight, don't worry. ;)

Right.  I thought I should avoid any doubt though :-).

>  Applied in Git, pending upload:
> 
>   
> https://salsa.debian.org/lintian/lintian.git/commit/cdeb447a02cd382ec5c22fb8ace02dfd8280e76b

Thanks.  FYI, I looked at that in my ordinary browser (very limited
JS, no cookies, etc.) and it invited me to log in.  Surely that is not
right ?

Ian.



Bug#898799: lintian: False positive for debhelper-compat-file-contains-multiple-levels

2018-05-15 Thread Axel Beckert
Package: lintian
Version: 2.5.86
Severity: normal

The following IMHO fully valid and not accidentially with ">>" appended
debian/compat file of debsums triggers the lintian tag
debhelper-compat-file-contains-multiple-levels:

---8<--
10
# Needs to stay on a compat level which is supported in stable,
# i.e. 10 for stretch (and probably 11 for buster)
--->8---

IMO this lintian warning should only be triggered, if each line only
contains numbers and especially does not begin with hash marks as
commonly used for comments.

Currently debhelper only looks at the first line of the debian/compat
file and hence ignores anything behind (which probably also caused this
tag to be implemented), but the tag should be only emitted if those
lines are obviously created by using ">>" instead of ">", not with
arbitrary content.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (980, 'unstable-debug'), (600, 'testing'), 
(111, 'buildd-unstable'), (111, 'buildd-experimental'), (110, 'experimental'), 
(105, 'experimental-debug')
Architecture: amd64 (x86_64)

Kernel: Linux 4.15.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils  2.30-19
ii  bzip2 1.0.6-8.1
ii  diffstat  1.61-1+b1
ii  dpkg  1.19.0.5+b1
ii  file  1:5.33-2
ii  gettext   0.19.8.1-6+b1
ii  intltool-debian   0.35.0+20060710.4
ii  libapt-pkg-perl   0.1.34
ii  libarchive-zip-perl   1.60-1
ii  libclass-accessor-perl0.51-1
ii  libclone-perl 0.39-1
ii  libdigest-sha-perl6.02-1
ii  libdpkg-perl  1.19.0.5
ii  libemail-valid-perl   1.202-1
ii  libfile-basedir-perl  0.08-1
ii  libipc-run-perl   0.99-1
ii  liblist-moreutils-perl0.416-1+b3
ii  libparse-debianchangelog-perl 1.2.0-12
ii  libperl5.26 [libdigest-sha-perl]  5.26.2-3
ii  libtext-levenshtein-perl  0.13-1
ii  libtimedate-perl  2.3000-2
ii  liburi-perl   1.74-1
ii  libxml-simple-perl2.25-1
ii  libyaml-libyaml-perl  0.69+repack-1
ii  man-db2.8.3-2
ii  patchutils0.3.4-2
ii  perl  5.26.2-3
ii  t1utils   1.41-2
ii  xz-utils  5.2.2-1.3

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b4

Versions of packages lintian suggests:
ii  binutils-multiarch 2.30-19
ii  dpkg-dev   1.19.0.5
ii  libhtml-parser-perl3.72-3+b2
ii  libtext-template-perl  1.53-1

-- no debconf information



Bug#898799: lintian: False positive for debhelper-compat-file-contains-multiple-levels

2018-05-15 Thread Axel Beckert
Hi,

to be more precise:

Axel Beckert wrote:
> The following IMHO fully valid and not accidentially with ">>" appended
> debian/compat file of debsums [...]

... as currently in git:
https://salsa.debian.org/perl-team/modules/packages/debsums/blob/master/debian/compat

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Bug#898809: lintian -F internal error: cannot run shared-libs check on package binary

2018-05-15 Thread Matthias Klose
Package: lintian
Version: 2.5.86
Severity: important
Tags: sid buster

This causes the gcc-8-cross packages built on amd64 and i386 failing the lintian
-F check during upload (packages at p.d.o/~d.../tmp).

$ lintian -F ../gcc-8-cross_16_amd64.changes 2>&1 | tee ../log.lintian
Use of uninitialized value $lib in pattern match (m//) at
/usr/share/lintian/checks/files.pm line 339.
Use of uninitialized value $val in split at
/usr/share/perl5/Lintian/Collect/Binary.pm line 423, <$_[...]> line 22776.
Use of uninitialized value $val in split at
/usr/share/perl5/Lintian/Collect/Binary.pm line 423, <$_[...]> line 22776.
internal error: shlib usr/lib/gcc-cross/arm-linux-gnueabi/8/libgo.a(log.o) not
found in package (should not happen!) at
/usr/share/lintian/checks/shared-libs.pm line 198.
internal error: cannot run shared-libs check on package
binary:gccgo-8-arm-linux-gnueabi/8.1.0-3cross2/amd64
warning: skipping check of binary:gccgo-8-arm-linux-gnueabi/8.1.0-3cross2/amd64



Bug#898708: vcs-deprecated-in-debian-infrastructure browse.dgit.debian.org

2018-05-15 Thread Mattia Rizzolo
On Tue, May 15, 2018 at 10:03:04PM +0100, Ian Jackson wrote:
> Chris Lamb writes ("Re: vcs-deprecated-in-debian-infrastructure 
> browse.dgit.debian.org"):
> >  Applied in Git, pending upload:
> > 
> >   
> > https://salsa.debian.org/lintian/lintian.git/commit/cdeb447a02cd382ec5c22fb8ace02dfd8280e76b
> 
> Thanks.  FYI, I looked at that in my ordinary browser (very limited
> JS, no cookies, etc.) and it invited me to log in.  Surely that is not
> right ?

That's because that address doesn't exist, but gitlab asks you to log in
case that url is private ("403" and 404 are handled the same way by
gitlab).

Chris: those urls should not contain '.git' :)

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
more about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature