Bug#545430: Better warning/error when compat contains spaces.
Package: lintian Version: 2.2.14 Severity: minor Hi Looking at junitperf's lintian warnings/errors[1] I noticed that lintian said debhelper-compat-not-a-number, followed by deprecated compat version 4. It turns out that the compat file had a trailing whitespace, which triggered this. I think lintian should either have a separate tag for this or at least have the tag info updated to include that whitespaces triggers this error. Alternatively lintian should simply ignore whitespaces in compat during this test (this is what it does on the deprecated compat version test anyway). ~Niels [1] http://lintian.debian.org/maintainer/pkg-java-maintain...@lists.alioth.debian.org.html#junitperf -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.30-1-686 (SMP w/2 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils 2.19.51.20090723-1 The GNU assembler, linker and bina ii diffstat 1.47-1 produces graph of changes introduc ii dpkg-dev 1.15.3.1 Debian package development tools ii file 5.03-1 Determines file type using magic ii gettext 0.17-7 GNU Internationalization utilities ii intltool-debian 0.35.0+20060710.1 Help i18n of RFC822 compliant conf ii libapt-pkg-perl 0.1.24 Perl interface to libapt-pkg ii libipc-run-perl 0.84-1 Perl module for running processes ii libparse-debianchange 1.1.1-2parse Debian changelogs and output ii libtimedate-perl 1.1600-9 Time and date functions for Perl ii liburi-perl 1.37+dfsg-1Manipulates and accesses URI strin ii man-db2.5.6-1on-line manual pager ii perl [libdigest-sha-p 5.10.0-25 Larry Wall's Practical Extraction lintian recommends no packages. Versions of packages lintian suggests: ii binutils-multiarch2.19.51.20090723-1 Binary utilities that support mult pn libtext-template-perl none (no description available) ii man-db2.5.6-1on-line manual pager -- no debconf information -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#557883: lintian: false positive in lib-recommends-documentation (name vs. content)
Hi I would also like -doc to be added to the special case list or/and any (binary) package in Section: docs [1]. ~Niels [1] liblucene2-java-doc recommends ant-doc causes false postive as well: http://lintian.debian.org/maintainer/pkg-java-maintain...@lists.alioth.debian.org.html#lucene2 signature.asc Description: OpenPGP digital signature
Bug#566948: lintian: [reporting] List packages with a given tag by a given maintainer
Package: lintian Version: 2.3.1 Severity: wishlist Hi Currently lintian.d.o allows me to see either all the packages maintained by my team or all packages affected by a given tag. Would it be possible to get all packages maintained by $X and with tag $Y as well? ~Niels -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.30-2-686 (SMP w/2 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils 2.20-5The GNU assembler, linker and bina ii diffstat 1.47-1produces graph of changes introduc ii dpkg-dev 1.15.5.6 Debian package development tools ii file 5.03-5Determines file type using magic ii gettext0.17-8GNU Internationalization utilities ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf ii libapt-pkg-perl0.1.24Perl interface to libapt-pkg ii libclass-accessor-perl 0.34-1Perl module that automatically gen ii libipc-run-perl0.84-1Perl module for running processes ii libparse-debianchangel 1.1.1-2 parse Debian changelogs and output ii libtimedate-perl 1.1900-1 Time and date functions for Perl ii liburi-perl1.50-1module to manipulate and access UR ii man-db 2.5.6-5 on-line manual pager ii perl [libdigest-sha-pe 5.10.1-8 Larry Wall's Practical Extraction lintian recommends no packages. Versions of packages lintian suggests: pn binutils-multiarchnone (no description available) pn libtext-template-perl none (no description available) ii man-db2.5.6-5on-line manual pager -- no debconf information -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#574771: lintian: [new check] Warning about files/symlinks called * or *.$ext
Package: lintian Version: 2.3.3 Severity: wishlist Hi A restructure of a debian/rules file lead to one of my packages containing symlinks called usr/share/java/* and usr/share/java/*.jar pointing to ../../lib/eclipse/plugins/* and ../../lib/eclipse/plugins/*.jar respectively. I think it is fairly safe to assume that this is an issue if there are no overrides. ~Niels -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.32-trunk-686 (SMP w/2 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils 2.20.1-2 The GNU assembler, linker and bina ii diffstat 1.47-1produces graph of changes introduc ii dpkg-dev 1.15.5.6 Debian package development tools ii file 5.04-1Determines file type using magic ii gettext0.17-10 GNU Internationalization utilities ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf ii libapt-pkg-perl0.1.24Perl interface to libapt-pkg ii libclass-accessor-perl 0.34-1Perl module that automatically gen ii libipc-run-perl0.84-1Perl module for running processes ii libparse-debianchangel 1.1.1-2 parse Debian changelogs and output ii libtimedate-perl 1.2000-1 collection of modules to manipulat ii liburi-perl1.52-1module to manipulate and access UR ii locales2.10.2-6 Embedded GNU C Library: National L ii man-db 2.5.7-2 on-line manual pager ii perl [libdigest-sha-pe 5.10.1-11 Larry Wall's Practical Extraction lintian recommends no packages. Versions of packages lintian suggests: pn binutils-multiarchnone (no description available) ii libtext-template-perl 1.45-1 Text::Template perl module ii man-db2.5.7-2on-line manual pager -- no debconf information -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100320212437.30905.398.report...@getsu.thykier.net
Bug#575447: lintian: Please add a warning in a .jar is not in /usr/share/java/
Hi I am not sure I can support this. There has been an interest in allowing a package to install private jar files in /usr/share/pkg/. Though jar files beneath /usr/lib/ is *usually* a problem (the swt jars are known exceptions). Though I think these are so rare that an override is in order for these. Adding a warning for jars beneath /usr/lib/ will cause a warning explosion in eclipse, but I am okay with that! I suspect quite a few of them can be moved to /usr/share/ and a lintian warning will serve as a good reminder of that. ~Niels signature.asc Description: OpenPGP digital signature
Bug#575447: [Fwd: Re: Bug#575447: lintian: Please add a warning in a .jar is not in /usr/share/java/]
I see I accidentally failed to send this to the bug report
Original Message
Subject: Re: Bug#575447: lintian: Please add a warning in a .jar is not
in /usr/share/java/
Date: Thu, 25 Mar 2010 22:49:05 +0100
From: Niels Thykier ni...@thykier.net
To: Sylvestre Ledru sylves...@debian.org
References: 4babcb51.9080...@thykier.net
1269550852.5310.262.ca...@zlarin
Sylvestre Ledru wrote:
Le jeudi 25 mars 2010 à 21:45 +0100, Niels Thykier a écrit :
Hi
I am not sure I can support this. There has been an interest in allowing
a package to install private jar files in /usr/share/pkg/.
Though jar files beneath /usr/lib/ is *usually* a problem (the swt jars
are known exceptions). Though I think these are so rare that an override
is in order for these. Adding a warning for jars beneath /usr/lib/ will
cause a warning explosion in eclipse, but I am okay with that! I suspect
quite a few of them can be moved to /usr/share/ and a lintian warning
will serve as a good reminder of that.
I am not sure to follow you. In the first paragraph, you say you do not
agree and in the second, reading between the lines, I have the feeling
you think it might be relevant. Am I wrong ?
Hi
I agree with the need for a warning for jars being in weird places, but
I disagree that a jar file beneath /usr/share/pkg/ should trigger a
warning (e.g I am okay with a warning for anywhere but /usr/share/java
and /usr/share/pkg/).
Consider (e.g.) ant uses symlinks from /usr/share/ant/lib/ into
/usr/share/java/, so /usr/share/pkg (and beneath) should definitely be
allowed.
Though there are more valid exceptions: maven has a public
repository that packages are encouraged to install their jars in (or
symlinks to them) beneath /usr/share/maven-repo.
The second paragraph was more informational to say that we have rare
cases where /usr/lib/java or /usr/lib/pkg is the correct location for
a jar-file (e.g. when storing native pointers in java code).
Though I believe these to be so rare that it would be acceptable to
force packages legally shipping jars beneath /usr/lib/ to add an override.
That being said. Java Virtual Machines are allowed to ship jar files
beneath /usr/lib/jvm/${dir}/ (${dir} does not equal package name).
Also, I think we should allow a symlink in /usr/lib/ to point to a jar
file in a valid location beneath /usr/share. Java projects usually do
not care about correct file system layouts - patching all ~1638 jars
to respect FHS is not just not feasible [1]!
BTW, I am just asking for a warning, not an error ;)
Sylvestre
Actually, I think jars beneath /usr/lib/ might be good candidate for an
error (that can be overridden). Java is supposed to be arch:all and thus
so should jar files. Personally I only know one valid exception
(swt.jar)[2].
~Niels
[1] Generated via:
apt-file search .jar | grep -v /usr/share/java | grep -v /usr/lib/jvm |
grep -E .jar\$ | grep -v /usr/share | wc -l
The number may be inflated since I get data from testing and unstable
and some of these may just be symlinks.
[2] Though due to symlinks, this may trigger more than one warning/error.
signature.asc
Description: OpenPGP digital signature
Bug#580700: lintian: Typo in duplicated-key-in-desktop-entry description
Package: lintian Version: 2.4.1 Severity: minor Hi I think a s/took/tool/ is needed :) N: duplicated-key-in-desktop-entry N: N: The desktop entry contains two instances of the same key. The behavior N: of such desktop entries is not well-defined by the standard. N: N: The desktop-file-validate took in the desktop-file-utils package is N: useful for checking the syntax of desktop entries. N: N: Severity: normal, Certainty: certain N: ~Niels -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.32-trunk-686 (SMP w/2 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils 2.20.1-5 The GNU assembler, linker and bina ii diffstat 1.47-1produces graph of changes introduc ii dpkg-dev 1.15.7.1 Debian package development tools ii file 5.04-2Determines file type using magic ii gettext0.17-11 GNU Internationalization utilities ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf ii libapt-pkg-perl0.1.24Perl interface to libapt-pkg ii libclass-accessor-perl 0.34-1Perl module that automatically gen ii libipc-run-perl0.89-1Perl module for running processes ii libparse-debianchangel 1.1.1-2 parse Debian changelogs and output ii libtimedate-perl 1.2000-1 collection of modules to manipulat ii liburi-perl1.54-1module to manipulate and access UR ii locales2.10.2-6 Embedded GNU C Library: National L ii man-db 2.5.7-2 on-line manual pager ii perl [libdigest-sha-pe 5.10.1-12 Larry Wall's Practical Extraction lintian recommends no packages. Versions of packages lintian suggests: pn binutils-multiarchnone (no description available) ii libtext-template-perl 1.45-1 Text::Template perl module ii man-db2.5.7-2on-line manual pager -- no debconf information -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100507205711.22149.10236.report...@getsu.thykier.net
Bug#575661: [checks/manpages] manpage-has-errors for multibyte issue on, col must be skipped?
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Osamu Aoki wrote: David, can you clarify what is your problem and why reopend this. I noticed the email [1] was only sent to cont...@b.d.o, but should also have been sent to 575...@b.d.o. David: please remember to also send such an email to the correct bug :) ~Niels [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=55;bug=575661 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEAREIAAYFAkxSchUACgkQVCqoiq1Ylqxq3ACgpB1slq4ZGOzaxvZ5avQPxBI1 mBYAoKJHDD+A4RBiMaIDhCiYaN6WX57a =px/M -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4c527216.2030...@thykier.net
Bug#593832: lintian: Build-Depends for the lintian test suite
Package: lintian
Version: 2.4.3
Severity: wishlist
Hi
I have tried to figure out the test suite dependencies; Beyond lintian's
Build-Depends{,-Indep} I also installed lintian's dependencies and the
following packages.
libtext-template-perl
rsync
fakeroot
quilt (fields-quilt-debhelper)
python [1] (maybe? relations - old)
On a related note, the test relations of the old test suite might be
broken with the newer dpkg, which no longer accepts as a part of the
version string.
[1] the test relations from the old suite runs:
python -V || true
at some point, so I am not sure it is required. I just installed it when
I noticed this, so a later test might need it.
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores)
Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages lintian depends on:
ii binutils 2.20.1-12 The GNU assembler, linker and bina
ii diffstat 1.53-1produces graph of changes introduc
ii dpkg-dev 1.15.7.2 Debian package development tools
ii file 5.04-5Determines file type using magic
ii gettext0.18.1.1-1GNU Internationalization utilities
ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii libapt-pkg-perl0.1.24Perl interface to libapt-pkg
ii libclass-accessor-perl 0.34-1Perl module that automatically gen
ii libipc-run-perl0.89-1Perl module for running processes
ii libparse-debianchangel 1.1.1-2.1 parse Debian changelogs and output
ii libtimedate-perl 1.2000-1 collection of modules to manipulat
ii liburi-perl1.54-1module to manipulate and access UR
ii locales2.11.2-2 Embedded GNU C Library: National L
ii man-db 2.5.7-3 on-line manual pager
ii perl [libdigest-sha-pe 5.10.1-14 Larry Wall's Practical Extraction
lintian recommends no packages.
Versions of packages lintian suggests:
pn binutils-multiarchnone (no description available)
ii libtext-template-perl 1.45-1 Text::Template perl module
ii man-db2.5.7-3on-line manual pager
-- no debconf information
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/20100821123900.24016.44610.report...@getsu.thykier.net
Bug#593837: [new check] Use of openjdk-6-doc/classpath-doc in B-D instead of default-jdk-doc
Package: lintian
Version: 2.4.3
Severity: wishlist
Tags: patch
Hi
I have created a new check to test if a package B-D(-I) on openjdk-6-doc
or classpath-doc instead of the default-jdk-doc. The rationale is that
default-jdk-doc is a meta package that will pull a system level jdk
documentation (javadoc) and put it in a unified location (using symlinks).
Using default-jdk-doc also allows us to later switch to a newer doc (e.g
openjdk-7-doc) by simply updating default-jdk-doc and not a lot java
packages.
The tag description may need some improvement and the check itself is
done in the part checking all the Build-{Depends*,Conflicts*} fields.
It may make more sense to move it into a part only checking B-D{,-I},
but I could not find such a part and honestly could not see why you
would ever need to Build-Conflict on a doc package.
The check comes with a simple test case to catch the openjdk-6-doc
case.
~Niels
*** 0001-Add-check-for-build-depending-on-specific-system-jav.patch
From 995d68ba31dab3fa80cdab5e839bfb21d927025c Mon Sep 17 00:00:00 2001
From: Niels Thykier ni...@thykier.net
Date: Sat, 21 Aug 2010 14:15:32 +0200
Subject: [PATCH] Add check for build-depending on specific system javadoc
instead
of default-jdk-doc
---
checks/fields|4
checks/fields.desc |8
t/tests/fields-java/debian/debian/control.in | 16
t/tests/fields-java/debian/debian/install|1 +
t/tests/fields-java/debian/some-file |2 ++
t/tests/fields-java/desc |6 ++
t/tests/fields-java/tags |1 +
7 files changed, 38 insertions(+), 0 deletions(-)
create mode 100644 t/tests/fields-java/debian/debian/control.in
create mode 100644 t/tests/fields-java/debian/debian/install
create mode 100644 t/tests/fields-java/debian/some-file
create mode 100644 t/tests/fields-java/desc
create mode 100644 t/tests/fields-java/tags
diff --git a/checks/fields b/checks/fields
index 5b4b5e7..5161ae2 100644
--- a/checks/fields
+++ b/checks/fields
@@ -726,6 +726,10 @@ if ($type eq source) {
}
}
+ if($d_pkg =~ m/openjdk-\d+-doc/o or
$d_pkg eq 'classpath-doc'){
+ tag
'build-depends-on-specific-java-doc-package', $d_pkg;
+ }
+
tag
'conflicting-negation-in-source-relation', $field: $part_d_orig
unless (not $d_arch or $d_arch-[1]
== 0 or $d_arch-[1] eq @{ $d_arch-[0] });
diff --git a/checks/fields.desc b/checks/fields.desc
index eff85cc..2a77b7e 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -992,3 +992,11 @@ Info: The given package appears to have a Python
development package
If you are building a Python extension instead, you should have
development packages listed in Build-Depends, but normally there should
be at least one Architecture: any package.
+
+Tag: build-depends-on-specific-java-doc-package
+Severity: normal
+Certainty: certain
+Info: The given package declares a build dependency on either openjdk-
+ X-doc or classpath-doc instead of using default-jdk-doc. default-jdk-doc
+ provides a symlink to the API via /usr/share/default-jdk-doc/api.
+
diff --git a/t/tests/fields-java/debian/debian/control.in
b/t/tests/fields-java/debian/debian/control.in
new file mode 100644
index 000..8dbc64a
--- /dev/null
+++ b/t/tests/fields-java/debian/debian/control.in
@@ -0,0 +1,16 @@
+Source: {$srcpkg}
+Priority: extra
+Section: java
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends: debhelper (= 7.0.50~), openjdk-6-doc
+
+Package: lib{$srcpkg}-java
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian. It is part of the Lintian test suite and may do very odd
+ things. It should not be installed like a regular package. It may
+ be an empty package.
+
diff --git a/t/tests/fields-java/debian/debian/install
b/t/tests/fields-java/debian/debian/install
new file mode 100644
index 000..6c37889
--- /dev/null
+++ b/t/tests/fields-java/debian/debian/install
@@ -0,0 +1 @@
+some-file usr/share/lintian
diff --git a/t/tests/fields-java/debian/some-file
b/t/tests/fields-java/debian/some-file
new file mode 100644
index 000..7bf08f7
--- /dev/null
+++ b/t/tests/fields-java/debian/some-file
@@ -0,0 +1,2 @@
+This file is installed into /usr/share/lintian just to ensure that this
+package doesn't look like a metapackage for the dependency checks.
diff --git a/t/tests/fields-java/desc b/t/tests/fields-java/desc
new file mode 100644
index 000..12e1005
--- /dev/null
+++ b/t/tests/fields-java/desc
@@ -0,0 +1,6 @@
+Testname: fields
Bug#605844: lintian: Consider pre-sorting keys %{$info-index}
Package: lintian
Version: 2.4.4
Hi
I examined the source of lintian (pulled from git) and noticed that
lintian could probably benefit from looking at common access patterns.
In the checks, there are 13 accesses to 'keys %{$info-index}'; 11 of
these are 'sort keys %{$info-index}'. This means that the list of
files is sorted 11 times!
grep '%{$info-index}' checks/*
checks/changelog-file:foreach (sort keys %{$info-index}) {
checks/copyright-file:foreach (sort keys %{$info-index}) {
checks/etcfiles:foreach my $file (sort keys %{$info-index}) {
checks/fields: for my $file (keys %{$info-index}) {
checks/files:for my $file (sort keys %{$info-index}) {
checks/files:foreach my $file (sort keys %{$info-index}) {
checks/files:foreach my $dir (sort keys %{$info-index}) {
checks/infofiles:foreach my $file (sort keys %{$info-index}) {
checks/manpages:foreach my $file (sort keys %{$info-index}) {
checks/menu-format:foreach my $file (sort keys %{$info-index}) {
checks/menus:for my $file (sort keys %{$info-index}) {
checks/scripts:foreach (sort keys %{$info-index}) {
checks/scripts: unless (grep { $_ =~ m/$divertrx/ } keys %{$info-index});
checks/shared-libs:for my $cur_file (sort keys %{$info-index}) {
This hurts a bit for larger packages; it might be a good idea to
supply a $info-sorted_index or so.
~Niels
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/aanlktimm3atgnh1l5xvxsft3hsfd8vrpvxx8zowsc...@mail.gmail.com
Bug#605844: lintian: Consider pre-sorting keys %{$info-index}
Interestingly enough this does not appear to be the current bottle
neck of lintian (or I am doing something wrong in my patch).
~Niels
$ dpkg --contents eclipse-platform-data_3.5.2-8_all.deb | wc -l
1480
lintian 2.4.3
$ for i in {1..5} ; do time lintian -EI --pedantic
eclipse-platform-data_3.5.2-8_all.deb ; done
real0m9.170s
user0m4.556s
sys 0m0.908s
real0m9.083s
user0m4.628s
sys 0m0.868s
real0m10.285s
user0m4.600s
sys 0m0.928s
real0m9.762s
user0m4.524s
sys 0m0.972s
real0m8.833s
user0m4.624s
sys 0m0.864s
lintian 2.4.4 (from git with patch)
$ for i in {1..5} ; do time lintian -EI --pedantic
eclipse-platform-data_3.5.2-8_all.deb ; done
real0m7.659s
user0m4.484s
sys 0m1.024s
real0m9.412s
user0m4.556s
sys 0m0.944s
real0m8.672s
user0m4.496s
sys 0m0.992s
real0m9.090s
user0m4.496s
sys 0m0.976s
real0m9.000s
user0m4.460s
sys 0m1.052s
diff --git a/checks/changelog-file b/checks/changelog-file
index 8147095..40f4b0f 100644
--- a/checks/changelog-file
+++ b/checks/changelog-file
@@ -79,7 +79,7 @@ for my $file (sort keys %{$info-file_info}) {
}
# Read package contents Capitalization errors are dealt with later.
-foreach (sort keys %{$info-index}) {
+foreach (@{$info-sorted_index}) {
next unless length $_;
# skip packages which have a /usr/share/doc/$pkg - foo symlink
if (m,usr/share/doc/$ppkg$, and defined $info-index-{$_}-{link}) {
diff --git a/checks/copyright-file b/checks/copyright-file
index 336d0f4..267ed43 100644
--- a/checks/copyright-file
+++ b/checks/copyright-file
@@ -45,7 +45,7 @@ my $found = 0;
my $linked = 0;
# Read package contents...
-foreach (sort keys %{$info-index}) {
+foreach (@{$info-sorted_index}) {
my $index_info = $info-index-{$_};
if (m,usr/(share/)?doc/$ppkg/copyright(\.\S+)?$,) {
my $ext = $2;
diff --git a/checks/etcfiles b/checks/etcfiles
index bc61715..9a734b1 100644
--- a/checks/etcfiles
+++ b/checks/etcfiles
@@ -45,7 +45,7 @@ if (open(IN, '', $conffiles)) {
}
# Read package contents...
-foreach my $file (sort keys %{$info-index}) {
+foreach my $file (@{$info-sorted_index}) {
my $index_info = $info-index-{$file};
next unless $file =~ m,^etc, and $index_info-{type}=~ m/^[-h]/;
diff --git a/checks/fields b/checks/fields
index e5f7108..848e9ac 100644
--- a/checks/fields
+++ b/checks/fields
@@ -503,7 +503,7 @@ if (defined $info-field('installer-menu-item')) {
my $metapackage = 0;
if ($type eq 'binary') {
$metapackage = 1;
- for my $file (keys %{$info-index}) {
+ for my $file (@{$info-sorted_index}) {
next if $info-index-{$file}-{type} =~ /^d/;
next if $file =~ m%^usr/share/doc/%;
next if $file =~ m%^usr/share/lintian/overrides/%;
diff --git a/checks/files b/checks/files
index 56cf40b..aa140dc 100644
--- a/checks/files
+++ b/checks/files
@@ -199,7 +199,7 @@ if ($description) {
}
}
if ($is_empty) {
-for my $file (sort keys %{$info-index}) {
+for my $file (@{$info-sorted_index}) {
# Ignore directories
unless ($file =~ m,/$,) {
# Skip if $file is an empty string
@@ -226,7 +226,7 @@ if ($is_empty) {
}
# Read package contents...
-foreach my $file (sort keys %{$info-index}) {
+foreach my $file (@{$info-sorted_index}) {
next if $file eq ;
my $index_info = $info-index-{$file};
my $owner = $index_info-{owner} . '/' . $index_info-{group};
@@ -1204,7 +1204,7 @@ if ($pkg_section !~ m,games$, and $games 0 and $other == 0) {
# so just ignore them.
#
# python-support needs a directory for each package even it might be empty
-foreach my $dir (sort keys %{$info-index}) {
+foreach my $dir (@{$info-sorted_index}) {
next if $dir eq or $info-index-{$dir}-{type} ne 'd';
next if ($dir =~ m{^var/} or $dir =~ m{^etc/});
next if $pkg eq 'base-files';
diff --git a/checks/infofiles b/checks/infofiles
index 2c5b994..872a74b 100644
--- a/checks/infofiles
+++ b/checks/infofiles
@@ -40,7 +40,7 @@ my %missing_section;
my $has_info_file;
# Read package contents...
-foreach my $file (sort keys %{$info-index}) {
+foreach my $file (@{$info-sorted_index}) {
my $index_info = $info-index-{$file};
my $file_info = $info-file_info-{$file};
my $link = $index_info-{link} || '';
diff --git a/checks/manpages b/checks/manpages
index 0035bda..17912d2 100644
--- a/checks/manpages
+++ b/checks/manpages
@@ -40,7 +40,7 @@ my %link;
my %manpage;
# Read package contents...
-foreach my $file (sort keys %{$info-index}) {
+foreach my $file (@{$info-sorted_index}) {
my $index_info = $info-index-{$file};
my $file_info = $info-file_info-{$file};
my $link = $index_info-{link} || '';
diff --git a/checks/menu-format b/checks/menu-format
index bbb4bc8..4e85dae 100644
--- a/checks/menu-format
+++ b/checks/menu-format
@@ -396,7 +396,7 @@ closedir MENUDIR;
# Find the desktop files in the package for verification.
my @desktop_files;
Bug#605844: lintian: Consider pre-sorting keys %{$info-index}
On Sat, Dec 4, 2010 at 2:09 AM, Raphael Geissert geiss...@debian.org wrote: Hi Niels! [OT but using the opportunity: congrats! :)] Thanks :) Niels Thykier wrote: Interestingly enough this does not appear to be the current bottle neck of lintian (or I am doing something wrong in my patch). Thanks for the analysis and the suggestion (don't know if Russ is going to beat me at merging the patch -- Hi Russ :) From some of my benchmarks the biggest bottle neck is at data collection time, objdump and file-info being the two that take the longest to be able to run (dependencies) and to run. Maybe it would be worth adding some highres timestamps to the debugging messages, to get a better idea without running a complete profiler. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net Hmm... could be interesting to see if we could do something about that. If time permits I will have a look. ~Niels -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/aanlktik3h1x24zruyq_umhio0k48hsz_0vv9uyosk...@mail.gmail.com
Bug#605844: lintian: Consider pre-sorting keys %{$info-index}
On Sat, Dec 4, 2010 at 1:57 AM, Russ Allbery r...@debian.org wrote: Niels Thykier nthyk...@gmail.com writes: Interestingly enough this does not appear to be the current bottle neck of lintian (or I am doing something wrong in my patch). It's probably a good change regardless, but sorting is generally very fast. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ True, turns out that the keys operation is apparently not too bad either ;) ~Niels -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/aanlktikpynmwfuujct3iaameqf904gow5kjcnxjpc...@mail.gmail.com
Bug#605844: lintian: Consider pre-sorting keys %{$info-index}
On Tue, Dec 7, 2010 at 10:02 PM, Niels Thykier nthyk...@gmail.com wrote:
Hmm... could be interesting to see if we could do something about
that. If time permits I will have a look.
~Niels
I guess I had time! Trivial testing on the eclipse-platform-data shows
that neither objdump-info[1] nor file-info are slow themselves.
The problem (in this case) is unpacked[2]:
$ time lintian ../eclipse/eclipse-platform-data_3.5.2-8_all.deb
N: unpacked took 3.707902 sec.
N: file-info took 0.03248 sec.
N: objdump-info took 0.00161 sec.
real0m8.383s
user0m4.644s
sys 0m0.924s
The actual timed part is:
@ss = gettimeofday();
my $opts = { err = unpacked-errors };
spawn($opts,
['dpkg-deb', '--fsys-tarfile', deb],
'|', ['tar', 'xf', '-', '-C', unpacked]);
unless ($opts-{success}) {
open(ERRORS, '', unpacked-errors)
or fail(cannot open unpacked-errors: $!);
print STDERR while ERRORS;
close ERRORS;
fail(dpkg-deb | tar failed with status , $opts-{harness}-result);
}
@end = gettimeofday();
So the slow end here is (hopefully) the dpkg-deb | tar pipe, which
is sort of unfortunate (since I cannot think of a way to trivially
optimise this). According to a comment in unpacked, the pipe is done
to avoid the poor performance of dpkg-deb's syncing (which is not
really required for lintian's use).
~Niels
[1] Note eclipse-platform-data contains no binaries - only images etc,
so objdump-info may perform worse on a package with a lot of binaries.
[2] The timing info was only done on a binary package - so a source
package may do even better or even worse.
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/aanlktimekk+nuo_fv+aojrsasd46hggwco35stj-d...@mail.gmail.com
Bug#606270: lintian: commit 894daa630bdf (most likely) caused test regressions
Package: lintian Version: 2.4.4 test output: ... Running test distribution-ubuntu-native 1.0... building... testing... FAILED: --- t/tests/distribution-ubuntu-native/tags 2010-08-03 15:05:07.354069756 +0200 +++ debian/tests/tags.distribution-ubuntu-native2010-12-07 23:21:50.378531654 +0100 @@ -0,0 +1 @@ +E: distribution-ubuntu-native_1.0_i386 changes: bad-distribution-in-changes-file jaunty ... Running test nmu-ubuntu-native 1.0... building... testing... FAILED: --- t/tests/nmu-ubuntu-native/tags 2010-08-03 15:05:07.775100644 +0200 +++ debian/tests/tags.nmu-ubuntu-native 2010-12-07 23:38:15.819550625 +0100 @@ -0,0 +1,3 @@ +E: nmu-ubuntu-native_1.0_i386 changes: bad-distribution-in-changes-file jaunty +W: nmu-ubuntu-native source: changelog-should-mention-nmu +W: nmu-ubuntu-native source: source-nmu-has-incorrect-version-number 1.0 ... I strongly suspect that this commit[1] broke these tests when the commit did not update the tests to reflect current valid Ubuntu code names. ~Niels [1] http://git.debian.org/?p=lintian/lintian.git;a=commit;h=894daa630bdf88e59ff3683857d1d808be2d3c1b -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/aanlktikecu5att+qdp2fxkmroc+b5yfrwccmuc3ra...@mail.gmail.com
Bug#582767: lintian: if Package format 3.0 is in use report warning for quilt in Depebds:
tags 582767 + patch
thanks
Hi
I have created a patch that implements this check with a small test case for it.
~Niels
From 0bd1d202b0f46598eff33cd8d522161c1e5f37ff Mon Sep 17 00:00:00 2001
From: Niels Thykier ni...@thykier.net
Date: Tue, 7 Dec 2010 23:48:52 +0100
Subject: [PATCH] Added check for unneeded build-dep on quilt when building a 3.0 (quilt) package,
including a test case for it.
---
checks/patch-systems |3 +++
checks/patch-systems.desc |8
.../debian/debian/README.source|1 +
.../debian/debian/control.in | 15 +++
.../debian/debian/source/format|1 +
t/tests/patch-systems-quilt-source/desc|7 +++
t/tests/patch-systems-quilt-source/tags|1 +
t/tests/patch-systems-quilt-source/upstream/README |1 +
8 files changed, 37 insertions(+), 0 deletions(-)
create mode 100644 t/tests/patch-systems-quilt-source/debian/debian/README.source
create mode 100644 t/tests/patch-systems-quilt-source/debian/debian/control.in
create mode 100644 t/tests/patch-systems-quilt-source/debian/debian/source/format
create mode 100644 t/tests/patch-systems-quilt-source/desc
create mode 100644 t/tests/patch-systems-quilt-source/tags
create mode 100644 t/tests/patch-systems-quilt-source/upstream/README
diff --git a/checks/patch-systems b/checks/patch-systems
index 9934d46..73337e9 100644
--- a/checks/patch-systems
+++ b/checks/patch-systems
@@ -118,6 +118,9 @@ sub run {
#- quilt
if ($build_deps-implies(quilt) or $quilt_format) {
$uses_patch_system++;
+ if($quilt_format $build_deps-implies(quilt)){
+ tag unneeded-build-dep-on-quilt;
+ }
#check for a debian/patches file:
if (! -r debfiles/patches/series) {
tag quilt-build-dep-but-no-series-file unless $quilt_format;
diff --git a/checks/patch-systems.desc b/checks/patch-systems.desc
index d77749b..f04a9bd 100644
--- a/checks/patch-systems.desc
+++ b/checks/patch-systems.desc
@@ -160,3 +160,11 @@ Info: This package build-depends on a patch system such as dpatch or
referring to tt/usr/share/doc/quilt/README.source/tt. Similarly, you
can refer to tt/usr/share/doc/dpatch/README.source.gz/tt for dpatch.
Ref: policy 4.14
+
+Tag: unneeded-build-dep-on-quilt
+Severity: normal
+Certainty: certain
+Info: This package build-depends on quilt, which is not required since
+ dpkg-source will apply patches at unpack time for 3.0 (quilt) source
+ packages.
+
diff --git a/t/tests/patch-systems-quilt-source/debian/debian/README.source b/t/tests/patch-systems-quilt-source/debian/debian/README.source
new file mode 100644
index 000..17250a4
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/debian/debian/README.source
@@ -0,0 +1 @@
+This package uses quilt. See /usr/share/doc/quilt/README.source.
diff --git a/t/tests/patch-systems-quilt-source/debian/debian/control.in b/t/tests/patch-systems-quilt-source/debian/debian/control.in
new file mode 100644
index 000..5f56ffb
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/debian/debian/control.in
@@ -0,0 +1,15 @@
+Source: {$srcpkg}
+Priority: extra
+Section: devel
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends: quilt, debhelper (= 7)
+
+Package: {$srcpkg}
+Architecture: {$architecture}
+Depends: $\{shlib:Depends\}, $\{misc:Depends\}
+Description: {$description}
+ This is a test package designed to exercise some feature or tag of
+ Lintian. It is part of the Lintian test suite and may do very odd
+ things. It should not be installed like a regular package. It may
+ be an empty package.
diff --git a/t/tests/patch-systems-quilt-source/debian/debian/source/format b/t/tests/patch-systems-quilt-source/debian/debian/source/format
new file mode 100644
index 000..163aaf8
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/debian/debian/source/format
@@ -0,0 +1 @@
+3.0 (quilt)
diff --git a/t/tests/patch-systems-quilt-source/desc b/t/tests/patch-systems-quilt-source/desc
new file mode 100644
index 000..d9f6dd1
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/desc
@@ -0,0 +1,7 @@
+Testname: patch-systems-quilt-source
+Sequence: 6000
+Type: non-native
+Version: 1.0-1
+Description: Test for quilt patches which do not have accompanying descriptions
+Test-For: unneeded-build-dep-on-quilt
+References: Debian Bug #582767
diff --git a/t/tests/patch-systems-quilt-source/tags b/t/tests/patch-systems-quilt-source/tags
new file mode 100644
index 000..856b0e2
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/tags
@@ -0,0 +1 @@
+W: patch-systems-quilt-source source: unneeded-build-dep-on-quilt
diff --git a/t/tests/patch-systems-quilt-source/upstream/README b/t/tests/patch-systems-quilt-source/upstream/README
new file mode 100644
index 000..e845566
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/upstream/README
@@ -0,0 +1 @@
+README
--
1.7.2.3
Bug#595941: lintian: False positive: extra-license-file
tags 595941 + patch
thanks
Made a patch for it and included a small test case for the tag.
~Niels
From 577a7ca9453a24f7fdba2eb5ba19a93c9839e3a1 Mon Sep 17 00:00:00 2001
From: Niels Thykier ni...@thykier.net
Date: Thu, 9 Dec 2010 16:21:28 +0100
Subject: [PATCH] Fix false-positive with extra-license-file with license.ui with test case.
---
checks/files |2 +-
.../files-extra-license/debian/debian/control.in | 18 ++
t/tests/files-extra-license/debian/debian/docs |1 +
t/tests/files-extra-license/debian/debian/rules|3 +++
t/tests/files-extra-license/debian/license.txt |1 +
t/tests/files-extra-license/debian/license.ui |2 ++
t/tests/files-extra-license/desc |6 ++
t/tests/files-extra-license/tags |1 +
8 files changed, 33 insertions(+), 1 deletions(-)
create mode 100644 t/tests/files-extra-license/debian/debian/control.in
create mode 100644 t/tests/files-extra-license/debian/debian/docs
create mode 100755 t/tests/files-extra-license/debian/debian/rules
create mode 100644 t/tests/files-extra-license/debian/license.txt
create mode 100644 t/tests/files-extra-license/debian/license.ui
create mode 100644 t/tests/files-extra-license/desc
create mode 100644 t/tests/files-extra-license/tags
diff --git a/checks/files b/checks/files
index 56cf40b..bdbd585 100644
--- a/checks/files
+++ b/checks/files
@@ -757,7 +757,7 @@ foreach my $file (sort keys %{$info-index}) {
#
# Ignore extra license files in examples, since various package
# building software includes example packages with licenses.
- and not $file =~ m/\.(?:el|c|h|py|cc|pl|pm|hi|p_hi|html|php|rb|xpm|png|jpe?g|gif|svg|dtd)$/
+ and not $file =~ m/\.(?:el|c|h|py|cc|pl|pm|hi|p_hi|html|php|rb|xpm|png|jpe?g|gif|svg|dtd|ui)$/
and not $file =~ m,^usr/share/zope/Products/.*\.(?:dtml|pt|cpt)$,
and not $file =~ m,/under\S+License\.docbook$,
and not $file =~ m,^(?:usr/)?s?bin/,
diff --git a/t/tests/files-extra-license/debian/debian/control.in b/t/tests/files-extra-license/debian/debian/control.in
new file mode 100644
index 000..a4517e1
--- /dev/null
+++ b/t/tests/files-extra-license/debian/debian/control.in
@@ -0,0 +1,18 @@
+Source: {$srcpkg}
+Priority: extra
+Section: {$section}
+Maintainer: {$author}
+Standards-Version: {$standards_version}
+Build-Depends: debhelper (= 7)
+
+Package: {$srcpkg}
+Architecture: all
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: checks for extra license files
+ Tests extra license files.
+ .
+ This is a test package designed to exercise some feature or tag of
+ Lintian. It is part of the Lintian test suite and may do very odd
+ things. It should not be installed like a regular package. It may
+ be an empty package.
+
diff --git a/t/tests/files-extra-license/debian/debian/docs b/t/tests/files-extra-license/debian/debian/docs
new file mode 100644
index 000..9c789d9
--- /dev/null
+++ b/t/tests/files-extra-license/debian/debian/docs
@@ -0,0 +1 @@
+license*
diff --git a/t/tests/files-extra-license/debian/debian/rules b/t/tests/files-extra-license/debian/debian/rules
new file mode 100755
index 000..cbe925d
--- /dev/null
+++ b/t/tests/files-extra-license/debian/debian/rules
@@ -0,0 +1,3 @@
+#!/usr/bin/make -f
+%:
+ dh $@
diff --git a/t/tests/files-extra-license/debian/license.txt b/t/tests/files-extra-license/debian/license.txt
new file mode 100644
index 000..473e105
--- /dev/null
+++ b/t/tests/files-extra-license/debian/license.txt
@@ -0,0 +1 @@
+Lintian should pick up this as an extra license file.
diff --git a/t/tests/files-extra-license/debian/license.ui b/t/tests/files-extra-license/debian/license.ui
new file mode 100644
index 000..afae290
--- /dev/null
+++ b/t/tests/files-extra-license/debian/license.ui
@@ -0,0 +1,2 @@
+Lintian should not mistake this QT UI file for a license file.
+
diff --git a/t/tests/files-extra-license/desc b/t/tests/files-extra-license/desc
new file mode 100644
index 000..1f7db60
--- /dev/null
+++ b/t/tests/files-extra-license/desc
@@ -0,0 +1,6 @@
+Testname: files-extra-license
+Sequence: 6000
+Version: 1.0
+Description: Test for extra license files
+Test-For:
+ extra-license-file
diff --git a/t/tests/files-extra-license/tags b/t/tests/files-extra-license/tags
new file mode 100644
index 000..2dbaffc
--- /dev/null
+++ b/t/tests/files-extra-license/tags
@@ -0,0 +1 @@
+W: files-extra-license: extra-license-file usr/share/doc/files-extra-license/license.txt
--
1.7.2.3
Bug#606506: lintian: default-jdk-builddep is deprecated and dh_nativejava is not provided by default-jdk
Package: lintian
Version: 2.4.3
Tags: patch
Hi
Due to the wide spread misunderstanding of how default-jdk-builddep was
supposed to be used, it has been deprecated by the Java Team. It has
been replaced by default-jdk and gcj-native-helper[1].
The idea is that default-jdk will provide a Java Development Kit (particularly
a java compiler and a jar tool) to compile java files into class files and stuff
them into jar files (as it always have).
gcj-native-helper is a new meta-package to pull the necessary tools to take
a jar file and compile it into native application or library (e.g.
dh_nativejava).
Note that gcj-native-helper is *not* intended to supply a JDK, javac or jar.
Any package needing to compile java files to class/jar files also need to
depend on default-jdk (or similar).
gcj-native-helper was introduced in java-common 0.38 and for the sake of
backwards compatibility it also depends on default-jdk and also provides
default-jdk-builddep.
This is why I have suppressed a missing-b-d tag for dh_nativejava if
default-jdk-builddep is used. However, since we (the Java Team) would like
to remove all references to default-jdk-builddep, we would like to remove
the provides (post Squeeze of course).
~Niels
[1] http://lists.debian.org/debian-java/2010/04/msg00070.html
Basically people thought it was a Java Build Essential.
However, it was default-jdk + tools to compile jar files into native
applications/libraries. On some architectures this ends up pulling two
Java Development Kits (which is a waste of time on the buildd machines)
From f9a5e2fafc22c6f8766bb8755f8c3b8f6badbc3f Mon Sep 17 00:00:00 2001
From: Niels Thykier ni...@thykier.net
Date: Thu, 9 Dec 2010 21:50:02 +0100
Subject: [PATCH] Deprecate default-jdk-builddep and correct list of packages providing dh_nativejava.
---
checks/debhelper |8 +---
data/fields/obsolete-packages |4
.../debian/debian/control.in |2 +-
3 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/checks/debhelper b/checks/debhelper
index 56bbc00..32adec2 100644
--- a/checks/debhelper
+++ b/checks/debhelper
@@ -120,10 +120,12 @@ while (RULES) {
if ($dh_commands_depends-known($dhcommand)) {
my $dep = $dh_commands_depends-value($dhcommand);
- # Special-case default-jdk-builddep. It appears to be a sort
- # of build-essential for Java applications.
+ # Special-case gcj-native-helper, which is a meta-package to
+ # pull this helper. default-jdk-builddep is obsolete, but
+ # we keep it for backwards compatibility, because it used to
+ # serve this purpose.
if ($dhcommand eq 'dh_nativejava') {
- $dep = $dep | default-jdk | default-jdk-builddep;
+ $dep = $dep | gcj-native-helper | default-jdk-builddep;
}
$missingbdeps{$dep} = $dhcommand;
}
diff --git a/data/fields/obsolete-packages b/data/fields/obsolete-packages
index 9726cf0..e4f2a17 100644
--- a/data/fields/obsolete-packages
+++ b/data/fields/obsolete-packages
@@ -56,3 +56,7 @@ xlibmesa-gl
xlibmesa-gl-dev
xlibmesa-glu
xutils
+
+# Last seen in Squeeze
+default-jdk-builddep
+
diff --git a/t/tests/debhelper-dh-nativejava/debian/debian/control.in b/t/tests/debhelper-dh-nativejava/debian/debian/control.in
index cff247e..ccc9a46 100644
--- a/t/tests/debhelper-dh-nativejava/debian/debian/control.in
+++ b/t/tests/debhelper-dh-nativejava/debian/debian/control.in
@@ -3,7 +3,7 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (= 7), default-jdk-builddep
+Build-Depends: debhelper (= 7), gcj-native-helper
Package: {$srcpkg}
Architecture: {$architecture}
--
1.7.2.3
Bug#607399: lintian: false-positive with shlib-calls-exit (triggered on application)
Package: lintian Version: 2.4.3 Hey $ lintian -IE ./openjdk-6-jdk_6b18-1.8.2-4_i386.deb triggers 28 of these; all of them appears to be applications and not shared libraries (installed in /usr/lib/jvm/folder/bin/app). ~Niels -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/aanlktik-oztxbwgtit-m9phvt=5gmmmf8f8jn2onw...@mail.gmail.com
Bug#607730: lintian: Bump debhelper to 7 (7.0.50~ due to tests)
Package: lintian Version: 2.4.3 Tags: patch Hi Bumped DH compat to7 and B-D to 7.0.50~ since tests are run during build and some tests use override_ targets. ~Niels From 26b818c7e66e1a240a5fb5eb7c1734465c406154 Mon Sep 17 00:00:00 2001 From: Niels Thykier ni...@thykier.net Date: Tue, 21 Dec 2010 14:39:34 +0100 Subject: [PATCH] Bump debhelper compat and depends (some tests use override_ targets) --- debian/compat |2 +- debian/control |2 +- debian/rules |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/debian/compat b/debian/compat index 7ed6ff8..7f8f011 100644 --- a/debian/compat +++ b/debian/compat @@ -1 +1 @@ -5 +7 diff --git a/debian/control b/debian/control index f3bb62a..a0638f1 100644 --- a/debian/control +++ b/debian/control @@ -9,7 +9,7 @@ Uploaders: Josip Rodin joy-packa...@debian.org, Colin Watson cjwat...@debian.org, Russ Allbery r...@debian.org, Adam D. Barratt a...@adam-barratt.org.uk, Raphael Geissert geiss...@debian.org -Build-Depends: debhelper (= 5), binutils, debiandoc-sgml, diffstat, +Build-Depends: debhelper (= 7.0.50~), binutils, debiandoc-sgml, diffstat, fakeroot, file, gettext, intltool-debian, libapt-pkg-perl, libclass-accessor-perl, libapt-pkg-perl, libdigest-sha-perl, libipc-run-perl, libparse-debianchangelog-perl, diff --git a/debian/rules b/debian/rules index 77861c5..81ceab8 100755 --- a/debian/rules +++ b/debian/rules @@ -66,7 +66,7 @@ binary-indep: $(neededfiles) build @echo binary-indep dh_testdir dh_testroot - dh_clean -k -Xtestset/diffs/binary.c~ + dh_prep -Xtestset/diffs/binary.c~ dh_installdirs dh_install -- 1.7.2.3
Bug#607731: lintian: Improving test coverage
Package: lintian Version: 2.4.3 Severity: wishlist Tags: patch Hi Adding tests for these tags: debian-rules-not-a-makefile wish-script-but-no-wish-dep ruby-script-but-no-ruby-dep gawk-script-but-no-gawk-dep mawk-script-but-no-mawk-dep tclsh-script-but-no-tclsh-dep ~Niels From fc2b57a06006276e63a88df62839e6eb1a7f1859 Mon Sep 17 00:00:00 2001 From: Niels Thykier ni...@thykier.net Date: Tue, 21 Dec 2010 14:42:33 +0100 Subject: [PATCH] Added some tests to improve coverage. --- t/tests/rules-not-makefile/debian/debian/rules | 11 +++ t/tests/rules-not-makefile/desc|6 ++ t/tests/rules-not-makefile/tags|1 + t/tests/scripts-missing-dep/debian/debian/clean|1 + t/tests/scripts-missing-dep/debian/debian/install |1 + t/tests/scripts-missing-dep/debian/debian/manpages |1 + t/tests/scripts-missing-dep/debian/debian/rules| 12 t/tests/scripts-missing-dep/debian/gawk-script |3 +++ t/tests/scripts-missing-dep/debian/mawk-script |3 +++ t/tests/scripts-missing-dep/debian/ruby-script |3 +++ t/tests/scripts-missing-dep/debian/script.pod | 18 ++ t/tests/scripts-missing-dep/debian/tclsh-script|3 +++ t/tests/scripts-missing-dep/debian/wish-script |3 +++ t/tests/scripts-missing-dep/desc |9 + t/tests/scripts-missing-dep/tags |5 + 15 files changed, 80 insertions(+), 0 deletions(-) create mode 100755 t/tests/rules-not-makefile/debian/debian/rules create mode 100644 t/tests/rules-not-makefile/desc create mode 100644 t/tests/rules-not-makefile/tags create mode 100644 t/tests/scripts-missing-dep/debian/debian/clean create mode 100644 t/tests/scripts-missing-dep/debian/debian/install create mode 100644 t/tests/scripts-missing-dep/debian/debian/manpages create mode 100755 t/tests/scripts-missing-dep/debian/debian/rules create mode 100755 t/tests/scripts-missing-dep/debian/gawk-script create mode 100755 t/tests/scripts-missing-dep/debian/mawk-script create mode 100755 t/tests/scripts-missing-dep/debian/ruby-script create mode 100644 t/tests/scripts-missing-dep/debian/script.pod create mode 100755 t/tests/scripts-missing-dep/debian/tclsh-script create mode 100755 t/tests/scripts-missing-dep/debian/wish-script create mode 100644 t/tests/scripts-missing-dep/desc create mode 100644 t/tests/scripts-missing-dep/tags diff --git a/t/tests/rules-not-makefile/debian/debian/rules b/t/tests/rules-not-makefile/debian/debian/rules new file mode 100755 index 000..d3a1c6c --- /dev/null +++ b/t/tests/rules-not-makefile/debian/debian/rules @@ -0,0 +1,11 @@ +#!/bin/sh +# This should be a makefile. +exec dh $@ + +# fake targets to trick lintain into believing the +# required targets are present (removed unrelated errors). +binary: +binary-arch: +binary-indep: +build: +clean: diff --git a/t/tests/rules-not-makefile/desc b/t/tests/rules-not-makefile/desc new file mode 100644 index 000..e01a928 --- /dev/null +++ b/t/tests/rules-not-makefile/desc @@ -0,0 +1,6 @@ +Testname: rules-not-makefile +Sequence: 6000 +Version: 1.0 +Description: Check if the rules file is a makefile +Test-For: debian-rules-not-a-makefile + diff --git a/t/tests/rules-not-makefile/tags b/t/tests/rules-not-makefile/tags new file mode 100644 index 000..017b643 --- /dev/null +++ b/t/tests/rules-not-makefile/tags @@ -0,0 +1 @@ +E: rules-not-makefile source: debian-rules-not-a-makefile diff --git a/t/tests/scripts-missing-dep/debian/debian/clean b/t/tests/scripts-missing-dep/debian/debian/clean new file mode 100644 index 000..8f76e67 --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/debian/clean @@ -0,0 +1 @@ +man/ diff --git a/t/tests/scripts-missing-dep/debian/debian/install b/t/tests/scripts-missing-dep/debian/debian/install new file mode 100644 index 000..0486c9a --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/debian/install @@ -0,0 +1 @@ +*-script usr/bin/ diff --git a/t/tests/scripts-missing-dep/debian/debian/manpages b/t/tests/scripts-missing-dep/debian/debian/manpages new file mode 100644 index 000..bf519d7 --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/debian/manpages @@ -0,0 +1 @@ +man/*.1 diff --git a/t/tests/scripts-missing-dep/debian/debian/rules b/t/tests/scripts-missing-dep/debian/debian/rules new file mode 100755 index 000..654f90a --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/debian/rules @@ -0,0 +1,12 @@ +#!/usr/bin/make -f + +%: + dh $@ + +override_dh_auto_build: + mkdir man + for FILE in *-script ; do \ + sed s/@SCRIPT@/$$FILE/g script.pod | \ + pod2man --section=1 man/$$FILE.1 ; \ + done + diff --git a/t/tests/scripts-missing-dep/debian/gawk-script b/t/tests/scripts-missing-dep/debian/gawk-script new file mode 100755 index 000..b66729e --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/gawk-script @@ -0,0 +1,3 @@ +#!/usr/bin/gawk -f + +# do something
[SCM] Debian package checker branch, master, updated. 2.4.3-13-g84cb794
The following commit has been merged in the master branch: commit d15295e01828223fcbf9db58f86f741272f0dc75 Author: Niels Thykier ni...@thykier.net Date: Tue Dec 21 22:32:07 2010 +0100 Bump debhelper compat and build dependency (some tests use override_ targets). diff --git a/debian/changelog b/debian/changelog index b624235..2b1478d 100755 --- a/debian/changelog +++ b/debian/changelog @@ -27,8 +27,13 @@ lintian (2.4.4) UNRELEASED; urgency=low work to determine which packages are required. (Closes: #593832) + [RA] Remove versions from dependencies when those versions are satisifed by stable (lenny). ++ [NT] Bump debhelper build dependency to 7.0.50~, since some tests + depend on using dh7 with override targets. (Closes: #607730) * debian/rules: + [RA] Run the test suite during the package build. ++ [NT] Replace dh_clean -k with dh_prep. + * debian/compat: ++ [NT] Bump debhelper comat to 7. -- Raphael Geissert geiss...@debian.org Thu, 29 Jul 2010 21:09:55 -0400 diff --git a/debian/compat b/debian/compat index 7ed6ff8..7f8f011 100644 --- a/debian/compat +++ b/debian/compat @@ -1 +1 @@ -5 +7 diff --git a/debian/control b/debian/control index f3bb62a..a0638f1 100644 --- a/debian/control +++ b/debian/control @@ -9,7 +9,7 @@ Uploaders: Josip Rodin joy-packa...@debian.org, Colin Watson cjwat...@debian.org, Russ Allbery r...@debian.org, Adam D. Barratt a...@adam-barratt.org.uk, Raphael Geissert geiss...@debian.org -Build-Depends: debhelper (= 5), binutils, debiandoc-sgml, diffstat, +Build-Depends: debhelper (= 7.0.50~), binutils, debiandoc-sgml, diffstat, fakeroot, file, gettext, intltool-debian, libapt-pkg-perl, libclass-accessor-perl, libapt-pkg-perl, libdigest-sha-perl, libipc-run-perl, libparse-debianchangelog-perl, diff --git a/debian/rules b/debian/rules index 77861c5..81ceab8 100755 --- a/debian/rules +++ b/debian/rules @@ -66,7 +66,7 @@ binary-indep: $(neededfiles) build @echo binary-indep dh_testdir dh_testroot - dh_clean -k -Xtestset/diffs/binary.c~ + dh_prep -Xtestset/diffs/binary.c~ dh_installdirs dh_install -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pva3q-0004lc...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-13-g84cb794
The following commit has been merged in the master branch: commit 84cb79477fc76e7f7603308d29986cc9394d76db Author: Niels Thykier ni...@thykier.net Date: Tue Dec 21 14:42:33 2010 +0100 Added some tests to improve coverage. diff --git a/debian/changelog b/debian/changelog index 2b1478d..da873b3 100755 --- a/debian/changelog +++ b/debian/changelog @@ -35,6 +35,11 @@ lintian (2.4.4) UNRELEASED; urgency=low * debian/compat: + [NT] Bump debhelper comat to 7. + * t/tests/rules-not-makefile: ++ [NT] Added new test. + * t/tests/scripts-missing-dep: ++ [NT] Added new test. (Closes: #607731) + -- Raphael Geissert geiss...@debian.org Thu, 29 Jul 2010 21:09:55 -0400 lintian (2.4.3) unstable; urgency=low diff --git a/t/tests/rules-not-makefile/debian/debian/rules b/t/tests/rules-not-makefile/debian/debian/rules new file mode 100755 index 000..d3a1c6c --- /dev/null +++ b/t/tests/rules-not-makefile/debian/debian/rules @@ -0,0 +1,11 @@ +#!/bin/sh +# This should be a makefile. +exec dh $@ + +# fake targets to trick lintain into believing the +# required targets are present (removed unrelated errors). +binary: +binary-arch: +binary-indep: +build: +clean: diff --git a/t/tests/rules-not-makefile/desc b/t/tests/rules-not-makefile/desc new file mode 100644 index 000..e01a928 --- /dev/null +++ b/t/tests/rules-not-makefile/desc @@ -0,0 +1,6 @@ +Testname: rules-not-makefile +Sequence: 6000 +Version: 1.0 +Description: Check if the rules file is a makefile +Test-For: debian-rules-not-a-makefile + diff --git a/t/tests/rules-not-makefile/tags b/t/tests/rules-not-makefile/tags new file mode 100644 index 000..017b643 --- /dev/null +++ b/t/tests/rules-not-makefile/tags @@ -0,0 +1 @@ +E: rules-not-makefile source: debian-rules-not-a-makefile diff --git a/t/tests/scripts-missing-dep/debian/debian/clean b/t/tests/scripts-missing-dep/debian/debian/clean new file mode 100644 index 000..8f76e67 --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/debian/clean @@ -0,0 +1 @@ +man/ diff --git a/t/tests/scripts-missing-dep/debian/debian/install b/t/tests/scripts-missing-dep/debian/debian/install new file mode 100644 index 000..0486c9a --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/debian/install @@ -0,0 +1 @@ +*-script usr/bin/ diff --git a/t/tests/scripts-missing-dep/debian/debian/manpages b/t/tests/scripts-missing-dep/debian/debian/manpages new file mode 100644 index 000..bf519d7 --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/debian/manpages @@ -0,0 +1 @@ +man/*.1 diff --git a/t/tests/scripts-missing-dep/debian/debian/rules b/t/tests/scripts-missing-dep/debian/debian/rules new file mode 100755 index 000..654f90a --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/debian/rules @@ -0,0 +1,12 @@ +#!/usr/bin/make -f + +%: + dh $@ + +override_dh_auto_build: + mkdir man + for FILE in *-script ; do \ + sed s/@SCRIPT@/$$FILE/g script.pod | \ + pod2man --section=1 man/$$FILE.1 ; \ + done + diff --git a/t/tests/scripts-missing-dep/debian/gawk-script b/t/tests/scripts-missing-dep/debian/gawk-script new file mode 100755 index 000..b66729e --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/gawk-script @@ -0,0 +1,3 @@ +#!/usr/bin/gawk -f + +# do something. diff --git a/t/tests/scripts-missing-dep/debian/mawk-script b/t/tests/scripts-missing-dep/debian/mawk-script new file mode 100755 index 000..fbb3316 --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/mawk-script @@ -0,0 +1,3 @@ +#!/usr/bin/mawk -f + +# do something. diff --git a/t/tests/scripts-missing-dep/debian/ruby-script b/t/tests/scripts-missing-dep/debian/ruby-script new file mode 100755 index 000..4700685 --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/ruby-script @@ -0,0 +1,3 @@ +#!/usr/bin/ruby + +# do something. diff --git a/t/tests/scripts-missing-dep/debian/script.pod b/t/tests/scripts-missing-dep/debian/script.pod new file mode 100644 index 000..8ffa2d0 --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/script.pod @@ -0,0 +1,18 @@ +=head1 NAME + +...@script@ - Cool script to do stuff written in some script language. + +=head1 SYNOPSIS + +...@script@ --cool-argument + +=head1 DESCRIPTION + +This script is very awesome and does something you do not even know +you need. + +=head1 AUTHOR + +I made this + + diff --git a/t/tests/scripts-missing-dep/debian/tclsh-script b/t/tests/scripts-missing-dep/debian/tclsh-script new file mode 100755 index 000..2e6707a --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/tclsh-script @@ -0,0 +1,3 @@ +#!/usr/bin/tclsh + +# do something. diff --git a/t/tests/scripts-missing-dep/debian/wish-script b/t/tests/scripts-missing-dep/debian/wish-script new file mode 100755 index 000..5a2cd12 --- /dev/null +++ b/t/tests/scripts-missing-dep/debian/wish-script @@ -0,0 +1,3 @@ +#!/usr/bin/wish + +# do something. diff --git a/t/tests/scripts-missing-dep/desc b/t/tests/scripts
[SCM] Debian package checker branch, master, updated. 2.4.3-14-g45d8f0e
The following commit has been merged in the master branch:
commit 45d8f0e05799522c50a5e4f5df9c389eb652
Author: David Bremner brem...@debian.org
Date: Tue Dec 21 23:10:16 2010 +0100
* checks/debian-source-dir:
+ [NT] Added missing import of Util perl module. Thanks to David
Bremner for the patch.
Signed-off-by: Niels Thykier ni...@thykier.net
diff --git a/checks/debian-source-dir b/checks/debian-source-dir
index 91e10c8..4bba150 100644
--- a/checks/debian-source-dir
+++ b/checks/debian-source-dir
@@ -23,6 +23,7 @@ use strict;
use Lintian::Data;
use Lintian::Tags qw(tag);
+use Util;
our %KNOWN_FORMATS = map { $_ = 1 }
('1.0', '2.0', '3.0 (quilt)', '3.0 (native)', '3.0 (git)', '3.0 (bzr)');
diff --git a/debian/changelog b/debian/changelog
index da873b3..915d8d1 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [RA] Exclude kfreebsd-kernel-di-{amd64,i386} from the
embedded-zlib check since it's in the kernel. (Closes: #593397)
+ [RG] Add swipl to the list of known interpreters. (Closes: #591316)
+ * checks/debian-source-dir:
++ [NT] Added missing import of Util perl module. Thanks to David
+ Bremner for the patch.
* checks/menu-format.desc:
+ [CW] Fix several typos.
* checks/menus.desc:
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvarq-0004e6...@alioth.debian.org
Re: [PATCH] check/debian-source-dir: add use Util
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 2010-12-21 05:10, brem...@debian.org wrote:
From: David Bremner brem...@debian.org
Hi David
This seems to be required in order to call fail.
---
checks/debian-source-dir |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/checks/debian-source-dir b/checks/debian-source-dir
index 94b4cfa..249aafa 100644
--- a/checks/debian-source-dir
+++ b/checks/debian-source-dir
@@ -23,6 +23,7 @@ use strict;
use Lintian::Data;
use Lintian::Tags qw(tag);
+use Util;
our %KNOWN_FORMATS = map { $_ = 1 }
('1.0', '2.0', '3.0 (quilt)', '3.0 (native)', '3.0 (git)', '3.0 (bzr)');
Applied and pushed[1], thanks for the patch.
~Niels
[1]
http://git.debian.org/?p=lintian/lintian.git;a=commit;h=45d8f0e05799522c50a5e4f5df9c389eb652
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBCAAGBQJNESafAAoJEAVLu599gGRCJWkP/3qOKAK3+VcdXbrCjy49K4mW
u44fXMiYomTd6hrBugkDw7/S3ZIkwRj4U5o7L9ZxFpYPP47lyiUM6fGCA5pXQHos
p6ADYLRa7RBdM5gc3Ffqy8M6cDn7SNELCdEW2Yld+/9AnPD26EskBNN20rpNz8iV
zn/9Wu08Gbm916e373LlqqcS/uYlfmR7REXY/wQLC/Pev9UGTpy+D2w+WUK3zYvN
fWBfQM/7HYdtqwhwA/CUQDY+f4HMn1JrAk+aUeMEf8rXKuzCsqnUrFB0/kkOc6Ed
Q0YROYBt14AmeflWx+Pu6qfwK6YGH0vjIulYFHRvzaKRYrHfdtX5d/wMWW94cHKi
fej5ZQWcm134KsjSx3DqwZODtkpkeFKrhlsIuS06H7boGO92dP5gwyQ2cZrhLz2f
rwTacl5Gv1IIsz8qZh2pdRsmPHyL52yXL/NqKv6Pt7RlSSidKaj0/LKhVNHJPoho
+ZOr3dl9bCA1NvINhCiZQ18BEntsQc7VfI61We7GIPZce7rAHKuPsIAiqnkFdcLj
YicCeIXGHIfk7M/lphvKRUVBSTb2GYUrMMrh72tDK6PS3jhbQ5KPrEFkRRBQGZAp
LdAyz8I75iMZWYYj30fjjZ5ydDqQP2ykcYZK+9jU7ah4b6l6jTGjyn+bPwcz8Yrl
tv9SUMIyuhe0LVqIXeNt
=/2PW
-END PGP SIGNATURE-
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/4d1126a0.4060...@thykier.net
[SCM] Debian package checker branch, master, updated. 2.4.3-17-g1330193
The following commit has been merged in the master branch:
commit a88c4da7095c6681c8c3d9e42f0ac8a1efee4bf9
Author: Niels Thykier ni...@thykier.net
Date: Thu Dec 9 16:21:28 2010 +0100
Fix false-positive with extra-license-file with license.ui with test case.
* checks/files:
+ [NT] Fixed false-positive extra-license-file for license.ui files.
Thanks to Jeremy Sanders for the report. (Closes: #595941)
* t/tests/files-extra-license:
+ [NT] Added new test.
diff --git a/checks/files b/checks/files
index 56cf40b..bdbd585 100644
--- a/checks/files
+++ b/checks/files
@@ -757,7 +757,7 @@ foreach my $file (sort keys %{$info-index}) {
#
# Ignore extra license files in examples, since various package
# building software includes example packages with licenses.
- and not $file =~
m/\.(?:el|c|h|py|cc|pl|pm|hi|p_hi|html|php|rb|xpm|png|jpe?g|gif|svg|dtd)$/
+ and not $file =~
m/\.(?:el|c|h|py|cc|pl|pm|hi|p_hi|html|php|rb|xpm|png|jpe?g|gif|svg|dtd|ui)$/
and not $file =~ m,^usr/share/zope/Products/.*\.(?:dtml|pt|cpt)$,
and not $file =~ m,/under\S+License\.docbook$,
and not $file =~ m,^(?:usr/)?s?bin/,
diff --git a/debian/changelog b/debian/changelog
index f6bc19b..fbad20e 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
* checks/debian-source-dir:
+ [NT] Added missing import of Util perl module. Thanks to David
Bremner for the patch.
+ * checks/files:
++ [NT] Fixed false-positive extra-license-file for license.ui files.
+ Thanks to Jeremy Sanders for the report. (Closes: #595941)
* checks/menu-format.desc:
+ [CW] Fix several typos.
* checks/menus.desc:
@@ -41,6 +44,8 @@ lintian (2.4.4) UNRELEASED; urgency=low
* debian/compat:
+ [NT] Bump debhelper comat to 7.
+ * t/tests/files-extra-license:
++ [NT] Added new test.
* t/tests/rules-not-makefile:
+ [NT] Added new test.
* t/tests/scripts-missing-dep:
diff --git a/t/tests/files-extra-license/debian/debian/docs
b/t/tests/files-extra-license/debian/debian/docs
new file mode 100644
index 000..9c789d9
--- /dev/null
+++ b/t/tests/files-extra-license/debian/debian/docs
@@ -0,0 +1 @@
+license*
diff --git a/t/tests/files-extra-license/debian/license.txt
b/t/tests/files-extra-license/debian/license.txt
new file mode 100644
index 000..473e105
--- /dev/null
+++ b/t/tests/files-extra-license/debian/license.txt
@@ -0,0 +1 @@
+Lintian should pick up this as an extra license file.
diff --git a/t/tests/files-extra-license/debian/license.ui
b/t/tests/files-extra-license/debian/license.ui
new file mode 100644
index 000..afae290
--- /dev/null
+++ b/t/tests/files-extra-license/debian/license.ui
@@ -0,0 +1,2 @@
+Lintian should not mistake this QT UI file for a license file.
+
diff --git a/t/tests/files-extra-license/desc b/t/tests/files-extra-license/desc
new file mode 100644
index 000..1f7db60
--- /dev/null
+++ b/t/tests/files-extra-license/desc
@@ -0,0 +1,6 @@
+Testname: files-extra-license
+Sequence: 6000
+Version: 1.0
+Description: Test for extra license files
+Test-For:
+ extra-license-file
diff --git a/t/tests/files-extra-license/tags b/t/tests/files-extra-license/tags
new file mode 100644
index 000..2dbaffc
--- /dev/null
+++ b/t/tests/files-extra-license/tags
@@ -0,0 +1 @@
+W: files-extra-license: extra-license-file
usr/share/doc/files-extra-license/license.txt
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvb2b-0008ks...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-17-g1330193
The following commit has been merged in the master branch:
commit 1330193cdf9880dbc4553ea5e6fd99b63892134b
Author: Niels Thykier ni...@thykier.net
Date: Sat Aug 21 14:15:32 2010 +0200
Add check for build-depending on specific system javadoc instead of
default-jdk-doc
* Summary of tag changes:
+ Added:
- build-depends-on-specific-java-doc-package
* checks/fields{,.desc}:
+ [NT] Added check for packages build depending on openjdk-X-doc or
classpath-doc instead of the default-jdk-doc metapackage.
(Closes: #593837)
* t/tests/fields-java:
+ [NT] Added test for new tag.
diff --git a/checks/fields b/checks/fields
index 5b4b5e7..5161ae2 100644
--- a/checks/fields
+++ b/checks/fields
@@ -726,6 +726,10 @@ if ($type eq source) {
}
}
+ if($d_pkg =~ m/openjdk-\d+-doc/o or
$d_pkg eq 'classpath-doc'){
+ tag
'build-depends-on-specific-java-doc-package', $d_pkg;
+ }
+
tag
'conflicting-negation-in-source-relation', $field: $part_d_orig
unless (not $d_arch or $d_arch-[1]
== 0 or $d_arch-[1] eq @{ $d_arch-[0] });
diff --git a/checks/fields.desc b/checks/fields.desc
index eff85cc..2a77b7e 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -992,3 +992,11 @@ Info: The given package appears to have a Python
development package
If you are building a Python extension instead, you should have
development packages listed in Build-Depends, but normally there should
be at least one Architecture: any package.
+
+Tag: build-depends-on-specific-java-doc-package
+Severity: normal
+Certainty: certain
+Info: The given package declares a build dependency on either openjdk-
+ X-doc or classpath-doc instead of using default-jdk-doc. default-jdk-doc
+ provides a symlink to the API via /usr/share/default-jdk-doc/api.
+
diff --git a/debian/changelog b/debian/changelog
index fbad20e..d9e4ddc 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,9 @@
lintian (2.4.4) UNRELEASED; urgency=low
+ * Summary of tag changes:
++ Added:
+ - build-depends-on-specific-java-doc-package
+
* checks/binaries:
+ [RA] Exclude kfreebsd-kernel-di-{amd64,i386} from the
embedded-zlib check since it's in the kernel. (Closes: #593397)
@@ -7,6 +11,10 @@ lintian (2.4.4) UNRELEASED; urgency=low
* checks/debian-source-dir:
+ [NT] Added missing import of Util perl module. Thanks to David
Bremner for the patch.
+ * checks/fields{,.desc}:
++ [NT] Added check for packages build depending on openjdk-X-doc or
+ classpath-doc instead of the default-jdk-doc metapackage.
+ (Closes: #593837)
* checks/files:
+ [NT] Fixed false-positive extra-license-file for license.ui files.
Thanks to Jeremy Sanders for the report. (Closes: #595941)
@@ -46,6 +54,8 @@ lintian (2.4.4) UNRELEASED; urgency=low
* t/tests/files-extra-license:
+ [NT] Added new test.
+ * t/tests/fields-java:
++ [NT] Added test for new tag.
* t/tests/rules-not-makefile:
+ [NT] Added new test.
* t/tests/scripts-missing-dep:
diff --git a/t/tests/debhelper-dh-clean-k-ok/debian/debian/control.in
b/t/tests/fields-java/debian/debian/control.in
similarity index 81%
copy from t/tests/debhelper-dh-clean-k-ok/debian/debian/control.in
copy to t/tests/fields-java/debian/debian/control.in
index 4a5a774..8dbc64a 100644
--- a/t/tests/debhelper-dh-clean-k-ok/debian/debian/control.in
+++ b/t/tests/fields-java/debian/debian/control.in
@@ -1,11 +1,11 @@
Source: {$srcpkg}
Priority: extra
-Section: {$section}
+Section: java
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (= 6)
+Build-Depends: debhelper (= 7.0.50~), openjdk-6-doc
-Package: {$srcpkg}
+Package: lib{$srcpkg}-java
Architecture: {$architecture}
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
Description: {$description}
@@ -13,3 +13,4 @@ Description: {$description}
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+
diff --git a/t/tests/fields-depends-general/debian/debian/install
b/t/tests/fields-java/debian/debian/install
similarity index 100%
copy from t/tests/fields-depends-general/debian/debian/install
copy to t/tests/fields-java/debian/debian/install
diff --git a/t/tests/fields-depends-general/debian/some-file
b/t/tests/fields-java/debian/some-file
similarity index 100%
copy from t/tests/fields-depends-general/debian/some-file
copy to t/tests/fields-java/debian/some-file
diff --git a/t/tests/fields-java/desc b/t/tests/fields-java/desc
new file mode 100644
index 000..12e1005
--- /dev/null
+++ b/t/tests/fields-java/desc
[SCM] Debian package checker branch, master, updated. 2.4.3-18-g570b098
The following commit has been merged in the master branch:
commit 570b0985ed5159bae6917a4d9121455cff039931
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 22 09:15:25 2010 +0100
Fixed some style issues in d/changelog.
diff --git a/debian/changelog b/debian/changelog
index d9e4ddc..788d98f 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -9,7 +9,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
embedded-zlib check since it's in the kernel. (Closes: #593397)
+ [RG] Add swipl to the list of known interpreters. (Closes: #591316)
* checks/debian-source-dir:
-+ [NT] Added missing import of Util perl module. Thanks to David
++ [NT] Added missing import of Util perl module. Thanks to David
Bremner for the patch.
* checks/fields{,.desc}:
+ [NT] Added check for packages build depending on openjdk-X-doc or
@@ -17,7 +17,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
(Closes: #593837)
* checks/files:
+ [NT] Fixed false-positive extra-license-file for license.ui files.
- Thanks to Jeremy Sanders for the report. (Closes: #595941)
+ Thanks to Jeremy Sanders for the report. (Closes: #595941)
* checks/menu-format.desc:
+ [CW] Fix several typos.
* checks/menus.desc:
@@ -42,7 +42,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [RA] Remove versions from dependencies when those versions are
satisifed by stable (lenny).
+ [NT] Bump debhelper build dependency to 7.0.50~, since some tests
- depend on using dh7 with override targets. (Closes: #607730)
+ depend on using dh7 with override targets. (Closes: #607730)
+ [NT] Added Niels Thykier to uploaders.
* debian/copyright:
+ [NT] Added Niels Thykier to maintainers.
@@ -52,14 +52,8 @@ lintian (2.4.4) UNRELEASED; urgency=low
* debian/compat:
+ [NT] Bump debhelper comat to 7.
- * t/tests/files-extra-license:
-+ [NT] Added new test.
- * t/tests/fields-java:
-+ [NT] Added test for new tag.
- * t/tests/rules-not-makefile:
-+ [NT] Added new test.
- * t/tests/scripts-missing-dep:
-+ [NT] Added new test. (Closes: #607731)
+ * t/tests/{rules-not-makefile,scripts-missing-dep}:
++ [NT] Added new tests. (Closes: #607731)
-- Raphael Geissert geiss...@debian.org Thu, 29 Jul 2010 21:09:55 -0400
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvjsl-0005ws...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-19-g92b41fe
The following commit has been merged in the master branch:
commit 92b41fec86c4e25225d9e5a0d224d276f8666276
Author: Niels Thykier ni...@thykier.net
Date: Fri Dec 3 22:41:43 2010 +0100
Add check for depending on specific system javadoc instead default-jdk-doc.
* Summary of tag changes:
+ Added:
- depends-on-specific-java-doc-package
* checks/fields{,.desc}:
+ [NT] Added check for packages (build) depending on openjdk-X-doc or
classpath-doc instead of the default-jdk-doc metapackage.
(Closes: #593837)
diff --git a/checks/fields b/checks/fields
index 5161ae2..e503a52 100644
--- a/checks/fields
+++ b/checks/fields
@@ -638,6 +638,13 @@ if (($type eq binary) || ($type eq 'udeb')) {
if ($field eq 'recommends'
$pkg =~ m/^lib/ $pkg !~
m/-(dev|docs?|tools|bin)$/
$part_d_orig =~ m/-docs?$/);
+
+ # default-jdk-doc must depend on openjdk-X-doc
(or classpath-doc) to be
+ # useful; other packages should depend on
default-jdk-doc if they
+ # want the Java Core API.
+ tag depends-on-specific-java-doc-package,
$field
+ if($is_dep_field($field) $pkg ne
'default-jdk-doc'
+ ($d_pkg eq 'classpath-doc' || $d_pkg
=~ m/openjdk-\d+-doc/o));
}
for my $pkg (@seen_obsolete_packages) {
diff --git a/checks/fields.desc b/checks/fields.desc
index 2a77b7e..cf91829 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1000,3 +1000,10 @@ Info: The given package declares a build dependency on
either openjdk-
X-doc or classpath-doc instead of using default-jdk-doc. default-jdk-doc
provides a symlink to the API via /usr/share/default-jdk-doc/api.
+Tag: depends-on-specific-java-doc-package
+Severity: normal
+Certainty: certain
+Info: The package should use default-jdk-doc instead of classpath-doc
+ or openjdk-X-doc to ease transitions when the providing doc package
+ is replaced (e.g. openjdk-6-doc being replaced by openjdk-7-doc).
+
diff --git a/debian/changelog b/debian/changelog
index 788d98f..4eec353 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
* Summary of tag changes:
+ Added:
- build-depends-on-specific-java-doc-package
+ - depends-on-specific-java-doc-package
* checks/binaries:
+ [RA] Exclude kfreebsd-kernel-di-{amd64,i386} from the
@@ -12,7 +13,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [NT] Added missing import of Util perl module. Thanks to David
Bremner for the patch.
* checks/fields{,.desc}:
-+ [NT] Added check for packages build depending on openjdk-X-doc or
++ [NT] Added check for packages (build) depending on openjdk-X-doc or
classpath-doc instead of the default-jdk-doc metapackage.
(Closes: #593837)
* checks/files:
diff --git a/t/tests/fields-java/debian/debian/control.in
b/t/tests/fields-java/debian/debian/control.in
index 8dbc64a..d03c194 100644
--- a/t/tests/fields-java/debian/debian/control.in
+++ b/t/tests/fields-java/debian/debian/control.in
@@ -5,9 +5,13 @@ Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: debhelper (= 7.0.50~), openjdk-6-doc
-Package: lib{$srcpkg}-java
+Package: lib{$srcpkg}-java-doc
Architecture: {$architecture}
+Section: doc
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Recommends: openjdk-6-doc
+# Negative testing as well, this should not be triggered.
+Replaces: openjdk-6-doc
Description: {$description}
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
diff --git a/t/tests/fields-java/desc b/t/tests/fields-java/desc
index 12e1005..52b570a 100644
--- a/t/tests/fields-java/desc
+++ b/t/tests/fields-java/desc
@@ -4,3 +4,4 @@ Version: 1.0
Description: General tests for java package (build) dependencies
Test-For:
build-depends-on-specific-java-doc-package
+ depends-on-specific-java-doc-package
diff --git a/t/tests/fields-java/tags b/t/tests/fields-java/tags
index 4f3321f..19f1802 100644
--- a/t/tests/fields-java/tags
+++ b/t/tests/fields-java/tags
@@ -1 +1,2 @@
W: fields-java source: build-depends-on-specific-java-doc-package openjdk-6-doc
+W: libfields-java-java-doc: depends-on-specific-java-doc-package recommends
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvkpf-00048f...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-20-g5b36419
The following commit has been merged in the master branch:
commit 5b36419d5040f8af89bf92440974c658d3fe69c0
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 22 09:59:42 2010 +0100
Create a sorted file index for checks to use instead of sorting it
themselves (Closes: #605844)
* checks/*:
+ [NT] Use the new pre-sorted file index when iterating over files.
* lib/Lintian/Collect/Binary.pm:
+ [NT] Create a sorted file index to avoid sorting it in the checks.
(Closes: #605844)
diff --git a/checks/changelog-file b/checks/changelog-file
index 8147095..40f4b0f 100644
--- a/checks/changelog-file
+++ b/checks/changelog-file
@@ -79,7 +79,7 @@ for my $file (sort keys %{$info-file_info}) {
}
# Read package contents Capitalization errors are dealt with later.
-foreach (sort keys %{$info-index}) {
+foreach (@{$info-sorted_index}) {
next unless length $_;
# skip packages which have a /usr/share/doc/$pkg - foo symlink
if (m,usr/share/doc/$ppkg$, and defined $info-index-{$_}-{link}) {
diff --git a/checks/copyright-file b/checks/copyright-file
index 336d0f4..267ed43 100644
--- a/checks/copyright-file
+++ b/checks/copyright-file
@@ -45,7 +45,7 @@ my $found = 0;
my $linked = 0;
# Read package contents...
-foreach (sort keys %{$info-index}) {
+foreach (@{$info-sorted_index}) {
my $index_info = $info-index-{$_};
if (m,usr/(share/)?doc/$ppkg/copyright(\.\S+)?$,) {
my $ext = $2;
diff --git a/checks/etcfiles b/checks/etcfiles
index bc61715..9a734b1 100644
--- a/checks/etcfiles
+++ b/checks/etcfiles
@@ -45,7 +45,7 @@ if (open(IN, '', $conffiles)) {
}
# Read package contents...
-foreach my $file (sort keys %{$info-index}) {
+foreach my $file (@{$info-sorted_index}) {
my $index_info = $info-index-{$file};
next unless $file =~ m,^etc, and $index_info-{type}=~ m/^[-h]/;
diff --git a/checks/fields b/checks/fields
index e503a52..af5fae5 100644
--- a/checks/fields
+++ b/checks/fields
@@ -503,7 +503,7 @@ if (defined $info-field('installer-menu-item')) {
my $metapackage = 0;
if ($type eq 'binary') {
$metapackage = 1;
- for my $file (keys %{$info-index}) {
+ for my $file (@{$info-sorted_index}) {
next if $info-index-{$file}-{type} =~ /^d/;
next if $file =~ m%^usr/share/doc/%;
next if $file =~ m%^usr/share/lintian/overrides/%;
diff --git a/checks/files b/checks/files
index bdbd585..07b7fea 100644
--- a/checks/files
+++ b/checks/files
@@ -199,7 +199,7 @@ if ($description) {
}
}
if ($is_empty) {
-for my $file (sort keys %{$info-index}) {
+for my $file (@{$info-sorted_index}) {
# Ignore directories
unless ($file =~ m,/$,) {
# Skip if $file is an empty string
@@ -226,7 +226,7 @@ if ($is_empty) {
}
# Read package contents...
-foreach my $file (sort keys %{$info-index}) {
+foreach my $file (@{$info-sorted_index}) {
next if $file eq ;
my $index_info = $info-index-{$file};
my $owner = $index_info-{owner} . '/' . $index_info-{group};
@@ -1204,7 +1204,7 @@ if ($pkg_section !~ m,games$, and $games 0 and $other
== 0) {
# so just ignore them.
#
# python-support needs a directory for each package even it might be empty
-foreach my $dir (sort keys %{$info-index}) {
+foreach my $dir (@{$info-sorted_index}) {
next if $dir eq or $info-index-{$dir}-{type} ne 'd';
next if ($dir =~ m{^var/} or $dir =~ m{^etc/});
next if $pkg eq 'base-files';
diff --git a/checks/infofiles b/checks/infofiles
index 2c5b994..872a74b 100644
--- a/checks/infofiles
+++ b/checks/infofiles
@@ -40,7 +40,7 @@ my %missing_section;
my $has_info_file;
# Read package contents...
-foreach my $file (sort keys %{$info-index}) {
+foreach my $file (@{$info-sorted_index}) {
my $index_info = $info-index-{$file};
my $file_info = $info-file_info-{$file};
my $link = $index_info-{link} || '';
diff --git a/checks/manpages b/checks/manpages
index 0035bda..17912d2 100644
--- a/checks/manpages
+++ b/checks/manpages
@@ -40,7 +40,7 @@ my %link;
my %manpage;
# Read package contents...
-foreach my $file (sort keys %{$info-index}) {
+foreach my $file (@{$info-sorted_index}) {
my $index_info = $info-index-{$file};
my $file_info = $info-file_info-{$file};
my $link = $index_info-{link} || '';
diff --git a/checks/menu-format b/checks/menu-format
index bbb4bc8..4e85dae 100644
--- a/checks/menu-format
+++ b/checks/menu-format
@@ -396,7 +396,7 @@ closedir MENUDIR;
# Find the desktop files in the package for verification.
my @desktop_files;
-foreach my $file (sort keys %{$info-index}) {
+foreach my $file (@{$info-sorted_index}) {
my $index_info = $info-index-{$file};
my $operm = $index_info-{operm};
diff --git a/checks/scripts b/checks/scripts
index 54aa37b..1acd2b0 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -312,7 +312,7 @@ my $pkg = shift;
my $type = shift;
my $info = shift
[SCM] Debian package checker branch, master, updated. 2.4.3-21-g6d868dc
The following commit has been merged in the master branch: commit 6d868dcf683f3bda40c3ac76afb84c5c7e7629e8 Author: David Bremner brem...@debian.org Date: Mon Dec 20 22:59:33 2010 -0400 debian/rules: Add support for skipping the test suite per policy 4.9.1 + [NT] Add support for skipping the test suite per policy 4.9.1. Many thanks to David Bremner for the patch. Signed-off-by: Niels Thykier ni...@thykier.net diff --git a/debian/changelog b/debian/changelog index df45810..877755a 100755 --- a/debian/changelog +++ b/debian/changelog @@ -52,6 +52,8 @@ lintian (2.4.4) UNRELEASED; urgency=low * debian/rules: + [RA] Run the test suite during the package build. + [NT] Replace dh_clean -k with dh_prep. ++ [NT] Add support for skipping the test suite per policy 4.9.1. + Many thanks to David Bremner for the patch. * debian/compat: + [NT] Bump debhelper comat to 7. diff --git a/debian/rules b/debian/rules index 81ceab8..a4a9bc8 100755 --- a/debian/rules +++ b/debian/rules @@ -14,6 +14,12 @@ perlprovides := data/fields/perl-provides onlyrun = tag = +ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) + testtarget = runtests +else + testtarget = +endif + runtests: $(neededfiles) $(allchecks) $(allcollect) $(tagfiles) $(testfiles) @echo running tests rm -rf debian/tests @@ -37,7 +43,7 @@ refresh-perl-provides: perl private/refresh-perl-provides $(perlprovides) build: build-stamp -build-stamp: $(neededfiles) $(docsource) runtests +build-stamp: $(neededfiles) $(docsource) $(testtarget) @echo running build dh_testdir cd doc LANG=C debiandoc2html lintian.sgml -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pvklj-0005ic...@alioth.debian.org
Re: [PATCH] debian/rules: Add support for skipping the test suite per policy 4.9.1
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-21 03:59, brem...@debian.org wrote: From: David Bremner brem...@debian.org Rational: the lintian test suite is somewhat heavyweight, and sometimes broken in git. This makes it hard for people to test new lintian checks. --- debian/rules |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/debian/rules b/debian/rules index 77861c5..497ca49 100755 --- a/debian/rules +++ b/debian/rules [...] Hi Applied and pushed[1], thanks for the patch. ~Niels [1] http://git.debian.org/?p=lintian/lintian.git;a=commit;h=6d868dcf683f3bda40c3ac76afb84c5c7e7629e8 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNEcENAAoJEAVLu599gGRCOfsQAKNG5sWopfhhrI1i6cgDpuC+ PEA0OT7O4E3KC4Apftq2zbTD5ziABtKMk4q1SGMdW08rZClXzwGbUB2rRB45oRgg kuqd/qQl7MpfX1k5oBXjwJk8ePWNlofD+HD4nm1cJAGlT/wP/2GnS2XRDtJJa2pz AFQzZ/znz30FE2MjwrEEz+3GxFUS3HKgQ2nnCDsQSpzEHkLya22kdnQz1BTHW12N 4LuAISgWWxHR6VF+ANVrWsBNIullVoCeHVrrOdKt5gFgA4uI3dPNluZwPKOzI9Dm eWtWEyEMq8IjpeUMDhOxHc6VuO0YrO/W/7ooWaCMaAcP76G1V/HR15Hu9tWuf5z5 3Aj12GMPsbk7/RkXex7/Fk3fpmqvMVtxCcFtX5cSxVf20msSvpDwsiY1neLkTDXf h/37XVIGgTdiIvDhzAnyHetFNw5mwgiM3QlbKvoyjywLayjCWlQkoaeLHYVO7XkU ZvcoSSe6LtvwFBtHB9Cem8Cmv309a3bkh0BGd5nUzH0SxVWVzh6igvupwo/9OjnH XcvhZPOyWyexYJm9UBAbFRtEAIsScfpkzf1dCOSmAThHTsTqS+F6IY+hj+7DFm9A A3dw2Z3L89H1VkxNBIgotn/IkKdhVbN/hhKUhhj611kA0WnBDwX+sToPmiMcTtw/ gV1LaRRpFm/x9IYxddfZ =1nnz -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d11c10d.8090...@thykier.net
Bug#528001: Appears to have been fixed in 2.3.4
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 tags 528001 - patch thanks Hi It appears that all the patches here have been applied. I have not closed it because I assumed it was still open since there is no check for (e.g.) d/source/include-binaries. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNEcOdAAoJEAVLu599gGRC7YEP/R4BKHg5ynGgRAX463i52Pcg 4J8lawJH+LalxCD3N5LXF8oWM5+k+pbGX4+iLtJL6MSUukyF6j3JW5e6ShTPXz+A z08g4jdDf3Di5cnxvqU0jpqdy8UPOnqbNJ37OuP2ZjkrNZalkQ9fsueXDSenUrDT 2iIWCalyS4iOm1F+cQ7RL1i0cd1VkGDdAOFTZumLjJWL+QZffnMOcMQTxbtyWzKa 0lKqhdENNOX5ML07oQc2AyR7sk2WWku/toh/8p3kJ8va0XhxZdndofD/HDYYFbZ2 at/oyjw/ZINs1u30/AzBbi+T68m/eceY/8nU0bcS2ZSrb1wfQCK+w1M8Yr5T+y6i jV3b4LFWvWtvNE9Oh97oPp2mVI3ZLCogHrBRAWVZrpthK2qWYdCmbnyDmVJ5Xwft 13JCl0H1kU0RUxSQi5nwR7nSvn2MglAD4AgS7B34mjv4eXUzzB70kCf3KE7mTmN7 k64btzi1rOVD4rTY2DtKl0lD7qVmgSLaEswYnLV+jw7AHP84cyC/exLGAF/4/hV/ BDqEPHExhoqWv/St2BUlWVmxVZvUp5X7M7vpCU8th/gH2fD/6c5nUGKz77/01iFD 7ZUX/ZxXkC7xovvtDT3ZR8Ocx5brwnuaRuhknUOpBJ0PwlJ8aOyZNDr+Ua/PkDlN BYJPK4YHRP+vHDjNuzNJ =1uKi -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d11c39d.7040...@thykier.net
[SCM] Debian package checker branch, master, updated. 2.4.3-23-g95bb4b1
The following commit has been merged in the master branch:
commit 6cf684cac7e1e4ec92260e6bf03358cf9cc1e4ea
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 22 10:57:16 2010 +0100
Fixed needs-info-missing.t, which was broken by commit 5b36419
diff --git a/t/scripts/needs-info-missing.t b/t/scripts/needs-info-missing.t
index 3999fce..c658487 100755
--- a/t/scripts/needs-info-missing.t
+++ b/t/scripts/needs-info-missing.t
@@ -73,6 +73,8 @@ for my $module (@MODULES) {
}
delete $seen_subs{'new'};
+# Extension of index
+delete $seen_subs{'sorted_index'};
is(scalar(keys(%seen_subs)) + scalar(keys(%seen_needsinfo)), 0,
$pretty_module has per-method needs-info) or
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvlwt-0006pe...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-23-g95bb4b1
The following commit has been merged in the master branch:
commit 95bb4b1b5ed1c1ee3f3f072ba1353ba28502681c
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 22 10:58:37 2010 +0100
Fixed the test regressions caused by commit 894daa6. (Closes #606270)
Made nmu-ubuntu-native Test-Against bad-distribution-in-changes-file,
since it may be broken every time we EOL Ubuntu releases.
diff --git a/t/tests/distribution-ubuntu-native/debian/debian/changelog.in
b/t/tests/distribution-ubuntu-native/debian/debian/changelog.in
index 2731d63..ea4d4f6 100644
--- a/t/tests/distribution-ubuntu-native/debian/debian/changelog.in
+++ b/t/tests/distribution-ubuntu-native/debian/debian/changelog.in
@@ -1,4 +1,4 @@
-{$srcpkg} ({$version}) jaunty; urgency=low
+{$srcpkg} ({$version}) lucid; urgency=low
* Lintian Test Suite.
* Test: {$testname}
diff --git a/t/tests/nmu-ubuntu-native/debian/debian/changelog.in
b/t/tests/nmu-ubuntu-native/debian/debian/changelog.in
index 48636ac..d922e3b 100644
--- a/t/tests/nmu-ubuntu-native/debian/debian/changelog.in
+++ b/t/tests/nmu-ubuntu-native/debian/debian/changelog.in
@@ -1,4 +1,4 @@
-{$srcpkg} ({$version}) jaunty; urgency=low
+{$srcpkg} ({$version}) lucid; urgency=low
* Lintian Test Suite.
* Test: {$testname}
diff --git a/t/tests/nmu-ubuntu-native/desc b/t/tests/nmu-ubuntu-native/desc
index 6bc454a..3ab6019 100644
--- a/t/tests/nmu-ubuntu-native/desc
+++ b/t/tests/nmu-ubuntu-native/desc
@@ -3,4 +3,5 @@ Sequence: 6000
Version: 1.0
Description: Test NMU tag suppression for Ubuntu native packages
Test-Against: changelog-should-mention-nmu
+ bad-distribution-in-changes-file
References: Debian Bug #507740
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvlx1-0006sl...@alioth.debian.org
lintian test suite
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi I had a look at the test suite and it is only a few hick-ups short of being issue free (at least on a x86). I have attached the failures I saw. I heard that some of the legacy tests are known to fail on non-x86 architectures; but I do not have a non-x86 system, so I could not verify this. If anyone has a bit of time to look at them, I would appreciate it. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNEdqIAAoJEAVLu599gGRCtG8P/joRyiZlvXqce0LfnZkQbC42 Jkf0DGcSReE/xOMtZdNhs4GRfjuO5fY3HGDXvL/5vnWybWRBXv7l5gAwgN9IOMNX SiS0N1JTrqGr+bN8fC1Q6ygkFfdTenXSRm7Bv9gfpoqFkhoPoatyMVxRIQlGBQhh eZlZ1NGbUeuxpJmQkHjXfOM2q2OA/UEwuxxfCzAMIhRczT8nZR7G1T+MaqfT/iKm IV840f9kYZb5sYF1jb/uj8JHesGa72NfwfCMp3k9eYAJc+zZaPrGkp8//BrnWt9/ //fYZDNZRycdywMXt7px7QIedbLS41IFiH3UL1hqZOd5JEsKGddfJ0p72vQP9Vh3 9LR5v4L8dpO9iCaFNZfUrn1eiNKYK/zKYz23wnjm4bkVbqdHRtWu6TFT4sludCxw BsUTFQIRXYlms1jyXg5KriSMSKhSY8vpsx30AF+EKRvkWkrkUtpxPcOYrRVBRfwH Fa3sAFKrevXAQaMVhccgqyhGD8tQIuFOmH5d+HRv3G2DVx8F32neW/mtAQjsFJWR 5yqabyPsSOL1G6PGH2a632CXMFsslNcGHh6GA/Lilohr8O5XkUKRnpTugDZGPHJR R35utKMWuRXi9kiEJUImBZLQAS2NFxyTaVSgZ9LRp56fWFmEFFGh50m4NFk9b3R1 kIFVFyrzGWraTv6DMLF4 =xKId -END PGP SIGNATURE- t/scripts/minimum-version.t ... 51/100 # Failed test '/home/user/debian/lintian/t/runtests' # at /usr/share/perl5/Test/MinimumVersion.pm line 104. # /home/user/debian/lintian/t/runtests requires 5.012 due to syntax # version markers for 5.012: # - _yada_yada_yada t/scripts/minimum-version.t ... 100/100 # Looks like you failed 1 test of 100. t/scripts/minimum-version.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/100 subtests Test Summary Report --- t/scripts/minimum-version.t (Wstat: 256 Tests: 100 Failed: 1) Failed test: 51 Non-zero exit status: 1 Running test package-version-0... building... testing... FAILED: --- t/source/package-version-0/tags 2010-08-03 15:05:06.726070395 +0200 +++ debian/tests/tags.package-version-0 2010-12-22 11:04:02.471068769 +0100 @@ -1 +0,0 @@ -E: package-version-0 source: upstream-version-not-numeric unknown tests.sig Description: Binary data
[SCM] Debian package checker branch, master, updated. 2.4.3-24-gdb0e678
The following commit has been merged in the master branch:
commit db0e6781185c8c0c8ce14883ff28d91f90d52a73
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 22 12:43:01 2010 +0100
Implemented fields-build-depends; it checks for some build-depends issues
that was previously only present in the legacy suite.
Updated t/COVERAGE.
diff --git a/t/COVERAGE b/t/COVERAGE
index a8ab743..1ebe133 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,4 +1,4 @@
-Last generated 2010-08-23
+Last generated 2010-12-22
The following tags are not tested by the test suite:
@@ -163,18 +163,12 @@ po-debconf missing-templates-pot
po-debconf not-using-po-debconf
rules debian-rules-is-symlink
-rules debian-rules-not-a-makefile
scripts csh-considered-harmful
-scripts gawk-script-but-no-gawk-dep
scripts killall-is-dangerous
scripts maintainer-script-needs-depends-on-adduser
scripts maintainer-script-needs-depends-on-update-inetd
-scripts mawk-script-but-no-mawk-dep
scripts mknod-in-maintainer-script
-scripts ruby-script-but-no-ruby-dep
-scripts tclsh-script-but-no-tclsh-dep
-scripts wish-script-but-no-wish-dep
shared-libs dev-pkg-without-shlib-symlink
shared-libs ldconfig-symlink-before-shlib-in-deb
@@ -258,19 +252,13 @@ debhelper uses-dh-python-with-no-pycompat
etcfiles file-in-etc-not-marked-as-conffile
-fields build-conflicts-with-build-dependency
fields build-depends-indep-without-arch-indep
-fields build-depends-on-1-revision
-fields build-depends-on-build-essential
-fields build-depends-on-essential-package-without-using-version
-fields build-depends-on-obsolete-package
fields conflicts-with-dependency
fields dbg-package-missing-depends
fields debian-revision-not-well-formed
fields debian-revision-should-not-be-zero
fields debug-package-should-be-priority-extra
fields depends-exclusively-on-makedev
-fields depends-on-build-essential-package-without-using-version
fields depends-on-essential-package-without-using-version
fields depends-on-obsolete-package
fields depends-on-old-emacs
@@ -304,7 +292,6 @@ files dir-or-file-in-var-www
files embedded-feedparser-library
files embedded-javascript-library
files executable-is-not-world-readable
-files extra-license-file
files file-directly-in-usr-share
files file-directly-in-usr-share-doc
files file-in-unusual-dir
@@ -596,7 +583,6 @@ filenames
dir-or-file-in-var-www
embedded-feedparser-library
embedded-javascript-library
- extra-license-file
file-in-usr-lib-sgml
macos-ds-store-file-in-package
macos-resource-fork-file-in-package
@@ -693,14 +679,8 @@ maintainer-scripts
wrong-debian-qa-group-name
relations
- build-conflicts-with-build-dependency
- build-depends-on-1-revision
- build-depends-on-build-essential
- build-depends-on-essential-package-without-using-version
- build-depends-on-obsolete-package
conflicts-with-dependency
depends-exclusively-on-makedev
- depends-on-build-essential-package-without-using-version
depends-on-essential-package-without-using-version
depends-on-obsolete-package
depends-on-old-emacs
diff --git a/t/tests/cruft-updated-libtool/debian/debian/control.in
b/t/tests/fields-build-depends/debian/debian/control.in
similarity index 74%
copy from t/tests/cruft-updated-libtool/debian/debian/control.in
copy to t/tests/fields-build-depends/debian/debian/control.in
index 82de9d0..650d4f1 100644
--- a/t/tests/cruft-updated-libtool/debian/debian/control.in
+++ b/t/tests/fields-build-depends/debian/debian/control.in
@@ -1,9 +1,11 @@
Source: {$srcpkg}
Priority: extra
-Section: {$section}
+Section: devel
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (= 7), libtool
+Build-Depends: debhelper (= 7.0.50~), bd-conflict, revision-1 (= 1.0-1),
+ bash, make, x-dev, build-essential
+Build-Conflicts: bd-conflict
Package: {$srcpkg}
Architecture: {$architecture}
@@ -13,3 +15,4 @@ Description: {$description}
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+
diff --git a/t/tests/fields-build-depends/desc
b/t/tests/fields-build-depends/desc
new file mode 100644
index 000..e1e810f
--- /dev/null
+++ b/t/tests/fields-build-depends/desc
@@ -0,0 +1,12 @@
+Testname: fields-build-depends
+Sequence: 6000
+Version: 1.0
+Description: Check for sane build depends
+Test-For:
+ build-conflicts-with-build-dependency
+ build-depends-on-1-revision
+ build-depends-on-build-essential
+ build-depends-on-essential-package-without-using-version
+ depends-on-build-essential-package-without-using-version
+ build-depends-on-obsolete-package
+
diff --git a/t/tests/fields-build-depends/tags
b/t/tests/fields-build-depends/tags
new file mode 100644
index 000..698f8ef
--- /dev/null
+++ b/t/tests/fields-build-depends/tags
@@ -0,0 +1,6 @@
+E: fields-build-depends source: build-conflicts-with-build-dependency
bd-conflict
+E: fields-build-depends
[SCM] Debian package checker branch, master, updated. 2.4.3-28-g20f9f99
The following commit has been merged in the master branch:
commit 36eaa280e0b90bc7281b68c6d2035e56124ad09f
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 22 16:07:51 2010 +0100
Extended fields-build-depends test to also check for
ored-build-depends-on-obsolete-package
diff --git a/t/COVERAGE b/t/COVERAGE
index 1ebe133..c7f01f6 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -265,7 +265,6 @@ fields depends-on-old-emacs
fields depends-on-python-minimal
fields malformed-dm-upload-allowed
fields needlessly-depends-on-awk
-fields ored-build-depends-on-obsolete-package
fields ored-depends-on-obsolete-package
fields package-depends-on-multiple-libpng-versions
fields package-depends-on-multiple-libstdc-versions
@@ -685,7 +684,6 @@ relations
depends-on-obsolete-package
depends-on-old-emacs
needlessly-depends-on-awk
- ored-build-depends-on-obsolete-package
ored-depends-on-obsolete-package
package-depends-on-multiple-libpng-versions
package-depends-on-multiple-libstdc-versions
diff --git a/t/tests/fields-build-depends/debian/debian/control.in
b/t/tests/fields-build-depends/debian/debian/control.in
index 650d4f1..c9aad19 100644
--- a/t/tests/fields-build-depends/debian/debian/control.in
+++ b/t/tests/fields-build-depends/debian/debian/control.in
@@ -4,7 +4,7 @@ Section: devel
Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: debhelper (= 7.0.50~), bd-conflict, revision-1 (= 1.0-1),
- bash, make, x-dev, build-essential
+ bash, make, x-dev, build-essential, new-package | xlibmesa-gl-dev
Build-Conflicts: bd-conflict
Package: {$srcpkg}
diff --git a/t/tests/fields-build-depends/desc
b/t/tests/fields-build-depends/desc
index e1e810f..e54cef9 100644
--- a/t/tests/fields-build-depends/desc
+++ b/t/tests/fields-build-depends/desc
@@ -9,4 +9,5 @@ Test-For:
build-depends-on-essential-package-without-using-version
depends-on-build-essential-package-without-using-version
build-depends-on-obsolete-package
+ ored-build-depends-on-obsolete-package
diff --git a/t/tests/fields-build-depends/tags
b/t/tests/fields-build-depends/tags
index 698f8ef..83c15cc 100644
--- a/t/tests/fields-build-depends/tags
+++ b/t/tests/fields-build-depends/tags
@@ -3,4 +3,5 @@ E: fields-build-depends source:
build-depends-on-build-essential build-depends
E: fields-build-depends source:
build-depends-on-essential-package-without-using-version build-depends: bash
E: fields-build-depends source: build-depends-on-obsolete-package
build-depends: x-dev
E: fields-build-depends source:
depends-on-build-essential-package-without-using-version make [build-depends:
make]
+I: fields-build-depends source: ored-build-depends-on-obsolete-package
build-depends: xlibmesa-gl-dev
W: fields-build-depends source: build-depends-on-1-revision build-depends:
revision-1 (= 1.0-1)
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvrcr-0001xx...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-28-g20f9f99
The following commit has been merged in the master branch:
commit e47231ba247a865183aff710e262e2fa38fd7d6c
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 22 16:32:47 2010 +0100
Move all Build-Depends related issues from fields-depends-general
to fields-build-depends.
diff --git a/t/tests/fields-build-depends/debian/debian/control.in
b/t/tests/fields-build-depends/debian/debian/control.in
index c9aad19..8a18228 100644
--- a/t/tests/fields-build-depends/debian/debian/control.in
+++ b/t/tests/fields-build-depends/debian/debian/control.in
@@ -4,7 +4,10 @@ Section: devel
Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: debhelper (= 7.0.50~), bd-conflict, revision-1 (= 1.0-1),
- bash, make, x-dev, build-essential, new-package | xlibmesa-gl-dev
+ bash, make, x-dev, build-essential, new-package | xlibmesa-gl-dev,
+ xorg-dev, java-propose-classpath, python3.1-dev, foo [all],
+ bar [i386 any], baz [source i3!86], baz [i386 !amd64],
+ other-pkg [kfreebsd-any], yet-another [any-powerpc]
Build-Conflicts: bd-conflict
Package: {$srcpkg}
diff --git a/t/tests/fields-build-depends/desc
b/t/tests/fields-build-depends/desc
index e54cef9..fe2f4f8 100644
--- a/t/tests/fields-build-depends/desc
+++ b/t/tests/fields-build-depends/desc
@@ -7,7 +7,12 @@ Test-For:
build-depends-on-1-revision
build-depends-on-build-essential
build-depends-on-essential-package-without-using-version
- depends-on-build-essential-package-without-using-version
+ build-depends-on-metapackage
+ build-depends-on-non-build-package
build-depends-on-obsolete-package
+ build-depends-on-python-dev-with-no-arch-any
+ conflicting-negation-in-source-relation
+ depends-on-build-essential-package-without-using-version
+ invalid-arch-string-in-source-relation
ored-build-depends-on-obsolete-package
-
+References: Debian Bug#540594, Debian Bug#551793
diff --git a/t/tests/fields-build-depends/tags
b/t/tests/fields-build-depends/tags
index 83c15cc..98b1f04 100644
--- a/t/tests/fields-build-depends/tags
+++ b/t/tests/fields-build-depends/tags
@@ -1,7 +1,14 @@
E: fields-build-depends source: build-conflicts-with-build-dependency
bd-conflict
E: fields-build-depends source: build-depends-on-build-essential build-depends
E: fields-build-depends source:
build-depends-on-essential-package-without-using-version build-depends: bash
+E: fields-build-depends source: build-depends-on-metapackage build-depends:
xorg-dev
+E: fields-build-depends source: build-depends-on-non-build-package
build-depends: java-propose-classpath
E: fields-build-depends source: build-depends-on-obsolete-package
build-depends: x-dev
+E: fields-build-depends source: conflicting-negation-in-source-relation
build-depends: baz [i386 !amd64]
E: fields-build-depends source:
depends-on-build-essential-package-without-using-version make [build-depends:
make]
+E: fields-build-depends source: invalid-arch-string-in-source-relation all
[build-depends: foo [all]]
+E: fields-build-depends source: invalid-arch-string-in-source-relation i3!86
[build-depends: baz [source i3!86]]
+E: fields-build-depends source: invalid-arch-string-in-source-relation source
[build-depends: baz [source i3!86]]
I: fields-build-depends source: ored-build-depends-on-obsolete-package
build-depends: xlibmesa-gl-dev
W: fields-build-depends source: build-depends-on-1-revision build-depends:
revision-1 (= 1.0-1)
+W: fields-build-depends source: build-depends-on-python-dev-with-no-arch-any
diff --git a/t/tests/fields-depends-general/debian/debian/control.in
b/t/tests/fields-depends-general/debian/debian/control.in
index ca24c2d..e914ad8 100644
--- a/t/tests/fields-depends-general/debian/debian/control.in
+++ b/t/tests/fields-depends-general/debian/debian/control.in
@@ -3,9 +3,7 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (= 7.0.50~), xorg-dev, java-propose-classpath,
- python3.1-dev, foo [all], bar [i386 any], baz [source i3!86],
- baz [i386 !amd64], other-pkg [kfreebsd-any], yet-another [any-powerpc]
+Build-Depends: debhelper (= 7.0.50~)
Package: {$srcpkg}
Architecture: {$architecture}
diff --git a/t/tests/fields-depends-general/desc
b/t/tests/fields-depends-general/desc
index b38609b..b2eca24 100644
--- a/t/tests/fields-depends-general/desc
+++ b/t/tests/fields-depends-general/desc
@@ -4,12 +4,7 @@ Version: 1.0
Description: General tests for package dependencies
Test-For:
breaks-without-version
- build-depends-on-metapackage
- build-depends-on-non-build-package
- build-depends-on-python-dev-with-no-arch-any
- conflicting-negation-in-source-relation
conflicts-with-version
depends-on-metapackage
- invalid-arch-string-in-source-relation
lib-recommends-documentation
-References: Debian Bug#540594, Debian Bug#551793
+
diff --git a/t/tests/fields-depends-general/tags
b/t/tests/fields-depends-general/tags
index 62c13a3..5b34d55 100644
--- a/t/tests/fields-depends
[SCM] Debian package checker branch, master, updated. 2.4.3-28-g20f9f99
The following commit has been merged in the master branch: commit a15414f0e27f66419a03658d24aa8a061c541660 Author: Niels Thykier ni...@thykier.net Date: Wed Dec 22 16:35:48 2010 +0100 Renamed fields-build-depends test to fields-build-depends-general. diff --git a/t/tests/fields-build-depends/debian/debian/control.in b/t/tests/fields-build-depends-general/debian/debian/control.in similarity index 100% rename from t/tests/fields-build-depends/debian/debian/control.in rename to t/tests/fields-build-depends-general/debian/debian/control.in diff --git a/t/tests/fields-build-depends/desc b/t/tests/fields-build-depends-general/desc similarity index 86% rename from t/tests/fields-build-depends/desc rename to t/tests/fields-build-depends-general/desc index fe2f4f8..1bb26b7 100644 --- a/t/tests/fields-build-depends/desc +++ b/t/tests/fields-build-depends-general/desc @@ -1,7 +1,7 @@ -Testname: fields-build-depends +Testname: fields-build-depends-general Sequence: 6000 Version: 1.0 -Description: Check for sane build depends +Description: General tests for build dependencies Test-For: build-conflicts-with-build-dependency build-depends-on-1-revision diff --git a/t/tests/fields-build-depends-general/tags b/t/tests/fields-build-depends-general/tags new file mode 100644 index 000..d0ff234 --- /dev/null +++ b/t/tests/fields-build-depends-general/tags @@ -0,0 +1,14 @@ +E: fields-build-depends-general source: build-conflicts-with-build-dependency bd-conflict +E: fields-build-depends-general source: build-depends-on-build-essential build-depends +E: fields-build-depends-general source: build-depends-on-essential-package-without-using-version build-depends: bash +E: fields-build-depends-general source: build-depends-on-metapackage build-depends: xorg-dev +E: fields-build-depends-general source: build-depends-on-non-build-package build-depends: java-propose-classpath +E: fields-build-depends-general source: build-depends-on-obsolete-package build-depends: x-dev +E: fields-build-depends-general source: conflicting-negation-in-source-relation build-depends: baz [i386 !amd64] +E: fields-build-depends-general source: depends-on-build-essential-package-without-using-version make [build-depends: make] +E: fields-build-depends-general source: invalid-arch-string-in-source-relation all [build-depends: foo [all]] +E: fields-build-depends-general source: invalid-arch-string-in-source-relation i3!86 [build-depends: baz [source i3!86]] +E: fields-build-depends-general source: invalid-arch-string-in-source-relation source [build-depends: baz [source i3!86]] +I: fields-build-depends-general source: ored-build-depends-on-obsolete-package build-depends: xlibmesa-gl-dev +W: fields-build-depends-general source: build-depends-on-1-revision build-depends: revision-1 (= 1.0-1) +W: fields-build-depends-general source: build-depends-on-python-dev-with-no-arch-any diff --git a/t/tests/fields-build-depends/tags b/t/tests/fields-build-depends/tags deleted file mode 100644 index 98b1f04..000 --- a/t/tests/fields-build-depends/tags +++ /dev/null @@ -1,14 +0,0 @@ -E: fields-build-depends source: build-conflicts-with-build-dependency bd-conflict -E: fields-build-depends source: build-depends-on-build-essential build-depends -E: fields-build-depends source: build-depends-on-essential-package-without-using-version build-depends: bash -E: fields-build-depends source: build-depends-on-metapackage build-depends: xorg-dev -E: fields-build-depends source: build-depends-on-non-build-package build-depends: java-propose-classpath -E: fields-build-depends source: build-depends-on-obsolete-package build-depends: x-dev -E: fields-build-depends source: conflicting-negation-in-source-relation build-depends: baz [i386 !amd64] -E: fields-build-depends source: depends-on-build-essential-package-without-using-version make [build-depends: make] -E: fields-build-depends source: invalid-arch-string-in-source-relation all [build-depends: foo [all]] -E: fields-build-depends source: invalid-arch-string-in-source-relation i3!86 [build-depends: baz [source i3!86]] -E: fields-build-depends source: invalid-arch-string-in-source-relation source [build-depends: baz [source i3!86]] -I: fields-build-depends source: ored-build-depends-on-obsolete-package build-depends: xlibmesa-gl-dev -W: fields-build-depends source: build-depends-on-1-revision build-depends: revision-1 (= 1.0-1) -W: fields-build-depends source: build-depends-on-python-dev-with-no-arch-any diff --git a/t/tests/fields-depends-general/desc b/t/tests/fields-depends-general/desc index b2eca24..a39c0d9 100644 --- a/t/tests/fields-depends-general/desc +++ b/t/tests/fields-depends-general/desc @@ -1,7 +1,7 @@ Testname: fields-depends-general Sequence: 6000 Version: 1.0 -Description: General tests for package dependencies +Description: General tests for binary package dependencies Test-For: breaks-without-version conflicts-with-version -- Debian package checker
[SCM] Debian package checker branch, master, updated. 2.4.3-28-g20f9f99
The following commit has been merged in the master branch:
commit 20f9f993175b670cbc1f4d9e7a69b7593ed169a6
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 22 17:03:20 2010 +0100
Added some extra binary package relation checks to
fields-depends-general.
diff --git a/t/COVERAGE b/t/COVERAGE
index c7f01f6..c3ba494 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -253,25 +253,19 @@ debhelper uses-dh-python-with-no-pycompat
etcfiles file-in-etc-not-marked-as-conffile
fields build-depends-indep-without-arch-indep
-fields conflicts-with-dependency
fields dbg-package-missing-depends
fields debian-revision-not-well-formed
fields debian-revision-should-not-be-zero
fields debug-package-should-be-priority-extra
fields depends-exclusively-on-makedev
-fields depends-on-essential-package-without-using-version
-fields depends-on-obsolete-package
fields depends-on-old-emacs
fields depends-on-python-minimal
fields malformed-dm-upload-allowed
-fields needlessly-depends-on-awk
-fields ored-depends-on-obsolete-package
fields package-depends-on-multiple-libpng-versions
fields package-depends-on-multiple-libstdc-versions
fields package-depends-on-multiple-tcl-versions
fields package-depends-on-multiple-tk-versions
fields package-depends-on-multiple-tkx-versions
-fields package-relation-with-self
fields redundant-bugs-field
fields redundant-origin-field
fields unknown-section
@@ -678,19 +672,13 @@ maintainer-scripts
wrong-debian-qa-group-name
relations
- conflicts-with-dependency
depends-exclusively-on-makedev
- depends-on-essential-package-without-using-version
- depends-on-obsolete-package
depends-on-old-emacs
- needlessly-depends-on-awk
- ored-depends-on-obsolete-package
package-depends-on-multiple-libpng-versions
package-depends-on-multiple-libstdc-versions
package-depends-on-multiple-tcl-versions
package-depends-on-multiple-tk-versions
package-depends-on-multiple-tkx-versions
- package-relation-with-self
quilt-build-dep-but-no-series-file
redundant-bugs-field
redundant-origin-field
diff --git a/t/tests/fields-depends-general/debian/debian/control.in
b/t/tests/fields-depends-general/debian/debian/control.in
index e914ad8..230d62f 100644
--- a/t/tests/fields-depends-general/debian/debian/control.in
+++ b/t/tests/fields-depends-general/debian/debian/control.in
@@ -7,9 +7,11 @@ Build-Depends: debhelper (= 7.0.50~)
Package: {$srcpkg}
Architecture: {$architecture}
-Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, xorg
-Breaks: package-without-version
-Conflicts: package-with-version ( 3.0)
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, xorg, bash,
+ conflict-dep, gawk | awk, new-package | xbase-clients, {$srcpkg},
+ gaim
+Breaks: package-without-version, {$srcpkg} ( 0.1)
+Conflicts: package-with-version ( 3.0), conflict-dep
Description: {$description}
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
diff --git a/t/tests/fields-depends-general/desc
b/t/tests/fields-depends-general/desc
index a39c0d9..520d978 100644
--- a/t/tests/fields-depends-general/desc
+++ b/t/tests/fields-depends-general/desc
@@ -4,7 +4,14 @@ Version: 1.0
Description: General tests for binary package dependencies
Test-For:
breaks-without-version
+ conflicts-with-dependency
conflicts-with-version
+ depends-on-essential-package-without-using-version
depends-on-metapackage
+ depends-on-obsolete-package
lib-recommends-documentation
+ needlessly-depends-on-awk
+ ored-depends-on-obsolete-package
+ package-depends-on-itself
+ package-relation-with-self
diff --git a/t/tests/fields-depends-general/tags
b/t/tests/fields-depends-general/tags
index 5b34d55..1a39a46 100644
--- a/t/tests/fields-depends-general/tags
+++ b/t/tests/fields-depends-general/tags
@@ -1,4 +1,11 @@
+E: fields-depends-general: conflicts-with-dependency depends conflict-dep
+E: fields-depends-general: depends-on-essential-package-without-using-version
depends: bash
E: fields-depends-general: depends-on-metapackage depends: xorg
+E: fields-depends-general: depends-on-obsolete-package depends: gaim
+E: fields-depends-general: needlessly-depends-on-awk depends
I: fields-depends-general: conflicts-with-version package-with-version ( 3.0)
+I: fields-depends-general: ored-depends-on-obsolete-package depends:
xbase-clients
+W: fields-depends-general source: package-depends-on-itself
fields-depends-general depends
W: fields-depends-general: breaks-without-version package-without-version
+W: fields-depends-general: package-relation-with-self breaks:
fields-depends-general ( 0.1)
W: libfields-depends-general: lib-recommends-documentation recommends:
debconf-doc
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvrcf-00023o...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-29-g3fbea3b
The following commit has been merged in the master branch:
commit 3fbea3b933c3591959165b3e6d61b90b4a0c41a7
Author: Niels Thykier ni...@thykier.net
Date: Thu Dec 9 21:50:02 2010 +0100
Deprecate default-jdk-builddep and correct list of packages providing
dh_nativejava.
* checks/debhelper:
+ [NT] Fix dependency check for dh_nativejava, default-jdk has never
provided dh_nativejava. (Closes: #606506)
* data/fields/obsolete-packages:
+ [NT] Added default-jdk-builddep (replaced by gcj-native-helper).
diff --git a/checks/debhelper b/checks/debhelper
index 56bbc00..32adec2 100644
--- a/checks/debhelper
+++ b/checks/debhelper
@@ -120,10 +120,12 @@ while (RULES) {
if ($dh_commands_depends-known($dhcommand)) {
my $dep = $dh_commands_depends-value($dhcommand);
- # Special-case default-jdk-builddep. It appears to be a sort
- # of build-essential for Java applications.
+ # Special-case gcj-native-helper, which is a meta-package to
+ # pull this helper. default-jdk-builddep is obsolete, but
+ # we keep it for backwards compatibility, because it used to
+ # serve this purpose.
if ($dhcommand eq 'dh_nativejava') {
- $dep = $dep | default-jdk | default-jdk-builddep;
+ $dep = $dep | gcj-native-helper | default-jdk-builddep;
}
$missingbdeps{$dep} = $dhcommand;
}
diff --git a/data/fields/obsolete-packages b/data/fields/obsolete-packages
index 9726cf0..e4f2a17 100644
--- a/data/fields/obsolete-packages
+++ b/data/fields/obsolete-packages
@@ -56,3 +56,7 @@ xlibmesa-gl
xlibmesa-gl-dev
xlibmesa-glu
xutils
+
+# Last seen in Squeeze
+default-jdk-builddep
+
diff --git a/debian/changelog b/debian/changelog
index 877755a..beea800 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -11,6 +11,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [RA] Exclude kfreebsd-kernel-di-{amd64,i386} from the
embedded-zlib check since it's in the kernel. (Closes: #593397)
+ [RG] Add swipl to the list of known interpreters. (Closes: #591316)
+ * checks/debhelper:
++ [NT] Fix dependency check for dh_nativejava, default-jdk has never
+ provided dh_nativejava. (Closes: #606506)
* checks/debian-source-dir:
+ [NT] Added missing import of Util perl module. Thanks to David
Bremner for the patch.
@@ -37,6 +40,8 @@ lintian (2.4.4) UNRELEASED; urgency=low
intrepid and jaunty.
* data/fields/essential:
+ [RG] Add hurd. (Closes: #591323)
+ * data/fields/obsolete-packages:
++ [NT] Added default-jdk-builddep (replaced by gcj-native-helper).
* debian/control:
+ [RA] Add the build dependencies required to run the test suite
diff --git a/t/tests/debhelper-dh-nativejava/debian/debian/control.in
b/t/tests/debhelper-dh-nativejava/debian/debian/control.in
index cff247e..ccc9a46 100644
--- a/t/tests/debhelper-dh-nativejava/debian/debian/control.in
+++ b/t/tests/debhelper-dh-nativejava/debian/debian/control.in
@@ -3,7 +3,7 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (= 7), default-jdk-builddep
+Build-Depends: debhelper (= 7), gcj-native-helper
Package: {$srcpkg}
Architecture: {$architecture}
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvrkf-0002ov...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-30-g57a16e8
The following commit has been merged in the master branch:
commit 57a16e8bf68374f53d48d6048220522e09797fd9
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 22 18:40:35 2010 +0100
Fix needs-info-missing the right way.
diff --git a/lib/Lintian/Collect/Binary.pm b/lib/Lintian/Collect/Binary.pm
index bc297fb..8198606 100644
--- a/lib/Lintian/Collect/Binary.pm
+++ b/lib/Lintian/Collect/Binary.pm
@@ -123,6 +123,7 @@ sub index {
}
# Returns sorted file index (eqv to sort keys %{$info-index}), except it is
cached.
+# sub sorted_index Needs-Info
sub sorted_index {
my ($self) = @_;
my $index;
diff --git a/t/scripts/needs-info-missing.t b/t/scripts/needs-info-missing.t
index c658487..3999fce 100755
--- a/t/scripts/needs-info-missing.t
+++ b/t/scripts/needs-info-missing.t
@@ -73,8 +73,6 @@ for my $module (@MODULES) {
}
delete $seen_subs{'new'};
-# Extension of index
-delete $seen_subs{'sorted_index'};
is(scalar(keys(%seen_subs)) + scalar(keys(%seen_needsinfo)), 0,
$pretty_module has per-method needs-info) or
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvsht-da...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-31-g22e2a1e
The following commit has been merged in the master branch:
commit 22e2a1ebe8dac84235665f8a2803b5ced31f30d3
Author: Niels Thykier ni...@thykier.net
Date: Tue Dec 7 23:48:52 2010 +0100
Added check for unneeded build-dep on quilt when building a 3.0 (quilt)
package, including a test case for it.
* Summary of tag changes:
+ Added:
- unneeded-build-dep-on-quilt
* checks/patch-systems{,.desc}
+ [NT] Added check for new unneeded-build-dep-on-quilt.
(Closes: #582767)
diff --git a/checks/patch-systems b/checks/patch-systems
index 9934d46..73337e9 100644
--- a/checks/patch-systems
+++ b/checks/patch-systems
@@ -118,6 +118,9 @@ sub run {
#- quilt
if ($build_deps-implies(quilt) or $quilt_format) {
$uses_patch_system++;
+ if($quilt_format $build_deps-implies(quilt)){
+ tag unneeded-build-dep-on-quilt;
+ }
#check for a debian/patches file:
if (! -r debfiles/patches/series) {
tag quilt-build-dep-but-no-series-file unless
$quilt_format;
diff --git a/checks/patch-systems.desc b/checks/patch-systems.desc
index d77749b..f04a9bd 100644
--- a/checks/patch-systems.desc
+++ b/checks/patch-systems.desc
@@ -160,3 +160,11 @@ Info: This package build-depends on a patch system such as
dpatch or
referring to tt/usr/share/doc/quilt/README.source/tt. Similarly, you
can refer to tt/usr/share/doc/dpatch/README.source.gz/tt for dpatch.
Ref: policy 4.14
+
+Tag: unneeded-build-dep-on-quilt
+Severity: normal
+Certainty: certain
+Info: This package build-depends on quilt, which is not required since
+ dpkg-source will apply patches at unpack time for 3.0 (quilt) source
+ packages.
+
diff --git a/debian/changelog b/debian/changelog
index beea800..65fd825 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ Added:
- build-depends-on-specific-java-doc-package
- depends-on-specific-java-doc-package
+ - unneeded-build-dep-on-quilt
* checks/*:
+ [NT] Use the new pre-sorted file index when iterating over files.
@@ -32,6 +33,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
* checks/nmu:
+ [RG] Completely abort if debian/changelog is a symlink.
(Closes: #582408)
+ * checks/patch-systems{,.desc}
++ [NT] Added check for new unneeded-build-dep-on-quilt.
+ (Closes: #582767)
* checks/standards-version:
+ [RG] Correctly handle cases where debian/changelog is a symlink.
diff --git a/t/tests/debhelper-dh-clean-k-ok/debian/debian/control.in
b/t/tests/patch-systems-quilt-source/debian/debian/control.in
similarity index 91%
copy from t/tests/debhelper-dh-clean-k-ok/debian/debian/control.in
copy to t/tests/patch-systems-quilt-source/debian/debian/control.in
index 4a5a774..07c8950 100644
--- a/t/tests/debhelper-dh-clean-k-ok/debian/debian/control.in
+++ b/t/tests/patch-systems-quilt-source/debian/debian/control.in
@@ -3,7 +3,7 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (= 6)
+Build-Depends: debhelper (= 7.0.50~), quilt
Package: {$srcpkg}
Architecture: {$architecture}
diff --git a/t/tests/basic-quilt/debian/debian/source/format
b/t/tests/patch-systems-quilt-source/debian/debian/source/format
similarity index 100%
copy from t/tests/basic-quilt/debian/debian/source/format
copy to t/tests/patch-systems-quilt-source/debian/debian/source/format
diff --git a/t/tests/patch-systems-quilt-source/desc
b/t/tests/patch-systems-quilt-source/desc
new file mode 100644
index 000..d9f6dd1
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/desc
@@ -0,0 +1,7 @@
+Testname: patch-systems-quilt-source
+Sequence: 6000
+Type: non-native
+Version: 1.0-1
+Description: Test for quilt patches which do not have accompanying descriptions
+Test-For: unneeded-build-dep-on-quilt
+References: Debian Bug #582767
diff --git a/t/tests/patch-systems-quilt-source/tags
b/t/tests/patch-systems-quilt-source/tags
new file mode 100644
index 000..856b0e2
--- /dev/null
+++ b/t/tests/patch-systems-quilt-source/tags
@@ -0,0 +1 @@
+W: patch-systems-quilt-source source: unneeded-build-dep-on-quilt
diff --git a/t/tests/basic-3.0-native/debian/README
b/t/tests/patch-systems-quilt-source/upstream/README
similarity index 100%
copy from t/tests/basic-3.0-native/debian/README
copy to t/tests/patch-systems-quilt-source/upstream/README
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvtjf-br...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-32-ga94e7b9
The following commit has been merged in the master branch:
commit a94e7b93c5a7409523b854c8d907ad1809f781ac
Author: Nelson A. de Oliveira nao...@debian.org
Date: Wed Nov 10 10:45:34 2010 -0200
Add a check for synopsis starting with articles
* Summary of tag changes:
+ Added:
- description-synopsis-starts-with-article
* checks/description{,.desc}:
+ [NT] Add a check for synopsis starting with articles. Thanks to
Nelson A. de Oliveira for the patch. (Closes: #603053)
Signed-off-by: Niels Thykier ni...@thykier.net
diff --git a/checks/description b/checks/description
index 0d75b9d..08cfbd4 100644
--- a/checks/description
+++ b/checks/description
@@ -61,6 +61,9 @@ if ($synopsis =~ m/^\s*$/) {
if ($synopsis =~ m/^\Q$pkg\E\b/i) {
tag description-starts-with-package-name, ;
}
+if ($synopsis =~ m/^(an?|the)\s/i) {
+ tag description-synopsis-starts-with-article, ;
+}
if ($synopsis =~ m/(?!etc)\.\s*$/i) {
tag description-synopsis-might-not-be-phrased-properly, ;
}
diff --git a/checks/description.desc b/checks/description.desc
index 26b6043..99cf9d4 100644
--- a/checks/description.desc
+++ b/checks/description.desc
@@ -52,6 +52,17 @@ Info: The first line of the Description: should not start
with the
have a description like this: foo is a program that
Ref: policy 3.4.1
+Tag: description-synopsis-starts-with-article
+Severity: minor
+Certainty: certain
+Info: The first line of the Description: should omit any initial indefinite
+ or definite article: a, an, or the. A good heuristic is that it should
+ be possible to substitute the package ttname/tt and ttsynopsis/tt
+ into this formula:
+ .
+ The package ttname/tt provides {a,an,the,some} ttsynopsis/tt.
+Ref: devref 6.2.2
+
Tag: description-contains-tabs
Severity: important
Certainty: certain
diff --git a/debian/changelog b/debian/changelog
index 65fd825..1ad605c 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
- build-depends-on-specific-java-doc-package
- depends-on-specific-java-doc-package
- unneeded-build-dep-on-quilt
+ - description-synopsis-starts-with-article
* checks/*:
+ [NT] Use the new pre-sorted file index when iterating over files.
@@ -18,6 +19,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
* checks/debian-source-dir:
+ [NT] Added missing import of Util perl module. Thanks to David
Bremner for the patch.
+ * checks/description{,.desc}:
++ [NT] Add a check for synopsis starting with articles. Thanks to
+ Nelson A. de Oliveira for the patch. (Closes: #603053)
* checks/fields{,.desc}:
+ [NT] Added check for packages (build) depending on openjdk-X-doc or
classpath-doc instead of the default-jdk-doc metapackage.
diff --git a/t/tests/description-general/debian/debian/control.in
b/t/tests/description-general/debian/debian/control.in
index cbed638..fff24ba 100644
--- a/t/tests/description-general/debian/debian/control.in
+++ b/t/tests/description-general/debian/debian/control.in
@@ -100,3 +100,15 @@ Description: test package with duplicated words that aren't
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+
+Package: {$srcpkg}-syn-article
+Architecture: {$architecture}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: the synopsis starts with an article
+ A good synopsis should start not start with a, an and the
+ according to devref 6.2.2.
+ .
+ This is a test package designed to exercise some feature or tag of
+ Lintian. It is part of the Lintian test suite and may do very odd
+ things. It should not be installed like a regular package. It may
+ be an empty package.
diff --git a/t/tests/description-general/desc b/t/tests/description-general/desc
index 153d0d0..ebb8708 100644
--- a/t/tests/description-general/desc
+++ b/t/tests/description-general/desc
@@ -15,6 +15,7 @@ Test-For:
description-synopsis-is-duplicated
description-synopsis-is-empty
description-synopsis-might-not-be-phrased-properly
+ description-synopsis-starts-with-article
description-too-long
extended-description-is-empty
extended-description-line-too-long
diff --git a/t/tests/description-general/tags b/t/tests/description-general/tags
index 5775813..57c67af 100644
--- a/t/tests/description-general/tags
+++ b/t/tests/description-general/tags
@@ -15,6 +15,7 @@ W: description-general-2:
possible-unindented-list-in-extended-description
W: description-general-3: extended-description-line-too-long
W: description-general-4: description-contains-homepage
W: description-general-4: spelling-error-in-description mroe more
+W: description-general-syn-article: description-synopsis-starts-with-article
W: description-general: description-contains-dh-make-perl-template
W: description-general
[SCM] Debian package checker branch, master, updated. 2.4.3-33-g3c3c00d
The following commit has been merged in the master branch:
commit 3c3c00dd57393c4916ef85b757432e8211ac6d03
Author: Niels Thykier ni...@thykier.net
Date: Thu Dec 23 18:31:34 2010 +0100
Extended diff-contains-substvars check to also catch package.substvars.
(not closing #598251, since there is still no d/*.debhelper(.log)?
check)
* checks/cruft{,.desc}:
+ [NT] Extended the diff-contains-substvars check to also catch files
prefixed with a package name.
diff --git a/checks/cruft b/checks/cruft
index 34ab8d9..859ba82 100644
--- a/checks/cruft
+++ b/checks/cruft
@@ -237,7 +237,7 @@ sub check_diffstat {
}
# Additional special checks only for the diff, not the full source.
-if ($file eq 'debian/substvars') {
+if ($file =~ m...@^debian/(?:.+\.)?substvars$@) {
tag 'diff-contains-substvars', $file;
}
}
@@ -275,7 +275,7 @@ sub check_debfiles {
}
# Additional special checks only for the diff, not the full source.
-if ($name eq 'substvars') {
+if ($name =~ m@(?:.+\.)?substvars$@) {
tag 'diff-contains-substvars', debian/$name;
}
}
diff --git a/checks/cruft.desc b/checks/cruft.desc
index 12923a6..31198fc 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -303,9 +303,9 @@ Tag: diff-contains-substvars
Severity: normal
Certainty: certain
Info: Lintian found a substvars file in the Debian diff for this source
- package. The debian/substvars file is usually generated and modified
- dynamically by debian/rules targets, in which case it must be removed by
- the clean target.
+ package. The debian/substvars (or debian/package.substvars) file is
+ usually generated and modified dynamically by debian/rules targets, in
+ which case it must be removed by the clean target.
Ref: policy 4.9
Tag: empty-debian-diff
diff --git a/debian/changelog b/debian/changelog
index 1ad605c..54c2559 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -13,6 +13,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [RA] Exclude kfreebsd-kernel-di-{amd64,i386} from the
embedded-zlib check since it's in the kernel. (Closes: #593397)
+ [RG] Add swipl to the list of known interpreters. (Closes: #591316)
+ * checks/cruft{,.desc}:
++ [NT] Extended the diff-contains-substvars check to also catch files
+ prefixed with a package name.
* checks/debhelper:
+ [NT] Fix dependency check for dh_nativejava, default-jdk has never
provided dh_nativejava. (Closes: #606506)
diff --git a/t/tests/cruft-general-diff/debian/debian/substvars
b/t/tests/cruft-general-diff/debian/debian/somepackage.substvars
similarity index 100%
copy from t/tests/cruft-general-diff/debian/debian/substvars
copy to t/tests/cruft-general-diff/debian/debian/somepackage.substvars
diff --git a/t/tests/cruft-general-diff/desc b/t/tests/cruft-general-diff/desc
index df2634d..bad829d 100644
--- a/t/tests/cruft-general-diff/desc
+++ b/t/tests/cruft-general-diff/desc
@@ -22,3 +22,4 @@ Test-For:
diff-contains-svn-commit-file
diff-contains-svn-conflict-file
diff-contains-svn-control-dir
+References: Debian Bug#598251
diff --git a/t/tests/cruft-general-diff/tags b/t/tests/cruft-general-diff/tags
index fb885b4..212d326 100644
--- a/t/tests/cruft-general-diff/tags
+++ b/t/tests/cruft-general-diff/tags
@@ -11,6 +11,7 @@ W: cruft-general-diff source: diff-contains-git-control-dir
.git
W: cruft-general-diff source: diff-contains-hg-control-dir .hg
W: cruft-general-diff source: diff-contains-hg-tags-file .hgtags
W: cruft-general-diff source: diff-contains-patch-failure-file foo.rej
+W: cruft-general-diff source: diff-contains-substvars
debian/somepackage.substvars
W: cruft-general-diff source: diff-contains-substvars debian/substvars
W: cruft-general-diff source: diff-contains-svk-commit-file svk-commit444.tmp
W: cruft-general-diff source: diff-contains-svn-commit-file svn-commit.tmp
diff --git a/t/tests/cruft-general-diff/debian/debian/substvars
b/t/tests/cruft-general-quilt/debian/debian/somepackage.substvars
similarity index 100%
copy from t/tests/cruft-general-diff/debian/debian/substvars
copy to t/tests/cruft-general-quilt/debian/debian/somepackage.substvars
diff --git a/t/tests/cruft-general-quilt/desc b/t/tests/cruft-general-quilt/desc
index 0d99b05..ec26a3d 100644
--- a/t/tests/cruft-general-quilt/desc
+++ b/t/tests/cruft-general-quilt/desc
@@ -21,3 +21,4 @@ Test-For:
diff-contains-svn-commit-file
diff-contains-svn-conflict-file
diff-contains-svn-control-dir
+References: Debian Bug#598251
diff --git a/t/tests/cruft-general-quilt/tags b/t/tests/cruft-general-quilt/tags
index c5fb443..e26ae3c 100644
--- a/t/tests/cruft-general-quilt/tags
+++ b/t/tests/cruft-general-quilt/tags
@@ -10,6 +10,7 @@ W: cruft-general-quilt source: diff-contains-git-control-dir
debian/.git
W: cruft-general-quilt source: diff-contains-hg-control-dir debian/.hg
W: cruft-general-quilt source: diff-contains-hg-tags
[SCM] Debian package checker branch, master, updated. 2.4.3-35-gc3209ba
The following commit has been merged in the master branch:
commit 8bf3d100f769b9166ca73dcdaa995df0e6196d65
Author: Niels Thykier ni...@thykier.net
Date: Thu Dec 23 19:25:36 2010 +0100
Since the empty directory check is skipped for base-files, we
might as well not loop over all the files in the package for it.
This also saves a $pkg eq 'base-files' in every iteration for other
packages.
diff --git a/checks/files b/checks/files
index 07b7fea..f575361 100644
--- a/checks/files
+++ b/checks/files
@@ -1204,15 +1204,16 @@ if ($pkg_section !~ m,games$, and $games 0 and $other
== 0) {
# so just ignore them.
#
# python-support needs a directory for each package even it might be empty
-foreach my $dir (@{$info-sorted_index}) {
-next if $dir eq or $info-index-{$dir}-{type} ne 'd';
-next if ($dir =~ m{^var/} or $dir =~ m{^etc/});
-next if $pkg eq 'base-files';
-if (dir_counts($info, $dir) == 0) {
- if ($dir ne 'usr/lib/perl5/'
- and $dir ne 'usr/share/perl5/'
- and $dir !~ m;^usr/share/python-support/;) {
- tag package-contains-empty-directory, $dir;
+if($pkg ne 'base-files'){
+foreach my $dir (@{$info-sorted_index}) {
+ next if $dir eq or $info-index-{$dir}-{type} ne 'd';
+ next if ($dir =~ m{^var/} or $dir =~ m{^etc/});
+ if (dir_counts($info, $dir) == 0) {
+ if ($dir ne 'usr/lib/perl5/'
+ and $dir ne 'usr/share/perl5/'
+ and $dir !~ m;^usr/share/python-support/;) {
+ tag package-contains-empty-directory, $dir;
+ }
}
}
}
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pvqng-0004pg...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-35-gc3209ba
The following commit has been merged in the master branch: commit c3209bad13e449c694c29aa3e2547f0271529eb9 Author: Niels Thykier ni...@thykier.net Date: Thu Dec 23 19:56:10 2010 +0100 Fixed test regressions caused by description-synopsis-starts-with-article. diff --git a/t/debs/description-synopsis-spaces/control b/t/debs/description-synopsis-spaces/control index 59c2fe4..6b31a2c 100644 --- a/t/debs/description-synopsis-spaces/control +++ b/t/debs/description-synopsis-spaces/control @@ -4,7 +4,7 @@ Architecture: all Maintainer: Debian Lintian Maintainers lintian-ma...@debian.org Section: devel Priority: extra -Description: the synopsis starts with spaces +Description: synopsis starts with spaces This is a test package designed to exercise some feature or tag of Lintian. It is part of the Lintian test suite and may do very odd things. It should not be installed like a regular package. It may diff --git a/t/tests/basic-3.0-native/desc b/t/tests/basic-3.0-native/desc index 26e174f..36b9003 100644 --- a/t/tests/basic-3.0-native/desc +++ b/t/tests/basic-3.0-native/desc @@ -1,4 +1,4 @@ Testname: basic-3.0-native Sequence: 0001 Version: 1.0 -Description: A basic test of a native 3.0 package +Description: Basic test of a native 3.0 package diff --git a/t/tests/basic-with-epoch/desc b/t/tests/basic-with-epoch/desc index 0e30cdc..f5ae926 100644 --- a/t/tests/basic-with-epoch/desc +++ b/t/tests/basic-with-epoch/desc @@ -1,4 +1,4 @@ Testname: basic-with-epoch Sequence: 0001 Version: 1:1.0 -Description: A basic test of a native package with an epoch +Description: Basic test of a native package with an epoch diff --git a/t/tests/unpack-slashes-in-field-name/desc b/t/tests/unpack-slashes-in-field-name/desc index b938d18..14ac1df 100644 --- a/t/tests/unpack-slashes-in-field-name/desc +++ b/t/tests/unpack-slashes-in-field-name/desc @@ -1,4 +1,4 @@ Testname: unpack-slashes-in-field-name Sequence: 3500 Version: 1.0 -Description: A test package with slashes in a control field name +Description: Test package with slashes in a control field name -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pvqnw-0004q9...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-36-gc6f6113
The following commit has been merged in the master branch: commit c6f611345659e2ca36fbd9bb4ab657979007cd29 Author: Niels Thykier ni...@thykier.net Date: Thu Dec 23 20:00:55 2010 +0100 Fixed test regression caused by -brackets in .desc file. diff --git a/checks/cruft.desc b/checks/cruft.desc index 31198fc..3fdc364 100644 --- a/checks/cruft.desc +++ b/checks/cruft.desc @@ -303,8 +303,8 @@ Tag: diff-contains-substvars Severity: normal Certainty: certain Info: Lintian found a substvars file in the Debian diff for this source - package. The debian/substvars (or debian/package.substvars) file is - usually generated and modified dynamically by debian/rules targets, in + package. The debian/substvars (or debian/ttpackage/tt.substvars) file + is usually generated and modified dynamically by debian/rules targets, in which case it must be removed by the clean target. Ref: policy 4.9 -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pvqrt-0005xd...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-37-g25e3b52
The following commit has been merged in the master branch: commit 25e3b52cccbe8c1b1aca46d4fbd6e26fb466652d Author: Niels Thykier ni...@thykier.net Date: Fri Dec 24 11:58:04 2010 +0100 Fixed another synopsis starts with article regression. diff --git a/t/tests/basic/desc b/t/tests/basic/desc index 519fc79..6b36cdb 100644 --- a/t/tests/basic/desc +++ b/t/tests/basic/desc @@ -1,4 +1,4 @@ Testname: basic Sequence: Version: 1.0 -Description: A basic test of a native package +Description: Simple/basic test of a native package -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pw5ns-00070v...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-39-gda5813a
The following commit has been merged in the master branch:
commit da5813a56c7841b02610e8f480b55b65e3deb9b9
Author: Niels Thykier ni...@thykier.net
Date: Fri Dec 24 12:20:15 2010 +0100
Allow hurd-udeb to deploy unusual top-level directories (#591331)
* checks/files:
+ [NT] Added hurd-udeb to the list of packages allowed to ship
unusual top-level directories. Thanks to Samual Thibault for
the patch. (Closes: #591331)
diff --git a/checks/files b/checks/files
index f575361..c2bcaf9 100644
--- a/checks/files
+++ b/checks/files
@@ -655,6 +655,7 @@ foreach my $file (@{$info-sorted_index}) {
tag non-standard-toplevel-dir, $file
unless $pkg eq 'base-files'
or $pkg eq 'hurd'
+ or $pkg eq 'hurd-udeb'
or $pkg =~ /^rootskel(?:-bootfloppy)?/
or $file =~ m,^emul/,;
}
diff --git a/debian/changelog b/debian/changelog
index eb611e2..b3e2064 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -32,6 +32,9 @@ lintian (2.4.4) UNRELEASED; urgency=low
* checks/files:
+ [NT] Fixed false-positive extra-license-file for license.ui files.
Thanks to Jeremy Sanders for the report. (Closes: #595941)
++ [NT] Added hurd-udeb to the list of packages allowed to ship
+ unusual top-level directories. Thanks to Samual Thibault for
+ the patch. (Closes: #591331)
* checks/menu-format.desc:
+ [CW] Fix several typos.
* checks/menus.desc:
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pw5k2-gt...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-40-gdfa2723
The following commit has been merged in the master branch:
commit dfa2723f5b1c64fe83827106a39c723dffa30892
Author: Niels Thykier ni...@thykier.net
Date: Fri Dec 24 12:24:05 2010 +0100
Reworded changelog entry.
diff --git a/debian/changelog b/debian/changelog
index b3e2064..b2fb62f 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -77,8 +77,8 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [NT] Bump debhelper comat to 7.
* lib/Lintian/Collect/Binary.pm:
-+ [NT] Create a sorted file index and file info to avoid sorting it
- in the checks. (Closes: #605844)
++ [NT] Pre-sort file index and file info to avoid sorting it
+ repeatedly in the checks. (Closes: #605844)
* t/tests/{rules-not-makefile,scripts-missing-dep}:
+ [NT] Added new tests. (Closes: #607731)
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pw5mx-o5...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-42-gdfa6336
The following commit has been merged in the master branch: commit d009beae175533b36ef9daac19f41e470e45ecc5 Author: Niels Thykier ni...@thykier.net Date: Fri Dec 24 12:36:19 2010 +0100 Removed duplicated B-D on libapt-pkg-perl and reformatted the D-B field. diff --git a/debian/control b/debian/control index b4cfd12..c3d0053 100644 --- a/debian/control +++ b/debian/control @@ -10,13 +10,32 @@ Uploaders: Josip Rodin joy-packa...@debian.org, Adam D. Barratt a...@adam-barratt.org.uk, Raphael Geissert geiss...@debian.org, Niels Thykier ni...@thykier.net -Build-Depends: debhelper (= 7.0.50~), binutils, debiandoc-sgml, diffstat, - fakeroot, file, gettext, intltool-debian, libapt-pkg-perl, - libclass-accessor-perl, libapt-pkg-perl, libdigest-sha-perl, - libipc-run-perl, libparse-debianchangelog-perl, - libtest-minimumversion-perl, libtest-pod-perl, libtest-strict-perl, - libtest-synopsis-perl, libtext-template-perl, libtimedate-perl, - liburi-perl, locales, man-db, perl, python, quilt, rsync +Build-Depends: binutils + debhelper (= 7.0.50~), + debiandoc-sgml, + diffstat, + fakeroot, + file, + gettext, + intltool-debian, + libapt-pkg-perl, + libclass-accessor-perl, + libdigest-sha-perl, + libipc-run-perl, + libparse-debianchangelog-perl, + libtest-minimumversion-perl, + libtest-pod-perl, + libtest-strict-perl, + libtest-synopsis-perl, + libtext-template-perl, + libtimedate-perl, + liburi-perl, + locales, + man-db, + perl, + python, + quilt, + rsync Standards-Version: 3.9.1 Vcs-Git: git://git.debian.org/git/lintian/lintian.git Vcs-Browser: http://git.debian.org/?p=lintian/lintian.git -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pw5zz-00032d...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-42-gdfa6336
The following commit has been merged in the master branch: commit dfa6336f6d44ee69ab1619cef70c7d7fafba97d5 Author: Niels Thykier ni...@thykier.net Date: Fri Dec 24 12:37:37 2010 +0100 Added test for non-standard-toplevel-dir and file-in-unusual-dir in files-general. diff --git a/t/COVERAGE b/t/COVERAGE index c3ba494..f9390ef 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -1,4 +1,4 @@ -Last generated 2010-12-22 +Last generated 2010-12-24 The following tags are not tested by the test suite: @@ -287,7 +287,6 @@ files embedded-javascript-library files executable-is-not-world-readable files file-directly-in-usr-share files file-directly-in-usr-share-doc -files file-in-unusual-dir files file-in-usr-lib-sgml files file-name-ends-in-whitespace files lengthy-symlink @@ -296,7 +295,6 @@ files macos-resource-fork-file-in-package files non-standard-dir-perm files non-standard-executable-perm files non-standard-setuid-executable-perm -files non-standard-toplevel-dir files package-contains-bts-control-dir files package-contains-devhelp-file-without-symlink files package-contains-hardlink @@ -474,7 +472,6 @@ binary doc-base-unknown-section executable-not-elf-or-script file-directly-in-usr-share - file-in-unusual-dir file-name-ends-in-whitespace lengthy-symlink menu-command-not-in-package @@ -580,7 +577,6 @@ filenames macos-ds-store-file-in-package macos-resource-fork-file-in-package non-standard-dir-perm - non-standard-toplevel-dir package-contains-bts-control-dir package-contains-devhelp-file-without-symlink package-contains-linda-override diff --git a/t/tests/files-general/debian/debian/install b/t/tests/files-general/debian/debian/install index dabd5b3..0e50eb3 100644 --- a/t/tests/files-general/debian/debian/install +++ b/t/tests/files-general/debian/debian/install @@ -10,3 +10,4 @@ lintian-lib.conf etc/ld.so.conf.d php-foo.ini etc/php5/conf.d types usr/share/mime mimeinfo.cache usr/share/applications +file-in-new-top-level-dir new-top-level-dir/ diff --git a/t/tests/files-general/debian/file-in-new-top-level-dir b/t/tests/files-general/debian/file-in-new-top-level-dir new file mode 100644 index 000..ae82d42 --- /dev/null +++ b/t/tests/files-general/debian/file-in-new-top-level-dir @@ -0,0 +1,2 @@ +Since an empty file triggers empty-dir tags; we might as well +test file-in-unusual-dir together with non-standard-toplevel-dir. diff --git a/t/tests/files-general/desc b/t/tests/files-general/desc index 732ca23..3a83141 100644 --- a/t/tests/files-general/desc +++ b/t/tests/files-general/desc @@ -7,9 +7,11 @@ Test-For: dir-or-file-in-var-run duplicated-compressed-file executable-manpage + file-in-unusual-dir global-data-in-games-directory icon-size-and-directory-name-mismatch non-conf-file-in-modprobe.d + non-standard-toplevel-dir obsolete-comments-style-in-php-ini package-contains-empty-directory package-contains-info-dir-file diff --git a/t/tests/files-general/tags b/t/tests/files-general/tags index a05c103..668f40d 100644 --- a/t/tests/files-general/tags +++ b/t/tests/files-general/tags @@ -3,6 +3,7 @@ E: files-general: dir-or-file-in-var-run var/run/lintian/ E: files-general: executable-manpage usr/share/man/man5/foo.5.gz E: files-general: global-data-in-games-directory usr/share/games/icons/hicolor/22x22/lintian-22x22.png E: files-general: non-conf-file-in-modprobe.d etc/modprobe.d/--lzma +E: files-general: non-standard-toplevel-dir new-top-level-dir/ E: files-general: package-contains-info-dir-file usr/share/info/dir.gz E: files-general: package-contains-mime-cache-file usr/share/mime/types E: files-general: package-contains-mimeinfo.cache-file usr/share/applications/mimeinfo.cache @@ -12,6 +13,7 @@ E: files-general: stray-directory-in-manpage-directory usr/share/man/man1/random I: files-general: duplicated-compressed-file usr/share/doc/lintian/lintian-16x16.png.gz I: files-general: package-contains-empty-directory usr/share/man/man1/random/ W: files-general: executable-not-elf-or-script ./usr/share/man/man5/foo.5.gz +W: files-general: file-in-unusual-dir new-top-level-dir/file-in-new-top-level-dir W: files-general: icon-size-and-directory-name-mismatch usr/share/apps/lintian/icons/hicolor/22x22/lintian-16x16.png 16x16 W: files-general: obsolete-comments-style-in-php-ini etc/php5/conf.d/php-foo.ini W: files-general: windows-devel-file-in-package usr/lib/foo/foo.vcproj -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pw601-000338...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-43-gdcba716
The following commit has been merged in the master branch:
commit dcba7168b753d504aefe0890efbdc44d31efed9d
Author: Niels Thykier ni...@thykier.net
Date: Fri Dec 24 12:50:13 2010 +0100
Fixed spelling of metapackage (#591300)
* checks/fields{,.desc}:
+ [NT] Fixed spelling of metapackage in tag descriptions.
* checks/files{,.desc}:
+ [NT] Fixed spelling of metapackage in empty-binary-package tag
description. (Closes: #591300)
diff --git a/checks/debhelper b/checks/debhelper
index 32adec2..9bd089a 100644
--- a/checks/debhelper
+++ b/checks/debhelper
@@ -120,7 +120,7 @@ while (RULES) {
if ($dh_commands_depends-known($dhcommand)) {
my $dep = $dh_commands_depends-value($dhcommand);
- # Special-case gcj-native-helper, which is a meta-package to
+ # Special-case gcj-native-helper, which is a metapackage to
# pull this helper. default-jdk-builddep is obsolete, but
# we keep it for backwards compatibility, because it used to
# serve this purpose.
diff --git a/checks/fields b/checks/fields
index af5fae5..e1f2043 100644
--- a/checks/fields
+++ b/checks/fields
@@ -495,8 +495,8 @@ if (defined $info-field('installer-menu-item')) {
# Package relations (binary package)
-# Check whether the package looks like a meta-package, used for later
-# dependency checks. We consider a package to possibly be a meta-package if
+# Check whether the package looks like a metapackage, used for later
+# dependency checks. We consider a package to possibly be a metapackage if
# it is a binary package with no files outside of /usr/share/doc and a few
# other directories found in metapackges. This also catches documentation
# packages, but that doesn't matter for our purposes.
diff --git a/checks/fields.desc b/checks/fields.desc
index cf91829..672b9d2 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -837,7 +837,7 @@ Info: You use the Bugs field though the field value is the
default
Tag: build-depends-on-build-essential
Info: You depend on the build-essential package, which is only a
- meta-package depending on build tools that have to be installed in all
+ metapackage depending on build tools that have to be installed in all
build environments.
Severity: important
Certainty: certain
diff --git a/checks/files.desc b/checks/files.desc
index 462a075..bf7786f 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1138,13 +1138,13 @@ Tag: empty-binary-package
Severity: important
Certainty: wild-guess
Info: This binary package appears to be empty, and its description does
- not say that it's a meta-package or a transitional package. This is
+ not say that it's a metapackage or a transitional package. This is
often due to problems with updating debhelper *.install files during
package renames or similar problems where installation rules don't put
files in the correct place.
.
If the package is deliberately empty, please mention in the package long
- description one of the phrases meta-package, dummy, dependency
+ description one of the phrases metapackage, dummy, dependency
package, empty package, or virtual package.
Tag: star-file
diff --git a/debian/changelog b/debian/changelog
index b2fb62f..31e3b9d 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -29,12 +29,15 @@ lintian (2.4.4) UNRELEASED; urgency=low
+ [NT] Added check for packages (build) depending on openjdk-X-doc or
classpath-doc instead of the default-jdk-doc metapackage.
(Closes: #593837)
- * checks/files:
++ [NT] Fixed spelling of metapackage in tag descriptions.
+ * checks/files{,.desc}:
+ [NT] Fixed false-positive extra-license-file for license.ui files.
Thanks to Jeremy Sanders for the report. (Closes: #595941)
+ [NT] Added hurd-udeb to the list of packages allowed to ship
unusual top-level directories. Thanks to Samual Thibault for
the patch. (Closes: #591331)
++ [NT] Fixed spelling of metapackage in empty-binary-package tag
+ description. (Closes: #591300)
* checks/menu-format.desc:
+ [CW] Fix several typos.
* checks/menus.desc:
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pw6cz-0004qk...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-44-g960b297
The following commit has been merged in the master branch: commit 960b297cb273bc6b394b2da308e12a73e8c8d57e Author: Niels Thykier ni...@thykier.net Date: Fri Dec 24 12:56:25 2010 +0100 * data/shared-libs/ldconfig-dirs: + [NT] Removed the emul/ia32-linux directories as they are no longer used. (Closes: #596848) diff --git a/data/shared-libs/ldconfig-dirs b/data/shared-libs/ldconfig-dirs index 0b3dfbb..7f251a6 100644 --- a/data/shared-libs/ldconfig-dirs +++ b/data/shared-libs/ldconfig-dirs @@ -16,10 +16,6 @@ lib64 usr/lib32 usr/lib64 -# Used by the Debian amd64 port for 32-bit libraries. -emul/ia32-linux/lib -emul/ia32-linux/usr/lib - # This is now obsolete, but is still in the standard ld.so.conf. usr/X11R6/lib diff --git a/debian/changelog b/debian/changelog index 31e3b9d..42a112d 100755 --- a/debian/changelog +++ b/debian/changelog @@ -55,6 +55,9 @@ lintian (2.4.4) UNRELEASED; urgency=low * data/changelog-file/ubuntu-dists: + [CW] Add natty as a valid Ubuntu distribution, and remove the EOLed intrepid and jaunty. + * data/shared-libs/ldconfig-dirs: ++ [NT] Removed the emul/ia32-linux directories as they are no longer + used. (Closes: #596848) * data/fields/essential: + [RG] Add hurd. (Closes: #591323) * data/fields/obsolete-packages: -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pw6i0-0005wl...@alioth.debian.org
Bug#596848: emul/ia32-linux is no longer used
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hey I have removed those directories from data/shared-libs/ldconfig-dirs. I suspect this would also make emul an unusal top-level directory as well, but I would like someone to confirm this assertion before I act on it. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNFItmAAoJEAVLu599gGRCyfwP/2ncYs4rVAtjvFmaAZ2u5415 +whdqR85U3j2pbyYjGSrop6BsGyJSGCo64s9Jet9A38KvenBDpw9pjLAX7YH0rrY maxKIl+bisOv/9klV4oW1k3Lj+UvjdGbvbKvTCb/f6WWFch95jqpXnqK9FG2xFxc +9NRNYro6e/Ky9IB7nIXP2hluGpVqtaVzjII1DF1Cg+GQD1CRHkzwOqPxArPmYEq KuptpKDj9y32U0rEd+lHbcbTHVW8DBTehR9iB6fyvKyTRWYmHRnCBl4hhBNL++FU 0b7YbXWsU+g5fRKTBqWNQFR5zzpT1XIYdy6Ix+dSVGFCVQT8zXIN5ZqBBAzsts05 3kudKW9a0wdA6WiIk7MobdtN2oztuRzlWmQOhbn35NiGZkg3prRWQ5LLRef4QuF0 4ocVKhT17zfJGr8XF/qRj0mj8gM5hpx56i+2yEG7HuKvQlZioLamF5Mf2EUC+AoV /1MSzM0ewyPVOb37btbhn68ORlrfh9QEkpR0orn5crpxvHd2mGohD5Qkd9ZrgUtq b5vZXrzDQKxwPLr4DN7IjaIXiYAAU8lmzvTCM+4tnLwbS04WqmvKybeqpfGtu6bP 63MQB9rKdo6htyZ7KxvsHG2pnPKSxSMp78Td9doak6aQuYuba2UgMZrPAaagYoyn lGfMINUPQIyS5M63+Pal =jbEZ -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d148b66.5030...@thykier.net
[SCM] Debian package checker branch, master, updated. 2.4.3-46-g4ac1fbb
The following commit has been merged in the master branch:
commit 3f2a1b9bdbec07efee85576e1ff008efa2a0dc8d
Author: Niels Thykier ni...@thykier.net
Date: Fri Dec 24 12:58:16 2010 +0100
Removed the emul/ia32-linux exception for file-in-unusual-dir.
diff --git a/checks/files b/checks/files
index c2bcaf9..6cc08f9 100644
--- a/checks/files
+++ b/checks/files
@@ -684,7 +684,6 @@ foreach my $file (@{$info-sorted_index}) {
# non-FHS, but still usual
or $file =~ m,^usr/[^/]+-linux[^/]*/,
or $file =~ m,^usr/iraf/,
- or $file =~ m,^emul/ia32-linux/(?:lib|usr/lib)/,
# not allowed, but tested indivudually
or $file =~ m,^(?:mnt|opt|srv|(?:(?:usr|var)/)?tmp)|var/www/,) {
tag file-in-unusual-dir, $file;
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pwatu-00025j...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-46-g4ac1fbb
The following commit has been merged in the master branch: commit 4ac1fbb315e8680e385fbb3feeb5d8095c0aa117 Author: Niels Thykier ni...@thykier.net Date: Fri Dec 24 17:24:19 2010 +0100 Removed unneeded tag in package-version-0/tags now that dpkg handles version 0 correctly. diff --git a/t/source/package-version-0/tags b/t/source/package-version-0/tags index 09e0c2b..e69de29 100644 --- a/t/source/package-version-0/tags +++ b/t/source/package-version-0/tags @@ -1 +0,0 @@ -E: package-version-0 source: upstream-version-not-numeric unknown -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pwaty-00026p...@alioth.debian.org
Re: lintian test suite
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-24 14:22, Adam D. Barratt wrote: On Wed, 2010-12-22 at 12:01 +0100, Niels Thykier wrote: I had a look at the test suite and it is only a few hick-ups short of being issue free (at least on a x86). I have attached the failures I saw. This one: -E: package-version-0 source: upstream-version-not-numeric unknown was a side-effect of a bug in Dpkg::Changelog. Russ filed #587382 at the same time as committing the change adding the above to the expected result; as the dpkg bug has now been fixed in unstable and testing for a while, we should probably just remove the tag from the test's tags file. Regards, Adam Cool, I have fixed that now. So the new test suite now only suffers from the false positive t/scripts/minimum-version.t. I might have a look at dealing with the libbaz issue tomorrow. :) ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNFMpKAAoJEAVLu599gGRCOQgP/RH2vbtxClMueaKVVuobGzDM v6sMG+wkwGXvuEXzxjCy9qc0wvPrwsdv5PaJwIIpd3xWJrIB2EFSVwue9xVmspSn DlZo7zrTHfKwlzAeCXxCzbFqnBXLl5l8p+eVejOwjEcbc/VaBWMwgxv9Elld0rrb YeIllr6YFibWS4dI9XRt9R/Gjzvn6nB+jTTPPIqqhqd+jWx23pChnbfWxX0vgN6W A9MALExCGbuiv0BKcKIN7UxHqe/jIlEouDWXIK89DzmvOfqJPH7hzFIp1HnuU41J iLr+7lCnPQ29NJqk4CUFe1/bqJ07HohF1YFIWWKz2P9fLfJugh3VmEbIH+NPlOLb k83jAccYVYxoWX8mg8lq74UUdnXilrkhT7ojQ8zzb6GjNzsezuRliEgWWqjwb9/s gTP7z3N8XRk+dAIzkOpYkGN0CmXV5mFEA1mUPH2Mw6J9/zBEjmc1DPn1EwLda7f1 hKIw+Ht2LZBKO7C1PnUMzl0pqd10xCfzkMc/zjvtwV0VSk5K/jgExqgd5lpG6pSx OKhrEmvKMF/uesqUTlxf5pnJ4NJn8FOC6ZCGb1Yevq9oSI9kuaw2vntqd+xlwevZ TftdN/xh5rCZPD2c2CCqjW06xFDpc1zdBVRzHrryIALT74gUlqIfiUymTA02F+4Q qOQC6cHjYHdiZAtWe1hR =sgoG -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d14ca4b.9050...@thykier.net
Bug#598251: Suggested patch for Warn about leftover *.debhelper.log and *.substvars
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Tags: patch
Hey,
I made a suggestion on how to implement this, although I am a bit
conflicted. On one hand I would like to add it to the cruft check (where
the substvars check is) on the other hand it is also related to
debhelper (which is where I added it).
If anyone has any strong preferences either way, please voice them.
Otherwise I will just go with this patch.
~Niels
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBCAAGBQJNFNalAAoJEAVLu599gGRCcKAP+wX+pbb29T1y5UlwJxWwYLeL
GtM91fSo3MeQZm4bYCDwrEeb4+suRrtubilbQY6JMyMB0GNeWnvYGIKWD14CgIWP
GFPqBzjeRoOgUwiEgUbwS0CG6Jd3wSFJexLzkz+qq6nkRk2a9LL/KaYxCEWWJUqg
mV1KvxvgC37k8TvBp4Yz0WdB81YBhw2FhB0PrGLdPbom+fgcqz2CzXas3POaHtgL
0iLrDTV+bapT/1UxeUSL6fwm1M1lXIFSX51wf6iU5CE8dWm9MmC/ywzjvRylws/f
X6koDrEoxv4HVOsHsNwQvUhZcAvDUKj5N4zI0quRx2Tv4Y9UU89P6uYHgdgwund2
gZD++wQuMDLnaiALonPr6OwdfQuK9+EarERdiALNsBkj82JOiSPum0pZRZDyqXnR
g1XqEOjUGI1vcy8Va0+xMnRCJ67oXGJGIZ8Ggv7wq0HpkdMsJlKRPhUUVoos/ErE
7CBKifXzl1J2drrquQ8B9okZq05LRTsdnFUx29MU10K7eXlVQpZH34zgJnmUUw0d
C3Moi06IzmPI8+y7UCmmKbuMDWPLkKThCY/Y2PymASg6Uo5o70ViPCZltUfunhJP
9TzI5IjOv4/EfPIRGd2B00djttG8RN/RzaVgM6ulE0HtWhV6T4mQhLi6w8hT5I0B
Kef/NQEHTesSDp58DcGK
=ruxU
-END PGP SIGNATURE-
From 9a0a22bc0447f56ce9781a1ab24dc5e9d327f3dc Mon Sep 17 00:00:00 2001
From: Niels Thykier ni...@thykier.net
Date: Fri, 24 Dec 2010 18:17:17 +0100
Subject: [PATCH] Check for leftover internal debhelper files.
---
checks/debhelper | 15 +++
checks/debhelper.desc | 10 ++
.../debian/debian/package.debhelper.log|1 +
.../debian/debian/package.postinst.debhelper |1 +
t/tests/debhelper-internal-files/desc |6 ++
t/tests/debhelper-internal-files/tags |1 +
6 files changed, 34 insertions(+), 0 deletions(-)
create mode 100644 t/tests/debhelper-internal-files/debian/debian/package.debhelper.log
create mode 100644 t/tests/debhelper-internal-files/debian/debian/package.postinst.debhelper
create mode 100644 t/tests/debhelper-internal-files/desc
create mode 100644 t/tests/debhelper-internal-files/tags
diff --git a/checks/debhelper b/checks/debhelper
index 9bd089a..3b750f7 100644
--- a/checks/debhelper
+++ b/checks/debhelper
@@ -241,6 +241,7 @@ if ($seendhcleank and $level = 7) {
# Check the files in the debian directory for various debhelper-related
# things.
+my @indebfiles = ();
opendir(DEBIAN, 'debfiles')
or fail(Can't open debfiles directory.);
while (defined(my $file=readdir(DEBIAN))) {
@@ -303,6 +304,8 @@ while (defined(my $file=readdir(DEBIAN))) {
}
} elsif ($file =~ m/^ex\.|\.ex$/i) {
tag dh-make-template-in-source, debian/$file;
+} elsif ($file =~ m/^(?:.+\.)?debhelper(?:\.log)?/){
+ push(@indebfiles, $file);
} else {
my $base = $file;
$base =~ s/^[.]+\.//;
@@ -329,6 +332,18 @@ while (defined(my $file=readdir(DEBIAN))) {
}
closedir(DEBIAN);
+if(scalar(@indebfiles)){
+my $f = pop(@indebfiles);
+my $others = scalar(@indebfiles);
+my $otext = ;
+if($others 1){
+ $otext = and $others others;
+} elsif($others == 1){
+ $otext = and 1 other;
+}
+tag temporary-debhelper-file, $f$otext;
+}
+
# Check for Python policy usage and the required debhelper dependency for
# dh_python policy support. Assume people who intentionally set pycompat to
# something earlier than 2 know what they're doing. Skip CDBS packages since
diff --git a/checks/debhelper.desc b/checks/debhelper.desc
index 312e78b..bf163d9 100644
--- a/checks/debhelper.desc
+++ b/checks/debhelper.desc
@@ -212,3 +212,13 @@ Info: The debhelper compatibility level specified in ttdebian/rules/tt
methods to generate the compatibility level, write the output into
ttdebian/compat/tt instead of setting DH_COMPAT. The latter should
be available for a user to override temporarily.
+
+Tag: temporary-debhelper-file
+Severity: important
+Certainty: certain
+Ref: dh_clean(1)
+Info: The package contains temporary debhelper files, which are normally
+ removed by ttdh_clean/tt. The most common cause for this is that a
+ binary package has been renamed or removed without cleaning the build
+ directory first.
+
diff --git a/t/tests/debhelper-internal-files/debian/debian/package.debhelper.log b/t/tests/debhelper-internal-files/debian/debian/package.debhelper.log
new file mode 100644
index 000..3cb1115
--- /dev/null
+++ b/t/tests/debhelper-internal-files/debian/debian/package.debhelper.log
@@ -0,0 +1 @@
+debhelper log file for package
diff --git a/t/tests/debhelper-internal-files/debian/debian/package.postinst.debhelper b/t/tests/debhelper-internal-files/debian/debian/package.postinst.debhelper
new file mode 100644
index 000..1cd1647
--- /dev/null
+++ b/t/tests/debhelper-internal-files/debian/debian/package.postinst.debhelper
[SCM] Debian package checker branch, master, updated. 2.4.3-48-g7c84b9d
The following commit has been merged in the master branch:
commit e11c14be6cbb337dd8cb53ff01a4b40af0967fe0
Author: Niels Thykier ni...@thykier.net
Date: Sat Dec 25 12:54:44 2010 +0100
Reformat Depends for lintian.
diff --git a/debian/control b/debian/control
index c3d0053..91d36e6 100644
--- a/debian/control
+++ b/debian/control
@@ -42,10 +42,23 @@ Vcs-Browser: http://git.debian.org/?p=lintian/lintian.git
Package: lintian
Architecture: all
-Depends: ${misc:Depends}, binutils, dpkg-dev, diffstat, file, gettext,
- intltool-debian, libapt-pkg-perl, libclass-accessor-perl,
- libdigest-sha-perl, libipc-run-perl, libparse-debianchangelog-perl,
- libtimedate-perl, liburi-perl, locales, man-db, perl
+Depends: ${misc:Depends},
+ binutils,
+ diffstat,
+ dpkg-dev,
+ file,
+ gettext,
+ intltool-debian,
+ libapt-pkg-perl,
+ libclass-accessor-perl,
+ libdigest-sha-perl,
+ libipc-run-perl,
+ libparse-debianchangelog-perl,
+ libtimedate-perl,
+ liburi-perl,
+ locales,
+ man-db,
+ perl
Suggests: binutils-multiarch, libtext-template-perl, man-db (= 2.5.1-1)
Description: Debian package checker
Lintian dissects Debian packages and reports bugs and policy
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pwtje-0007bh...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-48-g7c84b9d
The following commit has been merged in the master branch: commit 7c84b9d4b7a4d7229580b42b17245fceabd5722b Author: Niels Thykier ni...@thykier.net Date: Sat Dec 25 13:31:37 2010 +0100 Fix parse error of B-D field. diff --git a/debian/control b/debian/control index 91d36e6..42a224f 100644 --- a/debian/control +++ b/debian/control @@ -10,7 +10,7 @@ Uploaders: Josip Rodin joy-packa...@debian.org, Adam D. Barratt a...@adam-barratt.org.uk, Raphael Geissert geiss...@debian.org, Niels Thykier ni...@thykier.net -Build-Depends: binutils +Build-Depends: binutils, debhelper (= 7.0.50~), debiandoc-sgml, diffstat, -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pwtjk-0007gg...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-49-g4a87d0f
The following commit has been merged in the master branch: commit 4a87d0fdd4fc8744c9131729ed238dbc9437fe67 Author: Niels Thykier ni...@thykier.net Date: Sat Dec 25 14:05:14 2010 +0100 Explained where to find more information about the default-jdk-builddep deprecation in d/changelog. diff --git a/debian/changelog b/debian/changelog index 42a112d..3bfd7b6 100755 --- a/debian/changelog +++ b/debian/changelog @@ -61,7 +61,8 @@ lintian (2.4.4) UNRELEASED; urgency=low * data/fields/essential: + [RG] Add hurd. (Closes: #591323) * data/fields/obsolete-packages: -+ [NT] Added default-jdk-builddep (replaced by gcj-native-helper). ++ [NT] Added default-jdk-builddep. See README.gcj-native-transition + in java-common for the replacement. * debian/control: + [RA] Add the build dependencies required to run the test suite -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pwtr6-0007fk...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-50-gcc7f32e
The following commit has been merged in the master branch:
commit cc7f32e346f99895bed81c7567e98626c78ba379
Author: Niels Thykier ni...@thykier.net
Date: Sat Dec 25 14:12:46 2010 +0100
Added test case for dir-or-file-in-{srv,var-www}.
Updated t/COVERAGE
- upstream-version-not-numeric is no longer tested after commit
4ac1fbb
diff --git a/t/COVERAGE b/t/COVERAGE
index f9390ef..76df57b 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,4 +1,4 @@
-Last generated 2010-12-24
+Last generated 2010-12-25
The following tags are not tested by the test suite:
@@ -80,6 +80,7 @@ fields unknown-architecture
fields unknown-field-in-control
fields unknown-field-in-dsc
fields unknown-priority
+fields upstream-version-not-numeric
fields wrong-section-for-udeb
files FSSTND-dir-in-var
@@ -280,8 +281,6 @@ fields wrong-debian-qa-group-name
files bad-permissions-for-ali-file
files desktop-file-in-wrong-dir
-files dir-or-file-in-srv
-files dir-or-file-in-var-www
files embedded-feedparser-library
files embedded-javascript-library
files executable-is-not-world-readable
@@ -569,8 +568,6 @@ filenames
bad-permissions-for-ali-file
debian-news-file-not-compressed
desktop-file-in-wrong-dir
- dir-or-file-in-srv
- dir-or-file-in-var-www
embedded-feedparser-library
embedded-javascript-library
file-in-usr-lib-sgml
diff --git a/t/tests/files-foo-in-bar/debian/debian/install
b/t/tests/files-foo-in-bar/debian/debian/install
index abaf98f..0028454 100644
--- a/t/tests/files-foo-in-bar/debian/debian/install
+++ b/t/tests/files-foo-in-bar/debian/debian/install
@@ -9,5 +9,7 @@ bar usr/lib/debug/
bar usr/lib/site-python/foo
bar usr/share/doc/files-foo-in-bar/examples/examples
bar var/foo
+bar srv/foo
bar var/lock/foo
bar var/run/foo
+bar var/www/foo
diff --git a/t/tests/files-foo-in-bar/desc b/t/tests/files-foo-in-bar/desc
index e25ac59..2d26ffc 100644
--- a/t/tests/files-foo-in-bar/desc
+++ b/t/tests/files-foo-in-bar/desc
@@ -5,9 +5,11 @@ Description: Test tags about files or dirs in given paths
Test-For:
dir-in-usr-local
dir-or-file-in-mnt
+ dir-or-file-in-srv
dir-or-file-in-tmp
dir-or-file-in-var-lock
dir-or-file-in-var-run
+ dir-or-file-in-var-www
file-in-usr-lib-site-python
file-in-usr-local
nested-examples-directory
diff --git a/t/tests/files-foo-in-bar/tags b/t/tests/files-foo-in-bar/tags
index 181b4e0..c2e6877 100644
--- a/t/tests/files-foo-in-bar/tags
+++ b/t/tests/files-foo-in-bar/tags
@@ -1,12 +1,16 @@
E: files-foo-in-bar: dir-in-usr-local usr/local/foo/
E: files-foo-in-bar: dir-or-file-in-mnt mnt/foo/
E: files-foo-in-bar: dir-or-file-in-mnt mnt/foo/bar
+E: files-foo-in-bar: dir-or-file-in-srv srv/foo/
+E: files-foo-in-bar: dir-or-file-in-srv srv/foo/bar
E: files-foo-in-bar: dir-or-file-in-tmp tmp/foo/
E: files-foo-in-bar: dir-or-file-in-tmp tmp/foo/bar
E: files-foo-in-bar: dir-or-file-in-var-lock var/lock/foo/
E: files-foo-in-bar: dir-or-file-in-var-lock var/lock/foo/bar
E: files-foo-in-bar: dir-or-file-in-var-run var/run/foo/
E: files-foo-in-bar: dir-or-file-in-var-run var/run/foo/bar
+E: files-foo-in-bar: dir-or-file-in-var-www var/www/foo/
+E: files-foo-in-bar: dir-or-file-in-var-www var/www/foo/bar
E: files-foo-in-bar: file-in-usr-lib-site-python usr/lib/site-python/foo/
E: files-foo-in-bar: file-in-usr-lib-site-python usr/lib/site-python/foo/bar
E: files-foo-in-bar: file-in-usr-local usr/local/foo/bar
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pwtyp-gj...@alioth.debian.org
Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi I am considering to just make the switch to use Email::Valid. I have attached a patch that makes the switch and introduces a regression test to catch the particular issue in #602619. ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNFekwAAoJEAVLu599gGRCooEP/R/ZMEPkxCB7s0l5Et3qfT9x 7mEWUa8B5YLGVqN1BptfOITa4q9lO3gn/5B8QLlOGteGbzWqfwJH6SK3tsxEkvN9 KKKRwTMzunN5VNq/Wgkd3dEqH6ssmTKKf5QE7qGazUcC1hPCexrRx9VtMU1JZ01p 9bEn5wToO6fbPM1bF2PQbyQpzhu76RLmeHAdaSwYFQRkybGxawy01xT/RfDYkoCQ oci9qDQu/ShGEU7AdKhidMqpPAdvdLHHhWLiBXiC7aOP07+8yFhVE31NMe1z6vBY L7KaBp55rK2IzKNu0bD8265C9zGCLPDiOT2R3+uxaHUmneiIG53uhOyykkrf/Lkq aFjDVJM2tVJtxzp3y6GKGC3fFyZFGLITTM50qOcVMKgK0aZvdxQ22Zov/EYIlWt9 /c4fVHwLaYElarsibIkwAZ1AYxJ/wQ743E9y5HniP4rJNf6tYwp/+1hcydoSuZNQ J1uCzF73eiclmj37Q4cUwdfBbxIwsxJOTzUNA0LsrmuRYy2kUeR8GDZHg6Q19aGc ZrhYHHUSMgSrnKZSjSUeI0fbIezVhwzAngXHYKN43w1krCH1v1bBaabW9RwGk3oN 4CUR8mBRQAet/kAEMu8NaFHM27yHvQ2v5wWwV0YHvnspNYgydrFLv1Y3GKXUuJ3R /MCCiL31qaKG/KOQjL6q =9sLf -END PGP SIGNATURE- 0001-Made-Lintian-Check-use-Email-Valid-to-parse-emails-t.patch Description: application/wine-extension-patch 0001-Made-Lintian-Check-use-Email-Valid-to-parse-emails-t.patch.sig Description: Binary data
[SCM] Debian package checker branch, master, updated. 2.4.3-51-gd34cf43
The following commit has been merged in the master branch: commit d34cf4399feafcbb51278c76f06b90a29c9f52ff Author: Niels Thykier ni...@thykier.net Date: Sat Dec 25 14:56:52 2010 +0100 Added some symlink tests. diff --git a/t/COVERAGE b/t/COVERAGE index 76df57b..d28f6ce 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -317,11 +317,7 @@ files svk-commit-file-in-package files svn-commit-file-in-package files symlink-contains-spurious-segments files symlink-ends-with-slash -files symlink-has-double-slash -files symlink-has-too-many-up-segments files symlink-is-self-recursive -files symlink-should-be-absolute -files symlink-should-be-relative files use-of-compat-symlink files windows-thumbnail-database-in-package files wrong-file-owner-uid-or-gid @@ -498,7 +494,6 @@ binary su-wrapper-without--c substvar-source-version-is-deprecated symlink-contains-spurious-segments - symlink-should-be-relative unquoted-string-in-menu-item unstripped-binary-or-object xs-vcs-header-in-debian-control @@ -590,10 +585,7 @@ filenames svk-commit-file-in-package svn-commit-file-in-package symlink-ends-with-slash - symlink-has-double-slash - symlink-has-too-many-up-segments symlink-is-self-recursive - symlink-should-be-absolute use-of-compat-symlink windows-thumbnail-database-in-package wrong-file-owner-uid-or-gid diff --git a/t/tests/files-symlinks/debian/data-file b/t/tests/files-symlinks/debian/data-file new file mode 100644 index 000..9a50fd7 --- /dev/null +++ b/t/tests/files-symlinks/debian/data-file @@ -0,0 +1 @@ +# Some data file. \ No newline at end of file diff --git a/t/tests/files-symlinks/debian/debian/install b/t/tests/files-symlinks/debian/debian/install new file mode 100644 index 000..3b7d28b --- /dev/null +++ b/t/tests/files-symlinks/debian/debian/install @@ -0,0 +1,4 @@ +data-file usr/share/lintian/data/ +pkg.conf etc/ +symlinks/data-file.old usr/share/lintian/data/ +symlinks/pkg*.conf usr/share/lintian/data/ diff --git a/t/tests/files-symlinks/debian/debian/rules b/t/tests/files-symlinks/debian/debian/rules new file mode 100644 index 000..9785a63 --- /dev/null +++ b/t/tests/files-symlinks/debian/debian/rules @@ -0,0 +1,16 @@ +#!/usr/bin/make -f + +%: + dh $@ + +override_dh_auto_build: + mkdir symlinks/ + ln -s ../../../../etc/pkg.conf symlinks/pkg-old.conf + ln -s ../..//..//..//../etc/pkg.conf symlinks/pkg.conf + ln -s /usr/share/lintian/data-file symlinks/data-file.old + +override_dh_auto_clean: + rm -fr symlinks/ + +override_dh_link: + # it will fix our symlinks and ruin the test, so skip it. diff --git a/t/tests/files-symlinks/debian/pkg.conf b/t/tests/files-symlinks/debian/pkg.conf new file mode 100644 index 000..b3138c3 --- /dev/null +++ b/t/tests/files-symlinks/debian/pkg.conf @@ -0,0 +1 @@ +# sample config file diff --git a/t/tests/files-symlinks/desc b/t/tests/files-symlinks/desc new file mode 100644 index 000..b7dcc46 --- /dev/null +++ b/t/tests/files-symlinks/desc @@ -0,0 +1,11 @@ +Testname: files-symlinks +Sequence: 6000 +Version: 1.0 +Description: Test tags about symlinks +Test-For: + symlink-has-double-slash + symlink-has-too-many-up-segments + symlink-should-be-absolute + symlink-should-be-relative + + diff --git a/t/tests/files-symlinks/tags b/t/tests/files-symlinks/tags new file mode 100644 index 000..59a8c60 --- /dev/null +++ b/t/tests/files-symlinks/tags @@ -0,0 +1,4 @@ +E: files-symlinks: symlink-has-too-many-up-segments usr/share/lintian/data/pkg.conf ../..//..//..//../etc/pkg.conf +E: files-symlinks: symlink-should-be-absolute usr/share/lintian/data/pkg-old.conf ../../../../etc/pkg.conf +W: files-symlinks: symlink-has-double-slash usr/share/lintian/data/pkg.conf ../..//..//..//../etc/pkg.conf +W: files-symlinks: symlink-should-be-relative usr/share/lintian/data/data-file.old /usr/share/lintian/data-file -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pwue1-000395...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-52-gffde003
The following commit has been merged in the master branch: commit ffde003bfdddff4b87cb63d55be1cc92666b2702 Author: Niels Thykier ni...@thykier.net Date: Sat Dec 25 15:07:19 2010 +0100 Added debian-watch-file-in-native-package tests to the new test suite. diff --git a/t/COVERAGE b/t/COVERAGE index d28f6ce..0e9284d 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -438,7 +438,6 @@ version-substvars not-binnmuable-any-depends-any version-substvars substvar-source-version-is-deprecated version-substvars version-substvar-for-external-package -watch-file debian-watch-file-in-native-package watch-file debian-watch-file-specifies-old-upstream-version Breakdown of remaining tags in legacy test suite by test case: @@ -594,7 +593,6 @@ filenames foo++ debian-changelog-file-uses-obsolete-national-encoding debian-control-file-uses-obsolete-national-encoding - debian-watch-file-in-native-package malformed-dm-upload-allowed uploader-address-is-on-localhost uploader-address-looks-weird diff --git a/t/tests/watch-file-native/debian/debian/watch b/t/tests/watch-file-native/debian/debian/watch new file mode 100644 index 000..fe12dbc --- /dev/null +++ b/t/tests/watch-file-native/debian/debian/watch @@ -0,0 +1,5 @@ +# watch file with upstream version mangling + +version=3 +http://somewhere.debian.org/foo/foo_bar(.+)\.tar\.gz 5 uupdate + diff --git a/t/tests/watch-file-native/desc b/t/tests/watch-file-native/desc new file mode 100644 index 000..8a82824 --- /dev/null +++ b/t/tests/watch-file-native/desc @@ -0,0 +1,6 @@ +Testname: watch-file-native +Sequence: 6000 +Version: 1.0 +Description: Native package with a watch file +Test-For: + debian-watch-file-in-native-package diff --git a/t/tests/watch-file-native/tags b/t/tests/watch-file-native/tags new file mode 100644 index 000..b3d58a7 --- /dev/null +++ b/t/tests/watch-file-native/tags @@ -0,0 +1 @@ +W: watch-file-native source: debian-watch-file-in-native-package -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pwuo0-jl...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-53-g788ac0b
The following commit has been merged in the master branch:
commit 788ac0bd5b92667c8761edc1b56b4c56549e2fc9
Author: Niels Thykier ni...@thykier.net
Date: Sat Dec 25 15:25:41 2010 +0100
Added substvars tests to the new test suite.
diff --git a/t/COVERAGE b/t/COVERAGE
index 0e9284d..360551b 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -432,12 +432,6 @@ shared-libs unknown-meta-field-in-symbols-file
shared-libs unused-shlib-entry-in-control-file
shared-libs unused-shlib-entry-in-symbols-control-file
-version-substvars not-binnmuable-all-depends-any
-version-substvars not-binnmuable-any-depends-all
-version-substvars not-binnmuable-any-depends-any
-version-substvars substvar-source-version-is-deprecated
-version-substvars version-substvar-for-external-package
-
watch-file debian-watch-file-specifies-old-upstream-version
Breakdown of remaining tags in legacy test suite by test case:
@@ -480,8 +474,6 @@ binary
no-md5sums-control-file
non-wm-in-windowmanager-menu-section
non-wm-module-in-wm-modules-menu-section
- not-binnmuable-all-depends-any
- not-binnmuable-any-depends-all
old-fsf-address-in-copyright-file
package-contains-hardlink
package-contains-upstream-install-documentation
@@ -491,7 +483,6 @@ binary
su-to-root-with-usr-sbin
su-wrapper-not-su-to-root
su-wrapper-without--c
- substvar-source-version-is-deprecated
symlink-contains-spurious-segments
unquoted-string-in-menu-item
unstripped-binary-or-object
@@ -541,7 +532,6 @@ debug
syntax-error-in-symbols-file
unknown-meta-field-in-symbols-file
unused-shlib-entry-in-symbols-control-file
- version-substvar-for-external-package
etcfiles
file-in-etc-not-marked-as-conffile
@@ -613,7 +603,6 @@ libbaz
missing-dependency-on-perlapi
missing-depends-line
no-symbols-control-file
- not-binnmuable-any-depends-any
package-name-doesnt-match-sonames
postinst-must-call-ldconfig
postinst-should-not-set-usr-doc-link
diff --git a/t/tests/copyright-file-doc-symlink/debian/debian/control.in
b/t/tests/version-substvars-general/debian/debian/control.in
similarity index 56%
copy from t/tests/copyright-file-doc-symlink/debian/debian/control.in
copy to t/tests/version-substvars-general/debian/debian/control.in
index b933d68..2dfa8b2 100644
--- a/t/tests/copyright-file-doc-symlink/debian/debian/control.in
+++ b/t/tests/version-substvars-general/debian/debian/control.in
@@ -3,36 +3,40 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (= 7)
+Build-Depends: debhelper (= 7.0.50~)
-Package: {$srcpkg}
-Architecture: {$architecture}
-Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Package: program-bin
+Architecture: any
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\},
+ program-data (= $\{binary:Version\})
Description: {$description}
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
-Package: {$srcpkg}-helper
-Architecture: {$architecture}
-Depends: {$srcpkg} (= {$version}), $\{shlibs:Depends\}, $\{misc:Depends\}
-Description: {$description} (symlink)
- Helper package with a legitimate /usr/share/doc symlink.
- .
+
+Package: program-data
+Architecture: all
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\},
+ program-bin (= $\{binary:Version\}),
+ foreign-pkg (= $\{Source-Version\})
+Description: {$description} - data
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
-
-Package: {$srcpkg}-weak
-Architecture: {$architecture}
-Depends: {$srcpkg}, $\{shlibs:Depends\}, $\{misc:Depends\}
-Description: {$description} (weak)
- Helper package with a /usr/share/doc symlink but an insufficiently
- strong dependency. Lintian intentionally doesn't diagnose this.
.
+ Data package.
+
+Package: program-utils
+Architecture: any
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\},
+ program-bin (= $\{source:Version\})
+Description: {$description} - extra utils
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+ .
+ Extra utils.
diff --git a/t/tests/version-substvars-general/desc
b/t/tests/version-substvars-general/desc
new file mode 100644
index 000..7629b01
--- /dev/null
+++ b/t/tests/version-substvars-general/desc
@@ -0,0 +1,10 @@
+Testname: version-substvars-general
+Sequence: 6000
+Version: 1.0
+Description: Test of substvars
+Test-For:
+ not-binnmuable-all-depends-any
+ not-binnmuable-any-depends-all
+ not-binnmuable-any-depends-any
+ substvar-source-version
[SCM] Debian package checker branch, master, updated. 2.4.3-54-gfd93158
The following commit has been merged in the master branch: commit fd9315809b27770e6d3ee10ae8e1576c939048ee Author: Niels Thykier ni...@thykier.net Date: Sun Dec 26 22:46:34 2010 +0100 More symlink testing. diff --git a/t/COVERAGE b/t/COVERAGE index 360551b..b665a42 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -1,4 +1,4 @@ -Last generated 2010-12-25 +Last generated 2010-12-26 The following tags are not tested by the test suite: @@ -315,9 +315,6 @@ files setuid-binary files subdir-in-usr-bin files svk-commit-file-in-package files svn-commit-file-in-package -files symlink-contains-spurious-segments -files symlink-ends-with-slash -files symlink-is-self-recursive files use-of-compat-symlink files windows-thumbnail-database-in-package files wrong-file-owner-uid-or-gid @@ -483,7 +480,6 @@ binary su-to-root-with-usr-sbin su-wrapper-not-su-to-root su-wrapper-without--c - symlink-contains-spurious-segments unquoted-string-in-menu-item unstripped-binary-or-object xs-vcs-header-in-debian-control @@ -573,8 +569,6 @@ filenames subdir-in-usr-bin svk-commit-file-in-package svn-commit-file-in-package - symlink-ends-with-slash - symlink-is-self-recursive use-of-compat-symlink windows-thumbnail-database-in-package wrong-file-owner-uid-or-gid diff --git a/t/tests/files-symlinks/debian/debian/install b/t/tests/files-symlinks/debian/debian/install index 3b7d28b..b0fb63f 100644 --- a/t/tests/files-symlinks/debian/debian/install +++ b/t/tests/files-symlinks/debian/debian/install @@ -1,4 +1,7 @@ data-file usr/share/lintian/data/ -pkg.conf etc/ +pkg.conf etc/lintian/ symlinks/data-file.old usr/share/lintian/data/ +symlinks/etc-lintian* usr/share/ symlinks/pkg*.conf usr/share/lintian/data/ +symlinks/self-resursive usr/share/lintian/data/ +symlinks/spurious usr/share/lintian/data/ diff --git a/t/tests/files-symlinks/debian/debian/rules b/t/tests/files-symlinks/debian/debian/rules index 9785a63..96057b9 100644 --- a/t/tests/files-symlinks/debian/debian/rules +++ b/t/tests/files-symlinks/debian/debian/rules @@ -5,9 +5,12 @@ override_dh_auto_build: mkdir symlinks/ - ln -s ../../../../etc/pkg.conf symlinks/pkg-old.conf - ln -s ../..//..//..//../etc/pkg.conf symlinks/pkg.conf - ln -s /usr/share/lintian/data-file symlinks/data-file.old + ln -s ../../../../etc/lintian/pkg.conf symlinks/pkg-old.conf + ln -s ../..//..//..//../etc/lintian/pkg.conf symlinks/pkg.conf + ln -s /usr/share/lintian/data/data-file symlinks/data-file.old + ln -s /etc/lintian/ symlinks/etc-lintian + ln -s / symlinks/self-resursive + ln -s ../../lintian-old/../lintian/data/data-file symlinks/spurious override_dh_auto_clean: rm -fr symlinks/ diff --git a/t/tests/files-symlinks/desc b/t/tests/files-symlinks/desc index b7dcc46..3a07ba3 100644 --- a/t/tests/files-symlinks/desc +++ b/t/tests/files-symlinks/desc @@ -3,9 +3,11 @@ Sequence: 6000 Version: 1.0 Description: Test tags about symlinks Test-For: + symlink-contains-spurious-segments + symlink-ends-with-slash symlink-has-double-slash symlink-has-too-many-up-segments + symlink-is-self-recursive symlink-should-be-absolute symlink-should-be-relative - diff --git a/t/tests/files-symlinks/tags b/t/tests/files-symlinks/tags index 59a8c60..4bfaed0 100644 --- a/t/tests/files-symlinks/tags +++ b/t/tests/files-symlinks/tags @@ -1,4 +1,7 @@ -E: files-symlinks: symlink-has-too-many-up-segments usr/share/lintian/data/pkg.conf ../..//..//..//../etc/pkg.conf -E: files-symlinks: symlink-should-be-absolute usr/share/lintian/data/pkg-old.conf ../../../../etc/pkg.conf -W: files-symlinks: symlink-has-double-slash usr/share/lintian/data/pkg.conf ../..//..//..//../etc/pkg.conf -W: files-symlinks: symlink-should-be-relative usr/share/lintian/data/data-file.old /usr/share/lintian/data-file +E: files-symlinks: symlink-contains-spurious-segments usr/share/lintian/data/spurious ../../lintian-old/../lintian/data/data-file +E: files-symlinks: symlink-has-too-many-up-segments usr/share/lintian/data/pkg.conf ../..//..//..//../etc/lintian/pkg.conf +E: files-symlinks: symlink-should-be-absolute usr/share/lintian/data/pkg-old.conf ../../../../etc/lintian/pkg.conf +W: files-symlinks: symlink-ends-with-slash usr/share/etc-lintian /etc/lintian/ +W: files-symlinks: symlink-has-double-slash usr/share/lintian/data/pkg.conf ../..//..//..//../etc/lintian/pkg.conf +W: files-symlinks: symlink-is-self-recursive usr/share/lintian/data/self-resursive / +W: files-symlinks: symlink-should-be-relative usr/share/lintian/data/data-file.old /usr/share/lintian/data/data-file -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pwys5-0006ij...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-55-g20663e5
The following commit has been merged in the master branch: commit 20663e5711fda9da13f0c0581c17ead02ea6cbe3 Author: Niels Thykier ni...@thykier.net Date: Mon Dec 27 11:20:30 2010 +0100 Added unforgivable easy test of native-package-with-dash-version. diff --git a/t/tests/cruft-native-dash-version/desc b/t/tests/cruft-native-dash-version/desc new file mode 100644 index 000..d9cfdae --- /dev/null +++ b/t/tests/cruft-native-dash-version/desc @@ -0,0 +1,6 @@ +Testname: cruft-native-dash-version +Sequence: 6000 +Version: 1.0-1 +Type: native +Description: Test for native packages with dash version +Test-For: native-package-with-dash-version diff --git a/t/tests/cruft-native-dash-version/tags b/t/tests/cruft-native-dash-version/tags new file mode 100644 index 000..b2eaaca --- /dev/null +++ b/t/tests/cruft-native-dash-version/tags @@ -0,0 +1 @@ +W: cruft-native-dash-version source: native-package-with-dash-version -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxadb-oj...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-56-g6de8f8a
The following commit has been merged in the master branch:
commit 6de8f8a3b3906ecc9ac8b48cee1eb0166c2755c9
Author: Niels Thykier ni...@thykier.net
Date: Mon Dec 27 11:27:08 2010 +0100
Added test for debian-rules-is-symlink and remembered to commit
the updated COVERAGE file this time.
diff --git a/t/COVERAGE b/t/COVERAGE
index b665a42..b67d658 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,4 +1,4 @@
-Last generated 2010-12-26
+Last generated 2010-12-27
The following tags are not tested by the test suite:
@@ -163,8 +163,6 @@ po-debconf missing-potfiles-in
po-debconf missing-templates-pot
po-debconf not-using-po-debconf
-rules debian-rules-is-symlink
-
scripts csh-considered-harmful
scripts killall-is-dangerous
scripts maintainer-script-needs-depends-on-adduser
@@ -221,8 +219,6 @@ control-files control-file-is-empty
copyright-file old-fsf-address-in-copyright-file
copyright-file usr-share-doc-symlink-without-dependency
-cruft native-package-with-dash-version
-
debconf config-does-not-load-confmodule
debconf debconf-config-not-executable
debconf loads-obsolete-confmodule
@@ -467,7 +463,6 @@ binary
menu-item-uses-apps-section
menu-item-uses-windowmanagers-section
menu-method-should-include-menu-h
- native-package-with-dash-version
no-md5sums-control-file
non-wm-in-windowmanager-menu-section
non-wm-module-in-wm-modules-menu-section
diff --git a/t/source/changelog-file-symlink/rules
b/t/tests/rules-symlink/debian/debian/rules.real
old mode 100755
new mode 100644
similarity index 96%
copy from t/source/changelog-file-symlink/rules
copy to t/tests/rules-symlink/debian/debian/rules.real
index cbe925d..2d33f6a
--- a/t/source/changelog-file-symlink/rules
+++ b/t/tests/rules-symlink/debian/debian/rules.real
@@ -1,3 +1,4 @@
#!/usr/bin/make -f
+
%:
dh $@
diff --git a/t/tests/rules-symlink/desc b/t/tests/rules-symlink/desc
new file mode 100644
index 000..7664dd9
--- /dev/null
+++ b/t/tests/rules-symlink/desc
@@ -0,0 +1,6 @@
+Testname: rules-symlink
+Sequence: 6000
+Version: 1.0
+Description: Test for debian/rules being a symlink
+Test-For:
+ debian-rules-is-symlink
diff --git a/t/tests/rules-symlink/pre_build b/t/tests/rules-symlink/pre_build
new file mode 100755
index 000..c887d2c
--- /dev/null
+++ b/t/tests/rules-symlink/pre_build
@@ -0,0 +1,6 @@
+#!/bin/sh
+# Create d/rules as a symlink.
+
+ROOT_DIR=$1
+
+ln -fs rules.real ${ROOT_DIR}/debian/rules
diff --git a/t/tests/rules-symlink/tags b/t/tests/rules-symlink/tags
new file mode 100644
index 000..0251b44
--- /dev/null
+++ b/t/tests/rules-symlink/tags
@@ -0,0 +1 @@
+W: rules-symlink source: debian-rules-is-symlink
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxaku-0002nt...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-57-g5cc51ee
The following commit has been merged in the master branch: commit 5cc51ee81f0c9059004a1415bfcfba787b46991a Author: Niels Thykier ni...@thykier.net Date: Mon Dec 27 11:46:42 2010 +0100 Added tests for debian-revision-not-well-formed and debian-revision-should-not-be-zero. diff --git a/t/COVERAGE b/t/COVERAGE index b67d658..db9a3c0 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -251,8 +251,6 @@ etcfiles file-in-etc-not-marked-as-conffile fields build-depends-indep-without-arch-indep fields dbg-package-missing-depends -fields debian-revision-not-well-formed -fields debian-revision-should-not-be-zero fields debug-package-should-be-priority-extra fields depends-exclusively-on-makedev fields depends-on-old-emacs @@ -533,8 +531,6 @@ etcfiles run-parts-cron-filename-contains-full-stop fields - debian-revision-not-well-formed - debian-revision-should-not-be-zero depends-on-python-minimal unknown-section diff --git a/t/tests/fields-debian-revision/debian/debian/rules b/t/tests/fields-debian-revision/debian/debian/rules new file mode 100644 index 000..ce09a53 --- /dev/null +++ b/t/tests/fields-debian-revision/debian/debian/rules @@ -0,0 +1,7 @@ +#!/usr/bin/make -f + +%: + dh $@ + +override_dh_gencontrol: + dh_gencontrol -- -v1.0-0 diff --git a/t/tests/fields-debian-revision/desc b/t/tests/fields-debian-revision/desc new file mode 100644 index 000..09ce333 --- /dev/null +++ b/t/tests/fields-debian-revision/desc @@ -0,0 +1,8 @@ +Testname: fields-debian-revision +Sequence: 6000 +Version: 1.5-.3 +Description: Test for weird Debian revisions +Type: non-native +Test-For: + debian-revision-not-well-formed + debian-revision-should-not-be-zero diff --git a/t/tests/fields-debian-revision/tags b/t/tests/fields-debian-revision/tags new file mode 100644 index 000..d72d397 --- /dev/null +++ b/t/tests/fields-debian-revision/tags @@ -0,0 +1,2 @@ +E: fields-debian-revision: debian-revision-should-not-be-zero 1.0-0 +W: fields-debian-revision source: debian-revision-not-well-formed 1.5-.3 diff --git a/t/tests/fields-debian-revision/upstream/README b/t/tests/fields-debian-revision/upstream/README new file mode 100644 index 000..336f590 --- /dev/null +++ b/t/tests/fields-debian-revision/upstream/README @@ -0,0 +1 @@ +Hallo World -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxade-000531...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-58-g57d3a7d
The following commit has been merged in the master branch:
commit 57d3a7daf985950dbf31d8d91d9065c4094a1291
Author: Niels Thykier ni...@thykier.net
Date: Mon Dec 27 11:59:17 2010 +0100
Added test for uploader related issues.
diff --git a/t/COVERAGE b/t/COVERAGE
index db9a3c0..a664d90 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -264,11 +264,6 @@ fields package-depends-on-multiple-tkx-versions
fields redundant-bugs-field
fields redundant-origin-field
fields unknown-section
-fields uploader-address-is-on-localhost
-fields uploader-address-looks-weird
-fields uploader-address-malformed
-fields uploader-address-missing
-fields uploader-not-full-name
fields versioned-dependency-satisfied-by-perl
fields wrong-debian-qa-address-set-as-maintainer
fields wrong-debian-qa-group-name
@@ -569,11 +564,6 @@ foo++
debian-changelog-file-uses-obsolete-national-encoding
debian-control-file-uses-obsolete-national-encoding
malformed-dm-upload-allowed
- uploader-address-is-on-localhost
- uploader-address-looks-weird
- uploader-address-malformed
- uploader-address-missing
- uploader-not-full-name
wrong-debian-qa-address-set-as-maintainer
libbaz
diff --git a/t/tests/debhelper-override-depends/debian/debian/control.in
b/t/tests/fields-uploaders/debian/debian/control.in
similarity index 67%
copy from t/tests/debhelper-override-depends/debian/debian/control.in
copy to t/tests/fields-uploaders/debian/debian/control.in
index 6a076f1..81e6733 100644
--- a/t/tests/debhelper-override-depends/debian/debian/control.in
+++ b/t/tests/fields-uploaders/debian/debian/control.in
@@ -1,7 +1,12 @@
Source: {$srcpkg}
Priority: extra
-Section: {$section}
+Section: devel
Maintainer: {$author}
+Uploaders: Mrs. Localhost u...@localhost,
+ Mr. Weirdno-sp...@somewhere.com,
+ One-name has-only-1-n...@elsewhere.com,
+ Malformed Email @ddr...@myspace.com,
+ I have no email
Standards-Version: {$standards_version}
Build-Depends: debhelper (= 7)
@@ -13,3 +18,4 @@ Description: {$description}
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+
diff --git a/t/tests/fields-depends-general/debian/some-file
b/t/tests/fields-uploaders/debian/some-file
similarity index 100%
copy from t/tests/fields-depends-general/debian/some-file
copy to t/tests/fields-uploaders/debian/some-file
diff --git a/t/tests/fields-uploaders/desc b/t/tests/fields-uploaders/desc
new file mode 100644
index 000..7cbcbb8
--- /dev/null
+++ b/t/tests/fields-uploaders/desc
@@ -0,0 +1,10 @@
+Testname: fields-uploaders
+Sequence: 6000
+Version: 1.0
+Description: General tests of the uploaders field
+Test-For:
+ uploader-address-is-on-localhost
+ uploader-address-looks-weird
+ uploader-address-malformed
+ uploader-address-missing
+ uploader-not-full-name
diff --git a/t/tests/fields-uploaders/tags b/t/tests/fields-uploaders/tags
new file mode 100644
index 000..02f56ca
--- /dev/null
+++ b/t/tests/fields-uploaders/tags
@@ -0,0 +1,6 @@
+E: fields-uploaders source: uploader-address-is-on-localhost Mrs. Localhost
u...@localhost
+E: fields-uploaders source: uploader-address-malformed Malformed Email
@ddr...@myspace.com
+E: fields-uploaders source: uploader-address-malformed Mrs. Localhost
u...@localhost
+E: fields-uploaders source: uploader-address-missing I have no email
+W: fields-uploaders source: uploader-address-looks-weird Mr.
Weirdno-sp...@somewhere.com
+W: fields-uploaders source: uploader-not-full-name One-name
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxaps-0006x7...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-59-gd473507
The following commit has been merged in the master branch:
commit d4735078bc0c87b7d48aa31f3c96268bd84ba33d
Author: Niels Thykier ni...@thykier.net
Date: Mon Dec 27 12:17:37 2010 +0100
Added similar tests for maintainers. Removed redundant file from
uploaders test.
diff --git a/t/COVERAGE b/t/COVERAGE
index a664d90..a8284e6 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -58,9 +58,6 @@ fields bad-version-in-relation
fields bad-version-number
fields depends-on-libdb1-compat
fields doc-package-depends-on-main-package
-fields maintainer-address-is-on-localhost
-fields maintainer-address-looks-weird
-fields maintainer-address-malformed
fields malformed-python-version
fields multiline-field
fields no-architecture-field
diff --git a/t/tests/debhelper-override-depends/debian/debian/control.in
b/t/tests/fields-maintainer/debian/debian/control.in
similarity index 85%
copy from t/tests/debhelper-override-depends/debian/debian/control.in
copy to t/tests/fields-maintainer/debian/debian/control.in
index 6a076f1..4ef1a57 100644
--- a/t/tests/debhelper-override-depends/debian/debian/control.in
+++ b/t/tests/fields-maintainer/debian/debian/control.in
@@ -1,7 +1,8 @@
Source: {$srcpkg}
Priority: extra
-Section: {$section}
-Maintainer: {$author}
+Section: devel
+Maintainer: Mrs. Localhostu...@localhost
+Uploaders: {$author}
Standards-Version: {$standards_version}
Build-Depends: debhelper (= 7)
@@ -13,3 +14,4 @@ Description: {$description}
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+
diff --git a/t/tests/fields-maintainer/desc b/t/tests/fields-maintainer/desc
new file mode 100644
index 000..cd01f51
--- /dev/null
+++ b/t/tests/fields-maintainer/desc
@@ -0,0 +1,8 @@
+Testname: fields-maintainer
+Sequence: 6000
+Version: 1.0
+Description: General tests of the maintainer field
+Test-For:
+ maintainer-address-is-on-localhost
+ maintainer-address-looks-weird
+ maintainer-address-malformed
diff --git a/t/tests/fields-maintainer/tags b/t/tests/fields-maintainer/tags
new file mode 100644
index 000..24328a4
--- /dev/null
+++ b/t/tests/fields-maintainer/tags
@@ -0,0 +1,6 @@
+E: fields-maintainer source: maintainer-address-is-on-localhost Mrs.
Localhostu...@localhost
+E: fields-maintainer source: maintainer-address-malformed Mrs.
Localhostu...@localhost
+E: fields-maintainer: maintainer-address-is-on-localhost Mrs.
Localhostu...@localhost
+E: fields-maintainer: maintainer-address-malformed Mrs.
Localhostu...@localhost
+W: fields-maintainer source: maintainer-address-looks-weird Mrs.
Localhostu...@localhost
+W: fields-maintainer: maintainer-address-looks-weird Mrs.
Localhostu...@localhost
diff --git a/t/tests/fields-uploaders/debian/some-file
b/t/tests/fields-uploaders/debian/some-file
deleted file mode 100644
index 7bf08f7..000
--- a/t/tests/fields-uploaders/debian/some-file
+++ /dev/null
@@ -1,2 +0,0 @@
-This file is installed into /usr/share/lintian just to ensure that this
-package doesn't look like a metapackage for the dependency checks.
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxbas-0005vw...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-60-g7efa273
The following commit has been merged in the master branch: commit 7efa2730bba3da72a433606dca7d7581928d Author: Niels Thykier ni...@thykier.net Date: Mon Dec 27 14:19:43 2010 +0100 Added test for quilt-series-but-no-build-dep. diff --git a/t/COVERAGE b/t/COVERAGE index a8284e6..201aa70 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -154,8 +154,6 @@ menus preinst-calls-installdocs menus preinst-calls-updatemenus menus prerm-calls-updatemenus -patch-systems quilt-series-but-no-build-dep - po-debconf missing-potfiles-in po-debconf missing-templates-pot po-debconf not-using-po-debconf diff --git a/t/tests/patch-systems-quilt-no-depends/debian/debian/patches/series b/t/tests/patch-systems-quilt-no-depends/debian/debian/patches/series new file mode 100644 index 000..a920a3a --- /dev/null +++ b/t/tests/patch-systems-quilt-no-depends/debian/debian/patches/series @@ -0,0 +1 @@ +some-change.patch diff --git a/t/tests/patch-systems-quilt-no-depends/debian/debian/patches/some-change.patch b/t/tests/patch-systems-quilt-no-depends/debian/debian/patches/some-change.patch new file mode 100644 index 000..c34fd8f --- /dev/null +++ b/t/tests/patch-systems-quilt-no-depends/debian/debian/patches/some-change.patch @@ -0,0 +1,6 @@ +Description: Does something very useful - it hides empty-series tag +--- a/README 2010-12-27 14:09:55.025074505 +0100 b/README 2010-12-27 14:10:09.656080199 +0100 +@@ -1 +1,2 @@ + Hello World ++Goodbye world diff --git a/t/templates/pedantic/debian/source/format b/t/tests/patch-systems-quilt-no-depends/debian/debian/source/format similarity index 100% copy from t/templates/pedantic/debian/source/format copy to t/tests/patch-systems-quilt-no-depends/debian/debian/source/format diff --git a/t/tests/patch-systems-quilt-no-depends/desc b/t/tests/patch-systems-quilt-no-depends/desc new file mode 100644 index 000..83716a3 --- /dev/null +++ b/t/tests/patch-systems-quilt-no-depends/desc @@ -0,0 +1,8 @@ +Testname: patch-systems-quilt-no-depends +Sequence: 6000 +Version: 1.0 +Description: Test for quilt series but no B-D on quilt +Test-For: + quilt-series-but-no-build-dep + + diff --git a/t/tests/patch-systems-quilt-no-depends/tags b/t/tests/patch-systems-quilt-no-depends/tags new file mode 100644 index 000..de15bf4 --- /dev/null +++ b/t/tests/patch-systems-quilt-no-depends/tags @@ -0,0 +1 @@ +W: patch-systems-quilt-no-depends source: quilt-series-but-no-build-dep diff --git a/t/tests/patch-systems-quilt-no-depends/upstream/README b/t/tests/patch-systems-quilt-no-depends/upstream/README new file mode 100644 index 000..557db03 --- /dev/null +++ b/t/tests/patch-systems-quilt-no-depends/upstream/README @@ -0,0 +1 @@ +Hello World -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxd1h-0007tg...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-61-gfff5801
The following commit has been merged in the master branch: commit fff5801f2991430df5b93dc4a446e8f00e28a972 Author: Niels Thykier ni...@thykier.net Date: Mon Dec 27 14:25:18 2010 +0100 Renamed fields-debian-revision to fields-version-bad and had it also check upstream-version-not-numeric. diff --git a/t/COVERAGE b/t/COVERAGE index 201aa70..7e3c951 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -77,7 +77,6 @@ fields unknown-architecture fields unknown-field-in-control fields unknown-field-in-dsc fields unknown-priority -fields upstream-version-not-numeric fields wrong-section-for-udeb files FSSTND-dir-in-var diff --git a/t/tests/fields-debian-revision/desc b/t/tests/fields-debian-revision/desc deleted file mode 100644 index 09ce333..000 --- a/t/tests/fields-debian-revision/desc +++ /dev/null @@ -1,8 +0,0 @@ -Testname: fields-debian-revision -Sequence: 6000 -Version: 1.5-.3 -Description: Test for weird Debian revisions -Type: non-native -Test-For: - debian-revision-not-well-formed - debian-revision-should-not-be-zero diff --git a/t/tests/fields-debian-revision/tags b/t/tests/fields-debian-revision/tags deleted file mode 100644 index d72d397..000 --- a/t/tests/fields-debian-revision/tags +++ /dev/null @@ -1,2 +0,0 @@ -E: fields-debian-revision: debian-revision-should-not-be-zero 1.0-0 -W: fields-debian-revision source: debian-revision-not-well-formed 1.5-.3 diff --git a/t/tests/fields-debian-revision/debian/debian/rules b/t/tests/fields-version-bad/debian/debian/rules similarity index 100% rename from t/tests/fields-debian-revision/debian/debian/rules rename to t/tests/fields-version-bad/debian/debian/rules diff --git a/t/tests/fields-version-bad/desc b/t/tests/fields-version-bad/desc new file mode 100644 index 000..6d75cfa --- /dev/null +++ b/t/tests/fields-version-bad/desc @@ -0,0 +1,9 @@ +Testname: fields-version-bad +Sequence: 6000 +Version: unknown-.3 +Description: Test for weird versions +Type: non-native +Test-For: + debian-revision-not-well-formed + debian-revision-should-not-be-zero + upstream-version-not-numeric diff --git a/t/tests/fields-version-bad/tags b/t/tests/fields-version-bad/tags new file mode 100644 index 000..42a2f9b --- /dev/null +++ b/t/tests/fields-version-bad/tags @@ -0,0 +1,3 @@ +E: fields-version-bad source: upstream-version-not-numeric unknown-.3 +E: fields-version-bad: debian-revision-should-not-be-zero 1.0-0 +W: fields-version-bad source: debian-revision-not-well-formed unknown-.3 diff --git a/t/tests/fields-debian-revision/upstream/README b/t/tests/fields-version-bad/upstream/README similarity index 100% rename from t/tests/fields-debian-revision/upstream/README rename to t/tests/fields-version-bad/upstream/README -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxd7d-bj...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-62-g01f933c
The following commit has been merged in the master branch: commit 01f933c733c77b8d9f5e6bc8388a1dba56584869 Author: Niels Thykier ni...@thykier.net Date: Mon Dec 27 14:28:20 2010 +0100 Removed unused debhelper exclude for a back-up file that no longer exists. diff --git a/debian/rules b/debian/rules index a4a9bc8..08d11c0 100755 --- a/debian/rules +++ b/debian/rules @@ -66,13 +66,13 @@ clean: $(neededfiles) rm -rf doc/lintian.html/ doc/lintian.txt rm -rf debian/tests find -name *.py? -print0 | xargs -0r rm - dh_clean -Xtestset/diffs/binary.c~ + dh_clean binary-indep: $(neededfiles) build @echo binary-indep dh_testdir dh_testroot - dh_prep -Xtestset/diffs/binary.c~ + dh_prep dh_installdirs dh_install -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxd9k-jo...@alioth.debian.org
Lintian man pages in pod
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hey I understood from [1] that there has been an interest in rewriting the lintian man pages in POD, so I spent a couple of hours doing just that. I figured that the CHECKS and COLLECTION sections of the lintian manpage could mostly be auto-generated from checks/*.desc and collection/*.desc (respectively), which would save us time keeping them in sync. generate-lintian-pod was written for just that. Dump generate-lintian-pod in private/ and run it like: $ private/generate-lintian-pod man/lintian.pod.in man/lintian.pod Of course this will require that all checks and collection desc files actually have an info field, which they do not at the current time. Alternatively if it is not possible to completely reuse info in all cases, I made it possible to use a Manpage field that will be used instead. Do you think this would work, or would it be better just to keep this information static in the pod file and manually update it? ~Niels [1] http://wiki.debian.org/Teams/Lintian -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNGOTTAAoJEAVLu599gGRC6OUP/0NtnUFEbMsupYu9jcwV93lS UPtzfwX+hw8hHs8yCVwIHbihJhKkWpVsWqbZKRUaTeQvMUMySqdUtIICPK6pKe/w CUmEVN5m10vv09owtssYMRptmFPGYLJNZloTxdmjVdXj5ik0o++nt6rQ6wq+DEr3 DLunLaOzPuW2m8GrpCyJ2SSk1o+uoZb1ltPlggWR5NMUADbPrgEZTzKPawGxgNrD jFRNJwPpLLVhGG1a5wtKc/XK7svlhKHw8pPKsrudP2iWQCcmjDHtACpzwj0t3a94 4naWBS/jekZWRTNee9xq+xjsOoKyx4Hpm8TUWajnY37HjmRtOO1/bR0x9SJZTb/c xgAiO4HYMia0OqUugF1DE32F0ndm6gS5ip6I0fLvVDt1o0Ae+qs/zExRr+A9M9cz DQy8WP8e2scbZKLL+79n70JY2aPi6gbv87GfnF3aHz5xciF2bz046b7Tr96N8ttQ qCOcfPowT6/j4n1KmTOWbPEP1uANVnx/U+LADVUvgIQG1aVve9z87XXmbCDyNcDt ifSETCtuOVVLTLFw63OZt/uCs1vWMOp7//8Rx46VUGUI+U/Uxuh/guS/I0ordzDl DHL69FYO2NF88sQuik+d9mV+lewqBaEVA22NTmNka1NqYd6b4GZgLUoED6hAIyvw zfR1f2Mk+U9VhaIfqBWz =FqVk -END PGP SIGNATURE- # Copyright 2010 Niels Thyker # - based on the work Richard Braakman and Christian #Schwarz (copyrighted 1998). # # This manual page is free software. It is distributed under the # terms of the GNU General Public License as published by the Free # Software Foundation; either version 2 of the License, or (at your # option) any later version. # # This manual page is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this manual page; if not, write to the Free Software # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 # USA # =head1 NAME lintian-info - give detailed information about Lintian's error tags =head1 SYNOPSIS Blintian-info [Ilog-file...] Blintian-info B--tags Itag ... =head1 DESCRIPTION The Blintian-info command parses the output of the Blintian command and gives verbose information about the listed Lintian error tags, parses a Lintian override file and gives verbose information about the tags included, or (if given the B-t or B--tags option) explains a given tag or tags. If no log-file is specified on the command line, this command expects its input on stdin. Thus, the output of Blintian can either be piped through Blintian-info or a log file produced by Blintian can be processed with this command. (Note, though, that the Blintian command has a command line option B-i to display the same results as Blintian-info, so you will not normally need to pipe the output of Blintian into this command.) =head1 OPTIONS =over 4 =item B-a, B--annotate Read from standard input or any files specified on the command line and search the input for lines formatted like Lintian override entries. For each one that was found, display verbose information about that tag. =item B-h, B--help Display usage information and exit. =item B-t, B--tags Rather than treating them as log file names, treat any command-line options as tag names and display the descriptions of each tag. =back =head1 EXIT STATUS If B-t or B--tags was given and one or more of the tags specified were unknown, this command returns the exit code 1. Otherwise, it always returns with exit code 0. =head1 SEE ALSO Llintian(1) =head1 AUTHORS Niels Thykier ni...@thykier.net Richard Braakman d...@xs4all.nl Christian Schwarz schw...@monet.m.isar.de =cut # Copyright 2010 Niels Thyker # - based on the work Richard Braakman and Christian #Schwarz (copyrighted 1998). # # This manual page is free software. It is distributed under the # terms of the GNU General Public License as published by the Free # Software Foundation; either version 2 of the License, or (at your # option) any later version. # # This manual page is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY
Re: Lintian man pages in pod
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-27 20:11, Niels Thykier wrote: Hey [...] $ private/generate-lintian-pod man/lintian.pod.in man/lintian.pod [...] Erh, right. That would be $ perl -Ilib/ private/generate-lintian-pod man/lintian.pod (and yeah, I noticed the typo in the fail() msg .) ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNGRJCAAoJEAVLu599gGRCncEP/1pSQUDfnbWjRhWL4tTsCAuW pFKgKycOwBbvTtZWfhsKsM+dRBc0iu4XtYxt+TepcztaOlo/uBoZbNN8N6e3vTzp z/CtbTCaNbeXBeNzb+rOP+PmqZdsaLoK3I0KZDDKuJ2gyNAIKrX9xDQWtQDdN92n 5ueXmjbQ381v3hcV61Mic6ffaY8kfF1DofkKFhtg6IjR2j1kxbVqJHklbAUizBal WY1eU7XXk1OyArnoxIjqyCq84lBKmX6Mg4Ndy9R8UqCaYDRnTqGD8nWHRk3Kd+er EC6MXF/I3i0DpMiCcMTZRlmpBKELVZCVg82Pb9DL+PnYUHhbWeBJPfOtGxwEDA+u 9S0AOsKQYqvPYNvvbtG3DfMBFPfn4A19E7ukoTX4UK5WCgTXxK3SUzpn9NOU8eSK cpOY5o9552xtN95Ed5y4vKe/FnnX9j+HdTK1ZtzgDv/hvn6+/D7GdpcxnYDj56/z 78vrUWM8nx0dm+KdBDyyrwNljTFoev3up5FkkD/i4NtxYJt8pZwz/9r4+nWWqhqx 6eJTViornG3m0sjrVSsDKDeT4FR1RyA5MphWbFw1Xb+rcWwnCF2DsAmwI4jLIRzK gTys66oT+7iF8gf7SYntWkmuzg5nj6Qpy3lZK4ea1+mmoefwI2qB96ZTyMeWhZ3/ vLMbQHNwuN+dTgGoggp/ =lFJL -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d191243.4090...@thykier.net
[SCM] Debian package checker branch, master, updated. 2.4.3-63-gd2e0a1d
The following commit has been merged in the master branch:
commit d2e0a1d0db884a0418ba3c970d962f7bb8adf26a
Author: Niels Thykier ni...@thykier.net
Date: Tue Dec 28 10:43:21 2010 +0100
i386 test for shlib-with-non-pic-code.
diff --git a/t/COVERAGE b/t/COVERAGE
index 7e3c951..15a3b0a 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,4 +1,4 @@
-Last generated 2010-12-27
+Last generated 2010-12-28
The following tags are not tested by the test suite:
@@ -400,7 +400,6 @@ shared-libs sharedobject-in-library-directory-missing-soname
shared-libs shlib-missing-in-control-file
shared-libs shlib-missing-in-symbols-control-file
shared-libs shlib-with-executable-bit
-shared-libs shlib-with-non-pic-code
shared-libs shlibs-declares-dependency-on-other-package
shared-libs symbols-declared-but-not-shlib
shared-libs symbols-declares-dependency-on-other-package
@@ -578,7 +577,6 @@ libbaz
shlib-missing-in-control-file
shlib-missing-in-symbols-control-file
shlib-with-executable-bit
- shlib-with-non-pic-code
shlibs-declares-dependency-on-other-package
symbols-file-contains-current-version-with-debian-revision
symbols-file-contains-debian-revision
diff --git a/t/tests/shared-libs-non-pic-i386/debian/Makefile
b/t/tests/shared-libs-non-pic-i386/debian/Makefile
new file mode 100644
index 000..8b68d39
--- /dev/null
+++ b/t/tests/shared-libs-non-pic-i386/debian/Makefile
@@ -0,0 +1,24 @@
+CC=gcc
+CFLAGS=-Wall -Winline -O2
+
+NOPICOBJS=non-pic.o
+SONAME:=libbaz3.so.1
+
+all: libbaz3.so.1.0.3b
+
+# Non-PIC. We can't test this on all architectures
+libbaz3.so.1.0.3b: $(NOPICOBJS)
+ $(CC) -o $@ -shared -Wl,-soname,$(SONAME) $^ -lc
+
+%.o: %.c
+ $(CC) $(CFLAGS) -o $@ -c $
+
+clean:
+ rm -f *.a *.o *.so* *.sho
+
+install: all
+ install -m 0755 -d $(DESTDIR)/usr/lib
+ install -m 0644 *.so* $(DESTDIR)/usr/lib
+ ln -s libbaz3.so.1.0.3b $(DESTDIR)/usr/lib/$(SONAME)
+
+.PHONY: install clean
diff --git a/t/tests/shared-libs-unversioned/debian/debian/control.in
b/t/tests/shared-libs-non-pic-i386/debian/debian/control.in
similarity index 95%
copy from t/tests/shared-libs-unversioned/debian/debian/control.in
copy to t/tests/shared-libs-non-pic-i386/debian/debian/control.in
index b59e74b..e7d07c3 100644
--- a/t/tests/shared-libs-unversioned/debian/debian/control.in
+++ b/t/tests/shared-libs-non-pic-i386/debian/debian/control.in
@@ -5,10 +5,11 @@ Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: debhelper (= 7)
-Package: libfoo
+Package: libbaz3-1
Architecture: {$architecture}
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
Description: {$description}
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package.
+
diff --git a/t/tests/shared-libs-non-pic-i386/debian/debian/symbols
b/t/tests/shared-libs-non-pic-i386/debian/debian/symbols
new file mode 100644
index 000..e05d3c7
--- /dev/null
+++ b/t/tests/shared-libs-non-pic-i386/debian/debian/symbols
@@ -0,0 +1,2 @@
+libbaz3.so libfoo #MINVER#
+ p...@base 1.0
diff --git a/t/tests/shared-libs-non-pic-i386/debian/non-pic.c
b/t/tests/shared-libs-non-pic-i386/debian/non-pic.c
new file mode 100644
index 000..8e44c71
--- /dev/null
+++ b/t/tests/shared-libs-non-pic-i386/debian/non-pic.c
@@ -0,0 +1,6 @@
+#include math.h
+
+double pw(double p){
+ return exp(p);
+}
+
diff --git a/t/tests/shared-libs-non-pic-i386/desc
b/t/tests/shared-libs-non-pic-i386/desc
new file mode 100644
index 000..1073f99
--- /dev/null
+++ b/t/tests/shared-libs-non-pic-i386/desc
@@ -0,0 +1,6 @@
+Testname: shared-libs-non-pic-i386
+Sequence: 6000
+Version: 1.0
+Architecture: i386
+Description: Test checks related to non-pic code
+Test-For: shlib-with-non-pic-code
diff --git a/t/tests/shared-libs-non-pic-i386/tags
b/t/tests/shared-libs-non-pic-i386/tags
new file mode 100644
index 000..416cc6c
--- /dev/null
+++ b/t/tests/shared-libs-non-pic-i386/tags
@@ -0,0 +1 @@
+E: libbaz3-1: shlib-with-non-pic-code usr/lib/libbaz3.so.1.0.3b
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxw7w-0005a2...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-64-g9b861d0
The following commit has been merged in the master branch:
commit 9b861d0a4eb4ffa607d968158caa59c51595ffdf
Author: Niels Thykier ni...@thykier.net
Date: Tue Dec 28 20:01:38 2010 +0100
Pass --allow-root during testing to avoid auto-fails, if the test
is run as root.
diff --git a/t/runtests b/t/runtests
index 217d229..86b7d46 100755
--- a/t/runtests
+++ b/t/runtests
@@ -455,6 +455,7 @@ sub test_package {
print testing... ;
my $opts = { err = $RUNDIR/tags.$pkg, fail = 'never' };
my $status;
+unshift(@options, '--allow-root');
if ($testdata-{sort}) {
$status = spawn($opts, [ $LINTIAN, @options, $file ], '|', [ 'sort' ]);
} else {
@@ -574,7 +575,7 @@ sub test_changes {
my $testdir = $TESTSET/changes;
print testing... ;
-runsystem_ok($LINTIAN -I -E $testdir/$test.changes 21
+runsystem_ok($LINTIAN --allow-root -I -E $testdir/$test.changes 21
. | sort $RUNDIR/tags.changes-$test);
# Compare the output to the expected tags.
@@ -639,7 +640,7 @@ sub test_deb {
runsystem(cd $targetdir fakeroot make ../build.$test 21);
print testing... ;
-runsystem_ok($LINTIAN -I -E $targetdir/$test.deb 21
+runsystem_ok($LINTIAN --allow-root -I -E $targetdir/$test.deb 21
. | sort $RUNDIR/tags.$test);
# Compare the output to the expected tags.
@@ -703,7 +704,7 @@ sub test_source {
runsystem(cd $targetdir make ../build.$test 21);
print testing... ;
-runsystem_ok($LINTIAN -I -E $targetdir/*.dsc 21
+runsystem_ok($LINTIAN --allow-root -I -E $targetdir/*.dsc 21
. | sort $RUNDIR/tags.$test);
# Compare the output to the expected tags.
diff --git a/t/scripts/static-lab.t b/t/scripts/static-lab.t
index 489ba73..190cc2f 100755
--- a/t/scripts/static-lab.t
+++ b/t/scripts/static-lab.t
@@ -8,7 +8,7 @@ use Test::Simple tests = 4;
my $lintian_path = $ENV{LINTIAN_ROOT}/frontend/lintian;
my $labdir = tempdir(CLEANUP = 1);
-ok(system($lintian_path --lab $labdir --setup-lab) == 0, Create);
-ok(system($lintian_path --lab $labdir --setup-lab) == 0, Renew);
-ok(system($lintian_path --lab $labdir --remove-lab) == 0, Remove);
+ok(system($lintian_path --allow-root --lab $labdir --setup-lab) == 0,
Create);
+ok(system($lintian_path --allow-root --lab $labdir --setup-lab) == 0,
Renew);
+ok(system($lintian_path --allow-root --lab $labdir --remove-lab) == 0,
Remove);
ok(system(rmdir $labdir) == 0, Rmdir);
diff --git a/testset/runtests b/testset/runtests
index d70345d..9402746 100755
--- a/testset/runtests
+++ b/testset/runtests
@@ -207,8 +207,8 @@ for (@tests) {
runsystem(cd $rundir/$pkgdir dpkg-buildpackage
$dpkg_buildpackage_options ../build.$pkg 21);
print testing... ;
-print Running lintian $lintian_options on
$rundir/$pkg\_$ver*.changes...\n if $debug;
-runsystem_ok($lintian_path $lintian_options $rundir/$pkg\_$ver*.changes.
+print Running lintian --allow-root $lintian_options on
$rundir/$pkg\_$ver*.changes...\n if $debug;
+runsystem_ok($lintian_path --allow-root $lintian_options
$rundir/$pkg\_$ver*.changes.
21 | sort $rundir/tags.$pkg);
# Run a sed-script if it exists, for tests that have slightly variable
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxeq7-0008sq...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-65-g56a7afa
The following commit has been merged in the master branch:
commit 56a7afa0fd67c936465ba649a6e1a00fd1ceee89
Author: Niels Thykier ni...@thykier.net
Date: Tue Dec 28 20:33:44 2010 +0100
Added test for d/control being a symlink.
diff --git a/t/COVERAGE b/t/COVERAGE
index 15a3b0a..51940bf 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -18,7 +18,6 @@ changes-file bad-section-in-changes-file
changes-file checksum-mismatch-in-changes-file
changes-file file-size-mismatch-in-changes-file
-control-file debian-control-file-is-a-symlink
control-file debian-control-with-duplicate-fields
control-files control-file-has-bad-owner
diff --git a/t/tests/control-file-symlink/desc
b/t/tests/control-file-symlink/desc
new file mode 100644
index 000..a6546ab
--- /dev/null
+++ b/t/tests/control-file-symlink/desc
@@ -0,0 +1,6 @@
+Testname: control-file-symlink
+Sequence: 6000
+Version: 1.0
+Description: Test if debian/control is a symlink
+Test-For:
+ debian-control-file-is-a-symlink
diff --git a/t/tests/control-file-symlink/pre_build
b/t/tests/control-file-symlink/pre_build
new file mode 100755
index 000..d872c36
--- /dev/null
+++ b/t/tests/control-file-symlink/pre_build
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+ROOT_DIR=$1
+
+mv ${ROOT_DIR}/debian/control ${ROOT_DIR}/debian/control.real
+ln -s control.real ${ROOT_DIR}/debian/control
diff --git a/t/tests/control-file-symlink/tags
b/t/tests/control-file-symlink/tags
new file mode 100644
index 000..fe95e35
--- /dev/null
+++ b/t/tests/control-file-symlink/tags
@@ -0,0 +1 @@
+W: control-file-symlink source: debian-control-file-is-a-symlink
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxfky-0007y0...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-66-gace61b2
The following commit has been merged in the master branch: commit ace61b227a9eff446297617aaababe848dfe6bff Author: Niels Thykier ni...@thykier.net Date: Tue Dec 28 21:03:18 2010 +0100 Test for file-in-etc-not-marked-as-conffile diff --git a/t/COVERAGE b/t/COVERAGE index 51940bf..ad5a397 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -240,8 +240,6 @@ debconf using-question-in-extended-description-in-templates debhelper uses-dh-python-with-no-pycompat -etcfiles file-in-etc-not-marked-as-conffile - fields build-depends-indep-without-arch-indep fields dbg-package-missing-depends fields debug-package-should-be-priority-extra @@ -510,7 +508,6 @@ debug unused-shlib-entry-in-symbols-control-file etcfiles - file-in-etc-not-marked-as-conffile file-missing-in-md5sums malformed-md5sums-control-file md5sum-mismatch diff --git a/t/tests/etcfiles-etc-not-marked/debian/debian/install b/t/tests/etcfiles-etc-not-marked/debian/debian/install new file mode 100644 index 000..ec665e8 --- /dev/null +++ b/t/tests/etcfiles-etc-not-marked/debian/debian/install @@ -0,0 +1 @@ +something.conf etc/ diff --git a/t/tests/etcfiles-etc-not-marked/debian/debian/rules b/t/tests/etcfiles-etc-not-marked/debian/debian/rules new file mode 100644 index 000..5afe3f7 --- /dev/null +++ b/t/tests/etcfiles-etc-not-marked/debian/debian/rules @@ -0,0 +1,11 @@ +#!/usr/bin/make -f + +%: + dh $@ + +override_dh_builddeb: + DIR=$$(find -name 'DEBIAN'); \ + rm $$DIR/conffiles \ + md5sum something.conf | sed 's/ s/ etc\/s/' $$DIR/md5sums + dh_builddeb + diff --git a/t/tests/etcfiles-etc-not-marked/debian/something.conf b/t/tests/etcfiles-etc-not-marked/debian/something.conf new file mode 100644 index 000..432ea47 --- /dev/null +++ b/t/tests/etcfiles-etc-not-marked/debian/something.conf @@ -0,0 +1 @@ +hello=world diff --git a/t/tests/etcfiles-etc-not-marked/desc b/t/tests/etcfiles-etc-not-marked/desc new file mode 100644 index 000..60b86e7 --- /dev/null +++ b/t/tests/etcfiles-etc-not-marked/desc @@ -0,0 +1,5 @@ +Testname: etcfiles-etc-not-marked +Sequence: 6000 +Version: 1.0 +Description: Test checking etc files not being marked as conffiles +Test-For: file-in-etc-not-marked-as-conffile diff --git a/t/tests/etcfiles-etc-not-marked/tags b/t/tests/etcfiles-etc-not-marked/tags new file mode 100644 index 000..172788d --- /dev/null +++ b/t/tests/etcfiles-etc-not-marked/tags @@ -0,0 +1 @@ +E: etcfiles-etc-not-marked: file-in-etc-not-marked-as-conffile /etc/something.conf -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxfnm-un...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-67-g1282bb6
The following commit has been merged in the master branch:
commit 1282bb612b48c2aca18254ef525ebe6c3c51bc55
Author: Niels Thykier ni...@thykier.net
Date: Tue Dec 28 21:14:17 2010 +0100
Added test for depends on multiple something tags.
diff --git a/t/COVERAGE b/t/COVERAGE
index ad5a397..d43bca7 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -247,11 +247,6 @@ fields depends-exclusively-on-makedev
fields depends-on-old-emacs
fields depends-on-python-minimal
fields malformed-dm-upload-allowed
-fields package-depends-on-multiple-libpng-versions
-fields package-depends-on-multiple-libstdc-versions
-fields package-depends-on-multiple-tcl-versions
-fields package-depends-on-multiple-tk-versions
-fields package-depends-on-multiple-tkx-versions
fields redundant-bugs-field
fields redundant-origin-field
fields unknown-section
@@ -609,11 +604,6 @@ maintainer-scripts
relations
depends-exclusively-on-makedev
depends-on-old-emacs
- package-depends-on-multiple-libpng-versions
- package-depends-on-multiple-libstdc-versions
- package-depends-on-multiple-tcl-versions
- package-depends-on-multiple-tk-versions
- package-depends-on-multiple-tkx-versions
quilt-build-dep-but-no-series-file
redundant-bugs-field
redundant-origin-field
diff --git a/t/tests/control-file-suggests-itself/debian/debian/control.in
b/t/tests/fields-multiple-x-deps/debian/debian/control.in
similarity index 67%
copy from t/tests/control-file-suggests-itself/debian/debian/control.in
copy to t/tests/fields-multiple-x-deps/debian/debian/control.in
index 86553ca..00e49bc 100644
--- a/t/tests/control-file-suggests-itself/debian/debian/control.in
+++ b/t/tests/fields-multiple-x-deps/debian/debian/control.in
@@ -7,10 +7,15 @@ Build-Depends: debhelper (= 7)
Package: {$srcpkg}
Architecture: {$architecture}
-Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
-Suggests: {$srcpkg}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\},
+ libstdc++2.10, libstdc++2.10-glibc2.2, libstdc++3.0,
+ tk8.2, tk8.3,
+ tcl8.0, tcl8.2,
+ tkx8.2, tkx8.3, tclx8.2,
+ libpng2, libpng3
Description: {$description}
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+
diff --git a/t/tests/fields-multiple-x-deps/desc
b/t/tests/fields-multiple-x-deps/desc
new file mode 100644
index 000..89f9ffe
--- /dev/null
+++ b/t/tests/fields-multiple-x-deps/desc
@@ -0,0 +1,10 @@
+Testname: fields-multiple-x-deps
+Sequence: 6000
+Version: 1.0
+Description: Tests for multiple depends on X
+Test-For:
+ package-depends-on-multiple-libpng-versions
+ package-depends-on-multiple-libstdc-versions
+ package-depends-on-multiple-tcl-versions
+ package-depends-on-multiple-tk-versions
+ package-depends-on-multiple-tkx-versions
diff --git a/t/tests/fields-multiple-x-deps/tags
b/t/tests/fields-multiple-x-deps/tags
new file mode 100644
index 000..06ee336
--- /dev/null
+++ b/t/tests/fields-multiple-x-deps/tags
@@ -0,0 +1,5 @@
+E: fields-multiple-x-deps: package-depends-on-multiple-libpng-versions libpng2
libpng3
+E: fields-multiple-x-deps: package-depends-on-multiple-libstdc-versions
libstdc++2.10 libstdc++2.10-glibc2.2 libstdc++3.0
+E: fields-multiple-x-deps: package-depends-on-multiple-tcl-versions tcl8.0
tcl8.2
+E: fields-multiple-x-deps: package-depends-on-multiple-tk-versions tk8.2 tk8.3
+E: fields-multiple-x-deps: package-depends-on-multiple-tkx-versions tkx8.2
tkx8.3
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxfyc-0002oe...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-68-gb760e91
The following commit has been merged in the master branch:
commit b760e913311adbe620a9b9b063a781abca510166
Author: Niels Thykier ni...@thykier.net
Date: Tue Dec 28 21:21:40 2010 +0100
Added missing tag to multiple X depends.
diff --git a/t/COVERAGE b/t/COVERAGE
index d43bca7..a4380f5 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -67,7 +67,6 @@ fields no-version-field
fields obsolete-field
fields old-versioned-python-dependency
fields package-depends-on-an-x-font-package
-fields package-depends-on-multiple-tclx-versions
fields package-not-lowercase
fields package-superseded-by-perl
fields source-field-does-not-match-pkg-name
diff --git a/t/tests/fields-multiple-x-deps/debian/debian/control.in
b/t/tests/fields-multiple-x-deps/debian/debian/control.in
index 00e49bc..2863a24 100644
--- a/t/tests/fields-multiple-x-deps/debian/debian/control.in
+++ b/t/tests/fields-multiple-x-deps/debian/debian/control.in
@@ -11,7 +11,8 @@ Depends: $\{shlibs:Depends\}, $\{misc:Depends\},
libstdc++2.10, libstdc++2.10-glibc2.2, libstdc++3.0,
tk8.2, tk8.3,
tcl8.0, tcl8.2,
- tkx8.2, tkx8.3, tclx8.2,
+ tkx8.2, tkx8.3,
+ tclx76, tclx8.0.4, tclx8.2,
libpng2, libpng3
Description: {$description}
This is a test package designed to exercise some feature or tag of
diff --git a/t/tests/fields-multiple-x-deps/desc
b/t/tests/fields-multiple-x-deps/desc
index 89f9ffe..949781f 100644
--- a/t/tests/fields-multiple-x-deps/desc
+++ b/t/tests/fields-multiple-x-deps/desc
@@ -6,5 +6,6 @@ Test-For:
package-depends-on-multiple-libpng-versions
package-depends-on-multiple-libstdc-versions
package-depends-on-multiple-tcl-versions
+ package-depends-on-multiple-tclx-versions
package-depends-on-multiple-tk-versions
package-depends-on-multiple-tkx-versions
diff --git a/t/tests/fields-multiple-x-deps/tags
b/t/tests/fields-multiple-x-deps/tags
index 06ee336..bb0fdd5 100644
--- a/t/tests/fields-multiple-x-deps/tags
+++ b/t/tests/fields-multiple-x-deps/tags
@@ -1,5 +1,6 @@
E: fields-multiple-x-deps: package-depends-on-multiple-libpng-versions libpng2
libpng3
E: fields-multiple-x-deps: package-depends-on-multiple-libstdc-versions
libstdc++2.10 libstdc++2.10-glibc2.2 libstdc++3.0
E: fields-multiple-x-deps: package-depends-on-multiple-tcl-versions tcl8.0
tcl8.2
+E: fields-multiple-x-deps: package-depends-on-multiple-tclx-versions tclx76
tclx8.0.4 tclx8.2
E: fields-multiple-x-deps: package-depends-on-multiple-tk-versions tk8.2 tk8.3
E: fields-multiple-x-deps: package-depends-on-multiple-tkx-versions tkx8.2
tkx8.3
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxg51-0003dv...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-69-ga943690
The following commit has been merged in the master branch: commit a943690f7b0d4edb37c5eea685c08153e8b890a8 Author: Niels Thykier ni...@thykier.net Date: Tue Dec 28 22:06:02 2010 +0100 Correct symbols file in a test. diff --git a/t/tests/shared-libs-non-pic-i386/debian/debian/symbols b/t/tests/shared-libs-non-pic-i386/debian/debian/symbols index e05d3c7..27e214a 100644 --- a/t/tests/shared-libs-non-pic-i386/debian/debian/symbols +++ b/t/tests/shared-libs-non-pic-i386/debian/debian/symbols @@ -1,2 +1,2 @@ -libbaz3.so libfoo #MINVER# +libbaz3.so libbaz3-1 #MINVER# p...@base 1.0 -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxglt-0007ic...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-70-g92844ef
The following commit has been merged in the master branch:
commit 92844ef5e16f6607f837b32a8b0a97e1c5784be0
Author: Niels Thykier ni...@thykier.net
Date: Tue Dec 28 22:44:46 2010 +0100
Some symbols-file tests.
diff --git a/t/COVERAGE b/t/COVERAGE
index a4380f5..b209807 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -394,8 +394,6 @@ shared-libs shlib-with-executable-bit
shared-libs shlibs-declares-dependency-on-other-package
shared-libs symbols-declared-but-not-shlib
shared-libs symbols-declares-dependency-on-other-package
-shared-libs symbols-file-contains-current-version-with-debian-revision
-shared-libs symbols-file-contains-debian-revision
shared-libs syntax-error-in-symbols-file
shared-libs udeb-postinst-must-not-call-ldconfig
shared-libs unknown-meta-field-in-symbols-file
@@ -568,8 +566,6 @@ libbaz
shlib-missing-in-symbols-control-file
shlib-with-executable-bit
shlibs-declares-dependency-on-other-package
- symbols-file-contains-current-version-with-debian-revision
- symbols-file-contains-debian-revision
unused-shlib-entry-in-control-file
maintainer-scripts
diff --git a/t/tests/shared-libs-unversioned/debian/debian/control.in
b/t/tests/shared-libs-symbols-file/debian/debian/control.in
similarity index 90%
copy from t/tests/shared-libs-unversioned/debian/debian/control.in
copy to t/tests/shared-libs-symbols-file/debian/debian/control.in
index b59e74b..7b15dd1 100644
--- a/t/tests/shared-libs-unversioned/debian/debian/control.in
+++ b/t/tests/shared-libs-symbols-file/debian/debian/control.in
@@ -5,8 +5,8 @@ Maintainer: {$author}
Standards-Version: {$standards_version}
Build-Depends: debhelper (= 7)
-Package: libfoo
-Architecture: {$architecture}
+Package: libfoo1
+Architecture: any
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
Description: {$description}
This is a test package designed to exercise some feature or tag of
diff --git a/t/tests/shared-libs-symbols-file/debian/debian/symbols
b/t/tests/shared-libs-symbols-file/debian/debian/symbols
new file mode 100644
index 000..4088c6a
--- /dev/null
+++ b/t/tests/shared-libs-symbols-file/debian/debian/symbols
@@ -0,0 +1,3 @@
+libfoo.so.1 libfoo1 #MINVER#
+ e...@base 1.0-1
+ ene...@base 0.9-1
diff --git a/t/tests/shared-libs-symbols-file/desc
b/t/tests/shared-libs-symbols-file/desc
new file mode 100644
index 000..c178973
--- /dev/null
+++ b/t/tests/shared-libs-symbols-file/desc
@@ -0,0 +1,8 @@
+Testname: shared-libs-symbols-file
+Sequence: 6000
+Version: 1.0-1
+Type: non-native
+Description: Test checks related to symbols files
+Test-For:
+ symbols-file-contains-current-version-with-debian-revision
+ symbols-file-contains-debian-revision
diff --git a/t/tests/shared-libs-symbols-file/tags
b/t/tests/shared-libs-symbols-file/tags
new file mode 100644
index 000..80e7e0e
--- /dev/null
+++ b/t/tests/shared-libs-symbols-file/tags
@@ -0,0 +1,2 @@
+E: libfoo1: symbols-file-contains-current-version-with-debian-revision on
symbol e...@base
+W: libfoo1: symbols-file-contains-debian-revision on symbol ene...@base
diff --git a/t/tests/shared-libs-symbols-file/upstream/Makefile
b/t/tests/shared-libs-symbols-file/upstream/Makefile
new file mode 100644
index 000..d2af7a3
--- /dev/null
+++ b/t/tests/shared-libs-symbols-file/upstream/Makefile
@@ -0,0 +1,19 @@
+CC=gcc
+CFLAGS=-Wall -Winline -O2 -fPIC
+
+SONAME:= libfoo.so.1
+
+all: libfoo.so.1.0.1
+
+libfoo.so.1.0.1: code.o
+ $(CC) -o $@ -shared -Wl,-soname,$(SONAME) $^ -lc
+
+clean:
+ rm -f *.a *.o *.so* *.sho
+
+install: all
+ install -m 0755 -d $(DESTDIR)/usr/lib
+ install -m 0644 *.so* $(DESTDIR)/usr/lib
+ ln -s libfoo.so.1.0.1 $(DESTDIR)/usr/lib/$(SONAME)
+
+.PHONY: install clean
diff --git a/t/tests/shared-libs-symbols-file/upstream/code.c
b/t/tests/shared-libs-symbols-file/upstream/code.c
new file mode 100644
index 000..1eb449e
--- /dev/null
+++ b/t/tests/shared-libs-symbols-file/upstream/code.c
@@ -0,0 +1,10 @@
+#include math.h
+
+double e(double x){
+ return exp(x);
+}
+
+double energy(double mass){
+ return pow(10.0, 8.0) * pow(3.0, 2.0) * mass;
+}
+
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxhnn-0004xx...@alioth.debian.org
Bug#608222: lintian: Please check symbols-files for foreign packages
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hey Right, there is a check for that... but: cat t/tests/shared-libs-non-pic-i386/debian/debian/symbols: libbaz3.so libfilo #MINVER# p...@base 1.0 does not trigger an issue and I cannot figure out why! I am fairly confident that something is wrong, since the package libbaz3-1 does not provide or depends on libfilo[1]. ~Niels [1] Generated DEBIAN/control: Package: libbaz3-1 Source: shared-libs-non-pic-i386 Version: 1.0 Architecture: i386 Maintainer: Debian Lintian Maintainers lintian-ma...@debian.org Installed-Size: 28 Depends: libc6 (= 2.1.3) Section: libs Priority: extra Description: Test checks related to non-pic code This is a test package designed to exercise some feature or tag of Lintian. It is part of the Lintian test suite and may do very odd things. It should not be installed like a regular package. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNGlWRAAoJEAVLu599gGRCLC0P/AxkbYdZOzHMh2WBvUiLl5d/ XRKCNpn0zhPGsYjtyoLS6j3lhzoaczXvFr+JkrXjd6ag5fKWIHeHX2Cqpri3hW9a sEfx94JqiojH8dWoh1PyJQvfRI8zak4gajkfe3gWq/C9e5I+kgThAFtLSC4rl2Sw WPX7I95FzK5GThbqi5C7k2RLd32Yva7SttaaTlBSGmzL8L543V9USFIA+WtgKtyi kwERMOm2ZE/ykWKY4dgrPmNbnl/JNunEjZjg/hKynvT77sjqRqZ42UNlZSPD0+/D k0JzFrVHuLGhXvI3clqlreRMT7aYhtAUVt3g3+pl95x/oqUFUaGIT0nX80JO5nDs Uxnsxgjj7HxBuompxNmXtjNfuSGw+C1xXXHYsKVEmwRvusGX2OvtORzNicPV5YGz FcxzSXpPF3pfC1dH8gDBDH+m8H+GyYeNbWPW6a2rROmXANMuhCMokHH6uMQKU3tq SK+35WnHmzBgQNxcu66uHPwZSjVW3VFlwRQqjrClWGQJDidx1t0SXnrReOWdulDn +1p8/h2dicZK/a7TE6bVuCthkRDRqHiqM+rUVId6tfGrA5uElFO8J06SMrRZSU8d LEom/W4wh3OocAojz+kxwPFzknW4TNo1R4LQIorpmppxiIVKYQEnDyzBomaDhir7 n+KL1rIdyyJE38xn3/12 =HaYZ -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d1a5592.7080...@thykier.net
Bug#608222: lintian: Please check symbols-files for foreign packages
Package: lintian Version: 2.4.3 Severity: wishlist -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hey Check for symbol files referring to non-existent or foreign packages. libbaz3.so libfoo #MINVER# ~Niels - -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils 2.20.1-15 The GNU assembler, linker and bina ii diffstat 1.53-1produces graph of changes introduc ii dpkg-dev 1.15.8.5 Debian package development tools ii file 5.04-5Determines file type using magic ii gettext0.18.1.1-3GNU Internationalization utilities ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf ii libapt-pkg-perl0.1.24+b1 Perl interface to libapt-pkg ii libclass-accessor-perl 0.34-1Perl module that automatically gen ii libipc-run-perl0.89-1Perl module for running processes ii libparse-debianchangel 1.1.1-2.1 parse Debian changelogs and output ii libtimedate-perl 1.2000-1 collection of modules to manipulat ii liburi-perl1.54-2module to manipulate and access UR ii locales2.11.2-7 Embedded GNU C Library: National L ii man-db 2.5.7-7 on-line manual pager ii perl [libdigest-sha-pe 5.10.1-16 Larry Wall's Practical Extraction lintian recommends no packages. Versions of packages lintian suggests: pn binutils-multiarchnone (no description available) ii libtext-template-perl 1.45-1 Text::Template perl module ii man-db2.5.7-7on-line manual pager - -- no debconf information -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBCAAGBQJNGlDYAAoJEAVLu599gGRCBowQAK57wcumo7dSfg+bdhgrxLOG ARFx1Tm6XAd7fMntItro7eVZyv/geaoaAJ+w9KgESdzz2XDfnUeWt/BsjaNVvG/P SgNlnCuJYRVzr862Bx01XTE+QU1too3L5LOV/jqNPiufDAeSkS1o4gJOPDRDbInF /m7p0EAolGAGh677VjF5c9qqulJCVs3PVcAWMHX5BXOjr4MHbWkUpLvxFE1wQ+R3 tHuCfKtaXBQzMl2Q7t8YPXW10VdOPS2krw9ZX7G1ytWScVqZaEAHjE4ssm6Mv0XW jQ7okrF8c0F0ok3ljuMPgPgF1nhyyO6IPG13+eWgNKIAO3v9/Ep5e7e3cxh+0rxB dj5IAKAytH2UvLJF8WYe0lQGLjCnY0qi+rQFVG63L8mbesqRd5+gl0WKez0uYV9F BLNVraiut5npCcPbNoYFWwS0mE0x2s3GaLO7lW/Y6anoDpyj7Xay2p6O+RWoST1i KtrWX0n2Rlbh5nRnpZ2c58eEJuSfr0SAkbxGXCvYAjdqNRDm1xSJ1M6z/klMDxWI wOwTy9n+qtVDKym8kb7Q8bx/+LTdGYQ3HvglCYpeqw/cTyVngvLwqmjArU9JI1If GKgZJi7fkygUSrdiRIrAL37MykiZPuLN2DUMlNruKHJJCkf5hZKyZHnM5Qj2VmO1 bVnaKroZP7taHPSIicnN =FpCQ -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20101228210429.30930.30042.report...@getsu.thykier.net
[SCM] Debian package checker branch, master, updated. 2.4.3-71-ga3da5c4
The following commit has been merged in the master branch:
commit a3da5c49bae6a43ffbd5ec5476ea57bf96017141
Author: Niels Thykier ni...@thykier.net
Date: Tue Dec 28 23:06:45 2010 +0100
Test for XS-Vcs-vcs tags.
diff --git a/t/COVERAGE b/t/COVERAGE
index b209807..45b2fda 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -203,7 +203,6 @@ changelog-file wrong-name-for-debian-news-file
control-file debian-control-file-uses-obsolete-national-encoding
control-file section-area-mismatch
-control-file xs-vcs-header-in-debian-control
control-files control-file-has-bad-permissions
control-files control-file-is-empty
@@ -452,7 +451,6 @@ binary
su-wrapper-without--c
unquoted-string-in-menu-item
unstripped-binary-or-object
- xs-vcs-header-in-debian-control
debconf
loads-obsolete-confmodule
diff --git a/t/tests/control-file-general/debian/debian/control.in
b/t/tests/control-file-general/debian/debian/control.in
index 423310d..58e7522 100644
--- a/t/tests/control-file-general/debian/debian/control.in
+++ b/t/tests/control-file-general/debian/debian/control.in
@@ -10,7 +10,8 @@ Build-Depends: debhelper (= 7.0.50~),
sparc i386 amd64
]
Build-Depends-Indep: perl ( 5.8)
-X-VCS-Svn: svn://svn.example.com/{$srcpkg}/trunk
+XS-Vcs-Svn: svn://svn.example.com/{$srcpkg}/trunk
+
Package: {$srcpkg}
Section: {$section}
diff --git a/t/tests/control-file-general/desc
b/t/tests/control-file-general/desc
index cf965fe..99c6d58 100644
--- a/t/tests/control-file-general/desc
+++ b/t/tests/control-file-general/desc
@@ -12,5 +12,6 @@ Test-For:
obsolete-relation-form-in-source
package-depends-on-itself
stronger-dependency-implies-weaker
+ xs-vcs-header-in-debian-control
References: Debian Bug#30020, Debian Bug#409099, Debian Bug#516706,
Debian Bug#533202, Debian Bug#557971, Debian Bug#573399, Debian Bug#580494
diff --git a/t/tests/control-file-general/tags
b/t/tests/control-file-general/tags
index b58b4cd..82fd675 100644
--- a/t/tests/control-file-general/tags
+++ b/t/tests/control-file-general/tags
@@ -3,6 +3,7 @@ E: control-file-general source: missing-separator-between-items
in control-file-
I: control-file-general source: binary-control-field-duplicates-source field
maintainer in package control-file-general
I: control-file-general source: duplicate-long-description
control-file-general control-file-general-1 control-file-general-2
control-file-general-3 control-file-general-4
I: control-file-general source: duplicate-short-description
control-file-general control-file-general-1
+I: control-file-general source: xs-vcs-header-in-debian-control xs-vcs-svn
W: control-file-general source: no-section-field-for-source
W: control-file-general source: obsolete-relation-form-in-source in
control-file-general-1 breaks: libsqlite3-0 ( 3.6.12)
W: control-file-general source: obsolete-relation-form-in-source in source
build-depends-indep: perl ( 5.8)
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxhif-0004ja...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-73-gd84aa6b
The following commit has been merged in the master branch: commit 19b9aa12ec23cab1fafd28346be87715dd3b852d Author: Niels Thykier ni...@thykier.net Date: Tue Dec 28 23:38:40 2010 +0100 Added most of the md5sums tags. diff --git a/t/COVERAGE b/t/COVERAGE index 45b2fda..ed5c9c1 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -307,10 +307,6 @@ init.d postrm-does-not-call-updaterc.d-for-init.d-script init.d preinst-calls-updaterc.d init.d prerm-calls-updaterc.d -md5sums file-missing-in-md5sums -md5sums malformed-md5sums-control-file -md5sums md5sum-mismatch -md5sums md5sums-lists-nonexisting-file md5sums no-md5sums-control-file menu-format deprecated-kdelnk-file @@ -498,10 +494,6 @@ debug unused-shlib-entry-in-symbols-control-file etcfiles - file-missing-in-md5sums - malformed-md5sums-control-file - md5sum-mismatch - md5sums-lists-nonexisting-file run-parts-cron-filename-contains-full-stop fields diff --git a/t/tests/md5sums-general/debian/data-file1 b/t/tests/md5sums-general/debian/data-file1 new file mode 100644 index 000..ad9213e --- /dev/null +++ b/t/tests/md5sums-general/debian/data-file1 @@ -0,0 +1 @@ +Hello data-file1 diff --git a/t/tests/md5sums-general/debian/data-file2 b/t/tests/md5sums-general/debian/data-file2 new file mode 100644 index 000..fdf6b01 --- /dev/null +++ b/t/tests/md5sums-general/debian/data-file2 @@ -0,0 +1 @@ +Hello data-file2 diff --git a/t/tests/md5sums-general/debian/data-file3 b/t/tests/md5sums-general/debian/data-file3 new file mode 100644 index 000..0f72672 --- /dev/null +++ b/t/tests/md5sums-general/debian/data-file3 @@ -0,0 +1 @@ +Hello data-file3 diff --git a/t/tests/md5sums-general/debian/data-file4 b/t/tests/md5sums-general/debian/data-file4 new file mode 100644 index 000..2764cf8 --- /dev/null +++ b/t/tests/md5sums-general/debian/data-file4 @@ -0,0 +1 @@ +Hello data-file4 diff --git a/t/tests/md5sums-general/debian/debian/install b/t/tests/md5sums-general/debian/debian/install new file mode 100644 index 000..399564c --- /dev/null +++ b/t/tests/md5sums-general/debian/debian/install @@ -0,0 +1 @@ +data* usr/share/lintian/ diff --git a/t/tests/md5sums-general/debian/debian/rules b/t/tests/md5sums-general/debian/debian/rules new file mode 100644 index 000..6971ee0 --- /dev/null +++ b/t/tests/md5sums-general/debian/debian/rules @@ -0,0 +1,12 @@ +#!/usr/bin/make -f + +FIND ?= find + +%: + dh $@ + +override_dh_builddeb: + echo Broken md5sum $$($(FIND) debian/ -name 'data-file1') + sed -i 's/data-file2/data-file5/' $$($(FIND) -name 'md5sums') + echo broken-md5sums $$($(FIND) -name 'md5sums') + dh_builddeb diff --git a/t/tests/md5sums-general/desc b/t/tests/md5sums-general/desc new file mode 100644 index 000..be7f023 --- /dev/null +++ b/t/tests/md5sums-general/desc @@ -0,0 +1,9 @@ +Testname: md5sums-general +Sequence: 6000 +Version: 1.0 +Description: Test of md5sums related tags +Test-For: + file-missing-in-md5sums + malformed-md5sums-control-file + md5sum-mismatch + md5sums-lists-nonexisting-file diff --git a/t/tests/md5sums-general/tags b/t/tests/md5sums-general/tags new file mode 100644 index 000..43e9b18 --- /dev/null +++ b/t/tests/md5sums-general/tags @@ -0,0 +1,4 @@ +E: md5sums-general: malformed-md5sums-control-file line 7 +E: md5sums-general: md5sum-mismatch usr/share/lintian/data-file1 +E: md5sums-general: md5sums-lists-nonexisting-file usr/share/lintian/data-file5 +W: md5sums-general: file-missing-in-md5sums usr/share/lintian/data-file2 -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxikk-00015c...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-73-gd84aa6b
The following commit has been merged in the master branch: commit d84aa6b4c247fa1bd1b20dec3b6fc03954e7489c Author: Niels Thykier ni...@thykier.net Date: Tue Dec 28 23:45:46 2010 +0100 Added a test for missing md5sums control files. diff --git a/t/COVERAGE b/t/COVERAGE index ed5c9c1..2291423 100644 --- a/t/COVERAGE +++ b/t/COVERAGE @@ -307,8 +307,6 @@ init.d postrm-does-not-call-updaterc.d-for-init.d-script init.d preinst-calls-updaterc.d init.d prerm-calls-updaterc.d -md5sums no-md5sums-control-file - menu-format deprecated-kdelnk-file menu-format desktop-contains-deprecated-header menu-format desktop-entry-missing-required-key @@ -433,7 +431,6 @@ binary menu-item-uses-apps-section menu-item-uses-windowmanagers-section menu-method-should-include-menu-h - no-md5sums-control-file non-wm-in-windowmanager-menu-section non-wm-module-in-wm-modules-menu-section old-fsf-address-in-copyright-file diff --git a/t/tests/md5sums-missing/debian/debian/rules b/t/tests/md5sums-missing/debian/debian/rules new file mode 100644 index 000..9d8ce3a --- /dev/null +++ b/t/tests/md5sums-missing/debian/debian/rules @@ -0,0 +1,10 @@ +#!/usr/bin/make -f + +FIND ?= find + +%: + dh $@ + +override_dh_builddeb: + $(FIND) debian/ -name 'md5sums' -delete + dh_builddeb diff --git a/t/tests/md5sums-missing/desc b/t/tests/md5sums-missing/desc new file mode 100644 index 000..41ae417 --- /dev/null +++ b/t/tests/md5sums-missing/desc @@ -0,0 +1,6 @@ +Testname: md5sums-missing +Sequence: 6000 +Version: 1.0 +Description: Test of missing md5sums file +Test-For: + no-md5sums-control-file diff --git a/t/tests/md5sums-missing/tags b/t/tests/md5sums-missing/tags new file mode 100644 index 000..7388c6f --- /dev/null +++ b/t/tests/md5sums-missing/tags @@ -0,0 +1 @@ +I: md5sums-missing: no-md5sums-control-file -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxikl-00015y...@alioth.debian.org
Bug#608222: lintian: Please check symbols-files for foreign packages
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 2010-12-28 23:56, Adam D. Barratt wrote: On Tue, 2010-12-28 at 22:04 +0100, Niels Thykier wrote: Check for symbol files referring to non-existent or foreign packages. libbaz3.so libfoo #MINVER# That's what the catchily named symbols-declares-dependency-on-other-package is intended to catch. Indeed, if I modify shared-libs-symbols-file's symbols file so that instead of libfoo.so.1 libfoo1 #MINVER# it reads libfoo.so.1 libfoo #MINVER#, I get an extra W: libfoo1: symbols-declares-dependency-on-other-package libfoo #MINVER#. Yes, I noticed that 2 minutes after filing the bug . I don't have an i386 chroot or machine easily to hand where I can test, but I'm guessing that the above was from the shared-libs-non-pic-i386 test? Indeed and for some reason that test does not seem trigger that test no matter what I throw at it. It does not affect the test itself, but I fear we might have false-negatives here. Regards, Adam ~Niels -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNGm75AAoJEAVLu599gGRCKQoP/0CPxrTdq1ITm/PJ1Hg+48Yj iRASLpFqtPulKrMzeTWQS7ad/yGd8ccBH7Hnai0AcoIf0IPWBbLaoHgxxCqelhnh KuCvC2M1LPp0ZFSY5XPjNvZ6PAFVgOt97WjqS/1hoDOuFaFq6ZovanjtOqqULan8 q6Y82Ie/xDz+SVbMBbv1XY9g7um66lRW44dENAswaiHQTviG/9NlUkJtndPwB0wX XZt8c2QPKOzmQ8i6577Eax1B4Bdg2LTN/rda34m+hqIPNmJ6M0285rkRbcLlTIJX aMfXJ2awZXITOl4+KF36j6S955uHv/HRaDFJ3U3jQvpw5bPutcAOIqZrfb+khNvU 2gfySFGBlXYW6umIgXH5Rb1CffG2LxK7czk5k72WbOJWlPfphly7H2ZeZK5YpQwM YR2egmICzgryB5P5qcSNQICCdMRRq3Kaey26sac0b01Lk45y5hKfUEfhyaFPHBZz xP87jt/5yiUqccwsBT4QPFCHXRixCWK/9f07Ogpt01LejckhkfF+wgkrSveXepJi iXAu4ejrZB1VmhEJvkGTH/yZwyMBDYyIFPCP+pLON0gY+zkTNVkUn/l0MZphvCfa s1QMP+L+2ra0X/jFFxjXExilywISZ4vtLeOAAdh59jn/EFUqgEEpDyeUv6HQFi26 6qzSUmzP6nmnSFQ2J80A =KaIL -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4d1a6ef9.7050...@thykier.net
[SCM] Debian package checker branch, master, updated. 2.4.3-74-ga48fb5a
The following commit has been merged in the master branch:
commit a48fb5a20501a2e468401bfd2ea9e1aec085eb06
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 29 10:28:26 2010 +0100
Added some /usr/share/doc/pkg - other symlink tests.
diff --git a/t/COVERAGE b/t/COVERAGE
index 2291423..0e8b07b 100644
--- a/t/COVERAGE
+++ b/t/COVERAGE
@@ -1,4 +1,4 @@
-Last generated 2010-12-28
+Last generated 2010-12-29
The following tags are not tested by the test suite:
@@ -26,8 +26,6 @@ control-files unknown-control-file
copyright-file copyright-does-not-refer-to-common-license-file
copyright-file copyright-should-refer-to-common-license-file-for-lgpl
-copyright-file usr-share-doc-symlink-points-outside-of-usr-share-doc
-copyright-file usr-share-doc-symlink-to-foreign-package
cruft documentation-package-not-architecture-independent
cruft source-contains-prebuilt-windows-binary
diff --git a/t/tests/files-flash-non-free/debian/debian/control.in
b/t/tests/copyright-file-symlink/debian/debian/control.in
similarity index 68%
copy from t/tests/files-flash-non-free/debian/debian/control.in
copy to t/tests/copyright-file-symlink/debian/debian/control.in
index b531357..3997898 100644
--- a/t/tests/files-flash-non-free/debian/debian/control.in
+++ b/t/tests/copyright-file-symlink/debian/debian/control.in
@@ -3,26 +3,26 @@ Priority: extra
Section: {$section}
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (= 7)
-Homepage: http://lintian.debian.org/
+Build-Depends: debhelper (= 7.0.50~)
-Package: {$srcpkg}
+Package: symlink-to-foreign
Architecture: {$architecture}
-Depends: $\{misc:Depends\}
-Description: {$description}
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, foreign-package
+Description: {$description} (foreign)
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+ .
+ Foreign
-Package: {$srcpkg}-non-free
-Section: non-free/{$section}
+Package: symlink-outside-usd
Architecture: {$architecture}
-Depends: $\{misc:Depends\}
-Description: {$description} (okay)
- non-free in non-free, nice.
- .
+Depends: $\{shlibs:Depends\}, $\{misc:Depends\}
+Description: {$description} (usd)
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
things. It should not be installed like a regular package. It may
be an empty package.
+ .
+ USD
diff --git a/t/tests/copyright-file-symlink/debian/debian/rules
b/t/tests/copyright-file-symlink/debian/debian/rules
new file mode 100644
index 000..37b7cf6
--- /dev/null
+++ b/t/tests/copyright-file-symlink/debian/debian/rules
@@ -0,0 +1,19 @@
+#!/usr/bin/make -f
+
+USD:=usr/share/doc
+%:
+ dh $@
+
+
+override_dh_md5sums:
+ rm -fr debian/symlink-to-foreign/$(USD)/symlink-to-foreign
+ ln -sf foreign-package \
+ debian/symlink-to-foreign/$(USD)/symlink-to-foreign
+ # Move all of it to usr/lib/package/
+ mkdir -p debian/symlink-outside-usd/usr/lib/
+ mv debian/symlink-outside-usd/$(USD)/symlink-outside-usd \
+ debian/symlink-outside-usd/usr/lib/symlink-outside-usd/
+ # with symlink of course :)
+ ln -s ../../lib/symlink-outside-usd/copyright \
+ debian/symlink-outside-usd/$(USD)/symlink-outside-usd
+ dh_md5sums
diff --git a/t/tests/copyright-file-symlink/desc
b/t/tests/copyright-file-symlink/desc
new file mode 100644
index 000..3fc7062
--- /dev/null
+++ b/t/tests/copyright-file-symlink/desc
@@ -0,0 +1,7 @@
+Testname: copyright-file-symlink
+Sequence: 6000
+Version: 1.0
+Description: Test for symlinked copyright files
+Test-For:
+ usr-share-doc-symlink-points-outside-of-usr-share-doc
+ usr-share-doc-symlink-to-foreign-package
diff --git a/t/tests/copyright-file-symlink/tags
b/t/tests/copyright-file-symlink/tags
new file mode 100644
index 000..5c6372a
--- /dev/null
+++ b/t/tests/copyright-file-symlink/tags
@@ -0,0 +1,2 @@
+E: symlink-outside-usd: usr-share-doc-symlink-points-outside-of-usr-share-doc
../../lib/symlink-outside-usd/copyright
+E: symlink-to-foreign: usr-share-doc-symlink-to-foreign-package foreign-package
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1pxsmk-0004mt...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-75-gad4876b
The following commit has been merged in the master branch: commit ad4876b3c9c511ffad9bf3354955c38f6828e9d7 Author: Niels Thykier ni...@thykier.net Date: Wed Dec 29 17:27:22 2010 +0100 Added (more) misspellings of developer and development. See #608276 diff --git a/data/spelling/corrections b/data/spelling/corrections index 4b3cb4b..989511d 100644 --- a/data/spelling/corrections +++ b/data/spelling/corrections @@ -188,6 +188,8 @@ desactivate||deactivate detabase||database developement||development developped||developed +developpement||development +developper||developer deveolpment||development devided||divided dictionnary||dictionary -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxyuj-0006qe...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-76-g4b114ab
The following commit has been merged in the master branch: commit 4b114abbb5cce9d7f17ec2d448443e99816b63a0 Author: Niels Thykier ni...@thykier.net Date: Wed Dec 29 17:45:42 2010 +0100 libX-gcj also belong in the java section. diff --git a/checks/fields b/checks/fields index e1f2043..09d8a6f 100644 --- a/checks/fields +++ b/checks/fields @@ -131,7 +131,7 @@ my @NAME_SECTION_MAPPINGS = ( [ qr/^r-cran-/ = 'gnu-r'], [ qr/^lib.*-perl$/ = 'perl' ], [ qr/^lib.*-cil$/ = 'cli-mono' ], -[ qr/^lib.*-java$/ = 'java' ], +[ qr/^lib.*-(?:java|gcj)$/ = 'java' ], [ qr/^(?:lib)php-/ = 'php' ], [ qr/^lib(?:hugs|ghc6)-/ = 'haskell' ], [ qr/^lib.*-ruby(?:1\.\d)?$/ = 'ruby' ], -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1pxzbw-0002u8...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.4.3-78-gbdf93c8
The following commit has been merged in the master branch:
commit 0c69de90bb8f37774e9c35a418b76080804d0157
Author: Niels Thykier ni...@thykier.net
Date: Wed Dec 29 19:08:10 2010 +0100
Add check for needless dependency on JRE/JDK for java libraries.
* Summary of tag changes:
+ Added:
- needless-dependency-on-jre
* checks/fields{,.desc}:
+ [NT] Added needless-dependency-on-jre tag.
diff --git a/checks/fields b/checks/fields
index 09d8a6f..0730725 100644
--- a/checks/fields
+++ b/checks/fields
@@ -123,6 +123,15 @@ our %known_tkxs = map { $_ = 1 }
our %known_libpngs = map { $_ = 1 }
( 'libpng12-0', 'libpng2', 'libpng3', );
+our @known_java_pkg = map { qr/$_/ }
+('default-jre(?:-headless)?', 'default-jdk', # default java
+ 'java\d*-runtime(?:-headless)?', # java-runtime and javaX-runtime
alternatives (virtual)
+ '(openjdk-|sun-java)\d+-jre(?:-headless)?', '(openjdk-|sun-java)\d+-jdk',
# openjdk-X and sun-javaX
+ 'gcj-(?:\d+\.\d+-)?jre(?:-headless)?', 'gcj-(?:\d+\.\d+-)?jdk', # gcj
+ 'gij', 'java-compat(?:-dev|-headless)?', # deprecated/transitional
packages
+ 'kaffe', 'cacao', 'jamvm', 'classpath', # deprecated packages (removed in
Squeeze)
+);
+
# Mapping of package names to section names
my @NAME_SECTION_MAPPINGS = (
[ qr/-docs?$/ = 'doc' ],
@@ -518,10 +527,13 @@ if ($type eq 'binary') {
}
if (($type eq binary) || ($type eq 'udeb')) {
my (%deps, %fields, %parsed);
+ my $javalib = 0;
+ $javalib = 1 if($pkg =~ m/^lib.*-(?:java|gcj)$/o);
for my $field (qw(depends pre-depends recommends suggests conflicts
provides enhances replaces breaks)) {
next unless defined $info-field($field);
#Get data and clean it
my $data = $info-field($field);;
+ my $javadep = 0;
unfold($field, \$data);
$fields{$field} = $data;
@@ -645,6 +657,17 @@ if (($type eq binary) || ($type eq 'udeb')) {
tag depends-on-specific-java-doc-package,
$field
if($is_dep_field($field) $pkg ne
'default-jdk-doc'
($d_pkg eq 'classpath-doc' || $d_pkg
=~ m/openjdk-\d+-doc/o));
+
+
+ if($javalib $field eq 'depends'){
+ foreach my $reg (@known_java_pkg){
+ if($d_pkg =~ m/$reg/){
+ $javadep++;
+ last;
+ }
+
+ }
+ }
}
for my $pkg (@seen_obsolete_packages) {
@@ -655,6 +678,11 @@ if (($type eq binary) || ($type eq 'udeb')) {
tag ored-depends-on-obsolete-package,
$field: $pkg;
}
}
+
+ # Only emit the tag if all the alternatives are
JVM/JRE/JDKs
+ # - assume that some-lib | openjdk-6-jre-headless
makes sense for now.
+ tag needless-dependency-on-jre
+ if (scalar(@alternatives) == $javadep);
}
tag package-depends-on-multiple-libstdc-versions,
@seen_libstdcs
if (scalar @seen_libstdcs 1);
diff --git a/checks/fields.desc b/checks/fields.desc
index 672b9d2..ce6b9b3 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1007,3 +1007,15 @@ Info: The package should use default-jdk-doc instead of
classpath-doc
or openjdk-X-doc to ease transitions when the providing doc package
is replaced (e.g. openjdk-6-doc being replaced by openjdk-7-doc).
+Tag: needless-dependency-on-jre
+Severity: normal
+Certainty: possible
+Info: The package appear to be a Java library and depending on one
+ or more JRE/JDK packages. As of 05 Apr 2010, the Java Policy no
+ longer mandates that Java libraries depend on Java Runtimes.
+ .
+ If there is a valid reason for this dependency, please override
+ the tag.
+Ref: http://packages.qa.debian.org/j/java-common/news/20100405T221415Z.html,
+ http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=227587
+
diff --git a/debian/changelog b/debian/changelog
index 3bfd7b6..c73136d 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -6,6 +6,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
- depends-on-specific-java-doc-package
- unneeded-build-dep-on-quilt
- description-synopsis-starts-with-article
+ - needless-dependency-on-jre
* checks/*:
+ [NT] Use the new pre-sorted file {index,info} when iterating over files.
@@ -30,6 +31,7 @@ lintian (2.4.4) UNRELEASED; urgency=low
classpath-doc instead of the default-jdk-doc metapackage.
(Closes: #593837)
+ [NT] Fixed spelling
[SCM] Debian package checker branch, master, updated. 2.4.3-78-gbdf93c8
The following commit has been merged in the master branch: commit bdf93c8db99fadad852964a456bd817aba9feac9 Author: Niels Thykier ni...@thykier.net Date: Wed Dec 29 19:11:06 2010 +0100 Updated changelog to reflect changes made by commit ad4876b. * data/spelling/corrections: + [NT] Added more corrections. diff --git a/debian/changelog b/debian/changelog index c73136d..38a0922 100755 --- a/debian/changelog +++ b/debian/changelog @@ -65,6 +65,8 @@ lintian (2.4.4) UNRELEASED; urgency=low * data/fields/obsolete-packages: + [NT] Added default-jdk-builddep. See README.gcj-native-transition in java-common for the replacement. + * data/spelling/corrections: ++ [NT] Added more corrections. * debian/control: + [RA] Add the build dependencies required to run the test suite -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1py0xb-000231...@alioth.debian.org
