Re: Added autopkgtests for openslide
On Tue, May 24, 2022 at 12:36:36AM +0530, Mohd Bilal wrote: > I've updated the copyright as suggested. Uploaded. -- Best, Nilesh signature.asc Description: PGP signature
Re: Added autopkgtests for openslide
On 5/24/22 00:31, Nilesh Patra wrote: [ CCing list again ] On Tue, May 24, 2022 at 12:26:54AM +0530, Mohd Bilal wrote: On 5/24/22 00:17, Nilesh Patra wrote: On Tue, May 24, 2022 at 12:01:22AM +0530, Mohd Bilal wrote: I've added autopkgtests for openslide[1]. Requesting someone to review and sponsor my changes. Looks good, but have you created the image on your own - as you added yourself as copyr holder[2]? No I used the image from link[4]. It doesn't explicitly state any copyright holders name. That's why I added my name. That is not correct - don't add your/someone's names for data that hasn't been created/distributed by you/them. Noted and thanks Since its from the same upstream website, Shall I change the copyright name to that of the upstream (which is Carnegie Mellon University) ? Yes I've updated the copyright as suggested. If not so, please add the correct copyright holder, and also a get-test-data script[3] so it is easy for us to fetch the data going fwd. I've already added a get-test-data script[5] Must've been an oversight, my bad. [1] - https://salsa.debian.org/med-team/openslide [2]: https://salsa.debian.org/med-team/openslide/-/commit/402a1b0f84734b629b65570c042151333ed07e06#adb7f75f79e3bb85eb62912a2904c5d24af878fb_62_64 [3]: https://salsa.debian.org/med-team/multiqc/-/blob/master/debian/tests/get-test-data [4] - https://openslide.cs.cmu.edu/download/openslide-testdata/Aperio/ [5] - https://salsa.debian.org/med-team/openslide/-/blob/master/debian/tests/get-test-data -- ╭╮ │ Mohammed Bilal │ │ 2D65 BC1E B966 5A6E 97F9 730A B3F5 9452 8521 9E1F │ ╰╯ OpenPGP_0xB3F5945285219E1F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: Added autopkgtests for openslide
[ CCing list again ] On Tue, May 24, 2022 at 12:26:54AM +0530, Mohd Bilal wrote: > On 5/24/22 00:17, Nilesh Patra wrote: > > On Tue, May 24, 2022 at 12:01:22AM +0530, Mohd Bilal wrote: > > > I've added autopkgtests for openslide[1]. Requesting someone to review and > > > sponsor my changes. > > > > Looks good, but have you created the image on your own - as you added > > yourself as copyr holder[2]? > > > No I used the image from link[4]. It doesn't explicitly state any copyright > holders name. That's why I added my name. That is not correct - don't add your/someone's names for data that hasn't been created/distributed by you/them. > Since its from the same upstream > website, Shall I change the copyright name to that of the upstream (which is > Carnegie Mellon University) ? Yes > > If not so, please add the correct copyright holder, and also a > > get-test-data script[3] > > so it is easy for us to fetch the data going fwd. > > > > I've already added a get-test-data script[5] Must've been an oversight, my bad. > > > [1] - https://salsa.debian.org/med-team/openslide > > [2]: > > https://salsa.debian.org/med-team/openslide/-/commit/402a1b0f84734b629b65570c042151333ed07e06#adb7f75f79e3bb85eb62912a2904c5d24af878fb_62_64 > > [3]: > > https://salsa.debian.org/med-team/multiqc/-/blob/master/debian/tests/get-test-data > > > > [4] - https://openslide.cs.cmu.edu/download/openslide-testdata/Aperio/ > [5] - > https://salsa.debian.org/med-team/openslide/-/blob/master/debian/tests/get-test-data -- Best, Nilesh signature.asc Description: PGP signature
Re: Added autopkgtests for openslide
Hi and thanks for this On Tue, May 24, 2022 at 12:01:22AM +0530, Mohd Bilal wrote: > I've added autopkgtests for openslide[1]. Requesting someone to review and > sponsor my changes. Looks good, but have you created the image on your own - as you added yourself as copyr holder[2]? If not so, please add the correct copyright holder, and also a get-test-data script[3] so it is easy for us to fetch the data going fwd. > [1] - https://salsa.debian.org/med-team/openslide [2]: https://salsa.debian.org/med-team/openslide/-/commit/402a1b0f84734b629b65570c042151333ed07e06#adb7f75f79e3bb85eb62912a2904c5d24af878fb_62_64 [3]: https://salsa.debian.org/med-team/multiqc/-/blob/master/debian/tests/get-test-data -- Best, Nilesh signature.asc Description: PGP signature
