Re: salmon status in salsa
Am Sat, Nov 05, 2022 at 11:09:09PM +0100 schrieb Étienne Mollier: > > Further inspection of the backtrace shows the linker was > confused between the embedded and system version of libcereal. > Everything goes back to normal when the libcereal copy embedded > in pufferfish embedded in salmon is deleted (one more reason to > avoid vendoring). > > On upstream code, this situation can occur when their external/ > directory is not properly cleaned up and there is a system > libcereal installed in the meantime. Not sure what to do about > this, this looks like quite the corner case to make some noise > about it. Another $DRINK for this one. ;-) Thanks a lot Andreas. -- http://fam-tille.de
Re: salmon status in salsa
Andreas Tille, on 2022-11-05: > Am Sat, Nov 05, 2022 at 05:36:16PM +0100 schrieb Étienne Mollier: > > So I have been spending some time to try to put salmon back in > > working shape. The code currently available in Salsa[1] builds > > through, but fails it's test suite. Said test is fortunately > > straightforward to run, and from further analysis with the > > debugger and test rebuilds with the pristine upstream source > > code, I believe I isolated that the root cause of the test > > failure is that salmon crashes with a segmentation fault when > > built against libcereal 1.3.2, while it works properly when > > built against libcereal 1.3.0, which is the version vendored by > > upstream if a local copy is not available. > > Thanks a lot for this detailed analysis. As a quick (hopefully > temporary) solution I could imagine to keep the code copy of libcereal > for the moment. At the same time it makes sense to inform salmon > upstream. Further inspection of the backtrace shows the linker was confused between the embedded and system version of libcereal. Everything goes back to normal when the libcereal copy embedded in pufferfish embedded in salmon is deleted (one more reason to avoid vendoring). On upstream code, this situation can occur when their external/ directory is not properly cleaned up and there is a system libcereal installed in the meantime. Not sure what to do about this, this looks like quite the corner case to make some noise about it. > > [1]: https://salsa.debian.org/med-team/salmon Have a good night, :) -- Étienne Mollier Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/2, please excuse my verbosity. On air: Lanfear - Traces Of Infinity signature.asc Description: PGP signature
Re: salmon status in salsa
Hi Étienne, Am Sat, Nov 05, 2022 at 05:36:16PM +0100 schrieb Étienne Mollier: > So I have been spending some time to try to put salmon back in > working shape. The code currently available in Salsa[1] builds > through, but fails it's test suite. Said test is fortunately > straightforward to run, and from further analysis with the > debugger and test rebuilds with the pristine upstream source > code, I believe I isolated that the root cause of the test > failure is that salmon crashes with a segmentation fault when > built against libcereal 1.3.2, while it works properly when > built against libcereal 1.3.0, which is the version vendored by > upstream if a local copy is not available. Thanks a lot for this detailed analysis. As a quick (hopefully temporary) solution I could imagine to keep the code copy of libcereal for the moment. At the same time it makes sense to inform salmon upstream. Thanks again Andreas. > [1]: https://salsa.debian.org/med-team/salmon -- http://fam-tille.de
Re: Salmon
Am Samstag, den 16.12.2017, 10:28 +0100 schrieb Andreas Tille: > Hi Gert, > > I once injected version 0.8.0 where I ended up with > > /usr/bin/cc -g -O2 -fdebug-prefix-map=/build/salmon-0.8.0+ds1=. > -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time > -D_FORTIFY_SOURCE=2 -DCHECK_FUNCTION_EXISTS=pthread_ > create -Wl,-z,relro -Wl,- > z,now CMakeFiles/cmTC_de0fb.dir/CheckFunctionExists.c.o -o > cmTC_de0fb -rdynamic -lpthreads > /usr/bin/ld: cannot find -lpthreads > collect2: error: ld returned 1 exit status > > > I assume that would be easy to fix but got not help so far. I found > some hint in the web to add > > find_package(Threads) > > but I either did it on the wrong place or it does not help. The problem is, I didn't even get that far, as I pointes out, a file was missing to compile the whole thing. I'll try to give it another shot by first compiling the origial version to see if I get it to work at all, end then re-applying the patches. Best, Gert
Re: Salmon
Hi Gert, On Wed, Dec 13, 2017 at 11:44:18AM +0100, Gert Wollny wrote: > since in the build-tree there is also a version 0.8, and I had to give > up fixing that version - there was some include "FrugalBooMap.hpp" > missing, I've fixed the RC bug in an new branch: "version-7.2". At first thanks a lot for fixing this. I once injected version 0.8.0 where I ended up with /usr/bin/cc -g -O2 -fdebug-prefix-map=/build/salmon-0.8.0+ds1=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -DCHECK_FUNCTION_EXISTS=pthread_ create -Wl,-z,relro -Wl,-z,now CMakeFiles/cmTC_de0fb.dir/CheckFunctionExists.c.o -o cmTC_de0fb -rdynamic -lpthreads /usr/bin/ld: cannot find -lpthreads collect2: error: ld returned 1 exit status I assume that would be easy to fix but got not help so far. I found some hint in the web to add find_package(Threads) but I either did it on the wrong place or it does not help. I'd love if we could at least upload this version which is currently also superseeded by version 0.9.1. It would be even better but after I gave it a try and tried to fight through the hell of patches I gave up since I did not even managed to get the cmake configure step successful. Do you have any idea how to fix the pthreads issue and then we could apply your patch to 0.8.0 (if needed)? Kind regards Andreas. -- http://fam-tille.de
